[GitHub] [pulsar] tuteng commented on issue #5493: [website] Broken links to some download packages
tuteng commented on issue #5493: [website] Broken links to some download packages URL: https://github.com/apache/pulsar/issues/5493#issuecomment-547778251 I think this css file https://github.com/cckellogg/incubator-pulsar/blob/26d7dfbc651353f91eea4ecf0400685c331eaf5c/site2/website/static/css/code-blocks-buttons.css can be added, but some download links I tested are normal. https://archive.apache.org/dist/incubator/pulsar/pulsar-1.20.0-incubating/apache-pulsar-1.20.0-incubating-src.tar.gz https://archive.apache.org/dist/incubator/pulsar/pulsar-1.19.0-incubating/apache-pulsar-1.19.0-incubating-src.tar.gz But some file names are wrong, I think you can try to fix it.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] youurayy commented on issue #4941: Unable to delete topic when both consumer (subscription) and reader has been connected
youurayy commented on issue #4941: Unable to delete topic when both consumer (subscription) and reader has been connected URL: https://github.com/apache/pulsar/issues/4941#issuecomment-547789761 may be related - cannot unsubscribe (delete a subscription) via the admin tool:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] youurayy edited a comment on issue #4941: Unable to delete topic when both consumer (subscription) and reader has been connected
youurayy edited a comment on issue #4941: Unable to delete topic when both consumer (subscription) and reader has been connected URL: https://github.com/apache/pulsar/issues/4941#issuecomment-547789761 may be related - cannot unsubscribe (delete a subscription) via the admin tool:  (i had both a reader and consumers there as well) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5493: [website] Broken links to some download packages
Jennifer88huang commented on issue #5493: [website] Broken links to some download packages URL: https://github.com/apache/pulsar/issues/5493#issuecomment-547793845 Yes, when you click https://archive.apache.org/dist/incubator/pulsar/pulsar-1.19.0-incubating/apache-pulsar-1.19.0-incubating-src.tar.gz, it works; however, when you click `sha512` under that package, it does not work. The `asc` links work well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy merged pull request #5378: Trim messages which less than mark delete position for message redelivery
wolfstudy merged pull request #5378: Trim messages which less than mark delete position for message redelivery URL: https://github.com/apache/pulsar/pull/5378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy closed issue #5377: Old message continue redeliver after clear backlog.
wolfstudy closed issue #5377: Old message continue redeliver after clear backlog. URL: https://github.com/apache/pulsar/issues/5377 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (96f14d2 -> b11211f)
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 96f14d2 fix misspelling and adjust code style (#5497) add b11211f Trim messages which less than mark delete position for message redelivery (#5378) No new revisions were added by this update. Summary of changes: .../service/persistent/PersistentSubscription.java | 13 --- .../pulsar/client/impl/MessageRedeliveryTest.java | 41 ++ 2 files changed, 50 insertions(+), 4 deletions(-)
[GitHub] [pulsar] skyrocknroll commented on issue #5386: Update presto to 0.226
skyrocknroll commented on issue #5386: Update presto to 0.226 URL: https://github.com/apache/pulsar/pull/5386#issuecomment-547806965 rerun integration tests rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] youurayy commented on issue #4941: Unable to delete topic when both consumer (subscription) and reader has been connected
youurayy commented on issue #4941: Unable to delete topic when both consumer
(subscription) and reader has been connected
URL: https://github.com/apache/pulsar/issues/4941#issuecomment-547806673
I can confirm this is an issue: once a Reader as been seen on a topic, it
is not possible to delete any Consumer subscription.
This is a **massive** issue because it means that we basically cannot use
Readers and Consumers combined on a topic, because we will never be able to
clean that topic and it will be amassing data forever (until quotas are hit).
Here's minimal replication case:
1. subscribe with a Consumer, then stop the Consumer
2. delete the subscription with admin tool -- this will work
`bin/pulsar-admin topics unsubscribe public/test-seqid/topic-3 -s
failover-subscription`
3. subscribe with a Reader, then stop the Reader
4. subscribe with a Consumer, then stop the Consumer
5. delete the subscription with admin tool -- this will **NOT** work
(timeout)
`bin/pulsar-admin topics unsubscribe public/test-seqid/topic-3 -s
failover-subscription`
Client code:
```java
pulsar =
PulsarClient.builder()
.serviceUrl(pulsarUrl)
.connectionsPerBroker(1) // default: 1
.connectionTimeout(10, TimeUnit.SECONDS)
.enableTcpNoDelay(true)
.keepAliveInterval(999, TimeUnit.DAYS)
.maxBackoffInterval(5, TimeUnit.SECONDS)
.startingBackoffInterval(1, TimeUnit.SECONDS)
.statsInterval(60, TimeUnit.SECONDS)
.ioThreads(1) // default: 1
.listenerThreads(1) // default: 1
.maxConcurrentLookupRequests(5000) // default: 5000
.maxLookupRequests(5) // default: 5
.maxNumberOfRejectedRequestPerConnection(50) // default: 50
.operationTimeout(30, TimeUnit.SECONDS) // default: 30 sec
.build();
```
Consumer code:
```java
Consumer consumer = pulsar
.newConsumer(Schema.PROTOBUF(Test.class))
.consumerName("consumer1")
.subscriptionInitialPosition(SubscriptionInitialPosition.Latest)
.subscriptionType(SubscriptionType.Failover)
.subscriptionName("failover-subscription")
.topic("persistent://public/test-seqid/topic-3")
.subscribe();
while (true) {
Message message = consumer.receive();
...
```
Reader code:
```java
Reader reader = pulsar
.newReader(Schema.PROTOBUF(Test.class))
.readerName("reader1")
.topic("persistent://public/test-seqid/topic-3")
.startMessageId(MessageId.earliest)
.create();
while (true) {
Message message = reader.readNext();
...
```
(Another separate(?) issue is why the Reader is seeing any previously
published data, when retentions on the namespace are zero (both time and size),
and all messages were acknowledged. This is confusing.)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] youurayy removed a comment on issue #4941: Unable to delete topic when both consumer (subscription) and reader has been connected
youurayy removed a comment on issue #4941: Unable to delete topic when both consumer (subscription) and reader has been connected URL: https://github.com/apache/pulsar/issues/4941#issuecomment-547789761 may be related - cannot unsubscribe (delete a subscription) via the admin tool:  (i had both a reader and consumers there as well) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] youurayy edited a comment on issue #4941: Unable to delete topic when both consumer (subscription) and reader has been connected
youurayy edited a comment on issue #4941: Unable to delete topic when both
consumer (subscription) and reader has been connected
URL: https://github.com/apache/pulsar/issues/4941#issuecomment-547806673
I can confirm this is an issue: once a Reader as been seen on a topic, it
is not possible to delete any Consumer subscription.
This is a **massive** issue because it means that we basically cannot use
Readers and Consumers combined on a topic, because we will never be able to
clean that topic and it will be amassing data forever (until quotas are hit).
Here's minimal replication case:
- this is a 4 broker Pulsar cluster (in Kubernetes)
- accessed via proxied pulsar:// protocol (via the Pulsar Proxy)
1. subscribe with a Consumer, then stop the Consumer
2. delete the subscription with admin tool -- this will work
`bin/pulsar-admin topics unsubscribe public/test-seqid/topic-3 -s
failover-subscription`
3. subscribe with a Reader, then stop the Reader
4. subscribe with a Consumer, then stop the Consumer
5. delete the subscription with admin tool -- this will **NOT** work
(timeout)
`bin/pulsar-admin topics unsubscribe public/test-seqid/topic-3 -s
failover-subscription`
Client code:
```java
pulsar =
PulsarClient.builder()
.serviceUrl(pulsarUrl)
.connectionsPerBroker(1) // default: 1
.connectionTimeout(10, TimeUnit.SECONDS)
.enableTcpNoDelay(true)
.keepAliveInterval(999, TimeUnit.DAYS)
.maxBackoffInterval(5, TimeUnit.SECONDS)
.startingBackoffInterval(1, TimeUnit.SECONDS)
.statsInterval(60, TimeUnit.SECONDS)
.ioThreads(1) // default: 1
.listenerThreads(1) // default: 1
.maxConcurrentLookupRequests(5000) // default: 5000
.maxLookupRequests(5) // default: 5
.maxNumberOfRejectedRequestPerConnection(50) // default: 50
.operationTimeout(30, TimeUnit.SECONDS) // default: 30 sec
.build();
```
Consumer code:
```java
Consumer consumer = pulsar
.newConsumer(Schema.PROTOBUF(Test.class))
.consumerName("consumer1")
.subscriptionInitialPosition(SubscriptionInitialPosition.Latest)
.subscriptionType(SubscriptionType.Failover)
.subscriptionName("failover-subscription")
.topic("persistent://public/test-seqid/topic-3")
.subscribe();
while (true) {
Message message = consumer.receive();
...
```
Reader code:
```java
Reader reader = pulsar
.newReader(Schema.PROTOBUF(Test.class))
.readerName("reader1")
.topic("persistent://public/test-seqid/topic-3")
.startMessageId(MessageId.earliest)
.create();
while (true) {
Message message = reader.readNext();
...
```
(Another separate(?) issue is why the Reader is seeing any previously
published data, when retentions on the namespace are zero (both time and size),
and all messages were acknowledged. This is confusing.)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] skyrocknroll commented on issue #5386: Update presto to 0.226
skyrocknroll commented on issue #5386: Update presto to 0.226 URL: https://github.com/apache/pulsar/pull/5386#issuecomment-547811831 rerun cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng opened a new pull request #5501: [Doc]Fix broke link
tuteng opened a new pull request #5501: [Doc]Fix broke link URL: https://github.com/apache/pulsar/pull/5501 Fixes https://github.com/apache/pulsar/issues/5493 Master Issue: https://github.com/apache/pulsar/issues/5493 ### Motivation Currently, due to the change of file name, the old version of the document cannot be connected to the document, resulting in a large number of 404 ### Modifications * Fix broken links and maintain compatibility with old versions. ### Verifying this change run command yarn build Warnings that begin with the following do not appear ``` [WARN] unresolved links in file ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5496: [Doc]Fix document link error
tuteng commented on issue #5496: [Doc]Fix document link error URL: https://github.com/apache/pulsar/pull/5496#issuecomment-547813437 run integrations tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5496: [Doc]Fix document link error
tuteng commented on issue #5496: [Doc]Fix document link error URL: https://github.com/apache/pulsar/pull/5496#issuecomment-547813698 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zymap opened a new pull request #5502: Fix list non-persistent topics shows the persistent topics
zymap opened a new pull request #5502: Fix list non-persistent topics shows the persistent topics URL: https://github.com/apache/pulsar/pull/5502 --- Fixes #5414 *Motivation* When using the REST API to request to list all the non-persistent topics, it will show the persistent topics. *Modifications* - Add a filter when before sending the response This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar.wiki] branch master updated: Updated Home (markdown)
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new 31a1999 Updated Home (markdown) 31a1999 is described below commit 31a199961191d6763964700db42af23d41a4e19b Author: Sijie Guo AuthorDate: Wed Oct 30 17:47:19 2019 +0800 Updated Home (markdown) --- Home.md | 1 + 1 file changed, 1 insertion(+) diff --git a/Home.md b/Home.md index c8f01d3..2af8f1f 100644 --- a/Home.md +++ b/Home.md @@ -7,6 +7,7 @@ We encourage to document any big change or feature or any addition to public use ### Proposed +* [[PIP 48: hierarchical admin api]] * [[PIP 47: Time Based Release Plan]] * [[PIP 46: Next-gen Proxy]] * [[PIP 45: Pluggable metadata interface]]
[pulsar.wiki] branch master updated: Updated PIP 48: hierarchical admin api (markdown)
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new 9b765df Updated PIP 48: hierarchical admin api (markdown) 9b765df is described below commit 9b765df61199288f2e4af05d5079d697d003cffa Author: Sijie Guo AuthorDate: Wed Oct 30 17:49:21 2019 +0800 Updated PIP 48: hierarchical admin api (markdown) --- PIP-48:-hierarchical-admin-api.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/PIP-48:-hierarchical-admin-api.md b/PIP-48:-hierarchical-admin-api.md index 2f5558e..75d559c 100644 --- a/PIP-48:-hierarchical-admin-api.md +++ b/PIP-48:-hierarchical-admin-api.md @@ -1,5 +1,3 @@ -# PIP 47: hierarchical admin api - - Status: Draft - Author: [Florentin Dubois](https://github.com/FlorentinDUBOIS) ([@FlorentinDUBOIS](https://twitter.com/FlorentinDUBOIS)), [Steven Le Roux](https://github.com/StevenLeRoux) ([@GwinizDu](https://twitter.com/GwinizDu)) - Pull request:
[pulsar.wiki] branch master updated: Created PIP 48: hierarchical admin api (markdown)
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new aefc584 Created PIP 48: hierarchical admin api (markdown) aefc584 is described below commit aefc5841dad3aa2fe7529b10e4ab454b306df837 Author: Sijie Guo AuthorDate: Wed Oct 30 17:49:04 2019 +0800 Created PIP 48: hierarchical admin api (markdown) --- PIP-48:-hierarchical-admin-api.md | 96 +++ 1 file changed, 96 insertions(+) diff --git a/PIP-48:-hierarchical-admin-api.md b/PIP-48:-hierarchical-admin-api.md new file mode 100644 index 000..2f5558e --- /dev/null +++ b/PIP-48:-hierarchical-admin-api.md @@ -0,0 +1,96 @@ +# PIP 47: hierarchical admin api + +- Status: Draft +- Author: [Florentin Dubois](https://github.com/FlorentinDUBOIS) ([@FlorentinDUBOIS](https://twitter.com/FlorentinDUBOIS)), [Steven Le Roux](https://github.com/StevenLeRoux) ([@GwinizDu](https://twitter.com/GwinizDu)) +- Pull request: +- Mailing list discussion: +- Release: + +## Motivation + +The current pulsar admin APIs (v2,v3) inherits the historical structure, managing entities as prefix to the api's route path in a flat fashion. +Also, Pulsar evoled to the ability to manage multiple clusters. + +For example to administrate a namespace, we used the following route `v2/namespaces/:tenant-id/:namespace-id`. +This could be confusing, because we intend to manipulate a namespace under a tenant scope, which still requires here to give the tenant identifier in addition of the namespace identifier. + +This proposal aims to +- offer a more hierarchical routing approach reflecting the Pulsar semantic +- proposes to officially name an ensemble of Pulsar cluster : a `Constellation` +- to simplify the user experience for : + - Topic management between persistent and non-persistent. + - cluster management inside a Pulsar Constellation + + +## Current admin api + +Currently, we have the following admin api to control pulsar deployments. + +> Scope is on what the api deals with to execute the asked action. + +| path | description| scope | +| | -- | | +| `v2/functions` | manage pulsar functions| tenant, namespace, function | +| `v2/clusters`| manage clusters| cluster | +| `v2/resource-quotas` | manage quota on resource | tenant, namespace| +| `v2/tenants` | manage tenants | tenant | +| `v2/namespaces` | manage namespaces | tenant, namespace| +| `v2/non-persistent` | manage non-persistent topic| tenant, namespace, topic | +| `v2/persistent` | manage persistent topic| tenant, namespace, topic | +| `v2/schemas` | manage schema on registry | tenant, namespace, topic, schema | +| `v2/brokers` | manage brokers | cluster, broker | +| `v2/broker-stats`| retrieve broker statistics | cluster, broker | +| `v2/worker` | manage worker | cluster, worker | +| `v2/worker-stats`| retrieve worker statistics | cluster, worker | +| `v2/bookies` | retrieve bookies information | cluster, bookie | +| `v3/sink`| manage pulsar-io sink connectors | tenant, namespace, connector | +| `v3/sinks` | manage pulsar-io sink connectors | tenant, namespace, connector | +| `v3/source` | manage pulsar-io source connectors | tenant, namespace, connector | +| `v3/sources` | manage pulsar-io source connectors | tenant, namespace, connector | + +## Proposed changes + +We would like to propose new `v4` admin api which will have two level of reading. + +The first one is the `broker-level` which means all information linked to the pulsar broker's instance. The second one is the `constellation-level` which means the administration of multiple pulsar's cluster instances. + +> The "constellation" word is used to differentiate a pulsar's cluster instance and the management of multiple pulsar's cluster instances. + +### Broker + +The api at `broker` level will expose information of the broker, this aims to enhance the observability and operational tasks around the pulsar's broker. + +| path | description | scope | +| -- | | -- | +| `v4/metrics` | broker metrics (both b
[pulsar.wiki] branch master updated: Add PIP-49: Permission levels and inheritance for project
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new e4f2606 Add PIP-49: Permission levels and inheritance for project e4f2606 is described below commit e4f2606153cfdd2fdeb88cb16e9239d5613c921d Author: 冉小龙 AuthorDate: Wed Oct 30 18:06:27 2019 +0800 Add PIP-49: Permission levels and inheritance for project --- PIP-49:-Permission-levels-and-inheritance.md | 283 +++ 1 file changed, 283 insertions(+) diff --git a/PIP-49:-Permission-levels-and-inheritance.md b/PIP-49:-Permission-levels-and-inheritance.md new file mode 100644 index 000..f08fd73 --- /dev/null +++ b/PIP-49:-Permission-levels-and-inheritance.md @@ -0,0 +1,283 @@ +# PIP 49: Permission levels and inheritance + +- Status: Draft +- Author: Xiaolong Ran +- Pull request: +- Mailing list discussion: +- Release: + +## Motivation + +Lacking permission levels and inheritance causing the permission check in Pulsar become very confused. + +For example, currently Pulsar only allows a tenant administrator to retrieve the list of topics of a namespace. However, if you are a namespace administrator, you are not allowed to list the topics of it. This behavior is strange and uncommon compared to other RBAC systems. + +Also superuser permissions are misused in many places without clear thoughts. + +This PIP proposes introducing permission levels and inheritance into Pulsar authorization system to make permission check clearer across Pulsar codebase. + +## Permission levels & inheritance + +This PIP proposes adding permission level for each role. The permission level is determined by a number. The lower number gets higher permission. The role with higher level permission will inherit all the permissions from lower level roles. The roles at the same permission level can’t inherit the permissions from others. + + +The following table illustrates all the roles in Pulsar and their permission levels. + + +| Role| Permission Level +|---|--- +| Super user| 1 +| Tenant admin | 2 +| Namespace admin | 3 +| Namespace function | 4 | +| Namespace produce | 4 | +| Namespace consume | 4 | + +> Note: The `Namespace function`, `Namespace produce` and `Namespace consume` are at the same permission level. They can’t inherit the permissions from each other. +## Proposed Permission Changes + + +This PIP proposes the following permission changes for each admin API. + +### tenants + +Command |Current Permissions | Proposed Permissions +|---|--- +get | super-user | >= tenant admin +create | super-user | super user +update | super-user | super user +delete | super-user | super user +list | super-user | super user + +### schemas + +Command |Current Permissions | Proposed Permissions +|---|--- +get | tenant admin | >= namespace produce +upload | tenant admin | >= namespace produce +extract | tenant admin | >= namespace produce +delete | tenant admin | >= namespace produce + + +### functions + +Command |Current Permissions | Proposed Permissions +|---|--- +localrun | none | none +create | super-user or tenant admin or namespace function | >= namespace function +delete | super-user or tenant admin or namespace function | >= namespace function +update | super-user or tenant admin or namespace function | >= namespace function +get | super-user or tenant admin or namespace function | >= namespace function +restart | super-user or tenant admin or namespace function | >= namespace function +stop | super-user or tenant admin or namespace function | >= namespace function +start | super-user or tenant admin or namespace function | >= namespace function +status | super-user or tenant admin or namespace function | >= namespace function +stats | super-user or tenant admin or namespace function | >= namespace function +list | super-user or tenant admin or namespace function | >= namespace function +querystate | super-user or tenant admin or namespace function | >= namespace function +trigger | super-user or tenant admin or namespace function | >= namespace function +putstate | super-user or tenant admin or namespace function | >= namespace function + +### sources + +Command |Current Permissions | Proposed Permissions +|---|--- +localrun | none | none +create | super-user or tenant admin or namespace function | >= namespace function +delete | super-user or tenant admin or namespace function | >= namespace function +update | super-user or tenant admin or namespace function | >= namespace function +get | none | >= namespace function +status | super-user or tenant admin or namespace function | >= namespace function +stop | super-user or tenant admin or namespace function | >= namespace function +start | super-user or tenant admin or namespace function | >= namespace function +list | super-user or tenant admin or namespace function |
[pulsar.wiki] branch master updated: Update proposed list
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new fc1600e Update proposed list fc1600e is described below commit fc1600e455d4c4e67c2078648f01c00669fed22b Author: 冉小龙 AuthorDate: Wed Oct 30 18:07:33 2019 +0800 Update proposed list --- Home.md | 1 + 1 file changed, 1 insertion(+) diff --git a/Home.md b/Home.md index 2af8f1f..40bd55a 100644 --- a/Home.md +++ b/Home.md @@ -7,6 +7,7 @@ We encourage to document any big change or feature or any addition to public use ### Proposed +* [[PIP 49: Permission levels and inheritance]] * [[PIP 48: hierarchical admin api]] * [[PIP 47: Time Based Release Plan]] * [[PIP 46: Next-gen Proxy]]
[pulsar.wiki] branch master updated: Updated PIP 49: Permission levels and inheritance (markdown)
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new 1461fc5 Updated PIP 49: Permission levels and inheritance (markdown) 1461fc5 is described below commit 1461fc579276f8de5fae835ec72b79d6336e6ae9 Author: 冉小龙 AuthorDate: Wed Oct 30 18:12:27 2019 +0800 Updated PIP 49: Permission levels and inheritance (markdown) --- PIP-49:-Permission-levels-and-inheritance.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/PIP-49:-Permission-levels-and-inheritance.md b/PIP-49:-Permission-levels-and-inheritance.md index f08fd73..3bf6610 100644 --- a/PIP-49:-Permission-levels-and-inheritance.md +++ b/PIP-49:-Permission-levels-and-inheritance.md @@ -1,7 +1,5 @@ -# PIP 49: Permission levels and inheritance - - Status: Draft -- Author: Xiaolong Ran +- Author: [Xiaolong Ran](https://github.com/wolfstudy)([@wolf4j](https://twitter.com/wolf4j1)) - Pull request: - Mailing list discussion: - Release:
[GitHub] [pulsar] sijie commented on issue #5454: mysql JDBC Sink - consumer error
sijie commented on issue #5454: mysql JDBC Sink - consumer error URL: https://github.com/apache/pulsar/issues/5454#issuecomment-547837498 @tuteng is correct. The problem is that all non-java clients don't attach the schema version to the messages when clients produce them. The fix should be straightforward by attaching the schema version to the messages at c++ client. To get around this problem for now, please use java client to produce AVRO messages first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5503: [Schema]GenericData$Record cannot be cast
tuteng commented on issue #5503: [Schema]GenericData$Record cannot be cast URL: https://github.com/apache/pulsar/issues/5503#issuecomment-547838719 @codelipenghui @congbobo184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng opened a new issue #5503: [Schema]GenericData$Record cannot be cast
tuteng opened a new issue #5503: [Schema]GenericData$Record cannot be cast
URL: https://github.com/apache/pulsar/issues/5503
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
```
@Builder
@Data
@NoArgsConstructor
@AllArgsConstructor
public static class Foo2 {
private String name;
private Integer id;
}
PulsarClient client = PulsarClient.builder()
.serviceUrl("pulsar://localhost:6650")
.build();
AvroSchema schema =
AvroSchema.of(SchemaDefinition.builder().withJsonDef("{\n" +
"\"type\": \"record\",\n" +
"\"name\": \"Test\",\n" +
"\"fields\": [\n" +
" {\n" +
"\"name\": \"id\",\n" +
"\"type\": [\n" +
" \"null\",\n" +
" \"int\"\n" +
"]\n" +
" },\n" +
" {\n" +
"\"name\": \"name\",\n" +
"\"type\": [\n" +
" \"null\",\n" +
" \"string\"\n" +
"]\n" +
" }\n" +
"]\n" +
" }").withPojo(Foo2.class).build());
Consumer consumer = client.newConsumer(schema)
.topic("pulsar-mysql-jdbc-sink-topic")
.subscriptionName("my-subscription-2")
.subscribe();
while (true) {
// Wait for a message
Message msg = consumer.receive();
Foo2 f = msg.getValue();
}
```
2. See error
```
Exception in thread "main" java.lang.ClassCastException:
org.apache.pulsar.shade.org.apache.avro.generic.GenericData$Record cannot be
cast to io.streamnative.KeyValueSchemaTest$Foo2
at
io.streamnative.KeyValueSchemaTest.testConsumerByPythonProduce(KeyValueSchemaTest.java:412)
at io.streamnative.KeyValueSchemaTest.main(KeyValueSchemaTest.java:305)
```
**Expected behavior**
A clear and concise description of what you expected to happen.
**Desktop (please complete the following information):**
- OS: [e.g.Mac]
**Additional context**
Add any other context about the problem here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] PierreZ commented on issue #5495: Add a reverse mapping from role to namespaces
PierreZ commented on issue #5495: Add a reverse mapping from role to namespaces URL: https://github.com/apache/pulsar/issues/5495#issuecomment-547848019 I digged through the code, roles are stored within ZK as a serialized version of the policies class. Which means that it is [PulsarAuthorizationProvider which is responsible for this](https://github.com/apache/pulsar/blob/master/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java#L261). I'm wondering if we should add a new method to the interface to be sure that all [AuthorizationProvider](https://github.com/apache/pulsar/blob/master/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationProvider.java) can reverse a role to their associated namespaces. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui opened a new pull request #5504: [Transaction coordinator]Add transaction metadata store service
codelipenghui opened a new pull request #5504: [Transaction coordinator]Add transaction metadata store service URL: https://github.com/apache/pulsar/pull/5504 ### Motivation Add transaction metadata store service and auto create 1 transaction metadata store with id 0 ### Verifying this change Add new unit tests for transaction metadata store service ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (yes) - The public API: (no) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation - Does this pull request introduce a new feature? (yes) This is a internal mechanism for transaction streaming This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5504: [Transaction coordinator]Add transaction metadata store service
codelipenghui commented on issue #5504: [Transaction coordinator]Add transaction metadata store service URL: https://github.com/apache/pulsar/pull/5504#issuecomment-547857973 @congbobo184 please help review this changes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5491: Fix message deduplicate issue while using external sequence id with batch produce
codelipenghui commented on issue #5491: Fix message deduplicate issue while using external sequence id with batch produce URL: https://github.com/apache/pulsar/pull/5491#issuecomment-54785 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (b11211f -> fd8832a)
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from b11211f Trim messages which less than mark delete position for message redelivery (#5378) add fd8832a [Doc]Fix document link error (#5496) No new revisions were added by this update. Summary of changes: site2/docs/reference-connector-admin.md | 1 + site2/website/sidebars.json | 1 + site2/website/versioned_docs/version-2.4.0/io-quickstart.md | 8 3 files changed, 6 insertions(+), 4 deletions(-)
[GitHub] [pulsar] codelipenghui merged pull request #5496: [Doc]Fix document link error
codelipenghui merged pull request #5496: [Doc]Fix document link error URL: https://github.com/apache/pulsar/pull/5496 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zymap commented on issue #5502: Fix list non-persistent topics shows the persistent topics
zymap commented on issue #5502: Fix list non-persistent topics shows the persistent topics URL: https://github.com/apache/pulsar/pull/5502#issuecomment-547863597 @codelipenghui Sure. Test coming soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5501: [Doc]Fix broken link
sijie commented on issue #5501: [Doc]Fix broken link URL: https://github.com/apache/pulsar/pull/5501#issuecomment-547868222 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client.
codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#issuecomment-547871290 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zymap commented on issue #5502: Fix list non-persistent topics shows the persistent topics
zymap commented on issue #5502: Fix list non-persistent topics shows the persistent topics URL: https://github.com/apache/pulsar/pull/5502#issuecomment-547878129 @codelipenghui Added a test. PTAL. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5232: Upgrade dependencies for security fixes
wolfstudy commented on issue #5232: Upgrade dependencies for security fixes URL: https://github.com/apache/pulsar/pull/5232#issuecomment-547882709 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5501: [Doc]Fix broken link
Jennifer88huang commented on issue #5501: [Doc]Fix broken link URL: https://github.com/apache/pulsar/pull/5501#issuecomment-547894553 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5504: [Transaction coordinator]Add transaction metadata store service
codelipenghui commented on issue #5504: [Transaction coordinator]Add transaction metadata store service URL: https://github.com/apache/pulsar/pull/5504#issuecomment-547896732 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5232: Upgrade dependencies for security fixes
wolfstudy commented on issue #5232: Upgrade dependencies for security fixes URL: https://github.com/apache/pulsar/pull/5232#issuecomment-547897561 ping @merlimat can you fix test case: ``` org.apache.pulsar.proxy.server.AuthedAdminProxyHandlerTest.testAuthenticatedProxyAsNonAdmin org.apache.pulsar.proxy.server.SuperUserAuthedAdminProxyHandlerTest.testAuthenticatedProxyAsAdmin org.apache.pulsar.proxy.server.SuperUserAuthedAdminProxyHandlerTest.testAuthenticatedProxyAsNonAdmin ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] xujianhai666 commented on issue #5393: Support service mesh for pulsar
xujianhai666 commented on issue #5393: Support service mesh for pulsar URL: https://github.com/apache/pulsar/issues/5393#issuecomment-547897800 > @xujianhai666 I see. so it seems like a feature request adding Pulsar filter in envoy. The work seems to have be done at Envoy side though. @sijie okay, I got it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5474: Support CDC Connector for MongoDB
tuteng commented on issue #5474: Support CDC Connector for MongoDB
URL: https://github.com/apache/pulsar/issues/5474#issuecomment-547901366
Yes, Debezium has already supported MongoDB. That should be easy to add
support to Mongo in pulsar-io, you can refer to
https://github.com/apache/pulsar/blob/master/pulsar-io/debezium/postgres/src/main/java/org/apache/pulsar/io/debezium/postgres/DebeziumPostgresSource.java
```
package org.apache.pulsar.io.debezium.postgres;
import java.util.Map;
import org.apache.kafka.connect.runtime.TaskConfig;
import org.apache.pulsar.io.debezium.DebeziumSource;
/**
* A pulsar source that runs debezium postgres source
*/
public class DebeziumPostgresSource extends DebeziumSource {
static private final String DEFAULT_TASK =
"io.debezium.connector.postgresql.PostgresConnectorTask";
@Override
public void setDbConnectorTask(Map config) throws
Exception {
throwExceptionIfConfigNotMatch(config, TaskConfig.TASK_CLASS_CONFIG,
DEFAULT_TASK);
}
}
```
, but we haven't had time to add this recently, if you are interested, you
can try it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] tuteng edited a comment on issue #5474: Support CDC Connector for MongoDB
tuteng edited a comment on issue #5474: Support CDC Connector for MongoDB
URL: https://github.com/apache/pulsar/issues/5474#issuecomment-547901366
Yes, Debezium has already supported MongoDB. That should be easy to add
support to Mongo in pulsar-io, you can refer to
https://github.com/apache/pulsar/blob/master/pulsar-io/debezium/postgres/src/main/java/org/apache/pulsar/io/debezium/postgres/DebeziumPostgresSource.java
```
package org.apache.pulsar.io.debezium.postgres;
import java.util.Map;
import org.apache.kafka.connect.runtime.TaskConfig;
import org.apache.pulsar.io.debezium.DebeziumSource;
/**
* A pulsar source that runs debezium postgres source
*/
public class DebeziumPostgresSource extends DebeziumSource {
static private final String DEFAULT_TASK =
"io.debezium.connector.postgresql.PostgresConnectorTask";
@Override
public void setDbConnectorTask(Map config) throws
Exception {
throwExceptionIfConfigNotMatch(config, TaskConfig.TASK_CLASS_CONFIG,
DEFAULT_TASK);
}
}
```
but we haven't had time to add this recently, if you are interested, you can
try it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5491: Fix message deduplicate issue while using external sequence id with batch produce
wolfstudy commented on issue #5491: Fix message deduplicate issue while using external sequence id with batch produce URL: https://github.com/apache/pulsar/pull/5491#issuecomment-547905791 hello @codelipenghui can you fix the test case: ``` org.apache.pulsar.broker.service.ReplicatorTest.testResumptionAfterBacklogRelaxed ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui opened a new issue #5505: NPE occur when get partitioned topic stats
codelipenghui opened a new issue #5505: NPE occur when get partitioned topic stats URL: https://github.com/apache/pulsar/issues/5505 **Describe the bug**  **Pulsar version** 2.4.1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] xujianhai666 commented on issue #61: [issue:60] Fix partition topic message router logic
xujianhai666 commented on issue #61: [issue:60] Fix partition topic message router logic URL: https://github.com/apache/pulsar-client-go/pull/61#issuecomment-547911264 @wolfstudy resolve conflict. pls This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5504: [Transaction coordinator]Add transaction metadata store service
codelipenghui commented on issue #5504: [Transaction coordinator]Add transaction metadata store service URL: https://github.com/apache/pulsar/pull/5504#issuecomment-547913393 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] lxy1992 commented on issue #4540: Pulsar Client has no support in Mac 10.14.5 (18F132) ?
lxy1992 commented on issue #4540: Pulsar Client has no support in Mac 10.14.5 (18F132) ? URL: https://github.com/apache/pulsar/issues/4540#issuecomment-547924475 We met the some problem. * Mac OS 10.14.6 * python 3.7.4 * pulsar-client 2.4.1 I can install it perfectly, but when I run the server locally, it shows me the following error ``` lib/python3.7/site-packages/_pulsar.cpython-37m-darwin.so Reason: image not found ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] lxy1992 edited a comment on issue #4540: Pulsar Client has no support in Mac 10.14.5 (18F132) ?
lxy1992 edited a comment on issue #4540: Pulsar Client has no support in Mac 10.14.5 (18F132) ? URL: https://github.com/apache/pulsar/issues/4540#issuecomment-547924475 We met the some problem. * Mac OS 10.14.6 * python 3.7.4 * pulsar-client 2.4.1 I can install it perfectly, but when I run the server locally, it shows me the following error ``` import _pulsar ImportError: dlopen(/Users/xxx/.local/share/virtualenvs/hunger-game-N1jOgOYL/lib/python3.7/site-packages/_pulsar.cpython-37m-darwin.so, 2): Library not loaded: /usr/local/opt/protobuf/lib/libprotobuf-lite.20.dylib Referenced from: /Users//.local/share/virtualenvs/hunger-game-N1jOgOYL/lib/python3.7/site-packages/_pulsar.cpython-37m-darwin.so Reason: image not found ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5482: [Issue 5309][docs] Clarify wording around retention policies
Jennifer88huang commented on issue #5482: [Issue 5309][docs] Clarify wording around retention policies URL: https://github.com/apache/pulsar/pull/5482#issuecomment-547937119 @rocketraman I've just checked, the update is already displayed on our website at https://pulsar.apache.org/docs/en/next/cookbooks-retention-expiry/#retention-policies Since the PR content is merged to master, it takes effect in the `next` version, so it's not displayed for version 2.4.1 yet. If you want to update it in version 2.4.1, you need to copy the update to ../site2/website/versioned_docs/version-2.4.1. Since i've changed the Milestone to 2.4.2, and 2.4.2 release is due 10/31, so when 2.4.2 is released, you update will also be displayed in 2.4.2 as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang closed issue #5493: [website] Broken links to some download packages
Jennifer88huang closed issue #5493: [website] Broken links to some download packages URL: https://github.com/apache/pulsar/issues/5493 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang merged pull request #5501: [Doc]Fix broken link
Jennifer88huang merged pull request #5501: [Doc]Fix broken link URL: https://github.com/apache/pulsar/pull/5501 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (fd8832a -> 7b5693f)
This is an automated email from the ASF dual-hosted git repository.
hjf pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from fd8832a [Doc]Fix document link error (#5496)
add 7b5693f Fix broke link (#5501)
No new revisions were added by this update.
Summary of changes:
.../admin-api-schemas.md | 5 +-
.../concepts-schema-registry.md| 5 +-
.../version-2.4.0 => docs}/functions-api.md| 5 +-
site2/docs/functions-debugging.md | 126 +
.../version-2.3.0 => docs}/functions-deploying.md | 5 +-
.../version-2.2.0 => docs}/functions-guarantees.md | 5 +-
.../functions-metrics.md | 5 +-
.../functions-state.md | 6 +-
.../version-2.2.1 => docs}/io-tcp.md | 5 +-
.../version-2.4.0 => docs}/security-token-admin.md | 14 +--
site2/website/pages/en/download.js | 38 ---
.../getting-started-standalone.md | 2 +-
.../version-2.1.0-incubating/io-managing.md| 2 +-
.../getting-started-standalone.md | 2 +-
.../version-2.1.1-incubating/io-managing.md| 2 +-
.../version-2.2.0/getting-started-standalone.md| 2 +-
.../versioned_docs/version-2.2.0/io-managing.md| 2 +-
.../version-2.2.1/getting-started-standalone.md| 2 +-
.../versioned_docs/version-2.4.0/io-managing.md| 2 +-
19 files changed, 173 insertions(+), 62 deletions(-)
copy site2/{website/versioned_docs/version-2.1.0-incubating =>
docs}/admin-api-schemas.md (96%)
copy site2/{website/versioned_docs/version-2.1.0-incubating =>
docs}/concepts-schema-registry.md (97%)
copy site2/{website/versioned_docs/version-2.4.0 => docs}/functions-api.md
(99%)
create mode 100644 site2/docs/functions-debugging.md
copy site2/{website/versioned_docs/version-2.3.0 =>
docs}/functions-deploying.md (99%)
copy site2/{website/versioned_docs/version-2.2.0 =>
docs}/functions-guarantees.md (95%)
copy site2/{website/versioned_docs/version-2.1.0-incubating =>
docs}/functions-metrics.md (94%)
copy site2/{website/versioned_docs/version-2.1.0-incubating =>
docs}/functions-state.md (97%)
copy site2/{website/versioned_docs/version-2.2.1 => docs}/io-tcp.md (91%)
copy site2/{website/versioned_docs/version-2.4.0 =>
docs}/security-token-admin.md (90%)
[GitHub] [pulsar] dependabot[bot] opened a new pull request #5506: Bump jekyll from 3.7.3 to 3.7.4 in /site
dependabot[bot] opened a new pull request #5506: Bump jekyll from 3.7.3 to 3.7.4 in /site URL: https://github.com/apache/pulsar/pull/5506 Bumps [jekyll](https://github.com/jekyll/jekyll) from 3.7.3 to 3.7.4. Release notes *Sourced from [jekyll's releases](https://github.com/jekyll/jekyll/releases).* > ## v3.7.4 > ### Bug Fixes > > * Security: fix `include` bypass of EntryFilter#filter symlink check (https://github-redirect.dependabot.com/jekyll/jekyll/pull/7224) Changelog *Sourced from [jekyll's changelog](https://github.com/jekyll/jekyll/blob/master/History.markdown).* > ## 3.7.4 / 2018-09-07 > > ### Bug Fixes > > * Security: fix `include` bypass of EntryFilter#filter symlink check ([#7224](https://github-redirect.dependabot.com/jekyll/jekyll/issues/7224)) Commits - [`07561b3`](https://github.com/jekyll/jekyll/commit/07561b301b75010d5c4e447f68db4e4130f3bc26) Release :gem: 3.7.4 - [`bd70949`](https://github.com/jekyll/jekyll/commit/bd70949ecf59fdf5a410fb0f4355989f5eab285e) Release :gem: v3.7.4 - [`4108ddb`](https://github.com/jekyll/jekyll/commit/4108ddb05c404355f78c99b81aa44b58fbed87ef) Merge pull request [#7224](https://github-redirect.dependabot.com/jekyll/jekyll/issues/7224) from jekyll/3.7-entryfilter-symlink-fix - [`2025d12`](https://github.com/jekyll/jekyll/commit/2025d1250239d0a8e96a1f5e5da6567cfc3d1c42) Revert "Run this branch." - [`7f1faea`](https://github.com/jekyll/jekyll/commit/7f1faea47d0d1665b32d075cbe6b5f0990f11577) LayoutReader: skip tests if Windows - [`f5cd15c`](https://github.com/jekyll/jekyll/commit/f5cd15cfd4094ba0632dbf2901d79479ff062494) Run this branch. - [`35219a8`](https://github.com/jekyll/jekyll/commit/35219a8c42e4853485ef10dc1bb8ef1766c6aca3) Fix fmt errors. - [`2c088e2`](https://github.com/jekyll/jekyll/commit/2c088e2596c9ad6bb15ded045adbde8da2c245f5) Update tests for EntryFilter#filter fix and add comments for it - [`a8b91de`](https://github.com/jekyll/jekyll/commit/a8b91de97b3196b3e0f282145f6bdefab1303bda) EntryFilter#filter: reject all symlinks, even if included - [`2a679e7`](https://github.com/jekyll/jekyll/commit/2a679e797c0eee5864acdf8706d5b478fae86dc7) Add failing tests for symlink check. - See full diff in [compare view](https://github.com/jekyll/jekyll/compare/v3.7.3...v3.7.4) [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/pulsar/network/alerts). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch dependabot/bundler/site/jekyll-3.7.4 created (now 3eb0d17)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/bundler/site/jekyll-3.7.4 in repository https://gitbox.apache.org/repos/asf/pulsar.git. at 3eb0d17 Bump jekyll from 3.7.3 to 3.7.4 in /site No new revisions were added by this update.
[GitHub] [pulsar] dependabot[bot] opened a new pull request #5508: Bump jackson-databind from 2.9.9.3 to 2.10.0
dependabot[bot] opened a new pull request #5508: Bump jackson-databind from 2.9.9.3 to 2.10.0 URL: https://github.com/apache/pulsar/pull/5508 Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.9.9.3 to 2.10.0. Commits - See full diff in [compare view](https://github.com/FasterXML/jackson/commits) [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/pulsar/network/alerts). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] dependabot[bot] opened a new pull request #5507: Bump ffi from 1.9.23 to 1.11.1 in /site
dependabot[bot] opened a new pull request #5507: Bump ffi from 1.9.23 to 1.11.1 in /site URL: https://github.com/apache/pulsar/pull/5507 Bumps [ffi](https://github.com/ffi/ffi) from 1.9.23 to 1.11.1. Changelog *Sourced from [ffi's changelog](https://github.com/ffi/ffi/blob/master/CHANGELOG.md).* > 1.11.1 / 2019-05-20 > --- > > Changed: > * Raise required ruby version to >=2.0. [#699](https://github-redirect.dependabot.com/ffi/ffi/issues/699), [#700](https://github-redirect.dependabot.com/ffi/ffi/issues/700) > * Fix a possible linker error on ruby < 2.3 on Linux. > > > 1.11.0 / 2019-05-17 > --- > This version was yanked on 2019-05-20 to fix an install issue on ruby-1.9.3. [#700](https://github-redirect.dependabot.com/ffi/ffi/issues/700) > > Added: > * Add ability to disable or force use of system libffi. [#669](https://github-redirect.dependabot.com/ffi/ffi/issues/669) > Use like `gem inst ffi -- --enable-system-libffi` . > * Add ability to call FFI callbacks from outside of FFI call frame. [#584](https://github-redirect.dependabot.com/ffi/ffi/issues/584) > * Add proper documentation to FFI::Generator and ::Task > * Add gemspec metadata. [#696](https://github-redirect.dependabot.com/ffi/ffi/issues/696), [#698](https://github-redirect.dependabot.com/ffi/ffi/issues/698) > > Changed: > * Fix stdcall on Win32. [#649](https://github-redirect.dependabot.com/ffi/ffi/issues/649), [#669](https://github-redirect.dependabot.com/ffi/ffi/issues/669) > * Fix load paths for FFI::Generator::Task > * Fix FFI::Pointer#read_string(0) to return a binary String. [#692](https://github-redirect.dependabot.com/ffi/ffi/issues/692) > * Fix benchmark suite so that it runs on ruby-2.x > * Move FFI::Platform::CPU from C to Ruby. [#663](https://github-redirect.dependabot.com/ffi/ffi/issues/663) > * Move FFI::StructByReference to Ruby. [#681](https://github-redirect.dependabot.com/ffi/ffi/issues/681) > * Move FFI::DataConverter to Ruby ([#661](https://github-redirect.dependabot.com/ffi/ffi/issues/661)) > * Various cleanups and improvements of specs and benchmarks > > Removed: > * Remove ruby-1.8 and 1.9 compatibility code. [#683](https://github-redirect.dependabot.com/ffi/ffi/issues/683) > * Remove unused spec files. [#684](https://github-redirect.dependabot.com/ffi/ffi/issues/684) > > > 1.10.0 / 2019-01-06 > --- > > Added: > * Add /opt/local/lib/ to ffi's fallback library search path. [#638](https://github-redirect.dependabot.com/ffi/ffi/issues/638) > * Add binary gem support for ruby-2.6 on Windows > * Add FreeBSD on AArch64 and ARM support. [#644](https://github-redirect.dependabot.com/ffi/ffi/issues/644) > * Add FFI::LastError.winapi_error on Windows native or Cygwin. [#633](https://github-redirect.dependabot.com/ffi/ffi/issues/633) > > Changed: > * Update to rake-compiler-dock-0.7.0 > * Use 64-bit inodes on FreeBSD >= 12. [#644](https://github-redirect.dependabot.com/ffi/ffi/issues/644) > * Switch time_t and suseconds_t types to long on FreeBSD. [#627](https://github-redirect.dependabot.com/ffi/ffi/issues/627) > * Make register_t long_long on 64-bit FreeBSD. [#644](https://github-redirect.dependabot.com/ffi/ffi/issues/644) > * Fix Pointer#write_array_of_type [#637](https://github-redirect.dependabot.com/ffi/ffi/issues/637) > > ... (truncated) Commits - [`3d8c91c`](https://github.com/ffi/ffi/commit/3d8c91c902d67f2af184b1da1b0e99323bc1c744) Update CHANGELOG for ffi-1.11.1 - [`2a3d9d6`](https://github.com/ffi/ffi/commit/2a3d9d60db6d01e3a1472484371df2a14ec1ec3a) Bump VERSION to 1.11.1 - [`19d5776`](https://github.com/ffi/ffi/commit/19d5776080c2d8f3d2840ea449ef2c9a632b93d5) Add some missing items to CHANGELOG for ffi-1.11.0 - [`08b9b78`](https://github.com/ffi/ffi/commit/08b9b7875fe6fff8ba34d794a4bdebaf78b95ba2) Raise ruby version requirement to >=2.0 - [`e76c43b`](https://github.com/ffi/ffi/commit/e76c43b3efaa24563e6c93dd8f0128240197a88c) Fix build on ruby-2.0 on Linux - [`9b4a9e4`](https://github.com/ffi/ffi/commit/9b4a9e450a4f78bf569ad8b6497bd6b4e8ec82d3) Add version 1.11.0 to CHANGELOG - [`36f1bb5`](https://github.com/ffi/ffi/commit/36f1bb55aa0712fa8ea5431cfb9d94ebc2a34372) Bump VERSION to 1.11.0 - [`29c07a9`](https://github.com/ffi/ffi/commit/29c07a94fadfb644c28741f744ab9a3fda3e544c) Pass options from rake task to the FFI::Generator - [`7efdd2e`](https://github.com/ffi/ffi/commit/7efdd2ecbb8ab2df56aecade9c82fd48eb71969f) Include the name of the template file instead of just rake - [`bc99b7e`](https://github.com/ffi/ffi/commit/bc99b7efa78afc150fe32d09579a11c8990aaf84) Add proper documentation to FFI::Generator and ::Task - Additional commits viewable in [compare view](https://github.com/ffi/ffi/compare/1.9.2
[pulsar] branch dependabot/maven/com.fasterxml.jackson.core-jackson-databind-2.10.0 created (now 3fb4007)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.fasterxml.jackson.core-jackson-databind-2.10.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git. at 3fb4007 Bump jackson-databind from 2.9.9.3 to 2.10.0 No new revisions were added by this update.
[pulsar] branch dependabot/bundler/site/ffi-1.11.1 created (now aff7b3f)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/bundler/site/ffi-1.11.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git. at aff7b3f Bump ffi from 1.9.23 to 1.11.1 in /site No new revisions were added by this update.
[GitHub] [pulsar] rebootmoishe opened a new issue #5509: Similar to issue #5129. Unable to install pulsar-client 2.4.1 on Windows
rebootmoishe opened a new issue #5509: Similar to issue #5129. Unable to install pulsar-client 2.4.1 on Windows URL: https://github.com/apache/pulsar/issues/5509 **Describe the bug** Unable to pip install pulsar-client 2.4.1 on Windows **To Reproduce** C:\Users\name>python --version Python 3.7.5 C:\Users\name>pip install pulsar-client==2.4.1 ERROR: Could not find a version that satisfies the requirement pulsar-client==2.4.1 (from versions: none) ERROR: No matching distribution found for pulsar-client==2.4.1 **Expected behavior** client installs. **Desktop (please complete the following information):** - OS: Windows 10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5491: Fix message deduplicate issue while using external sequence id with batch produce
codelipenghui commented on issue #5491: Fix message deduplicate issue while using external sequence id with batch produce URL: https://github.com/apache/pulsar/pull/5491#issuecomment-547996249 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5495: Add a reverse mapping from role to namespaces
merlimat commented on issue #5495: Add a reverse mapping from role to namespaces URL: https://github.com/apache/pulsar/issues/5495#issuecomment-54852 > roles are stored within ZK as a serialized version of the policies class. That's true for the default implementation, though the AuthZ backend can be (and is in real-life) also pluggable with different implementations. > 'm wondering if we should add a new method to the interface to be sure that all AuthorizationProvider can reverse a role to their associated namespaces. What do you think? That would be requiring to do a scan of the metadata to search for namespaces in which a role has access to. Or maintaining a different mapping, with the trouble of keeping that in sink with the source of truth. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] PierreZ commented on issue #5495: Add a reverse mapping from role to namespaces
PierreZ commented on issue #5495: Add a reverse mapping from role to namespaces URL: https://github.com/apache/pulsar/issues/5495#issuecomment-548017823 > That would be requiring to do a scan of the metadata to search for namespaces in which a role has access to. Or maintaining a different mapping, with the trouble of keeping that in sink with the source of truth. True, I was thinking about implementing your first proposal. Something that is looping through znodes, and check if `auth_policies.namespace_auth.containsKey(role)` for the default implementation. > Or maintaining a different mapping, with the trouble of keeping that in sink with the source of truth. I agree with you, not sure it's worth it for now and for a first implementation. > That's true for the default implementation, though the AuthZ backend can be (and is in real-life) also pluggable with different implementations. That means that I don't have many options regarding the location of where that piece of code should be: it must be hold by the AuthorizationProvider. > I think that most AuthZ implementation won't be able to fulfill that info though I must admit that I saw only one implementation within the codebase, so I might underestimate this particular point. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aslom commented on issue #5252: support cloud event
aslom commented on issue #5252: support cloud event URL: https://github.com/apache/pulsar/issues/5252#issuecomment-548031979 @sijie how can I find that proposal? link? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5252: support cloud event
sijie commented on issue #5252: support cloud event URL: https://github.com/apache/pulsar/issues/5252#issuecomment-548035631 for people who are interested in this topic, here is the proposal : https://github.com/cloudevents/spec/pull/237/files This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5252: support cloud event
sijie commented on issue #5252: support cloud event URL: https://github.com/apache/pulsar/issues/5252#issuecomment-548036031 The proposal was a bit old. I think the CloudEvents has evolved to 1.0. So the proposal might need to be reworked to 1.0 specification. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5495: Add a reverse mapping from role to namespaces
merlimat commented on issue #5495: Add a reverse mapping from role to namespaces URL: https://github.com/apache/pulsar/issues/5495#issuecomment-548045280 > True, I was thinking about implementing your first proposal. Something that is looping through znodes, and check if auth_policies.namespace_auth.containsKey(role) for the default implementation. That might be expensive if called frequently from clients in any case with a non-trivial number of namespaces. > I must admit that I saw only one implementation within the codebase, so I might underestimate this particular point. Yes, there's just one implementation in the codebase, the default where ACLs are stored with the namespace policies on ZK, though there are others using different authorization options, including : * Use AuthZ information stored in the AuthN credentials (eg: JWT token, or TLS certificate, also containing which resources this token has access to. * Third party ACLs provider (eg: Okta, Auth0, Vault, etc.. ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5486: Make unit tests to only use dynamically allocated ports
aahmed-se commented on issue #5486: Make unit tests to only use dynamically allocated ports URL: https://github.com/apache/pulsar/pull/5486#issuecomment-548073082 run java8 tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on issue #5463: Function runtime pluggable
jerrypeng commented on issue #5463: Function runtime pluggable URL: https://github.com/apache/pulsar/pull/5463#issuecomment-548073106 @sijie @wolfstudy @merlimat please review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5506: Bump jekyll from 3.7.3 to 3.7.4 in /site
aahmed-se commented on issue #5506: Bump jekyll from 3.7.3 to 3.7.4 in /site URL: https://github.com/apache/pulsar/pull/5506#issuecomment-548078792 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5458: [cpp-build] Do not install libsnappy at each build
aahmed-se commented on issue #5458: [cpp-build] Do not install libsnappy at each build URL: https://github.com/apache/pulsar/pull/5458#issuecomment-548079355 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5486: Make unit tests to only use dynamically allocated ports
aahmed-se commented on issue #5486: Make unit tests to only use dynamically allocated ports URL: https://github.com/apache/pulsar/pull/5486#issuecomment-548117037 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] candlerb commented on issue #5488: Python API: Add test case for create_reader(is_read_compacted)
candlerb commented on issue #5488: Python API: Add test case for create_reader(is_read_compacted) URL: https://github.com/apache/pulsar/pull/5488#issuecomment-548118789 Weird - `test_negative_acks` still failed even with 10 second timeout. I have removed the timeout entirely from that test case and pushed again; it is now back how it was. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] candlerb commented on issue #5386: Update presto to 0.226
candlerb commented on issue #5386: Update presto to 0.226 URL: https://github.com/apache/pulsar/pull/5386#issuecomment-548124032 Integration test failures: ``` 2019-10-30\T\10:08:12.926 [INFO] --- 2019-10-30\T\10:08:12.926 [INFO] T E S T S 2019-10-30\T\10:08:12.926 [INFO] --- 2019-10-30\T\10:08:13.423 [INFO] Running TestSuite 2019-10-30\T\11:17:27.498 [ERROR] Tests run: 87, Failures: 2, Errors: 0, Skipped: 3, Time elapsed: 4,154.023 s <<< FAILURE! - in TestSuite 2019-10-30\T\11:17:27.499 [ERROR] pulsar-test-suite(org.apache.pulsar.tests.integration.presto.TestBasicPresto) Time elapsed: 2.261 s <<< FAILURE! org.apache.pulsar.tests.integration.docker.ContainerExecException: /bin/bash -c /pulsar/bin/pulsar sql --execute 'show catalogs;' failed on 50bdfb36060ff10e83189f10195798c073c6de929f3aad743223a0cf366f5487 with error code 1 at org.apache.pulsar.tests.integration.utils.DockerUtils$2.onComplete(DockerUtils.java:259) at com.github.dockerjava.core.exec.AbstrAsyncDockerCmdExec$1.onComplete(AbstrAsyncDockerCmdExec.java:51) at org.testcontainers.dockerclient.transport.okhttp.OkHttpInvocationBuilder.lambda$executeAndStream$1(OkHttpInvocationBuilder.java:297) at java.lang.Thread.run(Thread.java:748) 2019-10-30\T\11:17:27.501 [ERROR] pulsar-test-suite(org.apache.pulsar.tests.integration.presto.TestBasicPresto) Time elapsed: 2.273 s <<< FAILURE! org.apache.pulsar.tests.integration.docker.ContainerExecException: /bin/bash -c /pulsar/bin/pulsar sql --execute 'show catalogs;' failed on 50bdfb36060ff10e83189f10195798c073c6de929f3aad743223a0cf366f5487 with error code 1 at org.apache.pulsar.tests.integration.utils.DockerUtils$2.onComplete(DockerUtils.java:259) at com.github.dockerjava.core.exec.AbstrAsyncDockerCmdExec$1.onComplete(AbstrAsyncDockerCmdExec.java:51) at org.testcontainers.dockerclient.transport.okhttp.OkHttpInvocationBuilder.lambda$executeAndStream$1(OkHttpInvocationBuilder.java:297) at java.lang.Thread.run(Thread.java:748) ``` I think it would be helpful to see `cee.getResult().getStderr()` here - maybe class ContainerExecException should include some stderr in its default string output. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5509: Similar to issue #5129. Unable to install pulsar-client 2.4.1 on Windows
aahmed-se commented on issue #5509: Similar to issue #5129. Unable to install pulsar-client 2.4.1 on Windows URL: https://github.com/apache/pulsar/issues/5509#issuecomment-548127246 we don't publish python packages for windows currently. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #4967: Static linking for c/c++ libraries broken for osx
aahmed-se commented on issue #4967: Static linking for c/c++ libraries broken for osx URL: https://github.com/apache/pulsar/issues/4967#issuecomment-548127536 This issue is resolved This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se closed issue #4967: Static linking for c/c++ libraries broken for osx
aahmed-se closed issue #4967: Static linking for c/c++ libraries broken for osx URL: https://github.com/apache/pulsar/issues/4967 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #4540: Pulsar Client has no support in Mac 10.14.5 (18F132) ?
aahmed-se commented on issue #4540: Pulsar Client has no support in Mac 10.14.5 (18F132) ? URL: https://github.com/apache/pulsar/issues/4540#issuecomment-548127971 @lxy1992 try this ``` brew install protobuf ``` I will take a look at why the static linking didn't work correctly This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on a change in pull request #5491: Fix message deduplicate issue while using external sequence id with batch produce
merlimat commented on a change in pull request #5491: Fix message deduplicate
issue while using external sequence id with batch produce
URL: https://github.com/apache/pulsar/pull/5491#discussion_r340899288
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java
##
@@ -76,6 +76,14 @@ default long getOriginalSequenceId() {
}
void completed(Exception e, long ledgerId, long entryId);
+
+default long getLowestSequenceId() {
Review comment:
I don't see how these sequence ids relate to a `Topic`.
* What's the lowest sequenceId ? I think this only apply to 1 single batch.
* Sequence id are *per producer* anyway
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] merlimat commented on a change in pull request #5491: Fix message deduplicate issue while using external sequence id with batch produce
merlimat commented on a change in pull request #5491: Fix message deduplicate
issue while using external sequence id with batch produce
URL: https://github.com/apache/pulsar/pull/5491#discussion_r340894556
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationFailureTest.java
##
@@ -241,7 +241,11 @@ public void
testClientDeduplicationCorrectnessWithFailure() throws Exception {
producerThread.stop();
// send last message
-producer.newMessage().sequenceId(producerThread.getLastSeqId() +
1).value("end").send();
+try {
+producer.newMessage().sequenceId(producerThread.getLastSeqId() +
1).value("end").send();
+fail("should failed, because send a duplication");
+} catch (PulsarClientException.InvalidMessageException ignore) {
Review comment:
I don't think this is a valid assumption. The logic of dedup is to
transparently perform the deduplication, without giving error to the
application in case of duplicates.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] merlimat commented on a change in pull request #5491: Fix message deduplicate issue while using external sequence id with batch produce
merlimat commented on a change in pull request #5491: Fix message deduplicate
issue while using external sequence id with batch produce
URL: https://github.com/apache/pulsar/pull/5491#discussion_r340898868
##
File path: pulsar-common/src/main/proto/PulsarApi.proto
##
@@ -394,6 +398,10 @@ message CommandSend {
optional int32 num_messages = 3 [default = 1];
optional uint64 txnid_least_bits = 4 [default = 0];
optional uint64 txnid_most_bits = 5 [default = 0];
+
+/// Add lowest and highest sequence id to support external sequence id
+optional uint64 lowest_sequence_id = 6 [default = 0];
+optional uint64 highest_sequence_id = 7 [default = 0];
Review comment:
Why do we need 2 new fields here? Don't we just need to a new
`last_sequence_id`? isn't `lowest_sequence_id` the same as `sequence_id` ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] merlimat commented on a change in pull request #5491: Fix message deduplicate issue while using external sequence id with batch produce
merlimat commented on a change in pull request #5491: Fix message deduplicate
issue while using external sequence id with batch produce
URL: https://github.com/apache/pulsar/pull/5491#discussion_r340899523
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java
##
@@ -257,6 +285,9 @@ public ServerCnx getCnx() {
private String originalProducerName;
private long originalSequenceId;
+private long lowestSequenceId;
Review comment:
What does it mean the lowest sequence id of a producer?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] merlimat commented on a change in pull request #5491: Fix message deduplicate issue while using external sequence id with batch produce
merlimat commented on a change in pull request #5491: Fix message deduplicate
issue while using external sequence id with batch produce
URL: https://github.com/apache/pulsar/pull/5491#discussion_r340898206
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##
@@ -368,6 +372,19 @@ public void sendAsync(Message message, SendCallback
callback) {
} else {
sequenceId = msgMetadataBuilder.getSequenceId();
}
+
+if (sequenceId <= lastSequenceIdPushed) {
+if (sequenceId <= lastSequenceIdPublished) {
+callback.sendComplete(new PulsarClientException
+.InvalidMessageException("Message is
definitely a duplicate"));
+return;
+} else {
+callback.sendComplete(new PulsarClientException
+.InvalidMessageException("Message is a
definitely a duplicate or not cannot be " +
+"determined at this time"));
Review comment:
If we don't know whether is dup or not, then why are we triggering error
here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] merlimat commented on a change in pull request #5491: Fix message deduplicate issue while using external sequence id with batch produce
merlimat commented on a change in pull request #5491: Fix message deduplicate
issue while using external sequence id with batch produce
URL: https://github.com/apache/pulsar/pull/5491#discussion_r340896656
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##
@@ -368,6 +372,19 @@ public void sendAsync(Message message, SendCallback
callback) {
} else {
sequenceId = msgMetadataBuilder.getSequenceId();
}
+
+if (sequenceId <= lastSequenceIdPushed) {
+if (sequenceId <= lastSequenceIdPublished) {
+callback.sendComplete(new PulsarClientException
+.InvalidMessageException("Message is
definitely a duplicate"));
Review comment:
We shouldn't trigger an error to the application when there are dups, rather
the contract is that it gets an OK. In any case we need to think through the
implication of triggering an error just for one message out of band.
This is a very different behavior from the other failure modes where all the
messages are failed after 1 failure.
I believe that handling this in broker side is much preferable.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se edited a comment on issue #4028: Functions should make use of Schema Types that are available
aahmed-se edited a comment on issue #4028: Functions should make use of Schema Types that are available URL: https://github.com/apache/pulsar/pull/4028#issuecomment-547696831 @srkukarni can you address the comments This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5342: Use simple GC settings when running integration tests
aahmed-se commented on issue #5342: Use simple GC settings when running integration tests URL: https://github.com/apache/pulsar/pull/5342#issuecomment-548157126 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5458: [cpp-build] Do not install libsnappy at each build
aahmed-se commented on issue #5458: [cpp-build] Do not install libsnappy at each build URL: https://github.com/apache/pulsar/pull/5458#issuecomment-548157558 run java8 tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch docker2 created (now 925b542)
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch docker2 in repository https://gitbox.apache.org/repos/asf/pulsar.git. at 925b542 Update testContainers No new revisions were added by this update.
[GitHub] [pulsar] sunlc210 opened a new issue #5510: splitting bundle error
sunlc210 opened a new issue #5510: splitting bundle error URL: https://github.com/apache/pulsar/issues/5510 Met the split bundle error when supply huge data into pulsar,block the data transfer 20:11:38.774 [pulsar-modular-load-manager-29-1] INFO org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl - Load-manager splitting bundle crossjh2wx/jh2wx/0x8a00_0x8b00 and unloading true 20:11:38.779 [pulsar-web-30-6] INFO org.apache.pulsar.broker.admin.impl.NamespacesBase - [null] Split namespace bundle crossjh2wx/jh2wx/0x8a00_0x8b00 20:11:38.779 [pulsar-web-30-6] ERROR org.apache.pulsar.broker.web.PulsarWebResource - [null] Failed to validate namespace bundle crossjh2wx/jh2wx/0x8a00_0x8b00 java.lang.IllegalArgumentException: Invalid upper boundary for bundle at com.google.common.base.Preconditions.checkArgument(Preconditions.java:122) ~[com.google.guava-guava-21.0.jar:?] at org.apache.pulsar.common.naming.NamespaceBundles.validateBundle(NamespaceBundles.java:114) ~[org.apache.pulsar-pulsar-broker-2.4.1.jar:2.4.1] at org.apache.pulsar.broker.web.PulsarWebResource.validateNamespaceBundleRange(PulsarWebResource.java:465) ~[org.apache.pulsar-pulsar-broker-2.4.1.jar:2.4.1] at org.apache.pulsar.broker.web.PulsarWebResource.validateNamespaceBundleOwnership(PulsarWebResource.java:491) ~[org.apache.pulsar-pulsar-broker-2.4.1.jar:2.4.1] at org.apache.pulsar.broker.admin.impl.NamespacesBase.internalSplitNamespaceBundle(NamespacesBase.java:741) ~[org.apache.pulsar-pulsar-broker-2.4.1.jar:2.4.1] at org.apache.pulsar.broker.admin.v2.Namespaces.splitNamespaceBundle(Namespaces.java:330) ~[org.apache.pulsar-pulsar-broker-2.4.1.jar:2.4.1] at sun.reflect.GeneratedMethodAccessor85.invoke(Unknown Source) ~[?:?] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_111] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_111] at org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory.lambda$static$0(ResourceMethodInvocationHandlerFactory.java:76) ~[org.glassfish.jersey.core-jersey-server-2.27.jar:?] at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:148) [org.glassfish.jersey.core-jersey-server-2.27.jar:?] at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:191) [org.glassfish.jersey.core-jersey-server-2.27.jar:?] at org.glassfish.jersey.server.model.internal.JavaResourceMethodDispatcherProvider$VoidOutInvoker.doDispatch(JavaResourceMethodDispatcherProvider.java:183) [org.glassfish.jersey.core-jersey-server-2.27.jar:?] at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.dispatch(AbstractJavaResourceMethodDispatcher.java:103) [org.glassfish.jersey.core-jersey-server-2.27.jar:?] at org.glassfish.jersey.server.model.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:493) [org.glassfish.jersey.core-jersey-server-2.27.jar:?] at org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:415) [org.glassfish.jersey.core-jersey-server-2.27.jar:?] at org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:104) [org.glassfish.jersey.core-jersey-server-2.27.jar:?] at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:277) [org.glassfish.jersey.core-jersey-server-2.27.jar:?] at org.glassfish.jersey.internal.Errors$1.call(Errors.java:272) [org.glassfish.jersey.core-jersey-common-2.27.jar:?] at org.glassfish.jersey.internal.Errors$1.call(Errors.java:268) [org.glassfish.jersey.core-jersey-common-2.27.jar:?] at org.glassfish.jersey.internal.Errors.process(Errors.java:316) [org.glassfish.jersey.core-jersey-common-2.27.jar:?] at org.glassfish.jersey.internal.Errors.process(Errors.java:298) [org.glassfish.jersey.core-jersey-common-2.27.jar:?] at org.glassfish.jersey.internal.Errors.process(Errors.java:268) [org.glassfish.jersey.core-jersey-common-2.27.jar:?] at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:289) [org.glassfish.jersey.core-jersey-common-2.27.jar:?] at org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:256) [org.glassfish.jersey.core-jersey-server-2.27.jar:?] at org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:703) [org.glassfish.jersey.core-jersey-server-2.27.jar:?] at org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:416) [org.glassfish.jersey.containers-jersey-container-servle
[GitHub] [pulsar] tuteng opened a new pull request #5511: [Doc]Add md suffix for fix cdc link
tuteng opened a new pull request #5511: [Doc]Add md suffix for fix cdc link URL: https://github.com/apache/pulsar/pull/5511 * Add .md suffix for fix cdc link This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5505: NPE occur when get partitioned topic stats
Jennifer88huang commented on issue #5505: NPE occur when get partitioned topic stats URL: https://github.com/apache/pulsar/issues/5505#issuecomment-548188651 @codelipenghui Thank you for raising the issue. Do you know the reason of this issue, and could you fix it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5503: [Schema]GenericData$Record cannot be cast
Jennifer88huang commented on issue #5503: [Schema]GenericData$Record cannot be cast URL: https://github.com/apache/pulsar/issues/5503#issuecomment-548188823 When you find the reason for the bug, could you please pull request and fix it? Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] TC-oKozlov commented on issue #271: Consider using gRPC as an externally exposed API
TC-oKozlov commented on issue #271: Consider using gRPC as an externally exposed API URL: https://github.com/apache/pulsar/issues/271#issuecomment-548189109 We have real-time messaging system implemented in Erlang, and looking at pulsar as a pub/sub /queue message broker. Unfortunately that means implementing our own client lib with tons of features on top of binary / protobuf protocol. Having gRPC support would have greatly helped This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5481: CDC Debezium Connector isn't allowing to specify replication slot name
Jennifer88huang commented on issue #5481: CDC Debezium Connector isn't allowing to specify replication slot name URL: https://github.com/apache/pulsar/issues/5481#issuecomment-548190095 @limadelrey Thank you for raising the issue. @jiazhai @tuteng Is it possible to use `slot.name` property? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on a change in pull request #5491: Fix message deduplicate issue while using external sequence id with batch produce
codelipenghui commented on a change in pull request #5491: Fix message
deduplicate issue while using external sequence id with batch produce
URL: https://github.com/apache/pulsar/pull/5491#discussion_r340937664
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java
##
@@ -257,6 +285,9 @@ public ServerCnx getCnx() {
private String originalProducerName;
private long originalSequenceId;
+private long lowestSequenceId;
Review comment:
It is in the inner class named MessagePublishContext of Producer
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on a change in pull request #5491: Fix message deduplicate issue while using external sequence id with batch produce
codelipenghui commented on a change in pull request #5491: Fix message
deduplicate issue while using external sequence id with batch produce
URL: https://github.com/apache/pulsar/pull/5491#discussion_r340938778
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##
@@ -368,6 +372,19 @@ public void sendAsync(Message message, SendCallback
callback) {
} else {
sequenceId = msgMetadataBuilder.getSequenceId();
}
+
+if (sequenceId <= lastSequenceIdPushed) {
+if (sequenceId <= lastSequenceIdPublished) {
+callback.sendComplete(new PulsarClientException
+.InvalidMessageException("Message is
definitely a duplicate"));
Review comment:
If users use the external sequence id and enable batch on producer, sequence
id 1,2,3,1 will happens if we do not the check, we can just throw an exception
when using the external sequence id?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on a change in pull request #5491: Fix message deduplicate issue while using external sequence id with batch produce
codelipenghui commented on a change in pull request #5491: Fix message
deduplicate issue while using external sequence id with batch produce
URL: https://github.com/apache/pulsar/pull/5491#discussion_r340939035
##
File path: pulsar-common/src/main/proto/PulsarApi.proto
##
@@ -394,6 +398,10 @@ message CommandSend {
optional int32 num_messages = 3 [default = 1];
optional uint64 txnid_least_bits = 4 [default = 0];
optional uint64 txnid_most_bits = 5 [default = 0];
+
+/// Add lowest and highest sequence id to support external sequence id
+optional uint64 lowest_sequence_id = 6 [default = 0];
+optional uint64 highest_sequence_id = 7 [default = 0];
Review comment:
Yes, we can only add a new last_sequence_id, will fix.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5465: [Pulsar Functions] User class constructor throws exception
Jennifer88huang commented on issue #5465: [Pulsar Functions] User class constructor throws exception URL: https://github.com/apache/pulsar/issues/5465#issuecomment-548198069 @wolfstudy Is it by design, or shall we add a note in the document? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5474: Support CDC Connector for MongoDB
Jennifer88huang commented on issue #5474: Support CDC Connector for MongoDB URL: https://github.com/apache/pulsar/issues/5474#issuecomment-548198480 @tuteng Shall we add this to code only, or add it to both code and doc? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5505: NPE occur when get partitioned topic stats
codelipenghui commented on issue #5505: NPE occur when get partitioned topic stats URL: https://github.com/apache/pulsar/issues/5505#issuecomment-548199902 @Jennifer88huang I will take a look this issue later This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on a change in pull request #5491: Fix message deduplicate issue while using external sequence id with batch produce
codelipenghui commented on a change in pull request #5491: Fix message
deduplicate issue while using external sequence id with batch produce
URL: https://github.com/apache/pulsar/pull/5491#discussion_r340947559
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java
##
@@ -76,6 +76,14 @@ default long getOriginalSequenceId() {
}
void completed(Exception e, long ledgerId, long entryId);
+
+default long getLowestSequenceId() {
Review comment:
It is in the inner class named PublishContext of Topic
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
