[GitHub] [pulsar] sky-big commented on issue #5534: Pulsar Operator On Kubernetes

2019-11-12 Thread GitBox
sky-big commented on issue #5534: Pulsar Operator On Kubernetes
URL: https://github.com/apache/pulsar/issues/5534#issuecomment-552779660
 
 
   Basically realized the function of pulsar operator,include pulsar dashboard, 
grafana, prometheus and so on[Pulsar 
Operator](https://github.com/sky-big/pulsar-operator),weclome to use and 
contribute.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sky-big edited a comment on issue #5534: Pulsar Operator On Kubernetes

2019-11-12 Thread GitBox
sky-big edited a comment on issue #5534: Pulsar Operator On Kubernetes
URL: https://github.com/apache/pulsar/issues/5534#issuecomment-552779660
 
 
   Basically realized the function of pulsar operator,include pulsar dashboard, 
grafana, prometheus and so on [Pulsar 
Operator](https://github.com/sky-big/pulsar-operator),weclome to use and 
contribute.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sky-big commented on issue #5534: Pulsar Operator On Kubernetes

2019-11-12 Thread GitBox
sky-big commented on issue #5534: Pulsar Operator On Kubernetes
URL: https://github.com/apache/pulsar/issues/5534#issuecomment-552780322
 
 
   Next step concern pulsar stateful component(include Bookeeper and Zookeeper).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sky-big edited a comment on issue #5534: Pulsar Operator On Kubernetes

2019-11-12 Thread GitBox
sky-big edited a comment on issue #5534: Pulsar Operator On Kubernetes
URL: https://github.com/apache/pulsar/issues/5534#issuecomment-552780322
 
 
   Next step concern pulsar stateful component(include Bookeeper and 
Zookeeper), use operator control complex stateful component.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #5572: Fix create consumer on partitioned topic while disable topic auto creation.

2019-11-12 Thread GitBox
codelipenghui commented on issue #5572: Fix create consumer on partitioned 
topic while disable topic auto creation.
URL: https://github.com/apache/pulsar/pull/5572#issuecomment-552786206
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar-manager] annotated tag v0.1.0-candidate-3 updated (2643a78 -> b44e8ab)

2019-11-12 Thread guangning
This is an automated email from the ASF dual-hosted git repository.

guangning pushed a change to annotated tag v0.1.0-candidate-3
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git.


*** WARNING: tag v0.1.0-candidate-3 was modified! ***

from 2643a78  (commit)
  to b44e8ab  (tag)
 tagging 2643a785804d7ba5e6f2aa14549a7e7294ee16ba (commit)
 replaces v0.1.0-candidate-2
  by guangning
  on Tue Nov 12 16:30:37 2019 +0800

- Log -
Release 0.1.0-candidate-3
-BEGIN PGP SIGNATURE-

iQFJBAABCAAzFiEEfLgyKwIZSFWNsgIYV3wHyoZ66RAFAl3Kba0VHGd1YW5nbmlu
Z0BhcGFjaGUub3JnAAoJEFd8B8qGeukQYZAIAKybMGtsysOfj/tOiAlFIoKxRvz4
jr8px5hZJeO2y4du9qHlPqFe8G8Aq7rpUs7A3lB2LX17JB7tpm+YEJY00tlCIB9P
pR0T/jn5Cj6In7CJEXHiNROn6jiv+dRmI816sJqFC4t+oOJ8x6cuSWhRLCThx2Am
CIPsMETV5buSKzC2MgFgI5B9ZJm3evA+2BB05JfXYhFCoHMx4YX4yLfXRWlsjDfW
2eWCRPfqH4lSjA8oa6Smuyk+hiIHCPIPOWi+q3CuK/uP5xxv9jUsmLRxWf62zoz8
kB30i7WfSp8RIZxlKTzASsB/qfgWUeEpJQLXuM3EYOBWru4a+Qi14rxDsnU=
=/+Pc
-END PGP SIGNATURE-
---


No new revisions were added by this update.

Summary of changes:



[pulsar-manager.wiki] branch master updated: Updated Release process (markdown)

2019-11-12 Thread guangning
This is an automated email from the ASF dual-hosted git repository.

guangning pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new ce77221  Updated Release process (markdown)
ce77221 is described below

commit ce77221cf35136bd6c3a2989ed0e5812cddbc507
Author: tuteng 
AuthorDate: Tue Nov 12 16:33:28 2019 +0800

Updated Release process (markdown)
---
 Release-process.md | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/Release-process.md b/Release-process.md
index 2e60ac2..68ee8ef 100644
--- a/Release-process.md
+++ b/Release-process.md
@@ -74,10 +74,13 @@ $ npm run build:prod
 Generate a release candidate package.
 
 ```
-$ mkdir -p temp-release
+$ mkdir -p temp-release temp-release/pulsar-manager
 $ cd temp-release
-$ cp -r ../build/libs/pulsar-manager.jar ../front-end/dist .
-$ tar -czvf apache-pulsar-manager-0.X.0-candidate-1-bin.tar.gz 
pulsar-manager.jar dist/*
+$ cp ../distribution/LICENSE.bin.txt pulsar-manager/LICENSE
+$ cp ../distribution/NOTICE.bin.txt pulsar-manager/NOTICE
+$ cp -r ../distribution/licenses pulsar-manager/
+$ cp -r ../build/distributions/pulsar-manager.tar ../front-end/dist 
pulsar-manager
+$ tar -czvf apache-pulsar-manager-0.X.0-candidate-1-bin.tar.gz 
pulsar-manager.tar pulsar-manager
 ```
 
 4. Sign and stage the artifacts



[GitHub] [pulsar] vishalananth07 commented on issue #5619: Is there an alternate address we can provide for the fields while setting up cluster metadata in case we do not have a DNS?

2019-11-12 Thread GitBox
vishalananth07 commented on issue #5619: Is there an alternate address we can 
provide for the fields while setting up cluster metadata in case we do not have 
a DNS?
URL: https://github.com/apache/pulsar/issues/5619#issuecomment-552790741
 
 
   Thanks for the response, also how do we refer to this cluster from the 
client program since we are not having a dns name?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5619: Is there an alternate address we can provide for the fields while setting up cluster metadata in case we do not have a DNS?

2019-11-12 Thread GitBox
sijie commented on issue #5619: Is there an alternate address we can provide 
for the fields while setting up cluster metadata in case we do not have a DNS?
URL: https://github.com/apache/pulsar/issues/5619#issuecomment-552792820
 
 
   @vishalananth07 I just showed you the service url.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar-manager.wiki] branch master updated: Updated Release process (markdown)

2019-11-12 Thread guangning
This is an automated email from the ASF dual-hosted git repository.

guangning pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new 60ba2af  Updated Release process (markdown)
60ba2af is described below

commit 60ba2afd7c7cc91450a902b77bed9cb0e15750a8
Author: tuteng 
AuthorDate: Tue Nov 12 16:44:43 2019 +0800

Updated Release process (markdown)
---
 Release-process.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Release-process.md b/Release-process.md
index 68ee8ef..5a4ab4e 100644
--- a/Release-process.md
+++ b/Release-process.md
@@ -92,9 +92,9 @@ gpg -b --armor 
apache-pulsar-manager-0.X.0-candidate-1-src.tar.gz
 shasum -a 512 apache-pulsar-manager-0.X.0-candidate-2-bin.tar.gz > 
apache-pulsar-manager-0.X.0-candidate-1-bin.tar.gz.sha512
 shasum -a 512 apache-pulsar-manager-0.X.0-candidate-2-src.tar.gz > 
apache-pulsar-manager-0.X.0-candidate-2-src.tar.gz.sha512
 svn co https://dist.apache.org/repos/dist/dev/pulsar/pulsar-manager 
pulsar-manager
-cd svn pulsar-manager
+cd pulsar-manager
 
-svn mkdir pulsar-manager-0.X.0-candidate-1
+mkdir pulsar-manager-0.X.0-candidate-1
 
 cd pulsar-manager-0.X.0-candidate-1
 cp apache-pulsar-manager-0.X.0-candidate-1-src.tar.gz .



svn commit: r36704 - /dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/

2019-11-12 Thread guangning
Author: guangning
Date: Tue Nov 12 08:49:39 2019
New Revision: 36704

Log:
Staging artifacts and signature for Pulsar Manager release 0.1.0

Added:
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/

dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-bin.tar.gz
   (with props)

dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-bin.tar.gz.asc

dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-bin.tar.gz.sha512

dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-src.tar.gz
   (with props)

dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-src.tar.gz.asc

dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-src.tar.gz.sha512

Added: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-bin.tar.gz
==
Binary file - no diff available.

Propchange: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-bin.tar.gz
--
svn:mime-type = application/octet-stream

Added: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-bin.tar.gz.asc
==
--- 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-bin.tar.gz.asc
 (added)
+++ 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-bin.tar.gz.asc
 Tue Nov 12 08:49:39 2019
@@ -0,0 +1,11 @@
+-BEGIN PGP SIGNATURE-
+
+iQEzBAABCAAdFiEEfLgyKwIZSFWNsgIYV3wHyoZ66RAFAl3Kbv8ACgkQV3wHyoZ6
+6RBoIggAi6hXASaRq5fERDN2IpPcK7a0bsx8vTuYdsKGKG10Xniyrfs8XQzw9xpR
+z2tpsP41TM8/QHnFfjlrKwYy+M1E0hY7tAdGEK1t4X+gNq/mJ4dslPZty0Pc9fta
+NAOSGTmZ+ZR1514/d6pyVTqGlDNWEC0QF0b7FlyN0JTf46kpxzohWhYIzzHAST/U
+NXeRxi9ur+aC+PAB/9bEwtE5C0XQo9XMT6w2GtNVOA274r3UwFQB4nheQ/tGRZqr
+qk0yjvsYZO0ri48rOmJEhL9HWUygZ2QWkMfCDvTqV/QMFDlTNSgugmMKtH/O2qGy
+1ZBBUuDbL1Qi8cQPeYEcd4XCjevICg==
+=pESI
+-END PGP SIGNATURE-

Added: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-bin.tar.gz.sha512
==
--- 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-bin.tar.gz.sha512
 (added)
+++ 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-bin.tar.gz.sha512
 Tue Nov 12 08:49:39 2019
@@ -0,0 +1 @@
+0dfbfc6e57b7d1b6d32865dd50e16d24e8201945b01575a3fa38093053fee955e8e6ddcfe6a94c290b7a14276c2724079af5b154b7e086a75da8bbb95eff7134
  apache-pulsar-manager-0.1.0-candidate-3-bin.tar.gz

Added: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-src.tar.gz
==
Binary file - no diff available.

Propchange: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-src.tar.gz
--
svn:mime-type = application/octet-stream

Added: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-src.tar.gz.asc
==
--- 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-src.tar.gz.asc
 (added)
+++ 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-src.tar.gz.asc
 Tue Nov 12 08:49:39 2019
@@ -0,0 +1,11 @@
+-BEGIN PGP SIGNATURE-
+
+iQEzBAABCAAdFiEEfLgyKwIZSFWNsgIYV3wHyoZ66RAFAl3Kbw0ACgkQV3wHyoZ6
+6RCHhQf9FKi4RboK4qwcRmxnsoOpie/zNFrVwoq0OsOCvLVVdWkHeb3alL8cS53C
+9S3EZcPTuYjkqVmaNfNJ/+Mc85EcfmMLoWzsx2tKtQfyRI5BpycLKLEwtOWAuuxz
++Ie41R18mJxqaFHITP1iXMzaLkjUrmGQKLY2qVJaUg9OOHCymUy4UIqDmgwSiVuI
++vJI45nx9c+9V9B+bVA94rBNNzq3t8qNGtrnWyNN2myxS/o8zlQ7XAbtC00NwpnV
+bwpsM6omB7FaoXAm2pfm3NsGhkP9M9oIYS9pKSEZx1PWGwMfNoD9zs+UGsJDKMX/
+Sj8ok0cyq7XlpRUKYS81sE/ZsIOqYg==
+=RxdF
+-END PGP SIGNATURE-

Added: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-src.tar.gz.sha512
==
--- 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-0.1.0-candidate-3-src.tar.gz.sha512
 (added)
+++ 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-3/apache-pulsar-manager-

[GitHub] [pulsar] sijie commented on issue #5617: update Maven version to 3.3.9+ in README.md

2019-11-12 Thread GitBox
sijie commented on issue #5617: update Maven version to 3.3.9+ in README.md
URL: https://github.com/apache/pulsar/pull/5617#issuecomment-552796226
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5605: fix prometheusMetrics export contains " bug

2019-11-12 Thread GitBox
sijie commented on issue #5605: fix prometheusMetrics export contains " bug
URL: https://github.com/apache/pulsar/pull/5605#issuecomment-552796639
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5571: Add epoch for connection handler to handle create producer timeout.

2019-11-12 Thread GitBox
sijie commented on issue #5571: Add epoch for connection handler to handle 
create producer timeout.
URL: https://github.com/apache/pulsar/pull/5571#issuecomment-552797361
 
 
   @merlimat @rdhabalia can you please review this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] tuteng commented on issue #5625: [Issue 5618] [docs]Correct python example

2019-11-12 Thread GitBox
tuteng commented on issue #5625: [Issue 5618] [docs]Correct python example
URL: https://github.com/apache/pulsar/pull/5625#issuecomment-552797710
 
 
   This contents of the file 
https://github.com/apache/pulsar/blob/master/site2/website/versioned_docs/version-2.4.1/functions-develop.md
 also seem to need updating.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5607: Upgrade bk version to 4.10.0

2019-11-12 Thread GitBox
sijie commented on issue #5607: Upgrade bk version to 4.10.0
URL: https://github.com/apache/pulsar/pull/5607#issuecomment-552797771
 
 
   run java8 tests
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] vishalananth07 commented on issue #5619: Is there an alternate address we can provide for the fields while setting up cluster metadata in case we do not have a DNS?

2019-11-12 Thread GitBox
vishalananth07 commented on issue #5619: Is there an alternate address we can 
provide for the fields while setting up cluster metadata in case we do not have 
a DNS?
URL: https://github.com/apache/pulsar/issues/5619#issuecomment-552798443
 
 
   Thanks sijie for the quick response!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] vishalananth07 closed issue #5619: Is there an alternate address we can provide for the fields while setting up cluster metadata in case we do not have a DNS?

2019-11-12 Thread GitBox
vishalananth07 closed issue #5619: Is there an alternate address we can provide 
for the fields while setting up cluster metadata in case we do not have a DNS?
URL: https://github.com/apache/pulsar/issues/5619
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5279: Support for python native logging from python wrapper

2019-11-12 Thread GitBox
sijie commented on issue #5279: Support for python native logging from python 
wrapper
URL: https://github.com/apache/pulsar/pull/5279#issuecomment-552800133
 
 
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5328: Increase the retries count for PulsarFunctionStateTest

2019-11-12 Thread GitBox
sijie commented on issue #5328: Increase the retries count for 
PulsarFunctionStateTest
URL: https://github.com/apache/pulsar/pull/5328#issuecomment-552800265
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar-manager.wiki] branch master updated: Updated Release Candidate Validation (markdown)

2019-11-12 Thread guangning
This is an automated email from the ASF dual-hosted git repository.

guangning pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new f3c8ba1  Updated Release Candidate Validation (markdown)
f3c8ba1 is described below

commit f3c8ba176d188bddbad6fa11fcae3584a70f94e1
Author: tuteng 
AuthorDate: Tue Nov 12 17:08:11 2019 +0800

Updated Release Candidate Validation (markdown)
---
 Release-Candidate-Validation.md | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Release-Candidate-Validation.md b/Release-Candidate-Validation.md
index 92162d0..cb3b8bb 100644
--- a/Release-Candidate-Validation.md
+++ b/Release-Candidate-Validation.md
@@ -5,8 +5,6 @@ Unzip the server distribution 
`apache-pulsar-manager--bin.tar.gz`. The
 ## Validation checksum
 
 ```
-gpg -b --armor apache-pulsar-manager--bin.tar.gz
-gpg -b --armor apache-pulsar-manager--bin.tar.gz
 shasum -a 512 apache-pulsar-manager--src.tar.gz
 shasum -a 512 apache-pulsar-manager--bin.tar.gz
 ```



[GitHub] [pulsar] jiazhai commented on issue #5610: Fluentd connector for Apache Pulsar

2019-11-12 Thread GitBox
jiazhai commented on issue #5610: Fluentd connector for Apache Pulsar
URL: https://github.com/apache/pulsar/issues/5610#issuecomment-552802647
 
 
   Thanks for the help @pradeep-mishra 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5612: Update Deprecated classes for MongoSink

2019-11-12 Thread GitBox
jiazhai commented on issue #5612:   Update Deprecated classes for MongoSink 
URL: https://github.com/apache/pulsar/issues/5612#issuecomment-552803359
 
 
   @huangdx0726 Would you like to contribute to it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5626: Memory leak of pulsar-function-go library regarding time.NewTimer()

2019-11-12 Thread GitBox
jiazhai commented on issue #5626: Memory leak of pulsar-function-go library 
regarding time.NewTimer()
URL: https://github.com/apache/pulsar/issues/5626#issuecomment-552804775
 
 
   @Sunkwan-Kwon Thanks for the fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar-manager.wiki] branch master updated: Updated Release Candidate Validation (markdown)

2019-11-12 Thread guangning
This is an automated email from the ASF dual-hosted git repository.

guangning pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new 8d8399f  Updated Release Candidate Validation (markdown)
8d8399f is described below

commit 8d8399fa3d89e8007c5b350ba48dbe6aaf7bf13e
Author: tuteng 
AuthorDate: Tue Nov 12 17:15:55 2019 +0800

Updated Release Candidate Validation (markdown)
---
 Release-Candidate-Validation.md | 20 +++-
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/Release-Candidate-Validation.md b/Release-Candidate-Validation.md
index cb3b8bb..6fbbef1 100644
--- a/Release-Candidate-Validation.md
+++ b/Release-Candidate-Validation.md
@@ -20,15 +20,9 @@ Compare the contents of file .sha512, .asc to ensure 
consistency.
 ## Validation bin.tar.gz
 
 ```
-mkdir -p apache-pulsar-manager-release-bin
-tar -zxvf apache-pulsar-manager-release-bin.tar.gz -C 
./apache-pulsar-manager-release-bin
-cd apache-pulsar-manager-
-```
-
-### Start Pulsar Manager backend service
-
-```
-java -jar pulsar-manager.jar 
+tar -zxvf apache-pulsar-manager-0.X.0-release-bin.tar.gz
+cd pulsar-manager
+tar -zxvf pulsar-manager.tar
 ```
 
 ### Start Pulsar Manager frontend service
@@ -117,6 +111,14 @@ nginx -t
 nginx
 ```
 
+### Start Pulsar Manager backend service
+
+```
+cd pulsar-manager/bin
+./pulsar-manager
+```
+
+
 5. Open the website http://localhost:9527 and log in to.
 Username: pulsar
 Password: pulsar



[GitHub] [pulsar] jiazhai commented on issue #5627: [Issue 5626][pulsar-function-go] Fix a memory leak of pulsar-function-go library regarding time.NewTimer()

2019-11-12 Thread GitBox
jiazhai commented on issue #5627: [Issue 5626][pulsar-function-go] Fix a memory 
leak of pulsar-function-go library regarding time.NewTimer()
URL: https://github.com/apache/pulsar/pull/5627#issuecomment-552804971
 
 
   run integration tests
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar-manager.wiki] branch master updated: Updated Release Candidate Validation (markdown)

2019-11-12 Thread guangning
This is an automated email from the ASF dual-hosted git repository.

guangning pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new 3738053  Updated Release Candidate Validation (markdown)
3738053 is described below

commit 37380532f8a2976fc0d9ef4f5ec4ac9003f95216
Author: tuteng 
AuthorDate: Tue Nov 12 17:17:14 2019 +0800

Updated Release Candidate Validation (markdown)
---
 Release-Candidate-Validation.md | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/Release-Candidate-Validation.md b/Release-Candidate-Validation.md
index 6fbbef1..c6f0b23 100644
--- a/Release-Candidate-Validation.md
+++ b/Release-Candidate-Validation.md
@@ -118,27 +118,27 @@ cd pulsar-manager/bin
 ./pulsar-manager
 ```
 
-
-5. Open the website http://localhost:9527 and log in to.
+### Validation
+1. Open the website http://localhost:9527 and log in to.
 Username: pulsar
 Password: pulsar
 
 
-6. Validate the login.
+2. Validate the login.
 
-7. Validate a new environment.
+3. Validate a new environment.
 
-8. Validate a tenant.
+4. Validate a tenant.
 
-9. Validate a namespace.
+5. Validate a namespace.
 
-10. Validate a topi.c
+6. Validate a topi.c
 
-11. Validate a subscription.
+7. Validate a subscription.
 
-12. Validate a cluster.
+8. Validate a cluster.
 
-13. Stop nginx.
+9. Stop nginx.
 
 ```
 nginx -s stop



[GitHub] [pulsar] codelipenghui commented on issue #5622: Expose include head message for durable consumers

2019-11-12 Thread GitBox
codelipenghui commented on issue #5622: Expose include head message for durable 
consumers
URL: https://github.com/apache/pulsar/pull/5622#issuecomment-552805328
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client.

2019-11-12 Thread GitBox
codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java 
client.
URL: https://github.com/apache/pulsar/pull/4621#issuecomment-552805862
 
 
   run cpp tests
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #5621: Data is not deleted after expiration due to connected readers

2019-11-12 Thread GitBox
codelipenghui commented on issue #5621: Data is not deleted after expiration 
due to connected readers
URL: https://github.com/apache/pulsar/pull/5621#issuecomment-552806232
 
 
   run java8 tests
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar-manager.wiki] branch master updated: Updated Release Candidate Validation (markdown)

2019-11-12 Thread guangning
This is an automated email from the ASF dual-hosted git repository.

guangning pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new f2397cc  Updated Release Candidate Validation (markdown)
f2397cc is described below

commit f2397cc8cc2fd596368c584a1f980e41e8df7c41
Author: tuteng 
AuthorDate: Tue Nov 12 17:22:48 2019 +0800

Updated Release Candidate Validation (markdown)
---
 Release-Candidate-Validation.md | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Release-Candidate-Validation.md b/Release-Candidate-Validation.md
index c6f0b23..bc5821f 100644
--- a/Release-Candidate-Validation.md
+++ b/Release-Candidate-Validation.md
@@ -22,7 +22,6 @@ Compare the contents of file .sha512, .asc to ensure 
consistency.
 ```
 tar -zxvf apache-pulsar-manager-0.X.0-release-bin.tar.gz
 cd pulsar-manager
-tar -zxvf pulsar-manager.tar
 ```
 
 ### Start Pulsar Manager frontend service
@@ -114,8 +113,8 @@ nginx
 ### Start Pulsar Manager backend service
 
 ```
-cd pulsar-manager/bin
-./pulsar-manager
+tar -zxvf pulsar-manager.tar
+./pulsar-manager/bin/pulsar-manager --logging.level.org.apache=INFO
 ```
 
 ### Validation



[GitHub] [pulsar] codelipenghui opened a new issue #5586: [DISCUSS] Sticky consumer reset cursor

2019-11-12 Thread GitBox
codelipenghui opened a new issue #5586: [DISCUSS] Sticky consumer reset cursor
URL: https://github.com/apache/pulsar/issues/5586
 
 
   **Is your feature request related to a problem? Please describe.**
   Sticky consumer consume messages with distributed to a fixed hash key range, 
also like a logical partition or a virtual partition. PR 
https://github.com/apache/pulsar/pull/5388 is added support for sticky consumer.
   
   However, we need to rethink the reset cursor of sticky consumer. Currently, 
if one sticky consumer reset cursor to a historical point, other sticky 
consumers cursor also be set. So it's better to explore a new approach for 
sticky consumer reset cursor which can avoid effect between sticky consumers.
   
   Added issue to track the approach of sticky consumer reset cursor, if anyone 
has ideas please add comments here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai closed issue #5586: [DISCUSS] Sticky consumer reset cursor

2019-11-12 Thread GitBox
jiazhai closed issue #5586: [DISCUSS] Sticky consumer reset cursor
URL: https://github.com/apache/pulsar/issues/5586
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] vishalananth07 opened a new issue #5630: Error when trying to run Producer-Consumer commands in a 2 node cluster

2019-11-12 Thread GitBox
vishalananth07 opened a new issue #5630: Error when trying to run 
Producer-Consumer commands in a 2 node cluster
URL: https://github.com/apache/pulsar/issues/5630
 
 
   **Describe the bug**
   Producer command
   ```
   $ bin/pulsar-client consume persistent://public/default/test -n 100 -s 
"consumer-test" -t "Exclusive"
   ```
   and Consumer command
   ```
   bin/pulsar-client consume persistent://public/default/test -n 100 -s 
"consumer-test" -t "Exclusive"
   ```
   are giving the following error messages:
   
   Producer error message:
   ```
   bin/pulsar-client produce persistent://public/default/test -n 1 -m "hello 
pulsar"
   14:28:32.171 [pulsar-client-io-1-1] INFO  
org.apache.pulsar.client.impl.ConnectionPool - [[id: 0x2c91e691, 
L:/192.168.1.13:35714 - R:192.168.1.5/192.168.1.5:6650]] Connected to server
   14:28:32.707 [pulsar-client-io-1-1] INFO  
org.apache.pulsar.client.impl.ProducerStatsRecorderImpl - Starting Pulsar 
producer perf with config: {
 "topicName" : "persistent://public/default/test",
 "producerName" : null,
 "sendTimeoutMs" : 3,
 "blockIfQueueFull" : false,
 "maxPendingMessages" : 1000,
 "maxPendingMessagesAcrossPartitions" : 5,
 "messageRoutingMode" : "RoundRobinPartition",
 "hashingScheme" : "JavaStringHash",
 "cryptoFailureAction" : "FAIL",
 "batchingMaxPublishDelayMicros" : 1000,
 "batchingMaxMessages" : 1000,
 "batchingEnabled" : true,
 "compressionType" : "NONE",
 "initialSequenceId" : null,
 "autoUpdatePartitions" : true,
 "properties" : { }
   }
   14:28:32.710 [pulsar-client-io-1-1] INFO  
org.apache.pulsar.client.impl.ProducerStatsRecorderImpl - Pulsar client config: 
{
 "serviceUrl" : "pulsar://192.168.1.13:6650,192.168.1.5:6650",
 "authPluginClassName" : null,
 "authParams" : null,
 "operationTimeoutMs" : 3,
 "statsIntervalSeconds" : 60,
 "numIoThreads" : 1,
 "numListenerThreads" : 1,
 "connectionsPerBroker" : 1,
 "useTcpNoDelay" : true,
 "useTls" : false,
 "tlsTrustCertsFilePath" : "",
 "tlsAllowInsecureConnection" : false,
 "tlsHostnameVerificationEnable" : false,
 "concurrentLookupRequest" : 5000,
 "maxLookupRequest" : 5,
 "maxNumberOfRejectedRequestPerConnection" : 50,
 "keepAliveIntervalSeconds" : 30,
 "connectionTimeoutMs" : 1,
 "requestTimeoutMs" : 6,
 "defaultBackoffIntervalNanos" : 1,
 "maxBackoffIntervalNanos" : 300
   }
   14:28:32.714 [pulsar-client-io-1-1] INFO  
org.apache.pulsar.client.impl.ConnectionPool - [[id: 0x6e57db24, 
L:/192.168.1.13:43896 - R:192.168.1.13/192.168.1.13:6650]] Connected to server
   14:28:32.734 [pulsar-client-io-1-1] INFO  
org.apache.pulsar.client.impl.ConnectionPool - [[id: 0x009288aa, 
L:/127.0.0.1:40736 - R:sundar-UX303UB/127.0.1.1:6650]] Connected to server
   14:28:32.741 [pulsar-client-io-1-1] INFO  
org.apache.pulsar.client.impl.ProducerImpl - [persistent://public/default/test] 
[null] Creating producer on cnx [id: 0x009288aa, L:/127.0.0.1:40736 - 
R:sundar-UX303UB/127.0.1.1:6650]
   14:28:32.864 [pulsar-client-io-1-1] INFO  
org.apache.pulsar.client.impl.ProducerImpl - [persistent://public/default/test] 
[test-cluster-1-0-3] Created producer on cnx [id: 0x009288aa, 
L:/127.0.0.1:40736 - R:sundar-UX303UB/127.0.1.1:6650]
   14:28:32.951 [main] WARN  com.scurrilous.circe.checksum.Crc32cIntChecksum - 
Failed to load Circe JNI library. Falling back to Java based CRC32c provider
   14:29:02.954 [pulsar-timer-4-1] INFO  
org.apache.pulsar.client.impl.ProducerImpl - [persistent://public/default/test] 
[test-cluster-1-0-3] Message send timed out. Failing 1 messages
   14:29:02.964 [main] ERROR org.apache.pulsar.client.cli.PulsarClientTool - 
Error while producing messages
   14:29:02.965 [main] ERROR org.apache.pulsar.client.cli.PulsarClientTool - 
Could not send message to broker within given timeout
   org.apache.pulsar.client.api.PulsarClientException$TimeoutException: Could 
not send message to broker within given timeout
at 
org.apache.pulsar.client.api.PulsarClientException.unwrap(PulsarClientException.java:247)
 ~[org.apache.pulsar-pulsar-client-api-2.4.1.jar:2.4.1]
at 
org.apache.pulsar.client.impl.ProducerBase.send(ProducerBase.java:86) 
~[org.apache.pulsar-pulsar-client-original-2.4.1.jar:2.4.1]
at 
org.apache.pulsar.client.impl.TypedMessageBuilderImpl.send(TypedMessageBuilderImpl.java:61)
 ~[org.apache.pulsar-pulsar-client-original-2.4.1.jar:2.4.1]
at 
org.apache.pulsar.client.impl.ProducerBase.send(ProducerBase.java:51) 
~[org.apache.pulsar-pulsar-client-original-2.4.1.jar:2.4.1]
at org.apache.pulsar.client.cli.CmdProduce.publish(CmdProduce.java:189) 
[org.apache.pulsar-pulsar-client-tools-2.4.1.jar:2.4.1]
at org.apache.pulsar.client.cli.CmdProduce.run(CmdProduce.java:169) 
[org.apache.pulsar-pulsar-client-tools-2.4.1.jar:2.4.1]
at 
org.apache.pulsar.client.cli.PulsarClie

[GitHub] [pulsar] codelipenghui opened a new issue #5631: Topic auto creation for non-persistent topic.

2019-11-12 Thread GitBox
codelipenghui opened a new issue #5631: Topic auto creation for non-persistent 
topic.
URL: https://github.com/apache/pulsar/issues/5631
 
 
   **Is your feature request related to a problem? Please describe.**
   Currently, we can disable the topic auto creation at broker side, but for 
non-persistent topic, disable topic auto creation isn't works well.
   
   Unlike persistent topic, we need to create mledger znode in zookeeper, 
non-persistent topic only maintained in broker, so must allow topic auto 
creation for non-persistent topic now.
   
   But we also need to disable the non-persistent topic auto creation for topic 
management.
   
   **Describe the solution you'd like**
   Add support for disable non-persistent topic auto creation.
   
   **Describe alternatives you've considered**
   Since we just need to store the created non-persistent topics, i'd like to 
use a system topic to store the non-persistent topic create or delete log and 
the broker cache the non-persistent topics which is belongs to owned bundles. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #5631: Topic auto creation for non-persistent topic.

2019-11-12 Thread GitBox
codelipenghui commented on issue #5631: Topic auto creation for non-persistent 
topic.
URL: https://github.com/apache/pulsar/issues/5631#issuecomment-552811865
 
 
   relate to #5572


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar-manager.wiki] branch master updated: Updated Release Candidate Validation (markdown)

2019-11-12 Thread guangning
This is an automated email from the ASF dual-hosted git repository.

guangning pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new ae3d0e9  Updated Release Candidate Validation (markdown)
ae3d0e9 is described below

commit ae3d0e9fccaa3c5b07a3c4282a1d0c3dfb328d40
Author: tuteng 
AuthorDate: Tue Nov 12 17:36:25 2019 +0800

Updated Release Candidate Validation (markdown)
---
 Release-Candidate-Validation.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Release-Candidate-Validation.md b/Release-Candidate-Validation.md
index bc5821f..f1b3dca 100644
--- a/Release-Candidate-Validation.md
+++ b/Release-Candidate-Validation.md
@@ -150,7 +150,8 @@ nginx -s stop
 tar -zxvf apache-pulsar-manager--src.tar.gz
 cd pulsar-manager-release
 ./gradlew build
-java -jar build/libs/pulsar-manager-.jar
+unzip build/distributions/pulsar-manager-0.X.0-release.zip
+./pulsar-manager-0.X.0-release/bin/pulsar-manager-0.X.0-release 
--logging.level.org.apache=INFO
 ```
 
 ### Validation frontend



[GitHub] [pulsar] huangdx0726 commented on issue #5612: Update Deprecated classes for MongoSink

2019-11-12 Thread GitBox
huangdx0726 commented on issue #5612:   Update Deprecated classes for MongoSink 
URL: https://github.com/apache/pulsar/issues/5612#issuecomment-552814752
 
 
   OK,I’ll  try
   
   
   
   ---Original---
   From: "Jia Zhai"

[GitHub] [pulsar] tuteng commented on a change in pull request #5590: [Issue 5474][pulsar-io-debezium] Support CDC Connector for MongoDB

2019-11-12 Thread GitBox
tuteng commented on a change in pull request #5590: [Issue 
5474][pulsar-io-debezium] Support CDC Connector for MongoDB
URL: https://github.com/apache/pulsar/pull/5590#discussion_r345105919
 
 

 ##
 File path: 
tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/DebeziumMongoDbContainer.java
 ##
 @@ -0,0 +1,51 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.tests.integration.containers;
+
+import org.testcontainers.containers.wait.strategy.HostPortWaitStrategy;
+
+public class DebeziumMongoDbContainer extends 
ChaosContainer {
+
+public static final String NAME = "debezium-mongodb-example";
+
+public static final Integer[] PORTS = { 27017 };
+private static final String IMAGE_NAME = "debezium/example-mongodb:latest";
 
 Review comment:
   I haven't tested it on windows yet. If it's on mac or linux, use the 
following steps:
   
   ```
   mvn install -DskipTests -Pdocker
   mvn test -pl  tests/integration -DintegrationTests 
-DredirectTestOutputToFile=false 
-Dtest=org.apache.pulsar.tests.integration.functions.PulsarFunctionsProcessTest
   ```
   
   You can't work locally, you can change it according to my comment, I think 
it can pass the integration test.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] tuteng commented on a change in pull request #5590: [Issue 5474][pulsar-io-debezium] Support CDC Connector for MongoDB

2019-11-12 Thread GitBox
tuteng commented on a change in pull request #5590: [Issue 
5474][pulsar-io-debezium] Support CDC Connector for MongoDB
URL: https://github.com/apache/pulsar/pull/5590#discussion_r345105919
 
 

 ##
 File path: 
tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/DebeziumMongoDbContainer.java
 ##
 @@ -0,0 +1,51 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.tests.integration.containers;
+
+import org.testcontainers.containers.wait.strategy.HostPortWaitStrategy;
+
+public class DebeziumMongoDbContainer extends 
ChaosContainer {
+
+public static final String NAME = "debezium-mongodb-example";
+
+public static final Integer[] PORTS = { 27017 };
+private static final String IMAGE_NAME = "debezium/example-mongodb:latest";
 
 Review comment:
   I haven't tested it on windows yet. If it's on mac or linux, use the 
following steps:
   
   ```
   mvn install -DskipTests -Pdocker
   mvn test -pl  tests/integration -DintegrationTests 
-DredirectTestOutputToFile=false 
-Dtest=org.apache.pulsar.tests.integration.functions.PulsarFunctionsProcessTest
   ```
   
   If you can't work locally, you can change it according to my comment, I 
think it can pass the integration test.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Jennifer88huang commented on issue #5625: [Issue 5618] [docs]Correct python example

2019-11-12 Thread GitBox
Jennifer88huang commented on issue #5625: [Issue 5618] [docs]Correct python 
example
URL: https://github.com/apache/pulsar/pull/5625#issuecomment-552818051
 
 
   @tuteng Thanks for your reminder. If the content in this PR is correct, i'll 
update the one in version 2.4.1.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] huangdx0726 commented on issue #5624: [Issue 4601, 5215][pulsar-io-jdbc]Support almost all jdbc source sink

2019-11-12 Thread GitBox
huangdx0726 commented on issue #5624: [Issue 4601,5215][pulsar-io-jdbc]Support  
almost all  jdbc source sink
URL: https://github.com/apache/pulsar/pull/5624#issuecomment-552820055
 
 
   Do we provide driver package  ? Isn't it supposed to be provided by users?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5624: [Issue 4601, 5215][pulsar-io-jdbc]Support almost all jdbc source sink

2019-11-12 Thread GitBox
sijie commented on issue #5624: [Issue 4601,5215][pulsar-io-jdbc]Support  
almost all  jdbc source sink
URL: https://github.com/apache/pulsar/pull/5624#issuecomment-552820595
 
 
   > Do we provide driver package ? Isn't it supposed to be provided by users?
   
   How do users provide the driver package? For example, if I have a Postgres 
database, how do I run the JDBC connector?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5621: Data is not deleted after expiration due to connected readers

2019-11-12 Thread GitBox
sijie commented on issue #5621: Data is not deleted after expiration due to 
connected readers
URL: https://github.com/apache/pulsar/pull/5621#issuecomment-552822680
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] tuteng commented on issue #5624: [Issue 4601, 5215][pulsar-io-jdbc]Support almost all jdbc source sink

2019-11-12 Thread GitBox
tuteng commented on issue #5624: [Issue 4601,5215][pulsar-io-jdbc]Support  
almost all  jdbc source sink
URL: https://github.com/apache/pulsar/pull/5624#issuecomment-552823631
 
 
   I think if java's classloader mechanism can be used to load these packages, 
then the user should provide a driver parameter for the connector to load this 
jar package. Of course, for different databases, add, delete, update and the 
query should also be somewhat different, which may require separate processing 
and additional tests. This is only my idea, and I have not tested it yet.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] tuteng commented on issue #5629: [pulsar-io] hbase sink avoid flushing hbase table

2019-11-12 Thread GitBox
tuteng commented on issue #5629: [pulsar-io] hbase sink avoid flushing hbase 
table
URL: https://github.com/apache/pulsar/pull/5629#issuecomment-552824204
 
 
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] tuteng commented on issue #5629: [pulsar-io] hbase sink avoid flushing hbase table

2019-11-12 Thread GitBox
tuteng commented on issue #5629: [pulsar-io] hbase sink avoid flushing hbase 
table
URL: https://github.com/apache/pulsar/pull/5629#issuecomment-552824145
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5624: [Issue 4601, 5215][pulsar-io-jdbc]Support almost all jdbc source sink

2019-11-12 Thread GitBox
sijie commented on issue #5624: [Issue 4601,5215][pulsar-io-jdbc]Support  
almost all  jdbc source sink
URL: https://github.com/apache/pulsar/pull/5624#issuecomment-552824860
 
 
   my question is - as a user, how do I upload the driver or configure the 
driver in order to use this JDBC connector? This is the first question we have 
to answer for the users. but I don't see how does this pull request address it. 
So can you show me an example?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] huangdx0726 commented on issue #5624: [Issue 4601, 5215][pulsar-io-jdbc]Support almost all jdbc source sink

2019-11-12 Thread GitBox
huangdx0726 commented on issue #5624: [Issue 4601,5215][pulsar-io-jdbc]Support  
almost all  jdbc source sink
URL: https://github.com/apache/pulsar/pull/5624#issuecomment-552825074
 
 
   I think add the YAML file and the  Related packages  to the connectors  
folder,Isn't working now?May be i got it wrong。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5624: [Issue 4601, 5215][pulsar-io-jdbc]Support almost all jdbc source sink

2019-11-12 Thread GitBox
sijie commented on issue #5624: [Issue 4601,5215][pulsar-io-jdbc]Support  
almost all  jdbc source sink
URL: https://github.com/apache/pulsar/pull/5624#issuecomment-552826109
 
 
   @huangdx0726 
   
   > I think add the YAML file and the Related packages to the connectors 
folder,Isn't working now?May be i got it wrong。
   
   Not sure if it can work or not.
   
   1) We need a tutorial or an example to show this approach can work.
   2) We need documentation to let users know how to configure it.
   
   I don't see this pull request cover any of them.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] lsy180829 opened a new pull request #5632: Fix Issue 5614, Deprecate brokerServicePurgeInactiveFrequencyInSeconds

2019-11-12 Thread GitBox
lsy180829 opened a new pull request #5632: Fix Issue 5614, Deprecate 
brokerServicePurgeInactiveFrequencyInSeconds
URL: https://github.com/apache/pulsar/pull/5632
 
 
   ### Motivation
   
   Fixes #5614 
   
   *Explain here the context, and why you're making that change. What is the 
problem you're trying to solve.*
   
   ### Modifications
   
   Deprecate brokerServicePurgeInactiveFrequencyInSeconds.
   Modify many files, includes .java, .conf, .md. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] tuteng commented on issue #5629: [pulsar-io] hbase sink avoid flushing hbase table

2019-11-12 Thread GitBox
tuteng commented on issue #5629: [pulsar-io] hbase sink avoid flushing hbase 
table
URL: https://github.com/apache/pulsar/pull/5629#issuecomment-552841505
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] hangc0276 commented on issue #5605: fix prometheusMetrics export contains " bug

2019-11-12 Thread GitBox
hangc0276 commented on issue #5605: fix prometheusMetrics export contains " bug
URL: https://github.com/apache/pulsar/pull/5605#issuecomment-552843606
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] candlerb commented on a change in pull request #5549: Fix documentation: how to start server for cpp tests

2019-11-12 Thread GitBox
candlerb commented on a change in pull request #5549: Fix documentation: how to 
start server for cpp tests
URL: https://github.com/apache/pulsar/pull/5549#discussion_r345141505
 
 

 ##
 File path: pulsar-client-cpp/README.md
 ##
 @@ -202,8 +202,7 @@ ${PULSAR_PATH}/pulsar-client-cpp/tests/
 
 # Execution
 # Start standalone broker
-export 
PULSAR_STANDALONE_CONF=${PULSAR_PATH}/pulsar-client-cpp/tests/standalone.conf
-${PULSAR_PATH}/bin/pulsar standalone
+${PULSAR_PATH}/pulsar-test-service-start.sh
 
 Review comment:
   Added, and rebased to master and repushed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] zymap commented on issue #5615: Fix hangs when type invalid args at command-line

2019-11-12 Thread GitBox
zymap commented on issue #5615:  Fix hangs when type invalid args at 
command-line
URL: https://github.com/apache/pulsar/pull/5615#issuecomment-552856935
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] vishalananth07 commented on issue #5630: Error when trying to run Producer-Consumer commands in a 2 node cluster

2019-11-12 Thread GitBox
vishalananth07 commented on issue #5630: Error when trying to run 
Producer-Consumer commands in a 2 node cluster
URL: https://github.com/apache/pulsar/issues/5630#issuecomment-552867124
 
 
   I noticed that the Broker process stops automatically after 2 minutes on one 
node, but on the other node its running fine. Also the node in which the broker 
stops is not able to produce and consume, but the other node is able to run as 
consumer alone but fails when it tries to run the producer.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] hangc0276 commented on issue #5617: update Maven version to 3.3.9+ in README.md

2019-11-12 Thread GitBox
hangc0276 commented on issue #5617: update Maven version to 3.3.9+ in README.md
URL: https://github.com/apache/pulsar/pull/5617#issuecomment-552867885
 
 
   run java8 test
   run integration test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] hangc0276 commented on issue #5605: fix prometheusMetrics export contains " bug

2019-11-12 Thread GitBox
hangc0276 commented on issue #5605: fix prometheusMetrics export contains " bug
URL: https://github.com/apache/pulsar/pull/5605#issuecomment-552868245
 
 
   run java8 test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5605: fix prometheusMetrics export contains " bug

2019-11-12 Thread GitBox
jiazhai commented on issue #5605: fix prometheusMetrics export contains " bug
URL: https://github.com/apache/pulsar/pull/5605#issuecomment-552890878
 
 
   run java8 test
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar] branch master updated (0279431 -> 3e7cb68)

2019-11-12 Thread sijie
This is an automated email from the ASF dual-hosted git repository.

sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from 0279431  [Docs] Add admin api docs of Pulsar Functions (#5593)
 add 3e7cb68  Data is not deleted after expiration due to connected readers 
(#5621)

No new revisions were added by this update.

Summary of changes:
 .../bookkeeper/mledger/impl/EntryCacheImpl.java|  6 +++
 .../mledger/impl/ManagedCursorContainer.java   |  2 +-
 .../bookkeeper/mledger/impl/ManagedCursorImpl.java |  4 +-
 .../bookkeeper/mledger/impl/ManagedLedgerImpl.java | 12 +++---
 .../mledger/impl/NonDurableCursorImpl.java |  8 +++-
 .../mledger/impl/NonDurableCursorTest.java | 47 +-
 .../broker/service/persistent/PersistentTopic.java |  3 +-
 .../buffer/impl/PersistentTransactionBuffer.java   |  3 +-
 8 files changed, 71 insertions(+), 14 deletions(-)



[GitHub] [pulsar] sijie merged pull request #5621: Data is not deleted after expiration due to connected readers

2019-11-12 Thread GitBox
sijie merged pull request #5621: Data is not deleted after expiration due to 
connected readers
URL: https://github.com/apache/pulsar/pull/5621
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie closed issue #5558: When we use the pulsar-admin.sh script to delete partitioned topic, it will throw the http error, error code is 500

2019-11-12 Thread GitBox
sijie closed issue #5558: When we use the pulsar-admin.sh script to delete 
partitioned topic, it will throw the http error, error code is 500
URL: https://github.com/apache/pulsar/issues/5558
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client.

2019-11-12 Thread GitBox
codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java 
client.
URL: https://github.com/apache/pulsar/pull/4621#issuecomment-552895816
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #5628: Fix: Netty threads may still linger after client close

2019-11-12 Thread GitBox
codelipenghui commented on issue #5628: Fix: Netty threads may still linger 
after client close
URL: https://github.com/apache/pulsar/pull/5628#issuecomment-552898018
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Jennifer88huang commented on issue #5625: [Issue 5618] [docs]Correct python example

2019-11-12 Thread GitBox
Jennifer88huang commented on issue #5625: [Issue 5618] [docs]Correct python 
example
URL: https://github.com/apache/pulsar/pull/5625#issuecomment-552898806
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] raghavi92 opened a new issue #5633: Support Avro schema from Debezium source connector

2019-11-12 Thread GitBox
raghavi92 opened a new issue #5633: Support Avro schema from Debezium source 
connector
URL: https://github.com/apache/pulsar/issues/5633
 
 
   **Describe the bug**
   Currently the Debezium postgres source produces KeyValueSchema to the 
topics. Support is required for Avro schema type.
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. The connector configuration I used for the debezium source connector is:
   
   > tenant: "public"
   namespace: "default"
   name: "debezium-postgres-source"
   topicName: "debezium-postgres-topic"
   archive: "connectors/pulsar-io-debezium-postgres-2.5.0-SNAPSHOT.nar"
   schemaType: "avro"
   parallelism: 1
   configs:
 database.hostname: "localhost"
 database.port: "5432"
 database.user: "hq_gosecure"
 database.password: "postgres"
 database.dbname: "hq_gosecure"
 database.server.name: "dbserver1"
 plugin.name: "wal2json"
 pulsar.service.url: "pulsar://127.0.0.1:6650"
   
   
   2. Start the connector using the command :
   `bin/pulsar-admin sources localrun --source-config-file 
conf/debezium-postgres-source-config.yaml`
   3. See error
   
   **Expected behavior**
   The connector should start producing messages in avro schema. But I'm 
getting the following error:
   `19:15:12.353 [main] INFO  org.apache.pulsar.functions.LocalRunner - 
RuntimeSpawner quit because of
   org.apache.avro.AvroRuntimeException: 
avro.shaded.com.google.common.util.concurrent.UncheckedExecutionException: 
org.apache.avro.AvroTypeException: Unknown type: K
at 
org.apache.avro.specific.SpecificData.getSchema(SpecificData.java:227) 
~[org.apache.avro-avro-1.8.2.jar:1.8.2]
at 
org.apache.pulsar.client.impl.schema.StructSchema.createAvroSchema(StructSchema.java:136)
 ~[pulsar-client-original-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
at 
org.apache.pulsar.client.impl.schema.StructSchema.parseSchemaInfo(StructSchema.java:149)
 ~[pulsar-client-original-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
at 
org.apache.pulsar.client.impl.schema.AvroSchema.of(AvroSchema.java:90) 
~[pulsar-client-original-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
at 
org.apache.pulsar.functions.source.TopicSchema.newSchemaInstance(TopicSchema.java:144)
 ~[pulsar-functions-instance-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
at 
org.apache.pulsar.functions.source.TopicSchema.newSchemaInstance(TopicSchema.java:189)
 ~[pulsar-functions-instance-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
at 
org.apache.pulsar.functions.source.TopicSchema.newSchemaInstance(TopicSchema.java:209)
 ~[pulsar-functions-instance-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
at 
org.apache.pulsar.functions.source.TopicSchema.lambda$getSchema$0(TopicSchema.java:65)
 ~[pulsar-functions-instance-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
at java.util.HashMap.computeIfAbsent(HashMap.java:1127) ~[?:1.8.0_201]
at 
org.apache.pulsar.functions.source.TopicSchema.getSchema(TopicSchema.java:65) 
~[pulsar-functions-instance-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
at 
org.apache.pulsar.functions.sink.PulsarSink.initializeSchema(PulsarSink.java:327)
 ~[pulsar-functions-instance-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
at 
org.apache.pulsar.functions.sink.PulsarSink.open(PulsarSink.java:255) 
~[pulsar-functions-instance-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
at 
org.apache.pulsar.functions.instance.JavaInstanceRunnable.setupOutput(JavaInstanceRunnable.java:787)
 ~[pulsar-functions-instance-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
at 
org.apache.pulsar.functions.instance.JavaInstanceRunnable.setupJavaInstance(JavaInstanceRunnable.java:213)
 ~[pulsar-functions-instance-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
at 
org.apache.pulsar.functions.instance.JavaInstanceRunnable.run(JavaInstanceRunnable.java:244)
 ~[pulsar-functions-instance-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
at java.lang.Thread.run(Thread.java:748) ~[?:1.8.0_201]
   Caused by: 
avro.shaded.com.google.common.util.concurrent.UncheckedExecutionException: 
org.apache.avro.AvroTypeException: Unknown type: K
at 
avro.shaded.com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2234)
 ~[org.apache.avro-avro-1.8.2.jar:1.8.2]
at 
avro.shaded.com.google.common.cache.LocalCache.get(LocalCache.java:3965) 
~[org.apache.avro-avro-1.8.2.jar:1.8.2]
at 
avro.shaded.com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3969) 
~[org.apache.avro-avro-1.8.2.jar:1.8.2]
at 
avro.shaded.com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4829)
 ~[org.apache.avro-avro-1.8.2.jar:1.8.2]
at 
org.apache.avro.specific.SpecificData.getSchema(SpecificData.java:225) 
~[org.apache.avro-avro-1.8.2.jar:1.8.2]
... 15 more
   Caused by: org.apache.avro.AvroTypeException: Unknown type: K
at 
org.apache.avro.specific.SpecificData.createSchema(SpecificData.java:292) 
~[org.apache.avro-avro-1.8.2.jar:1.8.2]
at 
org.apache.avro.reflect

[GitHub] [pulsar] sijie commented on issue #5630: Error when trying to run Producer-Consumer commands in a 2 node cluster

2019-11-12 Thread GitBox
sijie commented on issue #5630: Error when trying to run Producer-Consumer 
commands in a 2 node cluster
URL: https://github.com/apache/pulsar/issues/5630#issuecomment-552902144
 
 
   > org.apache.bookkeeper.client.BKException$BKNotEnoughBookiesException: Not 
enough non-faulty bookies available
   
   It indicates that you don't have enough bookies. use `bookkeeper shell 
listbookies` to list the bookies. make sure you have enough bookies, because by 
default you need at least 2 bookies.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] zymap commented on issue #5615: Fix hangs when type invalid args at command-line

2019-11-12 Thread GitBox
zymap commented on issue #5615:  Fix hangs when type invalid args at 
command-line
URL: https://github.com/apache/pulsar/pull/5615#issuecomment-552909512
 
 
   run java8 tests
   run integration tests
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] bry00 opened a new issue #5634: Python consumer does not accept receiver_queue_size=0

2019-11-12 Thread GitBox
bry00 opened a new issue #5634: Python consumer does not accept 
receiver_queue_size=0
URL: https://github.com/apache/pulsar/issues/5634
 
 
   **Describe the bug**
   Python client does not accept receiver queue size equal to 0, but according 
to 
[documentation](https://pulsar.apache.org/docs/v2.0.1-incubating/cookbooks/message-queue#client-configuration-changes):
   > If you’d like to have tight control over message dispatching across 
consumers, set the consumers’ receiver queue size very low (potentially even to 
0 if necessary).
   while other clients (e.g. C++ and Java clients) accept receiver queue size 
equal to 0 and work according to documentation.
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Run the following Python code:
   
   ```python
   #!/usr/bin/env python3
   import sys
   import pulsar
   
   client = pulsar.Client('pulsar://localhost:6650')
   consumer = client.subscribe('abcd', subscription_name='xyz',
   consumer_type=pulsar.ConsumerType.Shared,
   receiver_queue_size=0)
   
   msg = consumer.receive()
   print("Received message: %s" % msg.data(), flush=True)
   
   consumer.acknowledge(msg)
   client.close()
   
   ```
   
   2. See error
   
   **Expected behavior**
   Python client consumer API (` client.subscribe`) should accept parameter 
`receiver_queue_size=0` as described in 
[documentation](https://pulsar.apache.org/docs/v2.0.1-incubating/cookbooks/message-queue#client-configuration-changes)
 and as function correctly for other clients (C++, Java).
   
   **Screenshots**
   
   ```console
   2019-11-12 15:11:57.331 INFO  Client:88 | Subscribing on Topic :abcd
   2019-11-12 15:11:57.331 INFO  ConnectionPool:72 | Created connection for 
pulsar://localhost:6650
   2019-11-12 15:11:57.333 INFO  ClientConnection:324 | [[::1]:51100 -> 
[::1]:6650] Connected to broker
   2019-11-12 15:11:57.398 INFO  HandlerBase:52 | 
[persistent://public/default/abcd, xyz, 0] Getting connection from pool
   2019-11-12 15:11:57.423 INFO  ConnectionPool:72 | Created connection for 
pulsar://cfc0ca6995fc:6650
   2019-11-12 15:11:57.424 INFO  ClientConnection:326 | [[::1]:51101 -> 
[::1]:6650] Connected to broker through proxy. Logical broker: 
pulsar://cfc0ca6995fc:6650
   2019-11-12 15:11:57.684 INFO  ConsumerImpl:170 | 
[persistent://public/default/abcd, xyz, 0] Created consumer on broker 
[[::1]:51101 -> [::1]:6650]
   2019-11-12 15:11:57.684 WARN  ConsumerImpl:631 | 
[persistent://public/default/abcd, xyz, 0] Can't use this function if the queue 
size is 0
   Traceback (most recent call last):
 File "tst.py", line 10, in 
   msg = consumer.receive()
 File "/python3.7/site-packages/pulsar/__init__.py", line 930, in receive
   msg = self._consumer.receive()
   Exception: Pulsar error: InvalidConfiguration
   ```
   
   **Desktop (please complete the following information):**
- OS: macOS Catalina (v: 10.15.1)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] vishalananth07 commented on issue #5630: Error when trying to run Producer-Consumer commands in a 2 node cluster

2019-11-12 Thread GitBox
vishalananth07 commented on issue #5630: Error when trying to run 
Producer-Consumer commands in a 2 node cluster
URL: https://github.com/apache/pulsar/issues/5630#issuecomment-552920177
 
 
   I have run bookkeeper on two nodes


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] huangdx0726 opened a new pull request #5635: [Issue 5612]Update Deprecated classes

2019-11-12 Thread GitBox
huangdx0726 opened a new pull request #5635: [Issue 5612]Update Deprecated 
classes
URL: https://github.com/apache/pulsar/pull/5635
 
 
   
   Fixes #5612 
   
   
   ### Motivation
   for MongoSink 
   
   ### Modifications
replace ”com.mongodb.async.client” package with 
”com.mongodb.reactivestreams.client.”
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client.

2019-11-12 Thread GitBox
codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java 
client.
URL: https://github.com/apache/pulsar/pull/4621#issuecomment-552921813
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] huangdx0726 commented on issue #5624: [Issue 4601, 5215][pulsar-io-jdbc]Support almost all jdbc source sink

2019-11-12 Thread GitBox
huangdx0726 commented on issue #5624: [Issue 4601,5215][pulsar-io-jdbc]Support  
almost all  jdbc source sink
URL: https://github.com/apache/pulsar/pull/5624#issuecomment-552930632
 
 
   em,I see the documentation ,may be add dependency of driver packages in 
pom.xml file in current  approach  of pulsar source。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] tuteng commented on issue #5629: [pulsar-io] hbase sink avoid flushing hbase table

2019-11-12 Thread GitBox
tuteng commented on issue #5629: [pulsar-io] hbase sink avoid flushing hbase 
table
URL: https://github.com/apache/pulsar/pull/5629#issuecomment-552933945
 
 
   run integration tests
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer

2019-11-12 Thread GitBox
sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting 
in pulsar producer
URL: https://github.com/apache/pulsar/pull/5045#issuecomment-552945867
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #4621: [PIP-38] Support batch receive in java client.

2019-11-12 Thread GitBox
sijie commented on issue #4621: [PIP-38] Support batch receive in java client.
URL: https://github.com/apache/pulsar/pull/4621#issuecomment-552946652
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] frank-dkvan commented on issue #3208: Is state shared by function instances?

2019-11-12 Thread GitBox
frank-dkvan commented on issue #3208: Is state shared by function instances?
URL: https://github.com/apache/pulsar/issues/3208#issuecomment-552951908
 
 
   > Yes, the state is shared between the two instances. When you do a put/get 
inside the Context inside a function the real-key is the fully qualified 
function name + the key that you specify. This means that the key is visible to 
not just other instances of the function, but to other functions as well. 
However the Context api currently doesnt provide any way of accessing some 
other functions' keys.
   
   If I want to read  states from the other functions, which API can help with 
this?  since context API doesn't support this.
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie opened a new pull request #5636: [tests] remove redundant check in PulsarFunctionE2ESecurityTest

2019-11-12 Thread GitBox
sijie opened a new pull request #5636: [tests] remove redundant check in 
PulsarFunctionE2ESecurityTest
URL: https://github.com/apache/pulsar/pull/5636
 
 
   *Motivation*
   
   We use `retryStrategically` to wait for a condition being met.
   There is no need to check the condition again if the condition is already 
met.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5605: fix prometheusMetrics export contains " bug

2019-11-12 Thread GitBox
sijie commented on issue #5605: fix prometheusMetrics export contains " bug
URL: https://github.com/apache/pulsar/pull/5605#issuecomment-552969702
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sleungtoast commented on issue #5395: Enable/disable allowAutoTopicCreation per namespace

2019-11-12 Thread GitBox
sleungtoast commented on issue #5395: Enable/disable allowAutoTopicCreation per 
namespace
URL: https://github.com/apache/pulsar/issues/5395#issuecomment-552975058
 
 
   @huangdx0726 Hmm that could work, but if my app had admin privileges 
already, I could just have it create topics as an admin before using them, and 
I wouldn't have to temporarily turn on auto topic creation just so this single 
app can do so. 
   What I need is for a single non-admin user be able to create topics on a 
namespace, but nobody else can.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jerrypeng commented on issue #5628: Fix: Netty threads may still linger after client close

2019-11-12 Thread GitBox
jerrypeng commented on issue #5628: Fix: Netty threads may still linger after 
client close
URL: https://github.com/apache/pulsar/pull/5628#issuecomment-553028466
 
 
   rerun integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar-client-go] merlimat merged pull request #94: Added negative acks tracker and integration

2019-11-12 Thread GitBox
merlimat merged pull request #94: Added negative acks tracker and integration
URL: https://github.com/apache/pulsar-client-go/pull/94
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar-client-go] branch master updated: Added negative acks tracker and integration (#94)

2019-11-12 Thread mmerli
This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git


The following commit(s) were added to refs/heads/master by this push:
 new 71bec03  Added negative acks tracker and integration (#94)
71bec03 is described below

commit 71bec030ccd7bc19014d2211ec04487bdb66dac8
Author: Matteo Merli 
AuthorDate: Tue Nov 12 11:07:06 2019 -0800

Added negative acks tracker and integration (#94)

* Added negative acks tracker and integration

* Fixed race condition in tests

* Fixed return after warning

* fixed format
---
 examples/consumer-listener/consumer-listener.go |   4 +-
 examples/consumer/consumer.go   |   4 +-
 perf/perf-consumer.go   |   4 +-
 pulsar/consumer.go  |  27 +-
 pulsar/consumer_impl.go |  46 +++--
 pulsar/consumer_partition.go|  74 ++-
 pulsar/consumer_test.go |  27 ++
 pulsar/impl_producer.go |   6 +-
 pulsar/negative_acks_tracker.go | 110 +
 pulsar/negative_acks_tracker_test.go| 121 
 pulsar/producer_test.go |   3 +-
 11 files changed, 358 insertions(+), 68 deletions(-)

diff --git a/examples/consumer-listener/consumer-listener.go 
b/examples/consumer-listener/consumer-listener.go
index 0a8e6c9..618c3c0 100644
--- a/examples/consumer-listener/consumer-listener.go
+++ b/examples/consumer-listener/consumer-listener.go
@@ -57,8 +57,6 @@ func main() {
fmt.Printf("Received message  msgId: %v -- content: '%s'\n",
msg.ID(), string(msg.Payload()))
 
-   if err := consumer.Ack(msg); err != nil {
-   log.Fatal(err)
-   }
+   consumer.Ack(msg)
}
 }
diff --git a/examples/consumer/consumer.go b/examples/consumer/consumer.go
index 5250a02..0b819bc 100644
--- a/examples/consumer/consumer.go
+++ b/examples/consumer/consumer.go
@@ -52,9 +52,7 @@ func main() {
fmt.Printf("Received message msgId: %#v -- content: '%s'\n",
msg.ID(), string(msg.Payload()))
 
-   if err := consumer.Ack(msg); err != nil {
-   log.Fatal(err)
-   }
+   consumer.Ack(msg)
}
 
if err := consumer.Unsubscribe(); err != nil {
diff --git a/perf/perf-consumer.go b/perf/perf-consumer.go
index 8fe2a86..582c06d 100644
--- a/perf/perf-consumer.go
+++ b/perf/perf-consumer.go
@@ -101,9 +101,7 @@ func consume(consumeArgs *ConsumeArgs, stop <-chan 
struct{}) {
}
msgReceived++
bytesReceived += int64(len(cm.Message.Payload()))
-   if err := consumer.Ack(cm.Message); err != nil {
-   return
-   }
+   consumer.Ack(cm.Message)
case <-tick.C:
currentMsgReceived := atomic.SwapInt64(&msgReceived, 0)
currentBytesReceived := 
atomic.SwapInt64(&bytesReceived, 0)
diff --git a/pulsar/consumer.go b/pulsar/consumer.go
index b0bba1b..961611e 100644
--- a/pulsar/consumer.go
+++ b/pulsar/consumer.go
@@ -19,6 +19,7 @@ package pulsar
 
 import (
"context"
+   "time"
 )
 
 // Pair of a Consumer and Message
@@ -106,6 +107,10 @@ type ConsumerOptions struct {
// ReceiverQueueSize(int) if the total exceeds this value (default: 
5).
MaxTotalReceiverQueueSizeAcrossPartitions int
 
+   // The delay after which to redeliver the messages that failed to be
+   // processed. Default is 1min. (See `Consumer.Nack()`)
+   NackRedeliveryDelay *time.Duration
+
// Set the consumer name.
Name string
 
@@ -136,10 +141,28 @@ type Consumer interface {
Chan() <-chan ConsumerMessage
 
// Ack the consumption of a single message
-   Ack(Message) error
+   Ack(Message)
 
// AckID the consumption of a single message, identified by its 
MessageID
-   AckID(MessageID) error
+   AckID(MessageID)
+
+   // Acknowledge the failure to process a single message.
+   //
+   // When a message is "negatively acked" it will be marked for 
redelivery after
+   // some fixed delay. The delay is configurable when constructing the 
consumer
+   // with ConsumerOptions.NAckRedeliveryDelay .
+   //
+   // This call is not blocking.
+   Nack(Message)
+
+   // Acknowledge the failure to process a single message.
+   //
+   // When a message is "negatively acked" it will be marked for 
redelivery after
+   // some fixed delay. The delay is configurable when constructing the 
consumer
+   // with ConsumerOpt

[GitHub] [pulsar-client-go] merlimat opened a new pull request #95: Fixed RpcClient.RequestOnCnxNoWait() to not require a request id

2019-11-12 Thread GitBox
merlimat opened a new pull request #95: Fixed RpcClient.RequestOnCnxNoWait() to 
not require a request id
URL: https://github.com/apache/pulsar-client-go/pull/95
 
 
   ### Motivation
   
   Simplified the rpc client handling of request that don't need to track the 
response.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] simoneau commented on issue #4043: go build faild with go mod

2019-11-12 Thread GitBox
simoneau commented on issue #4043: go build faild with go mod
URL: https://github.com/apache/pulsar/issues/4043#issuecomment-553125091
 
 
   To anyone else landing here, this is how I resolved this error on a Mac:
   ```
   brew install libpulsar
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar-client-go] cckellogg opened a new pull request #96: Hook up ack tracking to message ids.

2019-11-12 Thread GitBox
cckellogg opened a new pull request #96: Hook up ack tracking to message ids.
URL: https://github.com/apache/pulsar-client-go/pull/96
 
 
   ### Motivation
   
   Hook up the batch message id tracker for acking messages.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] aahmed-se closed pull request #5455: Update test docker scripts and library

2019-11-12 Thread GitBox
aahmed-se closed pull request #5455: Update test docker scripts and library
URL: https://github.com/apache/pulsar/pull/5455
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] aahmed-se closed pull request #5386: Update presto to 0.226

2019-11-12 Thread GitBox
aahmed-se closed pull request #5386: Update presto to 0.226
URL: https://github.com/apache/pulsar/pull/5386
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar-client-go] branch master updated: Fixed RpcClient.RequestOnCnxNoWait() to not require a request id (#95)

2019-11-12 Thread mmerli
This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git


The following commit(s) were added to refs/heads/master by this push:
 new 215023a  Fixed RpcClient.RequestOnCnxNoWait() to not require a request 
id (#95)
215023a is described below

commit 215023a2091c0f4425906e5964d84ea4e7cbb65f
Author: Matteo Merli 
AuthorDate: Tue Nov 12 14:32:03 2019 -0800

Fixed RpcClient.RequestOnCnxNoWait() to not require a request id (#95)
---
 pulsar/consumer_partition.go   | 13 -
 pulsar/internal/commands.go|  4 
 pulsar/internal/commands_test.go   | 11 +++
 pulsar/internal/connection.go  | 29 ++---
 pulsar/internal/lookup_service_test.go |  4 +---
 pulsar/internal/rpc_client.go  | 18 +++---
 6 files changed, 29 insertions(+), 50 deletions(-)

diff --git a/pulsar/consumer_partition.go b/pulsar/consumer_partition.go
index a8d9b6c..67c04e5 100644
--- a/pulsar/consumer_partition.go
+++ b/pulsar/consumer_partition.go
@@ -174,8 +174,7 @@ func (pc *partitionConsumer) internalRedeliver(req 
*redeliveryRequest) {
}
}
 
-   requestID := internal.RequestIDNoResponse
-   pc.client.rpcClient.RequestOnCnxNoWait(pc.conn, requestID,
+   pc.client.rpcClient.RequestOnCnxNoWait(pc.conn,
pb.BaseCommand_REDELIVER_UNACKNOWLEDGED_MESSAGES, 
&pb.CommandRedeliverUnacknowledgedMessages{
ConsumerId: proto.Uint64(pc.consumerID),
MessageIds: msgIdDataList,
@@ -203,14 +202,14 @@ func (pc *partitionConsumer) internalAck(req *ackRequest) 
{
LedgerId: proto.Uint64(uint64(msgId.ledgerID)),
EntryId:  proto.Uint64(uint64(msgId.entryID)),
}
-   requestID := internal.RequestIDNoResponse
+
cmdAck := &pb.CommandAck{
ConsumerId: proto.Uint64(pc.consumerID),
MessageId:  messageIDs,
AckType:pb.CommandAck_Individual.Enum(),
}
 
-   pc.client.rpcClient.RequestOnCnxNoWait(pc.conn, requestID, 
pb.BaseCommand_ACK, cmdAck)
+   pc.client.rpcClient.RequestOnCnxNoWait(pc.conn, pb.BaseCommand_ACK, 
cmdAck)
 }
 
 func (pc *partitionConsumer) MessageReceived(response *pb.CommandMessage, 
headersAndPayload internal.Buffer) error {
@@ -281,15 +280,11 @@ func (pc *partitionConsumer) internalFlow(permits uint32) 
error {
return fmt.Errorf("invalid number of permits requested: %d", 
permits)
}
 
-   requestID := internal.RequestIDNoResponse
cmdFlow := &pb.CommandFlow{
ConsumerId: proto.Uint64(pc.consumerID),
MessagePermits: proto.Uint32(permits),
}
-   _, err := pc.client.rpcClient.RequestOnCnxNoWait(pc.conn, requestID, 
pb.BaseCommand_FLOW, cmdFlow)
-   if err != nil {
-   return err
-   }
+   pc.client.rpcClient.RequestOnCnxNoWait(pc.conn, pb.BaseCommand_FLOW, 
cmdFlow)
 
return nil
 }
diff --git a/pulsar/internal/commands.go b/pulsar/internal/commands.go
index 4e691f0..09d223f 100644
--- a/pulsar/internal/commands.go
+++ b/pulsar/internal/commands.go
@@ -68,7 +68,6 @@ type MessageReader struct {
batched bool
 }
 
-
 // ReadChecksum
 func (r *MessageReader) readChecksum() (uint32, error) {
if r.buffer.ReadableBytes() < 6 {
@@ -83,7 +82,6 @@ func (r *MessageReader) readChecksum() (uint32, error) {
return checksum, nil
 }
 
-
 func (r *MessageReader) ReadMessageMetadata() (*pb.MessageMetadata, error) {
// Wire format
// [MAGIC_NUMBER][CHECKSUM] [METADATA_SIZE][METADATA]
@@ -145,7 +143,6 @@ func (r *MessageReader) readSingleMessage() 
(*pb.SingleMessageMetadata, []byte,
return &meta, r.buffer.Read(uint32(meta.GetPayloadSize())), nil
 }
 
-
 func baseCommand(cmdType pb.BaseCommand_Type, msg proto.Message) 
*pb.BaseCommand {
cmd := &pb.BaseCommand{
Type: &cmdType,
@@ -246,7 +243,6 @@ func serializeBatch(wb Buffer, cmdSend *pb.BaseCommand, 
msgMetadata *pb.MessageM
wb.PutUint32(checksum, checksumIdx)
 }
 
-
 // ConvertFromStringMap convert a string map to a KeyValue []byte
 func ConvertFromStringMap(m map[string]string) []*pb.KeyValue {
list := make([]*pb.KeyValue, len(m))
diff --git a/pulsar/internal/commands_test.go b/pulsar/internal/commands_test.go
index 5c2e19a..b43335a 100644
--- a/pulsar/internal/commands_test.go
+++ b/pulsar/internal/commands_test.go
@@ -38,7 +38,6 @@ func TestConvertStringMap(t *testing.T) {
assert.Equal(t, "2", m2["b"])
 }
 
-
 func TestReadMessageMetadata(t *testing.T) {
// read old style message (not batched)
reader := NewMessageReaderFromArray(rawCompatSingleMessage)
@@ -71,7 +70,6 @@ func TestReadMessageMetadata(t *testing.T) {
assert.Equal(t, 10, int(meta.GetNumMessagesInBatch

[GitHub] [pulsar-client-go] merlimat merged pull request #95: Fixed RpcClient.RequestOnCnxNoWait() to not require a request id

2019-11-12 Thread GitBox
merlimat merged pull request #95: Fixed RpcClient.RequestOnCnxNoWait() to not 
require a request id
URL: https://github.com/apache/pulsar-client-go/pull/95
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar-client-go] merlimat merged pull request #96: Hook up ack tracking to message ids.

2019-11-12 Thread GitBox
merlimat merged pull request #96: Hook up ack tracking to message ids.
URL: https://github.com/apache/pulsar-client-go/pull/96
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar-client-go] branch master updated: Hook up ack tracking to message ids. (#96)

2019-11-12 Thread mmerli
This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git


The following commit(s) were added to refs/heads/master by this push:
 new 7b29177  Hook up ack tracking to message ids. (#96)
7b29177 is described below

commit 7b29177d61372f56f207704123f7c1d86ada6e09
Author: cckellogg 
AuthorDate: Tue Nov 12 14:51:43 2019 -0800

Hook up ack tracking to message ids. (#96)
---
 pulsar/consumer_partition.go  |  20 +++-
 pulsar/consumer_partition_test.go | 198 ++
 2 files changed, 214 insertions(+), 4 deletions(-)

diff --git a/pulsar/consumer_partition.go b/pulsar/consumer_partition.go
index 67c04e5..b1d7b15 100644
--- a/pulsar/consumer_partition.go
+++ b/pulsar/consumer_partition.go
@@ -148,10 +148,12 @@ func (pc *partitionConsumer) internalUnsubscribe(unsub 
*unsubscribeRequest) {
 }
 
 func (pc *partitionConsumer) AckID(msgID *messageID) {
-   req := &ackRequest{
-   msgID: msgID,
+   if msgID != nil && msgID.ack() {
+   req := &ackRequest{
+   msgID: msgID,
+   }
+   pc.eventsCh <- req
}
-   pc.eventsCh <- req
 }
 
 func (pc *partitionConsumer) NackID(msgID *messageID) {
@@ -227,6 +229,11 @@ func (pc *partitionConsumer) MessageReceived(response 
*pb.CommandMessage, header
numMsgs = int(msgMeta.GetNumMessagesInBatch())
}
messages := make([]*message, numMsgs)
+   var ackTracker *ackTracker
+   // are there multiple messages in this batch?
+   if numMsgs > 1 {
+   ackTracker = newAckTracker(numMsgs)
+   }
for i := 0; i < numMsgs; i++ {
smm, payload, err := reader.ReadMessage()
if err != nil {
@@ -234,7 +241,12 @@ func (pc *partitionConsumer) MessageReceived(response 
*pb.CommandMessage, header
return err
}
 
-   msgID := newMessageID(int64(pbMsgID.GetLedgerId()), 
int64(pbMsgID.GetEntryId()), i, pc.partitionIdx)
+   msgID := newTrackingMessageID(
+   int64(pbMsgID.GetLedgerId()),
+   int64(pbMsgID.GetEntryId()),
+   i,
+   pc.partitionIdx,
+   ackTracker)
var msg *message
if smm != nil {
msg = &message{
diff --git a/pulsar/consumer_partition_test.go 
b/pulsar/consumer_partition_test.go
new file mode 100644
index 000..851b473
--- /dev/null
+++ b/pulsar/consumer_partition_test.go
@@ -0,0 +1,198 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package pulsar
+
+import (
+   "testing"
+
+   "github.com/stretchr/testify/assert"
+
+   "github.com/apache/pulsar-client-go/pulsar/internal"
+)
+
+func TestSingleMessageIDNoAckTracker(t *testing.T) {
+   eventsCh := make(chan interface{}, 1)
+   pc := partitionConsumer{
+   queueCh:  make(chan []*message, 1),
+   eventsCh: eventsCh,
+   }
+
+   headersAndPayload := internal.NewBufferWrapper(rawCompatSingleMessage)
+   if err := pc.MessageReceived(nil, headersAndPayload); err != nil {
+   t.Fatal(err)
+   }
+
+   // ensure the tracker was set on the message id
+   messages := <-pc.queueCh
+   for _, m := range messages {
+   assert.Nil(t, m.ID().(*messageID).tracker)
+   }
+
+   // ack the message id
+   pc.AckID(messages[0].msgID.(*messageID))
+
+   select{
+   case <- eventsCh:
+   default:
+   t.Error("Expected an ack request to be triggered!")
+   }
+}
+
+func TestBatchMessageIDNoAckTracker(t *testing.T) {
+   eventsCh := make(chan interface{}, 1)
+   pc := partitionConsumer{
+   queueCh:  make(chan []*message, 1),
+   eventsCh: eventsCh,
+   }
+
+   headersAndPayload := internal.NewBufferWrapper(rawBatchMessage1)
+   if err := pc.MessageReceived(nil, headersAndPayload); err != nil {
+   t.Fatal(err)
+   }
+
+   //

[GitHub] [pulsar] hangc0276 commented on issue #5605: fix prometheusMetrics export contains " bug

2019-11-12 Thread GitBox
hangc0276 commented on issue #5605: fix prometheusMetrics export contains " bug
URL: https://github.com/apache/pulsar/pull/5605#issuecomment-553164833
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options

2019-11-12 Thread GitBox
addisonj commented on a change in pull request #5400: [functions] Allow 
functions to pass runtime specific options
URL: https://github.com/apache/pulsar/pull/5400#discussion_r345499846
 
 

 ##
 File path: 
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/KubernetesFunctionAuthProvider.java
 ##
 @@ -30,7 +32,7 @@
  */
 public interface KubernetesFunctionAuthProvider extends FunctionAuthProvider {
 
-void initialize(CoreV1Api coreClient, String kubeNamespace, byte[] 
caBytes);
+void initialize(CoreV1Api coreClient, byte[] caBytes, 
java.util.function.Function 
namespaceCustomizerFunc);
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

2019-11-12 Thread GitBox
addisonj commented on issue #5400: [functions] Allow functions to pass runtime 
specific options
URL: https://github.com/apache/pulsar/pull/5400#issuecomment-553165046
 
 
   @jerrypeng changes made, let me know if you have anything else, glad it 
shaped up well :) 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] hangc0276 commented on issue #5617: update Maven version to 3.3.9+ in README.md

2019-11-12 Thread GitBox
hangc0276 commented on issue #5617: update Maven version to 3.3.9+ in README.md
URL: https://github.com/apache/pulsar/pull/5617#issuecomment-553165212
 
 
   run java8 tests
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar] branch master updated (3e7cb68 -> 9b9bff4)

2019-11-12 Thread mmerli
This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from 3e7cb68  Data is not deleted after expiration due to connected readers 
(#5621)
 add 9b9bff4  [Issue 5618] [docs]Correct python example (#5625)

No new revisions were added by this update.

Summary of changes:
 site2/docs/functions-develop.md|  23 +-
 .../version-2.4.1/functions-develop.md | 282 -
 2 files changed, 282 insertions(+), 23 deletions(-)



[GitHub] [pulsar] merlimat merged pull request #5625: [Issue 5618] [docs]Correct python example

2019-11-12 Thread GitBox
merlimat merged pull request #5625: [Issue 5618] [docs]Correct python example
URL: https://github.com/apache/pulsar/pull/5625
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] merlimat closed issue #5618: [Docs]The document of python function example is incorrect

2019-11-12 Thread GitBox
merlimat closed issue #5618: [Docs]The document of python function example is 
incorrect
URL: https://github.com/apache/pulsar/issues/5618
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] merlimat merged pull request #5636: [tests] remove redundant check in PulsarFunctionE2ESecurityTest

2019-11-12 Thread GitBox
merlimat merged pull request #5636: [tests] remove redundant check in 
PulsarFunctionE2ESecurityTest
URL: https://github.com/apache/pulsar/pull/5636
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


  1   2   >