[GitHub] [pulsar] Jennifer88huang opened a new pull request #5707: [Issue 5684] Add unit for storageSize
Jennifer88huang opened a new pull request #5707: [Issue 5684] Add unit for storageSize URL: https://github.com/apache/pulsar/pull/5707 Fixes #5684 ### Motivation The unit for `storageSize` is not specified in the documentation or API files. ### Modifications Add a note in the pulsar-admin documents. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5702: [pulsar-sql]Expose configurations of managed ledger and bookkeeper client.
codelipenghui commented on issue #5702: [pulsar-sql]Expose configurations of managed ledger and bookkeeper client. URL: https://github.com/apache/pulsar/pull/5702#issuecomment-555870845 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5677: [Issue 5676][C++ client] Expose redelivery count
codelipenghui commented on issue #5677: [Issue 5676][C++ client] Expose redelivery count URL: https://github.com/apache/pulsar/pull/5677#issuecomment-555870494 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5705: [pulsar-io] improve hbase sink performance
codelipenghui commented on issue #5705: [pulsar-io] improve hbase sink performance URL: https://github.com/apache/pulsar/pull/5705#issuecomment-555870146 related to #5696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5701: [issues 5698]Handle replicator producer as generated name producer
codelipenghui commented on issue #5701: [issues 5698]Handle replicator producer as generated name producer URL: https://github.com/apache/pulsar/pull/5701#issuecomment-555867873 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #4955: [PIP-39] Introduce system topic and topic policies service
codelipenghui commented on issue #4955: [PIP-39] Introduce system topic and topic policies service URL: https://github.com/apache/pulsar/pull/4955#issuecomment-555867272 ping @sijie @jiazhai I have rebased this PR, please help review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (77a69e4 -> 91621bc)
This is an automated email from the ASF dual-hosted git repository.
hjf pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 77a69e4 Use simple GC settings when running integration tests (#5342)
add 91621bc Update document for developer and old version (#5700)
No new revisions were added by this update.
Summary of changes:
site2/docs/admin-api-schemas.md| 92
site2/docs/concepts-schema-registry.md | 76 ---
site2/docs/deploy-bare-metal.md| 2 +-
site2/docs/functions-api.md| 5 +
site2/docs/functions-debugging.md | 123 +
site2/docs/functions-deploying.md | 223
site2/docs/functions-guarantees.md | 36 --
site2/docs/functions-metrics.md| 37 --
site2/docs/functions-quickstart.md | 5 +
site2/docs/functions-state.md | 5 +
site2/docs/io-aerospike.md | 16 -
site2/docs/io-cassandra.md | 17 -
site2/docs/io-cdc-canal.md | 170 --
site2/docs/io-elasticsearch.md | 16 -
site2/docs/io-file.md | 22 -
site2/docs/io-hbase.md | 22 -
site2/docs/io-hdfs.md | 21 -
site2/docs/io-influxdb.md | 20 -
site2/docs/io-jdbc.md | 18 -
site2/docs/io-kafka.md | 39 --
site2/docs/io-kinesis.md | 31 --
site2/docs/io-mongo.md | 15 -
site2/docs/io-netty.md | 15 -
site2/docs/io-rabbitmq.md | 48 --
site2/docs/io-redis.md | 22 -
site2/docs/io-solr.md | 16 -
site2/docs/io-tcp.md | 14 -
site2/docs/io-twitter.md | 17 -
site2/docs/reference-connector-admin.md| 594 -
.../admin-api-schemas.md | 2 +-
.../develop-bare-metal.md} | 4 +-
31 files changed, 20 insertions(+), 1723 deletions(-)
create mode 100644 site2/docs/functions-api.md
create mode 100644 site2/docs/functions-quickstart.md
create mode 100644 site2/docs/functions-state.md
copy site2/website/versioned_docs/{version-2.1.0-incubating =>
version-2.3.2}/admin-api-schemas.md (98%)
copy site2/website/versioned_docs/{version-2.4.0/deploy-bare-metal.md =>
version-2.4.1/develop-bare-metal.md} (99%)
[GitHub] [pulsar] Jennifer88huang merged pull request #5700: [Doc]Update document for developer and old version
Jennifer88huang merged pull request #5700: [Doc]Update document for developer and old version URL: https://github.com/apache/pulsar/pull/5700 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5706: [client]Fix consumer of python queue size is zero
tuteng commented on issue #5706: [client]Fix consumer of python queue size is zero URL: https://github.com/apache/pulsar/pull/5706#issuecomment-555857928 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5702: [pulsar-sql]Expose configurations of managed ledger and bookkeeper client.
codelipenghui commented on issue #5702: [pulsar-sql]Expose configurations of managed ledger and bookkeeper client. URL: https://github.com/apache/pulsar/pull/5702#issuecomment-555850936 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5701: [issues 5698]Handle replicator producer as generated name producer
codelipenghui commented on issue #5701: [issues 5698]Handle replicator producer as generated name producer URL: https://github.com/apache/pulsar/pull/5701#issuecomment-555850813 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] utf7 edited a comment on issue #5705: [pulsar-io] improve hbase sink performance
utf7 edited a comment on issue #5705: [pulsar-io] improve hbase sink performance URL: https://github.com/apache/pulsar/pull/5705#issuecomment-555835834 @codelipenghui mind have a look, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] utf7 commented on issue #5705: [pulsar-io] improve hbase sink performance
utf7 commented on issue #5705: [pulsar-io] improve hbase sink performance URL: https://github.com/apache/pulsar/pull/5705#issuecomment-555835834 @codelipenghui mind have i look, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5662: [doc] API documentation doesn't describe behaviour of async callbacks
jiazhai commented on issue #5662: [doc] API documentation doesn't describe
behaviour of async callbacks
URL: https://github.com/apache/pulsar/issues/5662#issuecomment-555833589
@candlerb This is related to the thread that user setting in client config?
```
struct ClientConfigurationImpl {
AuthenticationPtr authenticationPtr;
int ioThreads; < ===
int operationTimeoutSeconds;
int messageListenerThreads; < ===
int concurrentLookupRequest;
std::string logConfFilePath;
bool useTls;
std::string tlsTrustCertsFilePath;
bool tlsAllowInsecureConnection;
unsigned int statsIntervalInSeconds;
LoggerFactoryPtr loggerFactory;
bool validateHostName;
ClientConfigurationImpl()
: authenticationPtr(AuthFactory::Disabled()),
ioThreads(1),
operationTimeoutSeconds(30),
messageListenerThreads(1),
concurrentLookupRequest(5),
logConfFilePath(),
useTls(false),
tlsAllowInsecureConnection(false),
statsIntervalInSeconds(600), // 10 minutes
loggerFactory(),
validateHostName(false) {}
};
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
svn commit: r36839 - /dev/pulsar/KEYS
Author: rxl Date: Wed Nov 20 04:09:48 2019 New Revision: 36839 Log: Added gpg key for rxl Modified: dev/pulsar/KEYS Modified: dev/pulsar/KEYS == --- dev/pulsar/KEYS (original) +++ dev/pulsar/KEYS Wed Nov 20 04:09:48 2019 @@ -777,3 +777,62 @@ WbuS6k7VyxkZsY+Jc2KvRmT9fVU2/mHP5LSzUjUL cr0EockldeGbxsIM1r78b+PkE5BgeEH7SMzAZ1wpCwNH3meD3rsR1LY65yVnDqY= =e3P8 -END PGP PUBLIC KEY BLOCK- +pub rsa4096 2019-11-19 [SC] + 1EAA5DE92D3A0C4749E9846DB49DF828AFC9A442 +uid [ ç»å¯¹ ] xiaolong (CODE SIGNING KEY) +sig 3B49DF828AFC9A442 2019-11-19 xiaolong (CODE SIGNING KEY) +sub rsa4096 2019-11-19 [E] +sig B49DF828AFC9A442 2019-11-19 xiaolong (CODE SIGNING KEY) + +-BEGIN PGP PUBLIC KEY BLOCK- + +mQINBF3T1WoBEADwstBLhj1LtI/UAPWQALH7aRyTjLyN0ImGrd1Q1d/MOQ9Bqdmr +9NziHULBRvE8SGiajTHlX6uGSNw4h/nBNTtWuuHu8DlR6hyhOfc45PZKcNQ+r4y5 +E3lvDl6OsH0Cc1qcJiOD1FmmWQiLrG4oksxRF2XUSmeoZnZWdBsTV5QclrJ/4Ulk +FqeObPHeJLPRgOqrVlgwpGweIsX8QMYVult8AOpWt/L4t+uHH6tfZW9f6WHa8ks3 +0VS+ymwN015iefLET7dwuBzj6eplUh8BqrbAwJwMderPTiiKJGaLGU8JVAsidyjO +zvaT8vZLt6q84m9z8bMraKxC4D/qWlxoG/g2umybFyt28g8lW/wzS1ujT7xiIO5w +NZM6vKniOcBIAmhqvlvzPF05VHz4TItpO6dNfBPxKsGiDv+jo1CFjf5zMwi0336a +YJbLc8k5+uHRhACMnSAMTOfYpULJBqssQUrInXDmc8hA7bh4ViO3KELUYPwb9xeC +jN0bBf006fwcey1GKEDwnKrJl542VLi8ZTxLCdp1rQoYAdpDSXQeWIemVSPDXvB2 +24DME1KWHuJ8wBNgvTwkJFdpHnbY9pWn/AHzLD3RVxLvoJHvQYQZttSo8gD7qMvB +UMZ9YBioZFDOKACZy+ybRbgh67lHv8Z1lEFnYgDEFn4J5haVdcGJrifb+QARAQAB +tCx4aWFvbG9uZyAoQ09ERSBTSUdOSU5HIEtFWSkgPHJ4bEBhcGFjaGUub3JnPokC +TgQTAQgAOBYhBB6qXektOgxHSemEbbSd+CivyaRCBQJd09VqAhsDBQsJCAcCBhUK +CQgLAgQWAgMBAh4BAheAAAoJELSd+CivyaRCJnMQAKNbrI7kzNaRTjgRRSzUgqUp +Q3EZ/ptYg4dDh4zHNTdlwrkT/BmM6vxnnNE2Sexg2h+JxydbC8YNgzBqOFmu8QVn +tO2JVQTZalOQuuDmP05mhOrGDgkMzEA5PpqNSD7/oTyPU0vvnuIlEOToaZmbY7tE +wqs8qs8T1m9h8W3/i+Z6oysCIyBkvwWj4MR1NRm50yWZibLGpBlpsbvF92TPfrcp +PQ6uSbecPVHU+e0+dOpFNWN/mxUk6Kkwza2KV1bgTyPMwR+iq2jBPvJXbiocfY7D +1Om4IZwkbIp3TncKydPGPSIhq7ETj9AQuApVQUT+YaBeOUevTq/BIzgHXbObeJHL +uW7sH3/hJmKCciMY0bEdOYyF8OmvpGsaOAM5EwuT0xLIUQFeWlETYaONlB4ilDWT +J0ThoXwmGyGPsnF6fnHH7N1Rt0h2fUexkehHIl8ddh2ekFHkjHw85HQ6Nzd39nGI +svWLHuSzKAWly0fk4yb1IkmnsesMd2mGxCW4Z0y2KMCqIDrVpfMDPlIEoe8mKUQk +SGywOBdYDimdv/Pq/2aMk9Yz4i9BZwtK30UMoAW1G4g2JLVUfeJaKEnO/QSHDknb +ReDtlp736YzaO4UNeThdJ+sQSvHkFkbBcb4FDV2MmFz7jDno0fJH3tVFMhYmM1iY +OT5L1ZodEyuopqodz+M+uQINBF3T1WoBEADEgZ09B4TCwfRGWOcO//Jag6W34KbO +pDqIPsTv8xzSxhki5MTJmu8xXbm8Bq8k9ESPc0mD3AdpKBX3fkeeLT+fNI0G3ivy +5jnMGRFNbI27ybzr17f/tHcuS4KgHo3IDaXoCHjjDOCoAsSrSsWX1CwfktddbF2G +YktcqXno/DV0Rxas+mGJj1qTJp5dyOp/ucNrsUSm4fmAHX+TVvPYY042trOL9eBh +cEa8Z3J3ZYeW0Y9oKt/aliRO0mzNalh14/xgMHVLYGJMotCeymvpai73Dj01Ijjm +xXgk/02C+39v/vtGMBgQ3yHF1iUYo/ehI171e8xmR9H53GiQnhHxbq93Yk40vMgw +vwmjhsegaq9ZPiXf0o/06St8+3yTKayFR01D/a8lHsOHO6QZy1maYE/EOVNlsAQ+ +fHIlQlI3byyC3bxwSrDZCxu5hX71bnN+ACVin+WfsdwPu8iXtVUbRtvivZp7z4CK +v4GI7QZO14LkquMW0JI8oklsMpkNvYl56zuXcyL4UIpfC5mdR3eCyBoBec0J4I23 +GZHli0Nk6FgpucmeF3URBsjEx17A9GOzuZfmO9nraSMXQLBm2dyZVCZg6LH2/QFA ++Pcfe+IpHZdvzQNZEFlvMNzkr//DbLrQPhnMkwDfcBQN/simIqN/Ubj27lZf9xhz +0TXIqJfJo125YQARAQABiQI2BBgBCAAgFiEEHqpd6S06DEdJ6YRttJ34KK/JpEIF +Al3T1WoCGwwACgkQtJ34KK/JpEJk2hAAm8gQ+Q7gsbxi8b7R5Z6tdOMzg3MnnDy3 +kR48B55TZmz2yCEzM/nedUQSTCctPtHs8VY9F8z6iG6HmOygQmG3DYlk31C9Qgjb +FUoLX2kZMig5CUCDFDFx+H/s/pznqhn4ixzrJgP7N7hKcttfUe8w4ycSpXqJW3xY +gJhCdfox0KQQ0AjFjuqvG08mvjk64s7lkmnf78UQL+o8LYIa5woOiDcpnN6Swa+L +YLk9iJ+peHj8nkEqyy8D8godbfbN3DK5W2AbKPfyqG817kkugFObeHh7bc/S8p+B +wWiqUgWZgTVhWFi2lxc5wgI7xNkm1MxPljFvmSZgK5XpzV1gUFxE8qR7jribI7c3 +tJkuniqpWeOMzdvVi6FIQLTeMbO6PTsRd0Je2zAED8Gvck5Al8jbubOW/xCIV894 +Klw43EHzvZ5qpX3Jx5d3MVxBqjqL7NMBXYiDhe5s4f2yrnAeWDZWSddXTlIfRTPA +PV8VnPU/nhpxPnxMFEJ4wHO16tM4TuwCF+SdvAD96Hf+CK1AdRo31Bx7XQJHzG5w +lJTAcjwmMGAHV2HRZrthkqyDjKXutxl/Vf8kgprj4xrGtJoXrf9o+WCbhHlFFQ+g +GGMVc9R0HhyIfaOey9lg71Z6OGiyg2iKAfyQwZKyF4ogHqd4wGSHVitP2vo3BJ7l +oQ11CQmn87w= +=M2HO +-END PGP PUBLIC KEY BLOCK-
[GitHub] [pulsar] Jennifer88huang commented on issue #5684: Documentation: units for storageSize
Jennifer88huang commented on issue #5684: Documentation: units for storageSize URL: https://github.com/apache/pulsar/issues/5684#issuecomment-555828752 @candlerb The unit is Byte. We'll add it in docs. Thanks for your question. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5668: bookie server's log error: Failed to restore rocksdb 000000000000000000/000000000000000001/000000000000000000
jiazhai commented on issue #5668: bookie server's log error: Failed to restore rocksdb 00/01/00 URL: https://github.com/apache/pulsar/issues/5668#issuecomment-555828116 @kaykillyou Thanks for reporting this. If you are not using table service, you could pass in `-nss`(no stream store service) parameter when start broker or standalone. we will try to reproduce this issue and track it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #4423: Where can I find the helm chart to deploy Pulsar SQL with HA?
Jennifer88huang commented on issue #4423: Where can I find the helm chart to deploy Pulsar SQL with HA? URL: https://github.com/apache/pulsar/issues/4423#issuecomment-555826663 Since Presto does not support HA, I'll close this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang closed issue #4423: Where can I find the helm chart to deploy Pulsar SQL with HA?
Jennifer88huang closed issue #4423: Where can I find the helm chart to deploy Pulsar SQL with HA? URL: https://github.com/apache/pulsar/issues/4423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5666: Python, Go APIs: producer.flush() not blocking
jiazhai commented on issue #5666: Python, Go APIs: producer.flush() not blocking URL: https://github.com/apache/pulsar/issues/5666#issuecomment-555826623 @wolfstudy Would you please take a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] utf7 commented on issue #5705: [pulsar-io] improve hbase sink performance
utf7 commented on issue #5705: [pulsar-io] improve hbase sink performance URL: https://github.com/apache/pulsar/pull/5705#issuecomment-555820054 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng opened a new pull request #5706: Fix consumer of python queue size is zero
tuteng opened a new pull request #5706: Fix consumer of python queue size is zero URL: https://github.com/apache/pulsar/pull/5706 Fixes https://github.com/apache/pulsar/issues/5634 Master Issue: https://github.com/apache/pulsar/issues/5634 ### Motivation In java clients, when we call the `receive`, we will block it until a message arrives. in python clients, when we call the `receive` function, we add a delay parameter of 100ms. when the queue size is 0, the `receive` will have a strict check on the queue size, causing the following exception to be thrown ``` Traceback (most recent call last): File "tst.py", line 10, in msg = consumer.receive() File "/python3.7/site-packages/pulsar/__init__.py", line 930, in receive msg = self._consumer.receive() Exception: Pulsar error: InvalidConfiguration ``` ### Modifications * Removing timeout parameter in synchronous `receive` * Add test for queue size is 0 ### Verifying this change Add Test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar.wiki] branch master updated: Updated PIP 47: Time Based Release Plan (markdown)
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new 7d53dc3 Updated PIP 47: Time Based Release Plan (markdown) 7d53dc3 is described below commit 7d53dc36740f2ccd2526e56ba05cf3b186ea0d91 Author: 冉小龙 AuthorDate: Wed Nov 20 10:47:34 2019 +0800 Updated PIP 47: Time Based Release Plan (markdown) --- PIP-47:-Time-Based-Release-Plan.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PIP-47:-Time-Based-Release-Plan.md b/PIP-47:-Time-Based-Release-Plan.md index 21f7048..f901432 100644 --- a/PIP-47:-Time-Based-Release-Plan.md +++ b/PIP-47:-Time-Based-Release-Plan.md @@ -1,4 +1,4 @@ -- Status: Draft +- Status: Adopted - Author: Xiaolong Ran - Pull request: - Mailing list discussion:
[pulsar.wiki] branch master updated: Updated Home (markdown)
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new 85af5a6 Updated Home (markdown) 85af5a6 is described below commit 85af5a6f3f1e31d0b3280770dbf95ab351b778c7 Author: 冉小龙 AuthorDate: Wed Nov 20 10:46:46 2019 +0800 Updated Home (markdown) --- Home.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Home.md b/Home.md index 9f8a6c7..860a84d 100644 --- a/Home.md +++ b/Home.md @@ -10,7 +10,6 @@ We encourage to document any big change or feature or any addition to public use * [[PIP 50: Package Management]] * [[PIP 49: Permission levels and inheritance]] * [[PIP 48: hierarchical admin api]] -* [[PIP 47: Time Based Release Plan]] * [[PIP 46: Next-gen Proxy]] * [[PIP 45: Pluggable metadata interface]] * [[PIP 42: KoP - Kafka on Pulsar]] @@ -22,6 +21,7 @@ We encourage to document any big change or feature or any addition to public use * [[PIP 21: Pulsar Edge Component]] ### Accepted +* [[PIP 47: Time Based Release Plan]] * [[PIP 44: Separate schema compatibility checker for producer and consumer]] * [[PIP 43: producer send message with different schema]] * [[PIP 40: Pulsar Manager]]
[GitHub] [pulsar] zymap commented on issue #5376: [Issue 3009][docs] Add presto sql REST APIs doc
zymap commented on issue #5376: [Issue 3009][docs] Add presto sql REST APIs doc URL: https://github.com/apache/pulsar/pull/5376#issuecomment-555810093 @sijie PTAL. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5609: [Doc] Remove duplicate pages
Jennifer88huang commented on issue #5609: [Doc] Remove duplicate pages URL: https://github.com/apache/pulsar/pull/5609#issuecomment-555801127 @candlerb Since there are more obsolete files, @tuteng submit a PR to fix it in https://github.com/apache/pulsar/pull/5700 , could you please also check #5700 ? His solution includes the files in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5700: [Doc]Update document for developer and old version
Jennifer88huang commented on issue #5700: [Doc]Update document for developer and old version URL: https://github.com/apache/pulsar/pull/5700#issuecomment-555799806 @Anonymitaet could you please help check the IO parts? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] weishuisheng commented on a change in pull request #5701: [issues 5698]Handle replicator producer as generated name producer
weishuisheng commented on a change in pull request #5701: [issues 5698]Handle
replicator producer as generated name producer
URL: https://github.com/apache/pulsar/pull/5701#discussion_r348256048
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
##
@@ -430,6 +430,30 @@ public void testProducerOverwrite() throws Exception {
Assert.assertEquals(topic.getProducers().size(), 1);
topic.getProducers().values().forEach(producer ->
Assert.assertEquals(producer.getEpoch(), 2));
+
+topic.removeProducer(producer4);
+Assert.assertEquals(topic.getProducers().size(), 0);
+
+Producer producer5= new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
Review comment:
OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] weishuisheng commented on a change in pull request #5701: [issues 5698]Handle replicator producer as generated name producer
weishuisheng commented on a change in pull request #5701: [issues 5698]Handle
replicator producer as generated name producer
URL: https://github.com/apache/pulsar/pull/5701#discussion_r348256027
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##
@@ -316,6 +316,11 @@ private void tryOverwriteOldProducer(Producer
oldProducer, Producer newProducer)
}
}
+private boolean isUserProvidedProducerName(Producer producer){
+//considered replicator producer as generated name producer
+return producer.isUserProvidedProducerName() &&
!producer.getProducerName().startsWith(replicatorPrefix);
Review comment:
OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] weishuisheng commented on a change in pull request #5701: [issues 5698]Handle replicator producer as generated name producer
weishuisheng commented on a change in pull request #5701: [issues 5698]Handle
replicator producer as generated name producer
URL: https://github.com/apache/pulsar/pull/5701#discussion_r348256043
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
##
@@ -430,6 +430,30 @@ public void testProducerOverwrite() throws Exception {
Assert.assertEquals(topic.getProducers().size(), 1);
topic.getProducers().values().forEach(producer ->
Assert.assertEquals(producer.getEpoch(), 2));
+
+topic.removeProducer(producer4);
+Assert.assertEquals(topic.getProducers().size(), 0);
+
+Producer producer5= new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
+role, false, null, SchemaVersion.Latest, 1, false);
+
+topic.addProducer(producer5);
+Assert.assertEquals(topic.getProducers().size(), 1);
+
+Producer producer6= new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
Review comment:
OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] weishuisheng commented on a change in pull request #5701: [issues 5698]Handle replicator producer as generated name producer
weishuisheng commented on a change in pull request #5701: [issues 5698]Handle
replicator producer as generated name producer
URL: https://github.com/apache/pulsar/pull/5701#discussion_r348255880
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
##
@@ -430,6 +430,30 @@ public void testProducerOverwrite() throws Exception {
Assert.assertEquals(topic.getProducers().size(), 1);
topic.getProducers().values().forEach(producer ->
Assert.assertEquals(producer.getEpoch(), 2));
+
+topic.removeProducer(producer4);
+Assert.assertEquals(topic.getProducers().size(), 0);
+
+Producer producer5= new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
Review comment:
OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] weishuisheng commented on a change in pull request #5701: [issues 5698]Handle replicator producer as generated name producer
weishuisheng commented on a change in pull request #5701: [issues 5698]Handle
replicator producer as generated name producer
URL: https://github.com/apache/pulsar/pull/5701#discussion_r348255730
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##
@@ -316,6 +316,11 @@ private void tryOverwriteOldProducer(Producer
oldProducer, Producer newProducer)
}
}
+private boolean isUserProvidedProducerName(Producer producer){
+//considered replicator producer as generated name producer
+return producer.isUserProvidedProducerName() &&
!producer.getProducerName().startsWith(replicatorPrefix);
Review comment:
OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] weishuisheng commented on a change in pull request #5701: [issues 5698]Handle replicator producer as generated name producer
weishuisheng commented on a change in pull request #5701: [issues 5698]Handle
replicator producer as generated name producer
URL: https://github.com/apache/pulsar/pull/5701#discussion_r348255757
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
##
@@ -430,6 +430,30 @@ public void testProducerOverwrite() throws Exception {
Assert.assertEquals(topic.getProducers().size(), 1);
topic.getProducers().values().forEach(producer ->
Assert.assertEquals(producer.getEpoch(), 2));
+
+topic.removeProducer(producer4);
+Assert.assertEquals(topic.getProducers().size(), 0);
+
+Producer producer5= new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
+role, false, null, SchemaVersion.Latest, 1, false);
+
+topic.addProducer(producer5);
+Assert.assertEquals(topic.getProducers().size(), 1);
+
+Producer producer6= new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
+role, false, null, SchemaVersion.Latest, 2, false);
+
+topic.addProducer(producer6);
+Assert.assertEquals(topic.getProducers().size(), 1);
+
+topic.getProducers().values().forEach(producer ->
Assert.assertEquals(producer.getEpoch(), 2));
+
+Producer producer7= new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
Review comment:
OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] utf7 opened a new pull request #5705: [pulsar-io] improve hbase sink performance
utf7 opened a new pull request #5705: [pulsar-io] improve hbase sink performance URL: https://github.com/apache/pulsar/pull/5705 ### Motivation multi columns add to single put can improve the performace this can improve hbase put performance in our test env, it can be better 2.x-3.x ### Modifications hbase sink : change one column with one put to one put with many columns This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] utf7 closed pull request #5696: [pulsar-io] improve hbase sink performance
utf7 closed pull request #5696: [pulsar-io] improve hbase sink performance URL: https://github.com/apache/pulsar/pull/5696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] utf7 commented on issue #5696: [pulsar-io] improve hbase sink performance
utf7 commented on issue #5696: [pulsar-io] improve hbase sink performance URL: https://github.com/apache/pulsar/pull/5696#issuecomment-555790258 the origin repository was deleted for git flow clean so close the pr and will create a new one This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] laxpio opened a new issue #5704: revert terminate topic
laxpio opened a new issue #5704: revert terminate topic URL: https://github.com/apache/pulsar/issues/5704 **Is your feature request related to a problem? Please describe.** sometimes need restrict publish message，when use terminate function，the topic will can not be reverted as a normal topic **Describe the solution you'd like** Support un-terminate function This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] utf7 commented on issue #5696: [pulsar-io] improve hbase sink performance
utf7 commented on issue #5696: [pulsar-io] improve hbase sink performance URL: https://github.com/apache/pulsar/pull/5696#issuecomment-555786358 ok,will rebase,thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5677: [Issue 5676][C++ client] Expose redelivery count
merlimat commented on issue #5677: [Issue 5676][C++ client] Expose redelivery count URL: https://github.com/apache/pulsar/pull/5677#issuecomment-555779297 @frejonb ^^ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5677: [Issue 5676][C++ client] Expose redelivery count
merlimat commented on issue #5677: [Issue 5676][C++ client] Expose redelivery count URL: https://github.com/apache/pulsar/pull/5677#issuecomment-555779234 > is there a way to debug why Jenkins is breaking at testPartitionedReceiveAsyncFailedConsumer? it works on my machine ™. Running the tests inside a Docker container (especially from MacOS) is a good way to slow it down make it similar to ASF Jenkins environment: `pulsar-client-cpp/docker-tests.sh` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5671: [Doc] Add HBase sink connector guide
codelipenghui commented on issue #5671: [Doc] Add HBase sink connector guide URL: https://github.com/apache/pulsar/pull/5671#issuecomment-555779043 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5674: Parametrize grpc and metrics ports so that they can be configured
codelipenghui commented on issue #5674: Parametrize grpc and metrics ports so that they can be configured URL: https://github.com/apache/pulsar/pull/5674#issuecomment-555778196 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5677: [Issue 5676][C++ client] Expose redelivery count
codelipenghui commented on issue #5677: [Issue 5676][C++ client] Expose redelivery count URL: https://github.com/apache/pulsar/pull/5677#issuecomment-555777488 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5702: [pulsar-sql]Expose configurations of managed ledger and bookkeeper client.
codelipenghui commented on issue #5702: [pulsar-sql]Expose configurations of managed ledger and bookkeeper client. URL: https://github.com/apache/pulsar/pull/5702#issuecomment-555772056 run cpp tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] merlimat merged pull request #103: Update protobuf file.
merlimat merged pull request #103: Update protobuf file. URL: https://github.com/apache/pulsar-client-go/pull/103 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] cckellogg opened a new pull request #103: Update protobuf file.
cckellogg opened a new pull request #103: Update protobuf file. URL: https://github.com/apache/pulsar-client-go/pull/103 Update the protobuf file to access some of the new features and commands. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on issue #5628: Fix: Netty threads may still linger after client close
jerrypeng commented on issue #5628: Fix: Netty threads may still linger after client close URL: https://github.com/apache/pulsar/pull/5628#issuecomment-555765307 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on issue #5628: Fix: Netty threads may still linger after client close
jerrypeng commented on issue #5628: Fix: Netty threads may still linger after client close URL: https://github.com/apache/pulsar/pull/5628#issuecomment-555760727 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] danvixent opened a new issue #5703: Apache Netbeans 11.1 Not Opening
danvixent opened a new issue #5703: Apache Netbeans 11.1 Not Opening URL: https://github.com/apache/pulsar/issues/5703 The Apache Netbeans 11.1 never opens but keeps on creating error files in its application install directory(named hs_err_pid15684 or something similar). This particular one *hs_err_pid15684* contents below: # # A fatal error has been detected by the Java Runtime Environment: # # EXCEPTION_ACCESS_VIOLATION (0xc005) at pc=0x7ffb55616690, pid=15684, tid=18032 # # JRE version: Java(TM) SE Runtime Environment (12.0.2+10) (build 12.0.2+10) # Java VM: Java HotSpot(TM) 64-Bit Server VM (12.0.2+10, mixed mode, sharing, tiered, compressed oops, g1 gc, windows-amd64) # Problematic frame: # C 0x7ffb55616690 [error occurred during error reporting (printing problematic frame), id 0xc005, EXCEPTION_ACCESS_VIOLATION (0xc005) at pc=0x7ffb55616de0] # No core dump will be written. Minidumps are not enabled by default on client versions of Windows # # If you would like to submit a bug report, please visit: # http://bugreport.java.com/bugreport/crash.jsp # The crash happened outside the Java Virtual Machine in native code. # See problematic frame for where to report the bug. # --- S U M M A R Y Command Line: -Dnetbeans.importclass=org.netbeans.upgrade.AutoUpgrade -XX:+UseStringDeduplication -Xss2m -Djdk.gtk.version=2.2 -Dapple.laf.useScreenMenuBar=true -Dapple.awt.graphics.UseQuartz=true -Dsun.java2d.noddraw=true -Dsun.java2d.dpiaware=true -Dsun.zip.disableMemoryMapping=true -Dplugin.manager.check.updates=false -Dnetbeans.extbrowser.manual_chrome_plugin_install=yes --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.lang.ref=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.security=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.desktop/javax.swing.plaf.basic=ALL-UNNAMED --add-opens=java.desktop/javax.swing.text=ALL-UNNAMED --add-opens=java.desktop/javax.swing=ALL-UNNAMED --add-opens=java.desktop/java.awt=ALL-UNNAMED --add-opens=java.desktop/java.awt.event=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=jdk.jshell/jdk.jshell=ALL-UNNAMED --add-modules=jdk.jshell --add-exports=java.desktop/sun.awt=ALL-UNNAMED --add-exports=java.desktop/java.awt.peer=ALL-UNNAMED --add-exports=java.desktop/com.sun.beans.editors=ALL-UNNAMED --add-exports=java.desktop/sun.swing=ALL-UNNAMED --add-exports=java.desktop/sun.awt.im=ALL-UNNAMED --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED --add-exports=java.management/sun.management=ALL-UNNAMED --add-exports=java.base/sun.reflect.annotation=ALL-UNNAMED --add-exports=jdk.javadoc/com.sun.tools.javadoc.main=ALL-UNNAMED -XX:+IgnoreUnrecognizedVMOptions -Djdk.home=C:\Program Files\Java\jdk-12.0.2 -Dnetbeans.home=C:\Program Files\NetBeans-11.1\netbeans\platform -Dnetbeans.user=C:\Users\DANIEL\AppData\Roaming\NetBeans\11.1 -Dnetbeans.default_userdir_root=C:\Users\DANIEL\AppData\Roaming\NetBeans -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=C:\Users\DANIEL\AppData\Roaming\NetBeans\11.1\var\log\heapdump.hprof -Dsun.awt.keepWorkingSetOnMinimize=true -Dnetbeans.dirs=C:\Program Files\NetBeans-11.1\netbeans\nb;C:\Program Files\NetBeans-11.1\netbeans\ergonomics;C:\Program Files\NetBeans-11.1\netbeans\ide;C:\Program Files\NetBeans-11.1\netbeans\extide;C:\Program Files\NetBeans-11.1\netbeans\java;C:\Program Files\NetBeans-11.1\netbeans\apisupport;C:\Program Files\NetBeans-11.1\netbeans\webcommon;C:\Program Files\NetBeans-11.1\netbeans\websvccommon;C:\Program Files\NetBeans-11.1\netbeans\enterprise;C:\Program Files\NetBeans-11.1\netbeans\mobility;C:\Program Files\NetBeans-11.1\netbeans\profiler;C:\Program Files\NetBeans-11.1\netbeans\python;C:\Program Files\NetBeans-11.1\netbeans\php;C:\Program Files\NetBeans-11.1\netbeans\identity;C:\Program Files\NetBeans-11.1\netbeans\harness;C:\Program Files\NetBeans-11.1\netbeans\cnd;C:\Program Files\NetBeans-11.1\netbeans\cndext;C:\Program Files\NetBeans-11.1\netbeans\dlight;C:\Program Files\NetBeans-11.1\netbeans\groovy;C:\Program Files\NetBeans-11.1\netbeans\extra;C:\Program Files\NetBeans-11.1\netbeans\javacard;C:\Program Files\NetBeans-11.1\netbeans\javafx exit Host: Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz, 4 cores, 15G, Windows 10 , 64 bit Build 18362 (10.0.18362.86) Time: Thu Oct 31 11:52:38 2019 W. Central Africa Standard Time elapsed time: 1 seconds (0d 0h 0m 1s) --- T H R E A D --- Current thread (0x29a11000): JavaThread "AWT-EventQueue-0" [_thread_in_native, id=18032, stack(0x2b0b,0x2b2b)] Stack: [0x2b0b,0x2b2b], sp=0x2b2ab2b8, free space=2028k Native frames: (J=compiled Java code, j=interpreted,
[GitHub] [pulsar] gaoran10 opened a new pull request #5702: [pulsar-sql]Expose configurations of managed ledger and bookkeeper client.
gaoran10 opened a new pull request #5702: [pulsar-sql]Expose configurations of managed ledger and bookkeeper client. URL: https://github.com/apache/pulsar/pull/5702 ### Motivation Expose more configurations of managed ledger and bookkeeper client, this will provide ability for users to optimize performance of entries reading. ### Modifications Expose some configurations related to managed ledger and bookkeeper client in pulsar.config. ### Verifying this change Add unit tests to verify the default value of the configurations. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API: (no) - The schema: (no) - The default values of configurations: (yes) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation - Does this pull request introduce a new feature? (no) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5700: [Doc]Update document for developer and old version
sijie commented on issue #5700: [Doc]Update document for developer and old version URL: https://github.com/apache/pulsar/pull/5700#issuecomment-555637944 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5671: [Doc] Add HBase sink connector guide
sijie commented on issue #5671: [Doc] Add HBase sink connector guide URL: https://github.com/apache/pulsar/pull/5671#issuecomment-555637249 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie merged pull request #5342: Use simple GC settings when running integration tests
sijie merged pull request #5342: Use simple GC settings when running integration tests URL: https://github.com/apache/pulsar/pull/5342 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (33dd8b7 -> 77a69e4)
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 33dd8b7 update content of Pulsar SQL overview (#5647) add 77a69e4 Use simple GC settings when running integration tests (#5342) No new revisions were added by this update. Summary of changes: tests/docker-images/latest-version-image/conf/bookie.conf | 4 +--- tests/docker-images/latest-version-image/conf/broker.conf | 2 +- tests/docker-images/latest-version-image/conf/functions_worker.conf | 2 +- tests/docker-images/latest-version-image/conf/global-zk.conf| 2 +- tests/docker-images/latest-version-image/conf/local-zk.conf | 2 +- tests/docker-images/latest-version-image/conf/presto_worker.conf| 2 +- tests/docker-images/latest-version-image/conf/proxy.conf| 2 +- 7 files changed, 7 insertions(+), 9 deletions(-)
[pulsar] branch master updated (76b3720 -> 33dd8b7)
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 76b3720 [docs] Update sql getting started (#5648) add 33dd8b7 update content of Pulsar SQL overview (#5647) No new revisions were added by this update. Summary of changes: site2/docs/sql-overview.md | 17 + 1 file changed, 5 insertions(+), 12 deletions(-)
[GitHub] [pulsar] sijie merged pull request #5648: [docs] Update sql getting started
sijie merged pull request #5648: [docs] Update sql getting started URL: https://github.com/apache/pulsar/pull/5648 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie merged pull request #5647: [docs] Update content of Pulsar SQL overview
sijie merged pull request #5647: [docs] Update content of Pulsar SQL overview URL: https://github.com/apache/pulsar/pull/5647 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (1ec3cf4 -> 76b3720)
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 1ec3cf4 Fix ProxyLookupThrottlingTest (#5639) add 76b3720 [docs] Update sql getting started (#5648) No new revisions were added by this update. Summary of changes: site2/docs/sql-getting-started.md | 43 --- 1 file changed, 22 insertions(+), 21 deletions(-)
[pulsar] branch site-update updated: fix: example of Python client Syntax error (#5697)
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch site-update
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/site-update by this push:
new 9c76c44 fix: example of Python client Syntax error (#5697)
9c76c44 is described below
commit 9c76c0010cd180d3da240ebe6ef0841dd8f7
Author: wangyunpeng666 <57751906+wangyunpeng...@users.noreply.github.com>
AuthorDate: Wed Nov 20 01:59:45 2019 +0800
fix: example of Python client Syntax error (#5697)
fix: example of Python client Syntax error
---
site2/docs/security-token-client.md | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/site2/docs/security-token-client.md
b/site2/docs/security-token-client.md
index 204cdca..ac93b48 100644
--- a/site2/docs/security-token-client.md
+++ b/site2/docs/security-token-client.md
@@ -75,7 +75,7 @@ PulsarClient client = PulsarClient.builder()
```python
from pulsar import Client, AuthenticationToken
-client = Client('pulsar://broker.example.com:6650/'
+client = Client('pulsar://broker.example.com:6650/',
authentication=AuthenticationToken('eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJKb2UifQ.ipevRNuRP6HflG8cFKnmUPtypruRC4fb1DWtoLL62SY'))
```
@@ -87,7 +87,7 @@ def read_token():
with open('/path/to/token.txt') as tf:
return tf.read().strip()
-client = Client('pulsar://broker.example.com:6650/'
+client = Client('pulsar://broker.example.com:6650/',
authentication=AuthenticationToken(read_token))
```
[GitHub] [pulsar] sijie merged pull request #5697: fix: example of Python client Syntax error
sijie merged pull request #5697: fix: example of Python client Syntax error URL: https://github.com/apache/pulsar/pull/5697 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (56517d5 -> 9dd8dfd)
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 56517d5 [PIP-38] Support batch receive in java client. (#4621) add 9dd8dfd [Doc] Re-organize built-in connector guide (#5670) No new revisions were added by this update. Summary of changes: site2/docs/io-cdc.md| 2 +- site2/docs/io-connectors.md | 198 ++-- site2/docs/io-kafka-sink.md | 2 + site2/docs/io-kinesis-sink.md | 37 +--- site2/docs/io-kinesis-source.md | 4 - 5 files changed, 194 insertions(+), 49 deletions(-)
[pulsar] branch master updated (9dd8dfd -> 1ec3cf4)
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 9dd8dfd [Doc] Re-organize built-in connector guide (#5670) add 1ec3cf4 Fix ProxyLookupThrottlingTest (#5639) No new revisions were added by this update. Summary of changes: .../org/apache/pulsar/proxy/server/ProxyLookupThrottlingTest.java | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)
[GitHub] [pulsar] sijie merged pull request #5670: [Doc] Re-organize built-in connector guide
sijie merged pull request #5670: [Doc] Re-organize built-in connector guide URL: https://github.com/apache/pulsar/pull/5670 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie closed issue #5667: [Doc] Re-organize built-in connector guide & add HBase sink connector guide
sijie closed issue #5667: [Doc] Re-organize built-in connector guide & add HBase sink connector guide URL: https://github.com/apache/pulsar/issues/5667 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie merged pull request #5639: Fix ProxyLookupThrottlingTest
sijie merged pull request #5639: Fix ProxyLookupThrottlingTest URL: https://github.com/apache/pulsar/pull/5639 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5701: [issues 5698]Handle replicator producer as generated name producer
sijie commented on a change in pull request #5701: [issues 5698]Handle
replicator producer as generated name producer
URL: https://github.com/apache/pulsar/pull/5701#discussion_r348079294
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##
@@ -316,6 +316,11 @@ private void tryOverwriteOldProducer(Producer
oldProducer, Producer newProducer)
}
}
+private boolean isUserProvidedProducerName(Producer producer){
+//considered replicator producer as generated name producer
+return producer.isUserProvidedProducerName() &&
!producer.getProducerName().startsWith(replicatorPrefix);
Review comment:
```suggestion
return producer.isUserProvidedProducerName() &&
!producer.getProducerName().startsWith(replicatorPrefix);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5701: [issues 5698]Handle replicator producer as generated name producer
sijie commented on a change in pull request #5701: [issues 5698]Handle
replicator producer as generated name producer
URL: https://github.com/apache/pulsar/pull/5701#discussion_r348079163
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
##
@@ -430,6 +430,30 @@ public void testProducerOverwrite() throws Exception {
Assert.assertEquals(topic.getProducers().size(), 1);
topic.getProducers().values().forEach(producer ->
Assert.assertEquals(producer.getEpoch(), 2));
+
+topic.removeProducer(producer4);
+Assert.assertEquals(topic.getProducers().size(), 0);
+
+Producer producer5= new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
+role, false, null, SchemaVersion.Latest, 1, false);
+
+topic.addProducer(producer5);
+Assert.assertEquals(topic.getProducers().size(), 1);
+
+Producer producer6= new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
+role, false, null, SchemaVersion.Latest, 2, false);
+
+topic.addProducer(producer6);
+Assert.assertEquals(topic.getProducers().size(), 1);
+
+topic.getProducers().values().forEach(producer ->
Assert.assertEquals(producer.getEpoch(), 2));
+
+Producer producer7= new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
Review comment:
```suggestion
Producer producer7 = new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5701: [issues 5698]Handle replicator producer as generated name producer
sijie commented on a change in pull request #5701: [issues 5698]Handle
replicator producer as generated name producer
URL: https://github.com/apache/pulsar/pull/5701#discussion_r348079053
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
##
@@ -430,6 +430,30 @@ public void testProducerOverwrite() throws Exception {
Assert.assertEquals(topic.getProducers().size(), 1);
topic.getProducers().values().forEach(producer ->
Assert.assertEquals(producer.getEpoch(), 2));
+
+topic.removeProducer(producer4);
+Assert.assertEquals(topic.getProducers().size(), 0);
+
+Producer producer5= new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
Review comment:
```suggestion
Producer producer5 = new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5701: [issues 5698]Handle replicator producer as generated name producer
sijie commented on a change in pull request #5701: [issues 5698]Handle
replicator producer as generated name producer
URL: https://github.com/apache/pulsar/pull/5701#discussion_r348079098
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
##
@@ -430,6 +430,30 @@ public void testProducerOverwrite() throws Exception {
Assert.assertEquals(topic.getProducers().size(), 1);
topic.getProducers().values().forEach(producer ->
Assert.assertEquals(producer.getEpoch(), 2));
+
+topic.removeProducer(producer4);
+Assert.assertEquals(topic.getProducers().size(), 0);
+
+Producer producer5= new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
+role, false, null, SchemaVersion.Latest, 1, false);
+
+topic.addProducer(producer5);
+Assert.assertEquals(topic.getProducers().size(), 1);
+
+Producer producer6= new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
Review comment:
```suggestion
Producer producer6 = new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5701: [issues 5698]Handle replicator producer as generated name producer
codelipenghui commented on issue #5701: [issues 5698]Handle replicator producer as generated name producer URL: https://github.com/apache/pulsar/pull/5701#issuecomment-71348 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5671: [Doc] Add HBase sink connector guide
tuteng commented on issue #5671: [Doc] Add HBase sink connector guide URL: https://github.com/apache/pulsar/pull/5671#issuecomment-28529 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng removed a comment on issue #5700: [Doc]Update document for developer and old version
tuteng removed a comment on issue #5700: [Doc]Update document for developer and old version URL: https://github.com/apache/pulsar/pull/5700#issuecomment-27739 rerun integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5700: [Doc]Update document for developer and old version
tuteng commented on issue #5700: [Doc]Update document for developer and old version URL: https://github.com/apache/pulsar/pull/5700#issuecomment-27739 rerun integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng removed a comment on issue #5700: [Doc]Update document for developer and old version
tuteng removed a comment on issue #5700: [Doc]Update document for developer and old version URL: https://github.com/apache/pulsar/pull/5700#issuecomment-26808 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5700: [Doc]Update document for developer and old version
tuteng commented on issue #5700: [Doc]Update document for developer and old version URL: https://github.com/apache/pulsar/pull/5700#issuecomment-27491 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5700: [Doc]Update document for developer and old version
tuteng commented on issue #5700: [Doc]Update document for developer and old version URL: https://github.com/apache/pulsar/pull/5700#issuecomment-26808 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on a change in pull request #5701: [issues 5698]Handle replicator producer as generated name producer
codelipenghui commented on a change in pull request #5701: [issues 5698]Handle
replicator producer as generated name producer
URL: https://github.com/apache/pulsar/pull/5701#discussion_r347935145
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##
@@ -316,6 +316,11 @@ private void tryOverwriteOldProducer(Producer
oldProducer, Producer newProducer)
}
}
+private boolean isUserProvidedProducerName(Producer producer){
+//considered replicator producer as generated name producer
+return producer.isUserProvidedProducerName() &&
!producer.getProducerName().startsWith(replicatorPrefix);
Review comment:
seems 2 space here, please keep 1 space
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on a change in pull request #5701: [issues 5698]Handle replicator producer as generated name producer
codelipenghui commented on a change in pull request #5701: [issues 5698]Handle
replicator producer as generated name producer
URL: https://github.com/apache/pulsar/pull/5701#discussion_r347935588
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
##
@@ -430,6 +430,30 @@ public void testProducerOverwrite() throws Exception {
Assert.assertEquals(topic.getProducers().size(), 1);
topic.getProducers().values().forEach(producer ->
Assert.assertEquals(producer.getEpoch(), 2));
+
+topic.removeProducer(producer4);
+Assert.assertEquals(topic.getProducers().size(), 0);
+
+Producer producer5= new Producer(topic, serverCnx, 2 /* producer id
*/, "pulsar.repl.cluster1",
Review comment:
add space before =, please also check other places
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5628: Fix: Netty threads may still linger after client close
wolfstudy commented on issue #5628: Fix: Netty threads may still linger after client close URL: https://github.com/apache/pulsar/pull/5628#issuecomment-12506 @jerrypeng Please fix the test case, will change the milestone to `2.4.3`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] weishuisheng opened a new pull request #5701: [issues 5698]Handle replicator producer as generated name producer
weishuisheng opened a new pull request #5701: [issues 5698]Handle replicator producer as generated name producer URL: https://github.com/apache/pulsar/pull/5701 Fixes #5698 ### Motivation Since #5571 handle the generated producer name, i think the producer name of replicator producer also can be considered as a producer with generated producer name, because only one producer for a replicated topic. So, we can handle it simple by considered replicator producer as generated name producer. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (no) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) - The rest endpoints: (yno) - The admin cli options: (no) - Anything that affects deployment: (no) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar.wiki] branch master updated: Updated PIP 47: Time Based Release Plan (markdown)
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new 909c2fe Updated PIP 47: Time Based Release Plan (markdown) 909c2fe is described below commit 909c2feb69bd14f26c663db3217cf413be5dcfe4 Author: 冉小龙 AuthorDate: Tue Nov 19 21:26:58 2019 +0800 Updated PIP 47: Time Based Release Plan (markdown) --- PIP-47:-Time-Based-Release-Plan.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PIP-47:-Time-Based-Release-Plan.md b/PIP-47:-Time-Based-Release-Plan.md index 51ad5d5..21f7048 100644 --- a/PIP-47:-Time-Based-Release-Plan.md +++ b/PIP-47:-Time-Based-Release-Plan.md @@ -86,4 +86,4 @@ The proposed schedule for Apache Pulsar is shown below. - December 2019 - March 2020 - March 2020 - June 2020 - June 2020 - September 2020 -- December 2020 - December 2020 +- September 2020 - December 2020
[GitHub] [pulsar] wolfstudy commented on issue #5230: Allow for topic deletions with regex consumers
wolfstudy commented on issue #5230: Allow for topic deletions with regex consumers URL: https://github.com/apache/pulsar/pull/5230#issuecomment-03228 The pr change the proto file, will move the milestone to `2.5.0` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5382: Update client-libraries-go.md
wolfstudy commented on issue #5382: Update client-libraries-go.md URL: https://github.com/apache/pulsar/pull/5382#issuecomment-03167 Change the milestone to `2.4.2`, because of conflict This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5571: Add epoch for connection handler to handle create producer timeout.
wolfstudy commented on issue #5571: Add epoch for connection handler to handle create producer timeout. URL: https://github.com/apache/pulsar/pull/5571#issuecomment-555497995 @codelipenghui @jiazhai The pr changes the proto file, will move the milestone to `2.5.0` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy removed a comment on issue #3986: [pulsar-broker] Introduce publish rate-limiting on topic
wolfstudy removed a comment on issue #3986: [pulsar-broker] Introduce publish rate-limiting on topic URL: https://github.com/apache/pulsar/pull/3986#issuecomment-555491230 Change the Milestone to 2.4.2, because of conflict. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #3986: [pulsar-broker] Introduce publish rate-limiting on topic
wolfstudy commented on issue #3986: [pulsar-broker] Introduce publish rate-limiting on topic URL: https://github.com/apache/pulsar/pull/3986#issuecomment-555491230 Change the Milestone to 2.4.2, because of conflict. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] candlerb commented on issue #5683: Cannot create topic under sample/standalone/ns1
candlerb commented on issue #5683: Cannot create topic under
sample/standalone/ns1
URL: https://github.com/apache/pulsar/issues/5683#issuecomment-555486084
The REST API doc shows e.g.
`https://pulsar.apache.org/admin/v2/namespaces/{tenant}/{namespace}` - it
doesn't mention the optional `{cluster}` part.
At least, I can delete the sample namespace and tenant:
```
$ apache-pulsar-2.4.1/bin/pulsar-admin namespaces delete
sample/standalone/ns1
$ apache-pulsar-2.4.1/bin/pulsar-admin tenants delete sample
```
I agree it would be a good idea to remove this from the default standalone
configuration.
PIP-10 says:
> All REST APIs and tools will accept both naming schemes, though the
documentation will just refer to the new naming, to avoid confusion.
I think it should be mentioned *somewhere* in the documentation that older
versions of pulsar had this extra level in the namespace; otherwise it causes
confusion for anyone who happens to come across it (as it did for me)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #4987: Trim deleted entries after recover cursor.
wolfstudy commented on issue #4987: Trim deleted entries after recover cursor. URL: https://github.com/apache/pulsar/pull/4987#issuecomment-555482696 Change the Milestone to 2.4.2, because of conflict. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5572: Fix create consumer on partitioned topic while disable topic auto creation.
codelipenghui commented on issue #5572: Fix create consumer on partitioned topic while disable topic auto creation. URL: https://github.com/apache/pulsar/pull/5572#issuecomment-555479839 @sijie Please help review this PR again This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] frejonb commented on issue #5677: [Issue 5676][C++ client] Expose redelivery count
frejonb commented on issue #5677: [Issue 5676][C++ client] Expose redelivery count URL: https://github.com/apache/pulsar/pull/5677#issuecomment-555475801 @merlimat is there a way to debug why Jenkins is breaking at `testPartitionedReceiveAsyncFailedConsumer`? it _works on my machine ™_. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #4780: Clarify how retention interacts with readers
wolfstudy commented on issue #4780: Clarify how retention interacts with readers URL: https://github.com/apache/pulsar/pull/4780#issuecomment-555473592 Change the Milestone to 2.4.2, because of conflict. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zymap commented on issue #5683: Cannot create topic under sample/standalone/ns1
zymap commented on issue #5683: Cannot create topic under sample/standalone/ns1 URL: https://github.com/apache/pulsar/issues/5683#issuecomment-555472456 Hi @candlerb, I think this tenant and namespace should remove from the standalone. here is a PIP for removing the cluster of a namespace: https://github.com/apache/pulsar/wiki/PIP-10:-Remove-cluster-for-namespace-and-topic-names. A topic name consists of `domain`, `tenant`, `namespace`, and `topic`. The latest version of Pulsar already removes the cluster name for a topic name. The tenant name and namespace name can not include the `/` because we use the `/` to separate it. You can use `-=:.` to create a namespace name if you need to create a name with multipart. As far as I know, there is nothing to restrict the topic name. So you can use any characters as your topic name. And here has an admin API doc might can help you: https://pulsar.apache.org/admin-rest-api/?version=2.4.1. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng opened a new pull request #5700: Update document for developer and old version
tuteng opened a new pull request #5700: Update document for developer and old version URL: https://github.com/apache/pulsar/pull/5700 ### Motivation At present, in official documents, due to changes in the document structure and the limitation of docusaurus framework, the old version of the document cannot be deleted, only the name of the document can be changed so that there are many duplicate contents. when contributors want to modify the content of the document, they do not know where to modify it or need to modify several places, which is very unfriendly to developers. ### Modifications * Keep the title of the document of the old version, delete the content, and ensure that the old version can find the matching content. ### Verifying this change yarn build pass This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5036: [pulsar-perf] Introduce number of threads in perf producer program
wolfstudy commented on issue #5036: [pulsar-perf] Introduce number of threads in perf producer program URL: https://github.com/apache/pulsar/pull/5036#issuecomment-555465990 Change the Milestone to 2.4.2, because of conflict. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] utf7 commented on issue #5696: [pulsar-io] improve hbase sink performance
utf7 commented on issue #5696: [pulsar-io] improve hbase sink performance URL: https://github.com/apache/pulsar/pull/5696#issuecomment-555453587 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] ssrkr edited a comment on issue #5678: all-messages-shared subscription mode
ssrkr edited a comment on issue #5678: all-messages-shared subscription mode
URL: https://github.com/apache/pulsar/issues/5678#issuecomment-555427353
Could you elaborate on what you mean by subscription name? In our scenario,
all consumers have to subscribe to a topic and subscription is based on a
specific topic and mode, as per pulsar document. Taking client APi example from
https://pulsar.apache.org/docs/v2.0.0-rc1-incubating/clients/Java/
While creating let's say we use
Consumer consumer1 = client.newConsumer()
.topic("my-topic")
.subscriptionName("my-subscription-1")
.ackTimeout(10, TimeUnit.SECONDS)
.subscriptionType(SubscriptionType.Exclusive)
.subscribe();
Consumer consumer2 = client.newConsumer()
.topic("my-topic")
.subscriptionName("my-subscription-2")
.ackTimeout(10, TimeUnit.SECONDS)
.subscriptionType(SubscriptionType.Exclusive)
.subscribe();
Are you saying in this example both Consumer 1 and Consumer 2 will get same
message? If yes, it should server our need.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui opened a new issue #5699: Expose last execution time of message expiration.
codelipenghui opened a new issue #5699: Expose last execution time of message expiration. URL: https://github.com/apache/pulsar/issues/5699 **Is your feature request related to a problem? Please describe.** If user enable the message ttl and want to know the last execution time of message expiration for a subscription, it's only can be check by broker log, since the topic is maintained by a broker in the cluster, users must do a lookup to find that broker and then check the logs. So, expose the last execution time of message expiration in topic internal stats is more convenient for the users. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui edited a comment on issue #5698: Geo replicator has ProducerBusyException
codelipenghui edited a comment on issue #5698: Geo replicator has ProducerBusyException URL: https://github.com/apache/pulsar/issues/5698#issuecomment-555442990 Since https://github.com/apache/pulsar/pull/5571 handle the generated producer name, i think the producer name of replicator producer also can be considered as a producer with generated producer name, because only one producer for a replicated topic. So, we can handle it simple by considered replicator producer as generated name producer. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5698: Geo replicator has ProducerBusyException
codelipenghui commented on issue #5698: Geo replicator has ProducerBusyException URL: https://github.com/apache/pulsar/issues/5698#issuecomment-555442990 Since https://github.com/apache/pulsar/pull/5571 handle the generated producer name, i think the producer name of replicator producer also can be considered as a producer with generated producer name, because only producer for a replicated topic. So, we can handle it simple by considered replicator producer as generated name producer. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #4423: Where can I find the helm chart to deploy Pulsar SQL with HA?
Jennifer88huang commented on issue #4423: Where can I find the helm chart to deploy Pulsar SQL with HA? URL: https://github.com/apache/pulsar/issues/4423#issuecomment-555440654 In the latest Presto release, HA is not mentioned either https://prestosql.io/Presto_SQL_on_Everything.pdf This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
