[GitHub] [pulsar] PierreZ commented on issue #5495: Add a reverse mapping from role to namespaces

2019-11-25 Thread GitBox
PierreZ commented on issue #5495: Add a reverse mapping from role to namespaces
URL: https://github.com/apache/pulsar/issues/5495#issuecomment-558506067
 
 
   I cheated for my part, I'm injecting the tenant/namespace in the user field 
of the SASL_PLAIN to find topics. Leaving the issue opened as the main problem 
is still here, like for @yjshen.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] tuteng commented on issue #5724: [pulsar-broker]Support batch authorization of partitioned topic

2019-11-25 Thread GitBox
tuteng commented on issue #5724: [pulsar-broker]Support batch authorization of 
partitioned topic
URL: https://github.com/apache/pulsar/issues/5724#issuecomment-558505701
 
 
   Welcome, if you have any questions, you can ping me at any time. @zhaohaidao 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Sunkwan-Kwon commented on issue #5627: [Issue 5626][pulsar-function-go] Fix a memory leak of pulsar-function-go library regarding time.NewTimer()

2019-11-25 Thread GitBox
Sunkwan-Kwon commented on issue #5627: [Issue 5626][pulsar-function-go] Fix a 
memory leak of pulsar-function-go library regarding time.NewTimer()
URL: https://github.com/apache/pulsar/pull/5627#issuecomment-558502073
 
 
   Hello. @wolfstudy.
   Could you review this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] aahmed-se commented on issue #5642: Add Github workflow for gated checkin

2019-11-25 Thread GitBox
aahmed-se commented on issue #5642: Add Github workflow for gated checkin
URL: https://github.com/apache/pulsar/pull/5642#issuecomment-558500269
 
 
   run java8 tests
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai merged pull request #5710: Add publish rate limit for each broker to avoid OOM

2019-11-25 Thread GitBox
jiazhai merged pull request #5710: Add publish rate limit for each broker to 
avoid OOM
URL: https://github.com/apache/pulsar/pull/5710
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar] branch master updated (48506e5 -> 9e7b938)

2019-11-25 Thread zhaijia
This is an automated email from the ASF dual-hosted git repository.

zhaijia pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from 48506e5  fix setTxnidMostBits bug (#5743)
 add 9e7b938  Add publish rate limit for each broker to avoid OOM (#5710)

No new revisions were added by this update.

Summary of changes:
 conf/broker.conf   |  24 +-
 conf/standalone.conf   |  25 +-
 .../apache/pulsar/broker/ServiceConfiguration.java |  30 +-
 .../pulsar/broker/service/AbstractTopic.java   |  70 ++--
 .../pulsar/broker/service/BrokerService.java   | 148 ++--
 .../org/apache/pulsar/broker/service/Producer.java |   2 +-
 .../pulsar/broker/service/PublishRateLimiter.java  |  33 +-
 .../org/apache/pulsar/broker/service/Topic.java|  12 +-
 .../client/impl/MessagePublishThrottlingTest.java  | 405 +++--
 9 files changed, 643 insertions(+), 106 deletions(-)



[GitHub] [pulsar] jiazhai closed issue #5513: Publish rate limit on broker to avoid OOM

2019-11-25 Thread GitBox
jiazhai closed issue #5513: Publish rate limit on broker to avoid OOM
URL: https://github.com/apache/pulsar/issues/5513
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5726: Unhandled NoClassDefFoundError in SourceConfigUtils.java (and friends)

2019-11-25 Thread GitBox
jiazhai commented on issue #5726: Unhandled NoClassDefFoundError in 
SourceConfigUtils.java (and friends)
URL: https://github.com/apache/pulsar/issues/5726#issuecomment-558498061
 
 
   @phreed Thanks for your detailed issue reporting. Would you like to provide 
a PR for your fix? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #5742: [pulsar-broker] add support to configure max pending publish request per connection

2019-11-25 Thread GitBox
codelipenghui commented on issue #5742: [pulsar-broker] add support to 
configure max pending publish request per connection
URL: https://github.com/apache/pulsar/pull/5742#issuecomment-558496357
 
 
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5711: through pulsar proxy visit api return 502

2019-11-25 Thread GitBox
jiazhai commented on issue #5711: through pulsar proxy visit api return 502
URL: https://github.com/apache/pulsar/issues/5711#issuecomment-558495847
 
 
   Seems local deploy works well, This may related to K8s configs. @lxkaka 
Would you mind share a little details of how you deployed you pulsar in K8S?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] congbobo184 commented on issue #4848: Consumer can getValue return null

2019-11-25 Thread GitBox
congbobo184 commented on issue #4848: Consumer can getValue return null
URL: https://github.com/apache/pulsar/pull/4848#issuecomment-558493203
 
 
   I am not working on it.It can be moved to the next version.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5737: [Issue 5729]Picture and text are not match

2019-11-25 Thread GitBox
jiazhai commented on issue #5737: [Issue 5729]Picture and text are not match
URL: https://github.com/apache/pulsar/pull/5737#issuecomment-558492879
 
 
   @huangdx0726  Thanks for working on this. seems there are also some other 
old versioned files need update.
   
![image](https://user-images.githubusercontent.com/6348208/69606751-a2a64f80-105e-11ea-9cfe-e7fa636b6b56.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai closed issue #5728: [doc] Missing right Parentheses

2019-11-25 Thread GitBox
jiazhai closed issue #5728: [doc] Missing right Parentheses
URL: https://github.com/apache/pulsar/issues/5728
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] congbobo184 commented on issue #5222: 2.4.1 pulsar-admin should have 8 schema compatibility check strategies

2019-11-25 Thread GitBox
congbobo184 commented on issue #5222: 2.4.1 pulsar-admin should have 8 schema 
compatibility check strategies
URL: https://github.com/apache/pulsar/issues/5222#issuecomment-558491773
 
 
   I will update documentation soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #5745: Add document for sticky consumer

2019-11-25 Thread GitBox
codelipenghui commented on issue #5745: Add document for sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745#issuecomment-558491766
 
 
   @Anonymitaet Please help take a look.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5735: Provide raw counters metrics

2019-11-25 Thread GitBox
jiazhai commented on issue #5735: Provide raw counters metrics
URL: https://github.com/apache/pulsar/issues/5735#issuecomment-558491512
 
 
   Thanks @PierreZ for working on this. it sounds good to me.  Add @sijie 
@merlimat, to see if they have more suggestions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui opened a new pull request #5745: Add document for sticky consumer

2019-11-25 Thread GitBox
codelipenghui opened a new pull request #5745: Add document for sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745
 
 
   Fixes #5682 
   
   ### Motivation
   
   Add document for sticky consumer
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
 - Dependencies (does it add or upgrade a dependency): (no)
 - The public API: (no)
 - The schema: (no)
 - The default values of configurations: (no)
 - The wire protocol: (no)
 - The rest endpoints: (no)
 - The admin cli options: (no)
 - Anything that affects deployment: (no)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] aahmed-se commented on issue #5642: Add Github workflow for gated checkin

2019-11-25 Thread GitBox
aahmed-se commented on issue #5642: Add Github workflow for gated checkin
URL: https://github.com/apache/pulsar/pull/5642#issuecomment-558488930
 
 
   rerun java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5724: [pulsar-broker]Support batch authorization of partitioned topic

2019-11-25 Thread GitBox
jiazhai commented on issue #5724: [pulsar-broker]Support batch authorization of 
partitioned topic
URL: https://github.com/apache/pulsar/issues/5724#issuecomment-558486620
 
 
   @zhaohaidao You are welcome to do it. Please go ahead. Feel free to ping 
@tuteng if you meet problem


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5725: Relax PULSAR_HOME requirement.

2019-11-25 Thread GitBox
jiazhai commented on issue #5725: Relax PULSAR_HOME requirement.
URL: https://github.com/apache/pulsar/issues/5725#issuecomment-558486408
 
 
   It seem OK to me. 
   @jerrypeng @sijie. Is there any particular reason to use 
`System.getenv("PULSAR_HOME")` instead of `System.getProperty("PULSAR_HOME")` 
in PulsarLocalRunner? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5723: Quota, retention (macro management) on tenant level.

2019-11-25 Thread GitBox
jiazhai commented on issue #5723: Quota, retention (macro management) on tenant 
level.
URL: https://github.com/apache/pulsar/issues/5723#issuecomment-558481037
 
 
   👍 . @KannarFr Would you like to contribute to this feature? It would be good 
to start a pip to discuss what to do and how to do it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5734: [Reopen][Issue 5597]retry when getPartitionedTopicMetadata failed

2019-11-25 Thread GitBox
jiazhai commented on issue #5734: [Reopen][Issue 5597]retry when 
getPartitionedTopicMetadata failed
URL: https://github.com/apache/pulsar/pull/5734#issuecomment-558479491
 
 
   run java8 tests
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5720: authorize tenant level and namespace level access from the authorization provider

2019-11-25 Thread GitBox
jiazhai commented on issue #5720: authorize tenant level and namespace level 
access from the authorization provider
URL: https://github.com/apache/pulsar/issues/5720#issuecomment-558478836
 
 
   Hi Geal, there was a discussion of role and authorize in pulsar dev mail 
list. And also a PIP is here: 
https://github.com/apache/pulsar/wiki/PIP-49%3A-Permission-levels-and-inheritance
   
   Would you please check if these could help your case. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on issue #5549: Fix documentation: how to start server for cpp tests

2019-11-25 Thread GitBox
Anonymitaet commented on issue #5549: Fix documentation: how to start server 
for cpp tests
URL: https://github.com/apache/pulsar/pull/5549#issuecomment-558476172
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai merged pull request #5743: fix setTxnidMostBits bug

2019-11-25 Thread GitBox
jiazhai merged pull request #5743: fix setTxnidMostBits bug
URL: https://github.com/apache/pulsar/pull/5743
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar] branch master updated (de2ff6b -> 48506e5)

2019-11-25 Thread zhaijia
This is an automated email from the ASF dual-hosted git repository.

zhaijia pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from de2ff6b  Add right parenthesis for "(max size configurable" (#5744)
 add 48506e5  fix setTxnidMostBits bug (#5743)

No new revisions were added by this update.

Summary of changes:
 .../java/org/apache/pulsar/client/impl/TypedMessageBuilderImpl.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[pulsar] branch master updated (4207de6 -> de2ff6b)

2019-11-25 Thread zhaijia
This is an automated email from the ASF dual-hosted git repository.

zhaijia pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from 4207de6  [Issues 5692]Add document for mongodb connector (#5715)
 add de2ff6b  Add right parenthesis for "(max size configurable" (#5744)

No new revisions were added by this update.

Summary of changes:
 site2/docs/concepts-messaging.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[GitHub] [pulsar] jiazhai merged pull request #5744: Add right parenthesis for "(max size configurable"

2019-11-25 Thread GitBox
jiazhai merged pull request #5744: Add right parenthesis for "(max size 
configurable"
URL: https://github.com/apache/pulsar/pull/5744
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] fanyunbojerry commented on issue #5713: avoid unsafe split when validate hostname which might be ipv6 address

2019-11-25 Thread GitBox
fanyunbojerry commented on issue #5713: avoid unsafe split when validate 
hostname which might be ipv6 address
URL: https://github.com/apache/pulsar/pull/5713#issuecomment-558467379
 
 
   run cpp tests
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5742: [pulsar-broker] add support to configure max pending publish request per connection

2019-11-25 Thread GitBox
jiazhai commented on issue #5742: [pulsar-broker] add support to configure max 
pending publish request per connection
URL: https://github.com/apache/pulsar/pull/5742#issuecomment-558463419
 
 
   run cpp tests
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5710: Add publish rate limit for each broker to avoid OOM

2019-11-25 Thread GitBox
jiazhai commented on issue #5710: Add publish rate limit for each broker to 
avoid OOM
URL: https://github.com/apache/pulsar/pull/5710#issuecomment-558462872
 
 
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5744: Add right parenthesis for "(max size configurable"

2019-11-25 Thread GitBox
jiazhai commented on issue #5744: Add right parenthesis for "(max size 
configurable"
URL: https://github.com/apache/pulsar/pull/5744#issuecomment-558462621
 
 
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie removed a comment on issue #5743: fix setTxnidMostBits bug

2019-11-25 Thread GitBox
sijie removed a comment on issue #5743: fix setTxnidMostBits bug
URL: https://github.com/apache/pulsar/pull/5743#issuecomment-558455764
 
 
   fix java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5743: fix setTxnidMostBits bug

2019-11-25 Thread GitBox
sijie commented on issue #5743: fix setTxnidMostBits bug
URL: https://github.com/apache/pulsar/pull/5743#issuecomment-558455834
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5743: fix setTxnidMostBits bug

2019-11-25 Thread GitBox
sijie commented on issue #5743: fix setTxnidMostBits bug
URL: https://github.com/apache/pulsar/pull/5743#issuecomment-558455764
 
 
   fix java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] hangc0276 commented on issue #5743: fix setTxnidMostBits bug

2019-11-25 Thread GitBox
hangc0276 commented on issue #5743: fix setTxnidMostBits bug
URL: https://github.com/apache/pulsar/pull/5743#issuecomment-558445874
 
 
   > Thanks @hangc0276 for the work. A suggestion: Please following pulsar 
contributing guide to checkout a new branch from master for each fix: 
http://pulsar.apache.org/en/contributing/, This will be good for your own 
branch and code management.
   
   Thanks, i will follow the pulsar contributing guide next time. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5743: fix setTxnidMostBits bug

2019-11-25 Thread GitBox
jiazhai commented on issue #5743: fix setTxnidMostBits bug
URL: https://github.com/apache/pulsar/pull/5743#issuecomment-558443425
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5743: fix setTxnidMostBits bug

2019-11-25 Thread GitBox
jiazhai commented on issue #5743: fix setTxnidMostBits bug
URL: https://github.com/apache/pulsar/pull/5743#issuecomment-558443354
 
 
   Thanks @hangc0276 for the work. Please following pulsar contributing guide 
to checkout a new branch from master for each fix: 
http://pulsar.apache.org/en/contributing/, This will be good for your own 
branch and code management.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai edited a comment on issue #5743: fix setTxnidMostBits bug

2019-11-25 Thread GitBox
jiazhai edited a comment on issue #5743: fix setTxnidMostBits bug
URL: https://github.com/apache/pulsar/pull/5743#issuecomment-558443354
 
 
   Thanks @hangc0276 for the work. A suggestion: Please following pulsar 
contributing guide to checkout a new branch from master for each fix: 
http://pulsar.apache.org/en/contributing/, This will be good for your own 
branch and code management.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5710: Add publish rate limit for each broker to avoid OOM

2019-11-25 Thread GitBox
jiazhai commented on issue #5710: Add publish rate limit for each broker to 
avoid OOM
URL: https://github.com/apache/pulsar/pull/5710#issuecomment-558442663
 
 
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on issue #5562: Add the doc for new schema compatibility strategy.

2019-11-25 Thread GitBox
Anonymitaet commented on issue #5562: Add the doc for new schema compatibility  
strategy.
URL: https://github.com/apache/pulsar/issues/5562#issuecomment-558439510
 
 
   I'm handling this task and @congbobo184 will provide technical inputs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] yjshen commented on issue #5495: Add a reverse mapping from role to namespaces

2019-11-25 Thread GitBox
yjshen commented on issue #5495: Add a reverse mapping from role to namespaces
URL: https://github.com/apache/pulsar/issues/5495#issuecomment-558438284
 
 
   I'm facing the same situation while developing pulsar-flink-connector.
   
   My scene is as follows:
   I was developing a Pulsar catalog in Flink and mapping `tenant/namespace` to 
`database`,`topic` to `table`. Therefore, for each role, I need to list all 
topics it has access to, and users could fire queries based on his/her tables.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] tuteng commented on issue #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
tuteng commented on issue #5741: [website]Add content of pulsar-manager in 
website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#issuecomment-558437346
 
 
   @Anonymitaet PTAL


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] atlantic2099 opened a new pull request #5744: Add right parenthesis for "(max size configurable"

2019-11-25 Thread GitBox
atlantic2099 opened a new pull request #5744: Add right parenthesis for "(max 
size configurable"
URL: https://github.com/apache/pulsar/pull/5744
 
 
   @Jennifer88huang
   Resolved issue #5728
   
   
   
   *(If this PR fixes a github issue, please add `Fixes #`.)*
   
   Fixes #
   
   *(or if this PR is one task of a github issue, please add `Master Issue: 
#` to link to the master issue.)*
   
   Master Issue: #
   
   ### Motivation
   
   
   *Explain here the context, and why you're making that change. What is the 
problem you're trying to solve.*
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe 
tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
 - *Added integration tests for end-to-end deployment with large payloads 
(10MB)*
 - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
 - Dependencies (does it add or upgrade a dependency): (yes / no)
 - The public API: (yes / no)
 - The schema: (yes / no / don't know)
 - The default values of configurations: (yes / no)
 - The wire protocol: (yes / no)
 - The rest endpoints: (yes / no)
 - The admin cli options: (yes / no)
 - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
 - Does this pull request introduce a new feature? (yes / no)
 - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
 - If a feature is not applicable for documentation, explain why?
 - If a feature is not documented yet in this PR, please create a followup 
issue for adding the documentation
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on issue #5549: Fix documentation: how to start server for cpp tests

2019-11-25 Thread GitBox
Anonymitaet commented on issue #5549: Fix documentation: how to start server 
for cpp tests
URL: https://github.com/apache/pulsar/pull/5549#issuecomment-558435915
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on issue #4704: Add documentation for HDFS offloader

2019-11-25 Thread GitBox
Anonymitaet commented on issue #4704: Add documentation for HDFS offloader
URL: https://github.com/apache/pulsar/issues/4704#issuecomment-558433394
 
 
   @congbobo184 could you please provide technical inputs? Then I can review 
from the perspective of technical writing, thank you


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] hangc0276 opened a new pull request #5743: fix setTxnidMostBits bug

2019-11-25 Thread GitBox
hangc0276 opened a new pull request #5743: fix setTxnidMostBits bug
URL: https://github.com/apache/pulsar/pull/5743
 
 
   In TypedMessageBuilderImpl::beforeSend function, when setting TxnIdMostBits 
field of msgMetadataBuilder, it sets into TxnidLeastBits field and override the 
original TxnIdLeastBits value.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] zymap commented on issue #5714: Add more info in the error messages

2019-11-25 Thread GitBox
zymap commented on issue #5714: Add more info in the error messages
URL: https://github.com/apache/pulsar/pull/5714#issuecomment-558431290
 
 
   The unit test seems failed caused by my fix. I am fixing the test.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] zymap commented on issue #5001: [Pulsar-sql]Using pulsar SQL query messages will appear `NoSuchLedger` when zk root directory changed

2019-11-25 Thread GitBox
zymap commented on issue #5001: [Pulsar-sql]Using pulsar SQL query messages 
will appear `NoSuchLedger` when zk root directory changed
URL: https://github.com/apache/pulsar/pull/5001#issuecomment-558430999
 
 
   @sijie Ok


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui closed pull request #5719: Remove cursor while remove non-durable subscription

2019-11-25 Thread GitBox
codelipenghui closed pull request #5719: Remove cursor while remove non-durable 
subscription
URL: https://github.com/apache/pulsar/pull/5719
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #5719: Remove cursor while remove non-durable subscription

2019-11-25 Thread GitBox
codelipenghui commented on issue #5719: Remove cursor while remove non-durable 
subscription
URL: https://github.com/apache/pulsar/pull/5719#issuecomment-558430392
 
 
   Seems @merlimat already have a PR #5022 related to this issue, so we can 
close this PR


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


svn commit: r36942 - /release/pulsar/pulsar-manager/apache-pulsar-manager-0.1.0-bin.tar.gz.sha512

2019-11-25 Thread zhaijia
Author: zhaijia
Date: Tue Nov 26 02:26:23 2019
New Revision: 36942

Log:
Delete duplicate files for bin sha512 package of pulsar manager

Removed:
release/pulsar/pulsar-manager/apache-pulsar-manager-0.1.0-bin.tar.gz.sha512



svn commit: r36945 - /release/pulsar/pulsar-manager/apache-pulsar-manager-0.1.0-src.tar.gz.sha512

2019-11-25 Thread zhaijia
Author: zhaijia
Date: Tue Nov 26 02:26:39 2019
New Revision: 36945

Log:
Delete duplicate files for sha512 package of pulsar manager

Removed:
release/pulsar/pulsar-manager/apache-pulsar-manager-0.1.0-src.tar.gz.sha512



svn commit: r36943 - /release/pulsar/pulsar-manager/apache-pulsar-manager-0.1.0-src.tar.gz

2019-11-25 Thread zhaijia
Author: zhaijia
Date: Tue Nov 26 02:26:30 2019
New Revision: 36943

Log:
Delete duplicate files for src package of pulsar manager

Removed:
release/pulsar/pulsar-manager/apache-pulsar-manager-0.1.0-src.tar.gz



svn commit: r36944 - /release/pulsar/pulsar-manager/apache-pulsar-manager-0.1.0-src.tar.gz.asc

2019-11-25 Thread zhaijia
Author: zhaijia
Date: Tue Nov 26 02:26:34 2019
New Revision: 36944

Log:
Delete duplicate files for src asc package of pulsar manager

Removed:
release/pulsar/pulsar-manager/apache-pulsar-manager-0.1.0-src.tar.gz.asc



[GitHub] [pulsar] codelipenghui commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client.

2019-11-25 Thread GitBox
codelipenghui commented on issue #5680: [transaction-coordinator] 
Implementation of transaction coordinator client.
URL: https://github.com/apache/pulsar/pull/5680#issuecomment-558429954
 
 
   run java8 tests
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


svn commit: r36941 - /release/pulsar/pulsar-manager/apache-pulsar-manager-0.1.0-bin.tar.gz.asc

2019-11-25 Thread zhaijia
Author: zhaijia
Date: Tue Nov 26 02:26:18 2019
New Revision: 36941

Log:
Delete duplicate files for bin asc package of pulsar manager

Removed:
release/pulsar/pulsar-manager/apache-pulsar-manager-0.1.0-bin.tar.gz.asc



svn commit: r36940 - /release/pulsar/pulsar-manager/apache-pulsar-manager-0.1.0-bin.tar.gz

2019-11-25 Thread zhaijia
Author: zhaijia
Date: Tue Nov 26 02:26:07 2019
New Revision: 36940

Log:
Delete duplicate files for bin package of pulsar manager

Removed:
release/pulsar/pulsar-manager/apache-pulsar-manager-0.1.0-bin.tar.gz



svn commit: r36939 - /dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-4/apache-pulsar-manager-0.1.0-candidate-4-bin.tar.gz.sha512

2019-11-25 Thread guangning
Author: guangning
Date: Tue Nov 26 02:21:03 2019
New Revision: 36939

Log:
Delete candidate file

Removed:

dev/pulsar/pulsar-manager/pulsar-manager-0.1.0-candidate-4/apache-pulsar-manager-0.1.0-candidate-4-bin.tar.gz.sha512



[pulsar-manager.wiki] branch master updated: Updated Release process (markdown)

2019-11-25 Thread guangning
This is an automated email from the ASF dual-hosted git repository.

guangning pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new d712063  Updated Release process (markdown)
d712063 is described below

commit d7120637e0b624a4d0413b75baa040511ece8036
Author: tuteng 
AuthorDate: Tue Nov 26 10:16:10 2019 +0800

Updated Release process (markdown)
---
 Release-process.md | 26 +-
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/Release-process.md b/Release-process.md
index 25b0b48..576d6d6 100644
--- a/Release-process.md
+++ b/Release-process.md
@@ -80,25 +80,25 @@ $ cp ../distribution/LICENSE.bin.txt pulsar-manager/LICENSE
 $ cp ../distribution/NOTICE.bin.txt pulsar-manager/NOTICE
 $ cp -r ../distribution/licenses pulsar-manager/
 $ cp -r ../build/distributions/pulsar-manager.tar ../front-end/dist 
pulsar-manager
-$ tar -czvf apache-pulsar-manager-0.X.0-candidate-1-bin.tar.gz 
pulsar-manager.tar pulsar-manager
+$ tar -czvf apache-pulsar-manager-0.X.0-bin.tar.gz pulsar-manager.tar 
pulsar-manager
 ```
 
 4. Sign and stage the artifacts
 The src and bin artifacts need to be signed and uploaded to the dist SVN 
repository for staging.
 
 ```
-gpg -b --armor apache-pulsar-manager-0.X.0-candidate-1-bin.tar.gz
-gpg -b --armor apache-pulsar-manager-0.X.0-candidate-1-src.tar.gz
-shasum -a 512 apache-pulsar-manager-0.X.0-candidate-1-bin.tar.gz > 
apache-pulsar-manager-0.X.0-candidate-1-bin.tar.gz.sha512
-shasum -a 512 apache-pulsar-manager-0.X.0-candidate-1-src.tar.gz > 
apache-pulsar-manager-0.X.0-candidate-1-src.tar.gz.sha512
+gpg -b --armor apache-pulsar-manager-0.X.0-bin.tar.gz
+gpg -b --armor apache-pulsar-manager-0.X.0-src.tar.gz
+shasum -a 512 apache-pulsar-manager-0.X.0-bin.tar.gz > 
apache-pulsar-manager-0.X.0-bin.tar.gz.sha512
+shasum -a 512 apache-pulsar-manager-0.X.0-src.tar.gz > 
apache-pulsar-manager-0.X.0-src.tar.gz.sha512
 svn co https://dist.apache.org/repos/dist/dev/pulsar/pulsar-manager 
pulsar-manager
 cd pulsar-manager
 
 mkdir pulsar-manager-0.X.0-candidate-1
 
 cd pulsar-manager-0.X.0-candidate-1
-cp apache-pulsar-manager-0.X.0-candidate-1-src.tar.gz .
-cp apache-pulsar-manager-0.X.0-candidate-1-bin.tar.gz .
+cp apache-pulsar-manager-0.X.0-src.tar.gz .
+cp apache-pulsar-manager-0.X.0-bin.tar.gz .
 
 svn add *
 svn ci -m 'Staging artifacts and signature for Pulsar Manager release 0.X.0'
@@ -154,13 +154,13 @@ The vote will be open for at least 72 hours. It is 
adopted by majority approval,
 
 
 Source and binary files:
-https://dist.apache.org/repos/dist/dev/pulsar/pulsar-manager/apache-pulsar-manager-0.X.0-candidate-1-bin.tar.gz
-https://dist.apache.org/repos/dist/dev/pulsar/pulsar-manager/apache-pulsar-manager-0.X.0-candidate-1-src.tar.gz
+https://dist.apache.org/repos/dist/dev/pulsar/pulsar-manager/apache-pulsar-manager-0.X.0-bin.tar.gz
+https://dist.apache.org/repos/dist/dev/pulsar/pulsar-manager/apache-pulsar-manager-0.X.0-src.tar.gz
 
 SHA-1 checksums:
 
-028313cbbb24c5647e85a6df58a48d3c560aacc9  
apache-pulsar-manager-0.X.0-candidate-1-bin.tar.gz
-97bb1000f70011e9a585186590e0688586590e09  
apache-pulsar-manager-0.X.0-candidate-1-src.tar.gz
+028313cbbb24c5647e85a6df58a48d3c560aacc9  
apache-pulsar-manager-0.X.0-bin.tar.gz
+97bb1000f70011e9a585186590e0688586590e09  
apache-pulsar-manager-0.X.0-src.tar.gz
 ```
 
 The vote should be open for at least 72 hours (3 days). Votes from Pulsar PMC 
members will be considered binding, while anyone else is encouraged to verify 
the release and vote as well.
@@ -178,8 +178,8 @@ $ git push origin v0.X.0
 Promote the artifacts on the release location (need PMC permissions):
 
 ```
-svn move 
https://dist.apache.org/repos/dist/dev/pulsar/pulsar-manager/apache-pulsar-manager-0.X.0-candidate-1-src.tar.gz
 \
- 
https://dist.apache.org/repos/dist/release/pulsar/puslar-manager/pulsar-manager-0.X.0/apache-pulsar-manager-0.X.0-src.tar.gz
+svn move 
https://dist.apache.org/repos/dist/dev/pulsar/pulsar-manager/pulsar-manager-0.X.0-candidate-1
 \
+ 
https://dist.apache.org/repos/dist/release/pulsar/puslar-manager/pulsar-manager-0.X.0
 Remove the old releases (if any). We only need the latest release there, older 
releases are available through the Apache archive:
 ```
 ```



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350511036
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the pulsar manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
+
+
+```
+docker pull apachepulsar/pulsar-manager:v0.1.0
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.0.104 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* REDIRECT_HOST: the IP address of the front-end server.
+
+* REDIRECT_PORT: the port of the front-end server.
+
+* DRIVER_CLASS_NAME: the driver class name of PostgreSQL.
+
+* URL: the url of PostgreSQL jdbc, example: 
jdbc:postgresql://127.0.0.1:5432/pulsar_manager.
+
+* USERNAME: the username of PostgreSQL.
+
+* PASSWORD: the password of PostgreSQL.
+
+* LOG_LEVEL: level of log.
+
+You can find the in the 
[docker](https://github.com/apache/pulsar-manager/tree/master/docker) directory 
and build an image from scratch as well:
+
+```
+git clone https://github.com/apache/pulsar-manager
+cd pulsar-manager
+./gradlew build -x test
+cd front-end
+npm install --save
+npm run build:prod
+cd ..
+docker build -f docker/Dockerfile --build-arg BUILD_DATE=`date -u 
+"%Y-%m-%dT%H:%M:%SZ"` --build-arg VCS_REF=`latest` --build-arg 
VERSION=`latest` -t apachepulsar/pulsar-manager .
+```
+
+### Use custom databases
+
+If you have a large amount of data, you can use a custom database. The 
following is an example of PostgreSQL.   
+
+1. Initialize database and table structures using 
[file](https://github.com/apache/pulsar-manager/tree/master/src/main/resources/META-INF/sql/postgresql-schema.sql).
+
+2. Modify the [configuration 
file](https://github.com/apache/pulsar-manager/blob/master/src/main/resources/application.properties)
 and add PostgreSQL configuration
+
+```
+spring.datasource.driver-class-name=org.postgresql.Driver
+spring.datasource.url=jdbc:postgresql://127.0.0.1:5432/pulsar_manager
+spring.datasource.username=postgres
+spring.datasource.password=postgres
+```
+
+3. Compile to generate a new executable jar package
+
+```
+./gradlew -x build -x test
+```
+
+### Enable JWT Auth
+
+If you want to turn on JWT authentication, configure the following parameters:
+
+* backend.jwt.token  token for the superuser. You need to configure this 
parameter during cluster initialization.
+* jwt.broker.token.mode  Two modes of generating token, SECRET and PRIVATE.
+* jwt.broker.public.key Configure this option if you are using the PRIVATE 
mode.
+* jwt.broker.private.key Configure this option if you are using the PRIVATE 
mode.
+* jwt.broker.secret.key Configure this option if you are using the SECRET mode.
+
+For more information, see [Apache 
Pulsar](http://pulsar.apache.org/docs/en/security-token-admin/)
+
+* Method 1: Use command-line tool
+
+```
+./build/distributions/pulsar-manager/bin/pulsar-manager 
--redirect.host=http://localhost --redirect.port=9527 
insert.stats.interval=60 --backend.jwt.token=token 
--jwt.broker.token.mode=PRIVATE 
--jwt.broker.private.key=file:///path/broker-private.key 
--jwt.broker.public.key=file:///path/broker-public.key
+```
+
+* Method 2. Configure the application.properties file
+
+```
+backend.jwt.token=token
+
+jwt.broker.token.mode=PRIVATE
+jwt.broker.public.key=file:///path/broker-public.key
+jwt.broker.private.key=file:///path/broker-private.key
+
+or 
+jwt.broker.token.mode=SECRET
+jwt.broker.secret.key=file:///path/broker-secret.key
+```
+
+* Method 3: Use Docker only use token.
+
+```
+export JWT_TOKEN="your-token"
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.55.182 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -e JWT_TOKEN=$JWT_TOKEN -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* Method 4: Use Docker with token, public key and private key.
+
+```
+export JWT_TOKEN="your-token"
+export PRIVATE_KEY="file:///private-key-path"
+export PUBLIC_KEY="file:///public-key-path"
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.55.182 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127

svn commit: r36938 - /dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/ /release/pulsar/pulsar-manager/pulsar-manager-0.1.0/

2019-11-25 Thread zhaijia
Author: zhaijia
Date: Tue Nov 26 02:02:29 2019
New Revision: 36938

Log:
tuteng: update package name, remove candidate

Added:
release/pulsar/pulsar-manager/pulsar-manager-0.1.0/
  - copied from r36937, dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/
Removed:
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350511846
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the pulsar manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
+
+
+```
+docker pull apachepulsar/pulsar-manager:v0.1.0
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.0.104 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* REDIRECT_HOST: the IP address of the front-end server.
+
+* REDIRECT_PORT: the port of the front-end server.
+
+* DRIVER_CLASS_NAME: the driver class name of PostgreSQL.
+
+* URL: the url of PostgreSQL jdbc, example: 
jdbc:postgresql://127.0.0.1:5432/pulsar_manager.
+
+* USERNAME: the username of PostgreSQL.
+
+* PASSWORD: the password of PostgreSQL.
+
+* LOG_LEVEL: level of log.
+
+You can find the in the 
[docker](https://github.com/apache/pulsar-manager/tree/master/docker) directory 
and build an image from scratch as well:
+
+```
+git clone https://github.com/apache/pulsar-manager
+cd pulsar-manager
+./gradlew build -x test
+cd front-end
+npm install --save
+npm run build:prod
+cd ..
+docker build -f docker/Dockerfile --build-arg BUILD_DATE=`date -u 
+"%Y-%m-%dT%H:%M:%SZ"` --build-arg VCS_REF=`latest` --build-arg 
VERSION=`latest` -t apachepulsar/pulsar-manager .
+```
+
+### Use custom databases
+
+If you have a large amount of data, you can use a custom database. The 
following is an example of PostgreSQL.   
+
+1. Initialize database and table structures using 
[file](https://github.com/apache/pulsar-manager/tree/master/src/main/resources/META-INF/sql/postgresql-schema.sql).
+
+2. Modify the [configuration 
file](https://github.com/apache/pulsar-manager/blob/master/src/main/resources/application.properties)
 and add PostgreSQL configuration
+
+```
+spring.datasource.driver-class-name=org.postgresql.Driver
+spring.datasource.url=jdbc:postgresql://127.0.0.1:5432/pulsar_manager
+spring.datasource.username=postgres
+spring.datasource.password=postgres
+```
+
+3. Compile to generate a new executable jar package
+
+```
+./gradlew -x build -x test
+```
+
+### Enable JWT Auth
+
+If you want to turn on JWT authentication, configure the following parameters:
+
+* backend.jwt.token  token for the superuser. You need to configure this 
parameter during cluster initialization.
+* jwt.broker.token.mode  Two modes of generating token, SECRET and PRIVATE.
+* jwt.broker.public.key Configure this option if you are using the PRIVATE 
mode.
+* jwt.broker.private.key Configure this option if you are using the PRIVATE 
mode.
+* jwt.broker.secret.key Configure this option if you are using the SECRET mode.
+
+For more information, see [Apache 
Pulsar](http://pulsar.apache.org/docs/en/security-token-admin/)
+
+* Method 1: Use command-line tool
+
+```
+./build/distributions/pulsar-manager/bin/pulsar-manager 
--redirect.host=http://localhost --redirect.port=9527 
insert.stats.interval=60 --backend.jwt.token=token 
--jwt.broker.token.mode=PRIVATE 
--jwt.broker.private.key=file:///path/broker-private.key 
--jwt.broker.public.key=file:///path/broker-public.key
+```
+
+* Method 2. Configure the application.properties file
+
+```
+backend.jwt.token=token
+
+jwt.broker.token.mode=PRIVATE
+jwt.broker.public.key=file:///path/broker-public.key
+jwt.broker.private.key=file:///path/broker-private.key
+
+or 
+jwt.broker.token.mode=SECRET
+jwt.broker.secret.key=file:///path/broker-secret.key
+```
+
+* Method 3: Use Docker only use token.
+
+```
+export JWT_TOKEN="your-token"
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.55.182 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -e JWT_TOKEN=$JWT_TOKEN -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* Method 4: Use Docker with token, public key and private key.
+
+```
+export JWT_TOKEN="your-token"
+export PRIVATE_KEY="file:///private-key-path"
+export PUBLIC_KEY="file:///public-key-path"
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.55.182 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350511753
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the pulsar manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
+
+
+```
+docker pull apachepulsar/pulsar-manager:v0.1.0
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.0.104 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* REDIRECT_HOST: the IP address of the front-end server.
+
+* REDIRECT_PORT: the port of the front-end server.
+
+* DRIVER_CLASS_NAME: the driver class name of PostgreSQL.
+
+* URL: the url of PostgreSQL jdbc, example: 
jdbc:postgresql://127.0.0.1:5432/pulsar_manager.
+
+* USERNAME: the username of PostgreSQL.
+
+* PASSWORD: the password of PostgreSQL.
+
+* LOG_LEVEL: level of log.
+
+You can find the in the 
[docker](https://github.com/apache/pulsar-manager/tree/master/docker) directory 
and build an image from scratch as well:
+
+```
+git clone https://github.com/apache/pulsar-manager
+cd pulsar-manager
+./gradlew build -x test
+cd front-end
+npm install --save
+npm run build:prod
+cd ..
+docker build -f docker/Dockerfile --build-arg BUILD_DATE=`date -u 
+"%Y-%m-%dT%H:%M:%SZ"` --build-arg VCS_REF=`latest` --build-arg 
VERSION=`latest` -t apachepulsar/pulsar-manager .
+```
+
+### Use custom databases
+
+If you have a large amount of data, you can use a custom database. The 
following is an example of PostgreSQL.   
+
+1. Initialize database and table structures using 
[file](https://github.com/apache/pulsar-manager/tree/master/src/main/resources/META-INF/sql/postgresql-schema.sql).
+
+2. Modify the [configuration 
file](https://github.com/apache/pulsar-manager/blob/master/src/main/resources/application.properties)
 and add PostgreSQL configuration
+
+```
+spring.datasource.driver-class-name=org.postgresql.Driver
+spring.datasource.url=jdbc:postgresql://127.0.0.1:5432/pulsar_manager
+spring.datasource.username=postgres
+spring.datasource.password=postgres
+```
+
+3. Compile to generate a new executable jar package
+
+```
+./gradlew -x build -x test
+```
+
+### Enable JWT Auth
+
+If you want to turn on JWT authentication, configure the following parameters:
+
+* backend.jwt.token  token for the superuser. You need to configure this 
parameter during cluster initialization.
+* jwt.broker.token.mode  Two modes of generating token, SECRET and PRIVATE.
+* jwt.broker.public.key Configure this option if you are using the PRIVATE 
mode.
+* jwt.broker.private.key Configure this option if you are using the PRIVATE 
mode.
+* jwt.broker.secret.key Configure this option if you are using the SECRET mode.
+
+For more information, see [Apache 
Pulsar](http://pulsar.apache.org/docs/en/security-token-admin/)
+
+* Method 1: Use command-line tool
+
+```
+./build/distributions/pulsar-manager/bin/pulsar-manager 
--redirect.host=http://localhost --redirect.port=9527 
insert.stats.interval=60 --backend.jwt.token=token 
--jwt.broker.token.mode=PRIVATE 
--jwt.broker.private.key=file:///path/broker-private.key 
--jwt.broker.public.key=file:///path/broker-public.key
+```
+
+* Method 2. Configure the application.properties file
+
+```
+backend.jwt.token=token
+
+jwt.broker.token.mode=PRIVATE
+jwt.broker.public.key=file:///path/broker-public.key
+jwt.broker.private.key=file:///path/broker-private.key
+
+or 
+jwt.broker.token.mode=SECRET
+jwt.broker.secret.key=file:///path/broker-secret.key
+```
+
+* Method 3: Use Docker only use token.
+
+```
+export JWT_TOKEN="your-token"
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.55.182 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -e JWT_TOKEN=$JWT_TOKEN -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* Method 4: Use Docker with token, public key and private key.
+
+```
+export JWT_TOKEN="your-token"
+export PRIVATE_KEY="file:///private-key-path"
+export PUBLIC_KEY="file:///public-key-path"
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.55.182 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127

svn commit: r36937 - /dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/

2019-11-25 Thread guangning
Author: guangning
Date: Tue Nov 26 01:59:18 2019
New Revision: 36937

Log:
Staging artifacts and signature for Pulsar Manager release 0.1.0

Added:

dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-bin.tar.gz
   (with props)

dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-bin.tar.gz.asc

dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-bin.tar.gz.sha512

dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-src.tar.gz
   (with props)

dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-src.tar.gz.asc

dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-src.tar.gz.sha512

Added: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-bin.tar.gz
==
Binary file - no diff available.

Propchange: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-bin.tar.gz
--
svn:mime-type = application/octet-stream

Added: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-bin.tar.gz.asc
==
--- 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-bin.tar.gz.asc
 (added)
+++ 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-bin.tar.gz.asc
 Tue Nov 26 01:59:18 2019
@@ -0,0 +1,11 @@
+-BEGIN PGP SIGNATURE-
+
+iQEzBAABCAAdFiEEfLgyKwIZSFWNsgIYV3wHyoZ66RAFAl3Td9EACgkQV3wHyoZ6
+6RBGYwgAww1LeifQzwZp8EiZkjouDZmlN7BJQeNt1Thum0kp96JMVG61DDxv8B+p
+2aw1vVidcCLETq1+B6im6VICrXjlPyOwRVKit4r109+OQcVYa0z49lnBfeUK10Nm
+aNRK6ny1vhLOHe54d/N65ar6tvQpdwqQfA/K/+zcR/OwJSRCcSolmaqqOnW4pmaC
+3ymCBM8vbl+sTUd7E5q9xBGJqhPdbuJzVjjybLoKVZatuba5BYbsX1uDMKiRXSTt
+QbjwCpMsvXvd7wIJXEEVP/pWPdXBUqG2X7LUnNOnDYdkwZ64lTxbFpn/b4THG6aB
+aGJKhxOhWaj64nZuL6gDs3FsXppVoQ==
+=P4u/
+-END PGP SIGNATURE-

Added: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-bin.tar.gz.sha512
==
--- 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-bin.tar.gz.sha512
 (added)
+++ 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-bin.tar.gz.sha512
 Tue Nov 26 01:59:18 2019
@@ -0,0 +1 @@
+bc25543b1693efc9eb1e037a1ae8cb68a1fe30edf69b179cf415a27dcc61fc4398928ea1a52053bcaa7baf51e0365a2bd3d609b712de4e4ebe8ae105602ac3ef
  apache-pulsar-manager-0.1.0-bin.tar.gz

Added: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-src.tar.gz
==
Binary file - no diff available.

Propchange: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-src.tar.gz
--
svn:mime-type = application/octet-stream

Added: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-src.tar.gz.asc
==
--- 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-src.tar.gz.asc
 (added)
+++ 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-src.tar.gz.asc
 Tue Nov 26 01:59:18 2019
@@ -0,0 +1,11 @@
+-BEGIN PGP SIGNATURE-
+
+iQEzBAABCAAdFiEEfLgyKwIZSFWNsgIYV3wHyoZ66RAFAl3Td9oACgkQV3wHyoZ6
+6RDFeAgA7wq4PVJrtWgO7kkVVYZ+ScOAZKXGUqQfk7+zxjBRji41ATIaXFcuj5Z8
+6AhWcNFc23uNiSzMqIqKXpTIcNyd9YR2R65NGwbK+SasbFYtfBCQPY0hpvQWyfme
+Guh7S2dQtQGL5hsWaq55T3DADCZjwedST8ZGTwgSbQ7klWdiPjY9qhyiz0RZpDQQ
+hK3ouqi1ozKxRr/RwHPLe4APSFVne99kbF8cB8rh/csQXC36udAjBgVgmdRzLiZm
+qZVLjausH/xiQD5yQxiFGLcnXv5vlB2E764uepFq70fSq8hlcWymfhDBzz46PtwN
+vHXrqPYyaO0ZvBPTtLyUHiIpL6mT4w==
+=ofaN
+-END PGP SIGNATURE-

Added: 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-src.tar.gz.sha512
==
--- 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-src.tar.gz.sha512
 (added)
+++ 
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/apache-pulsar-manager-0.1.0-src.tar.gz.sha512
 Tue Nov 26 01:59:18 2019
@@ -0,0 +1 @@
+da75944d288bc91a2dca17e5a13ad30300b7c433ecc6a55dd7b3e64db889a46019b0d027e5dbd2932cc90694e1fb526356e0739fde594b57e16a0675be876c6c
  apache-pulsar-manager-0.1.0-src.tar.gz




[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350510836
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the pulsar manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
+
+
+```
+docker pull apachepulsar/pulsar-manager:v0.1.0
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.0.104 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* REDIRECT_HOST: the IP address of the front-end server.
+
+* REDIRECT_PORT: the port of the front-end server.
+
+* DRIVER_CLASS_NAME: the driver class name of PostgreSQL.
+
+* URL: the url of PostgreSQL jdbc, example: 
jdbc:postgresql://127.0.0.1:5432/pulsar_manager.
+
+* USERNAME: the username of PostgreSQL.
+
+* PASSWORD: the password of PostgreSQL.
+
+* LOG_LEVEL: level of log.
+
+You can find the in the 
[docker](https://github.com/apache/pulsar-manager/tree/master/docker) directory 
and build an image from scratch as well:
+
+```
+git clone https://github.com/apache/pulsar-manager
+cd pulsar-manager
+./gradlew build -x test
+cd front-end
+npm install --save
+npm run build:prod
+cd ..
+docker build -f docker/Dockerfile --build-arg BUILD_DATE=`date -u 
+"%Y-%m-%dT%H:%M:%SZ"` --build-arg VCS_REF=`latest` --build-arg 
VERSION=`latest` -t apachepulsar/pulsar-manager .
+```
+
+### Use custom databases
+
+If you have a large amount of data, you can use a custom database. The 
following is an example of PostgreSQL.   
+
+1. Initialize database and table structures using 
[file](https://github.com/apache/pulsar-manager/tree/master/src/main/resources/META-INF/sql/postgresql-schema.sql).
+
+2. Modify the [configuration 
file](https://github.com/apache/pulsar-manager/blob/master/src/main/resources/application.properties)
 and add PostgreSQL configuration
+
+```
+spring.datasource.driver-class-name=org.postgresql.Driver
+spring.datasource.url=jdbc:postgresql://127.0.0.1:5432/pulsar_manager
+spring.datasource.username=postgres
+spring.datasource.password=postgres
+```
+
+3. Compile to generate a new executable jar package
+
+```
+./gradlew -x build -x test
+```
+
+### Enable JWT Auth
+
+If you want to turn on JWT authentication, configure the following parameters:
+
+* backend.jwt.token  token for the superuser. You need to configure this 
parameter during cluster initialization.
+* jwt.broker.token.mode  Two modes of generating token, SECRET and PRIVATE.
+* jwt.broker.public.key Configure this option if you are using the PRIVATE 
mode.
+* jwt.broker.private.key Configure this option if you are using the PRIVATE 
mode.
+* jwt.broker.secret.key Configure this option if you are using the SECRET mode.
+
+For more information, see [Apache 
Pulsar](http://pulsar.apache.org/docs/en/security-token-admin/)
+
+* Method 1: Use command-line tool
+
+```
+./build/distributions/pulsar-manager/bin/pulsar-manager 
--redirect.host=http://localhost --redirect.port=9527 
insert.stats.interval=60 --backend.jwt.token=token 
--jwt.broker.token.mode=PRIVATE 
--jwt.broker.private.key=file:///path/broker-private.key 
--jwt.broker.public.key=file:///path/broker-public.key
+```
+
+* Method 2. Configure the application.properties file
+
+```
+backend.jwt.token=token
+
+jwt.broker.token.mode=PRIVATE
+jwt.broker.public.key=file:///path/broker-public.key
+jwt.broker.private.key=file:///path/broker-private.key
+
+or 
+jwt.broker.token.mode=SECRET
+jwt.broker.secret.key=file:///path/broker-secret.key
+```
+
+* Method 3: Use Docker only use token.
 
 Review comment:
   What does "use Docker only use token" mean?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350510741
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the pulsar manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
+
+
+```
+docker pull apachepulsar/pulsar-manager:v0.1.0
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.0.104 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* REDIRECT_HOST: the IP address of the front-end server.
+
+* REDIRECT_PORT: the port of the front-end server.
+
+* DRIVER_CLASS_NAME: the driver class name of PostgreSQL.
+
+* URL: the url of PostgreSQL jdbc, example: 
jdbc:postgresql://127.0.0.1:5432/pulsar_manager.
+
+* USERNAME: the username of PostgreSQL.
+
+* PASSWORD: the password of PostgreSQL.
+
+* LOG_LEVEL: level of log.
+
+You can find the in the 
[docker](https://github.com/apache/pulsar-manager/tree/master/docker) directory 
and build an image from scratch as well:
+
+```
+git clone https://github.com/apache/pulsar-manager
+cd pulsar-manager
+./gradlew build -x test
+cd front-end
+npm install --save
+npm run build:prod
+cd ..
+docker build -f docker/Dockerfile --build-arg BUILD_DATE=`date -u 
+"%Y-%m-%dT%H:%M:%SZ"` --build-arg VCS_REF=`latest` --build-arg 
VERSION=`latest` -t apachepulsar/pulsar-manager .
+```
+
+### Use custom databases
+
+If you have a large amount of data, you can use a custom database. The 
following is an example of PostgreSQL.   
+
+1. Initialize database and table structures using 
[file](https://github.com/apache/pulsar-manager/tree/master/src/main/resources/META-INF/sql/postgresql-schema.sql).
+
+2. Modify the [configuration 
file](https://github.com/apache/pulsar-manager/blob/master/src/main/resources/application.properties)
 and add PostgreSQL configuration
+
+```
+spring.datasource.driver-class-name=org.postgresql.Driver
+spring.datasource.url=jdbc:postgresql://127.0.0.1:5432/pulsar_manager
+spring.datasource.username=postgres
+spring.datasource.password=postgres
+```
+
+3. Compile to generate a new executable jar package
+
+```
+./gradlew -x build -x test
+```
+
+### Enable JWT Auth
+
+If you want to turn on JWT authentication, configure the following parameters:
+
+* backend.jwt.token  token for the superuser. You need to configure this 
parameter during cluster initialization.
+* jwt.broker.token.mode  Two modes of generating token, SECRET and PRIVATE.
+* jwt.broker.public.key Configure this option if you are using the PRIVATE 
mode.
+* jwt.broker.private.key Configure this option if you are using the PRIVATE 
mode.
+* jwt.broker.secret.key Configure this option if you are using the SECRET mode.
+
+For more information, see [Apache 
Pulsar](http://pulsar.apache.org/docs/en/security-token-admin/)
+
+* Method 1: Use command-line tool
+
+```
+./build/distributions/pulsar-manager/bin/pulsar-manager 
--redirect.host=http://localhost --redirect.port=9527 
insert.stats.interval=60 --backend.jwt.token=token 
--jwt.broker.token.mode=PRIVATE 
--jwt.broker.private.key=file:///path/broker-private.key 
--jwt.broker.public.key=file:///path/broker-public.key
+```
+
+* Method 2. Configure the application.properties file
 
 Review comment:
   ```suggestion
   * Method 2: Configure the application.properties file
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350510594
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the pulsar manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
+
+
+```
+docker pull apachepulsar/pulsar-manager:v0.1.0
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.0.104 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* REDIRECT_HOST: the IP address of the front-end server.
+
+* REDIRECT_PORT: the port of the front-end server.
+
+* DRIVER_CLASS_NAME: the driver class name of PostgreSQL.
+
+* URL: the url of PostgreSQL jdbc, example: 
jdbc:postgresql://127.0.0.1:5432/pulsar_manager.
+
+* USERNAME: the username of PostgreSQL.
+
+* PASSWORD: the password of PostgreSQL.
+
+* LOG_LEVEL: level of log.
+
+You can find the in the 
[docker](https://github.com/apache/pulsar-manager/tree/master/docker) directory 
and build an image from scratch as well:
+
+```
+git clone https://github.com/apache/pulsar-manager
+cd pulsar-manager
+./gradlew build -x test
+cd front-end
+npm install --save
+npm run build:prod
+cd ..
+docker build -f docker/Dockerfile --build-arg BUILD_DATE=`date -u 
+"%Y-%m-%dT%H:%M:%SZ"` --build-arg VCS_REF=`latest` --build-arg 
VERSION=`latest` -t apachepulsar/pulsar-manager .
+```
+
+### Use custom databases
+
+If you have a large amount of data, you can use a custom database. The 
following is an example of PostgreSQL.   
+
+1. Initialize database and table structures using 
[file](https://github.com/apache/pulsar-manager/tree/master/src/main/resources/META-INF/sql/postgresql-schema.sql).
+
+2. Modify the [configuration 
file](https://github.com/apache/pulsar-manager/blob/master/src/main/resources/application.properties)
 and add PostgreSQL configuration
+
+```
+spring.datasource.driver-class-name=org.postgresql.Driver
+spring.datasource.url=jdbc:postgresql://127.0.0.1:5432/pulsar_manager
+spring.datasource.username=postgres
+spring.datasource.password=postgres
+```
+
+3. Compile to generate a new executable jar package
+
+```
+./gradlew -x build -x test
+```
+
+### Enable JWT Auth
+
+If you want to turn on JWT authentication, configure the following parameters:
+
+* backend.jwt.token  token for the superuser. You need to configure this 
parameter during cluster initialization.
+* jwt.broker.token.mode  Two modes of generating token, SECRET and PRIVATE.
+* jwt.broker.public.key Configure this option if you are using the PRIVATE 
mode.
+* jwt.broker.private.key Configure this option if you are using the PRIVATE 
mode.
+* jwt.broker.secret.key Configure this option if you are using the SECRET mode.
+
+For more information, see [Apache 
Pulsar](http://pulsar.apache.org/docs/en/security-token-admin/)
 
 Review comment:
   ```suggestion
   For more information, see [Token Authentication Admin of 
Pulsar](http://pulsar.apache.org/docs/en/security-token-admin/).
   ```
   
   Tell users more and accurate info.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350510315
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the pulsar manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
+
+
+```
+docker pull apachepulsar/pulsar-manager:v0.1.0
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.0.104 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* REDIRECT_HOST: the IP address of the front-end server.
+
+* REDIRECT_PORT: the port of the front-end server.
+
+* DRIVER_CLASS_NAME: the driver class name of PostgreSQL.
+
+* URL: the url of PostgreSQL jdbc, example: 
jdbc:postgresql://127.0.0.1:5432/pulsar_manager.
+
+* USERNAME: the username of PostgreSQL.
+
+* PASSWORD: the password of PostgreSQL.
+
+* LOG_LEVEL: level of log.
+
+You can find the in the 
[docker](https://github.com/apache/pulsar-manager/tree/master/docker) directory 
and build an image from scratch as well:
+
+```
+git clone https://github.com/apache/pulsar-manager
+cd pulsar-manager
+./gradlew build -x test
+cd front-end
+npm install --save
+npm run build:prod
+cd ..
+docker build -f docker/Dockerfile --build-arg BUILD_DATE=`date -u 
+"%Y-%m-%dT%H:%M:%SZ"` --build-arg VCS_REF=`latest` --build-arg 
VERSION=`latest` -t apachepulsar/pulsar-manager .
+```
+
+### Use custom databases
+
+If you have a large amount of data, you can use a custom database. The 
following is an example of PostgreSQL.   
+
+1. Initialize database and table structures using 
[file](https://github.com/apache/pulsar-manager/tree/master/src/main/resources/META-INF/sql/postgresql-schema.sql).
+
+2. Modify the [configuration 
file](https://github.com/apache/pulsar-manager/blob/master/src/main/resources/application.properties)
 and add PostgreSQL configuration
+
+```
+spring.datasource.driver-class-name=org.postgresql.Driver
+spring.datasource.url=jdbc:postgresql://127.0.0.1:5432/pulsar_manager
+spring.datasource.username=postgres
+spring.datasource.password=postgres
+```
+
+3. Compile to generate a new executable jar package
+
+```
+./gradlew -x build -x test
+```
+
+### Enable JWT Auth
+
+If you want to turn on JWT authentication, configure the following parameters:
+
+* backend.jwt.token  token for the superuser. You need to configure this 
parameter during cluster initialization.
 
 Review comment:
   ```suggestion
   * `backend.jwt.token`: token for the superuser. You need to configure this 
parameter during cluster initialization.
   ```
   
   Please check all (line 72-75).
   
   
![image](https://user-images.githubusercontent.com/50226895/69592993-bcca3880-1032-11ea-89cc-4fb9a1a57cff.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350510315
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the pulsar manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
+
+
+```
+docker pull apachepulsar/pulsar-manager:v0.1.0
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.0.104 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* REDIRECT_HOST: the IP address of the front-end server.
+
+* REDIRECT_PORT: the port of the front-end server.
+
+* DRIVER_CLASS_NAME: the driver class name of PostgreSQL.
+
+* URL: the url of PostgreSQL jdbc, example: 
jdbc:postgresql://127.0.0.1:5432/pulsar_manager.
+
+* USERNAME: the username of PostgreSQL.
+
+* PASSWORD: the password of PostgreSQL.
+
+* LOG_LEVEL: level of log.
+
+You can find the in the 
[docker](https://github.com/apache/pulsar-manager/tree/master/docker) directory 
and build an image from scratch as well:
+
+```
+git clone https://github.com/apache/pulsar-manager
+cd pulsar-manager
+./gradlew build -x test
+cd front-end
+npm install --save
+npm run build:prod
+cd ..
+docker build -f docker/Dockerfile --build-arg BUILD_DATE=`date -u 
+"%Y-%m-%dT%H:%M:%SZ"` --build-arg VCS_REF=`latest` --build-arg 
VERSION=`latest` -t apachepulsar/pulsar-manager .
+```
+
+### Use custom databases
+
+If you have a large amount of data, you can use a custom database. The 
following is an example of PostgreSQL.   
+
+1. Initialize database and table structures using 
[file](https://github.com/apache/pulsar-manager/tree/master/src/main/resources/META-INF/sql/postgresql-schema.sql).
+
+2. Modify the [configuration 
file](https://github.com/apache/pulsar-manager/blob/master/src/main/resources/application.properties)
 and add PostgreSQL configuration
+
+```
+spring.datasource.driver-class-name=org.postgresql.Driver
+spring.datasource.url=jdbc:postgresql://127.0.0.1:5432/pulsar_manager
+spring.datasource.username=postgres
+spring.datasource.password=postgres
+```
+
+3. Compile to generate a new executable jar package
+
+```
+./gradlew -x build -x test
+```
+
+### Enable JWT Auth
+
+If you want to turn on JWT authentication, configure the following parameters:
+
+* backend.jwt.token  token for the superuser. You need to configure this 
parameter during cluster initialization.
 
 Review comment:
   ```suggestion
   * `backend.jwt.token`: token for the superuser. You need to configure this 
parameter during cluster initialization.
   ```
   
   Please check all.
   
   
![image](https://user-images.githubusercontent.com/50226895/69592993-bcca3880-1032-11ea-89cc-4fb9a1a57cff.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350510071
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the pulsar manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
+
+
+```
+docker pull apachepulsar/pulsar-manager:v0.1.0
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.0.104 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* REDIRECT_HOST: the IP address of the front-end server.
+
+* REDIRECT_PORT: the port of the front-end server.
+
+* DRIVER_CLASS_NAME: the driver class name of PostgreSQL.
+
+* URL: the url of PostgreSQL jdbc, example: 
jdbc:postgresql://127.0.0.1:5432/pulsar_manager.
+
+* USERNAME: the username of PostgreSQL.
+
+* PASSWORD: the password of PostgreSQL.
+
+* LOG_LEVEL: level of log.
+
+You can find the in the 
[docker](https://github.com/apache/pulsar-manager/tree/master/docker) directory 
and build an image from scratch as well:
+
+```
+git clone https://github.com/apache/pulsar-manager
+cd pulsar-manager
+./gradlew build -x test
+cd front-end
+npm install --save
+npm run build:prod
+cd ..
+docker build -f docker/Dockerfile --build-arg BUILD_DATE=`date -u 
+"%Y-%m-%dT%H:%M:%SZ"` --build-arg VCS_REF=`latest` --build-arg 
VERSION=`latest` -t apachepulsar/pulsar-manager .
+```
+
+### Use custom databases
+
+If you have a large amount of data, you can use a custom database. The 
following is an example of PostgreSQL.   
+
+1. Initialize database and table structures using 
[file](https://github.com/apache/pulsar-manager/tree/master/src/main/resources/META-INF/sql/postgresql-schema.sql).
+
+2. Modify the [configuration 
file](https://github.com/apache/pulsar-manager/blob/master/src/main/resources/application.properties)
 and add PostgreSQL configuration
+
+```
+spring.datasource.driver-class-name=org.postgresql.Driver
+spring.datasource.url=jdbc:postgresql://127.0.0.1:5432/pulsar_manager
+spring.datasource.username=postgres
+spring.datasource.password=postgres
+```
+
+3. Compile to generate a new executable jar package
+
+```
+./gradlew -x build -x test
+```
+
+### Enable JWT Auth
 
 Review comment:
   ```suggestion
   ### Enable JWT authentication
   ```
   
   We use sentence case rather than title case for heading.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350509909
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the pulsar manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
+
+
+```
+docker pull apachepulsar/pulsar-manager:v0.1.0
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.0.104 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* REDIRECT_HOST: the IP address of the front-end server.
+
+* REDIRECT_PORT: the port of the front-end server.
+
+* DRIVER_CLASS_NAME: the driver class name of PostgreSQL.
+
+* URL: the url of PostgreSQL jdbc, example: 
jdbc:postgresql://127.0.0.1:5432/pulsar_manager.
+
+* USERNAME: the username of PostgreSQL.
+
+* PASSWORD: the password of PostgreSQL.
+
+* LOG_LEVEL: level of log.
+
+You can find the in the 
[docker](https://github.com/apache/pulsar-manager/tree/master/docker) directory 
and build an image from scratch as well:
+
+```
+git clone https://github.com/apache/pulsar-manager
+cd pulsar-manager
+./gradlew build -x test
+cd front-end
+npm install --save
+npm run build:prod
+cd ..
+docker build -f docker/Dockerfile --build-arg BUILD_DATE=`date -u 
+"%Y-%m-%dT%H:%M:%SZ"` --build-arg VCS_REF=`latest` --build-arg 
VERSION=`latest` -t apachepulsar/pulsar-manager .
+```
+
+### Use custom databases
+
+If you have a large amount of data, you can use a custom database. The 
following is an example of PostgreSQL.   
+
+1. Initialize database and table structures using 
[file](https://github.com/apache/pulsar-manager/tree/master/src/main/resources/META-INF/sql/postgresql-schema.sql).
+
+2. Modify the [configuration 
file](https://github.com/apache/pulsar-manager/blob/master/src/main/resources/application.properties)
 and add PostgreSQL configuration
+
+```
+spring.datasource.driver-class-name=org.postgresql.Driver
+spring.datasource.url=jdbc:postgresql://127.0.0.1:5432/pulsar_manager
+spring.datasource.username=postgres
+spring.datasource.password=postgres
+```
+
+3. Compile to generate a new executable jar package
 
 Review comment:
   ```suggestion
   3. Compile to generate a new executable jar package.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5513: Publish rate limit on broker to avoid OOM

2019-11-25 Thread GitBox
jiazhai commented on issue #5513: Publish rate limit on broker to avoid OOM
URL: https://github.com/apache/pulsar/issues/5513#issuecomment-558422247
 
 
   @rdhabalia @sijie Thanks for your comments. And many thanks for @rdhabalia 
's PR #3985, It worked well in our test. 
   And as the steps that @sijie mentioned, It could be reproduced easy in user 
side. And user complained a lot for this OOM. This should be a good way to 
solve this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350509778
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the pulsar manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
+
+
+```
+docker pull apachepulsar/pulsar-manager:v0.1.0
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.0.104 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* REDIRECT_HOST: the IP address of the front-end server.
+
+* REDIRECT_PORT: the port of the front-end server.
+
+* DRIVER_CLASS_NAME: the driver class name of PostgreSQL.
+
+* URL: the url of PostgreSQL jdbc, example: 
jdbc:postgresql://127.0.0.1:5432/pulsar_manager.
+
+* USERNAME: the username of PostgreSQL.
+
+* PASSWORD: the password of PostgreSQL.
+
+* LOG_LEVEL: level of log.
+
+You can find the in the 
[docker](https://github.com/apache/pulsar-manager/tree/master/docker) directory 
and build an image from scratch as well:
+
+```
+git clone https://github.com/apache/pulsar-manager
+cd pulsar-manager
+./gradlew build -x test
+cd front-end
+npm install --save
+npm run build:prod
+cd ..
+docker build -f docker/Dockerfile --build-arg BUILD_DATE=`date -u 
+"%Y-%m-%dT%H:%M:%SZ"` --build-arg VCS_REF=`latest` --build-arg 
VERSION=`latest` -t apachepulsar/pulsar-manager .
+```
+
+### Use custom databases
+
+If you have a large amount of data, you can use a custom database. The 
following is an example of PostgreSQL.   
+
+1. Initialize database and table structures using 
[file](https://github.com/apache/pulsar-manager/tree/master/src/main/resources/META-INF/sql/postgresql-schema.sql).
+
+2. Modify the [configuration 
file](https://github.com/apache/pulsar-manager/blob/master/src/main/resources/application.properties)
 and add PostgreSQL configuration
 
 Review comment:
   ```suggestion
   2. Modify the [configuration 
file](https://github.com/apache/pulsar-manager/blob/master/src/main/resources/application.properties)
 and add PostgreSQL configuration.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350509282
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the pulsar manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
+
+
+```
+docker pull apachepulsar/pulsar-manager:v0.1.0
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.0.104 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* REDIRECT_HOST: the IP address of the front-end server.
+
+* REDIRECT_PORT: the port of the front-end server.
+
+* DRIVER_CLASS_NAME: the driver class name of PostgreSQL.
+
+* URL: the url of PostgreSQL jdbc, example: 
jdbc:postgresql://127.0.0.1:5432/pulsar_manager.
+
+* USERNAME: the username of PostgreSQL.
+
+* PASSWORD: the password of PostgreSQL.
+
+* LOG_LEVEL: level of log.
+
+You can find the in the 
[docker](https://github.com/apache/pulsar-manager/tree/master/docker) directory 
and build an image from scratch as well:
+
+```
+git clone https://github.com/apache/pulsar-manager
+cd pulsar-manager
+./gradlew build -x test
+cd front-end
+npm install --save
+npm run build:prod
+cd ..
+docker build -f docker/Dockerfile --build-arg BUILD_DATE=`date -u 
+"%Y-%m-%dT%H:%M:%SZ"` --build-arg VCS_REF=`latest` --build-arg 
VERSION=`latest` -t apachepulsar/pulsar-manager .
+```
+
+### Use custom databases
+
+If you have a large amount of data, you can use a custom database. The 
following is an example of PostgreSQL.   
+
+1. Initialize database and table structures using 
[file](https://github.com/apache/pulsar-manager/tree/master/src/main/resources/META-INF/sql/postgresql-schema.sql).
 
 Review comment:
   ```suggestion
   1. Initialize database and table structures using the 
[file](https://github.com/apache/pulsar-manager/tree/master/src/main/resources/META-INF/sql/postgresql-schema.sql).
   ```
   
   Please use a grammar tool to check basic grammar mistakes before submitting 
a PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


svn commit: r36936 - /dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/

2019-11-25 Thread guangning
Author: guangning
Date: Tue Nov 26 01:49:33 2019
New Revision: 36936

Log:
Staging artifacts and signature for Pulsar Manager release 0.1.0

Added:
dev/pulsar/pulsar-manager/pulsar-manager-0.1.0/



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350508726
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the pulsar manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
+
+
+```
+docker pull apachepulsar/pulsar-manager:v0.1.0
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.0.104 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* REDIRECT_HOST: the IP address of the front-end server.
+
+* REDIRECT_PORT: the port of the front-end server.
+
+* DRIVER_CLASS_NAME: the driver class name of PostgreSQL.
+
+* URL: the url of PostgreSQL jdbc, example: 
jdbc:postgresql://127.0.0.1:5432/pulsar_manager.
+
+* USERNAME: the username of PostgreSQL.
+
+* PASSWORD: the password of PostgreSQL.
+
+* LOG_LEVEL: level of log.
+
+You can find the in the 
[docker](https://github.com/apache/pulsar-manager/tree/master/docker) directory 
and build an image from scratch as well:
 
 Review comment:
   Find what in the Docker?
   
   Please capitalize "Docker" correctly. I suggest using a grammar tool before 
submitting a PR. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350508450
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the pulsar manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
+
+
+```
+docker pull apachepulsar/pulsar-manager:v0.1.0
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.0.104 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* REDIRECT_HOST: the IP address of the front-end server.
+
+* REDIRECT_PORT: the port of the front-end server.
+
+* DRIVER_CLASS_NAME: the driver class name of PostgreSQL.
+
+* URL: the url of PostgreSQL jdbc, example: 
jdbc:postgresql://127.0.0.1:5432/pulsar_manager.
 
 Review comment:
   ```suggestion
   * URL: the URL of PostgreSQL JDBC. For example, 
`jdbc:postgresql://127.0.0.1:5432/pulsar_manager`.
   ```
   
   Please capitalize proper nouns correctly. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350508224
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the pulsar manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
 
 Review comment:
   ```suggestion
   The easiest way to use the Pulsar Manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
   ```
   
   Pulsar Manager is a proper noun, please use the correct capitalization and 
check all occurrences.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on issue #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-25 Thread GitBox
Anonymitaet commented on issue #5741: [website]Add content of pulsar-manager in 
website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#issuecomment-558418055
 
 
   @Jennifer88huang glad to help
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] rdhabalia commented on issue #5742: [pulsar-broker] add support to configure max pending publish request per connection

2019-11-25 Thread GitBox
rdhabalia commented on issue #5742: [pulsar-broker] add support to configure 
max pending publish request per connection
URL: https://github.com/apache/pulsar/pull/5742#issuecomment-558412769
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] rdhabalia commented on issue #5513: Publish rate limit on broker to avoid OOM

2019-11-25 Thread GitBox
rdhabalia commented on issue #5513: Publish rate limit on broker to avoid OOM
URL: https://github.com/apache/pulsar/issues/5513#issuecomment-558405439
 
 
   >  (I have tried to explain that existing approaches don't apply to our 
requirements as above)
   
   sure. If you feel this will be useful for your usecase and useful to your 
users then we can add it. 👍 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5513: Publish rate limit on broker to avoid OOM

2019-11-25 Thread GitBox
sijie commented on issue #5513: Publish rate limit on broker to avoid OOM
URL: https://github.com/apache/pulsar/issues/5513#issuecomment-558405159
 
 
   > all threads are going to do rate limit using one counter and that could be 
bottleneck as well so, one wants to avoid it as well.
   
   The current implementation of RateLimiter is using LongAdder for counting 
the bytes and msgs. A LongAdder maintains multiple cells for counters. They are 
only aggregated when `sum` is called. The `sum` is called when the monitor, 
which is done periodically in the background thread. I am not sure how this 
would be a bottleneck.
   
   LongAdder is also used for other metrics. Shouldn't they be all concerned as 
well?  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5513: Publish rate limit on broker to avoid OOM

2019-11-25 Thread GitBox
sijie commented on issue #5513: Publish rate limit on broker to avoid OOM
URL: https://github.com/apache/pulsar/issues/5513#issuecomment-558402635
 
 
   > I wanted to figure out root cause of OOM as we are trying to target that 
issue mainly
   
   what else we can provide you to figure out the root cause of OOM?
   
   > I had verified autoread behavior while implementing #3985 so,
   
   We also verified #3985 works as expected. As I explained, auto-read 
mechanism is not a problem. The problem is we need to a broker-level 
metric/mechanism to disable auto-read, which is not a namespace based or a 
connection based mechanism. That's why we need a broker-level rate limiter.
   
   > also, all threads are going to do rate limit using one counter and that 
could be bottleneck as well so, one wants to avoid it as well.
   
   1) this is a feature that users can turn it on/off. If people doesn't need 
this feature, they don't have to turn on broker-level rate limiting.
   2) If current counter is a bottleneck, we can seek for an improved method to 
improve counting. e.g. a better counter implementation.
   
   The question here is more about: do we need a broker-level mechanism to meet 
the requirements of running Pulsar at high load? If we need, then why not adopt 
the rate limiter approach? If we don't, then what are the other approaches? (I 
have tried to explain that existing approaches don't apply to our requirements 
as above)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Jennifer88huang commented on issue #5632: [Issue 5614] Deprecate brokerServicePurgeInactiveFrequencyInSeconds

2019-11-25 Thread GitBox
Jennifer88huang commented on issue #5632: [Issue 5614] Deprecate 
brokerServicePurgeInactiveFrequencyInSeconds
URL: https://github.com/apache/pulsar/pull/5632#issuecomment-558399925
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] rdhabalia commented on issue #5513: Publish rate limit on broker to avoid OOM

2019-11-25 Thread GitBox
rdhabalia commented on issue #5513: Publish rate limit on broker to avoid OOM
URL: https://github.com/apache/pulsar/issues/5513#issuecomment-558398519
 
 
   >> putting OOM question aside, what are the concerns of adding a 
broker-level rate limiter
   
   I wanted to figure out root cause of OOM as we are trying to target that 
issue mainly. I had verified autoread behavior while implementing #3985 so, was 
curious about the actual issue. also, all threads are going to do rate limit 
using one counter and that could be bottleneck as well so, one wants to avoid 
it as well.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Jennifer88huang commented on issue #5562: Add the doc for new schema compatibility strategy.

2019-11-25 Thread GitBox
Jennifer88huang commented on issue #5562: Add the doc for new schema 
compatibility  strategy.
URL: https://github.com/apache/pulsar/issues/5562#issuecomment-558397620
 
 
   Got it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client.

2019-11-25 Thread GitBox
codelipenghui commented on issue #5680: [transaction-coordinator] 
Implementation of transaction coordinator client.
URL: https://github.com/apache/pulsar/pull/5680#issuecomment-558396950
 
 
   run java8 tests
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Jennifer88huang commented on issue #4753: [docs] Add documentation for Functions develop: encryption

2019-11-25 Thread GitBox
Jennifer88huang commented on issue #4753: [docs] Add documentation for 
Functions develop: encryption
URL: https://github.com/apache/pulsar/issues/4753#issuecomment-558396789
 
 
   Got it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Jennifer88huang commented on issue #4752: [docs] Add Go SerDe option

2019-11-25 Thread GitBox
Jennifer88huang commented on issue #4752: [docs] Add Go SerDe option
URL: https://github.com/apache/pulsar/issues/4752#issuecomment-558396386
 
 
   @sijie Got it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Jennifer88huang commented on issue #4704: Add documentation for HDFS offloader

2019-11-25 Thread GitBox
Jennifer88huang commented on issue #4704: Add documentation for HDFS offloader
URL: https://github.com/apache/pulsar/issues/4704#issuecomment-558396118
 
 
   @sijie Got it, I've contacted with @congbobo184 on this issue last week, and 
@Anonymitaet is dealing with this issue this week.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5513: Publish rate limit on broker to avoid OOM

2019-11-25 Thread GitBox
sijie commented on issue #5513: Publish rate limit on broker to avoid OOM
URL: https://github.com/apache/pulsar/issues/5513#issuecomment-558395743
 
 
   @rdhabalia putting OOM question aside, what are the concerns of adding a 
broker-level rate limiter as a feature? Just looking into features that Pulsar 
has, it usually has broker-level settings and namespace-level settings. As a 
feature, doesn't it make sense to also have a broker-level rate limiter in 
addition to namespace-level rate limiter?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie edited a comment on issue #5513: Publish rate limit on broker to avoid OOM

2019-11-25 Thread GitBox
sijie edited a comment on issue #5513: Publish rate limit on broker to avoid OOM
URL: https://github.com/apache/pulsar/issues/5513#issuecomment-558394361
 
 
   > my only point is to figure out root cause of OOM and address it. 
   >  do we think auto-read is not working as expected 
   
   Yes. we think auto-read is not working as expected, because 
`maxPendingRequestPerConnection` is not a useful mechanism. 1) it is not a 
broker level mechanism. it only limits per connection. when a broker has 
increase number of connections, the limit is changed; 2) it is not a `bytes` 
based mechanism. it limits on number of requests, the request size can change 
when the batching behavior changes in the client side. the number of bytes 
pending on the channel is non-deterministic. 3) it is almost impossible to 
determine a value based on `maxPendingRequestPerConnection` in a real 
production traffic. (think about the peak traffic in China's shopping festival 
day).
   
   The requirement from us is deadly simple - I have a broker, no matter how 
many clients send the request and how clients batch the request, broker should 
work as normal and give backpressure to the client when exceed the capacity 
that a broker offers. The ideal perfect solution is to disable auto-read when 
the resource usage (aka memory usage, cpu usage, or network usage) exceed a 
threshold and the process should be done automatically. However to achieve a 
perfect solution like that takes time and is usually complicated.  The closest 
solution that we can provide is to have a broker-level rate limiter : 1) we can 
limit the traffic based on an aggregate throughput (bytes/second); 2) the 
mechanism is already available by #3985, we just piggyback. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5513: Publish rate limit on broker to avoid OOM

2019-11-25 Thread GitBox
sijie commented on issue #5513: Publish rate limit on broker to avoid OOM
URL: https://github.com/apache/pulsar/issues/5513#issuecomment-558394361
 
 
   > my only point is to figure out root cause of OOM and address it. 
   >  do we think auto-read is not working as expected 
   
   Yes. we think auto-read is not working as expected, because 
`maxPendingRequestPerConnection` is not a useful mechanism. 1) it is not a 
broker level mechanism. it only limits per connection. when a broker has 
increase number of connections, the limit is changed; 2) it is not a `bytes` 
mechanism. it limits on number of requests, the request size can change when 
the batching behavior changes in the client side. the number of bytes pending 
on the channel is non-deterministic. 3) it is almost impossible to determine a 
value based on `maxPendingRequestPerConnection` in a real production traffic. 
(think about the peak traffic in China's shopping festival day).
   
   The requirement from us is deadly simple - I have a broker, no matter how 
many clients send the request and how clients batch the request, broker should 
work as normal and give backpressure to the client when exceed the capacity 
that a broker offers. The ideal perfect solution is to disable auto-read when 
the resource usage (aka memory usage, cpu usage, or network usage) exceed a 
threshold and the process should be done automatically. However to achieve a 
perfect solution like that takes time and is usually complicated.  The closest 
solution that we can provide is to have a broker-level rate limiter : 1) we can 
limit the traffic based on an aggregate throughput (bytes/second); 2) the 
mechanism is already available by #3985, we just piggyback. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] rdhabalia commented on a change in pull request #5710: Add publish rate limit for each broker to avoid OOM

2019-11-25 Thread GitBox
rdhabalia commented on a change in pull request #5710: Add publish rate limit 
for each broker to avoid OOM
URL: https://github.com/apache/pulsar/pull/5710#discussion_r350478500
 
 

 ##
 File path: conf/broker.conf
 ##
 @@ -175,9 +175,21 @@ maxUnackedMessagesPerBroker=0
 # limit/2 messages
 maxUnackedMessagesPerSubscriptionOnBrokerBlocked=0.16
 
-# Tick time to schedule task that checks publish rate limiting across all 
topics  
-# (Disable publish throttling with value 0)
-publisherThrottlingTickTimeMillis=10
+# Tick time to schedule task that checks topic publish rate limiting across 
all topics
+# Reducing to lower value can give more accuracy while throttling publish but
+# it uses more CPU to perform frequent check. (Disable publish throttling with 
value 0)
+topicPublisherThrottlingTickTimeMillis=10
+
+# Tick time to schedule task that checks broker publish rate limiting across 
all topics
+# Reducing to lower value can give more accuracy while throttling publish but
+# it uses more CPU to perform frequent check. (Disable publish throttling with 
value 0)
+brokerPublisherThrPottlingTickTimeMillis=50
+
+# Max Rate(in 1 seconds) of Message allowed to publish for a broker if broker 
publish rate limiting enabled
+brokerPublisherThrottlingMaxMessageRate=-1
 
 Review comment:
   can we make 0 to disable and also add into comment for disable instruction.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] rdhabalia commented on issue #5513: Publish rate limit on broker to avoid OOM

2019-11-25 Thread GitBox
rdhabalia commented on issue #5513: Publish rate limit on broker to avoid OOM
URL: https://github.com/apache/pulsar/issues/5513#issuecomment-558388748
 
 
   > I am not sure how do you setup. Are you running the flink connector?
   
   no, I have pref broker setup and trying to publish messages with multiple 
processes of perf-producers. 
   
   my only point is to figure out root cause of OOM and address it. if broker 
is going OOM with 20 topics and 20-400 producers then do we think auto-read is 
not working as expected and broker is still accepting messages after auto-read 
disable and keeping them in memory is causing OOM?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5710: Add publish rate limit for each broker to avoid OOM

2019-11-25 Thread GitBox
sijie commented on issue #5710: Add publish rate limit for each broker to avoid 
OOM
URL: https://github.com/apache/pulsar/pull/5710#issuecomment-558384990
 
 
   @rdhabalia I just replied to your comment in #5513. so this change here is 
using the mechanism you added for namespace rate limiter. what it basically 
does is having a rate calculator at broker level and piggyback the rate 
limiting by checking if publish exceeds a certain rate threshold (both 
namespace setting and broker setting). It is a pretty simple change that 
piggyback to your mechanism. why is this a concern to you?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5513: Publish rate limit on broker to avoid OOM

2019-11-25 Thread GitBox
sijie commented on issue #5513: Publish rate limit on broker to avoid OOM
URL: https://github.com/apache/pulsar/issues/5513#issuecomment-558383987
 
 
   @rdhabalia 
   
   > I gave a try with similar setup and somehow I couldn't reproduce it. 
   
   I am not sure how do you setup. Are you running the flink connector? or you 
simulate it? Did you run enough parallelism to stress test the cluster?
   
   OOM is a common scene during our test.
   
   > Broker restricts max pending publish request per connection.
   
   But the broker is still facing OOM when the number of connections increase, 
no?
   
   > also, introducing counter across all topics for throttling can cause 
bottleneck while publishing for all topics so, this feature might not be 
recommended for most of the users.
   
   The feature we are adding is controlled by a flag. People need to 
pre-configure what is the rate that a broker can accept. That rate is typically 
aligned with your NIC configuration. E.g. 80% of your NIC bandwidth. We might 
make it smart by automatically adjust the rate based on NIC bandwidth and 
memory usage. but we will always make it easy to turn on/off with a flag. 
   
   What is the side effect of adding this rate limiter at broker level?
   
   > depend on maxPendingRequestPerConnection rather adding more complexity 
   
   We can't really depend on `maxPendingRequestPerConnection`. Because when you 
have a lot of concurrent clients (connections), that setting doesn't worker. 
Also using number of requests doesn't give an accurate estimation. because the 
size of per request varies between applications. A broker level mechanism that 
based on bytes not requests is much robust than the other approaches.
   
   You mentioned that "I know disabling auto-read was not working all the time 
with ByteToMessageDecoder because of this reason and I think it's taken care in 
#3985." But the implementation that Jia proposed is using your implementation 
at #3985. If the problem is taken care by #3985, then there shouldn't be a 
problem in #5710; if the problem is not taken care by #3985, then it is a 
problem for both namespace level rate limiter and a broker level rate limiter, 
which I am not sure it is a problem for adding a broker level rate limiter not 
a problem for adding the namespace level rate limiter.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] rdhabalia commented on issue #5710: Add publish rate limit for each broker to avoid OOM

2019-11-25 Thread GitBox
rdhabalia commented on issue #5710: Add publish rate limit for each broker to 
avoid OOM
URL: https://github.com/apache/pulsar/pull/5710#issuecomment-558374929
 
 
   @sijie @jiazhai I have gone through the change and I have also put some 
comments and concern at #5513 . can you check if that makes sense?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] rdhabalia commented on issue #5513: Publish rate limit on broker to avoid OOM

2019-11-25 Thread GitBox
rdhabalia commented on issue #5513: Publish rate limit on broker to avoid OOM
URL: https://github.com/apache/pulsar/issues/5513#issuecomment-558372993
 
 
   >> @merlimat 
   There's already a limit per-connection of max outstanding entries between 
broker and bookies. Do you have a precise scenario for this to happen?
   
   >> @sijie 
   create a topic with 20 partitions. with parallelism == 20. The producer 
setting in the pulsar sink is the default producer setting.
   
   
   I gave a try with similar setup and  somehow I couldn't reproduce it. and 
reason broker doesn't go OOM because I think what @merlimat mentioned. Broker 
restricts max pending publish request per connection.
   
https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L130
   
   also, introducing counter across all topics for throttling can cause 
bottleneck while publishing for all topics so, this feature might not be 
recommended for most of the users.
   
   so, I would recommend to depend on maxPendingRequestPerConnection rather 
adding more complexity and if that's not working then it's worth to investigate 
why it disabling channel still cause OOM. I have also created #5742 which can 
allow users to configure max-pending requests per connection if needed.
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


  1   2   3   >