date:20191128

codelipenghui commented on issue #5763: Broker graceful shutdown when znode of 
loadbalance disappeared
URL: https://github.com/apache/pulsar/issues/5763#issuecomment-559692929
 
 
   Yes, i think so, will fixed soon


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] aahmed-se commented on issue #5642: Add Github workflow for gated checkin

aahmed-se commented on issue #5642: Add Github workflow for gated checkin
URL: https://github.com/apache/pulsar/pull/5642#issuecomment-559691989
 
 
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #4955: [PIP-39] Introduce system topic and topic policies service

codelipenghui commented on issue #4955: [PIP-39] Introduce system topic and 
topic policies service
URL: https://github.com/apache/pulsar/pull/4955#issuecomment-559691601
 
 
   run java8 tests
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client.

codelipenghui commented on issue #5680: [transaction-coordinator] 
Implementation of transaction coordinator client.
URL: https://github.com/apache/pulsar/pull/5680#issuecomment-559691215
 
 
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy commented on issue #5734: [Reopen][Issue 5597]retry when getPartitionedTopicMetadata failed

wolfstudy commented on issue #5734: [Reopen][Issue 5597]retry when 
getPartitionedTopicMetadata failed
URL: https://github.com/apache/pulsar/pull/5734#issuecomment-559691274
 
 
   run java8 tests
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on issue #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

tuteng commented on issue #5741: [website]Add content of pulsar-manager in 
website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#issuecomment-559685638
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] congbobo184 commented on issue #5757: [doc]Modify schema compatibility check doc

congbobo184 commented on issue #5757: [doc]Modify schema compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#issuecomment-559676111
 
 
   @sijie  where does the flag add? pulsar-client-tools or broker reject this 
request? if it is in pular-client-tools, how to add it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] alphashaw opened a new issue #5770: Pulsar Broker Sometimes does not return CommandSendReceipt/CommandSendError to prducer send CommandSend

alphashaw opened a new issue #5770: Pulsar Broker Sometimes does not return
CommandSendReceipt/CommandSendError to prducer send CommandSend
URL: https://github.com/apache/pulsar/issues/5770

I'm writing a Pulsar client library for Erlang. I first started with the
producer implementation.
I'm doing non/partitioned topics publishing and everything at protocol
level works fine.
However, when I'm doing a batch partitioned topic produce( max. 1000 msgs)
with a max. **batch delay** of 1ms, I noticed that some **CommandSend**
requests doesn't get an equivalent **CommandSendReceipt** response. The broker
never returns that. This is causing one of the producer of the partition topic
to stuck. All the producers share the same connection, and I'm using the the
prodcuer_id and the sequence_id of each **CommandSend** to assocate with the
corresponding **CommandSendReceipt's**. Is the broker shedding off my loads to
avoid overloading? I suspect this because when I increase the batch delay
everything works fine. However, I'm not sure. Why is this behaviour? If this is
expected, is the sequence_id of the responses that make it be in the same order
as the sequence_id of the **CommandSend** requests? In other words, does the
broker serially handles requests from the all producers (partitioned/not) on
the same connection?

**Expected behavior**
If load shedding is not happening, I expects to see **CommandSendReceipt's**
or a **CommandSendError** for any **CommandSend** request.

**Screenshots**
Below is a photo of the command send and the associated receipt command. It
shows where the break happens.

![kaja](https://user-images.githubusercontent.com/14175735/69847443-0f903400-126f-11ea-8fe3-7519484a7450.png)

**Desktop.**
- OS: [e.g. Ubuntu]

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

With regards,
Apache Git Services

svn commit: r36987 [1/2] - in /dev/pulsar/pulsar-2.4.2-candidate-3: ./ DEB/ RPMS/ RPMS/repodata/ connectors/

Author: rxl
Date: Fri Nov 29 06:11:27 2019
New Revision: 36987

Log:
Staging artifacts and signature for Pulsar release 2.4.2

Added:
dev/pulsar/pulsar-2.4.2-candidate-3/
dev/pulsar/pulsar-2.4.2-candidate-3/DEB/
dev/pulsar/pulsar-2.4.2-candidate-3/DEB/Packages.gz   (with props)
dev/pulsar/pulsar-2.4.2-candidate-3/DEB/Packages.gz.asc
dev/pulsar/pulsar-2.4.2-candidate-3/DEB/Packages.gz.sha512
dev/pulsar/pulsar-2.4.2-candidate-3/DEB/apache-pulsar-client-dev.deb   
(with props)
dev/pulsar/pulsar-2.4.2-candidate-3/DEB/apache-pulsar-client-dev.deb.asc
dev/pulsar/pulsar-2.4.2-candidate-3/DEB/apache-pulsar-client-dev.deb.sha512
dev/pulsar/pulsar-2.4.2-candidate-3/DEB/apache-pulsar-client.deb   (with 
props)
dev/pulsar/pulsar-2.4.2-candidate-3/DEB/apache-pulsar-client.deb.asc
dev/pulsar/pulsar-2.4.2-candidate-3/DEB/apache-pulsar-client.deb.sha512
dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/apache-pulsar-client-2.4.2-1.x86_64.rpm
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/apache-pulsar-client-2.4.2-1.x86_64.rpm.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/apache-pulsar-client-2.4.2-1.x86_64.rpm.sha512

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/apache-pulsar-client-debuginfo-2.4.2-1.x86_64.rpm
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/apache-pulsar-client-debuginfo-2.4.2-1.x86_64.rpm.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/apache-pulsar-client-debuginfo-2.4.2-1.x86_64.rpm.sha512

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/apache-pulsar-client-devel-2.4.2-1.x86_64.rpm
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/apache-pulsar-client-devel-2.4.2-1.x86_64.rpm.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/apache-pulsar-client-devel-2.4.2-1.x86_64.rpm.sha512
dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/0170debf61ab7b76985d4e3a7a318d9c85cc90088a32f192d4153d136ceaff75-filelists.sqlite.bz2
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/0170debf61ab7b76985d4e3a7a318d9c85cc90088a32f192d4153d136ceaff75-filelists.sqlite.bz2.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/0170debf61ab7b76985d4e3a7a318d9c85cc90088a32f192d4153d136ceaff75-filelists.sqlite.bz2.sha512

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/30028f68d9bab34dfe6282d4cbc55220e7bde8eb42db52a235a44c61d285d66f-other.xml.gz
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/30028f68d9bab34dfe6282d4cbc55220e7bde8eb42db52a235a44c61d285d66f-other.xml.gz.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/30028f68d9bab34dfe6282d4cbc55220e7bde8eb42db52a235a44c61d285d66f-other.xml.gz.sha512

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/36ed4993a13472569d4fd66fb5506ebd9ae41040159058615fd957ab8fc1b172-filelists.xml.gz
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/36ed4993a13472569d4fd66fb5506ebd9ae41040159058615fd957ab8fc1b172-filelists.xml.gz.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/36ed4993a13472569d4fd66fb5506ebd9ae41040159058615fd957ab8fc1b172-filelists.xml.gz.sha512

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/679e02b307edb9950c821a599d029901247fd299b6047317ee47103d9e21d057-other.sqlite.bz2
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/679e02b307edb9950c821a599d029901247fd299b6047317ee47103d9e21d057-other.sqlite.bz2.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/679e02b307edb9950c821a599d029901247fd299b6047317ee47103d9e21d057-other.sqlite.bz2.sha512

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/9e22e049fd653ae313511844937f692840f4cbf534eed72e1ac9055ce7f6-primary.sqlite.bz2
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/9e22e049fd653ae313511844937f692840f4cbf534eed72e1ac9055ce7f6-primary.sqlite.bz2.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/9e22e049fd653ae313511844937f692840f4cbf534eed72e1ac9055ce7f6-primary.sqlite.bz2.sha512

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/a0780d959200b519612f70899cf93fa2732c33be46c8be4c68c64b57c4d455c7-primary.xml.gz
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/a0780d959200b519612f70899cf93fa2732c33be46c8be4c68c64b57c4d455c7-primary.xml.gz.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/a0780d959200b519612f70899cf93fa2732c33be46c8be4c68c64b57c4d455c7-primary.xml.gz.sha512
dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/repomd.xml
dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/repomd.xml.asc
dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/repomd.xml.sha512
dev/pulsar/pulsar-2.4.2-candidate-3/apache-pulsar-2.4.2-bin.tar.gz   (with 
props)
dev/pulsar/pulsar-2.4.2-candidate-3/apache-pulsar-2.4.2-bin.tar.gz.asc
dev/pulsar/pulsar-2.4.2-candidate-3/apache-pulsar-2.4.2-bin.tar.gz.sha512
dev/pulsar/pulsar-2.4.2

svn commit: r36987 [2/2] - in /dev/pulsar/pulsar-2.4.2-candidate-3: ./ DEB/ RPMS/ RPMS/repodata/ connectors/

Added: 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-flume-2.4.2.nar.sha512
==
--- 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-flume-2.4.2.nar.sha512 
(added)
+++ 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-flume-2.4.2.nar.sha512 
Fri Nov 29 06:11:27 2019
@@ -0,0 +1 @@
+0bd9112528ad4157d1708baab3664611cfe96d0afc58f8138257d82f8d4efe8f426b04ba761963c8f12dae09494ecb1b41186887768fc4b39c715d77d2565f6c
  ./connectors/pulsar-io-flume-2.4.2.nar

Added: dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hbase-2.4.2.nar
==
Binary file - no diff available.

Propchange: 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hbase-2.4.2.nar
--
svn:mime-type = application/octet-stream

Added: 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hbase-2.4.2.nar.asc
==
--- 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hbase-2.4.2.nar.asc 
(added)
+++ 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hbase-2.4.2.nar.asc 
Fri Nov 29 06:11:27 2019
@@ -0,0 +1,16 @@
+-BEGIN PGP SIGNATURE-
+
+iQIzBAABCAAdFiEEHqpd6S06DEdJ6YRttJ34KK/JpEIFAl3grcsACgkQtJ34KK/J
+pELZBw/7BgIW5ylwAtV+01yBWL3EvyCHWpnWXo2yDkjp2OC2QDYvUcpVUHVxoQHh
+P5mbeIbWATI+3k/LDvrgfQYJ4aQ9hG0umcRgbIQv8DjAPDhVcNeDXAW9V6OG8Ako
+GUYc4ByhO6vAn7NefNZd45BkhwjbebyeZ7buIeRQLz/Sv3yGKcLWPkva36VVqO28
+gvwJP6MfJkKG5hMMwt1TNQL8kdEhWTRRVjdXadt6dVq6Idez4EHUBR44eIF7Q/Py
+bPVpzODj5KIS12CudcLXvw+2TfN5pD3wLz86sw9sLfu5UjD8DKsJYvC6mSUJzTgV
+LmrDRRVal+qq5JY5FUEZKAKRcGaUhq2A49iM8pBbACyIOObdytvNwliAjWjYvhWo
+HOA+RJRKnkVp2xHVA71+UT3B4gL8D5hYnxwuN+8F7sVKOTfH7sRSZRmg/pn7swY9
+/cPCUhWWKaQZ763mSFlThKsX2pJVCkZTV79THHAWhnOHICwVicycKxqj9jnMdGyc
+y9jTXhy0zXGUXYb9yEW771FINwHq1tfLb7UXDRHxw1nMXwDCMLOiLfl6+J26TtQk
+h7yP7brwGkV7HsBv14bpSQSycbUVw6w4DivGvOqCh4GfmXrZm6BdtkayqV+NnABe
+Ln/RdNdD19J7Rc94XjCwmX/Itau0uE0NuroQxo2BzocE4jZuJis=
+=BzqX
+-END PGP SIGNATURE-

Added: 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hbase-2.4.2.nar.sha512
==
--- 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hbase-2.4.2.nar.sha512 
(added)
+++ 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hbase-2.4.2.nar.sha512 
Fri Nov 29 06:11:27 2019
@@ -0,0 +1 @@
+f344a21922f415af775b8ae85d8920e23201469faed58ca4d745e5d8b01edfbc584788025601daa5b3b11f03e7fd0fca43afa0908e31dcc7409dc3b500ed248e
  ./connectors/pulsar-io-hbase-2.4.2.nar

Added: dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hdfs2-2.4.2.nar
==
Binary file - no diff available.

Propchange: 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hdfs2-2.4.2.nar
--
svn:mime-type = application/octet-stream

Added: 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hdfs2-2.4.2.nar.asc
==
--- 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hdfs2-2.4.2.nar.asc 
(added)
+++ 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hdfs2-2.4.2.nar.asc 
Fri Nov 29 06:11:27 2019
@@ -0,0 +1,16 @@
+-BEGIN PGP SIGNATURE-
+
+iQIzBAABCAAdFiEEHqpd6S06DEdJ6YRttJ34KK/JpEIFAl3grc8ACgkQtJ34KK/J
+pEJyjRAAnIaceqCqzQMFKHOVhk62c5fed+wFcnUb++WtPDBR6Xjh7Acbj+ylOXX3
+W0XBzrAGuofw59gsRF6+/h7Sr1Ow1NKXeJbg/xR/N0OrmBR/ogtEAIMTH2MYAej1
+/QCt91CFZt4ODQbE2zGi57cWMb+NgBHufXlFYsQHv/sSDXv5XrhTum1QcyMDrO5F
+/WPd3mEAplH1wc1bYnw9r0AkRZSmZdG+OfckcOULEgoCPuNQLlNlEHEkRBc2kcD1
+5JYQHf4CVSF7EhzXU20kIrHRKe7wApSRrxVB2K2RRcYAvO9m3Lacs61QsYo21eOX
+iA41wF+9I4KLeaSoKU8NW/HLw6AgWrQe1Ktm2tc97gsX7eK3hwMWBvrDU087WpJ6
+Etj62/va6O09kCsTq16HkUll4gD8FgZ13urOYTAx8G6w5bNl/q7DSshVuiR0uihP
++UIfcs8HqCmNYJWBdiafoG4UqOz5ySwxffbKT0ZAoQsjgO++5UAhKdUC3sXQaDwu
+RVGZIh34oWbs3ArxeXcGEoJLZQDO+CjQk9vgtyjjxu59dfAWyajYsehxspFMmxVu
+W/SdDQH6iOh99Ffb/jWdSqPiK0hhSXq0SdkkP/EvJiyb8srJSo9WB9u9c3uD+Gjf
+goW76FcxWna+FeCPCSVHnmbsMMo0o7bgRBRsLJ8wbf8Wa4uSRCU=
+=coRY
+-END PGP SIGNATURE-

Added: 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hdfs2-2.4.2.nar.sha512
==
--- 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hdfs2-2.4.2.nar.sha512 
(added)
+++ 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-hdfs2-2.4.2.nar.sha512 
Fri Nov 29 06:11:27 2019
@@ -0,0 +1 @@
+f1b3fc37df550d9e52a728a61e6d015f2243fa69d4628249d4de4af3d424422e410493d4fa9d361235189d2efe49b491d43702c99a90f005e495d059849a5a4c
  ./connectors/pulsar-io-hdfs2-2.4.2.nar

Added: dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pul

[GitHub] [pulsar] tuteng commented on issue #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

tuteng commented on issue #5741: [website]Add content of pulsar-manager in 
website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#issuecomment-559668960
 
 
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] aahmed-se commented on issue #5642: Add Github workflow for gated checkin

aahmed-se commented on issue #5642: Add Github workflow for gated checkin
URL: https://github.com/apache/pulsar/pull/5642#issuecomment-559664647
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch master updated (ae59d55 -> d9c2b8b)

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from ae59d55  [tests] ManagedLedgerFactoryChangeLedgerPathTest is flaky 
(#5766)
 add d9c2b8b  Add document for sticky consumer  (#5745)

No new revisions were added by this update.

Summary of changes:
 site2/docs/client-libraries-java.md   | 15 ++-
 site2/docs/concepts-messaging.md  |  2 +-
 site2/website/blog/2019-07-05-Apache-Pulsar-2-4-0.md  |  2 +-
 .../versioned_docs/version-2.4.0/client-libraries-java.md |  2 +-
 .../versioned_docs/version-2.4.1/client-libraries-java.md |  2 +-
 .../versioned_docs/version-2.4.1/concepts-messaging.md|  2 +-
 6 files changed, 19 insertions(+), 6 deletions(-)

[GitHub] [pulsar] sijie closed issue #5682: Documentation for sticky consumer

sijie closed issue #5682: Documentation for sticky consumer
URL: https://github.com/apache/pulsar/issues/5682
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #5745: Add document for sticky consumer

sijie merged pull request #5745: Add document for sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5279: Support for python native logging from python wrapper

sijie commented on issue #5279: Support for python native logging from python 
wrapper
URL: https://github.com/apache/pulsar/pull/5279#issuecomment-559661603
 
 
   @BlackJohnny do you mind rebasing this pull request to latest master to 
include some of the test fixes? I can't do it since you are creating a pull 
request based on the master of your fork.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

svn commit: r36985 - /dev/pulsar/pulsar-2.4.2-candidate-3/

Author: rxl
Date: Fri Nov 29 05:09:07 2019
New Revision: 36985

Log:
Delete pulsar-candidate-3

Removed:
dev/pulsar/pulsar-2.4.2-candidate-3/

[GitHub] [pulsar] sijie commented on issue #5147: Deprecate getstatus subcommand for source command

sijie commented on issue #5147: Deprecate getstatus subcommand for source 
command
URL: https://github.com/apache/pulsar/pull/5147#issuecomment-559661403
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch master updated (ecf7792 -> ae59d55)

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from ecf7792  Fix NPE when send a large message and don't release 
batchedMessageMetadataAndPayload when discard in batch message container. 
(#5748)
 add ae59d55  [tests] ManagedLedgerFactoryChangeLedgerPathTest is flaky 
(#5766)

No new revisions were added by this update.

Summary of changes:
 .../mledger/impl/ManagedLedgerFactoryChangeLedgerPathTest.java   | 1 -
 1 file changed, 1 deletion(-)

[GitHub] [pulsar] sijie merged pull request #5766: [tests] ManagedLedgerFactoryChangeLedgerPathTest is flaky

sijie merged pull request #5766: [tests] 
ManagedLedgerFactoryChangeLedgerPathTest is flaky
URL: https://github.com/apache/pulsar/pull/5766
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

svn commit: r36984 - /dev/pulsar/KEYS

2019-11-28 Thread guangning

Author: guangning
Date: Fri Nov 29 04:52:10 2019
New Revision: 36984

Log:
Add KEYS file to svn.

Added:
dev/pulsar/KEYS

Added: dev/pulsar/KEYS
==
--- dev/pulsar/KEYS (added)
+++ dev/pulsar/KEYS Fri Nov 29 04:52:10 2019
@@ -0,0 +1,838 @@
+This file contains the PGP keys of various developers.
+
+Users: pgp < KEYS
+or
+   gpg --import KEYS
+
+
+Developers:
+pgp -kxa  and append it to this file.
+or
+(pgpk -ll  && pgpk -xa ) >> this file.
+or
+(gpg --list-sigs 
+&& gpg --armor --export ) >> this file.
+
+
+pub   rsa2048 2017-07-23 [SC] [expires: 2019-07-23]
+  8C75C738C33372AE198FD10CC238A8CAAC055FD2
+uid   [ultimate] Matteo Merli 
+sig 3C238A8CAAC055FD2 2017-07-23  Matteo Merli 
+sub   rsa2048 2017-07-23 [E] [expires: 2019-07-23]
+sig  C238A8CAAC055FD2 2017-07-23  Matteo Merli 
+
+-BEGIN PGP PUBLIC KEY BLOCK-
+
+mQENBFl1KkIBCADOFSzS7pOnk1ZeBCh41SHTVmZ97NjMv19ysRTkobZ29nWYDcWX
+W9aRDE7EKEjMMMwvwN5nogAddr42UAK3DbKOF3zieD2waDld6Hzp34LxH4P/KPsz
+cb8JfjNKQiKxAWD5c90W9JEjcmDhjf1cpwgtn0xgsvJsSadT8ZQtq5D0Y6TQyaiH
+ArLYgahK73D7XXwghomvC9Fl+ONUhcLDs7loO6U0Rj/+QXTL6i0pKeWlnErb0Vx6
+z862JunFdZRS8UZ1HjeWmYVApvuJJTkhujdPcWP/Y02FFpy8G68ABLfdOLaLdhmS
+AczyNRkx1sCyQYCQHAMuIdN/V4mwcdFj105XABEBAAG0IE1hdHRlbyBNZXJsaSA8
+bW1lcmxpQGFwYWNoZS5vcmc+iQFUBBMBCgA+FiEEjHXHOMMzcq4Zj9EMwjioyqwF
+X9IFAll1KkICGwMFCQPCZwAFCwkIBwMFFQoJCAsFFgIDAQACHgECF4AACgkQwjio
+yqwFX9L2hwgAgF6zLf8c0CdVguWOnDnh0hl9B7b+iXKZB6qHtAqd7g0jZt9R40rB
+ae9VRph9exBiA/bl1r/M78OZ1RKKi7tQNp/Hp6gDyeH4cb6pNSwxT//Pu0nE5j3f
+NfVjqUNQFlbQN7nmBaKwqrxyH4BDLzYd+uyGEz9JksY9vTbiJkRcy+rcOEioNiNV
+InPYXpFI6Efo9pbmzS6rOuB9H1p+Z1vylTYl2KvG4sGef2/jet1ebnwXgC7tRsbp
+luyS89DsbQDZ3k7Q/hwaUM8W8vwAbk+2tAm/jTdPBY/Qj5KLTpRABPGPPPCI2ccc
+yHztD+r0BZTFfWfCdcec1WiVxaBxESI0D7kBDQRZdSpCAQgAxgJBZz7Fk5C8fqgf
+H6hY12Y0pxWfl7zTioDToga4vqDooKuLgzl1DnOwhPrxMen/9B/yWnxKdpASXw3o
+o85MRm6fdcCyYMIti5JbwJ2ZTWDyOXNmHWiDAn/u34/4rBeuy5ivjQU9TxbLH/vV
+XoiaJpmonw6OiKWaiYc52gPZ2SR8kd2K9kc8gsY5uj0HM2x/lEUFJS8aTxZEqpOS
+QXpyIXUZV1v0lMFxyzLfpb6tN5m+MFHadXlWU4RYVcf5KbMZCnrEQpAc6ly083Rj
+x3UhC7d+c6Li1ZCWUtd0IbDuRkx5o6A37qg7tfj4foeu18/zWlC3YRs+UYuS2DGo
+//GQZwARAQABiQE8BBgBCgAmFiEEjHXHOMMzcq4Zj9EMwjioyqwFX9IFAll1KkIC
+GwwFCQPCZwAACgkQwjioyqwFX9J1Jgf/aaerd2syFpZh/ws0IFfJUa+HDfIlNWq2
+6FkC2OMC8vd1jowG+WkkxJGel1XnfYswxJJ/4mCSqgN6nXlUOx2RBgNBufrY/mIO
+6CbZrJ/iFK2P6mIb1BN2F0B9ZpeaMBWl3uBxpEsRwLBMU64uOzHnH/eNMi/UDmPO
+COGVJWUffm3OZHzC6IgwavgsXbjp/JZIZH3AUdyZptsVyYMASHq1QJ/HIqZORiBg
+/wkH8P4Y1NKnkDI2BB8vYgdR3C7ifnwn1ddVos+05aS1PKHNjPhnpVYmRFZWuudt
+/hPels3A0sS//jGruY3A4XfmrRFOi6+qh6em50kNRameseElLM3BOQ==
+=HWMB
+-END PGP PUBLIC KEY BLOCK-
+pub   rsa2048 2017-08-03 [SC] [expires: 2019-08-03]
+  CC251AE1C7C5BF592E9D6DE13956248899767A23
+uid   [ultimate] rdhabalia 
+sig 33956248899767A23 2017-08-03  rdhabalia 
+sub   rsa2048 2017-08-03 [E] [expires: 2019-08-03]
+sig  3956248899767A23 2017-08-03  rdhabalia 
+
+-BEGIN PGP PUBLIC KEY BLOCK-
+
+mQENBFmDpigBCAC8qs1e7eQj3a52vW4fS/xsfY0PlWfnwOiIhJ2OfD7gVhm8nyL1
+A/ySeUvqzsHjdYWSh/yICoKm5I++wgquS+h5CfR3WYfku5mtBzaph461rdpbSfpN
+ESQGV7VFQHDHihMcXlUBsFPzuxWErjxHWaQNZjGTQR9+9flzpdP++CkSp9mlAqUb
+fSsepcQEwm7PhioKNzDtiSmY1XbQwETMX7peKqSP3hE1igZlEXoHvVqRk5DY61V6
+W6iK78ZpY7bDay4omfYLc9IBWjvurxkH2lDpfDqD0Vz4WhViJLuRziPCFTpb/iXq
+z4ENBzQs7pX0ATPjYYVfK84xNJ2J0a6vaVXTABEBAAG0IHJkaGFiYWxpYSA8cmRo
+YWJhbGlhQGFwYWNoZS5vcmc+iQFUBBMBCAA+FiEEzCUa4cfFv1kunW3hOVYkiJl2
+eiMFAlmDpigCGwMFCQPCZwAFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQOVYk
+iJl2eiPmqwgAqraC9XYBnjJc8USNW3KUs9WNBt0g9oFAWiKr1x/CmDwC/BBla1Z8
+wzalm/NapC/Fhx2s9/Vmi6lDZ0l5JxI4Q6bDwPQEiGyMUapHXMbk+53X9jKpRn7W
+HbORg392Z6On/zjbxvZD+xKqWoYTfdpU+C0nsPiCH6RdsxbHxeO00wcHainrRitC
+rNWyDHNbWFWV1EkXjJTZFy8OO185Ads/qlYP1siFy6SdciG/y/vfUNM9auphVa5U
+kOGTmEfUCB6YT4w0lUzHxWixZG2PDfKA9Vg2EI2Smqt3uwb0Z9UOUq6ZKmL4LqK6
+N7Ta2KhE+bY9mG45SgIwvmto0PyoRGF+/rkBDQRZg6YoAQgAqUaOPCESsnJ8Vh1h
+/ao/VMRusX6eJOjGK2DhlLTc0rrear9a/or+lfYWV7emLCDmhsVYvhflHBtZsb36
+v5nDFwr2G+iHcQkewtU+TptMZT5gfY8dM2DwUooAFl1bHU0IIOeDXyJ44utDik86
+k6Rr4AoSVERU0Leo2w4NeZb8V2yPGsDf0ql5u95ZDkqTxPRLKp/CqRbSSXmZwHy6
+GC/o4jMPSwjbkh985tUYhCaKNW3pVTm7ETHiyxLFT3LFKCx3j3TjoNTJoHEFt+Ft
+bSbsa0kUJYU9n20bakbTnFm/RilJs23D3YrutCO43l/nLt+2ronyBoU7N9IhRee6
+iUHrvwARAQABiQE8BBgBCAAmFiEEzCUa4cfFv1kunW3hOVYkiJl2eiMFAlmDpigC
+GwwFCQPCZwAACgkQOVYkiJl2eiMGEwf9GZVx5pKcnGfUDnkopYtlVrO3I0X7WLKG
+YMm/K4lhklKY3Yfb7lWyBvdYX4q1HUhTNzk/Fq1aPnv4Gio4cPobgfuF9rR6LCxY
+0oRDtkiW3V3tp0R3ThJdczInlsiVvlMCSF4KjDjcFELS00WVKsxb73xxxnx45nWh
+xcoGiU+YVrcPbWJXzoTwpTsSTCxirV3XTrI5fmS1FUBnJESnVBYj60HDapkdKxfp
+hryaT5d9KzFMp0B7+XpvyhNJrywafgGOMNSo2zrr7hwzP8WrrjbGsaG73/L4H+B7
+fKBF9EgNhXGM+JpHk//JdTlnCyqzeCsfHSTQnfwjrsN30IKrcI8W5A==
+=PNp3
+-END PGP PUBLIC KEY BLOCK-
+pub   4096R/E4EECE23 2017-09-18
+uid   [ultimate] Joe Francis (CODE SIGNING KEY) 
+sig 3E4EECE23 2017-09-18  Joe Francis (CODE SIGNING KEY) 

+sub   4096R/867CFB34 2017-09-18
+sig

[GitHub] [pulsar] aahmed-se closed pull request #5769: [WIP] Add github actions ci workflow

aahmed-se closed pull request #5769: [WIP] Add github actions ci workflow
URL: https://github.com/apache/pulsar/pull/5769
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on issue #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

tuteng commented on issue #5741: [website]Add content of pulsar-manager in 
website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#issuecomment-559653546
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351974176
 
 

 ##
 File path: site2/docs/schema-understand.md
 ##
 @@ -560,16 +563,10 @@ This diagram illustrates how does Schema work on the 
consumer side.
 
 2. The consumer connects to the broker with the `SchemaInfo` extracted from 
the passed-in schema instance.

-3. The broker looks up the schema in the schema storage to check if it is 
already a registered schema. 
-   
-4. If yes, the broker skips the schema validation since it is a known schema, 
and returns the schema version to the consumer.
-
-5. If no, the broker validates the schema based on the schema compatibility 
check strategy defined for the topic. 
-   
-6. If the schema is compatible, the broker stores it and returns the schema 
version to the consumer. 
+3. If the schema is compatible, the consumer will be connected. 
 
 Review comment:
   ```suggestion
   3. If the schema is compatible, the consumer is connected to the broker. 
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on issue #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on issue #5757: [doc]Modify schema compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#issuecomment-559652601
 
 
   @congbobo184 as we discussed before, we finalize contents first and then 
re-draw the workflow, so pls do not add images now. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351974206
 
 

 ##
 File path: site2/docs/schema-understand.md
 ##
 @@ -560,16 +563,10 @@ This diagram illustrates how does Schema work on the 
consumer side.
 
 2. The consumer connects to the broker with the `SchemaInfo` extracted from 
the passed-in schema instance.

-3. The broker looks up the schema in the schema storage to check if it is 
already a registered schema. 
-   
-4. If yes, the broker skips the schema validation since it is a known schema, 
and returns the schema version to the consumer.
-
-5. If no, the broker validates the schema based on the schema compatibility 
check strategy defined for the topic. 
-   
-6. If the schema is compatible, the broker stores it and returns the schema 
version to the consumer. 
+3. If the schema is compatible, the consumer will be connected. 

-7. If the schema is incompatible, the consumer will be disconnected.
+4. If the schema is incompatible, the consumer will be disconnected.
 
 Review comment:
   ```suggestion
   4. If the schema is incompatible, the consumer is disconnected to the broker.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] aahmed-se opened a new pull request #5769: [WIP] Add github actions ci workflow

aahmed-se opened a new pull request #5769: [WIP] Add github actions ci workflow
URL: https://github.com/apache/pulsar/pull/5769
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351966551
 
 

 ##
 File path: site2/docs/schema-manage.md
 ##
 @@ -50,17 +58,22 @@ For a consumer, the `AutoUpdate` happens in the following 
cases:
 
 * If a **consumer connects to a topic without a schema** (which means the 
consumer receiving raw bytes), the consumer can connect to the topic 
successfully without doing any compatibility check.
 
-* If a **consumer connects to a topic with a schema**:
-
-  * If the **topic is idle** (no producers, no entries, no other consumers and 
no registered schemas), the broker registers a schema for the topic 
automatically.
+* If a **consumer connects to a topic with a schema**.
 
-  * If the **topic is not idle**, the broker verifies if the schema provided 
by the consumer is compatible with the registered schema of the topic. 
+* If topic don't have schema, no data or no local consumers and no local 
producers.
 
-* If the **schema passes the compatibility check**, the consumer can 
connect to the topic and receive messages. 
+* If `isAllowAutoUpdateSchema` = true, register the schema and connect.
+
+* If `isAllowAutoUpdateSchema` = false, rejected.
+
+* If topic have schema, have data or have local consumers and have local 
producers., schema do compatibility check
 
-* If the **schema does not pass the compatibility check**, the consumer is 
rejected and disconnected.
-
-![AutoUpdate Producer](assets/schema-autoupdate-consumer.png)
+* If schema pass the compatibility check, the consumer is connected.
+
+* If schema does not pass the compatibility, the consumer is rejected.
 
 Review comment:
   ```suggestion
   * If the schema does not pass the compatibility check, then the 
consumer is rejected to connect to the broker.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351966427
 
 

 ##
 File path: site2/docs/schema-manage.md
 ##
 @@ -50,17 +58,22 @@ For a consumer, the `AutoUpdate` happens in the following 
cases:
 
 * If a **consumer connects to a topic without a schema** (which means the 
consumer receiving raw bytes), the consumer can connect to the topic 
successfully without doing any compatibility check.
 
-* If a **consumer connects to a topic with a schema**:
-
-  * If the **topic is idle** (no producers, no entries, no other consumers and 
no registered schemas), the broker registers a schema for the topic 
automatically.
+* If a **consumer connects to a topic with a schema**.
 
-  * If the **topic is not idle**, the broker verifies if the schema provided 
by the consumer is compatible with the registered schema of the topic. 
+* If topic don't have schema, no data or no local consumers and no local 
producers.
 
-* If the **schema passes the compatibility check**, the consumer can 
connect to the topic and receive messages. 
+* If `isAllowAutoUpdateSchema` = true, register the schema and connect.
+
+* If `isAllowAutoUpdateSchema` = false, rejected.
+
+* If topic have schema, have data or have local consumers and have local 
producers., schema do compatibility check
 
-* If the **schema does not pass the compatibility check**, the consumer is 
rejected and disconnected.
-
-![AutoUpdate Producer](assets/schema-autoupdate-consumer.png)
+* If schema pass the compatibility check, the consumer is connected.
 
 Review comment:
   ```suggestion
   * If the schema passes the compatibility check, then the consumer is 
connected to the broker.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351964929
 
 

 ##
 File path: site2/docs/schema-manage.md
 ##
 @@ -36,11 +36,19 @@ For a producer, the `AutoUpdate` happens in the following 
cases:
 
   * If a **producer carries a schema**:
   
-A broker performs the compatibility check based on the configured 
compatibility check strategy of the namespace to which the topic belongs. 
+A broker performs the compatibility check based on the configured 
compatibility check strategy of the namespace to which the topic belongs.
 
-* If it is a new schema and it passes the compatibility check, the broker 
registers a new schema automatically for the topic.
-
-* If the schema does not pass the compatibility check, the broker does not 
register a schema.
+* If the schema is registered, producer is connected. 
+
+* If the schema isn't registered
+
+* If`isAllowAutoUpdateSchema` = false, producer is rejected.
+
+* If `isAllowAutoUpdateSchema` = true
 
 Review comment:
   ```suggestion
   * If `isAllowAutoUpdateSchema` sets to **true**:
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351965890
 
 

 ##
 File path: site2/docs/schema-manage.md
 ##
 @@ -50,17 +58,22 @@ For a consumer, the `AutoUpdate` happens in the following 
cases:
 
 * If a **consumer connects to a topic without a schema** (which means the 
consumer receiving raw bytes), the consumer can connect to the topic 
successfully without doing any compatibility check.
 
-* If a **consumer connects to a topic with a schema**:
-
-  * If the **topic is idle** (no producers, no entries, no other consumers and 
no registered schemas), the broker registers a schema for the topic 
automatically.
+* If a **consumer connects to a topic with a schema**.
 
-  * If the **topic is not idle**, the broker verifies if the schema provided 
by the consumer is compatible with the registered schema of the topic. 
+* If topic don't have schema, no data or no local consumers and no local 
producers.
 
-* If the **schema passes the compatibility check**, the consumer can 
connect to the topic and receive messages. 
+* If `isAllowAutoUpdateSchema` = true, register the schema and connect.
 
 Review comment:
   ```suggestion
   * If `isAllowAutoUpdateSchema` sets to **true**, then the consumer 
registers a schema and it is connected to a broker.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351964897
 
 

 ##
 File path: site2/docs/schema-manage.md
 ##
 @@ -36,11 +36,19 @@ For a producer, the `AutoUpdate` happens in the following 
cases:
 
   * If a **producer carries a schema**:
   
-A broker performs the compatibility check based on the configured 
compatibility check strategy of the namespace to which the topic belongs. 
+A broker performs the compatibility check based on the configured 
compatibility check strategy of the namespace to which the topic belongs.
 
-* If it is a new schema and it passes the compatibility check, the broker 
registers a new schema automatically for the topic.
-
-* If the schema does not pass the compatibility check, the broker does not 
register a schema.
+* If the schema is registered, producer is connected. 
+
+* If the schema isn't registered
+
+* If`isAllowAutoUpdateSchema` = false, producer is rejected.
 
 Review comment:
   ```suggestion
   * If `isAllowAutoUpdateSchema` sets to **false**, the producer is 
rejected to connect to a broker.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351973675
 
 

 ##
 File path: site2/docs/schema-understand.md
 ##
 @@ -539,14 +539,17 @@ This diagram illustrates how does schema work on the 
Producer side.
 3. The broker looks up the schema in the schema storage to check if it is 
already a registered schema. 

 4. If yes, the broker skips the schema validation since it is a known schema, 
and returns the schema version to the producer.
+
+5. If no, the broker judge whether this namespace can automatically create 
schema.
+   isAllowAutoUpdateSchema can be modified by Admin-Api and REST-API 
   
-5. If no, the broker validates the schema based on the schema compatibility 
check strategy defined for the topic. 
+6. If yes, the broker validates the schema based on the schema compatibility 
check strategy defined for the topic. 
 
 Review comment:
   I've moved the line 546 to the step 5.
   If it is correct, can we delete the line 546?
   
   
![image](https://user-images.githubusercontent.com/50226895/69842795-9c52e600-129f-11ea-904b-0ccd82015f20.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351965710
 
 

 ##
 File path: site2/docs/schema-manage.md
 ##
 @@ -50,17 +58,22 @@ For a consumer, the `AutoUpdate` happens in the following 
cases:
 
 * If a **consumer connects to a topic without a schema** (which means the 
consumer receiving raw bytes), the consumer can connect to the topic 
successfully without doing any compatibility check.
 
-* If a **consumer connects to a topic with a schema**:
-
-  * If the **topic is idle** (no producers, no entries, no other consumers and 
no registered schemas), the broker registers a schema for the topic 
automatically.
+* If a **consumer connects to a topic with a schema**.
 
-  * If the **topic is not idle**, the broker verifies if the schema provided 
by the consumer is compatible with the registered schema of the topic. 
+* If topic don't have schema, no data or no local consumers and no local 
producers.
 
 Review comment:
   ```suggestion
   * If a topic does not have all of them (a schema/data/a local consumer 
and a local producer):
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351966303
 
 

 ##
 File path: site2/docs/schema-manage.md
 ##
 @@ -50,17 +58,22 @@ For a consumer, the `AutoUpdate` happens in the following 
cases:
 
 * If a **consumer connects to a topic without a schema** (which means the 
consumer receiving raw bytes), the consumer can connect to the topic 
successfully without doing any compatibility check.
 
-* If a **consumer connects to a topic with a schema**:
-
-  * If the **topic is idle** (no producers, no entries, no other consumers and 
no registered schemas), the broker registers a schema for the topic 
automatically.
+* If a **consumer connects to a topic with a schema**.
 
-  * If the **topic is not idle**, the broker verifies if the schema provided 
by the consumer is compatible with the registered schema of the topic. 
+* If topic don't have schema, no data or no local consumers and no local 
producers.
 
-* If the **schema passes the compatibility check**, the consumer can 
connect to the topic and receive messages. 
+* If `isAllowAutoUpdateSchema` = true, register the schema and connect.
+
+* If `isAllowAutoUpdateSchema` = false, rejected.
+
+* If topic have schema, have data or have local consumers and have local 
producers., schema do compatibility check
 
 Review comment:
   ```suggestion
   * If a topic has one of them (a schema/data/a local consumer and a local 
producer), then the schema compatibility check is performed.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351971439
 
 

 ##
 File path: site2/docs/schema-manage.md
 ##
 @@ -75,7 +88,7 @@ You can use the `pulsar-admin` command to manage the 
`AutoUpdate` strategy as be
 To disable `AutoUpdate` on a namespace, you can use the `pulsar-admin` command.
 
 ```bash
-bin/pulsar-admin namespaces set-schema-autoupdate-strategy --disabled 
tenant/namespace
+bin/pulsar-admin namespaces set-is-allow-auto-update-schema --disabled 
tenant/namespace
 
 Review comment:
   Do we consider adding **enable AutoUpdate** before this part? 
   
   From line 82:
   ```suggestion
   * [Enable AutoUpdate](#enable-autoupdate)
   * [Disable AutoUpdate](#disable-autoupdate)
   * [Adjust compatibility](#adjust-compatibility)
   
    Enable AutoUpdate
   
   To enable `AutoUpdate` on a namespace, you can use the `pulsar-admin` 
command.
   
   ```bash
   bin/pulsar-admin namespaces set-is-allow-auto-update-schema --enable 
tenant/namespace
   ```
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351972673
 
 

 ##
 File path: site2/docs/schema-understand.md
 ##
 @@ -539,14 +539,17 @@ This diagram illustrates how does schema work on the 
Producer side.
 3. The broker looks up the schema in the schema storage to check if it is 
already a registered schema. 

 4. If yes, the broker skips the schema validation since it is a known schema, 
and returns the schema version to the producer.
+
+5. If no, the broker judge whether this namespace can automatically create 
schema.
+   isAllowAutoUpdateSchema can be modified by Admin-Api and REST-API 
 
 Review comment:
   ```suggestion
   5. If no, the broker verifies whether a schema can be automatically created 
in this namespace:
 * If `isAllowAutoUpdateSchema` sets to **true**, then a schema can be 
created, and the broker validates the schema based on the schema compatibility 
check strategy defined for the topic.
 * If `isAllowAutoUpdateSchema` sets to **false**, then a schema can not be 
created, and the consumer is rejected to connect to the broker.
   
   **Tip**:
   `isAllowAutoUpdateSchema` can be set via **Pulsar admin API** or **REST 
API.** 
   For how to set `isAllowAutoUpdateSchema` via Pulsar admin API, see [Manage 
AutoUpdate Strategy](schema-manage.md/#manage-autoupdate-strategy).
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351964839
 
 

 ##
 File path: site2/docs/schema-manage.md
 ##
 @@ -36,11 +36,19 @@ For a producer, the `AutoUpdate` happens in the following 
cases:
 
   * If a **producer carries a schema**:
   
-A broker performs the compatibility check based on the configured 
compatibility check strategy of the namespace to which the topic belongs. 
+A broker performs the compatibility check based on the configured 
compatibility check strategy of the namespace to which the topic belongs.
 
-* If it is a new schema and it passes the compatibility check, the broker 
registers a new schema automatically for the topic.
-
-* If the schema does not pass the compatibility check, the broker does not 
register a schema.
+* If the schema is registered, producer is connected. 
+
+* If the schema isn't registered
 
 Review comment:
   ```suggestion
   * If the schema is not registered:
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351965377
 
 

 ##
 File path: site2/docs/schema-manage.md
 ##
 @@ -36,11 +36,19 @@ For a producer, the `AutoUpdate` happens in the following 
cases:
 
   * If a **producer carries a schema**:
   
-A broker performs the compatibility check based on the configured 
compatibility check strategy of the namespace to which the topic belongs. 
+A broker performs the compatibility check based on the configured 
compatibility check strategy of the namespace to which the topic belongs.
 
-* If it is a new schema and it passes the compatibility check, the broker 
registers a new schema automatically for the topic.
-
-* If the schema does not pass the compatibility check, the broker does not 
register a schema.
+* If the schema is registered, producer is connected. 
+
+* If the schema isn't registered
+
+* If`isAllowAutoUpdateSchema` = false, producer is rejected.
+
+* If `isAllowAutoUpdateSchema` = true
+ 
+* If schema pass the compatibility check then the broker registers 
a new schema automatically for the topic and producer is connected.
+
+* If the schema does not pass the compatibility check, the broker 
does not register a schema and producer is rejected.
 
 Review comment:
   ```suggestion
   * If the schema does not pass the compatibility check, then the 
broker does not register a schema and the producer is rejected to connect to a 
broker.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351964819
 
 

 ##
 File path: site2/docs/schema-manage.md
 ##
 @@ -36,11 +36,19 @@ For a producer, the `AutoUpdate` happens in the following 
cases:
 
   * If a **producer carries a schema**:
   
-A broker performs the compatibility check based on the configured 
compatibility check strategy of the namespace to which the topic belongs. 
+A broker performs the compatibility check based on the configured 
compatibility check strategy of the namespace to which the topic belongs.
 
-* If it is a new schema and it passes the compatibility check, the broker 
registers a new schema automatically for the topic.
-
-* If the schema does not pass the compatibility check, the broker does not 
register a schema.
+* If the schema is registered, producer is connected. 
 
 Review comment:
   ```suggestion
   * If the schema is registered, a producer is connected to a broker. 
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351966076
 
 

 ##
 File path: site2/docs/schema-manage.md
 ##
 @@ -50,17 +58,22 @@ For a consumer, the `AutoUpdate` happens in the following 
cases:
 
 * If a **consumer connects to a topic without a schema** (which means the 
consumer receiving raw bytes), the consumer can connect to the topic 
successfully without doing any compatibility check.
 
-* If a **consumer connects to a topic with a schema**:
-
-  * If the **topic is idle** (no producers, no entries, no other consumers and 
no registered schemas), the broker registers a schema for the topic 
automatically.
+* If a **consumer connects to a topic with a schema**.
 
-  * If the **topic is not idle**, the broker verifies if the schema provided 
by the consumer is compatible with the registered schema of the topic. 
+* If topic don't have schema, no data or no local consumers and no local 
producers.
 
-* If the **schema passes the compatibility check**, the consumer can 
connect to the topic and receive messages. 
+* If `isAllowAutoUpdateSchema` = true, register the schema and connect.
+
+* If `isAllowAutoUpdateSchema` = false, rejected.
 
 Review comment:
   ```suggestion
   * If `isAllowAutoUpdateSchema` sets to **false**, then the consumer 
is rejected to connect to a broker.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351965303
 
 

 ##
 File path: site2/docs/schema-manage.md
 ##
 @@ -36,11 +36,19 @@ For a producer, the `AutoUpdate` happens in the following 
cases:
 
   * If a **producer carries a schema**:
   
-A broker performs the compatibility check based on the configured 
compatibility check strategy of the namespace to which the topic belongs. 
+A broker performs the compatibility check based on the configured 
compatibility check strategy of the namespace to which the topic belongs.
 
-* If it is a new schema and it passes the compatibility check, the broker 
registers a new schema automatically for the topic.
-
-* If the schema does not pass the compatibility check, the broker does not 
register a schema.
+* If the schema is registered, producer is connected. 
+
+* If the schema isn't registered
+
+* If`isAllowAutoUpdateSchema` = false, producer is rejected.
+
+* If `isAllowAutoUpdateSchema` = true
+ 
+* If schema pass the compatibility check then the broker registers 
a new schema automatically for the topic and producer is connected.
 
 Review comment:
   ```suggestion
   * If schema pass the compatibility check then the broker 
registers a new schema automatically for the topic and producer is connected.
   ```
   ```suggestion
   * If the schema passes the compatibility check, then the broker 
registers a new schema automatically for the topic and the producer is 
connected.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] congbobo184 edited a comment on issue #5757: [doc]Modify schema compatibility check doc

congbobo184 edited a comment on issue #5757: [doc]Modify schema compatibility 
check doc
URL: https://github.com/apache/pulsar/pull/5757#issuecomment-559649018
 
 
   This seems like a good way.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] congbobo184 commented on issue #5757: [doc]Modify schema compatibility check doc

congbobo184 commented on issue #5757: [doc]Modify schema compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#issuecomment-559649018
 
 
   This seems like a good way


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5757: [doc]Modify schema compatibility check doc

sijie commented on issue #5757: [doc]Modify schema compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#issuecomment-559648008
 
 
   @congbobo184 if those two commands are deprecated, you can add `hidden` flag 
to hide them.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] congbobo184 edited a comment on issue #5757: [doc]Modify schema compatibility check doc

congbobo184 edited a comment on issue #5757: [doc]Modify schema compatibility 
check doc
URL: https://github.com/apache/pulsar/pull/5757#issuecomment-559647039
 
 
   @sijie 
   ```
   bin/pulsar-admin namespaces set-schema-autoupdate-strategy --compatibility 
 tenant/namespace
   bin/pulsar-admin namespaces get-schema-autoupdate-strategy --compatibility 
 tenant/namespace
   ```
   I think this two command should not be provided to users.
   It's easy to confuse users following commands :
   ```
   bin/pulsar-admin namespaces set-schema-compatibility-strategy 
--compatibility  tenant/namespace
   bin/pulsar-admin namespaces get-schema-compatibility-strategy 
--compatibility  tenant/namespace
   bin/pulsar-admin namespaces get-is-allow-auto-update-schema --disable 
tenant/namespace
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] congbobo184 commented on issue #5757: [doc]Modify schema compatibility check doc

congbobo184 commented on issue #5757: [doc]Modify schema compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#issuecomment-559647039
 
 
   @sijie 
   ```
   bin/pulsar-admin namespaces set-schema-autoupdate-strategy --compatibility 
 tenant/namespace
   bin/pulsar-admin namespaces get-schema-autoupdate-strategy --compatibility 
 tenant/namespace
   ```
   I think this two command should not be provided to users.
   It's easy to confuse users.
   ```
   bin/pulsar-admin namespaces set-schema-compatibility-strategy 
--compatibility  tenant/namespace
   bin/pulsar-admin namespaces get-schema-compatibility-strategy 
--compatibility  tenant/namespace
   bin/pulsar-admin namespaces get-is-allow-auto-update-schema --disable 
tenant/namespace
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5766: [tests] ManagedLedgerFactoryChangeLedgerPathTest is flaky

sijie commented on issue #5766: [tests] 
ManagedLedgerFactoryChangeLedgerPathTest is flaky
URL: https://github.com/apache/pulsar/pull/5766#issuecomment-559646482
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

svn commit: r36981 [1/2] - in /dev/pulsar/pulsar-2.4.2-candidate-3: ./ DEB/ RPMS/ RPMS/repodata/ connectors/

Author: rxl
Date: Fri Nov 29 03:18:59 2019
New Revision: 36981

Log:
Staging artifacts and signature for Pulsar release 2.4.2

Added:
dev/pulsar/pulsar-2.4.2-candidate-3/
dev/pulsar/pulsar-2.4.2-candidate-3/DEB/
dev/pulsar/pulsar-2.4.2-candidate-3/DEB/Packages.gz   (with props)
dev/pulsar/pulsar-2.4.2-candidate-3/DEB/Packages.gz.asc
dev/pulsar/pulsar-2.4.2-candidate-3/DEB/Packages.gz.sha512
dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/apache-pulsar-client-debuginfo-2.4.2-1.x86_64.rpm
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/apache-pulsar-client-debuginfo-2.4.2-1.x86_64.rpm.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/apache-pulsar-client-debuginfo-2.4.2-1.x86_64.rpm.sha512
dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/b63720768aaddd3a20fbdd6f629e19762d370943e1f55cd0dea30630e04b999b-primary.xml.gz
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/b63720768aaddd3a20fbdd6f629e19762d370943e1f55cd0dea30630e04b999b-primary.xml.gz.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/b63720768aaddd3a20fbdd6f629e19762d370943e1f55cd0dea30630e04b999b-primary.xml.gz.sha512

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/d2e33d37010272101e891b9c3cfcb8f145420ec7cd7996dc42d6b7d3f380bf0e-filelists.xml.gz
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/d2e33d37010272101e891b9c3cfcb8f145420ec7cd7996dc42d6b7d3f380bf0e-filelists.xml.gz.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/d2e33d37010272101e891b9c3cfcb8f145420ec7cd7996dc42d6b7d3f380bf0e-filelists.xml.gz.sha512

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/dc09fd722436618912dc98dd8a436c3dc230da405c08bf6d74515c5285c587c6-other.sqlite.bz2
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/dc09fd722436618912dc98dd8a436c3dc230da405c08bf6d74515c5285c587c6-other.sqlite.bz2.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/dc09fd722436618912dc98dd8a436c3dc230da405c08bf6d74515c5285c587c6-other.sqlite.bz2.sha512

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/deff38ee75d0897f0efa30804c3cf25c88e4dbcedf27283702946aee91cef83d-filelists.sqlite.bz2
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/deff38ee75d0897f0efa30804c3cf25c88e4dbcedf27283702946aee91cef83d-filelists.sqlite.bz2.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/deff38ee75d0897f0efa30804c3cf25c88e4dbcedf27283702946aee91cef83d-filelists.sqlite.bz2.sha512

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/e03a84e132004b733f0391396d58daa2897e0ed0c0249b7729e501abaa2691c1-primary.sqlite.bz2
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/e03a84e132004b733f0391396d58daa2897e0ed0c0249b7729e501abaa2691c1-primary.sqlite.bz2.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/e03a84e132004b733f0391396d58daa2897e0ed0c0249b7729e501abaa2691c1-primary.sqlite.bz2.sha512

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/fd16df1037d96ed64bc9483e11d5427f29de2879697713291740a6eeb2c9f886-other.xml.gz
   (with props)

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/fd16df1037d96ed64bc9483e11d5427f29de2879697713291740a6eeb2c9f886-other.xml.gz.asc

dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/fd16df1037d96ed64bc9483e11d5427f29de2879697713291740a6eeb2c9f886-other.xml.gz.sha512
dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/repomd.xml
dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/repomd.xml.asc
dev/pulsar/pulsar-2.4.2-candidate-3/RPMS/repodata/repomd.xml.sha512
dev/pulsar/pulsar-2.4.2-candidate-3/apache-pulsar-2.4.2-bin.tar.gz   (with 
props)
dev/pulsar/pulsar-2.4.2-candidate-3/apache-pulsar-2.4.2-bin.tar.gz.asc
dev/pulsar/pulsar-2.4.2-candidate-3/apache-pulsar-2.4.2-bin.tar.gz.sha512
dev/pulsar/pulsar-2.4.2-candidate-3/apache-pulsar-2.4.2-src.tar.gz   (with 
props)
dev/pulsar/pulsar-2.4.2-candidate-3/apache-pulsar-2.4.2-src.tar.gz.asc
dev/pulsar/pulsar-2.4.2-candidate-3/apache-pulsar-2.4.2-src.tar.gz.sha512

dev/pulsar/pulsar-2.4.2-candidate-3/apache-pulsar-offloaders-2.4.2-bin.tar.gz   
(with props)

dev/pulsar/pulsar-2.4.2-candidate-3/apache-pulsar-offloaders-2.4.2-bin.tar.gz.asc

dev/pulsar/pulsar-2.4.2-candidate-3/apache-pulsar-offloaders-2.4.2-bin.tar.gz.sha512
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/LICENSE
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/README

dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-aerospike-2.4.2.nar   
(with props)

dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-aerospike-2.4.2.nar.asc

dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-aerospike-2.4.2.nar.sha512
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-canal-2.4.2.nar   
(with props)
dev/pulsar/pulsar-2.4.2-candidate-3/conn

svn commit: r36981 [2/2] - in /dev/pulsar/pulsar-2.4.2-candidate-3: ./ DEB/ RPMS/ RPMS/repodata/ connectors/

Added: 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-jdbc-2.4.2.nar.asc
==
--- dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-jdbc-2.4.2.nar.asc 
(added)
+++ dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-jdbc-2.4.2.nar.asc 
Fri Nov 29 03:18:59 2019
@@ -0,0 +1,16 @@
+-BEGIN PGP SIGNATURE-
+
+iQIzBAABCAAdFiEEHqpd6S06DEdJ6YRttJ34KK/JpEIFAl3f6CIACgkQtJ34KK/J
+pEKZ1Q//atFldb2O0a/5RYM4nhxITBghgarwUFta4lIy6k5Ub8PAiOH4nRI2dJTj
+W7EG/iFcHhAYD+IHOVD4H9DimYG4+41hpeZqvxR2R1mktG3hm2nHRdzoMJD3NVV0
+GRSLdkLy6VL22sjmiO0wU7lo8JM17PoheoFC6rLBZ0/7JwRKiGS3hspYlk+6uW2e
+McCCjU+79mzye/99BhqhB4jS4R1FM2O7l9UGlf1XFknpcEg1aZsYckR7bqrgder+
+i7KgDn9Jm2V5emWy9lV9q+Z2lyR8i+2hHdmQbIcbbSVtqo3t3GKlQIrWiuHb9lvN
+zY4Y1N/3LFMlYVUMw2SrUAbDiVI3Sa6jkJvdfDKt8JPB8TjdI6xuW07lOa8mCGG9
+k7UMFqD1w4rPm+jjg1GCgLm6wP+2NvUb3HMzuH1l/omZyFnQoRb8uX0KopoYhAeX
+4B69Gx1A25jfNqS84vsohPW4Y6J3xFVSmYK3WXrZS1I6qRzBL+8m3zakg2XM119C
+b/gqStP2EywrvyAZHqMqS9mJ1MzeJbvQjMnAvCWn6buC9hAcjR2xOoHYRVKyyqiw
+teah6/JxXJiLwvHGQkm4hesFtJdmzKAdbIFoUPE/AZ5VlEbCaosyTX288PEnuBFr
+epxXHUVAxMmA/xrGfhlbqJF5uiQy0sL8bEIz6W/FBDquHtog8h0=
+=HFW5
+-END PGP SIGNATURE-

Added: 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-jdbc-2.4.2.nar.sha512
==
--- 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-jdbc-2.4.2.nar.sha512 
(added)
+++ 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-jdbc-2.4.2.nar.sha512 
Fri Nov 29 03:18:59 2019
@@ -0,0 +1 @@
+fb1ae2a42e4674bef84a5227b10c87e31871c1d8187dcee931419f4bffeb8b393e28f9ffa9e2751ba53c9445d4a8efecdba78cb233d19b78b0b070ec1b41a3fd
  ./connectors/pulsar-io-jdbc-2.4.2.nar

Added: dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-kafka-2.4.2.nar
==
Binary file - no diff available.

Propchange: 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-kafka-2.4.2.nar
--
svn:mime-type = application/octet-stream

Added: 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-kafka-2.4.2.nar.asc
==
--- 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-kafka-2.4.2.nar.asc 
(added)
+++ 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-kafka-2.4.2.nar.asc 
Fri Nov 29 03:18:59 2019
@@ -0,0 +1,16 @@
+-BEGIN PGP SIGNATURE-
+
+iQIzBAABCAAdFiEEHqpd6S06DEdJ6YRttJ34KK/JpEIFAl3f6CMACgkQtJ34KK/J
+pEKboBAA4+Izop88SMvAVDlGux2a2imxlvawJ+/f0WOzsnmyHrBum8Z0fgcqrLUA
+DNszhKfA2Cp3pZxm3WiSZZ1Iz7BSqAj5jisWf/HZ0w55LrbVcYlonkpUQHuLO/z+
+8b5I5weP8w1WiilZ0MFV6PeR2VRbnLTMg/qenCajc4Q8Vse7R1voOUJCd4aRvwbp
+vV3Xwa73Uuk3eg/uei/5YsAKxwuF4ejBnPG0l9b+B6DURBllCtozysOsenU0LbcV
+cJqtB7XKHu+CE1ljJ6sxB+RJCUn0dT/Fsos+1UtOthnWvy0DgksGmtdR2uuQRPap
+s6o6Ozlghrzm2ASyM8T/iZj7YhamRPHTLgmCZtKXDAdh1i09V+5zcdXS02jaNWTG
+IYZdMiVpF6DXfrz/Ib2gwyImLnJQ6GxczKD2hvLOS6akupqUffS4kII56T1HBvbY
+0LTtUK/aMnfzEZk+vU/HOL0L5sp2tq2v2wRpDz+guRBjqPz4Te9KhDj6vNiQlq4Y
+w+QE1R6xP29x7kWQTjORBZOjEfqoBnH/0UQBOJxs+U5Ckr4QgLjDHphTm3zW1kDP
+zyx3yT7txYo2qv2+zkRuasonC1tyewikbaaTXY38bx8ezESdY4HfDYQM2JDeVYcf
+epIJlvc/8wJ0qASIBNtZyAdbfrbL/R/Vc8RS+IZ9hrd1GupOlsk=
+=LfUf
+-END PGP SIGNATURE-

Added: 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-kafka-2.4.2.nar.sha512
==
--- 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-kafka-2.4.2.nar.sha512 
(added)
+++ 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-kafka-2.4.2.nar.sha512 
Fri Nov 29 03:18:59 2019
@@ -0,0 +1 @@
+bc1939ec51fcec38359a1473c258cbc7dc75f3d14b710f53b6faeb12b89dffb2af513cd3c21b77d052b8a0a88dc4051a0aa57a97b6be5fbf7ad5c455aabcc508
  ./connectors/pulsar-io-kafka-2.4.2.nar

Added: 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-kafka-connect-adaptor-2.4.2.nar
==
Binary file - no diff available.

Propchange: 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-kafka-connect-adaptor-2.4.2.nar
--
svn:mime-type = application/octet-stream

Added: 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-kafka-connect-adaptor-2.4.2.nar.asc
==
--- 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-kafka-connect-adaptor-2.4.2.nar.asc
 (added)
+++ 
dev/pulsar/pulsar-2.4.2-candidate-3/connectors/pulsar-io-kafka-connect-adaptor-2.4.2.nar.asc
 Fri Nov 29 03:18:59 2019
@@ -0,0 +1,16 @@
+-BEGIN PGP SIGNATURE-
+
+iQIzBAABCAAdFiEEHqpd6S06DEdJ6YRttJ34KK/JpEIFAl3f6CsACgkQtJ34KK/J
+pEI2nw//R5HFeOjrLDQQ96lrCdUCEOj+EhZF++zNo1L4xMkc529lPgoHujdiogW

[GitHub] [pulsar] sijie commented on issue #5738: [Pulsar Client Tools]Support generate documentation of pulsar admin cli automatically

sijie commented on issue #5738: [Pulsar Client Tools]Support generate 
documentation of pulsar admin cli automatically
URL: https://github.com/apache/pulsar/pull/5738#issuecomment-559645674
 
 
   > I found that different command objects jcommand was used in the 
PulsarAdminTool and CmdBase.
   
   The jcommand in PulsarrAdminTool is the root command.The jcommand in CmdBase 
is for a command group.
   
   > All the child commands were inherited from the class CmdBase. In 
subclasses such as CmdTopics, we cannot get the commandMap object. 
   
   You can get the command groups from the commandMap of PulsarAdminTool. Then 
you can iterate the command group. For each command group, you can get its sub 
commandMap. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5768: [CLI] Add a broker tool for operations of a specific broker

sijie commented on issue #5768: [CLI] Add a broker tool for operations of a 
specific broker
URL: https://github.com/apache/pulsar/pull/5768#issuecomment-559643791
 
 
   This is the tool runs on broker. It is used for troubleshooting why broker 
can’t collect right load report. The command in Pulsar-admin is used for 
querying the data reported to zookeeper. That’s the difference.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351958437
 
 

 ##
 File path: site2/docs/schema-evolution-compatibility.md
 ##
 @@ -366,6 +366,40 @@ Any order
 
 
 
+
+
+ 
+
+`UNDEFINED`
+
+ 
+
+ 
+
+The schema compatibility check strategy in order to Upgrade to 2.5.0 or above 
for compatibility with pulsar version below 2.5.0.
 
 Review comment:
   ```suggestion
   * If you upgrade a lower version to Pulsar 2.5.0, then it uses the 
`UNDEFINED` strategy, at this time, it actually uses the compatibility strategy 
of the topic.
   
   * If you use Pulsar 2.5.0 and a higher version, then it uses the `UNDEFINED` 
strategy, at this time, it actually uses the `FULL` compatibility strategy.
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351959172
 
 

 ##
 File path: site2/docs/schema-evolution-compatibility.md
 ##
 @@ -626,6 +660,44 @@ None
 
 In some data formats, for example, Avro, you can define fields with default 
values. Consequently, adding or removing a field with a default value is a 
fully compatible change.
 
+### UNDEFINED 
+
+
+
+
+
+
+
+Compatibility check strategy
+
+
+
+
+
+Note 
+
+
+
+
+
+
+
+ 
+
+`UNDEFINED`
+
+ 
+
+ 
+
+The schema compatibility check strategy in order to Upgrade to 2.5.0 or above 
for compatibility with pulsar version below 2.5.0.
 
 Review comment:
   ```suggestion
   * If you upgrade a lower version to Pulsar 2.5.0, then it uses the 
`UNDEFINED` strategy, at this time, it actually uses the compatibility strategy 
of the topic.
   
   * If you use Pulsar 2.5.0 and a higher version, then it uses the `UNDEFINED` 
strategy, at this time, it actually uses the `FULL` compatibility strategy.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351963820
 
 

 ##
 File path: site2/docs/schema-evolution-compatibility.md
 ##
 @@ -626,6 +660,44 @@ None
 
 In some data formats, for example, Avro, you can define fields with default 
values. Consequently, adding or removing a field with a default value is a 
fully compatible change.
 
+### UNDEFINED 
+
+
+
+
+
+
+
+Compatibility check strategy
+
+
+
+
+
+Note 
+
+
+
+
+
+
+
+ 
+
+`UNDEFINED`
+
+ 
+
+ 
+
+The schema compatibility check strategy in order to Upgrade to 2.5.0 or above 
for compatibility with pulsar version below 2.5.0.
+
+ 
+
+
+
+
+
 
 Review comment:
   Add schema verification here. I've re-written some sentences as well.
   
   ```suggestion
   ## Schema verification
   
   When a producer or a consumer tries to connect to a topic, a broker performs 
some checks to verify a schema.
   
   ### Producer
   
   When a producer tries to connect to a topic (suppose ignore the schema auto 
creation), a broker does the following checks:
   
   * Check if the schema carried by the producer exists in the schema registry 
or not.
   
   * If the schema is already registered, then the producer is connected to 
a broker and produce messages with that schema.
   
   * If the schema is not registered, then Pulsar verifies if the schema is 
allowed to be registered based on the configured compatibility check strategy.
   
   ### Consumer
   
   When a consumer tries to connect to a topic, a broker checks if a carried 
schema is compatible with a registered schema based on the configured schema 
compatibility check strategy.
   
   
   
   
   
   
   
   Compatibility check strategy
   
   
   
   
   
   Check logic
   
   
   
   
   
   
   

   
   `ALWAYS_COMPATIBLE`
   

   

   
   All pass
   
 
   
   
   
   
   

   
   `ALWAYS_INCOMPATIBLE`
   

   

   
   No pass
   

   
   
   
   
   

   
   `BACKWARD`
   

   

   
   Can read the last schema
   

   
   
   
   
   

   
   `BACKWARD_TRANSITIVE`
   

   

   
   Can read all schemas
   

   
   
   
   
   

   
   `FORWARD`
   

   

   
   Can read the last schema
   

   
   
   
   
   

   
   `FORWARD_TRANSITIVE`
   

   

   
   Can read the last schema
   

   
   
   
   
   

   
   `FULL`
   

   

   
   Can read the last schema
   

   
   
   
   
   

   
   `FULL_TRANSITIVE`
   

   

   
   Can read all schemas
   

   
   
   
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351958691
 
 

 ##
 File path: site2/docs/schema-evolution-compatibility.md
 ##
 @@ -366,6 +366,40 @@ Any order
 
 
 
+
+
+ 
+
+`UNDEFINED`
+
+ 
+
+ 
+
+The schema compatibility check strategy in order to Upgrade to 2.5.0 or above 
for compatibility with pulsar version below 2.5.0.
+
+ 
+
+ 
+
+NONE
+
+ 
+
+ 
+
+NONE
+
+ 
 
 Review comment:
   ```suggestion
   It depends
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351959083
 
 

 ##
 File path: site2/docs/schema-evolution-compatibility.md
 ##
 @@ -626,6 +660,44 @@ None
 
 In some data formats, for example, Avro, you can define fields with default 
values. Consequently, adding or removing a field with a default value is a 
fully compatible change.
 
+### UNDEFINED 
+
+
+
+
+
+
+
+Compatibility check strategy
+
+
+
+
+
+Note 
 
 Review comment:
   ```suggestion
   Description
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351963750
 
 

 ##
 File path: site2/docs/schema-evolution-compatibility.md
 ##
 @@ -781,3 +853,168 @@ Consequently, you can upgrade the producers and 
consumers in **any order**.
 
 
 
+
+## Schema verification for producers
 
 Review comment:
   I've moved this part before `order of upgrading clients`, please delete 
lines 857-1017.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351958714
 
 

 ##
 File path: site2/docs/schema-evolution-compatibility.md
 ##
 @@ -366,6 +366,40 @@ Any order
 
 
 
+
+
+ 
+
+`UNDEFINED`
+
+ 
+
+ 
+
+The schema compatibility check strategy in order to Upgrade to 2.5.0 or above 
for compatibility with pulsar version below 2.5.0.
+
+ 
+
+ 
+
+NONE
+
+ 
+
+ 
+
+NONE
+
+ 
+
+ 
+
+NONE
 
 Review comment:
   ```suggestion
   It depends
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5757: [doc]Modify schema compatibility check doc

Anonymitaet commented on a change in pull request #5757: [doc]Modify schema 
compatibility check doc
URL: https://github.com/apache/pulsar/pull/5757#discussion_r351958676
 
 

 ##
 File path: site2/docs/schema-evolution-compatibility.md
 ##
 @@ -366,6 +366,40 @@ Any order
 
 
 
+
+
+ 
+
+`UNDEFINED`
+
+ 
+
+ 
+
+The schema compatibility check strategy in order to Upgrade to 2.5.0 or above 
for compatibility with pulsar version below 2.5.0.
+
+ 
+
+ 
+
+NONE
 
 Review comment:
   ```suggestion
   It depends
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #5745: Add document for sticky consumer

codelipenghui commented on issue #5745: Add document for sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745#issuecomment-559640226
 
 
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on issue #5766: [tests] ManagedLedgerFactoryChangeLedgerPathTest is flaky

tuteng commented on issue #5766: [tests] 
ManagedLedgerFactoryChangeLedgerPathTest is flaky
URL: https://github.com/apache/pulsar/pull/5766#issuecomment-559640236
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on issue #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

tuteng commented on issue #5741: [website]Add content of pulsar-manager in 
website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#issuecomment-559640081
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on issue #5768: [CLI] Add a broker tool for operations of a specific broker

tuteng commented on issue #5768: [CLI] Add a broker tool for operations of a 
specific broker
URL: https://github.com/apache/pulsar/pull/5768#issuecomment-559639959
 
 
   I saw a `broker-stats` sub-command under the command `pulsar-admin` and a 
`load-report` sub-command under the command `broker-stats`. I also saw this 
sub-command here. is there any difference between the two, why not consider 
adding it under pulsar-admin? @sijie 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on issue #5738: [Pulsar Client Tools]Support generate documentation of pulsar admin cli automatically

tuteng commented on issue #5738: [Pulsar Client Tools]Support generate 
documentation of pulsar admin cli automatically
URL: https://github.com/apache/pulsar/pull/5738#issuecomment-559637809
 
 
   Thank you for your suggestion. The situation you mentioned is my initial 
implementation plan. However, when I tested it, I found that different command 
objects `jcommand` was used in the PulsarAdminTool and CmdBase.
   
   PulsarAdminTool:
   
https://github.com/apache/pulsar/blob/master/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java#L87
   CmdBase:
   
https://github.com/apache/pulsar/blob/master/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBase.java#L38
   
   
   All the child commands were inherited from the class `CmdBase`. In 
subclasses such as `CmdTopics`, we cannot get the `commandMap` object. 
Therefore, it may be necessary to pass down the `commandmap` object and the 
`jcommand` object of `PulsarAdminTool`. therefore, it is necessary to add some 
logic to the `PulsarAdmintool`. I am not sure if my understanding is correct. I 
hope to get your reply, but I will try this implementation as much as possible.
   
   @sijie 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on issue #5660: [docs]Add old version api document

tuteng commented on issue #5660: [docs]Add old version api document
URL: https://github.com/apache/pulsar/pull/5660#issuecomment-559634878
 
 
   It seems to be my local language environment problem. I will regenerate 
these documents.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #5745: Add document for sticky consumer

codelipenghui commented on issue #5745: Add document for sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745#issuecomment-559633716
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5279: Support for python native logging from python wrapper

sijie commented on issue #5279: Support for python native logging from python 
wrapper
URL: https://github.com/apache/pulsar/pull/5279#issuecomment-559633449
 
 
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5767: Support batch authorization of partitioned topic

sijie commented on issue #5767: Support batch authorization of partitioned topic
URL: https://github.com/apache/pulsar/pull/5767#issuecomment-559632996
 
 
   @zhaohaidao can you update the description of the pull request? so the 
reviewers can understand what is the motivation of this pull request?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie opened a new pull request #5768: [CLI] Add a broker tool for operations of a specific broker

sijie opened a new pull request #5768: [CLI] Add a broker tool for operations 
of a specific broker
URL: https://github.com/apache/pulsar/pull/5768
 
 
   *Motivation*
   
   Add a tool to collect load report on a specific broker.
   This is used for troubleshooting problems in a production cluster.
   
   *Modifications*
   
   Add a broker tool for operations of a specific broker.
   
   ```
   broker-tool is used for operations on a specific broker
   
   Usage:  broker-tool [flags] [commands]
   
   Commands:
   
   load-report Collect the load report of a specific broker
   
   helpDisplay help information about it
   
   Flags:
   
   
   -h, --help
   Display help information
   
   Use "broker-tool [command] --help" or "broker-tool help [command]" for more
   information about a command
   ```
   
   ```
   Collect the load report of a specific broker
   
   Usage:  load-report [flags]
   
   Flags:
   
   -i, --interval-ms
   Interval to collect load report, in milliseconds
   
   
   -h, --help
   Display help information
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5766: [tests] ManagedLedgerFactoryChangeLedgerPathTest is flaky

sijie commented on issue #5766: [tests] 
ManagedLedgerFactoryChangeLedgerPathTest is flaky
URL: https://github.com/apache/pulsar/pull/5766#issuecomment-559632656
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on issue #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

tuteng commented on issue #5741: [website]Add content of pulsar-manager in 
website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#issuecomment-559632396
 
 
   run java8 tests
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Jennifer88huang commented on issue #5762: Add the filesystem offload doc

Jennifer88huang commented on issue #5762: Add the filesystem offload doc
URL: https://github.com/apache/pulsar/pull/5762#issuecomment-559631006
 
 
   @sijie Got it. Thanks for your reminder. We should consider reorganizing it. 
Currently, there are two "tiered storage" sections in sidebar under "Concepts 
and architecture" and "Cookbooks".


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] massakam commented on issue #5758: Bump jackson libraries to 2.10.1

massakam commented on issue #5758: Bump jackson libraries to 2.10.1
URL: https://github.com/apache/pulsar/pull/5758#issuecomment-559627897
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] zhaohaidao opened a new pull request #5767: Support batch authorization of partitioned topic

zhaohaidao opened a new pull request #5767: Support batch authorization of 
partitioned topic
URL: https://github.com/apache/pulsar/pull/5767
 
 
   
   
   *(If this PR fixes a github issue, please add `Fixes #`.)*
   
   Fixes #
   
   *(or if this PR is one task of a github issue, please add `Master Issue: 
#` to link to the master issue.)*
   
   Master Issue: #
   
   ### Motivation
   
   
   *Explain here the context, and why you're making that change. What is the 
problem you're trying to solve.*
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   - [ ] Add unit tests for this change and make sure that the change passes 
the CI checks
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe 
tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
 - *Added integration tests for end-to-end deployment with large payloads 
(10MB)*
 - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
 - Dependencies (does it add or upgrade a dependency): (yes / no)
 - The public API: (yes / no)
 - The schema: (yes / no / don't know)
 - The default values of configurations: (yes / no)
 - The wire protocol: (yes / no)
 - The rest endpoints: (yes / no)
 - The admin cli options: (yes / no)
 - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
 - Does this pull request introduce a new feature? (yes / no)
 - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
 - If a feature is not applicable for documentation, explain why?
 - If a feature is not documented yet in this PR, please create a followup 
issue for adding the documentation
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie opened a new pull request #5766: [tests] ManagedLedgerFactoryChangeLedgerPathTest is flaky

sijie opened a new pull request #5766: [tests] 
ManagedLedgerFactoryChangeLedgerPathTest is flaky
URL: https://github.com/apache/pulsar/pull/5766
 
 
   Master Issue: #
   
   *Motivation*
   
   ManagedLedgerFactoryChangeLedgerPathTest sets the zk session timeout to 10 
ms.
   
   10ms is too low for a zookeeper client to connect to the zookeeper server.
   
   *Modifications*
   
   Remove zkSessionTimeout and use the default
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie closed issue #5746: NPE occur when send an over size message.

sijie closed issue #5746: NPE occur when send an over size message.
URL: https://github.com/apache/pulsar/issues/5746
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #5748: Fix NPE and release already released ByteBuf in batch message container

sijie merged pull request #5748: Fix NPE and release already released ByteBuf 
in batch message container
URL: https://github.com/apache/pulsar/pull/5748
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch master updated: Fix NPE when send a large message and don't release batchedMessageMetadataAndPayload when discard in batch message container. (#5748)

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
 new ecf7792  Fix NPE when send a large message and don't release 
batchedMessageMetadataAndPayload when discard in batch message container. 
(#5748)
ecf7792 is described below

commit ecf779210c31d1051f9cd2c823a1a7d078cdfd75
Author: lipenghui 
AuthorDate: Fri Nov 29 06:38:23 2019 +0800

Fix NPE when send a large message and don't release 
batchedMessageMetadataAndPayload when discard in batch message container. 
(#5748)

Fixes #5746 #5747

### Motivation

Fix NPE and release an already released ByteBuf when publish an oversize 
message.

Here is error log:
```
io.netty.util.IllegalReferenceCountException: refCnt: 0, decrement: 1
at 
io.netty.util.internal.ReferenceCountUpdater.toLiveRealRefCnt(ReferenceCountUpdater.java:74)
 ~[netty-common-4.1.43.Final.jar:4.1.43.Final]
at 
io.netty.util.internal.ReferenceCountUpdater.release(ReferenceCountUpdater.java:138)
 ~[netty-common-4.1.43.Final.jar:4.1.43.Final]
at 
io.netty.buffer.AbstractReferenceCountedByteBuf.release(AbstractReferenceCountedByteBuf.java:100)
 ~[netty-buffer-4.1.43.Final.jar:4.1.43.Final]
at io.netty.util.ReferenceCountUtil.release(ReferenceCountUtil.java:88) 
~[netty-common-4.1.43.Final.jar:4.1.43.Final]
at 
io.netty.util.ReferenceCountUtil.safeRelease(ReferenceCountUtil.java:113) 
[netty-common-4.1.43.Final.jar:4.1.43.Final]
at 
org.apache.pulsar.client.impl.BatchMessageKeyBasedContainer$KeyedBatch.discard(BatchMessageKeyBasedContainer.java:244)
 [classes/:?]
at 
org.apache.pulsar.client.impl.BatchMessageKeyBasedContainer.createOpSendMsg(BatchMessageKeyBasedContainer.java:125)
 [classes/:?]
at 
org.apache.pulsar.client.impl.BatchMessageKeyBasedContainer.createOpSendMsgs(BatchMessageKeyBasedContainer.java:145)
 [classes/:?]
at 
org.apache.pulsar.client.impl.ProducerImpl.batchMessageAndSend(ProducerImpl.java:1426)
 [classes/:?]
at 
org.apache.pulsar.client.impl.ProducerImpl.triggerFlush(ProducerImpl.java:1411) 
[classes/:?]
at 
org.apache.pulsar.client.impl.ProducerBase.send(ProducerBase.java:112) 
[classes/:?]
at 
org.apache.pulsar.client.impl.TypedMessageBuilderImpl.send(TypedMessageBuilderImpl.java:89)
 [classes/:?]
at 
org.apache.pulsar.client.impl.ProducerBase.send(ProducerBase.java:63) 
[classes/:?]
at 
org.apache.pulsar.broker.service.BatchMessageTest.testSendOverSizeMessage(BatchMessageTest.java:875)
 [test-classes/:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[?:1.8.0_201]
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
~[?:1.8.0_201]
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[?:1.8.0_201]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_201]
at 
org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:124)
 [testng-6.14.3.jar:?]
at org.testng.internal.Invoker.invokeMethod(Invoker.java:583) 
[testng-6.14.3.jar:?]
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:719) 
[testng-6.14.3.jar:?]
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:989) 
[testng-6.14.3.jar:?]
at 
org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:125)
 [testng-6.14.3.jar:?]
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:109) 
[testng-6.14.3.jar:?]
at org.testng.TestRunner.privateRun(TestRunner.java:648) 
[testng-6.14.3.jar:?]
at org.testng.TestRunner.run(TestRunner.java:505) [testng-6.14.3.jar:?]
at org.testng.SuiteRunner.runTest(SuiteRunner.java:455) 
[testng-6.14.3.jar:?]
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:450) 
[testng-6.14.3.jar:?]
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:415) 
[testng-6.14.3.jar:?]
at org.testng.SuiteRunner.run(SuiteRunner.java:364) 
[testng-6.14.3.jar:?]
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52) 
[testng-6.14.3.jar:?]
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:84) 
[testng-6.14.3.jar:?]
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1208) 
[testng-6.14.3.jar:?]
at org.testng.TestNG.runSuitesLocally(TestNG.java:1137) 
[testng-6.14.3.jar:?]
at org.testng.TestNG.runSuites(TestNG.java:1049) [testng-6.14.3.jar:?]
at org.testng.TestNG.run(TestNG.java:1017) [testng-6.14.3.jar:?]
at org.testng.IDEARemoteTestNG.run(IDEARemoteTestNG.java:73) 
[testng-plugin.jar:?]
at org.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:123) 
[testng-plugin.jar:?]

[GitHub] [pulsar] rcollina commented on issue #2307: Provide a netcore client

rcollina commented on issue #2307: Provide a netcore client
URL: https://github.com/apache/pulsar/issues/2307#issuecomment-559612954
 
 
   @sijie thank you for your thorough reply, much appreciated.
   
   Confluent is an official enough a name when it comes to evaluating Kafka’s 
pros and cons. 
   
   I can’t honestly comment on which scenario would work best, whether to 
follow Kafka’s model regarding project ownership.
   
   What I know, given my current understanding of Pulsar’s featureset, it’s 
that it is closer to my requirements than Kafka’s. However, the project’s site 
does not even mention .NET Core. This unfortunately can turn potential users 
away.
   
   I’m aware offering a proper client is no easy undertaking, especially 
considering the introduction of “memory friendly” constructs like Span in the 
latest .NET iterations, but it’s essential to increase adoption. My humble 
opinion, of course.
   
   That being said, a gRPC endpoint + client package could be a viable 
solution, something to start with.
   
   Thank you
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch master updated: Remove cursor while remove non-durable subscription (#5719)

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
 new 2e30c08  Remove cursor while remove non-durable subscription (#5719)
2e30c08 is described below

commit 2e30c086b2461531c62164d09ea148928a0e3ae6
Author: lipenghui 
AuthorDate: Fri Nov 29 06:12:49 2019 +0800

Remove cursor while remove non-durable subscription (#5719)

### Motivation

Remove cursor from cursors of managed ledger while remove non-durable 
subscription.  The data deletion is depends the mark delete position of all 
cursors, if left a unused cursor in the cursors of managed ledger, data can't 
be delete as expected.

### Modifications

Remove cursor while remove non-durable subscription
---
 .../AbstractDispatcherSingleActiveConsumer.java|  4 +-
 .../org/apache/pulsar/broker/service/Consumer.java | 12 +-
 .../apache/pulsar/broker/service/Dispatcher.java   |  6 ++-
 .../apache/pulsar/broker/service/Subscription.java |  6 ++-
 .../nonpersistent/NonPersistentDispatcher.java |  4 +-
 .../NonPersistentDispatcherMultipleConsumers.java  |  2 +-
 .../nonpersistent/NonPersistentSubscription.java   |  2 +-
 .../PersistentDispatcherMultipleConsumers.java |  4 +-
 .../service/persistent/PersistentSubscription.java | 14 ++-
 .../org/apache/pulsar/client/impl/ReaderTest.java  | 44 +++---
 10 files changed, 79 insertions(+), 19 deletions(-)

diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractDispatcherSingleActiveConsumer.java
 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractDispatcherSingleActiveConsumer.java
index 02fcea1..509c3e3 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractDispatcherSingleActiveConsumer.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractDispatcherSingleActiveConsumer.java
@@ -219,11 +219,11 @@ public abstract class 
AbstractDispatcherSingleActiveConsumer extends AbstractBas
  *
  * @return
  */
-public synchronized CompletableFuture disconnectAllConsumers() {
+public synchronized CompletableFuture disconnectAllConsumers(boolean 
isResetCursor) {
 closeFuture = new CompletableFuture<>();
 
 if (!consumers.isEmpty()) {
-consumers.forEach(Consumer::disconnect);
+consumers.forEach(consumer -> consumer.disconnect(isResetCursor));
 cancelPendingRead();
 } else {
 // no consumer connected, complete disconnect immediately
diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
index fa45eb4..8c0e1d5 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
@@ -293,15 +293,23 @@ public class Consumer {
  * pending message acks
  */
 public void close() throws BrokerServiceException {
-subscription.removeConsumer(this);
+close(false);
+}
+
+public void close(boolean isResetCursor) throws BrokerServiceException {
+subscription.removeConsumer(this, isResetCursor);
 cnx.removedConsumer(this);
 }
 
 public void disconnect() {
+disconnect(false);
+}
+
+public void disconnect(boolean isResetCursor) {
 log.info("Disconnecting consumer: {}", this);
 cnx.closeConsumer(this);
 try {
-close();
+close(isResetCursor);
 } catch (BrokerServiceException e) {
 log.warn("Consumer {} was already closed: {}", this, 
e.getMessage(), e);
 }
diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Dispatcher.java 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Dispatcher.java
index 24118ae..cffa024 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Dispatcher.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Dispatcher.java
@@ -60,7 +60,11 @@ public interface Dispatcher {
  *
  * @return
  */
-CompletableFuture disconnectAllConsumers();
+CompletableFuture disconnectAllConsumers(boolean isResetCursor);
+
+default CompletableFuture disconnectAllConsumers() {
+return disconnectAllConsumers(false);
+}
 
 void resetCloseFuture();
 
diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Subscription.java
 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Subscription.java
index c044fa5..18c7c49 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Subscription.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Subscription.java
@@ -37,7

[GitHub] [pulsar] sijie merged pull request #5719: Remove cursor while remove non-durable subscription

sijie merged pull request #5719: Remove cursor while remove non-durable 
subscription
URL: https://github.com/apache/pulsar/pull/5719
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5745: Add document for sticky consumer

sijie commented on issue #5745: Add document for sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745#issuecomment-559610469
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #5376: [Issue 3009][docs] Add presto sql REST APIs doc

sijie merged pull request #5376: [Issue 3009][docs] Add presto sql REST APIs doc
URL: https://github.com/apache/pulsar/pull/5376
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch master updated (da80606 -> b23c732)

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from da80606  [Issue 5614] Deprecate 
brokerServicePurgeInactiveFrequencyInSeconds (#5632)
 add b23c732  [Issue 3009][docs] Add presto sql REST APIs doc (#5376)

No new revisions were added by this update.

Summary of changes:
 site2/docs/sql-rest-api.md  | 185 
 site2/website/sidebars.json |   3 +-
 2 files changed, 187 insertions(+), 1 deletion(-)
 create mode 100644 site2/docs/sql-rest-api.md

[GitHub] [pulsar] sijie closed issue #3009: documentation request: document presto http endpoint

sijie closed issue #3009: documentation request: document presto http endpoint
URL: https://github.com/apache/pulsar/issues/3009
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5279: Support for python native logging from python wrapper

sijie commented on issue #5279: Support for python native logging from python 
wrapper
URL: https://github.com/apache/pulsar/pull/5279#issuecomment-559610266
 
 
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5762: Add the filesystem offload doc

sijie commented on issue #5762: Add the filesystem offload doc
URL: https://github.com/apache/pulsar/pull/5762#issuecomment-559607110
 
 
   while @congbobo184 and @codelipenghui are settling down the technical 
details, @Jennifer88huang and @Anonymitaet we should consider reorganizing the 
documentation for tiered storage. we should consider adding a section called 
"Storage" or "Tiered Storage" at the sidebar rather than putting everything 
into a cookbook.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5147: Deprecate getstatus subcommand for source command

sijie commented on issue #5147: Deprecate getstatus subcommand for source 
command
URL: https://github.com/apache/pulsar/pull/5147#issuecomment-559606703
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] mickdelaney commented on issue #271: Consider using gRPC as an externally exposed API

mickdelaney commented on issue #271: Consider using gRPC as an externally 
exposed API
URL: https://github.com/apache/pulsar/issues/271#issuecomment-559566538
 
 
   @sijie thanks for the detailed feedback. i was thinking of the former, my 
thinking being that it would atleast remove some of the concerns in maintaining 
the various language level clients.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] cbornet edited a comment on issue #271: Consider using gRPC as an externally exposed API

cbornet edited a comment on issue #271: Consider using gRPC as an externally 
exposed API
URL: https://github.com/apache/pulsar/issues/271#issuecomment-559566128
 
 
   I think moving to gRPC for the Pulsar clients would have some benefits. For 
instance it already handles flow control and bi-directional streaming. For 
those who want to write native clients, that's a layer less to develop.
   Another interesting alternative could be RSocket which has some very nice 
features such as session resumption and message-level backpressure. In JAVA, it 
would be possible to have a fully reactive-streams API using these protocols. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] cbornet commented on issue #271: Consider using gRPC as an externally exposed API

cbornet commented on issue #271: Consider using gRPC as an externally exposed 
API
URL: https://github.com/apache/pulsar/issues/271#issuecomment-559566128
 
 
   I think moving to gRPC for the Pulsar clients would have some benefits. For 
instance it already handles flow control and bi-directional streaming.
   Another interesting alternative could be RSocket which has some very nice 
features such as session resumption and message-level backpressure. In JAVA, it 
would be possible to have a fully reactive-streams API using these protocols. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #2307: Provide a netcore client

sijie commented on issue #2307: Provide a netcore client
URL: https://github.com/apache/pulsar/issues/2307#issuecomment-559564195
 
 
   @rcollina 
   
   Sure.  I hear your concerns. Just to understand it more, if I understand 
correctly, Kafka doesn't provide an _official_ dotnet client in the apache 
repo. The dotnet client was maintained by confluent outside of the ASF. What is 
your thought about this? Is this model okay to you?
   
   The model that Pulsar is using is very similar as Kafka. The Pulsar core 
repo maintains two core implementations, one is Java implementation and the 
other one is c++ implementation (with a c library exposed). So the community 
can develop other language wrappers based on the c/c++ library. In this way, 
Pulsar core team can focus on the core features and ensure it implemented 
correctly and reliably, and encourage more people in the community helping with 
developing different language clients (or wrappers). Although I guess people 
doesn't like implementing wrappers over a c/c++ library, people want *native* 
clients, which ends up with implementing the protocols in different languages 
(go, dotnet, rust and etc). If the requirement is to have a language-native 
client for every different language, it is really hard for Pulsar team to 
maintain and it also limits the scalability of the development. Thus we 
encourage developing language-native clients in the community. 
   
   There are a couple of options we can probably explore on providing 
_official_ clients.
   
   1) implementing a dotnet wrapper over c/c++ library if it is a trivial 
enough to maintain.
   2) setting up a *pulsar-ecosystem* repo and move some of the community 
implementations to be under its umbrella. similar as what 
https://flink.apache.org/ecosystem.html and https://flink-packages.org/
   
   let me know what you think.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #271: Consider using gRPC as an externally exposed API

sijie commented on issue #271: Consider using gRPC as an externally exposed API
URL: https://github.com/apache/pulsar/issues/271#issuecomment-559559488
 
 
   @mickdelaney @TC-oKozlov thank you for your input. 
   
   just to understand a bit more about the requirements, are you expecting a 
gRPC based proxy or pulsar broker protocol exposed in gPRC? This would lead 
into two different approaches.
   
   A gRPC based proxy means providing a much simpler protocol than the current 
broker protocol. So it is easy to have different language gRPC clients. But it 
will has its own limitations and drawbacks, such as another network hop, and 
some of the features might be hard to support and etc.
   
   Exposing pulsar broker protocol in gPRC can solve the problem in handling 
wire-level request & response encoding and decoding. However the challenge of 
implementing a Pulsar client is not about handling wire-level encoding and 
decoding. It is more about the logic within a Pulsar client, such as 
flow-control, topic lookup, error handling and etc. So we will still be facing 
the same challenges that current Pulsar client is facing. It is probably even 
worse than implementing language client wrapper using Pulsar c/c++ client, 
because implementing a language client wrapper is much simpler and less error 
prone than re-implementing flow-control, topic lookup and error handling in 
different languages.
   
   I would like to collect more requirements of gRPC to understand what is the 
right approach for solving the problem here. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai edited a comment on issue #5760: IndexOutOfBoundsException in PerformanceProducer

jiazhai edited a comment on issue #5760: IndexOutOfBoundsException in 
PerformanceProducer
URL: https://github.com/apache/pulsar/issues/5760#issuecomment-559548151
 
 
   hi @codelipenghui I could reproduce this in a short time way. 
   1. start a standalone: `bin/pulsar standalone`
   2. run  pulsar-perf  to produce message: `bin/pulsar-perf  produce  
persistent://public/default/test-topic  --num-producers 1 -r 2000`
   3. kill pulsar standalone, and no touch pulsar-perf(let it still running)
   4. after a while (5-10 minutes) restart standalone, then will find this 
issue in pulsar-perf.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai edited a comment on issue #5760: IndexOutOfBoundsException in PerformanceProducer

jiazhai edited a comment on issue #5760: IndexOutOfBoundsException in 
PerformanceProducer
URL: https://github.com/apache/pulsar/issues/5760#issuecomment-559548151
 
 
   hi @codelipenghui I could reproduce this in a short timee way. 
   1. start a standalone: `bin/pulsar standalone`
   2. run  pulsar-perf  to produce message: `bin/pulsar-perf  produce  
persistent://public/default/test-topic  --num-producers 1 -r 2000`
   3. kill pulsar standalone, and no touch pulsar-perf(let it still running)
   4. after a while (5-10 minutes) restart standalone, then will find this 
issue in pulsar-perf.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on issue #5760: IndexOutOfBoundsException in PerformanceProducer

jiazhai commented on issue #5760: IndexOutOfBoundsException in 
PerformanceProducer
URL: https://github.com/apache/pulsar/issues/5760#issuecomment-559548151
 
 
   hi @codelipenghui I could reproduce this in a short way. 
   1. start a standalone: `bin/pulsar standalone`
   2. run  pulsar-perf  to produce message: `bin/pulsar-perf  produce  
persistent://public/default/test-topic  --num-producers 1 -r 2000`
   3. kill pulsar standalone, and no touch pulsar-perf(let it still running)
   4. after a while (5-10 minutes) restart standalone, then will find this 
issue in pulsar-perf.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on issue #5763: Broker graceful shutdown when znode of loadbalance disappeared

jiazhai commented on issue #5763: Broker graceful shutdown when znode of 
loadbalance disappeared
URL: https://github.com/apache/pulsar/issues/5763#issuecomment-559539489
 
 
   Hi @codelipenghui Thanks for the reporting. Seems the fix is direct,  need 
to "Catch the no node exception and create the disappeared znode" , right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #5765: add Murmur3_32Hash private constructor

codelipenghui commented on issue #5765: add Murmur3_32Hash private constructor
URL: https://github.com/apache/pulsar/pull/5765#issuecomment-559536503
 
 
   run java tests
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #5765: add Murmur3_32Hash private constructor