[GitHub] [pulsar] sijie opened a new pull request #5817: [website] Mitigate "Invalid code tab markdown" issue on translated docs
sijie opened a new pull request #5817: [website] Mitigate "Invalid code tab markdown" issue on translated docs URL: https://github.com/apache/pulsar/pull/5817 *Motivation* Docusaurus code tabs are removed when crowdin generated the translated docs. It causes website failed to build. See details: #5816 *Modifications* Use the original file for the translated files when building the website. Note: this is a work around. it doesn't address the root cause of #5816. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #4976: Pulsar SQL can not query the latest ingested event in a topic , but Pulsar Consumer/Read always can.
sijie commented on issue #4976: Pulsar SQL can not query the latest ingested event in a topic , but Pulsar Consumer/Read always can. URL: https://github.com/apache/pulsar/issues/4976#issuecomment-562921387 @frank-dkvan I think it requires a change at Pulsar side. since we are cutting 2.5.0 next week, I don't think we are able to include this in time. We can do this for 2.5.1 or 2.6.0. you might be able to work around with 4.10 with a bk client configuraiton. @codelipenghui should be able to help you with this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie opened a new issue #5816: website failed to build due to "Invalid code tab markdown"
sijie opened a new issue #5816: website failed to build due to "Invalid code tab markdown" URL: https://github.com/apache/pulsar/issues/5816 **Describe the bug** The website fails to build because there is an "invalid code tab markdown" in `website/translated_docs/zh-CN/version-2.4.2/functions-develop.md` ``` Error: Invalid code tab markdown at forEach (/pulsar/site2/website/node_modules/docusaurus/lib/core/Doc.js:104:15) at Array.forEach () at splitTabsToTitleAndContent (/pulsar/site2/website/node_modules/docusaurus/lib/core/Doc.js:30:9) at replace (/pulsar/site2/website/node_modules/docusaurus/lib/core/Doc.js:190:14) at String.replace () at Doc.renderContent (/pulsar/site2/website/node_modules/docusaurus/lib/core/Doc.js:160:20) at Doc.render (/pulsar/site2/website/node_modules/docusaurus/lib/core/Doc.js:247:32) at processChild (/pulsar/site2/website/node_modules/react-dom/cjs/react-dom-server.node.development.js:3293:18) at resolve (/pulsar/site2/website/node_modules/react-dom/cjs/react-dom-server.node.development.js:3124:5) at ReactDOMServerRenderer.render (/pulsar/site2/website/node_modules/react-dom/cjs/react-dom-server.node.development.js:3598:22) error Command failed with exit code 1. ``` **Additional context** It seems that when crowdin generates the translated markdown file, some code tabs (e.g. ``, ``) are removed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5813: version 2.4.2 doesn't support bookkeeper 4.10.0？pulsar can NOT startup successfully based on BK 4.10.0
sijie commented on issue #5813: version 2.4.2 doesn't support bookkeeper 4.10.0？pulsar can NOT startup successfully based on BK 4.10.0 URL: https://github.com/apache/pulsar/issues/5813#issuecomment-562919839 @frank-dkvan we will start releasing 2.5.0 next week. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] frank-dkvan edited a comment on issue #4976: Pulsar SQL can not query the latest ingested event in a topic , but Pulsar Consumer/Read always can.
frank-dkvan edited a comment on issue #4976: Pulsar SQL can not query the latest ingested event in a topic , but Pulsar Consumer/Read always can. URL: https://github.com/apache/pulsar/issues/4976#issuecomment-562911609 > @frank-dkvan this is a known issue of #3828. because Pulsar doesn't flush LAC so when Presto SQL reads data from bookkeeper bypassing broker, it will miss the latest message because the advanced LAC is not flushed back. > > The fix is waiting for BK 4.10 release. @sijie I tested and found this bug hasn't yet been fixed in latest 2.5.0 snapshot with BK 4.10 release. will this bug get fixed in 2.5.0 official release? or it there any workaround solution/configuration to solve that? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] frank-dkvan edited a comment on issue #4976: Pulsar SQL can not query the latest ingested event in a topic , but Pulsar Consumer/Read always can.
frank-dkvan edited a comment on issue #4976: Pulsar SQL can not query the latest ingested event in a topic , but Pulsar Consumer/Read always can. URL: https://github.com/apache/pulsar/issues/4976#issuecomment-562911609 > @frank-dkvan this is a known issue of #3828. because Pulsar doesn't flush LAC so when Presto SQL reads data from bookkeeper bypassing broker, it will miss the latest message because the advanced LAC is not flushed back. > > The fix is waiting for BK 4.10 release. @sijie I tested and found this bug hasn't solved in latest 2.5.0 snapshot with BK 4.10 release yet. will this bug get solved in 2.5.0 official release? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] frank-dkvan commented on issue #4976: Pulsar SQL can not query the latest ingested event in a topic , but Pulsar Consumer/Read always can.
frank-dkvan commented on issue #4976: Pulsar SQL can not query the latest ingested event in a topic , but Pulsar Consumer/Read always can. URL: https://github.com/apache/pulsar/issues/4976#issuecomment-562911609 > @frank-dkvan this is a known issue of #3828. because Pulsar doesn't flush LAC so when Presto SQL reads data from bookkeeper bypassing broker, it will miss the latest message because the advanced LAC is not flushed back. > > The fix is waiting for BK 4.10 release. I tested and found this bug hasn't solved in latest 2.5.0 snapshot with BK 4.10 release yet. will this bug get solved in 2.5.0 official release? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #2307: Provide a netcore client
sijie commented on issue #2307: Provide a netcore client URL: https://github.com/apache/pulsar/issues/2307#issuecomment-562908859 @rcollina and @JarrodJ83 thank you for your input. I am reopening the issue for tracking this task. I will follow up with this soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] fglaeser opened a new issue #2307: Provide a netcore client
fglaeser opened a new issue #2307: Provide a netcore client URL: https://github.com/apache/pulsar/issues/2307 It will be good to have a pulsar netcore client. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] Jim-Lambert-Bose commented on issue #112: Can't install go module.
Jim-Lambert-Bose commented on issue #112: Can't install go module. URL: https://github.com/apache/pulsar-client-go/issues/112#issuecomment-562907343 Looks like the module is download and "installed" but the go.mod file is not updated to reflect the new version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] Jim-Lambert-Bose opened a new issue #112: Can't install go module.
Jim-Lambert-Bose opened a new issue #112: Can't install go module.
URL: https://github.com/apache/pulsar-client-go/issues/112
Expected behavior
go get github.com/apache/pulsar-client-go@latest
should download and install the latest commit on the master branch
Steps to reproduce
$ go get github.com/apache/pulsar-client-go@latest
go: finding github.com/apache/pulsar-client-go latest
go build github.com/apache/pulsar-client-go: no non-test Go files in
/Users/jimlambrt/go/pkg/mod/github.com/apache/pulsar-client-go@v0.0.0-20191205202832-862285fee18a
I think this is happening because you only have one .go file in the parent
directory https://github.com/apache/pulsar-client-go and it's a test file.
System configuration
$ go version
go version go1.13.4 darwin/amd64
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[pulsar] branch master updated: Add Yu to team list. (#5796)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 90944f1 Add Yu to team list. (#5796)
90944f1 is described below
commit 90944f1b7673bfa9c635ded6f2df15e0c39eb9a6
Author: lipenghui
AuthorDate: Sun Dec 8 10:42:37 2019 +0800
Add Yu to team list. (#5796)
---
site2/website/data/team.js | 6 ++
1 file changed, 6 insertions(+)
diff --git a/site2/website/data/team.js b/site2/website/data/team.js
index 5dfc7d7..9ccb54d 100644
--- a/site2/website/data/team.js
+++ b/site2/website/data/team.js
@@ -161,6 +161,12 @@ module.exports = {
roles: 'Committer'
},
{
+name: 'Yu Liu',
+apacheId: 'liuyu',
+org: 'StreamNative',
+roles: 'Committer'
+},
+{
name: 'Yuki Shiga',
apacheId: 'yushiga',
org: 'Yahoo Japan Corporation',
[GitHub] [pulsar] codelipenghui merged pull request #5796: Add Yu to team list.
codelipenghui merged pull request #5796: Add Yu to team list. URL: https://github.com/apache/pulsar/pull/5796 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5815: [doc] Fix warnings 'Header field "Tutorial" is not supported'
codelipenghui commented on issue #5815: [doc] Fix warnings 'Header field "Tutorial" is not supported' URL: https://github.com/apache/pulsar/pull/5815#issuecomment-562906625 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5803: updated link to Yahoo's open source website
codelipenghui commented on issue #5803: updated link to Yahoo's open source website URL: https://github.com/apache/pulsar/pull/5803#issuecomment-562906493 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] thlautenschlaeger commented on issue #4540: Pulsar Client has no support in Mac 10.14.5 (18F132) ?
thlautenschlaeger commented on issue #4540: Pulsar Client has no support in Mac 10.14.5 (18F132) ? URL: https://github.com/apache/pulsar/issues/4540#issuecomment-562905528 only works with python 3.6 and pulsar 2.0.1 but missing mandatory updates This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] thlautenschlaeger commented on issue #4540: Pulsar Client has no support in Mac 10.14.5 (18F132) ?
thlautenschlaeger commented on issue #4540: Pulsar Client has no support in Mac 10.14.5 (18F132) ? URL: https://github.com/apache/pulsar/issues/4540#issuecomment-562905425 for me it's still not working This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] Jim-Lambert-Bose opened a new issue #111: consumer.Subscription() returns "" since options are never set in internalTopicSubscribe()
Jim-Lambert-Bose opened a new issue #111: consumer.Subscription() returns ""
since options are never set in internalTopicSubscribe()
URL: https://github.com/apache/pulsar-client-go/issues/111
Expected behavior
Subscriber.Subscription() should return the subscription name
Actual behavior
returns ""
Steps to reproduce
create subscriber with pulsar.ConsumerOptions{
SubscriptionName: "anything-at-all"
}
Then try to call sub.Subscription()
It appears you pass the options correctly when creating the
newPartitionConsumer, but you forgot to set them in the consumer you return at:
https://github.com/apache/pulsar-client-go/blob/862285fee18a213289062d855156f44823e5a724/pulsar/consumer_impl.go#L198
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5809: [Issue:5669] Fix the ledgerID not found cause NPE
sijie commented on a change in pull request #5809: [Issue:5669] Fix the
ledgerID not found cause NPE
URL: https://github.com/apache/pulsar/pull/5809#discussion_r355149324
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##
@@ -1790,8 +1790,12 @@ void updateCursor(ManagedCursorImpl cursor,
PositionImpl newPosition) {
}
}
-PositionImpl startReadOperationOnLedger(PositionImpl position) {
-long ledgerId = ledgers.ceilingKey(position.getLedgerId());
+PositionImpl startReadOperationOnLedger(PositionImpl position,
ReadEntriesCallback callback) {
+Long ledgerId = ledgers.ceilingKey(position.getLedgerId());
+if (null == ledgerId) {
+callback.readEntriesFailed(new
ManagedLedgerNotFoundException("read ledger failed, the ledgerID is null"),
null);
Review comment:
1) we should not use ManagedLedgerNotFoundExcception.
ManagedLedgerNotFoundExcception is used when a managed ledger is not found, not
a ledger in the managed ledger is not found
2) the error message should be improved. `The ceilingKey(K key) method is
used to return the least key greater than or equal to the given key, or null if
there is no such key.` that means in this managed ledger there is no ledger
greater than or equal to `position.getLedgerId()`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5803: updated link to Yahoo's open source website
sijie commented on issue #5803: updated link to Yahoo's open source website URL: https://github.com/apache/pulsar/pull/5803#issuecomment-562895086 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5797: PIP-52: [pulsar-sever] Add support of dispatch throttling relative to publish-rate
sijie commented on issue #5797: PIP-52: [pulsar-sever] Add support of dispatch throttling relative to publish-rate URL: https://github.com/apache/pulsar/pull/5797#issuecomment-562895035 @rdhabalia sure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie opened a new pull request #5815: [doc] Fix warnings 'Header field "Tutorial" is not supported'
sijie opened a new pull request #5815: [doc] Fix warnings 'Header field "Tutorial" is not supported' URL: https://github.com/apache/pulsar/pull/5815 *Motivation* Fix warnings 'Header field "Tutorial" is not supported' on building the website This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on a change in pull request #5716: [Issues 5709]remove the namespace checking
codelipenghui commented on a change in pull request #5716: [Issues 5709]remove
the namespace checking
URL: https://github.com/apache/pulsar/pull/5716#discussion_r355127468
##
File path:
pulsar-client/src/test/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImplTest.java
##
@@ -62,4 +71,41 @@ public void testGetStats() throws Exception {
impl.getStats();
}
+@Test
+public void multiTopicsInDifferentNameSpace() throws PulsarClientException
{
+List topics = new ArrayList<>();
+topics.add("persistent://public/default/MultiTopics1");
+topics.add("persistent://public/test-multi/MultiTopics2");
+topics.add("persistent://public/test-multi/MultiTopics3");
+ClientConfigurationData conf = new ClientConfigurationData();
+conf.setServiceUrl("pulsar://localhost:6650");
+
+PulsarClientImpl clientImpl = new PulsarClientImpl(conf);
+
+Consumer consumer =
clientImpl.newConsumer().topic("persistent://public/test-multi/MultiTopics2")
+.subscriptionName("multiTopicSubscription")
+.subscribe();
Review comment:
I think you need to create a consumer which subscribe multi topics in multi
namespaces right? Or can you clarify how the new test cover your change in this
PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on a change in pull request #5716: [Issues 5709]remove the namespace checking
codelipenghui commented on a change in pull request #5716: [Issues 5709]remove
the namespace checking
URL: https://github.com/apache/pulsar/pull/5716#discussion_r355127468
##
File path:
pulsar-client/src/test/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImplTest.java
##
@@ -62,4 +71,41 @@ public void testGetStats() throws Exception {
impl.getStats();
}
+@Test
+public void multiTopicsInDifferentNameSpace() throws PulsarClientException
{
+List topics = new ArrayList<>();
+topics.add("persistent://public/default/MultiTopics1");
+topics.add("persistent://public/test-multi/MultiTopics2");
+topics.add("persistent://public/test-multi/MultiTopics3");
+ClientConfigurationData conf = new ClientConfigurationData();
+conf.setServiceUrl("pulsar://localhost:6650");
+
+PulsarClientImpl clientImpl = new PulsarClientImpl(conf);
+
+Consumer consumer =
clientImpl.newConsumer().topic("persistent://public/test-multi/MultiTopics2")
+.subscriptionName("multiTopicSubscription")
+.subscribe();
Review comment:
I think you need to create a consumer which subscribe multi topics in multi
namespaces right? Or can you clarify how this cover your change in this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on a change in pull request #5716: [Issues 5709]remove the namespace checking
codelipenghui commented on a change in pull request #5716: [Issues 5709]remove
the namespace checking
URL: https://github.com/apache/pulsar/pull/5716#discussion_r355127233
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
##
@@ -180,27 +180,18 @@
// Check topics are valid.
// - each topic is valid,
-// - every topic has same namespace,
// - topic names are unique.
private static boolean topicNamesValid(Collection topics) {
checkState(topics != null && topics.size() >= 1,
"topics should contain more than 1 topic");
-final String namespace =
TopicName.get(topics.stream().findFirst().get()).getNamespace();
-
Optional result = topics.stream()
.filter(topic -> {
boolean topicInvalid = !TopicName.isValid(topic);
if (topicInvalid) {
return true;
}
-
-String newNamespace = TopicName.get(topic).getNamespace();
-if (!namespace.equals(newNamespace)) {
-return true;
-} else {
-return false;
-}
+return false;
Review comment:
Can simplify by
```
topic -> !TopicName.isValid(topic)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5803: updated link to Yahoo's open source website
codelipenghui commented on issue #5803: updated link to Yahoo's open source website URL: https://github.com/apache/pulsar/pull/5803#issuecomment-562859229 run Integration Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5803: updated link to Yahoo's open source website
codelipenghui commented on issue #5803: updated link to Yahoo's open source website URL: https://github.com/apache/pulsar/pull/5803#issuecomment-562859192 run Java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5803: updated link to Yahoo's open source website
codelipenghui commented on issue #5803: updated link to Yahoo's open source website URL: https://github.com/apache/pulsar/pull/5803#issuecomment-562859126 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui removed a comment on issue #5803: updated link to Yahoo's open source website
codelipenghui removed a comment on issue #5803: updated link to Yahoo's open source website URL: https://github.com/apache/pulsar/pull/5803#issuecomment-562859126 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5810: Add pulsar-manager to helm chart
codelipenghui commented on issue #5810: Add pulsar-manager to helm chart URL: https://github.com/apache/pulsar/pull/5810#issuecomment-562858990 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5812: [Issue 5811][pulsar-client-python]Add redelivery count python
codelipenghui commented on issue #5812: [Issue 5811][pulsar-client-python]Add redelivery count python URL: https://github.com/apache/pulsar/pull/5812#issuecomment-562858856 @frejonb Since this PR is work on expose redelivery_count in python client, can we change the PR name to Expose redelivery_count of message in python client? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated: Create load balance znode of broker when znode missed. (#5784)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 3d38ad2 Create load balance znode of broker when znode missed. (#5784)
3d38ad2 is described below
commit 3d38ad270b3e4a24308b8e7938080e6fd4d05f7a
Author: lipenghui
AuthorDate: Sat Dec 7 23:01:52 2019 +0800
Create load balance znode of broker when znode missed. (#5784)
---
.../pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java | 9 +++--
.../pulsar/broker/loadbalance/ModularLoadManagerImplTest.java| 9 +
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
index 89e965e..07fe7dc 100644
---
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
+++
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
@@ -29,7 +29,6 @@ import io.netty.util.concurrent.DefaultThreadFactory;
import java.io.IOException;
import java.util.ArrayList;
-import java.util.HashMap;
import java.util.HashSet;
import java.util.Iterator;
import java.util.List;
@@ -869,7 +868,13 @@ public class ModularLoadManagerImpl implements
ModularLoadManager, ZooKeeperCach
updateLocalBrokerData();
if (needBrokerDataUpdate()) {
localData.setLastUpdate(System.currentTimeMillis());
-zkClient.setData(brokerZnodePath, localData.getJsonBytes(),
-1);
+
+try {
+zkClient.setData(brokerZnodePath,
localData.getJsonBytes(), -1);
+} catch (KeeperException.NoNodeException e) {
+ZkUtils.createFullPathOptimistic(zkClient,
brokerZnodePath, localData.getJsonBytes(),
+ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.EPHEMERAL);
+}
// Clear deltas.
localData.getLastBundleGains().clear();
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/ModularLoadManagerImplTest.java
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/ModularLoadManagerImplTest.java
index 20bba39..6368ea4 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/ModularLoadManagerImplTest.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/ModularLoadManagerImplTest.java
@@ -630,4 +630,13 @@ public class ModularLoadManagerImplTest {
pulsar.close();
}
+
+@Test
+public void testZnodeMissed() throws Exception {
+String path = LoadManager.LOADBALANCE_BROKERS_ROOT + "/" +
pulsar1.getAdvertisedAddress() + ":" +
pulsar1.getConfiguration().getWebServicePort().get();
+ZkUtils.deleteFullPathOptimistic(pulsar1.getZkClient(), path, -1);
+pulsar1.getLoadManager().get().writeLoadReportOnZookeeper();
+// Delete it again to check the znode is create before write load
balance data
+ZkUtils.deleteFullPathOptimistic(pulsar1.getZkClient(), path, -1);
+}
}
[GitHub] [pulsar] codelipenghui closed issue #5763: Broker graceful shutdown when znode of loadbalance disappeared
codelipenghui closed issue #5763: Broker graceful shutdown when znode of loadbalance disappeared URL: https://github.com/apache/pulsar/issues/5763 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated: [pulsar-java-client] Decouple partition switch frequency with maxPublishDelay in producer configuration (#5788)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 6c47ba8 [pulsar-java-client] Decouple partition switch frequency with
maxPublishDelay in producer configuration (#5788)
6c47ba8 is described below
commit 6c47ba8bee66ade007a69ad05c80c8ba967c0306
Author: Yijie Shen
AuthorDate: Sat Dec 7 23:00:47 2019 +0800
[pulsar-java-client] Decouple partition switch frequency with
maxPublishDelay in producer configuration (#5788)
---
.../java/org/apache/pulsar/client/api/ProducerBuilder.java | 14 ++
.../apache/pulsar/client/impl/PartitionedProducerImpl.java | 2 +-
.../org/apache/pulsar/client/impl/ProducerBuilderImpl.java | 6 ++
.../client/impl/RoundRobinPartitionMessageRouterImpl.java | 14 +++---
.../pulsar/client/impl/conf/ProducerConfigurationData.java | 10 ++
site2/docs/client-libraries-java.md| 1 +
6 files changed, 39 insertions(+), 8 deletions(-)
diff --git
a/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilder.java
b/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilder.java
index 970a401..c4a250e 100644
---
a/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilder.java
+++
b/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilder.java
@@ -350,6 +350,20 @@ public interface ProducerBuilder extends Cloneable {
ProducerBuilder batchingMaxPublishDelay(long batchDelay, TimeUnit
timeUnit);
/**
+ * Set the partition switch frequency while batching of messages is
enabled and
+ * using round-robin routing mode for non-keyed message default: 10.
+ *
+ * The time period of partition switch is frequency *
batchingMaxPublishDelay. During this period,
+ * all messages arrives will be route to the same partition.
+ *
+ * @param frequency the frequency of partition switch
+ * @return the producer builder instance
+ * @see #messageRoutingMode(MessageRoutingMode)
+ * @see #batchingMaxPublishDelay(long, TimeUnit)
+ */
+ProducerBuilder roundRobinRouterBatchingPartitionSwitchFrequency(int
frequency);
+
+/**
* Set the maximum number of messages permitted in a batch. default:
1000 If set to a value greater than 1,
* messages will be queued until this threshold is reached or batch
interval has elapsed.
*
diff --git
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedProducerImpl.java
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedProducerImpl.java
index 7803447..dd7b29b 100644
---
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedProducerImpl.java
+++
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedProducerImpl.java
@@ -103,7 +103,7 @@ public class PartitionedProducerImpl extends
ProducerBase {
conf.getHashingScheme(),
ThreadLocalRandom.current().nextInt(topicMetadata.numPartitions()),
conf.isBatchingEnabled(),
-
TimeUnit.MICROSECONDS.toMillis(conf.getBatchingMaxPublishDelayMicros()));
+
TimeUnit.MICROSECONDS.toMillis(conf.batchingPartitionSwitchFrequencyIntervalMicros()));
}
return messageRouter;
diff --git
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBuilderImpl.java
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBuilderImpl.java
index 5d617f9..ef77af6 100644
---
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBuilderImpl.java
+++
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBuilderImpl.java
@@ -209,6 +209,12 @@ public class ProducerBuilderImpl implements
ProducerBuilder {
}
@Override
+public ProducerBuilder
roundRobinRouterBatchingPartitionSwitchFrequency(int frequency) {
+conf.setBatchingPartitionSwitchFrequencyByPublishDelay(frequency);
+return this;
+}
+
+@Override
public ProducerBuilder batchingMaxMessages(int
batchMessagesMaxMessagesPerBatch) {
conf.setBatchingMaxMessages(batchMessagesMaxMessagesPerBatch);
return this;
diff --git
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/RoundRobinPartitionMessageRouterImpl.java
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/RoundRobinPartitionMessageRouterImpl.java
index ee8b9a0..d293ad4 100644
---
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/RoundRobinPartitionMessageRouterImpl.java
+++
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/RoundRobinPartitionMessageRouterImpl.java
@@ -46,7 +46,7 @@ public class RoundRobinPartitionMessageRouterImpl extends
MessageRouterBase {
private final in
[GitHub] [pulsar] codelipenghui merged pull request #5784: Create load balance znode of broker when znode missed.
codelipenghui merged pull request #5784: Create load balance znode of broker when znode missed. URL: https://github.com/apache/pulsar/pull/5784 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client.
codelipenghui commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client. URL: https://github.com/apache/pulsar/pull/5680#issuecomment-562858311 @sijie I have fixed some cpp test issue related to cpp code format, can you help take a look again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui merged pull request #5788: [pulsar-java-client] Decouple partition switch frequency with maxPublishDelay in producer configuration
codelipenghui merged pull request #5788: [pulsar-java-client] Decouple partition switch frequency with maxPublishDelay in producer configuration URL: https://github.com/apache/pulsar/pull/5788 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5796: Add Yu to team list.
codelipenghui commented on issue #5796: Add Yu to team list. URL: https://github.com/apache/pulsar/pull/5796#issuecomment-562858206 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #4955: [PIP-39] Introduce system topic and topic policies service
codelipenghui commented on issue #4955: [PIP-39] Introduce system topic and topic policies service URL: https://github.com/apache/pulsar/pull/4955#issuecomment-562858168 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on a change in pull request #5814: [Issue 5808][documentation]fix example code
codelipenghui commented on a change in pull request #5814: [Issue 5808][documentation]fix example code URL: https://github.com/apache/pulsar/pull/5814#discussion_r355125945 ## File path: site2/docs/schema-understand.md ## @@ -220,7 +220,7 @@ This example shows how to construct a key/value schema and then use it to produc 1. Construct a key/value schema with `INLINE` encoding type. -```text +``` Review comment: If the example is using java, i recommend using ``` java here, keywords can be highlighted This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] frank-dkvan commented on issue #5813: version 2.4.2 doesn't support bookkeeper 4.10.0？pulsar can NOT startup successfully based on BK 4.10.0
frank-dkvan commented on issue #5813: version 2.4.2 doesn't support bookkeeper 4.10.0？pulsar can NOT startup successfully based on BK 4.10.0 URL: https://github.com/apache/pulsar/issues/5813#issuecomment-562853675 > > version 2.4.2 doesn't support bookkeeper 4.10.0？pulsar can NOT startup successfully based on BK 4.10.0 > > @frank-dkvan Yes, version 2.4.2 is just a bug fix for version 2.4.0. To ensure compatibility, we should not support any component version changes in version 2.4.2, including bk. > > In version 2.5.0, it will support bk 4.10.0. by the way, when will the version 2.5.0 get released? :-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] frejonb commented on issue #5812: [Issue 5811][pulsar-client-python]Add redelivery count python
frejonb commented on issue #5812: [Issue 5811][pulsar-client-python]Add redelivery count python URL: https://github.com/apache/pulsar/pull/5812#issuecomment-562852305 @wolfstudy I fixed the test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-translation] Silent-voice closed pull request #13: test
Silent-voice closed pull request #13: test URL: https://github.com/apache/pulsar-translation/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-translation] Silent-voice opened a new pull request #13: test
Silent-voice opened a new pull request #13: test URL: https://github.com/apache/pulsar-translation/pull/13 <-- ### Contribution Checklist - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number. Skip *Issue XYZ* if there is no associated github issue for this pull request. Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** --> *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)* Master Issue: # ### Motivation *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* ### Modifications *Describe the modifications you've done.* ### Verify this change - [ ] Make sure that the change is correct. - For how to check and verify, refer to [Translation and localization](https://github.com/apache/pulsar/tree/master/site2#translation-and-localization). ### Documentation - Is this pull request related to crowdin usage? (yes / no) - Is this pull request related to translation quality? (yes / no) - If yes, how to improve? - Is this pull request related to translation guidelines?(yes / no) - Is this pull request related to translation workflow?(yes / no) - If a sth is not documented yet in this PR, please create a followup issue for adding the documentation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-translation] sijia-w opened a new pull request #12: functions-deploy: sijia-w
sijia-w opened a new pull request #12: functions-deploy: sijia-w URL: https://github.com/apache/pulsar-translation/pull/12 <-- ### Contribution Checklist - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number. Skip *Issue XYZ* if there is no associated github issue for this pull request. Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** --> *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)* Master Issue: # ### Motivation *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* ### Modifications *Describe the modifications you've done.* ### Verify this change - [ ] Make sure that the change is correct. - For how to check and verify, refer to [Translation and localization](https://github.com/apache/pulsar/tree/master/site2#translation-and-localization). ### Documentation - Is this pull request related to crowdin usage? (yes / no) - Is this pull request related to translation quality? (yes / no) - If yes, how to improve? - Is this pull request related to translation guidelines?(yes / no) - Is this pull request related to translation workflow?(yes / no) - If a sth is not documented yet in this PR, please create a followup issue for adding the documentation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5810: Add pulsar-manager to helm chart
wolfstudy commented on issue #5810: Add pulsar-manager to helm chart URL: https://github.com/apache/pulsar/pull/5810#issuecomment-562845549 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5799: Using the latest release version of pulsar-client-go module from pulsar-function-go
wolfstudy commented on issue #5799: Using the latest release version of pulsar-client-go module from pulsar-function-go URL: https://github.com/apache/pulsar/issues/5799#issuecomment-562845419 Thanks @Sunkwan-Kwon, this is a good proposal, when the 2.5.0 is released, we can replace the latest version of `pulsar-client-go` in `pulsar-function-go`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5812: [Issue 5811][pulsar-client-python]Add redelivery count python
wolfstudy commented on issue #5812: [Issue 5811][pulsar-client-python]Add redelivery count python URL: https://github.com/apache/pulsar/pull/5812#issuecomment-562844963 run cpp tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5812: [Issue 5811][pulsar-client-python]Add redelivery count python
wolfstudy commented on issue #5812: [Issue 5811][pulsar-client-python]Add redelivery count python URL: https://github.com/apache/pulsar/pull/5812#issuecomment-562844931 @tuteng PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5813: version 2.4.2 doesn't support bookkeeper 4.10.0？pulsar can NOT startup successfully based on BK 4.10.0
wolfstudy commented on issue #5813: version 2.4.2 doesn't support bookkeeper 4.10.0？pulsar can NOT startup successfully based on BK 4.10.0 URL: https://github.com/apache/pulsar/issues/5813#issuecomment-562844645 > version 2.4.2 doesn't support bookkeeper 4.10.0？pulsar can NOT startup successfully based on BK 4.10.0 @frank-dkvan Yes, version 2.4.2 is just a bug fix for version 2.4.0. To ensure compatibility, we should not support any component version changes in version 2.4.2, including bk. In version 2.5.0, it will support bk 4.10.0. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5814: [Issue 5808][documentation]fix example code
wolfstudy commented on issue #5814: [Issue 5808][documentation]fix example code URL: https://github.com/apache/pulsar/pull/5814#issuecomment-562844396 @Anonymitaet PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated: Fix ArrayIndexOutOfBoundsException in PerformanceProducer. (#5786)
This is an automated email from the ASF dual-hosted git repository.
zhaijia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 54ec194 Fix ArrayIndexOutOfBoundsException in PerformanceProducer.
(#5786)
54ec194 is described below
commit 54ec19423883e6c1ab3db828ab13ef92aba511a5
Author: lipenghui
AuthorDate: Sat Dec 7 17:05:28 2019 +0800
Fix ArrayIndexOutOfBoundsException in PerformanceProducer. (#5786)
Fixes #5760
### Motivation
We use `org.HdrHistogram.Recorder` to record write latency and
`highestTrackableValue` is `TimeUnit.SECONDS.toMicros(12)`, but we record
the value in micros, the error happens when the latency in micros is a very
large number, so this PR change the `highestTrackableValue` of Recorder to
`TimeUnit.SECONDS.toMicros(12)`
---
.../java/org/apache/pulsar/testclient/PerformanceProducer.java | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git
a/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java
b/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java
index 9d7e4b9..0bd40c3 100644
---
a/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java
+++
b/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java
@@ -87,8 +87,8 @@ public class PerformanceProducer {
private static final LongAdder totalMessagesSent = new LongAdder();
private static final LongAdder totalBytesSent = new LongAdder();
-private static Recorder recorder = new
Recorder(TimeUnit.SECONDS.toMillis(12), 5);
-private static Recorder cumulativeRecorder = new
Recorder(TimeUnit.SECONDS.toMillis(12), 5);
+private static Recorder recorder = new
Recorder(TimeUnit.SECONDS.toMicros(12), 5);
+private static Recorder cumulativeRecorder = new
Recorder(TimeUnit.SECONDS.toMicros(12), 5);
static class Arguments {
@@ -521,6 +521,11 @@ public class PerformanceProducer {
cumulativeRecorder.recordValue(latencyMicros);
}
}).exceptionally(ex -> {
+// Ignore the exception of recorder since a very large
latencyMicros will lead
+// ArrayIndexOutOfBoundsException in AbstractHistogram
+if (ex.getCause() instanceof
ArrayIndexOutOfBoundsException) {
+return null;
+}
log.warn("Write error on message", ex);
messagesFailed.increment();
if (arguments.exitOnFailure) {
[GitHub] [pulsar] jiazhai merged pull request #5786: Fix ArrayIndexOutOfBoundsException in PerformanceProducer.
jiazhai merged pull request #5786: Fix ArrayIndexOutOfBoundsException in PerformanceProducer. URL: https://github.com/apache/pulsar/pull/5786 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai closed issue #5760: IndexOutOfBoundsException in PerformanceProducer
jiazhai closed issue #5760: IndexOutOfBoundsException in PerformanceProducer URL: https://github.com/apache/pulsar/issues/5760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
