[GitHub] [pulsar] sijie commented on a change in pull request #5856: Make standalone to advertise "localhost" to avoid failure when hostname is not resolvable
sijie commented on a change in pull request #5856: Make standalone to advertise
"localhost" to avoid failure when hostname is not resolvable
URL: https://github.com/apache/pulsar/pull/5856#discussion_r357897732
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java
##
@@ -67,7 +67,7 @@ public PulsarStandaloneStarter(String[] args) throws
Exception {
zkServers = this.getAdvertisedAddress();
} else if (isBlank(config.getAdvertisedAddress())) {
// Use advertised address as local hostname
-
config.setAdvertisedAddress(ServiceConfigurationUtils.unsafeLocalhostResolve());
+config.setAdvertisedAddress("localhost");
Review comment:
I feel it is better to try to add a method to `ServiceConfigurationUtils` to
resolve localhost first. It is not resolved then fallback to use "localhost".
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie edited a comment on issue #2307: Provide a netcore client
sijie edited a comment on issue #2307: Provide a netcore client URL: https://github.com/apache/pulsar/issues/2307#issuecomment-565682792 @JarrodJ83 thank you for your input. I am following up with the owners of these projects since they are already working on these projects. it would be great to make sure we don't create another project to spread out the community efforts. regarding the comment around Confluent, we (StreamNative) are also happy to provide the support for dotnet client as well. but I really want the community can work together on building pulsar ecosystem before splitting the efforts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #2307: Provide a netcore client
sijie commented on issue #2307: Provide a netcore client URL: https://github.com/apache/pulsar/issues/2307#issuecomment-565682792 @JarrodJ83 thank you for your input. I am following up with the owners of these projects since they are already working on these projects. it would be great to make sure we don't create another project to spread out the community efforts. regarding the comment around Confluent, we (StreamNative) are also happy to provide the support for dotnet client as well. but I will want the community can work together on building pulsar ecosystem before splitting the efforts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5843: Duplicate flags when running bin/pulsar bookie
jiazhai commented on issue #5843: Duplicate flags when running bin/pulsar bookie URL: https://github.com/apache/pulsar/issues/5843#issuecomment-565674706 @cckellogg Thanks for the feedback. Using `PULSAR_MEM` instead of `BOOKIE_MEM` to set bookies, this seems be not a good way. Is it OK to change the k8s charts to use `BOOKIE_MEM` for bookies setting? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai closed issue #5828: Netty UDP connector doesn't work
jiazhai closed issue #5828: Netty UDP connector doesn't work URL: https://github.com/apache/pulsar/issues/5828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai closed issue #5827: Netty UDP connector ClassCastException
jiazhai closed issue #5827: Netty UDP connector ClassCastException URL: https://github.com/apache/pulsar/issues/5827 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated: [Issue 5827][Issue 5828][netty] Fixes for UDP protocol support in netty connector (#5829)
This is an automated email from the ASF dual-hosted git repository.
zhaijia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new b52449a [Issue 5827][Issue 5828][netty] Fixes for UDP protocol
support in netty connector (#5829)
b52449a is described below
commit b52449a6604cbdc4fe70bdfd8ecc9456d6b42ece
Author: gbensa <58692163+gbe...@users.noreply.github.com>
AuthorDate: Sat Dec 14 03:40:39 2019 +0100
[Issue 5827][Issue 5828][netty] Fixes for UDP protocol support in netty
connector (#5829)
### Motivation
UDP protocol is not working for netty connector
### Modifications
Added a specific handler for UDP and use Channel instead of SocketChannel
in NettyChannelInitializer
Successfully tested
* Fixes for UDP protocol support in netty connector
* Added specific handlers for UDP and TCP netty connector
---
.../apache/pulsar/io/netty/server/NettyServer.java | 21 +--
.../NettyTCPChannelInitializer.java} | 14 +-
.../NettyTCPServerHandler.java}| 22
.../package-info.java} | 26 +--
.../NettyUDPChannelInitializer.java} | 14 +-
.../NettyUDPServerHandler.java}| 30 --
.../package-info.java} | 26 +--
...tyChannelInitializer.java => package-info.java} | 25 --
.../NettyTCPChannelInitializerTest.java} | 21 +--
.../NettyUDPChannelInitializerTest.java} | 21 +++
10 files changed, 79 insertions(+), 141 deletions(-)
diff --git
a/pulsar-io/netty/src/main/java/org/apache/pulsar/io/netty/server/NettyServer.java
b/pulsar-io/netty/src/main/java/org/apache/pulsar/io/netty/server/NettyServer.java
index 775b6f4..60c9c2d 100644
---
a/pulsar-io/netty/src/main/java/org/apache/pulsar/io/netty/server/NettyServer.java
+++
b/pulsar-io/netty/src/main/java/org/apache/pulsar/io/netty/server/NettyServer.java
@@ -21,6 +21,17 @@ package org.apache.pulsar.io.netty.server;
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Preconditions.checkNotNull;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.pulsar.io.netty.NettySource;
+import org.apache.pulsar.io.netty.http.NettyHttpChannelInitializer;
+import org.apache.pulsar.io.netty.http.NettyHttpServerHandler;
+import org.apache.pulsar.io.netty.tcp.NettyTCPChannelInitializer;
+import org.apache.pulsar.io.netty.tcp.NettyTCPServerHandler;
+import org.apache.pulsar.io.netty.udp.NettyUDPChannelInitializer;
+import org.apache.pulsar.io.netty.udp.NettyUDPServerHandler;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import io.netty.bootstrap.Bootstrap;
import io.netty.bootstrap.ServerBootstrap;
import io.netty.channel.ChannelFuture;
@@ -30,12 +41,6 @@ import io.netty.channel.EventLoopGroup;
import io.netty.channel.nio.NioEventLoopGroup;
import io.netty.channel.socket.nio.NioDatagramChannel;
import io.netty.channel.socket.nio.NioServerSocketChannel;
-import org.apache.commons.lang3.StringUtils;
-import org.apache.pulsar.io.netty.NettySource;
-import org.apache.pulsar.io.netty.http.NettyHttpChannelInitializer;
-import org.apache.pulsar.io.netty.http.NettyHttpServerHandler;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
/**
* Netty Server to accept incoming data via the configured type.
@@ -96,7 +101,7 @@ public class NettyServer {
Bootstrap bootstrap = new Bootstrap();
bootstrap.group(workerGroup);
bootstrap.channel(NioDatagramChannel.class);
-bootstrap.handler(new NettyChannelInitializer(new
NettyServerHandler(this.nettySource)))
+bootstrap.handler(new NettyUDPChannelInitializer(new
NettyUDPServerHandler(this.nettySource)))
.option(ChannelOption.SO_BACKLOG, 1024);
ChannelFuture channelFuture = bootstrap.bind(this.host,
this.port).sync();
@@ -105,7 +110,7 @@ public class NettyServer {
private void runTcp() throws InterruptedException {
ServerBootstrap serverBootstrap = getServerBootstrap(
-new NettyChannelInitializer(new
NettyServerHandler(this.nettySource)));
+new NettyTCPChannelInitializer(new
NettyTCPServerHandler(this.nettySource)));
ChannelFuture channelFuture = serverBootstrap.bind(this.host,
this.port).sync();
channelFuture.channel().closeFuture().sync();
diff --git
a/pulsar-io/netty/src/main/java/org/apache/pulsar/io/netty/server/NettyChannelInitializer.java
b/pulsar-io/netty/src/main/java/org/apache/pulsar/io/netty/tcp/NettyTCPChannelInitializer.java
similarity index 72%
copy from
pulsar-io/netty/src/main/java/org/apache/pulsar/io/netty/server/NettyChannelInitializer.java
copy
[GitHub] [pulsar] jiazhai merged pull request #5829: [Issue 5827][Issue 5828][netty] Fixes for UDP protocol support in netty connector
jiazhai merged pull request #5829: [Issue 5827][Issue 5828][netty] Fixes for UDP protocol support in netty connector URL: https://github.com/apache/pulsar/pull/5829 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] tuteng commented on a change in pull request #124: [Issue #123] Ensure message is sent if no room in current batch.
tuteng commented on a change in pull request #124: [Issue #123] Ensure message
is sent if no room in current batch.
URL: https://github.com/apache/pulsar-client-go/pull/124#discussion_r357876188
##
File path: pulsar/producer_partition.go
##
@@ -256,10 +256,17 @@ func (p *partitionProducer) internalSend(request
*sendRequest) {
}
if sendAsBatch {
- ok := p.batchBuilder.Add(smm, sequenceID, msg.Payload, request,
msg.ReplicationClusters)
- if ok == false {
+ added := p.batchBuilder.Add(smm, sequenceID, msg.Payload,
request, msg.ReplicationClusters)
+ if !added {
// The current batch is full.. flush it and retry
p.internalFlushCurrentBatch()
+
+ // after flushing try again to add the current payload
+ if ok := p.batchBuilder.Add(smm, sequenceID,
msg.Payload, request, msg.ReplicationClusters); !ok {
+ p.log.WithField("size", len(msg.Payload)).
+ WithField("sequenceID", sequenceID).
+ Error("unable to send message")
+ }
}
} else {
// Send individually
Review comment:
I think there may be the same problem here. If false is returned after the
https://github.com/apache/pulsar-client-go/blob/master/pulsar/internal/batch_builder.go#L107
function is executed.
```
// Add will add single message to batch.
func (bb *BatchBuilder) Add(metadata *pb.SingleMessageMetadata, sequenceID
uint64, payload []byte,
callback interface{}, replicateTo []string) bool {
if replicateTo != nil && bb.numMessages != 0 {
// If the current batch is not empty and we're trying to set
the replication clusters,
// then we need to force the current batch to flush and send
the message individually
return false
} else if bb.msgMetadata.ReplicateTo != nil {
// There's already a message with cluster replication list.
need to flush before next
// message can be sent
return false
} else if bb.hasSpace(payload) {
// The current batch is full. Producer has to call Flush() to
return false
}
if bb.numMessages == 0 {
bb.msgMetadata.SequenceId = proto.Uint64(sequenceID)
bb.msgMetadata.PublishTime =
proto.Uint64(TimestampMillis(time.Now()))
bb.msgMetadata.SequenceId = proto.Uint64(sequenceID)
bb.msgMetadata.ProducerName = &bb.producerName
bb.msgMetadata.ReplicateTo = replicateTo
bb.cmdSend.Send.SequenceId = proto.Uint64(sequenceID)
}
addSingleMessageToBatch(bb.buffer, metadata, payload)
bb.numMessages++
bb.callbacks = append(bb.callbacks, callback)
return true
}
```
This data will not be retried, resulting in incorrect processing.
Therefore, I think retry should be added after internalFlushCurrentBatch under
this condition.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] SakaSun opened a new pull request #5860: [Issue 5857][Helm Chart] - Support to existing Storage Class with StorageClassName
SakaSun opened a new pull request #5860: [Issue 5857][Helm Chart] - Support to existing Storage Class with StorageClassName URL: https://github.com/apache/pulsar/pull/5860 Fixes #5857 ### Motivation With current aproach for specifying storage class in persistent volume claim it's not possible to customize the provisioner parameters. If the property 'storageClass' is declared the chart always create a new storage class with hardcoded parameters. ### Modifications A property 'storageClassName' was added to support an existent storage class. ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: - Anything that affects deployment: yes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] juliohm1978 opened a new pull request #5859: [Issue 5858][helm chart] Provide better defaults for ingress tls and secretName configuration.
juliohm1978 opened a new pull request #5859: [Issue 5858][helm chart] Provide better defaults for ingress tls and secretName configuration. URL: https://github.com/apache/pulsar/pull/5859 Fixes #5858, provides better defaults for the Ingress object and allows TLS to be enabled with an empty secretName. ### Motivation The current helm chart can create an Ingress with TLS, but it requires a secretName to be added. This is not an Ingress requirement and, in some cases, the ingress controller can provide a default certificate when the Ingress object does not declare one. ### Modifications Modifications include `values.yaml` and `dashboard-ingress.yaml` to address the issue. ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: - Anything that affects deployment: yes - Ingress deployment on Kubernetes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] juliohm1978 opened a new issue #5858: Helm chart does not allow ingress TLS to be enabled without a secretName
juliohm1978 opened a new issue #5858: Helm chart does not allow ingress TLS to be enabled without a secretName URL: https://github.com/apache/pulsar/issues/5858 **Describe the bug** The provided helm chart can create an Ingress with TLS, but it requires a `secretName` to be added. This is not an Ingress requirement and, in some cases, the ingress controller can provide a default certificate when the Ingress object does not declare one. **To Reproduce** Deploy the helm chart with an Ingress enabled and an empty tls `secretName`. **Expected behavior** I expect to be able to configure the Ingress TLS without the need to give it a `secretName`. My Ingress controller will use a default certificate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng removed a comment on issue #4996: [k8s] convert to valid pod name part with k8s function runtime
jerrypeng removed a comment on issue #4996: [k8s] convert to valid pod name part with k8s function runtime URL: https://github.com/apache/pulsar/pull/4996#issuecomment-565600900 @sijie @freeznet did you guys consider backwards compatibility for this? Especially for the case when I already have functions running in kubernetes. With this change existing functions will not be able to be deleted since the expected name of the statefulset will be different. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on issue #4996: [k8s] convert to valid pod name part with k8s function runtime
jerrypeng commented on issue #4996: [k8s] convert to valid pod name part with k8s function runtime URL: https://github.com/apache/pulsar/pull/4996#issuecomment-565600900 @sijie @freeznet did you guys consider backwards compatibility for this? Especially for the case when I already have functions running in kubernetes. With this change existing functions will not be able to be deleted since the expected name of the statefulset will be different. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] julio666 commented on issue #5847: Error at starting apachepulsar/pulsar-dashboard docker container within Kubernetes
julio666 commented on issue #5847: Error at starting apachepulsar/pulsar-dashboard docker container within Kubernetes URL: https://github.com/apache/pulsar/issues/5847#issuecomment-565597171 @jiazhai no problem, I'll do it. Thanks for the tip about pulsar-manager. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] JarrodJ83 edited a comment on issue #2307: Provide a netcore client
JarrodJ83 edited a comment on issue #2307: Provide a netcore client URL: https://github.com/apache/pulsar/issues/2307#issuecomment-565587963 @sijie Building on @rcollina 's comment about Confluent, a potential third option may be to reach out to some of the companies that are building platforms around Pulsar (Streamlio?) and see if they would be interested in contributing to one of the existing repos or starting their own. This would give Pulsar an equivalent to Confluent which would greatly increase the confidence that dotnet and Pulsar will be a good pair moving forward, broadening the adoption of Pulsar. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] JarrodJ83 commented on issue #2307: Provide a netcore client
JarrodJ83 commented on issue #2307: Provide a netcore client URL: https://github.com/apache/pulsar/issues/2307#issuecomment-565587963 @sijie Building on @rcollina 's comment about Confluent, a potential third option may be to reach out to some of the companies that are building commercial platforms around Pulsar (Streamlio?) and see if they would be interested in contributing to one of the existing repos or starting their own. This would give Pulsar an equivalent to Confluent which would greatly increase the confidence that dotnet and Pulsar will be a good pair moving forward, broadening the adoption of Pulsar. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] SakaSun opened a new issue #5857: Ability to specify an existing storage class instead of creating one when using Helm deployment
SakaSun opened a new issue #5857: Ability to specify an existing storage class instead of creating one when using Helm deployment URL: https://github.com/apache/pulsar/issues/5857 **Is your feature request related to a problem? Please describe.** Yes. With current aproach for specifying storage class in persistent volume claim it's not possible to customize the provisioner parameters. If the property 'storageClass' is declared the chart always create a new storage class with hardcoded parameters. **Describe the solution you'd like** It would be helpful if the chart template had an attribute 'storageClassName' to specify an existing storage class instead of creating one. Example (values.yaml): ``` bookkeeper: volumes: ledgers: storageClassName: existent-storage-class ``` **Describe alternatives you've considered** Delete and recreate the PVC with wanted storage class or manually create the PV. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version
rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version URL: https://github.com/apache/pulsar/pull/5599#issuecomment-565556744 we are keep facing this issue and need this fix soon. so, @merlimat @sijie can we please review it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #5604: [pulsar-broker] recover zk-badversion while updating cursor metadata
rdhabalia commented on issue #5604: [pulsar-broker] recover zk-badversion while updating cursor metadata URL: https://github.com/apache/pulsar/pull/5604#issuecomment-565556413 @sijie this is real issue which is keep happening for us and wanted to merge it as part of 2.5. can we please review it soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] cckellogg opened a new pull request #124: [Issue #123] Ensure message is sent if no room in current batch.
cckellogg opened a new pull request #124: [Issue #123] Ensure message is sent if no room in current batch. URL: https://github.com/apache/pulsar-client-go/pull/124 Fixes #123 If the current message being published does not fit in the current batch that message is never sent. This patch will add the message to the batch after flushing the current batch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat opened a new pull request #5856: Make standalone to advertise "localhost" to avoid failure when hostname is not resolvable
merlimat opened a new pull request #5856: Make standalone to advertise "localhost" to avoid failure when hostname is not resolvable URL: https://github.com/apache/pulsar/pull/5856 ### Motivation The standalone service is failing to startup when the hostname is not resolvable to an IP. This is common in laptops. The reason is that the function worker in standalone is trying to connect to the advertised address rather than "localhost". To fix this, we should make the standalone to always advertise "localhost" as the the broker address. This is ok because in any case the standalone treats the advertisement as the pulsar proxy, in that it forces the clients to always go through the same service url, so a client connecting from a different host won't have problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat opened a new pull request #5855: Added `zookeeper.snapshot.trust.empty=true` for ZK 3.5 upgrade
merlimat opened a new pull request #5855: Added `zookeeper.snapshot.trust.empty=true` for ZK 3.5 upgrade URL: https://github.com/apache/pulsar/pull/5855 ### Motivation According to https://issues.apache.org/jira/browse/ZOOKEEPER-3056 we need to pass a flag to ZK to make sure we can start it without a snapshot file, as part of the upgrade from zk-3.4.x. From Pulsar 2.6 on, we'll then be able to remove this flag. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] cckellogg commented on issue #5843: Duplicate flags when running bin/pulsar bookie
cckellogg commented on issue #5843: Duplicate flags when running bin/pulsar bookie URL: https://github.com/apache/pulsar/issues/5843#issuecomment-565519395 @jiazhai the main issue I see with #5675 is it's a breaking change. Users who update to a newer version of pulsar will have to change their configurations and that's not a good user experience. Also, all of the kubernetes charts default to using PULSAR_MEM to set resources for the bookies and that will no longer work. I agree with @murong00 only variables from `pulsar_env.sh` should be loaded by `bin/pulsar` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] one70six opened a new issue #5854: Prometheus - Add Metrics Around Message Storage
one70six opened a new issue #5854: Prometheus - Add Metrics Around Message Storage URL: https://github.com/apache/pulsar/issues/5854 Currently you can visualize message backlog via Prometheus/Grafana by observing the **pulsar_msg_backlog** metric. Since Pulsar allows for TTL and Retention to be set on a namespace, it would be very nice if we could somehow visualize if the messages are in TTL phase or in Retention phase. Pulsar does a great job of abstracting storage from the consumer by design, but developers ask all the time how they know if there is still data in the topic or not. - Did we consume it all? - I thought there was a retention? - etc. ### Enhancement Please add the following metrics for better visualizing what phase the messages are in. - Add pulsar_msg_ttl metric - Add pulsar_msg_retention metric Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5742: [pulsar-broker] add support to configure max pending publish request per connection
codelipenghui commented on issue #5742: [pulsar-broker] add support to configure max pending publish request per connection URL: https://github.com/apache/pulsar/pull/5742#issuecomment-565494050 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5793: Fixes some minor thread safety violations
codelipenghui commented on issue #5793: Fixes some minor thread safety violations URL: https://github.com/apache/pulsar/pull/5793#issuecomment-565493683 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5802: Provide raw counters metrics (#5735)
codelipenghui commented on issue #5802: Provide raw counters metrics (#5735) URL: https://github.com/apache/pulsar/pull/5802#issuecomment-565492382 run cpp tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5829: [Issue 5827][Issue 5828][netty] Fixes for UDP protocol support in netty connector
codelipenghui commented on issue #5829: [Issue 5827][Issue 5828][netty] Fixes for UDP protocol support in netty connector URL: https://github.com/apache/pulsar/pull/5829#issuecomment-565491957 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on a change in pull request #5834: To fix the problem of repeated storage of offload driver metadata.
codelipenghui commented on a change in pull request #5834: To fix the problem
of repeated storage of offload driver metadata.
URL: https://github.com/apache/pulsar/pull/5834#discussion_r357703785
##
File path:
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/offload/OffloadUtilsTest.java
##
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.bookkeeper.mledger.offload;
+
+import org.apache.bookkeeper.mledger.proto.MLDataFormats;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+import java.util.HashMap;
+import java.util.Map;
+
+
+public class OffloadUtilsTest {
+
+@Test
+void testOffloadMetadataStore() {
Review comment:
```suggestion
void testOffloadMetadataShouldClearBeforeSet() {
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on a change in pull request #5834: To fix the problem of repeated storage of offload driver metadata.
codelipenghui commented on a change in pull request #5834: To fix the problem
of repeated storage of offload driver metadata.
URL: https://github.com/apache/pulsar/pull/5834#discussion_r357705244
##
File path:
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/offload/OffloadUtilsTest.java
##
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.bookkeeper.mledger.offload;
+
+import org.apache.bookkeeper.mledger.proto.MLDataFormats;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+import java.util.HashMap;
+import java.util.Map;
+
+
+public class OffloadUtilsTest {
+
+@Test
+void testOffloadMetadataStore() {
+MLDataFormats.ManagedLedgerInfo.LedgerInfo.Builder builder =
+MLDataFormats.ManagedLedgerInfo.LedgerInfo.newBuilder();
+builder.setLedgerId(1L);
+
+Map map = new HashMap<>();
+map.put("key1", "value1");
+map.put("key2", "value2");
+
+
+OffloadUtils.setOffloadDriverMetadata(builder, "offload", map);
+
+OffloadUtils.setOffloadDriverMetadata(builder, "offload", map);
Review comment:
nit: It's better to add some java docs, may be thought as duplicate code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5852: [Doc][Issue 5397] Generate a complete list of connectors on the Pulsar Download Page
codelipenghui commented on issue #5852: [Doc][Issue 5397] Generate a complete list of connectors on the Pulsar Download Page URL: https://github.com/apache/pulsar/pull/5852#issuecomment-565482426 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5853: [docs]Refine "The Pulsar Java client" content
codelipenghui commented on issue #5853: [docs]Refine "The Pulsar Java client" content URL: https://github.com/apache/pulsar/pull/5853#issuecomment-565481413 @Anonymitaet Please help review this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5822: Expose bookkeeper expose explicit lac configuration in broker.conf
codelipenghui commented on issue #5822: Expose bookkeeper expose explicit lac configuration in broker.conf URL: https://github.com/apache/pulsar/pull/5822#issuecomment-565480063 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5824: Add a blog post for release 2.4.2
Jennifer88huang commented on issue #5824: Add a blog post for release 2.4.2 URL: https://github.com/apache/pulsar/pull/5824#issuecomment-565480039 @wolfstudy Please check the update, if there is any technical misunderstanding, feel free to update it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5822: Expose bookkeeper expose explicit lac configuration in broker.conf
codelipenghui commented on issue #5822: Expose bookkeeper expose explicit lac configuration in broker.conf URL: https://github.com/apache/pulsar/pull/5822#issuecomment-565479745 @rdhabalia It's related to #3828 #4976, some Pulsar SQL users need to enable the explicitLacInterval, so that they can get the last message in Pulsar SQL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] atlantic2099 opened a new pull request #5853: [docs]Refine "The Pulsar Java client" content
atlantic2099 opened a new pull request #5853: [docs]Refine "The Pulsar Java client" content URL: https://github.com/apache/pulsar/pull/5853 ### Motivation To refine the document. ### Modifications Refine "The Pulsar Java client" content in aspects of grammar, spelling, wording, etc. ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API: (yes / no) - The schema: (yes / no / don't know) - The default values of configurations: (yes / no) - The wire protocol: (yes / no) - The rest endpoints: (yes / no) - The admin cli options: (yes / no) - Anything that affects deployment: (yes / no / don't know) ### Documentation - Does this pull request introduce a new feature? (yes / no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) - If a feature is not applicable for documentation, explain why? - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] atlantic2099 closed pull request #5850: [docs] Refine "The Pulsar Java client" content
atlantic2099 closed pull request #5850: [docs] Refine "The Pulsar Java client" content URL: https://github.com/apache/pulsar/pull/5850 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Javac7 commented on issue #5847: Error at starting apachepulsar/pulsar-dashboard docker container within Kubernetes
Javac7 commented on issue #5847: Error at starting apachepulsar/pulsar-dashboard docker container within Kubernetes URL: https://github.com/apache/pulsar/issues/5847#issuecomment-565431951 I'm looking for a working docker-compose for local standalone pulsar with dashboard, someone already made it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] atlantic2099 removed a comment on issue #5779: [docs] Reorganize "Tiered storage" content
atlantic2099 removed a comment on issue #5779: [docs] Reorganize "Tiered storage" content URL: https://github.com/apache/pulsar/issues/5779#issuecomment-565338792 Reorganized and proofread "Tiered Storage" section per your comments. See details from https://github.com/atlantic2099/pulsar/commit/b7fb118800bf170ee34ddba78244c98db18360cd This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] atlantic2099 closed pull request #5851: [Issue 5779][docs] Reorganize Tiered Storage section
atlantic2099 closed pull request #5851: [Issue 5779][docs] Reorganize Tiered Storage section URL: https://github.com/apache/pulsar/pull/5851 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5852: [Doc][Issue 5397] Generate a complete list of connectors on the Pulsar Download Page
Anonymitaet commented on issue #5852: [Doc][Issue 5397] Generate a complete list of connectors on the Pulsar Download Page URL: https://github.com/apache/pulsar/pull/5852#issuecomment-565388185 @tuteng This is the preview after running `yarn start`. All links and download links are correct.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5397: Pulsar-io connectors not all showing up in releases
Anonymitaet commented on issue #5397: Pulsar-io connectors not all showing up in releases URL: https://github.com/apache/pulsar/issues/5397#issuecomment-565381718 @thps Thanks for your questions. ## #1 >1. Go to http://apache.claz.org/pulsar/pulsar-2.4.1/connectors/ If you want to download connector NAR files, see [here](https://archive.apache.org/dist/pulsar/), this is the **complete and most accurate list** for all Pulsar versions, from 2.1.0 to the latest (currently is 2.4.2). >or https://pulsar.apache.org/en/download/ Thanks for reporting this issue. Yes, the connector list in the `Pulsar IO connectors` section on the Pulsar download page are incomplete. Since the connector list is automatically generated from the `pulsar/site2/website/data/connectors.js` file, I've submitted a [PR](https://github.com/apache/pulsar/pull/5852) to fix this issue. I will keep you updated once it is merged. ## #2 >Not all connectors in releases show up as NAR file artifacts as shown in >Release Notes or release branches. >See https://github.com/apache/pulsar/tree/branch-2.4/pulsar-io >and https://pulsar.apache.org/en/release-notes/ NAR files are stored in other places rather than the following websites and they eat up much space. - https://github.com/apache/pulsar/tree/branch-2.4/pulsar-io: **source code** of connectors are stored here. - https://pulsar.apache.org/en/release-notes/: fixes, enhancements, PIPs and other highlights **about Pulsar release** are shown here. @tuteng Please correct me if I'm wrong. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5852: [Doc][Issue 5397] Generate a complete list of connectors on the Pulsar Download Page
Anonymitaet commented on issue #5852: [Doc][Issue 5397] Generate a complete list of connectors on the Pulsar Download Page URL: https://github.com/apache/pulsar/pull/5852#issuecomment-565378627 @tuteng could you please review? Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet opened a new pull request #5852: [Doc][Issue 5397] Generate a complete list of connectors on the Pulsar Download Page
Anonymitaet opened a new pull request #5852: [Doc][Issue 5397] Generate a complete list of connectors on the Pulsar Download Page URL: https://github.com/apache/pulsar/pull/5852 Fix https://github.com/apache/pulsar/issues/5397 Currently, the `Pulsar IO connectors` are incomplete on the Pulsar Download Page. For example, `flume source`, `flume sink`, `redis sink`, and `solr sink` are not shown.  I've added the missing ones. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] f-ld edited a comment on issue #5459: macOS 10.15 support
f-ld edited a comment on issue #5459: macOS 10.15 support URL: https://github.com/apache/pulsar/issues/5459#issuecomment-565359291 Any doc / repo that would help us build this package locally and unblock devs having up to date OSX laptops ? EDIT: alternative = use docker: ``` docker run -it --name pulsar-client --network=host apachepulsar/pulsar /bin/bash ``` And then push your python code to the docker image and run it from there to connect to your local standalone pulsar instance using "host.docker.internal:6650". Later you can come back to that container using `docker start -a pulsar-client` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] f-ld edited a comment on issue #5459: macOS 10.15 support
f-ld edited a comment on issue #5459: macOS 10.15 support URL: https://github.com/apache/pulsar/issues/5459#issuecomment-565359291 Any doc / repo that would help us build this package locally and unblock devs having up to date OSX laptops ? EDIT: alternative = use docker: ``` docker run -it --name pulsar-client --network=host apachepulsar/pulsar /bin/bash ``` And then push your python code to the docker image and run it from there to connect to your local standalone pulsar instance using "localhost:6650". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5582: pulsar dashboard collector encountered error message
tuteng commented on issue #5582: pulsar dashboard collector encountered error message URL: https://github.com/apache/pulsar/issues/5582#issuecomment-565374543 I'm very sorry for the late reply. I didn't have your problem tested locally. Can you show me some steps of your deployment or read some more detailed log information? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5459: macOS 10.15 support
aahmed-se commented on issue #5459: macOS 10.15 support URL: https://github.com/apache/pulsar/issues/5459#issuecomment-565369700 have a look here https://github.com/apache/pulsar/blob/master/pulsar-client-cpp/python/pkg/osx/vagrant-build.sh This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on a change in pull request #5767: Support batch authorization of partitioned topic
jiazhai commented on a change in pull request #5767: Support batch
authorization of partitioned topic
URL: https://github.com/apache/pulsar/pull/5767#discussion_r357552464
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
##
@@ -312,4 +316,82 @@ public void testGetPartitionedTopicsList() throws
KeeperException, InterruptedEx
Assert.assertEquals(nonPersistentPartitionedTopics.size(), 1);
Assert.assertEquals(TopicName.get(nonPersistentPartitionedTopics.get(0)).getDomain().value(),
TopicDomain.non_persistent.value());
}
+
+@Test
+public void testGrantNonPartitionedTopic() {
+final String topicName = "non-partitioned-topic";
+persistentTopics.createNonPartitionedTopic(testTenant, testNamespace,
topicName, true);
+String role = "role";
+Set expectActions = new HashSet<>();
+expectActions.add(AuthAction.produce);
+persistentTopics.grantPermissionsOnTopic(testTenant, testNamespace,
topicName, role, expectActions);
+Map> permissions =
persistentTopics.getPermissionsOnTopic(testTenant, testNamespace, topicName);
+Assert.assertEquals(permissions.get(role), expectActions);
+}
+
+@Test
+public void testGrantPartitionedTopic() {
+final String partitionedTopicName = "partitioned-topic";
+final int numPartitions = 5;
+LocalZooKeeperCacheService mockLocalZooKeeperCacheService =
mock(LocalZooKeeperCacheService.class);
+ZooKeeperChildrenCache mockZooKeeperChildrenCache =
mock(ZooKeeperChildrenCache.class);
+
doReturn(mockLocalZooKeeperCacheService).when(pulsar).getLocalZkCacheService();
+
doReturn(mockZooKeeperChildrenCache).when(mockLocalZooKeeperCacheService).managedLedgerListCache();
Review comment:
Great. I am free to have a new api. we could following other apis, such as
stats/list .
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5767: Support batch authorization of partitioned topic
tuteng commented on issue #5767: Support batch authorization of partitioned topic URL: https://github.com/apache/pulsar/pull/5767#issuecomment-565364665 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] kuido85 commented on issue #5242: Consumer fails to retrieve messages when using multi-host connection with Avro schema and one broker is down in cluster.
kuido85 commented on issue #5242: Consumer fails to retrieve messages when using multi-host connection with Avro schema and one broker is down in cluster. URL: https://github.com/apache/pulsar/issues/5242#issuecomment-565361109 It suddenly started to working and I never had this issue anymore. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] f-ld commented on issue #5459: macOS 10.15 support
f-ld commented on issue #5459: macOS 10.15 support URL: https://github.com/apache/pulsar/issues/5459#issuecomment-565359291 Any doc / repo that would help us build this package locally and unblock devs having up to date OSX laptops ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] atagunduzalp commented on issue #5242: Consumer fails to retrieve messages when using multi-host connection with Avro schema and one broker is down in cluster.
atagunduzalp commented on issue #5242: Consumer fails to retrieve messages when using multi-host connection with Avro schema and one broker is down in cluster. URL: https://github.com/apache/pulsar/issues/5242#issuecomment-565349074 How did you solve it ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5851: The reorganization and proofreading of "Tiered Storage" has been finished.
Jennifer88huang commented on issue #5851: The reorganization and proofreading of "Tiered Storage" has been finished. URL: https://github.com/apache/pulsar/pull/5851#issuecomment-565344968 Please remove client-libraries-java.md file from this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5850: The proofreading of "The Pulsar Java client" has been finished.
Jennifer88huang commented on issue #5850: The proofreading of "The Pulsar Java client" has been finished. URL: https://github.com/apache/pulsar/pull/5850#issuecomment-565344825 Please remove the two files related to tiered storage from this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang edited a comment on issue #5851: The reorganization and proofreading of "Tiered Storage" has been finished.
Jennifer88huang edited a comment on issue #5851: The reorganization and proofreading of "Tiered Storage" has been finished. URL: https://github.com/apache/pulsar/pull/5851#issuecomment-565343749 @atlantic2099 Could you pull 2 requests for the changes? One for proofreading in Java client library(#5850), one for Tiered Storage(#5851). Besides, there are some conflicts. Have you fetched the latest docs for refinement? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang edited a comment on issue #5851: The reorganization and proofreading of "Tiered Storage" has been finished.
Jennifer88huang edited a comment on issue #5851: The reorganization and proofreading of "Tiered Storage" has been finished. URL: https://github.com/apache/pulsar/pull/5851#issuecomment-565343749 @atlantic2099 Could you pull 2 requests for the changes? One for proofreading in Java client library, one for Tiered Storage. Besides, there are some conflicts. Have you fetched the latest docs for refinement? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5851: The reorganization and proofreading of "Tiered Storage" has been finished.
Jennifer88huang commented on issue #5851: The reorganization and proofreading of "Tiered Storage" has been finished. URL: https://github.com/apache/pulsar/pull/5851#issuecomment-565343749 @atlantic2099 Could you pull 2 requests for the changes? One for proofreading in Java client library. One for Tiered Storage. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
