[GitHub] [pulsar] jiazhai commented on issue #6012: [Github Actions]Remove dependence on personal project
jiazhai commented on issue #6012: [Github Actions]Remove dependence on personal project URL: https://github.com/apache/pulsar/issues/6012#issuecomment-571928847 @aahmed-se will you fix this issue? or @tuteng could work on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6006: Fix unit test issue in BrokerServiceTest.java
codelipenghui commented on issue #6006: Fix unit test issue in BrokerServiceTest.java URL: https://github.com/apache/pulsar/pull/6006#issuecomment-571926715 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6003: Possibility to add builtin Pulsar Functions with a shared jar copied inside the function folder
jiazhai commented on issue #6003: Possibility to add builtin Pulsar Functions with a shared jar copied inside the function folder URL: https://github.com/apache/pulsar/issues/6003#issuecomment-571924108 thanks @nicolo-paganin ,right, this is part of the work in pip-50, which tries to manage the nars in a better way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6002: 2.4.2 pulsar dashboard cannot view a message
jiazhai commented on issue #6002: 2.4.2 pulsar dashboard cannot view a message URL: https://github.com/apache/pulsar/issues/6002#issuecomment-571922922 @youurayy Will this appear each time? Would you please help provide a detailed steps to reproduce? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai edited a comment on issue #6001: Push Subscriptions through REST
jiazhai edited a comment on issue #6001: Push Subscriptions through REST URL: https://github.com/apache/pulsar/issues/6001#issuecomment-571919103 Thanks @DanielFerreiraJorge for rising up this issue. it is a useful feature. It would be convenient to provide a REST endpoint to produce/consume message. Currently, could the websocket API solve part of your issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6001: Push Subscriptions through REST
jiazhai commented on issue #6001: Push Subscriptions through REST URL: https://github.com/apache/pulsar/issues/6001#issuecomment-571919103 Thanks @DanielFerreiraJorge for rising up this issue. it is a useful feature. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6000: Sending Individual ACK for multiple messages in one command.
jiazhai commented on issue #6000: Sending Individual ACK for multiple messages in one command. URL: https://github.com/apache/pulsar/issues/6000#issuecomment-571917827 Thanks @tongsucn for rising up this issue. Cpp client need to catchup with the feature of group-ack. Would you like to contribute to this feature? > Does acknowledge interface in C++ client really send ACK synchronously? Regarding this issue, right, currently java and cpp clients have the same behavior, acks are in a try-best way. this will be handled after transaction feature added in. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #6006: Fix unit test issue in BrokerServiceTest.java
sijie commented on issue #6006: Fix unit test issue in BrokerServiceTest.java URL: https://github.com/apache/pulsar/pull/6006#issuecomment-571902169 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] kaynewu commented on issue #5986: [4510] A host can't connect and won't try other hosts again in multi-hosts service url configuration
kaynewu commented on issue #5986: [4510] A host can't connect and won't try other hosts again in multi-hosts service url configuration URL: https://github.com/apache/pulsar/pull/5986#issuecomment-571900090 > @kaynewu Thanks for fix this issue. would you please help add a tests for this case? There is a integration tests `AdminMultiHostTest` could be referenced. @jiazhai A tests has been add in 'PulsarServiceNameResolverTest' , please have check! thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] kaynewu removed a comment on issue #5986: [4510] A host can't connect and won't try other hosts again in multi-hosts service url configuration
kaynewu removed a comment on issue #5986: [4510] A host can't connect and won't try other hosts again in multi-hosts service url configuration URL: https://github.com/apache/pulsar/pull/5986#issuecomment-571899984 > @kaynewu Thanks for fix this issue. would you please help add a tests for this case? There is a integration tests `AdminMultiHostTest` could be referenced. A tests has been add in 'PulsarServiceNameResolverTest' , please have check! thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] kaynewu commented on issue #5986: [4510] A host can't connect and won't try other hosts again in multi-hosts service url configuration
kaynewu commented on issue #5986: [4510] A host can't connect and won't try other hosts again in multi-hosts service url configuration URL: https://github.com/apache/pulsar/pull/5986#issuecomment-571899984 > @kaynewu Thanks for fix this issue. would you please help add a tests for this case? There is a integration tests `AdminMultiHostTest` could be referenced. A tests has been add in 'PulsarServiceNameResolverTest' , please have check! thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #167: res channel causes connection.Run() to block When request timeout occuers
wolfstudy commented on a change in pull request #167: res channel causes connection.Run() to block When request timeout occuers URL: https://github.com/apache/pulsar-client-go/pull/167#discussion_r364070356 ## File path: pulsar/internal/rpc_client.go ## @@ -90,7 +90,7 @@ func (c *rpcClient) Request(logicalAddr *url.URL, physicalAddr *url.URL, request *RPCResult error } - ch := make(chan Res) + ch := make(chan Res, 1) Review comment: ```suggestion ch := make(chan Res, 10) ``` Normally we use 10 as the buffer size. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #6004: [Github actions]Fixed unit test
tuteng commented on issue #6004: [Github actions]Fixed unit test URL: https://github.com/apache/pulsar/pull/6004#issuecomment-571889340 There are too many unit tests for Github's actions to pass, and the tests and tests will affect each other. This pull request has already solved some of the problems. I think we can merge this pr and let GitHub actions run first, then we can solve all the problems step by step later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on a change in pull request #6004: [Github actions]Fixed unit test
tuteng commented on a change in pull request #6004: [Github actions]Fixed unit test URL: https://github.com/apache/pulsar/pull/6004#discussion_r364061750 ## File path: .github/workflows/ci-unit-adaptors.yml ## @@ -0,0 +1,56 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: CI - Unit - Adaptors +on: + pull_request: +branches: + - master +paths-ignore: + - '**.md' + +jobs: + + unit-tests: +name: +runs-on: ubuntu-latest +timeout-minutes: 120 + +steps: + - name: Set up JDK 1.8 +uses: actions/setup-java@v1 +with: + java-version: 1.8 + + - name: checkout +uses: actions/checkout@v1 + + - name: Set up Maven +uses: aahmed-se/setup-maven@v3 Review comment: @rdhabalia I have created an issue https://github.com/apache/pulsar/issues/6012 for track remove this. PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on a change in pull request #6004: [Github actions]Fixed unit test
tuteng commented on a change in pull request #6004: [Github actions]Fixed unit test URL: https://github.com/apache/pulsar/pull/6004#discussion_r364061448 ## File path: .github/workflows/ci-unit.yaml ## @@ -46,17 +46,34 @@ jobs: with: maven-version: 3.6.1 + - name: run unit tests install by skip tests +run: mvn clean install -DskipTests + + - name: run unit tests pulsar proxy +run: mvn install -DfailIfNoTests=false '-Dtest=!ProxyTest,!ProxyLookupThrottlingTest' -pl pulsar-proxy Review comment: @aahmed-se PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng opened a new issue #6012: [Github Actions]Remove dependence on personal project
tuteng opened a new issue #6012: [Github Actions]Remove dependence on personal project URL: https://github.com/apache/pulsar/issues/6012 **Is your feature request related to a problem? Please describe.** The current Github action test run depends on a personal maven project. We need to remove it https://github.com/apache/pulsar/blob/master/.github/workflows/ci-unit.yaml#L45. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] dsmlily opened a new pull request #167: res channel causes connection.Run() to block When request timeout occuers
dsmlily opened a new pull request #167: res channel causes connection.Run() to block When request timeout occuers URL: https://github.com/apache/pulsar-client-go/pull/167 Change the RPCResultChannel to a buffer channel to avoid blocking connection.Run() when request timeout occuers https://github.com/apache/pulsar-client-go/issues/144 https://github.com/apache/pulsar-client-go/issues/151 Signed-off-by: dsmlily This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] duli559 commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer
duli559 commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-571878744 > > why this ci build is failed? I feel a little strange, some other pull requests have the same problem, > > @duli559 the current Jenkins is a bit flaky. We are working on migrating to Github Actions. @sijie , it's great, and i have changed my commited code with your earlier review advice. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6006: Fix unit test issue in BrokerServiceTest.java
codelipenghui commented on issue #6006: Fix unit test issue in BrokerServiceTest.java URL: https://github.com/apache/pulsar/pull/6006#issuecomment-571875503 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #5866: Flink event time based windowing functions not working with pulsar
yjshen commented on issue #5866: Flink event time based windowing functions not working with pulsar URL: https://github.com/apache/pulsar/issues/5866#issuecomment-571873949 Hi @subbu107, I've created a repo for you to enable IDE-based flink program debugging, using JUnit, you could find it here https://github.com/yjshen/flink-pulsar-playground. Please make your program as a test case and check what happens by debugging it. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] BGRichi opened a new pull request #6011: [Issue 5775][Doc] Description of broker-tool added
BGRichi opened a new pull request #6011: [Issue 5775][Doc] Description of broker-tool added URL: https://github.com/apache/pulsar/pull/6011 Fixes https://github.com/apache/pulsar/issues/5775 ### Motivation Add the description for broker-tool accordingly. Refer to: https://github.com/apache/pulsar/pull/5768 ### Modifications broker-tool section added. ### Verifying this change This change needs to be reviewed. ### Does this pull request potentially affect one of the following parts: Dependencies (does it add or upgrade a dependency): (no) The public API: (no) The schema: (no) The default values of configurations: (no) The wire protocol: (no) The rest endpoints: (no) The admin cli options: (no) Anything that affects deployment: (no) ### Documentation Does this pull request introduce a new feature? (yes) If yes, how is the feature documented? ( docs ) If a feature is not applicable for documentation, explain why? If a feature is not documented yet in this PR, please create a followup issue for adding the documentation This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6006: Fix unit test issue in BrokerServiceTest.java
codelipenghui commented on issue #6006: Fix unit test issue in BrokerServiceTest.java URL: https://github.com/apache/pulsar/pull/6006#issuecomment-571863407 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy merged pull request #166: Fix: producer code example
wolfstudy merged pull request #166: Fix: producer code example URL: https://github.com/apache/pulsar-client-go/pull/166 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar-client-go] branch master updated: Fix: producer code example (#166)
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 5603a6a Fix: producer code example (#166)
5603a6a is described below
commit 5603a6a836278f6e9d9545d68feaceb9bc0fddec
Author: Mickaël FORTUNATO
AuthorDate: Wed Jan 8 03:12:00 2020 +0100
Fix: producer code example (#166)
Fixing a typo in a readme.md following changes done in #141
---
README.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/README.md b/README.md
index f7a2953..acc96f1 100644
--- a/README.md
+++ b/README.md
@@ -64,7 +64,7 @@ producer, err := client.CreateProducer(pulsar.ProducerOptions{
Topic: "my-topic",
})
-err = producer.Send(context.Background(), {
+_, err = producer.Send(context.Background(), {
Payload: []byte("hello"),
})
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #5995: [docs] improve statement on ordering guarantees for multi-topic subscriptions
Jennifer88huang commented on a change in pull request #5995: [docs] improve statement on ordering guarantees for multi-topic subscriptions URL: https://github.com/apache/pulsar/pull/5995#discussion_r364034817 ## File path: site2/docs/concepts-messaging.md ## @@ -226,8 +226,8 @@ When a consumer subscribes to a Pulsar topic, by default it subscribes to one sp When subscribing to multiple topics, the Pulsar client will automatically make a call to the Pulsar API to discover the topics that match the regex pattern/list and then subscribe to all of them. If any of the topics don't currently exist, the consumer will auto-subscribe to them once the topics are created. -> No ordering guarantees -> When a consumer subscribes to multiple topics, all ordering guarantees normally provided by Pulsar on single topics do not hold. If your use case for Pulsar involves any strict ordering requirements, we would strongly recommend against using this feature. +> No cross-topic ordering guarantees +> Ordering guarantees given for single topics do not hold across multiple topics. So users need to make sure that all messages that need to be delivered in order are on the same topic. Review comment: If you think it's more clear to use "cross-topic ordering" or "ordering across topics", it's OK to use that. I prefer "ordering across topics". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] Morsicus opened a new pull request #166: Fix: producer code example
Morsicus opened a new pull request #166: Fix: producer code example URL: https://github.com/apache/pulsar-client-go/pull/166 Fixing a typo in a readme.md following changes done in https://github.com/apache/pulsar-client-go/pull/141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #5742: [pulsar-broker] add support to configure max pending publish request per connection
rdhabalia commented on issue #5742: [pulsar-broker] add support to configure max pending publish request per connection URL: https://github.com/apache/pulsar/pull/5742#issuecomment-571781039 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on a change in pull request #6004: [Github actions]Fixed unit test
rdhabalia commented on a change in pull request #6004: [Github actions]Fixed unit test URL: https://github.com/apache/pulsar/pull/6004#discussion_r363958787 ## File path: .github/workflows/ci-unit-adaptors.yml ## @@ -0,0 +1,56 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: CI - Unit - Adaptors +on: + pull_request: +branches: + - master +paths-ignore: + - '**.md' + +jobs: + + unit-tests: +name: +runs-on: ubuntu-latest +timeout-minutes: 120 + +steps: + - name: Set up JDK 1.8 +uses: actions/setup-java@v1 +with: + java-version: 1.8 + + - name: checkout +uses: actions/checkout@v1 + + - name: Set up Maven +uses: aahmed-se/setup-maven@v3 Review comment: we should avoid individual name mention here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] EugenDueck commented on a change in pull request #5995: [docs] improve statement on ordering guarantees for multi-topic subscriptions
EugenDueck commented on a change in pull request #5995: [docs] improve statement on ordering guarantees for multi-topic subscriptions URL: https://github.com/apache/pulsar/pull/5995#discussion_r363932512 ## File path: site2/docs/concepts-messaging.md ## @@ -226,8 +226,8 @@ When a consumer subscribes to a Pulsar topic, by default it subscribes to one sp When subscribing to multiple topics, the Pulsar client will automatically make a call to the Pulsar API to discover the topics that match the regex pattern/list and then subscribe to all of them. If any of the topics don't currently exist, the consumer will auto-subscribe to them once the topics are created. -> No ordering guarantees -> When a consumer subscribes to multiple topics, all ordering guarantees normally provided by Pulsar on single topics do not hold. If your use case for Pulsar involves any strict ordering requirements, we would strongly recommend against using this feature. +> No cross-topic ordering guarantees +> Ordering guarantees given for single topics do not hold across multiple topics. So users need to make sure that all messages that need to be delivered in order are on the same topic. Review comment: Imo something like "cross-topic ordering" or "ordering across topics" makes it more clear than "multiple topics" that in-topic ordering is not affected by this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #6010: Broker can not reload expired bookie certs and fails to connect to bookie
rdhabalia commented on issue #6010: Broker can not reload expired bookie certs and fails to connect to bookie URL: https://github.com/apache/pulsar/issues/6010#issuecomment-571752805 This should be fixed by : https://github.com/apache/bookkeeper/pull/2235 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia opened a new issue #6010: Broker can not reload expired bookie certs and fails to connect to bookie
rdhabalia opened a new issue #6010: Broker can not reload expired bookie certs and fails to connect to bookie URL: https://github.com/apache/pulsar/issues/6010 ### Issue Bookkeeper-client caches the tls certificates when it first tries to create a cnx with a given bookie and after that it never reloads certs even when valid certs changes on the file-system or new bookie-connection is created. Because of that as soon as client certs expires and broker disconnects from bookie then broker is not able to reconnect to bookie until we restart the broker process. and we see below TLS exception at broker. ``` 19:43:03.983 [bookkeeper-io-12-45] ERROR org.apache.bookkeeper.proto.PerChannelBookieClient - Unexpected exception caught by bookie client channel handler io.netty.handler.codec.DecoderException: javax.net.ssl.SSLHandshakeException: General OpenSslEngine problem at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:472) ~[netty-codec-4.1.31.Final.jar:4.1.31.Final] at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:278) ~[netty-codec-4.1.31.Final.jar:4.1.31.Final] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) [netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) [netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) [netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1434) [netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) [netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) [netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:965) [netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:799) [netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:433) [netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:330) [netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:909) [netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [netty-all-4.1.32.Final.jar:4.1.32.Final] at java.lang.Thread.run(Thread.java:834) [?:?] Caused by: javax.net.ssl.SSLHandshakeException: General OpenSslEngine problem at io.netty.handler.ssl.ReferenceCountedOpenSslClientContext$OpenSslClientCertificateCallback.handle(ReferenceCountedOpenSslClientContext.java:273) ~[netty-all-4.1.32.Final.jar :4.1.32.Final] at io.netty.internal.tcnative.SSL.readFromSSL(Native Method) ~[netty-tcnative-boringssl-static-2.0.20.Final.jar:2.0.20.Final] at io.netty.handler.ssl.ReferenceCountedOpenSslEngine.readPlaintextData(ReferenceCountedOpenSslEngine.java:575) ~[netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.handler.ssl.ReferenceCountedOpenSslEngine.unwrap(ReferenceCountedOpenSslEngine.java:1124) ~[netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.handler.ssl.ReferenceCountedOpenSslEngine.unwrap(ReferenceCountedOpenSslEngine.java:1236) ~[netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.handler.ssl.ReferenceCountedOpenSslEngine.unwrap(ReferenceCountedOpenSslEngine.java:1279) ~[netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.handler.ssl.SslHandler$SslEngineType$1.unwrap(SslHandler.java:217) ~[netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.handler.ssl.SslHandler.unwrap(SslHandler.java:1301) ~[netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.handler.ssl.SslHandler.decodeNonJdkCompatible(SslHandler.java:1215) ~[netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.handler.ssl.SslHandler.decode(SslHandler.java:1249) ~[netty-all-4.1.32.Final.jar:4.1.32.Final] at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:502) ~[netty-codec-4.1.31.Final.jar:4.1.31.Final] at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:441) ~[netty-codec-4.1.31.Final.jar:4.1.31.Final]
[GitHub] [pulsar] Antti-Kaikkonen commented on issue #5370: sql worker on Ubuntu 18: libprocname.so failing, and failing JVM vendor check
Antti-Kaikkonen commented on issue #5370: sql worker on Ubuntu 18: libprocname.so failing, and failing JVM vendor check URL: https://github.com/apache/pulsar/issues/5370#issuecomment-571721800 I got it working with OpenJDK 8 by running `./bin/pulsar sql-worker run -D "java.vendor"="Oracle Corporation"` Also tested same with OpenJDK 11 but it failed with unrelated nullpointer exception. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] ckdarby commented on issue #5867: [issue 5847][dashboard] postgresql correct version (9.6 to 11)
ckdarby commented on issue #5867: [issue 5847][dashboard] postgresql correct version (9.6 to 11) URL: https://github.com/apache/pulsar/pull/5867#issuecomment-571712036 @julio666 probably worth being aware of this, as it is indirectly related to #5689 The solution that was taken here was pinning the version of the docker image for Postgresql version 9.6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] dunglas opened a new pull request #6009: [helm] Fix typos and sync values-mini with values
dunglas opened a new pull request #6009: [helm] Fix typos and sync values-mini with values URL: https://github.com/apache/pulsar/pull/6009 ### Motivation Fix typos and sync values-mini with values ### Modifications Comments only. ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): no - The public API: no - The schema: no - The default values of configurations: no - The wire protocol: no - The rest endpoints: no - The admin cli options: no - Anything that affects deployment: no ### Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable - If a feature is not applicable for documentation, explain why? trivial - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] digi691 edited a comment on issue #5417: Broker hangs and crashes when listing non-persistent topics
digi691 edited a comment on issue #5417: Broker hangs and crashes when listing
non-persistent topics
URL: https://github.com/apache/pulsar/issues/5417#issuecomment-571677117
@tuteng I was able to upgrade our dev/test Pulsar cluster to version 2.4.2.
Now hitting the /admin/v2/non-persistent/{tenant}/{namespace} API endpoint
causes a HTTP ERROR 504 when connecting through the proxy whether the namspace
has non-persistent topics or not. When connecting directly to the broker at
/admin/v2/non-persistent/{tenant}/{namespace} it seems to infinitely wait. The
crashing of the broker API seems to be resolved, but still cannot hit this
endpoint on a Pulsar cluster. When Pulsar is running in standalone mode, this
produces an empty list.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jeffgrunewald edited a comment on issue #5997: websocket meet 404 when create producer in standalone mode
jeffgrunewald edited a comment on issue #5997: websocket meet 404 when create producer in standalone mode URL: https://github.com/apache/pulsar/issues/5997#issuecomment-571680005 > @jeffgrunewald have you use `telnet` to check that the port is OK? The current commit is failing to build but I checked out a commit 10 back from HEAD (roughly where it was at tip when I last attempted from source over the weekend, f141efa669) and I am still getting the inability to connect via the client, but I _am_ able to successfully telnet to the local host on both ports 6650 and 8080. When I attempt to connect with my client I see the following two messages in the logs one immediately after the other: ``` 12:04:30.530 [pulsar-web-57-14] WARN org.apache.pulsar.websocket.ProducerHandler - [127.0.0.1:62817] Failed in creating producer on topic persistent://public/default/integration1: Param serviceUrl must not be blank. 12:04:30.531 [pulsar-web-57-14] INFO org.eclipse.jetty.server.RequestLog - 127.0.0.1 - - [07/Jan/2020:12:04:30 -0500] "GET /ws/v2/producer/persistent/public/default/integration1 HTTP/1.1" 400 466 "-" "-" 2 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jeffgrunewald commented on issue #5997: websocket meet 404 when create producer in standalone mode
jeffgrunewald commented on issue #5997: websocket meet 404 when create producer in standalone mode URL: https://github.com/apache/pulsar/issues/5997#issuecomment-571680005 > @jeffgrunewald have you use `telnet` to check that the port is OK? The current commit is failing to build but I checked out a commit 10 back from HEAD (roughly where it was at tip when I last attempted from source over the weekend) and I am still getting the inability to connect, but I am able to successfully telnet to the local host on both ports 6650 and 8080. When I attempt to connect with my client I see the following two messages in the logs one immediately after the other: ``` 12:04:30.530 [pulsar-web-57-14] WARN org.apache.pulsar.websocket.ProducerHandler - [127.0.0.1:62817] Failed in creating producer on topic persistent://public/default/integration1: Param serviceUrl must not be blank. 12:04:30.531 [pulsar-web-57-14] INFO org.eclipse.jetty.server.RequestLog - 127.0.0.1 - - [07/Jan/2020:12:04:30 -0500] "GET /ws/v2/producer/persistent/public/default/integration1 HTTP/1.1" 400 466 "-" "-" 2 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] digi691 edited a comment on issue #5417: Broker hangs and crashes when listing non-persistent topics
digi691 edited a comment on issue #5417: Broker hangs and crashes when listing
non-persistent topics
URL: https://github.com/apache/pulsar/issues/5417#issuecomment-571677117
@tuteng I was able to upgrade our dev/test Pulsar cluster to version 2.4.2.
Now hitting the /admin/v2/non-persistent/{tenant}/{namespace} API endpoint
causes a HTTP ERROR 504 whether the namspace has non-persistent topics or not.
When Pulsar is run in standalone mode, it produces an empty list.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] digi691 commented on issue #5417: Broker hangs and crashes when listing non-persistent topics
digi691 commented on issue #5417: Broker hangs and crashes when listing
non-persistent topics
URL: https://github.com/apache/pulsar/issues/5417#issuecomment-571677117
I was able to upgrade our dev/test Pulsar cluster to version 2.4.2. Now
hitting the /admin/v2/non-persistent/{tenant}/{namespace} API endpoint causes a
HTTP ERROR 504 whether the namspace has non-persistent topics or not. When
Pulsar is run in standalone mode, it produces an empty list.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] KannarFr commented on issue #5841: Biscuit customs authentication and authorization providers usages.
KannarFr commented on issue #5841: Biscuit customs authentication and authorization providers usages. URL: https://github.com/apache/pulsar/issues/5841#issuecomment-571640113 @zymap Thanks for your work sorry, I'm using hadoop-unit which is not logging the exception, we are working on a fix with its maintainer. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #5995: [docs] improve statement on ordering guarantees for multi-topic subscriptions
Jennifer88huang commented on a change in pull request #5995: [docs] improve statement on ordering guarantees for multi-topic subscriptions URL: https://github.com/apache/pulsar/pull/5995#discussion_r363805395 ## File path: site2/docs/concepts-messaging.md ## @@ -226,8 +226,8 @@ When a consumer subscribes to a Pulsar topic, by default it subscribes to one sp When subscribing to multiple topics, the Pulsar client will automatically make a call to the Pulsar API to discover the topics that match the regex pattern/list and then subscribe to all of them. If any of the topics don't currently exist, the consumer will auto-subscribe to them once the topics are created. -> No ordering guarantees -> When a consumer subscribes to multiple topics, all ordering guarantees normally provided by Pulsar on single topics do not hold. If your use case for Pulsar involves any strict ordering requirements, we would strongly recommend against using this feature. +> No cross-topic ordering guarantees +> Ordering guarantees given for single topics do not hold across multiple topics. So users need to make sure that all messages that need to be delivered in order are on the same topic. Review comment: > Message order is not guaranteed for multiple topics > The order of messages sent by a producer to a single topic is guaranteed. However, if a consumer subscribes to multiple topics, the order of messages is not guaranteed. To guarantee the order of messages to be delivered, you need to make sure that all messages are on the same topic. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] julio666 commented on issue #5867: [issue 5847][dashboard] postgresql correct version (9.6 to 11)
julio666 commented on issue #5867: [issue 5847][dashboard] postgresql correct version (9.6 to 11) URL: https://github.com/apache/pulsar/pull/5867#issuecomment-571630334 @tuteng I'll try to take care of it soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zymap opened a new pull request #6008: Fix PulsarFunctionE2E test
zymap opened a new pull request #6008: Fix PulsarFunctionE2E test URL: https://github.com/apache/pulsar/pull/6008 --- *Motivation* The PulsarFunctionE2E test always failed by connection refused. That because when the test is executed, the file server maybe not have started. *Modifications* - Wait the file server started before running test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on a change in pull request #6004: [Github actions]Fixed unit test
aahmed-se commented on a change in pull request #6004: [Github actions]Fixed unit test URL: https://github.com/apache/pulsar/pull/6004#discussion_r363685408 ## File path: .github/workflows/ci-unit.yaml ## @@ -46,17 +46,34 @@ jobs: with: maven-version: 3.6.1 + - name: run unit tests install by skip tests +run: mvn clean install -DskipTests + + - name: run unit tests pulsar proxy +run: mvn install -DfailIfNoTests=false '-Dtest=!ProxyTest,!ProxyLookupThrottlingTest' -pl pulsar-proxy Review comment: no need to install not just run mvn test for all subsequent actions This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5992: Helm deployment fails to deploy properly
aahmed-se commented on issue #5992: Helm deployment fails to deploy properly URL: https://github.com/apache/pulsar/issues/5992#issuecomment-571528066 @merlimat I don't my changes to docker build files can affect this,I did not change the runtime docker images. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie merged pull request #5940: [Docs]Auto generate pages for pulsar-admin
sijie merged pull request #5940: [Docs]Auto generate pages for pulsar-admin URL: https://github.com/apache/pulsar/pull/5940 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (d1d5cf7 -> 8d200b6)
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from d1d5cf7 add_backlogSize_in_topicStat (#5914)
add 8d200b6 [Docs]Auto generate pages for pulsar-admin (#5940)
No new revisions were added by this update.
Summary of changes:
.gitignore | 3 +
.../pulsar/admin/cli/CmdGenerateDocument.java | 2 +-
site2/tools/generate-api-docs.sh | 3 +
site2/tools/pulsar-admin-doc-gen.sh| 59 +
site2/website/brodocs/actions.js | 58 +
site2/website/brodocs/brodoc.js| 214
.../{static/img/favicon => brodocs}/favicon.ico| Bin
site2/website/brodocs/manifest.json| 42
site2/website/brodocs/markedDecorations.js | 101
site2/website/brodocs/scroll.js| 196 +++
site2/website/brodocs/stylesheet.css | 269 +
site2/website/brodocs/tabvisibility.js | 27 +++
site2/website/package.json | 10 +-
13 files changed, 982 insertions(+), 2 deletions(-)
create mode 100755 site2/tools/pulsar-admin-doc-gen.sh
create mode 100644 site2/website/brodocs/actions.js
create mode 100644 site2/website/brodocs/brodoc.js
copy site2/website/{static/img/favicon => brodocs}/favicon.ico (100%)
create mode 100644 site2/website/brodocs/manifest.json
create mode 100644 site2/website/brodocs/markedDecorations.js
create mode 100644 site2/website/brodocs/scroll.js
create mode 100644 site2/website/brodocs/stylesheet.css
create mode 100644 site2/website/brodocs/tabvisibility.js
[GitHub] [pulsar] sijie commented on a change in pull request #5989: [docs] Improve documentation about batching
sijie commented on a change in pull request #5989: [docs] Improve documentation about batching URL: https://github.com/apache/pulsar/pull/5989#discussion_r363679013 ## File path: site2/docs/concepts-messaging.md ## @@ -49,7 +49,14 @@ Messages published by producers can be compressed during transportation in order ### Batching -If batching is enabled, the producer will accumulate and send a batch of messages in a single request. Batching size is defined by the maximum number of messages and maximum publish latency. +If batching is enabled, the producer will accumulate and send a batch of messages in a single request. Batch size is defined by the maximum number of messages and maximum publish latency. + +Batches are tracked and stored by Pulsar as batches rather than as individual messages. Under the hood the consumer unbundles these batches into individual messages. Since the messages are stored as batches, the backlog size will also represent the total number of batches rather than the total number of messages. + +Scheduled messages (using `deliverAt` or `deliverAfter`) are always sent as individual messages even when batching is enabled. + +> Note +> Since batches are tracked as single units, a batch will only be considered acknowledged when all its messages are acknowledged by the consumer. This means unexpected failures, negative acknowledgements, and acknowledgement timeouts can result in redelivery of all messages in the batch, even if some of the messages have already been acknowledged. Review comment: Agreed. This is a bug and fixes at the client side are not enough. Just fixing this at the client side is actually making the behavior much more confused. We need to get this documentation merged first and then fix the behavior fundamentally in the next release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5990: [Issue 5969] prevent redelivery of acked batch message at the client api
sijie commented on a change in pull request #5990: [Issue 5969] prevent
redelivery of acked batch message at the client api
URL: https://github.com/apache/pulsar/pull/5990#discussion_r363672688
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchAckedTracker.java
##
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.client.impl;
+
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
+
+import com.google.common.annotations.VisibleForTesting;
+
+import org.apache.pulsar.client.api.MessageId;
+
+/**
+ * Tracks any partial acked batches and its acked messages
+ * This will prevent acked message redelivery to the client only at the client
API level.
+ * This class does not track batch with all acked message. We trust broker
won't deliver again.
+ */
+class BatchAckedTracker {
+
+// a map of partial acked batch and its messages already acked
+@VisibleForTesting
+Map> ackedBatches = new HashMap>();
Review comment:
1) I think we should go with bitset. Otherwise, the memory usage can become
out of control.
2) Since the logic here seems to be duplicating the functionality of
AcknowledgmentGroupingTracker. I would prefer not adding duplicated classes. It
is confusing and hard to maintain.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui opened a new pull request #6006: Fix unit test issue in BrokerServiceTest.java
codelipenghui opened a new pull request #6006: Fix unit test issue in BrokerServiceTest.java URL: https://github.com/apache/pulsar/pull/6006 ### Motivation Since #5599 merged, it introduce some conflict code with master branch, maybe the reason is #5599 not rebase with master ### Verifying this change This is a test change ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (no) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation - Does this pull request introduce a new feature? (no) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang opened a new pull request #6007: [Issue 5996][docs] Update links in 2.4.1 and 2.4.2 releases
Jennifer88huang opened a new pull request #6007: [Issue 5996][docs] Update links in 2.4.1 and 2.4.2 releases URL: https://github.com/apache/pulsar/pull/6007 Fixes #5996 ### Motivation The link to "Pulsar Functions SDK for Java" does not work in 2.4.1 and 2.4.2 releases. ### Modifications Fix the link issues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] gmethvin commented on a change in pull request #5989: [docs] Improve documentation about batching
gmethvin commented on a change in pull request #5989: [docs] Improve documentation about batching URL: https://github.com/apache/pulsar/pull/5989#discussion_r363653260 ## File path: site2/docs/concepts-messaging.md ## @@ -49,7 +49,14 @@ Messages published by producers can be compressed during transportation in order ### Batching -If batching is enabled, the producer will accumulate and send a batch of messages in a single request. Batching size is defined by the maximum number of messages and maximum publish latency. +If batching is enabled, the producer will accumulate and send a batch of messages in a single request. Batch size is defined by the maximum number of messages and maximum publish latency. + +Batches are tracked and stored by Pulsar as batches rather than as individual messages. Under the hood the consumer unbundles these batches into individual messages. Since the messages are stored as batches, the backlog size will also represent the total number of batches rather than the total number of messages. + +Scheduled messages (using `deliverAt` or `deliverAfter`) are always sent as individual messages even when batching is enabled. + +> Note +> Since batches are tracked as single units, a batch will only be considered acknowledged when all its messages are acknowledged by the consumer. This means unexpected failures, negative acknowledgements, and acknowledgement timeouts can result in redelivery of all messages in the batch, even if some of the messages have already been acknowledged. Review comment: If we agree it's definitely a bug, then let's get the fix and this documentation update in the next release, and I'll remove the part about negative acks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] fangpengcheng95 commented on a change in pull request #5998: [Issue 5983][docs] promote assign the advertisedAddress when startup …
fangpengcheng95 commented on a change in pull request #5998: [Issue 5983][docs] promote assign the advertisedAddress when startup … URL: https://github.com/apache/pulsar/pull/5998#discussion_r363649577 ## File path: site2/docs/getting-started-standalone.md ## @@ -171,6 +171,8 @@ If you have started Pulsar successfully, you will see `INFO`-level log messages > Tip > +> * Before starting the Pulsar standalone, you may need to config the advertisedAddress to avoid startup errors. Actually, you can modify the default value of advertisedAddress in "conf/standalone.conf" or use command "bin/pulsar standalone -a 127.0.0.1" to assign the advertisedAddress. +> Review comment: @jiazhai Thanks a lot for reviews and advice. I have moved the tip to [2.4.2 version](https://github.com/apache/pulsar/blob/master/site2/website/versioned_docs/version-2.4.2/getting-started-standalone.md). PTAL. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer
sijie commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-571495996 > why this ci build is failed? I feel a little strange, some other pull requests have the same problem, @duli559 the current Jenkins is a bit flaky. We are working on migrating to Github Actions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on a change in pull request #5998: [Issue 5983][docs] promote assign the advertisedAddress when startup …
jiazhai commented on a change in pull request #5998: [Issue 5983][docs] promote assign the advertisedAddress when startup … URL: https://github.com/apache/pulsar/pull/5998#discussion_r363640845 ## File path: site2/docs/getting-started-standalone.md ## @@ -171,6 +171,8 @@ If you have started Pulsar successfully, you will see `INFO`-level log messages > Tip > +> * Before starting the Pulsar standalone, you may need to config the advertisedAddress to avoid startup errors. Actually, you can modify the default value of advertisedAddress in "conf/standalone.conf" or use command "bin/pulsar standalone -a 127.0.0.1" to assign the advertisedAddress. +> Review comment: @fangpengcheng95 FYI. Here is the link of [2.4.2 verison](https://github.com/apache/pulsar/blob/master/site2/website/versioned_docs/version-2.4.2/getting-started-standalone.md) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5742: [pulsar-broker] add support to configure max pending publish request per connection
jiazhai commented on issue #5742: [pulsar-broker] add support to configure max pending publish request per connection URL: https://github.com/apache/pulsar/pull/5742#issuecomment-571488767 ut is fixing by @tuteng at #6004 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer
tuteng commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-571487234 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5997: websocket meet 404 when create producer in standalone mode
jiazhai commented on issue #5997: websocket meet 404 when create producer in standalone mode URL: https://github.com/apache/pulsar/issues/5997#issuecomment-571487305 @jeffgrunewald thanks for the info. so latest 2.4.2 release is fine, while latest master have issues? We will produce and looking into it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5994: k8s/EKS some Proxies fail to get Broker info from Zookeeper
jiazhai commented on issue #5994: k8s/EKS some Proxies fail to get Broker info from Zookeeper URL: https://github.com/apache/pulsar/issues/5994#issuecomment-571485940 @wolfstudy @zymap This looks like a start ordering issue. would you please help check this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
