[GitHub] [pulsar] zymap closed pull request #8453: (WIP) [PIP-50][package-management]Introduce package management interface
zymap closed pull request #8453: URL: https://github.com/apache/pulsar/pull/8453 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8348: Upgrade to ZooKeeper 3.6.2
eolivelli commented on pull request #8348: URL: https://github.com/apache/pulsar/pull/8348#issuecomment-728738345 @merlimat @codelipenghui I am trying to fix this patch now. btw **it is not a blocker for a release**. We are also supporting ZooKeeper server in pulsar distribution, and AFAIK adapting the server side can be painful the way we are launching it. Stay tuned This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8554: [C++] Fixed the setting method of linker option.
codelipenghui merged pull request #8554: URL: https://github.com/apache/pulsar/pull/8554 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated (c01b1ee -> 8ebe0e5)
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c01b1ee [schemaregistry]ProtobufNative Schema Support (#8372) add 8ebe0e5 [C++] Fixed the setting method of linker option. (#8554) No new revisions were added by this update. Summary of changes: pulsar-client-cpp/CMakeLists.txt| 2 +- pulsar-client-cpp/python/CMakeLists.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
[GitHub] [pulsar] codelipenghui closed issue #7642: Protobuf Schema support AutoConsumeSchema and Presto table
codelipenghui closed issue #7642: URL: https://github.com/apache/pulsar/issues/7642 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8372: [schemaregistry]ProtobufNative Schema Support
codelipenghui merged pull request #8372: URL: https://github.com/apache/pulsar/pull/8372 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated (8bb756f -> c01b1ee)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 8bb756f update mongo reactivestreams version (#8190)
add c01b1ee [schemaregistry]ProtobufNative Schema Support (#8372)
No new revisions were added by this update.
Summary of changes:
.../apache/pulsar/broker/ServiceConfiguration.java | 9 +-
.../ProtobufNativeSchemaCompatibilityCheck.java| 73 +++
...java => ProtobufNativeSchemaDataValidator.java} | 42 +++---
.../schema/validator/SchemaDataValidator.java | 3 +
.../src/main/proto/SchemaRegistryFormat.proto | 1 +
...ProtobufNativeSchemaCompatibilityCheckTest.java | 50
.../java/org/apache/pulsar/client/api/Schema.java | 21 +++
.../client/internal/DefaultImplementation.java | 28 +++-
.../apache/pulsar/common/schema/SchemaInfo.java| 1 +
.../apache/pulsar/common/schema/SchemaType.java| 7 +
.../client/impl/schema/AutoConsumeSchema.java | 9 +-
...otobufSchema.java => ProtobufNativeSchema.java} | 72 ++-
.../impl/schema/ProtobufNativeSchemaUtils.java | 142 +
.../generic/GenericProtobufNativeReader.java | 83
...ecord.java => GenericProtobufNativeRecord.java} | 33 +++--
.../generic/GenericProtobufNativeSchema.java | 111
.../GenericProtobufNativeWriter.java} | 10 +-
.../generic/ProtobufNativeRecordBuilderImpl.java | 72 +++
.../impl/schema/reader/ProtobufNativeReader.java | 13 +-
.../impl/schema/writer/ProtobufNativeWriter.java | 11 +-
.../impl/schema/ProtobufNativeSchemaTest.java | 103 +++
.../impl/schema/ProtobufNativeSchemaUtilsTest.java | 44 +++
.../client/impl/schema/ProtobufSchemaTest.java | 36 +++---
.../schema/generic/AbstractGenericSchemaTest.java | 98 ++
.../generic/GenericProtobufNativeReaderTest.java | 71 +++
.../generic/GenericProtobufNativeSchemaTest.java | 66 ++
.../src/test/proto/ExternalTest.proto | 14 +-
pulsar-client/src/test/proto/Test.proto| 8 ++
.../apache/pulsar/common/api/proto/PulsarApi.java | 3 +
...Response.java => ProtobufNativeSchemaData.java} | 18 ++-
pulsar-common/src/main/proto/PulsarApi.proto | 1 +
31 files changed, 1124 insertions(+), 129 deletions(-)
create mode 100644
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/ProtobufNativeSchemaCompatibilityCheck.java
copy
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/validator/{StringSchemaDataValidator.java
=> ProtobufNativeSchemaDataValidator.java} (56%)
create mode 100644
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/schema/ProtobufNativeSchemaCompatibilityCheckTest.java
copy
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/{ProtobufSchema.java
=> ProtobufNativeSchema.java} (60%)
create mode 100644
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/ProtobufNativeSchemaUtils.java
create mode 100644
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/GenericProtobufNativeReader.java
copy
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/{VersionedGenericRecord.java
=> GenericProtobufNativeRecord.java} (58%)
create mode 100644
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/GenericProtobufNativeSchema.java
copy
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/{writer/ProtobufWriter.java
=> generic/GenericProtobufNativeWriter.java} (72%)
create mode 100644
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/ProtobufNativeRecordBuilderImpl.java
copy
pulsar-io/flume/src/main/java/org/apache/pulsar/io/flume/sink/StringSink.java
=>
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/reader/ProtobufNativeReader.java
(75%)
copy
pulsar-io/flume/src/main/java/org/apache/pulsar/io/flume/source/StringSource.java
=>
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/writer/ProtobufNativeWriter.java
(78%)
create mode 100644
pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/ProtobufNativeSchemaTest.java
create mode 100644
pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/ProtobufNativeSchemaUtilsTest.java
create mode 100644
pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/generic/AbstractGenericSchemaTest.java
create mode 100644
pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/generic/GenericProtobufNativeReaderTest.java
create mode 100644
pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/generic/GenericProtobufNativeSchemaTest.java
copy
pulsar-broker-common/src/main/java/org/apache/pulsar/common/configuration/PulsarConfiguration.java
=>
[GitHub] [pulsar] codelipenghui closed issue #7674: [Java Client] Schema Registry enhancement for protobuf schema
codelipenghui closed issue #7674: URL: https://github.com/apache/pulsar/issues/7674 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on issue #7696: [Java] [v2.5.2] BatchReceivePolicy not strictly complied by ConsumerBase and MessageImpl
codelipenghui commented on issue #7696: URL: https://github.com/apache/pulsar/issues/7696#issuecomment-728732176 @e-marchand-exensa I have added the test case for part A https://github.com/apache/pulsar/pull/8587. Seems the problem can't be reproduced. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui opened a new pull request #8587: Add more test case for BatchReceivePolicy.
codelipenghui opened a new pull request #8587: URL: https://github.com/apache/pulsar/pull/8587 Add more test case for BatchReceivePolicy. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on issue #7395: Consumer.getLastMessageId() returns invalid MessageId
codelipenghui commented on issue #7395:
URL: https://github.com/apache/pulsar/issues/7395#issuecomment-728727340
@fmiguelez I try to reproduce the issue, but can't be reproduced on the
master branch, Here is my test code :
```
final String topicName =
"persistent://my-property/my-ns/testGetLastMessageId";
final String subName = "my-sub";
Producer producer = pulsarClient.newProducer(Schema.STRING)
.topic(topicName).create();
producer.send("Hello Pulsar");
Consumer consumer = pulsarClient.newConsumer(Schema.STRING)
.topic(topicName).subscriptionName(subName)
.subscriptionInitialPosition(SubscriptionInitialPosition.Earliest)
.subscribe();
MessageId lastMsgId = consumer.getLastMessageId();
System.out.println(lastMsgId);
```
Output:
```
3:0:-1
```
Could you please provide more information about your reproduce steps? I will
move this issue to milestone 2.8.0 first.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] cbornet commented on a change in pull request #6720: Make ServerCnx, Producer and Consumer independent of Netty
cbornet commented on a change in pull request #6720:
URL: https://github.com/apache/pulsar/pull/6720#discussion_r524915605
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
##
@@ -218,24 +205,20 @@ public boolean readCompacted() {
*
* @return a SendMessageInfo object that contains the detail of what was
sent to consumer
*/
-
-public ChannelPromise sendMessages(final List entries,
EntryBatchSizes batchSizes, EntryBatchIndexesAcks batchIndexesAcks,
+public Future sendMessages(final List entries,
EntryBatchSizes batchSizes, EntryBatchIndexesAcks batchIndexesAcks,
int totalMessages, long totalBytes, long totalChunkedMessages,
RedeliveryTracker redeliveryTracker) {
this.lastConsumedTimestamp = System.currentTimeMillis();
-final ChannelHandlerContext ctx = cnx.ctx();
-final ChannelPromise writePromise = ctx.newPromise();
if (entries.isEmpty() || totalMessages == 0) {
if (log.isDebugEnabled()) {
log.debug("[{}-{}] List of messages is empty, triggering write
future immediately for consumerId {}",
topicName, subscription, consumerId);
}
-writePromise.setSuccess();
batchSizes.recyle();
if (batchIndexesAcks != null) {
batchIndexesAcks.recycle();
}
-return writePromise;
+return ImmediateEventExecutor.INSTANCE.newSucceededFuture(null);
Review comment:
I can move this part of code to the cnx delegate if you prefer (so there
won't be any change for the regular ServerCnx/PulsarCommandSenderImpl).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] lhotari commented on issue #3630: Broker can not respond to client requests
lhotari commented on issue #3630: URL: https://github.com/apache/pulsar/issues/3630#issuecomment-728721439 > let's create a fix on branch-2.6 and create a 2.6.3 release. @sijie @wolfstudy @rdhabalia for consistency, it might be good to also cherry pick d8f319ea , #8302 before removing the extra line (expireAfterWrite from dataCache) to fix the cherry-picking of #8304. There wouldn't have been a merge conflict if that change would have been included. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] cbornet commented on a change in pull request #6720: Make ServerCnx, Producer and Consumer independent of Netty
cbornet commented on a change in pull request #6720:
URL: https://github.com/apache/pulsar/pull/6720#discussion_r524913561
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
##
@@ -218,24 +205,20 @@ public boolean readCompacted() {
*
* @return a SendMessageInfo object that contains the detail of what was
sent to consumer
*/
-
-public ChannelPromise sendMessages(final List entries,
EntryBatchSizes batchSizes, EntryBatchIndexesAcks batchIndexesAcks,
+public Future sendMessages(final List entries,
EntryBatchSizes batchSizes, EntryBatchIndexesAcks batchIndexesAcks,
int totalMessages, long totalBytes, long totalChunkedMessages,
RedeliveryTracker redeliveryTracker) {
this.lastConsumedTimestamp = System.currentTimeMillis();
-final ChannelHandlerContext ctx = cnx.ctx();
-final ChannelPromise writePromise = ctx.newPromise();
if (entries.isEmpty() || totalMessages == 0) {
if (log.isDebugEnabled()) {
log.debug("[{}-{}] List of messages is empty, triggering write
future immediately for consumerId {}",
topicName, subscription, consumerId);
}
-writePromise.setSuccess();
batchSizes.recyle();
if (batchIndexesAcks != null) {
batchIndexesAcks.recycle();
}
-return writePromise;
+return ImmediateEventExecutor.INSTANCE.newSucceededFuture(null);
Review comment:
It's because protocol handlers may not have a `ChannelHandlerContext` to
create a `ChannelPromise` from (eg. in gRPC you don't have direct access to the
Netty channel).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] murong00 commented on pull request #8103: [pulsar-broker] Added support to force deleting tenant
murong00 commented on pull request #8103: URL: https://github.com/apache/pulsar/pull/8103#issuecomment-728716410 > move to 2.8.0 first @codelipenghui I can add a test to cover your comments and we expect this feature as soon as possilbe. Can this be introduced in coming 2.7.0? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] murong00 commented on a change in pull request #8103: [pulsar-broker] Added support to force deleting tenant
murong00 commented on a change in pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103#discussion_r524909204
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminTest.java
##
@@ -455,9 +455,11 @@ public void properties() throws Exception {
assertEquals(e.getResponse().getStatus(),
Status.NOT_FOUND.getStatusCode());
}
+AsyncResponse response = mock(AsyncResponse.class);
+
// Check deleting non-existing property
try {
-properties.deleteTenant("non-existing");
+properties.deleteTenant(response, "non-existing", false);
Review comment:
This change adds a force option so the test need pass this option. I can
add a test to cover the above situations later.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-728709428 @sijie no I didn't and I do not have a way to do it right now, I am sorry. It would be really better to test it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
codelipenghui commented on pull request #8444: URL: https://github.com/apache/pulsar/pull/8444#issuecomment-728709267 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8221: [buildtool] security vulnerability present in jcommander-1.72
codelipenghui commented on pull request #8221: URL: https://github.com/apache/pulsar/pull/8221#issuecomment-728708704 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8076: Update #! in shell scripts
codelipenghui commented on pull request #8076: URL: https://github.com/apache/pulsar/pull/8076#issuecomment-728708277 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8139: [Issue 7675][Pulsar SQL] Presto connector OffloadPolicies deserialization
codelipenghui commented on pull request #8139: URL: https://github.com/apache/pulsar/pull/8139#issuecomment-728708401 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
codelipenghui commented on pull request #7042: URL: https://github.com/apache/pulsar/pull/7042#issuecomment-728707744 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] lhotari opened a new issue #8586: Update TLS instructions to cover the change in default keystore type from JKS to PKCS12 in Java 9+
lhotari opened a new issue #8586: URL: https://github.com/apache/pulsar/issues/8586 **Problem** TLS instructions in https://github.com/apache/pulsar/blob/master/site2/docs/security-tls-keystore.md break in Java 9+ since the [default keystore type is PKCS12 in Java 9+](http://openjdk.java.net/jeps/229). Prepare for supporting Java 9+ by updating the instructions. **Solution** Add `-storetype JKS` parameter to `keytool` commands in https://github.com/apache/pulsar/blob/master/site2/docs/security-tls-keystore.md . Another possibility would be to document how the PKCS12 keystore can be used with Pulsar. **Additional context** [default keystore type is PKCS12 in Java 9+](http://openjdk.java.net/jeps/229) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #8555: [pulsar-broker] support v1 topic dedup admin api
rdhabalia commented on pull request #8555: URL: https://github.com/apache/pulsar/pull/8555#issuecomment-728693311 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #8565: [pulsar-broker] Fix: Topic dedup policy configuration doesn't support V1 topic-name
rdhabalia commented on pull request #8565: URL: https://github.com/apache/pulsar/pull/8565#issuecomment-728693191 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8281: move artifacts of buildtools to test since its only used for testing
codelipenghui commented on pull request #8281: URL: https://github.com/apache/pulsar/pull/8281#issuecomment-728691243 move to 2.8.0 first This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
codelipenghui commented on pull request #8444: URL: https://github.com/apache/pulsar/pull/8444#issuecomment-728691011 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] odidev commented on pull request #7854: Add support for aarch64
odidev commented on pull request #7854: URL: https://github.com/apache/pulsar/pull/7854#issuecomment-728690794 Thanks for merging. It will be useful if arm64 jobs are added to Travis-CI. If you are interested, I can help by raising another PR for adding arm64 jobs in Travis-CI. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8565: [pulsar-broker] Fix: Topic dedup policy configuration doesn't support V1 topic-name
codelipenghui commented on pull request #8565: URL: https://github.com/apache/pulsar/pull/8565#issuecomment-728690554 @rdhabalia Seems dup with #8555 ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated (de4277e -> 8bb756f)
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from de4277e Add support to build pulsar on aarch64 (#7854) add 8bb756f update mongo reactivestreams version (#8190) No new revisions were added by this update. Summary of changes: pulsar-io/mongo/pom.xml | 2 +- .../java/org/apache/pulsar/io/mongodb/MongoSink.java| 6 +++--- .../org/apache/pulsar/io/mongodb/MongoSourceTest.java | 17 + 3 files changed, 17 insertions(+), 8 deletions(-)
[pulsar] branch master updated (de4277e -> 8bb756f)
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from de4277e Add support to build pulsar on aarch64 (#7854) add 8bb756f update mongo reactivestreams version (#8190) No new revisions were added by this update. Summary of changes: pulsar-io/mongo/pom.xml | 2 +- .../java/org/apache/pulsar/io/mongodb/MongoSink.java| 6 +++--- .../org/apache/pulsar/io/mongodb/MongoSourceTest.java | 17 + 3 files changed, 17 insertions(+), 8 deletions(-)
[pulsar] branch master updated (8e31e85 -> de4277e)
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 8e31e85 [pulsar-broker] Fix broker-ml bucket stats show high metrics rate (#8218) add de4277e Add support to build pulsar on aarch64 (#7854) No new revisions were added by this update. Summary of changes: distribution/server/src/assemble/LICENSE.bin.txt | 2 +- pom.xml | 3 ++- pulsar-common/pom.xml| 2 +- pulsar-sql/presto-distribution/LICENSE | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-)
[pulsar] branch master updated (5bbd447 -> 3ae9399)
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 5bbd447 Update Guava to version 30.0 (#8538) add 3ae9399 Add `passive` to io-rabbitmq config options (#8075) No new revisions were added by this update. Summary of changes: .../main/java/org/apache/pulsar/io/rabbitmq/RabbitMQSource.java| 6 +- .../java/org/apache/pulsar/io/rabbitmq/RabbitMQSourceConfig.java | 6 ++ .../apache/pulsar/io/rabbitmq/source/RabbitMQSourceConfigTest.java | 7 +++ .../org/apache/pulsar/io/rabbitmq/source/RabbitMQSourceTest.java | 1 + pulsar-io/rabbitmq/src/test/resources/sourceConfig.yaml| 4 ++-- site2/docs/io-rabbitmq-source.md | 5 - 6 files changed, 25 insertions(+), 4 deletions(-)
[pulsar] branch master updated (3ae9399 -> 8e31e85)
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 3ae9399 Add `passive` to io-rabbitmq config options (#8075) add 8e31e85 [pulsar-broker] Fix broker-ml bucket stats show high metrics rate (#8218) No new revisions were added by this update. Summary of changes: .../apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java | 2 +- .../org/apache/pulsar/broker/stats/metrics/AbstractMetrics.java | 4 ++-- .../apache/pulsar/broker/stats/metrics/ManagedLedgerMetrics.java | 9 + 3 files changed, 8 insertions(+), 7 deletions(-)
[GitHub] [pulsar] codelipenghui merged pull request #8190: update mongo reactivestreams version
codelipenghui merged pull request #8190: URL: https://github.com/apache/pulsar/pull/8190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #7854: Add support for aarch64
codelipenghui merged pull request #7854: URL: https://github.com/apache/pulsar/pull/7854 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8218: [pulsar-broker] Fix broker-ml bucket stats show high metrics rate
codelipenghui merged pull request #8218: URL: https://github.com/apache/pulsar/pull/8218 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8075: Add `passive` to io-rabbitmq config options
codelipenghui merged pull request #8075: URL: https://github.com/apache/pulsar/pull/8075 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] lhotari opened a new issue #8585: Update certificates used in TLS tests to use SHA-256 signature algorithm so that TLSv1.3 support can be added
lhotari opened a new issue #8585: URL: https://github.com/apache/pulsar/issues/8585 ** Problem ** In TLSv1.3, certificates using SHA-1 signature algorithm are considered legacy and it's not recommended that TLSv1.3 implementations accept certificates that use SHA-1 signature algorithms. [In RFC8446, section 4.4.2.4. Receiving a Certificate Message](https://tools.ietf.org/html/rfc8446#section-4.4.2.4) _SHA-1 is deprecated, and it is RECOMMENDED that any endpoint receiving any certificate which it would need to validate using any signature algorithm using a SHA-1 hash abort the handshake with a "bad_certificate" alert._ ** Solution ** Update all certificates (server and client) used in Pulsar tests to use SHA-256 signature algorithms so that it's possible to add TLSv1.3 support. **Additional context** #8580, #8581 [TLSv1.3 is available in Java 8 since 8u161 (since OpenJDK 8u272)](https://github.com/AdoptOpenJDK/openjdk-build/issues/1254#issuecomment-683337917). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8581: [Issue 8580][pulsar-common] Set configured TLS protocols to SSLEngine instance
lhotari commented on pull request #8581: URL: https://github.com/apache/pulsar/pull/8581#issuecomment-728681953 > Is there any way to add a test case? > This is security related code > We should prevent regressions Yes. It would be possible to create a negative test case where the client and server are configured to use different TLS protocols. In that case, the TLS handshake shouldn't succeed and the connection shouldn't get established. That would catch the bug that was in the code. In addition, there could be a few tests that check that connections can be established when the server contains at least one of the protocols that is enabled on the client. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] lhotari edited a comment on pull request #8581: [Issue 8580][pulsar-common] Set configured TLS protocols to SSLEngine instance
lhotari edited a comment on pull request #8581: URL: https://github.com/apache/pulsar/pull/8581#issuecomment-728679620 > What is the value returns before? @sijie For Java 8u272, Arrays.asList(sslEngine.getSupportedProtocols()).toString() returns `[TLSv1.3, TLSv1.2, TLSv1.1, TLSv1, SSLv3, SSLv2Hello]`. For Java 8u232, it's `[SSLv2Hello, SSLv3, TLSv1, TLSv1.1, TLSv1.2]`. [The `protocols` field in `KeyStoreSSLContext` was unused before](https://github.com/apache/pulsar/blob/5bbd44784a9e4bc58ee5025025d748b52b21825a/pulsar-common/src/main/java/org/apache/pulsar/common/util/keystoretls/KeyStoreSSLContext.java#L79) and it's an old bug that the field was never used to configure the enabled TLS protocols for the SSLEngine. TLS `protocols` are properly passed in `NettyServerSslContextBuilder` class, so this has been a bug in the code that uses `KeyStoreSSLContext`. btw. The KeyStoreSSLContext class is also used for the web server. In those cases, [the protocols aren't configured and there's also a comment about it in the code](https://github.com/apache/pulsar/blob/5bbd44784a9e4bc58ee5025025d748b52b21825a/pulsar-common/src/main/java/org/apache/pulsar/common/util/keystoretls/KeyStoreSSLContext.java#L247). However there's a default value in `KeyStoreSSLContext` which will get used if null is passed to protocols. It's defined at https://github.com/apache/pulsar/blob/5bbd44784a9e4bc58ee5025025d748b52b21825a/pulsar-common/src/main/java/org/apache/pulsar/common/util/keystoretls/KeyStoreSSLContext.java#L52 . Previously this default value has been ignored since it was never set to the SSLEngine. With this PR, it will get set. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8581: [Issue 8580][pulsar-common] Set configured TLS protocols to SSLEngine instance
lhotari commented on pull request #8581: URL: https://github.com/apache/pulsar/pull/8581#issuecomment-728679620 > What is the value returns before? @sijie For Java 8u272, Arrays.asList(sslEngine.getSupportedProtocols()).toString() returns `[TLSv1.3, TLSv1.2, TLSv1.1, TLSv1, SSLv3, SSLv2Hello]`. For Java 8u232, it's `[SSLv2Hello, SSLv3, TLSv1, TLSv1.1, TLSv1.2]`. [The `protocols` field in `KeyStoreSSLContext` was unused before](https://github.com/apache/pulsar/blob/5bbd44784a9e4bc58ee5025025d748b52b21825a/pulsar-common/src/main/java/org/apache/pulsar/common/util/keystoretls/KeyStoreSSLContext.java#L79) and it's an old bug that the field was never used to configure the enabled TLS protocols for the SSLEngine. TLS `protocols` are properly passed in `NettyServerSslContextBuilder` class, so this has been a bug in the code that uses `KeyStoreSSLContext`. btw. The KeyStoreSSLContext class is also used for the web server. In those cases, [the protocols aren't configured and there's also a comment about it in the code](https://github.com/apache/pulsar/blob/5bbd44784a9e4bc58ee5025025d748b52b21825a/pulsar-common/src/main/java/org/apache/pulsar/common/util/keystoretls/KeyStoreSSLContext.java#L247). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] bsergean opened a new issue #8584: WebSocket broker: url (path and query) args (namespace, topic, etc...) exposed through message fields
bsergean opened a new issue #8584:
URL: https://github.com/apache/pulsar/issues/8584
**Is your enhancement request related to a problem? Please describe.**
If a client need to publish to 2 different topics, it will take 2 tcp
connections between the client and the broker. 3 topics, 3 tcp connections
etc... if ssl is enabled this is more costly.
**Describe the solution you'd like**
It would be very handy to be able to specify all the url info in the
websocket message instead. There are multiple websocket apis that do that, like
[wamp](https://wamp-proto.org/), [wamp publish
doc](https://wamp-proto.org/_static/gen/wamp_latest.html#publish-0) or
[cobra](https://machinezone.github.io/cobra/api/). I'm trying to look at the
[pusher
api](https://pusher.com/docs/channels/library_auth_reference/pusher-websockets-protocol)
but cannot find the details, however it looks possible to make multiple
subscriptions with a single client.
For publishing, instead of doing this:
url:
*/ws/v2/producer/persistent/:tenant/:namespace/:topic?param1=too=bar
```
{
"payload": "SGVsbG8gV29ybGQ=",
"properties": {"key1": "value1", "key2": "value2"},
"context": "1"
}
```
Do this:
url: */ws/v2/producer/persistent/:tenant/:namespace/:topic*
```
{
"payload": "SGVsbG8gV29ybGQ=",
"properties": {"key1": "value1", "key2": "value2"},
"context": "1",
-- Extra args -
"action": "producer",
"persistence": true,
"tenant": "a tenant",
"namespace": "a namespace",
"topic": "a topic"
"params": {
"param1": "foo",
"param2": "bar"
}
}
```
**Describe alternatives you've considered**
Writing a proxy broker that does this ?
**Additional context**
If a client needs to publish to 10 topics, or 50, it will need to create 10,
50 tcp connections to the broker which is not scalable.
Thanks !
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8075: Add `passive` to io-rabbitmq config options
codelipenghui commented on pull request #8075: URL: https://github.com/apache/pulsar/pull/8075#issuecomment-728677458 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8075: Add `passive` to io-rabbitmq config options
codelipenghui commented on pull request #8075: URL: https://github.com/apache/pulsar/pull/8075#issuecomment-728677164 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
codelipenghui commented on pull request #7042: URL: https://github.com/apache/pulsar/pull/7042#issuecomment-728676732 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6648: [pulsar-client] add api to wait for inflight messages while closing producer
codelipenghui commented on pull request #6648: URL: https://github.com/apache/pulsar/pull/6648#issuecomment-728675890 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #8565: [pulsar-broker] Fix: Topic dedup policy configuration doesn't support V1 topic-name
codelipenghui commented on a change in pull request #8565:
URL: https://github.com/apache/pulsar/pull/8565#discussion_r524873416
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/PersistentTopics.java
##
@@ -347,6 +348,67 @@ public void getPartitionedStats(@Suspended final
AsyncResponse asyncResponse,
}
}
+@GET
+@Path("/{tenant}/{cluster}/{namespace}/{topic}/deduplicationEnabled")
+@ApiOperation(value = "Get deduplication configuration of a topic.")
+@ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have
admin permission"),
+@ApiResponse(code = 404, message = "Tenant or cluster or namespace
or topic doesn't exist"),
+@ApiResponse(code = 405, message = "Topic level policy is
disabled, to enable the topic level policy and retry")})
+public void getDeduplicationEnabled(@Suspended final AsyncResponse
asyncResponse,
+ @PathParam("tenant") String tenant,
+ @PathParam("cluster") String cluster,
+ @PathParam("namespace") String namespace,
+ @PathParam("topic") @Encoded String encodedTopic)
{
+validateTopicName(tenant, cluster, namespace, encodedTopic);
+TopicPolicies topicPolicies = getTopicPolicies(topicName).orElse(new
TopicPolicies());
Review comment:
Should we check the topic ownership check?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #8564: [pulsar-broker] Fix topic policy update
codelipenghui commented on a change in pull request #8564:
URL: https://github.com/apache/pulsar/pull/8564#discussion_r524872949
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest2.java
##
@@ -1343,6 +1345,20 @@ public void testInvalidBundleErrorResponse() throws
Exception {
}
}
+@Test
+public void testDedupTopicOwnership() throws Exception {
Review comment:
Seems the tests can't cover the changes? I think we must start more than
1 brokers.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8561: [broker] Close topics that remain fenced forcefully
codelipenghui commented on pull request #8561: URL: https://github.com/apache/pulsar/pull/8561#issuecomment-728673708 @sijie Please help review this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8554: [C++] Fixed the setting method of linker option.
codelipenghui commented on pull request #8554: URL: https://github.com/apache/pulsar/pull/8554#issuecomment-728672931 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8540: Support key base for python function
codelipenghui commented on pull request #8540: URL: https://github.com/apache/pulsar/pull/8540#issuecomment-728672791 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated (bd475c2 -> 5bbd447)
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from bd475c2 [Issue #8268][Pulsar Function] k8s runtime with go functions support (#8352) add 5bbd447 Update Guava to version 30.0 (#8538) No new revisions were added by this update. Summary of changes: distribution/server/src/assemble/LICENSE.bin.txt | 10 +- pom.xml | 2 +- pulsar-sql/presto-distribution/LICENSE | 12 ++-- pulsar-sql/presto-distribution/pom.xml | 2 +- 4 files changed, 13 insertions(+), 13 deletions(-)
[GitHub] [pulsar] codelipenghui merged pull request #8538: Update Guava to version 30.0
codelipenghui merged pull request #8538: URL: https://github.com/apache/pulsar/pull/8538 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
codelipenghui commented on a change in pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#discussion_r524868285
##
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
##
@@ -217,27 +229,6 @@ public void failed(Throwable throwable) {
}
}
-@Override
-public CompletableFuture> getListInBundleAsync(String
namespace, String bundleRange) {
Review comment:
I think this will not break the compatibility since this will not change
the interface.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on issue #8431: Adding document for e2e encryption pulsar functions
wolfstudy commented on issue #8431: URL: https://github.com/apache/pulsar/issues/8431#issuecomment-728668475 > @nlu90 I will start the 2.7.0 release process soon. Do you have time to add the documentation for #8432? @codelipenghui Please add this task to me, I will process this task. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on issue #8431: Adding document for e2e encryption pulsar functions
codelipenghui commented on issue #8431: URL: https://github.com/apache/pulsar/issues/8431#issuecomment-728668068 @nlu90 I will start the 2.7.0 release process soon. Do you have time to add the documentation for https://github.com/apache/pulsar/pull/8432? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8422: [PIP-71][SQL]Pulsar SQL migrate SchemaHandle to presto decoder
codelipenghui commented on pull request #8422: URL: https://github.com/apache/pulsar/pull/8422#issuecomment-728667500 move to 2.8.0 first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8418: support broker-level consume rate limiter
codelipenghui commented on pull request #8418: URL: https://github.com/apache/pulsar/pull/8418#issuecomment-728667379 move to 2.8.0 first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated (12ef7c9 -> bd475c2)
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 12ef7c9 Support partitioned topics in the Reader (#7518) add bd475c2 [Issue #8268][Pulsar Function] k8s runtime with go functions support (#8352) No new revisions were added by this update. Summary of changes: .../pulsar/functions/runtime/RuntimeUtils.java | 2 +- .../runtime/kubernetes/KubernetesRuntime.java | 11 ++- .../kubernetes/KubernetesRuntimeFactory.java | 2 +- .../pulsar/functions/runtime/RuntimeUtilsTest.java | 2 +- .../runtime/kubernetes/KubernetesRuntimeTest.java | 83 ++ .../KubernetesSecretsProviderConfigurator.java | 3 +- 6 files changed, 98 insertions(+), 5 deletions(-)
[GitHub] [pulsar] codelipenghui merged pull request #8352: [Issue #8268][Pulsar Function] k8s runtime with go functions support
codelipenghui merged pull request #8352: URL: https://github.com/apache/pulsar/pull/8352 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui closed issue #8268: [Pulsar Function] Support k8s runtime for Go Functions
codelipenghui closed issue #8268: URL: https://github.com/apache/pulsar/issues/8268 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8348: Upgrade to ZooKeeper 3.6.2
codelipenghui commented on pull request #8348: URL: https://github.com/apache/pulsar/pull/8348#issuecomment-728666746 @eolivelli I will start the 2.7.0 release process soon, I think it's better to onboard this change. Seems @merlimat do not have time, I think you can pick up this fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8342: [Issue 8340] [pulsar-testclient] Provide options to specify existing topics and subscriptions
codelipenghui commented on pull request #8342: URL: https://github.com/apache/pulsar/pull/8342#issuecomment-728665710 move to 2.8.0 first This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8295: Pending ack persistent implement
codelipenghui commented on pull request #8295: URL: https://github.com/apache/pulsar/pull/8295#issuecomment-728663639 move to 2.8.0 first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8250: [pulsar-io] Add NSQ Source
codelipenghui commented on pull request #8250: URL: https://github.com/apache/pulsar/pull/8250#issuecomment-728662069 @flowchartsman There are some flaky test that already fixed in master branch, could you please sync with the apache master branch? Since you are pushing the PR with your master branch, I have sync the apache master branch to your master branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8249: Nack support in WS
codelipenghui commented on pull request #8249: URL: https://github.com/apache/pulsar/pull/8249#issuecomment-728659477 move to 2.8.0 first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #8249: Nack support in WS
codelipenghui commented on a change in pull request #8249:
URL: https://github.com/apache/pulsar/pull/8249#discussion_r524858103
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/websocket/proxy/ProxyPublishConsumeTest.java
##
@@ -564,6 +566,76 @@ public void socketPullModeTest() throws Exception {
}
}
+@Test(timeOut = 1)
+public void nackMessageTest() throws Exception {
+final String subscription = "my-sub";
+final String dlqTopic = "my-property/my-ns/my-topic10";
+final String consumerTopic = "my-property/my-ns/my-topic9";
+
+final String dlqUri = "ws://localhost:" +
proxyServer.getListenPortHTTP().get() +
+ "/ws/v2/consumer/persistent/" +
+ dlqTopic + "/" + subscription +
+ "?subscriptionType=Shared";
+
+final String consumerUri = "ws://localhost:" +
proxyServer.getListenPortHTTP().get() +
+ "/ws/v2/consumer/persistent/" +
+ consumerTopic + "/" + subscription +
+ "?deadLetterTopic=" + dlqTopic +
+
"=0=Shared=1000=1000";
+
+final String producerUri = "ws://localhost:" +
proxyServer.getListenPortHTTP().get() +
+ "/ws/v2/producer/persistent/" + consumerTopic;
+
+WebSocketClient consumeClient1 = new WebSocketClient();
+SimpleConsumerSocket consumeSocket1 = new SimpleConsumerSocket();
+WebSocketClient consumeClient2 = new WebSocketClient();
+SimpleConsumerSocket consumeSocket2 = new SimpleConsumerSocket();
+WebSocketClient produceClient = new WebSocketClient();
+SimpleProducerSocket produceSocket = new SimpleProducerSocket();
+
+consumeSocket1.setMessageHandler((id, data) -> {
+JsonObject nack = new JsonObject();
+nack.add("messageId", new JsonPrimitive(id));
+nack.add("type", new JsonPrimitive("negativeAcknowledge"));
+return nack.toString();
+});
+
+try {
+consumeClient1.start();
+consumeClient2.start();
+ClientUpgradeRequest consumeRequest1 = new ClientUpgradeRequest();
+ClientUpgradeRequest consumeRequest2 = new ClientUpgradeRequest();
+Future consumerFuture1 =
consumeClient1.connect(consumeSocket1, URI.create(consumerUri),
consumeRequest1);
+Future consumerFuture2 =
consumeClient2.connect(consumeSocket2, URI.create(dlqUri), consumeRequest2);
+
+assertTrue(consumerFuture1.get().isOpen());
+assertTrue(consumerFuture2.get().isOpen());
+
+ClientUpgradeRequest produceRequest = new ClientUpgradeRequest();
+produceClient.start();
+Future producerFuture =
produceClient.connect(produceSocket, URI.create(producerUri), produceRequest);
+assertTrue(producerFuture.get().isOpen());
+
+assertEquals(consumeSocket1.getReceivedMessagesCount(), 0);
+assertEquals(consumeSocket2.getReceivedMessagesCount(), 0);
+
+produceSocket.sendMessage(1);
+
+Thread.sleep(500);
+
+//assertEquals(consumeSocket1.getReceivedMessagesCount(), 1);
Review comment:
I think you can refine the test as
https://github.com/apache/pulsar/pull/8557 does. Sleep also introduces too much
flaky tests.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8242: Fix docker image permissions of /pulsar for OpenShift
codelipenghui commented on pull request #8242: URL: https://github.com/apache/pulsar/pull/8242#issuecomment-728657284 move to 2.8.0 first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] xuesongxs opened a new issue #8583: The RESTAPI "Get the internal stats for the topic" does not show the status of the ledger
xuesongxs opened a new issue #8583: URL: https://github.com/apache/pulsar/issues/8583 **Describe the bug** The RESTAPI "Get the internal stats for the topic" does not show the status of the ledger，so the status displayed on the pulsar manager page may not be correct。    This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] pkumar-singh opened a new pull request #8221: [buildtool] security vulnerability present in jcommander-1.72
pkumar-singh opened a new pull request #8221: URL: https://github.com/apache/pulsar/pull/8221 ### Motivation jcommander-1.72 has a white source reported security vulnerability WS-2019-0490: https://www.whitesourcesoftware.com/vulnerability-database/WS-2019-0490 White source vulnerability description as it is. > Inclusion of Functionality from Untrusted Control Sphere vulnerability found in jcommander before 1.75. jcommander resolving dependencies over HTTP instead of HTTPS. ### Modifications Upgrade org.testng to 7.3.0 in buildtools. That way it pulls in jcommander 1.78 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #8221: [buildtool] security vulnerability present in jcommander-1.72
codelipenghui closed pull request #8221: URL: https://github.com/apache/pulsar/pull/8221 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8221: [buildtool] security vulnerability present in jcommander-1.72
codelipenghui commented on pull request #8221: URL: https://github.com/apache/pulsar/pull/8221#issuecomment-728653692 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8218: [pulsar-broker] Fix broker-ml bucket stats show high metrics rate
codelipenghui commented on pull request #8218: URL: https://github.com/apache/pulsar/pull/8218#issuecomment-728652577 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8125: [REST] Rest API Produce message.
codelipenghui commented on pull request #8125: URL: https://github.com/apache/pulsar/pull/8125#issuecomment-728650840 move to 2.8.0 first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on issue #8121: Fix the flaky test testRemoveSubscribeRate
codelipenghui commented on issue #8121: URL: https://github.com/apache/pulsar/issues/8121#issuecomment-728650592 Seems this issue is fixed by #8557, So close it first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui closed issue #8121: Fix the flaky test testRemoveSubscribeRate
codelipenghui closed issue #8121: URL: https://github.com/apache/pulsar/issues/8121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8105: [Issue 6040][pulsar-client-go] Avoid incompatible pointer types warnings during build
codelipenghui commented on pull request #8105: URL: https://github.com/apache/pulsar/pull/8105#issuecomment-728650216 move to 2.8.0 first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] seeday opened a new pull request #8076: Update #! in shell scripts
seeday opened a new pull request #8076: URL: https://github.com/apache/pulsar/pull/8076 ### Motivation Some new distributions like nix and guix have stressed the definition of posix compliance and do not provide `/bin/bash`, breaking pulsar builds for these distros. This PR applies the most straightforward fix, as `/usr/bin/env` is posix. Note for those searching in the future: there are still issues with nix builds relating to [this ridiculousness](https://discourse.nixos.org/t/runtime-alternative-to-patchelf-set-interpreter/3539), but that's truly a nix issue, not pulsar. ### Modifications `fd -e .sh -x sed -i 's/#!\/bin\/bash/#!\/usr\/bin\/env bash/'` ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is a trivial rework / **code cleanup** without any test coverage. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API: (yes / **no**) - The schema: (yes / **no** / don't know) - The default values of configurations: (yes / **no**) - The wire protocol: (yes / **no**) - The rest endpoints: (yes / **no**) - The admin cli options: (yes / **no**) - Anything that affects deployment: (yes / **no**/ don't know) ### Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented) - If a feature is not applicable for documentation, explain why? - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8103: [pulsar-broker] Added support to force deleting tenant
codelipenghui commented on pull request #8103: URL: https://github.com/apache/pulsar/pull/8103#issuecomment-728649861 move to 2.8.0 first This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #8076: Update #! in shell scripts
codelipenghui closed pull request #8076: URL: https://github.com/apache/pulsar/pull/8076 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #8103: [pulsar-broker] Added support to force deleting tenant
codelipenghui commented on a change in pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103#discussion_r524848532
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminTest.java
##
@@ -455,9 +455,11 @@ public void properties() throws Exception {
assertEquals(e.getResponse().getStatus(),
Status.NOT_FOUND.getStatusCode());
}
+AsyncResponse response = mock(AsyncResponse.class);
+
// Check deleting non-existing property
try {
-properties.deleteTenant("non-existing");
+properties.deleteTenant(response, "non-existing", false);
Review comment:
Is the test related to this change? I think the test should cover there
are namespaces and topics under a tenant, then we delete the tenant forcefully
should success.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8076: Update #! in shell scripts
codelipenghui commented on pull request #8076: URL: https://github.com/apache/pulsar/pull/8076#issuecomment-728648233 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8042: Updated storage client
codelipenghui commented on pull request #8042: URL: https://github.com/apache/pulsar/pull/8042#issuecomment-728647499 move to 2.8.0 first This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] massakam commented on a change in pull request #8561: [broker] Close topics that remain fenced forcefully
massakam commented on a change in pull request #8561:
URL: https://github.com/apache/pulsar/pull/8561#discussion_r524846319
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##
@@ -2384,6 +2387,40 @@ public boolean isSystemTopic() {
return false;
}
+private synchronized void fence() {
+isFenced = true;
+ScheduledFuture monitoringTask = this.fencedTopicMonitoringTask;
+if (monitoringTask == null || monitoringTask.isDone()) {
+final int timeout =
brokerService.pulsar().getConfiguration().getTopicFencingTimeoutSeconds();
+if (timeout > 0) {
+this.fencedTopicMonitoringTask =
brokerService.executor().schedule(this::closeFencedTopicForcefully,
+timeout, TimeUnit.SECONDS);
+}
+}
+}
+
+private synchronized void unfence() {
+isFenced = false;
+ScheduledFuture monitoringTask = this.fencedTopicMonitoringTask;
+if (monitoringTask != null && !monitoringTask.isDone()) {
+monitoringTask.cancel(false);
+}
+}
+
+private synchronized void closeFencedTopicForcefully() {
+if (isFenced) {
+final int timeout =
brokerService.pulsar().getConfiguration().getTopicFencingTimeoutSeconds();
+if (isClosingOrDeleting) {
+log.warn("[{}] Topic remained fenced for {} seconds and is
already closed (pendingWriteOps: {})", topic,
+timeout, pendingWriteOps.get());
+} else {
+log.error("[{}] Topic remained fenced for {} seconds, so close
it (pendingWriteOps: {})", topic,
+timeout, pendingWriteOps.get());
+close();
Review comment:
I removed "synchronized" because there was no clear reason to make this
method synchronized.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8026: [pulsar-functions] Fix message consume ordering issue of function
codelipenghui commented on pull request #8026: URL: https://github.com/apache/pulsar/pull/8026#issuecomment-728647170 @wolfstudy Please also help review this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8026: [pulsar-functions] Fix message consume ordering issue of function
codelipenghui commented on pull request #8026: URL: https://github.com/apache/pulsar/pull/8026#issuecomment-728647067 move to 2.8.0 first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8025: The consumption performance index cannot be obtained, and the obtaine…
codelipenghui commented on pull request #8025: URL: https://github.com/apache/pulsar/pull/8025#issuecomment-728646453 move to milestone 2.8.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7907: Allow disabling HTTP TRACE/TRACK verbs
codelipenghui commented on pull request #7907: URL: https://github.com/apache/pulsar/pull/7907#issuecomment-728646198 move to 2.8.0 first This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7894: add cache hit ratio metrics for topic subscription
codelipenghui commented on pull request #7894: URL: https://github.com/apache/pulsar/pull/7894#issuecomment-728645420 @zhaorongsheng Could you please help resolve the conflicts? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7855: [Issue 7846]Add support for regex patterns in tenant and namespace
codelipenghui commented on pull request #7855: URL: https://github.com/apache/pulsar/pull/7855#issuecomment-728645156 move to 2.8.0 first This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated (8d3c0df -> 12ef7c9)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 8d3c0df Fix gc log variable judge in jdk8 (#8579)
add 12ef7c9 Support partitioned topics in the Reader (#7518)
No new revisions were added by this update.
Summary of changes:
.../broker/service/SubscriptionSeekTest.java | 3 +-
.../apache/pulsar/client/api/TopicReaderTest.java | 507 -
...{ReaderTest.java => MultiTopicsReaderTest.java} | 271 ++-
.../apache/pulsar/client/impl/ConsumerImpl.java| 22 +-
.../apache/pulsar/client/impl/MessageIdImpl.java | 13 +
.../client/impl/MultiTopicsConsumerImpl.java | 100 +++-
...{ReaderImpl.java => MultiTopicsReaderImpl.java} | 136 +++---
.../pulsar/client/impl/PulsarClientImpl.java | 19 +-
8 files changed, 836 insertions(+), 235 deletions(-)
copy
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/{ReaderTest.java =>
MultiTopicsReaderTest.java} (74%)
copy
pulsar-client/src/main/java/org/apache/pulsar/client/impl/{ReaderImpl.java =>
MultiTopicsReaderImpl.java} (60%)
[pulsar] branch master updated (8d3c0df -> 12ef7c9)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 8d3c0df Fix gc log variable judge in jdk8 (#8579)
add 12ef7c9 Support partitioned topics in the Reader (#7518)
No new revisions were added by this update.
Summary of changes:
.../broker/service/SubscriptionSeekTest.java | 3 +-
.../apache/pulsar/client/api/TopicReaderTest.java | 507 -
...{ReaderTest.java => MultiTopicsReaderTest.java} | 271 ++-
.../apache/pulsar/client/impl/ConsumerImpl.java| 22 +-
.../apache/pulsar/client/impl/MessageIdImpl.java | 13 +
.../client/impl/MultiTopicsConsumerImpl.java | 100 +++-
...{ReaderImpl.java => MultiTopicsReaderImpl.java} | 136 +++---
.../pulsar/client/impl/PulsarClientImpl.java | 19 +-
8 files changed, 836 insertions(+), 235 deletions(-)
copy
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/{ReaderTest.java =>
MultiTopicsReaderTest.java} (74%)
copy
pulsar-client/src/main/java/org/apache/pulsar/client/impl/{ReaderImpl.java =>
MultiTopicsReaderImpl.java} (60%)
[GitHub] [pulsar] codelipenghui commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
codelipenghui commented on pull request #7848: URL: https://github.com/apache/pulsar/pull/7848#issuecomment-728642649 move to 2.8.0 first This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on issue #7804: ConcurrentModificationException occurs when dispatch message to consumers
codelipenghui commented on issue #7804: URL: https://github.com/apache/pulsar/issues/7804#issuecomment-728641901 move to milestone 2.8.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated (8d3c0df -> 12ef7c9)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 8d3c0df Fix gc log variable judge in jdk8 (#8579)
add 12ef7c9 Support partitioned topics in the Reader (#7518)
No new revisions were added by this update.
Summary of changes:
.../broker/service/SubscriptionSeekTest.java | 3 +-
.../apache/pulsar/client/api/TopicReaderTest.java | 507 -
...{ReaderTest.java => MultiTopicsReaderTest.java} | 271 ++-
.../apache/pulsar/client/impl/ConsumerImpl.java| 22 +-
.../apache/pulsar/client/impl/MessageIdImpl.java | 13 +
.../client/impl/MultiTopicsConsumerImpl.java | 100 +++-
...{ReaderImpl.java => MultiTopicsReaderImpl.java} | 136 +++---
.../pulsar/client/impl/PulsarClientImpl.java | 19 +-
8 files changed, 836 insertions(+), 235 deletions(-)
copy
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/{ReaderTest.java =>
MultiTopicsReaderTest.java} (74%)
copy
pulsar-client/src/main/java/org/apache/pulsar/client/impl/{ReaderImpl.java =>
MultiTopicsReaderImpl.java} (60%)
[GitHub] [pulsar] codelipenghui commented on pull request #7776: Make bundle REST calls to be async
codelipenghui commented on pull request #7776: URL: https://github.com/apache/pulsar/pull/7776#issuecomment-728640786 move to milestone 2.8.0 first This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on issue #7742: Allow function instance configuring a different instance classpath
codelipenghui commented on issue #7742: URL: https://github.com/apache/pulsar/issues/7742#issuecomment-728640629 move to 2.8.0 first This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7533: [Issue 7492][pulsar-broker] Cleanup configuration process when using PulsarStandaloneBuilder
codelipenghui commented on pull request #7533: URL: https://github.com/apache/pulsar/pull/7533#issuecomment-728640273 move to milestone 2.8.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #7518: Support partitioned topics in the Reader
codelipenghui merged pull request #7518: URL: https://github.com/apache/pulsar/pull/7518 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
