Re: [I] Factor out integration test utils [pulsar]
tisonkun closed issue #20664: Factor out integration test utils URL: https://github.com/apache/pulsar/issues/20664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Doc] Fix links to Google docs page in the documentation guide [pulsar]
tisonkun closed issue #18297: [Doc] Fix links to Google docs page in the documentation guide URL: https://github.com/apache/pulsar/issues/18297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Flaky-test: recoverLongTimeAfterMultipleWriteErrors [pulsar]
tisonkun commented on issue #20364: URL: https://github.com/apache/pulsar/issues/20364#issuecomment-2053889868 Outdated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Flaky-test: recoverLongTimeAfterMultipleWriteErrors [pulsar]
tisonkun closed issue #20364: Flaky-test: recoverLongTimeAfterMultipleWriteErrors URL: https://github.com/apache/pulsar/issues/20364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Factor out integration test utils [pulsar]
tisonkun commented on issue #20664: URL: https://github.com/apache/pulsar/issues/20664#issuecomment-2053889792 No longer a blocker since we drop all the pulsar-sql code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Doc] Fix links to Google docs page in the documentation guide [pulsar]
tisonkun commented on issue #18297: URL: https://github.com/apache/pulsar/issues/18297#issuecomment-2053889681 https://github.com/apache/pulsar/issues/18272#issuecomment-2053889607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Doc] Tracking issue for contribution guide [pulsar]
tisonkun closed issue #18272: [Doc] Tracking issue for contribution guide URL: https://github.com/apache/pulsar/issues/18272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Doc] Tracking issue for contribution guide [pulsar]
tisonkun commented on issue #18272: URL: https://github.com/apache/pulsar/issues/18272#issuecomment-2053889607 Most done. Others are abandon from my personal motivation. Closing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(pulsar-site) branch main updated: Docs sync done from apache/pulsar (#7009071)
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 280481c30ea3 Docs sync done from apache/pulsar (#7009071) 280481c30ea3 is described below commit 280481c30ea3bfbcb3c93c091fd8c131a5e73065 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> AuthorDate: Sun Apr 14 01:38:26 2024 + Docs sync done from apache/pulsar (#7009071) --- .../next/config/reference-configuration-pulsar-proxy.md | 12 1 file changed, 12 insertions(+) diff --git a/static/reference/next/config/reference-configuration-pulsar-proxy.md b/static/reference/next/config/reference-configuration-pulsar-proxy.md index 3fe9741c9c01..655b98e5dc51 100644 --- a/static/reference/next/config/reference-configuration-pulsar-proxy.md +++ b/static/reference/next/config/reference-configuration-pulsar-proxy.md @@ -338,6 +338,18 @@ Http directs to redirect to non-pulsar services **Category**: HTTP +### metricsServletTimeoutMs +Time in milliseconds that metrics endpoint would time out. Default is 30s. + Set it to 0 to disable timeout. + +**Type**: `long` + +**Default**: `3` + +**Dynamic**: `false` + +**Category**: HTTP + ### brokerClientSslProvider The TLS Provider used by the Pulsar proxy to authenticate with Pulsar brokers
(pulsar-client-python) branch main updated: Bumped version to 3.6.0a1 (#210)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-python.git The following commit(s) were added to refs/heads/main by this push: new e1e74c6 Bumped version to 3.6.0a1 (#210) e1e74c6 is described below commit e1e74c696305516fb41860727d8c46903d5a8800 Author: Yunze Xu AuthorDate: Sun Apr 14 01:00:53 2024 +0800 Bumped version to 3.6.0a1 (#210) --- pulsar/__about__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pulsar/__about__.py b/pulsar/__about__.py index e891b1b..d4148e5 100644 --- a/pulsar/__about__.py +++ b/pulsar/__about__.py @@ -16,4 +16,4 @@ # specific language governing permissions and limitations # under the License. # -__version__='3.5.0a1' +__version__='3.6.0a1'
Re: [PR] Bumped version to 3.6.0a1 [pulsar-client-python]
merlimat merged PR #210: URL: https://github.com/apache/pulsar-client-python/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(pulsar) branch master updated: [fix][broker] Optimize /metrics, fix unbounded request queue issue and fix race conditions in metricsBufferResponse mode (#22494)
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 7009071b6d5 [fix][broker] Optimize /metrics, fix unbounded request
queue issue and fix race conditions in metricsBufferResponse mode (#22494)
7009071b6d5 is described below
commit 7009071b6d53bbc3d740ea99cdc0c010692679ab
Author: Lari Hotari
AuthorDate: Sat Apr 13 10:00:23 2024 -0700
[fix][broker] Optimize /metrics, fix unbounded request queue issue and fix
race conditions in metricsBufferResponse mode (#22494)
---
conf/proxy.conf| 6 +-
.../PrometheusMetricsGeneratorUtils.java | 2 +-
.../stats/prometheus/PrometheusMetricsServlet.java | 149 +++---
.../org/apache/pulsar/broker/stats/TimeWindow.java | 94 --
.../org/apache/pulsar/broker/stats/WindowWrap.java | 56
.../broker/stats/prometheus/MetricsExports.java| 68 +
.../stats/prometheus/PrometheusMetricStreams.java | 2 +-
.../prometheus/PrometheusMetricsGenerator.java | 328 -
.../prometheus/PulsarPrometheusMetricsServlet.java | 140 -
.../pulsar/broker/stats/prometheus/TopicStats.java | 12 +-
.../apache/pulsar/PrometheusMetricsTestUtil.java | 84 ++
.../persistent/BucketDelayedDeliveryTest.java | 6 +-
.../service/persistent/PersistentTopicTest.java| 4 +-
.../broker/service/schema/SchemaServiceTest.java | 4 +-
.../pulsar/broker/stats/ConsumerStatsTest.java | 4 +-
.../broker/stats/MetadataStoreStatsTest.java | 6 +-
.../pulsar/broker/stats/PrometheusMetricsTest.java | 120
.../pulsar/broker/stats/SubscriptionStatsTest.java | 4 +-
.../apache/pulsar/broker/stats/TimeWindowTest.java | 83 --
.../broker/stats/TransactionMetricsTest.java | 18 +-
.../buffer/TransactionBufferClientTest.java| 4 +-
.../pendingack/PendingAckPersistentTest.java | 4 +-
.../apache/pulsar/broker/web/WebServiceTest.java | 4 +-
.../pulsar/common/util/SimpleTextOutputStream.java | 16 +-
.../pulsar/proxy/server/ProxyConfiguration.java| 6 +
.../apache/pulsar/proxy/server/ProxyService.java | 3 +-
.../pulsar/proxy/server/ProxyServiceStarter.java | 40 ++-
27 files changed, 739 insertions(+), 528 deletions(-)
diff --git a/conf/proxy.conf b/conf/proxy.conf
index 8285e1cb753..5a9d433f39c 100644
--- a/conf/proxy.conf
+++ b/conf/proxy.conf
@@ -376,5 +376,7 @@ zooKeeperCacheExpirySeconds=-1
enableProxyStatsEndpoints=true
# Whether the '/metrics' endpoint requires authentication. Defaults to true
authenticateMetricsEndpoint=true
-# Enable cache metrics data, default value is false
-metricsBufferResponse=false
+# Time in milliseconds that metrics endpoint would time out. Default is 30s.
+# Set it to 0 to disable timeout.
+metricsServletTimeoutMs=3
+
diff --git
a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGeneratorUtils.java
b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGeneratorUtils.java
index 828d9871bb3..077d5280b51 100644
---
a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGeneratorUtils.java
+++
b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGeneratorUtils.java
@@ -76,7 +76,7 @@ public class PrometheusMetricsGeneratorUtils {
}
for (int j = 0; j < sample.labelNames.size(); j++) {
String labelValue = sample.labelValues.get(j);
-if (labelValue != null) {
+if (labelValue != null && labelValue.indexOf('"') > -1) {
labelValue = labelValue.replace("\"", "\\\"");
}
if (j > 0) {
diff --git
a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsServlet.java
b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsServlet.java
index 64d1fcdab6f..8a41bed29d4 100644
---
a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsServlet.java
+++
b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsServlet.java
@@ -25,9 +25,13 @@ import java.util.LinkedList;
import java.util.List;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
import javax.servlet.AsyncContext;
+import javax.servlet.AsyncEvent;
+import javax.servlet.AsyncListener;
import javax.servlet.ServletException;
-import javax.servlet.ServletOutputStream;
import javax.servlet.http.HttpSer
Re: [I] [Bug] /metrics endpoint processes requests one-by-one and seems to queue up waiting requests infinitely, ignoring the request timeout [pulsar]
merlimat closed issue #22477: [Bug] /metrics endpoint processes requests one-by-one and seems to queue up waiting requests infinitely, ignoring the request timeout URL: https://github.com/apache/pulsar/issues/22477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][broker] Optimize /metrics, fix unbounded request queue issue and fix race conditions in metricsBufferResponse mode [pulsar]
merlimat merged PR #22494: URL: https://github.com/apache/pulsar/pull/22494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(pulsar-client-python) annotated tag v3.5.0 updated (38737a2 -> f33bdc7)
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to annotated tag v3.5.0 in repository https://gitbox.apache.org/repos/asf/pulsar-client-python.git *** WARNING: tag v3.5.0 was modified! *** from 38737a2 (commit) to f33bdc7 (tag) tagging 38737a24f6ba77fe4efc5321980513ae317920e4 (commit) replaces v3.5.0-candidate-2 by Yunze Xu on Sat Apr 13 23:25:09 2024 +0800 - Log - Release v3.5.0 -BEGIN PGP SIGNATURE- iQJDBAABCgAtFiEEn+m0+KLf1EiRy6J0Qrtq+2zSb6YFAmYao9UPHHh5ekBhcGFj aGUub3JnAAoJEEK7avts0m+mXoAP/2AwepUZ8Oj1ION19zAdvObCcDpcX/1eNIXs Pne85Hq3RzjGoHYms7T4hKWdh5/MNL4VWJ3vZfkAFMf7evx0SQT1j1BK5cVECyfk oPOiRxhJGEctdTUYtcDw5IPAy4g1dkmg9A01CdrpKfuPdLkiRuySqhMo9zkxRhrN 29iNjCjvoFS3eUCQpNCkSkpzpjvUtREtlb/jZV1tIjxONAHb7nrWevL9PQbcLu+7 IOBnYyf6ucNaM9hVUOX3KmPOMUvpbzdVRV5SkkKsYQNAppUiiTYUJ4YEiO2D0z35 N9CRV2A/XbDCwCQxZm024Ew9OLYlc0V8w01uvucSF9NlxKwkdgh3IkFUCs2UNx/N 8B0nuh+r/gVmbF9SXFY2BJhliH2nERG1K4lKy6z7KMNP8qrORTRZ6bqoblr2EJBi NVEqnSRMuH0g8xmI62+4rulJi+eRwE98JCUVuTPhYmpxzBScYl8eW7U9TDHgIIBB D/JXjceMPGBwqkaKKxGJY+PhjCDzeCbARm5H5u3N75/pmxO1Fqd9sNP0+t2sP3tK +1ZTuWF3Kis7iuH+c6HtObgNldN4MhA0JxwhKtXFKZHzgEFJ85NdfmYeAwuasO5l hWuHR1MkBet3fr50m1/n7cSj3reQDfgl3aW7tBNtyqVVWXA4J37SWtEA9SnSieNN wJggIew1 =HRoa -END PGP SIGNATURE- --- No new revisions were added by this update. Summary of changes:
(pulsar-client-python) branch v3.5.0 deleted (was 38737a2)
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch v3.5.0 in repository https://gitbox.apache.org/repos/asf/pulsar-client-python.git was 38737a2 Merge branch 'main' into branch-3.5 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(pulsar-client-python) branch v3.5.0 created (now 38737a2)
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch v3.5.0 in repository https://gitbox.apache.org/repos/asf/pulsar-client-python.git at 38737a2 Merge branch 'main' into branch-3.5 No new revisions were added by this update.
Re: [I] 3.5.0 release? [pulsar-client-python]
BewareMyPower commented on issue #207: URL: https://github.com/apache/pulsar-client-python/issues/207#issuecomment-2053675863 The wheels are available in PyPI now: https://pypi.org/project/pulsar-client/3.5.0/#files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
svn commit: r68476 - /dev/pulsar/pulsar-client-python-3.5.0-candidate-3/ /release/pulsar/pulsar-client-python-3.5.0/
Author: xyz Date: Sat Apr 13 15:08:33 2024 New Revision: 68476 Log: Release Apache Pulsar Client Python 3.5.0 Added: release/pulsar/pulsar-client-python-3.5.0/ - copied from r68475, dev/pulsar/pulsar-client-python-3.5.0-candidate-3/ Removed: dev/pulsar/pulsar-client-python-3.5.0-candidate-3/
[PR] Bumped version to 3.6.0a1 [pulsar-client-python]
BewareMyPower opened a new pull request, #210: URL: https://github.com/apache/pulsar-client-python/pull/210 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][broker] Optimize /metrics, fix unbounded request queue issue and fix race conditions in metricsBufferResponse mode [pulsar]
lhotari commented on PR #22494: URL: https://github.com/apache/pulsar/pull/22494#issuecomment-2053617569 > > One interesting detail is that in the load test, the system couldn't keep up with the load without making the optimization to direct buffer allocation in commit [eb53342](https://github.com/apache/pulsar/commit/eb53342e6a73788e470a1bb13c9722ccb25cc584). > > I guess it is related to CompositeByteBuf#consolidateIfNeeded, once the number of components exceeds MAX_COMPONENT, it will combine all the components to one component, memory copy happens. Memory copying isn't the biggest problem. A bigger problem is direct memory OOM that seems to happen when the memory space is so fragmented that there isn't free space for the allocation requests. The Netty pool has a maximum chunk size (8MB default) and all larger allocations are huge allocations that aren't pooled. That's why I think the added logic helps since it pre-allocates up to 8MB chunks. Memory copying will happen, but that seems to be fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][broker] Optimize /metrics, fix unbounded request queue issue and fix race conditions in metricsBufferResponse mode [pulsar]
dao-jun commented on PR #22494: URL: https://github.com/apache/pulsar/pull/22494#issuecomment-2053612386 > One interesting detail is that in the load test, the system couldn't keep up with the load without making the optimization to direct buffer allocation in commit [eb53342](https://github.com/apache/pulsar/commit/eb53342e6a73788e470a1bb13c9722ccb25cc584). I guess it is related to CompositeByteBuf#consolidateIfNeeded, once the number of components exceeds MAX_COMPONENT, it will combine all the components to one component, memory copy happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
svn commit: r68474 - /dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/
Author: baodi Date: Sat Apr 13 09:21:38 2024 New Revision: 68474 Log: Staging artifacts and signature for Pulsar Node.js client release 1.11.0-rc.4 Added: dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/ dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/apache-pulsar-client-node-1.11.0.tar.gz (with props) dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/apache-pulsar-client-node-1.11.0.tar.gz.asc dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/apache-pulsar-client-node-1.11.0.tar.gz.sha512 dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-darwin-unknown-arm64.tar.gz (with props) dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-darwin-unknown-arm64.tar.gz.asc dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-darwin-unknown-arm64.tar.gz.sha512 dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-darwin-unknown-x64.tar.gz (with props) dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-darwin-unknown-x64.tar.gz.asc dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-darwin-unknown-x64.tar.gz.sha512 dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-linux-glibc-arm64.tar.gz (with props) dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-linux-glibc-arm64.tar.gz.asc dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-linux-glibc-arm64.tar.gz.sha512 dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-linux-glibc-x64.tar.gz (with props) dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-linux-glibc-x64.tar.gz.asc dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-linux-glibc-x64.tar.gz.sha512 dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-linux-musl-arm64.tar.gz (with props) dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-linux-musl-arm64.tar.gz.asc dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-linux-musl-arm64.tar.gz.sha512 dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-linux-musl-x64.tar.gz (with props) dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-linux-musl-x64.tar.gz.asc dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-linux-musl-x64.tar.gz.sha512 dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-win32-unknown-ia32.tar.gz (with props) dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-win32-unknown-ia32.tar.gz.asc dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-win32-unknown-ia32.tar.gz.sha512 dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-win32-unknown-x64.tar.gz (with props) dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-win32-unknown-x64.tar.gz.asc dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/napi-win32-unknown-x64.tar.gz.sha512 Added: dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/apache-pulsar-client-node-1.11.0.tar.gz == Binary file - no diff available. Propchange: dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/apache-pulsar-client-node-1.11.0.tar.gz -- svn:mime-type = application/octet-stream Added: dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/apache-pulsar-client-node-1.11.0.tar.gz.asc == --- dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/apache-pulsar-client-node-1.11.0.tar.gz.asc (added) +++ dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/apache-pulsar-client-node-1.11.0.tar.gz.asc Sat Apr 13 09:21:38 2024 @@ -0,0 +1,16 @@ +-BEGIN PGP SIGNATURE- + +iQIzBAABCgAdFiEEnbUbKJ6SOn3CcPqaYxrD/PIvSAoFAmYaTmkACgkQYxrD/PIv +SAoy3RAAvgqpUwVcZJVvFFHltcfs4TxlacFw2G8pwDbd4qQVdTI+OTHyjo5oGwJo +PIOzWUWIm5d3veTYU2+kWrmU3yaoVU9OEFckN4yZNhSYlGyCumaTCvAT2yNQuaf9 +iydWdwtGvnGLqa6W1LZ2ZZj2FQ71TxRNWKECKkf5dG+Ju+qOHfTyV9Qvx1dG41IR +Aln0A+b0rSFE8eFldsKFJm0wi4gFlB2DnjX28jhpzGRrNmHF8CgCNzNzcktHtObW +G2g19oj9Up8t9hhqwk8akUZF56D3yk4m8EiPYp+KjWXbe9sFoa1Sgp60iHyq36sb +n2g7fgoHXn4crzng0s8QF1eNz9QUEQLYt/Kx1tSCrI+yYCjAivT61sX5VMR32krd +h/iDdDUATriB4iNsEVB6DjaevQfA8vp95GhdrXs0SIODfq0ENd8TW2CY2uTtxssQ +kLSr9mLL6ymw5nBY/HBSEki6IztJxjIjQ6F7RWkeDAscmJhCKD9xh09wmDe4xw6U +BGrK9tiiTGSWYNclh1+iufsb23PW5H+qGAN2SOpcfKvZU66sg/L7Mpe4AokQ/BVy +Nywog5TSJNRl6xym3xP6URojcen5pNksZV78NuT7gDjprl1ovQk0+Xj+fRwLnpJX +1yOvxPcWcJSi4e7c/NI0xUd86uxQvJNbDqM8SeqmsumO/KEWt2c= +=oLLm +-END PGP SIGNATURE- Added: dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.4/apache-pulsar-client-node-1.11.0.tar.gz.sha512 ==
Re: [PR] [fix][broker] Optimize /metrics, fix unbounded request queue issue and fix race conditions in metricsBufferResponse mode [pulsar]
github-advanced-security[bot] commented on code in PR #22494:
URL: https://github.com/apache/pulsar/pull/22494#discussion_r1563884550
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGenerator.java:
##
@@ -220,10 +176,34 @@
//if exception happens, release buffer
if (exceptionHappens) {
buf.release();
+} else {
+// for the next time, the initial buffer size will be
suggested by the last buffer size
+initialBufferSize = Math.max(DEFAULT_INITIAL_BUFFER_SIZE,
buf.readableBytes());
}
}
}
+private ByteBuf allocateMultipartCompositeDirectBuffer() {
+// use composite buffer with pre-allocated buffers to ensure that the
pooled allocator can be used
+// for allocating the buffers
+ByteBufAllocator byteBufAllocator = PulsarByteBufAllocator.DEFAULT;
+long chunkSize;
+if (byteBufAllocator instanceof PooledByteBufAllocator) {
+PooledByteBufAllocator pooledByteBufAllocator =
(PooledByteBufAllocator) byteBufAllocator;
+chunkSize = Math.max(pooledByteBufAllocator.metric().chunkSize(),
DEFAULT_INITIAL_BUFFER_SIZE);
+} else {
+chunkSize = DEFAULT_INITIAL_BUFFER_SIZE;
+}
+CompositeByteBuf buf = byteBufAllocator.compositeDirectBuffer(
+Math.max(MINIMUM_FOR_MAX_COMPONENTS, (int) (initialBufferSize
/ chunkSize) + 1));
+int totalLen = 0;
+while (totalLen < initialBufferSize) {
+totalLen += chunkSize;
Review Comment:
## Implicit narrowing conversion in compound assignment
Implicit cast of source type long to narrower destination type int.
[Show more
details](https://github.com/apache/pulsar/security/code-scanning/116)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [fix] [broker] Prevent long deduplication cursor backlog so that topic loading wouldn't timeout [pulsar]
kristgpt commented on PR #22479: URL: https://github.com/apache/pulsar/pull/22479#issuecomment-2053576863 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(pulsar-client-node) annotated tag v1.11.0-rc.4 updated (4c39024 -> 7cb21a5)
This is an automated email from the ASF dual-hosted git repository. baodi pushed a change to annotated tag v1.11.0-rc.4 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git *** WARNING: tag v1.11.0-rc.4 was modified! *** from 4c39024 (commit) to 7cb21a5 (tag) tagging 4c39024b86c578b3c7cf24d7ace62bc3b4fa8a60 (commit) replaces v1.11.0-rc.3 by Baodi Shi on Sat Apr 13 16:12:58 2024 +0800 - Log - Release v1.11.0-rc.4 -BEGIN PGP SIGNATURE- iQJFBAABCgAvFiEEnbUbKJ6SOn3CcPqaYxrD/PIvSAoFAmYaPooRHGJhb2RpQGFw YWNoZS5vcmcACgkQYxrD/PIvSAoQRxAAuvDzvq0AmJeL+LmQb3diP2Pv58Ao8Ovx 1LP5gk4uMfHokmGJSAOZINFxz4pZzaDFtoRhX2aSb+bx1rBJ2RjOv/OP5u/ZeY7Q OgJrBcmuEkoBQqjiRK2hpOVM+if6XXGZaGdNIXT9t2uWB06a4p8QE6gNqZ3S2WL8 zxOht4nNfumrNYQcPxKsryKdsJkFwflgWVcJ6Wp7O4XxYAq0CCCOG0kugUcoE6F9 Ecm+xinWS+Z6Kp3fWgrOUyMIsgjUfqa/edLiUBrG0JQTN3ri+Gze4MN5NiMf5C2y iwnSbdRyj5Rv1w2Fa21JkdgABoLDMX+RI+3eo55WGWdkqjG/WCw2f6Lut8fzM+LM 2QmwdmejGGJQNFRXzjyqu6lMWjMycFatRWQunBWnbr7xEts25Pp1qdYesQcpCCB+ N0blISvJKybHAMLUIDPdXetQmNremOoACzUClvxi4F9G9p+4h2BshYlCn+HZR+Oo jqYYHqn8MyOfd2Ff/ltNXZ6bxsZVYKNiWqrUlzRbESbymFva2wdNixl0FhVzDBe/ ZgOaeCKK6I9fD8m5xF/mbuXnc02iiK03fQdVjydgkdN4XaQfo88KVeD5itsvmJEj q3eXon+CcCp1RnON33slqameP8VYPqsuCs4oGfKTvZnHJ13n8vNB9qPQeTyOVUSC mUy/4nk4tB4= =M4m2 -END PGP SIGNATURE- --- No new revisions were added by this update. Summary of changes:
(pulsar-client-node) branch branch-1.11 updated: fix: Compatible with Node 12.3.0 and higher versions. (#378)
This is an automated email from the ASF dual-hosted git repository.
baodi pushed a commit to branch branch-1.11
in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git
The following commit(s) were added to refs/heads/branch-1.11 by this push:
new 4c39024 fix: Compatible with Node 12.3.0 and higher versions. (#378)
4c39024 is described below
commit 4c39024b86c578b3c7cf24d7ace62bc3b4fa8a60
Author: Baodi Shi
AuthorDate: Sat Apr 13 15:56:55 2024 +0800
fix: Compatible with Node 12.3.0 and higher versions. (#378)
(cherry picked from commit 2d659d2b2850fc92ec58ff700e04f966b0771e6a)
---
README.md | 5 +++--
package.json | 2 +-
src/Client.js | 9 -
3 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/README.md b/README.md
index ac92e2d..5d8cd37 100644
--- a/README.md
+++ b/README.md
@@ -23,8 +23,9 @@
The Pulsar Node.js client can be used to create Pulsar producers and consumers
in Node.js. For the supported Pulsar features, see [Client Feature
Matrix](https://pulsar.apache.org/client-feature-matrix/).
-This library works only in Node.js 10.x or later because it uses the
-[node-addon-api](https://github.com/nodejs/node-addon-api) module to wrap the
C++ library.
+This library works only in Node.js 12.3 or later because it uses:
+1. The [node-addon-api](https://github.com/nodejs/node-addon-api) module to
wrap the C++ library.
+2. The [Mozilla CA](https://nodejs.org/api/tls.html#tlsrootcertificates) file,
which is provided by Node.js v12.3.0 and subsequent versions.
## Getting Started
diff --git a/package.json b/package.json
index 271b4e7..ade792f 100644
--- a/package.json
+++ b/package.json
@@ -32,7 +32,7 @@
"license": "Apache-2.0",
"gypfile": true,
"engines": {
-"node": ">=10.16.0"
+"node": ">=12.3.0"
},
"devDependencies": {
"@seadub/clang-format-lint": "0.0.2",
diff --git a/src/Client.js b/src/Client.js
index 2ddbfc1..f51b1b6 100644
--- a/src/Client.js
+++ b/src/Client.js
@@ -57,7 +57,14 @@ class Client {
}
static genCertFile() {
-fs.rmSync(certsFilePath, { force: true });
+try {
+ if (fs.existsSync(certsFilePath)) {
+fs.unlinkSync(certsFilePath);
+ }
+} catch (err) {
+ console.error(err);
+}
+
const fd = fs.openSync(certsFilePath, 'a');
try {
tls.rootCertificates.forEach((cert) => {
Re: [PR] fix: Compatible with Node 12.3.0 and higher versions. [pulsar-client-node]
shibd merged PR #378: URL: https://github.com/apache/pulsar-client-node/pull/378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(pulsar-client-node) branch master updated: fix: Compatible with Node 12.3.0 and higher versions. (#378)
This is an automated email from the ASF dual-hosted git repository.
baodi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git
The following commit(s) were added to refs/heads/master by this push:
new 2d659d2 fix: Compatible with Node 12.3.0 and higher versions. (#378)
2d659d2 is described below
commit 2d659d2b2850fc92ec58ff700e04f966b0771e6a
Author: Baodi Shi
AuthorDate: Sat Apr 13 15:56:55 2024 +0800
fix: Compatible with Node 12.3.0 and higher versions. (#378)
---
README.md | 5 +++--
package.json | 2 +-
src/Client.js | 9 -
3 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/README.md b/README.md
index ac92e2d..5d8cd37 100644
--- a/README.md
+++ b/README.md
@@ -23,8 +23,9 @@
The Pulsar Node.js client can be used to create Pulsar producers and consumers
in Node.js. For the supported Pulsar features, see [Client Feature
Matrix](https://pulsar.apache.org/client-feature-matrix/).
-This library works only in Node.js 10.x or later because it uses the
-[node-addon-api](https://github.com/nodejs/node-addon-api) module to wrap the
C++ library.
+This library works only in Node.js 12.3 or later because it uses:
+1. The [node-addon-api](https://github.com/nodejs/node-addon-api) module to
wrap the C++ library.
+2. The [Mozilla CA](https://nodejs.org/api/tls.html#tlsrootcertificates) file,
which is provided by Node.js v12.3.0 and subsequent versions.
## Getting Started
diff --git a/package.json b/package.json
index 22b825c..87a5059 100644
--- a/package.json
+++ b/package.json
@@ -32,7 +32,7 @@
"license": "Apache-2.0",
"gypfile": true,
"engines": {
-"node": ">=10.16.0"
+"node": ">=12.3.0"
},
"devDependencies": {
"@seadub/clang-format-lint": "0.0.2",
diff --git a/src/Client.js b/src/Client.js
index 2ddbfc1..f51b1b6 100644
--- a/src/Client.js
+++ b/src/Client.js
@@ -57,7 +57,14 @@ class Client {
}
static genCertFile() {
-fs.rmSync(certsFilePath, { force: true });
+try {
+ if (fs.existsSync(certsFilePath)) {
+fs.unlinkSync(certsFilePath);
+ }
+} catch (err) {
+ console.error(err);
+}
+
const fd = fs.openSync(certsFilePath, 'a');
try {
tls.rootCertificates.forEach((cert) => {
Re: [PR] Cherry-pick from apache/3.0 to 3.1_ds [pulsar]
mukesh-ctds closed pull request #22499: Cherry-pick from apache/3.0 to 3.1_ds URL: https://github.com/apache/pulsar/pull/22499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Cherry-pick from apache/3.0 to 3.1_ds [pulsar]
mukesh-ctds opened a new pull request, #22499: URL: https://github.com/apache/pulsar/pull/22499 Fixes #xyz Main Issue: #xyz PIP: #xyz ### Motivation ### Modifications ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Cherry-pick from apache/3.0 to 3.1_ds [pulsar]
github-actions[bot] commented on PR #22499: URL: https://github.com/apache/pulsar/pull/22499#issuecomment-2053554481 @mukesh-ctds Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
