Re: [PR] [fix][broker] fix replicated subscriptions for transactional messages [pulsar]
thetumbled commented on PR #22452: URL: https://github.com/apache/pulsar/pull/22452#issuecomment-2094000170 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(pulsar) branch master updated: [improve][build] Upgrade OTel library versions (#22649)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2821afad7a1 [improve][build] Upgrade OTel library versions (#22649) 2821afad7a1 is described below commit 2821afad7a1fff056e4f04f71934dcd8c01fbcb1 Author: Lari Hotari AuthorDate: Sat May 4 02:48:02 2024 +0300 [improve][build] Upgrade OTel library versions (#22649) --- distribution/server/src/assemble/LICENSE.bin.txt | 51 +++--- distribution/shell/src/assemble/LICENSE.bin.txt| 6 +-- pom.xml| 20 ++--- pulsar-broker/pom.xml | 6 --- pulsar-client/pom.xml | 2 +- .../apache/pulsar/client/impl/metrics/Counter.java | 2 +- .../client/impl/metrics/LatencyHistogram.java | 2 +- .../pulsar/client/impl/metrics/UpDownCounter.java | 2 +- 8 files changed, 47 insertions(+), 44 deletions(-) diff --git a/distribution/server/src/assemble/LICENSE.bin.txt b/distribution/server/src/assemble/LICENSE.bin.txt index c5c243796b6..aec4df2a93a 100644 --- a/distribution/server/src/assemble/LICENSE.bin.txt +++ b/distribution/server/src/assemble/LICENSE.bin.txt @@ -338,12 +338,12 @@ The Apache Software License, Version 2.0 - io.prometheus-simpleclient_tracer_otel-0.16.0.jar - io.prometheus-simpleclient_tracer_otel_agent-0.16.0.jar * Prometheus exporter -- io.prometheus-prometheus-metrics-config-1.1.0.jar -- io.prometheus-prometheus-metrics-exporter-common-1.1.0.jar -- io.prometheus-prometheus-metrics-exporter-httpserver-1.1.0.jar -- io.prometheus-prometheus-metrics-exposition-formats-1.1.0.jar -- io.prometheus-prometheus-metrics-model-1.1.0.jar -- io.prometheus-prometheus-metrics-shaded-protobuf-1.1.0.jar +- io.prometheus-prometheus-metrics-config-1.2.1.jar +- io.prometheus-prometheus-metrics-exporter-common-1.2.1.jar +- io.prometheus-prometheus-metrics-exporter-httpserver-1.2.1.jar +- io.prometheus-prometheus-metrics-exposition-formats-1.2.1.jar +- io.prometheus-prometheus-metrics-model-1.2.1.jar +- io.prometheus-prometheus-metrics-shaded-protobuf-1.2.1.jar * Jakarta Bean Validation API - jakarta.validation-jakarta.validation-api-2.0.2.jar - javax.validation-validation-api-1.1.0.Final.jar @@ -524,26 +524,25 @@ The Apache Software License, Version 2.0 - org.roaringbitmap-RoaringBitmap-0.9.44.jar - org.roaringbitmap-shims-0.9.44.jar * OpenTelemetry -- io.opentelemetry-opentelemetry-api-1.34.1.jar -- io.opentelemetry-opentelemetry-api-events-1.34.1-alpha.jar -- io.opentelemetry-opentelemetry-context-1.34.1.jar -- io.opentelemetry-opentelemetry-exporter-common-1.34.1.jar -- io.opentelemetry-opentelemetry-exporter-otlp-1.34.1.jar -- io.opentelemetry-opentelemetry-exporter-otlp-common-1.34.1.jar -- io.opentelemetry-opentelemetry-exporter-prometheus-1.34.1-alpha.jar -- io.opentelemetry-opentelemetry-exporter-sender-okhttp-1.34.1.jar -- io.opentelemetry-opentelemetry-extension-incubator-1.34.1-alpha.jar -- io.opentelemetry-opentelemetry-sdk-1.34.1.jar -- io.opentelemetry-opentelemetry-sdk-common-1.34.1.jar -- io.opentelemetry-opentelemetry-sdk-extension-autoconfigure-1.34.1.jar -- io.opentelemetry-opentelemetry-sdk-extension-autoconfigure-spi-1.34.1.jar -- io.opentelemetry-opentelemetry-sdk-logs-1.34.1.jar -- io.opentelemetry-opentelemetry-sdk-metrics-1.34.1.jar -- io.opentelemetry-opentelemetry-sdk-trace-1.34.1.jar -- io.opentelemetry.instrumentation-opentelemetry-instrumentation-api-1.32.1.jar -- io.opentelemetry.instrumentation-opentelemetry-instrumentation-api-semconv-1.32.1-alpha.jar -- io.opentelemetry.instrumentation-opentelemetry-resources-1.32.1-alpha.jar -- io.opentelemetry.semconv-opentelemetry-semconv-1.23.1-alpha.jar +- io.opentelemetry-opentelemetry-api-1.37.0.jar +- io.opentelemetry-opentelemetry-api-incubator-1.37.0-alpha.jar +- io.opentelemetry-opentelemetry-context-1.37.0.jar +- io.opentelemetry-opentelemetry-exporter-common-1.37.0.jar +- io.opentelemetry-opentelemetry-exporter-otlp-1.37.0.jar +- io.opentelemetry-opentelemetry-exporter-otlp-common-1.37.0.jar +- io.opentelemetry-opentelemetry-exporter-prometheus-1.37.0-alpha.jar +- io.opentelemetry-opentelemetry-exporter-sender-okhttp-1.37.0.jar +- io.opentelemetry-opentelemetry-sdk-1.37.0.jar +- io.opentelemetry-opentelemetry-sdk-common-1.37.0.jar +- io.opentelemetry-opentelemetry-sdk-extension-autoconfigure-1.37.0.jar +- io.opentelemetry-opentelemetry-sdk-extension-autoconfigure-spi-1.37.0.jar +- io.opentelemetry-opentelemetry-sdk-logs-1.37.0.jar +- io.opentelemetry-opentelemetry-sdk-metrics-1.37.0.jar +- io.opentelemetry-opentelemetry-sdk-trace-1.37.0.j
Re: [PR] [improve][build] Upgrade OTel library versions [pulsar]
merlimat merged PR #22649: URL: https://github.com/apache/pulsar/pull/22649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [improve][build] Upgrade OTel library versions [pulsar]
codecov-commenter commented on PR #22649: URL: https://github.com/apache/pulsar/pull/22649#issuecomment-2093871510 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22649?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 72.73%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`f758408`)](https://app.codecov.io/gh/apache/pulsar/pull/22649?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 222 commits behind head on master. Additional details and impacted files [](https://app.codecov.io/gh/apache/pulsar/pull/22649?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #22649 +/- ## - Coverage 73.57% 72.73% -0.85% + Complexity3262432554 -70 Files 1877 1887 +10 Lines139502 141014+1512 Branches 1529915478 +179 - Hits 102638 102565 -73 - Misses2890830587+1679 + Partials 7956 7862 -94 ``` | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/22649/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/22649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.20% <ø> (+2.62%)` | :arrow_up: | | [systests](https://app.codecov.io/gh/apache/pulsar/pull/22649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.68% <ø> (+0.35%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/22649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `71.48% <ø> (-1.37%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/apache/pulsar/pull/22649?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...org/apache/pulsar/client/impl/metrics/Counter.java](https://app.codecov.io/gh/apache/pulsar/pull/22649?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2Fmetrics%2FCounter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL21ldHJpY3MvQ291bnRlci5qYXZh) | `100.00% <ø> (ø)` | | | [...e/pulsar/client/impl/metrics/LatencyHistogram.java](https://app.codecov.io/gh/apache/pulsar/pull/22649?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2Fmetrics%2FLatencyHistogram.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL21ldHJpY3MvTGF0ZW5jeUhpc3RvZ3JhbS5qYXZh) | `95.34% <ø> (ø)` | | | [...ache/pulsar/client/impl/metrics/UpDownCounter.java](https://app.codecov.io/gh/apache/pulsar/pull/22649?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2Fmetrics%2FUpDownCounter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL21ldHJpY3MvVXBEb3duQ291bnRlci5qYXZh) | `95.00% <ø> (ø)` | | ... and [335 files with indirect coverage changes](https:/
[PR] [improve][build] Upgrade OTel library versions [pulsar]
lhotari opened a new pull request, #22649: URL: https://github.com/apache/pulsar/pull/22649 ### Motivation In Pulsar, a long waited improvement to Otel, metric exporter REUSABLE_DATA memory mode, contributed by @asafm has been released in 1.37.0 version. In addition, it's a good practice to stay updated with the experimental API changes within OTel. For example, in 1.37.0, the opentelemetry-extension-incubator got renamed to opentelemetry-api-incubator and the package name also changed. This impacts the Pulsar client OTel support (PIP-342, #22179). ### Modifications - upgrades - opentelemetry.version: 1.34.1 -> 1.37.0 - opentelemetry.instrumentation.version: 1.32.1-alpha -> 1.33.2 - opentelemetry.semconv.version: 1.23.1-alpha -> 1.25.0-alpha - start using opentelemetry-instrumentation-bom / opentelemetry-instrumentation-bom-alpha - adapt to breaking changes ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][sec] Upgrade Debezium oracle connector version to avoid CVE-2023-4586 [pulsar]
lhotari commented on PR #22641: URL: https://github.com/apache/pulsar/pull/22641#issuecomment-2093785902 Just wondering that we are upgrading this connector to a newer Debezium version than the others. It seems like a hack. I wonder why we are sticking to an old Debezium version for others. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(pulsar) branch master updated: [fix][sec] Upgrade elasticsearch-java version to avoid CVE-2023-4043 (#22640)
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3ca4ddfc8fe [fix][sec] Upgrade elasticsearch-java version to avoid CVE-2023-4043 (#22640) 3ca4ddfc8fe is described below commit 3ca4ddfc8fecab633b473e48e1a6f78adcfbd4df Author: Nikhil Erigila <60037808+nikhilerigil...@users.noreply.github.com> AuthorDate: Sat May 4 02:51:48 2024 +0530 [fix][sec] Upgrade elasticsearch-java version to avoid CVE-2023-4043 (#22640) --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 4bfdc54e55d..7507a5cb28b 100644 --- a/pom.xml +++ b/pom.xml @@ -196,7 +196,7 @@ flexible messaging model and an intuitive client API. 3.3.5 2.4.10 1.2.4 -8.5.2 +8.12.1 1.9.7.Final 2.2.0.Final 42.5.0
Re: [PR] [fix][sec] Upgrade elasticsearch-java version to avoid CVE-2023-4043 [pulsar]
lhotari merged PR #22640: URL: https://github.com/apache/pulsar/pull/22640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Eclipse Parsson has a vulnerability CVE-2023-4043 [pulsar]
lhotari closed issue #21783: [Bug] Eclipse Parsson has a vulnerability CVE-2023-4043 URL: https://github.com/apache/pulsar/issues/21783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][sec] Upgrade elasticsearch-java version to avoid CVE-2023-4043 [pulsar]
codecov-commenter commented on PR #22640: URL: https://github.com/apache/pulsar/pull/22640#issuecomment-2093753323 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22640?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 72.71%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`cbc14a9`)](https://app.codecov.io/gh/apache/pulsar/pull/22640?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 221 commits behind head on master. Additional details and impacted files [](https://app.codecov.io/gh/apache/pulsar/pull/22640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #22640 +/- ## - Coverage 73.57% 72.71% -0.86% + Complexity3262432338 -286 Files 1877 1887 +10 Lines139502 141006+1504 Branches 1529915478 +179 - Hits 102638 102537 -101 - Misses2890830608+1700 + Partials 7956 7861 -95 ``` | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/22640/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/22640/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.31% <ø> (+2.72%)` | :arrow_up: | | [systests](https://app.codecov.io/gh/apache/pulsar/pull/22640/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.57% <ø> (+0.24%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/22640/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `71.49% <ø> (-1.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 338 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/22640/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [feat][broker] PIP-264: Add Java runtime metrics [pulsar]
lhotari commented on PR #22616: URL: https://github.com/apache/pulsar/pull/22616#issuecomment-2093736097 There were quite a few OOMs in that last runs. I'll close and reopen to see if they were originating from the changes made in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [feat][broker] PIP-264: Add Java runtime metrics [pulsar]
lhotari closed pull request #22616: [feat][broker] PIP-264: Add Java runtime metrics URL: https://github.com/apache/pulsar/pull/22616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][sec] Upgrade postgresql version to avoid CVE-2024-1597 [pulsar]
lhotari commented on PR #22635: URL: https://github.com/apache/pulsar/pull/22635#issuecomment-2093733435 @nikhilerigila09 There's a merge conflict and this PR has been created without [allowing edits from maintainers](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork), so you'd have to do the merge conflict resolution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: support seeding default superuser via application.properties [pulsar-manager]
maranmaran commented on PR #565: URL: https://github.com/apache/pulsar-manager/pull/565#issuecomment-2093730646 👋 👋 @lhotari Hey man, some tiny hiccups, I just adjusted my IDE and am good to go. The build and tests should be okay now (`./gradlew build ✅ `). I have another [branch ready to update docs](https://github.com/maranmaran/pulsar-manager/tree/docs/default-superuser?tab=readme-ov-file#setting-up-super-user) about this change. Additionally, I have experienced this https://github.com/apache/pulsar-manager/issues/567 and I can't run the backend. I have some proposal fix for it. Would you be so kind and just put some 👀 on the GH issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Infinispan Client Hotrod has a vulnerability CVE-2023-4586 [pulsar]
lhotari closed issue #22626: [Bug] Infinispan Client Hotrod has a vulnerability CVE-2023-4586 URL: https://github.com/apache/pulsar/issues/22626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(pulsar) branch master updated: [fix][sec] Upgrade Debezium oracle connector version to avoid CVE-2023-4586 (#22641)
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 4a5953640fd [fix][sec] Upgrade Debezium oracle connector version to
avoid CVE-2023-4586 (#22641)
4a5953640fd is described below
commit 4a5953640fd93f8ecac39c7713851ac4c1ab902b
Author: Nikhil Erigila <60037808+nikhilerigil...@users.noreply.github.com>
AuthorDate: Sat May 4 02:00:28 2024 +0530
[fix][sec] Upgrade Debezium oracle connector version to avoid CVE-2023-4586
(#22641)
---
pom.xml | 1 +
pulsar-io/debezium/oracle/pom.xml | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/pom.xml b/pom.xml
index 048bc952466..4bfdc54e55d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -198,6 +198,7 @@ flexible messaging model and an intuitive client
API.
1.2.4
8.5.2
1.9.7.Final
+2.2.0.Final
42.5.0
8.0.30
diff --git a/pulsar-io/debezium/oracle/pom.xml
b/pulsar-io/debezium/oracle/pom.xml
index c69640ecff7..b22a5785dfb 100644
--- a/pulsar-io/debezium/oracle/pom.xml
+++ b/pulsar-io/debezium/oracle/pom.xml
@@ -48,7 +48,8 @@
io.debezium
debezium-connector-oracle
- ${debezium.version}
+ ${debezium.oracle.version}
+ runtime
Re: [PR] [fix][sec] Upgrade Debezium oracle connector version to avoid CVE-2023-4586 [pulsar]
lhotari merged PR #22641: URL: https://github.com/apache/pulsar/pull/22641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [D] consumer created multiple subscriptions wrongly [pulsar]
GitHub user visortelle added a comment to the discussion: consumer created multiple subscriptions wrongly @wallacepeng from the stats you provided, I see a single subscription with multiple consumers. If it is a partitioned topic, could you check if the number of consumers equals the number of partitions? GitHub link: https://github.com/apache/pulsar/discussions/22648#discussioncomment-9309416 This is an automatically sent email for commits@pulsar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@pulsar.apache.org
Re: [D] consumer created multiple subscriptions wrongly [pulsar]
GitHub user visortelle edited a comment on the discussion: consumer created multiple subscriptions wrongly @wallacepeng from the stats you provided, I see a single subscription with multiple consumers. If it is a partitioned topic, could you check if the number of consumers equals the number of active partitions? GitHub link: https://github.com/apache/pulsar/discussions/22648#discussioncomment-9309416 This is an automatically sent email for commits@pulsar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@pulsar.apache.org
[I] Following readme to run backend fails with latest [pulsar-manager]
maranmaran opened a new issue, #567: URL: https://github.com/apache/pulsar-manager/issues/567 Steps: ``` cd pulsar-manager ./gradlew build -x test cd build/distributions unzip pulsar-manager.zip or tar -zxvf pulsar-manager.tar ./pulsar-manager/bin/pulsar-manager ``` Result: ``` *** APPLICATION FAILED TO START *** Description: The dependencies of some of the beans in the application context form a cycle: bookiesController defined in URL [jar:file:/mnt/c/Repos/Personal/pulsar-manager/build/distributions/pulsar-manager/lib/pulsar-manager.jar!/org/apache/pulsar/manager/controller/BookiesController.class] ↓ bookiesServiceImpl defined in URL [jar:file:/mnt/c/Repos/Personal/pulsar-manager/build/distributions/pulsar-manager/lib/pulsar-manager.jar!/org/apache/pulsar/manager/service/impl/BookiesServiceImpl.class] ┌─┐ | environmentCacheServiceImpl defined in URL [jar:file:/mnt/c/Repos/Personal/pulsar-manager/build/distributions/pulsar-manager/lib/pulsar-manager.jar!/org/apache/pulsar/manager/service/impl/EnvironmentCacheServiceImpl.class] ↑ ↓ | pulsarAdminServiceImpl (field private org.apache.pulsar.manager.service.EnvironmentCacheService org.apache.pulsar.manager.service.impl.PulsarAdminServiceImpl.environmentCacheService) └─┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] After updating broker from 3.0.3 to 3.0.4, reader cannot receive new messages from compacted topics. [pulsar]
lhotari commented on issue #22634: URL: https://github.com/apache/pulsar/issues/22634#issuecomment-2093679427 Thanks for the report. Do you have a change to test with latest branch-3.0 version (building Pulsar locally from branch-3.0)? 3.0.4 included #22191 which caused a regression, #22435. That is fixed by #22454. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][broker] fix replicated subscriptions for transactional messages [pulsar]
codecov-commenter commented on PR #22452: URL: https://github.com/apache/pulsar/pull/22452#issuecomment-2093677033 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22452?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `55.6%` with `16 lines` in your changes are missing coverage. Please review. > Project coverage is 38.30%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`3cff761`)](https://app.codecov.io/gh/apache/pulsar/pull/22452?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 220 commits behind head on master. Additional details and impacted files [](https://app.codecov.io/gh/apache/pulsar/pull/22452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #22452 +/- ## = - Coverage 73.57% 38.30% -35.27% + Complexity3262414345-18279 = Files 1877 1672 -205 Lines139502 133188 -6314 Branches 1529914893 -406 = - Hits 10263851023-51615 - Misses2890875763+46855 + Partials 7956 6402 -1554 ``` | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/22452/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/22452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.74% <55.55%> (+3.16%)` | :arrow_up: | | [systests](https://app.codecov.io/gh/apache/pulsar/pull/22452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/22452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `36.69% <50.00%> (-36.16%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/apache/pulsar/pull/22452?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...sar/broker/service/persistent/PersistentTopic.java](https://app.codecov.io/gh/apache/pulsar/pull/22452?src=pr&el=tree&filepath=pulsar-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fbroker%2Fservice%2Fpersistent%2FPersistentTopic.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvUGVyc2lzdGVudFRvcGljLmphdmE=) | `51.39% <71.42%> (-27.07%)` | :arrow_down: | | [.../persistent/ReplicatedSubscriptionsController.java](https://app.codecov.io/gh/apache/pulsar/pull/22452?src=pr&el=tree&filepath=pulsar-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fbroker%2Fservice%2Fpersistent%2FReplicatedSubscriptionsController.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvUmVwbGljYXRlZFN1YnNjcmlwdGlvbnNDb250cm9sbGVyLmphdmE=) | `0.00% <0.00%> (-72.60%)` | :arrow_down: | | [...nsaction/buffer/impl/TransactionBufferDisable.java](https://app.codecov.io/gh/apache/pulsar/pull/22452?src=pr&el=tree&filepath=pulsar-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fbroker%2Ftransaction%2Fbuffer%2Fimpl%2FTransactionBufferDisable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb
Re: [PR] [fix][broker] Fix cursor should use latest ledger config [pulsar]
dao-jun commented on PR #22644: URL: https://github.com/apache/pulsar/pull/22644#issuecomment-2093668164 This lead to too many changes, can we just update Cursor#config when the config changed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [improve] [broker] Add systemCursorNames ignore list for ttl check [pulsar]
lhotari commented on code in PR #22614:
URL: https://github.com/apache/pulsar/pull/22614#discussion_r1589662256
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##
@@ -652,6 +652,12 @@ The max allowed delay for delayed delivery (in
milliseconds). If the broker rece
)
private int ttlDurationDefaultInSeconds = 0;
+@FieldContext(
+category = CATEGORY_POLICIES,
+doc = "System subscriptions that will be ignored by ttl check. Default
is empty."
Review Comment:
"Default is empty" in the description, but there's `__compaction` in the
default.
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##
@@ -652,6 +652,12 @@ The max allowed delay for delayed delivery (in
milliseconds). If the broker rece
)
private int ttlDurationDefaultInSeconds = 0;
+@FieldContext(
+category = CATEGORY_POLICIES,
+doc = "System subscriptions that will be ignored by ttl check. Default
is empty."
Review Comment:
Please also add changes to the default `broker.conf` and `standalone.conf`
files if this is something that should be usually configurable by users.
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##
@@ -1933,7 +1936,7 @@ public void checkMessageExpiry() {
int messageTtlInSeconds = topicPolicies.getMessageTTLInSeconds().get();
if (messageTtlInSeconds != 0) {
subscriptions.forEach((__, sub) -> {
-if (!isCompactionSubscription(sub.getName())) {
+if (systemCursorNames.contains(sub.getName())) {
Review Comment:
I think it would be better to always ignore the compaction subscription. It
could be better to change the meaning of the configurable `systemCursorNames`
to be additional system cursor names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] docs: update docs on seeding default superuser from app props [pulsar-manager]
maranmaran closed pull request #566: docs: update docs on seeding default superuser from app props URL: https://github.com/apache/pulsar-manager/pull/566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] docs: update docs on seeding default superuser from app props [pulsar-manager]
maranmaran opened a new pull request, #566: URL: https://github.com/apache/pulsar-manager/pull/566 ### Motivation Knowledge sharing, documentation for https://github.com/apache/pulsar-manager/pull/565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][broker] Fix cursor should use latest ledger config [pulsar]
lhotari commented on PR #22644: URL: https://github.com/apache/pulsar/pull/22644#issuecomment-2093656353 a test needs updating: ``` BrokerBkEnsemblesTests.testSkipCorruptDataLedger:213 » NoSuchField config ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][broker] fix replicated subscriptions for transactional messages [pulsar]
lhotari closed pull request #22452: [fix][broker] fix replicated subscriptions for transactional messages URL: https://github.com/apache/pulsar/pull/22452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][broker] fix replicated subscriptions for transactional messages [pulsar]
lhotari commented on PR #22452: URL: https://github.com/apache/pulsar/pull/22452#issuecomment-2093587476 Closing and reopening to get recent changes from master branch to the PR build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: check for existing superuser [pulsar-manager]
lhotari commented on PR #564: URL: https://github.com/apache/pulsar-manager/pull/564#issuecomment-2093579903 Thanks for the contribution @maranmaran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: check for existing superuser [pulsar-manager]
lhotari merged PR #564: URL: https://github.com/apache/pulsar-manager/pull/564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(pulsar-manager) branch master updated: fix: check for existing superuser (#564)
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git
The following commit(s) were added to refs/heads/master by this push:
new abf8328 fix: check for existing superuser (#564)
abf8328 is described below
commit abf8328a3a8c93ed9efc6a7962cf1a622518215a
Author: Marko Urh
AuthorDate: Fri May 3 20:48:51 2024 +0200
fix: check for existing superuser (#564)
---
.../java/org/apache/pulsar/manager/controller/UsersController.java | 5 +
1 file changed, 5 insertions(+)
diff --git
a/src/main/java/org/apache/pulsar/manager/controller/UsersController.java
b/src/main/java/org/apache/pulsar/manager/controller/UsersController.java
index b4996ca..21f2f24 100644
--- a/src/main/java/org/apache/pulsar/manager/controller/UsersController.java
+++ b/src/main/java/org/apache/pulsar/manager/controller/UsersController.java
@@ -218,6 +218,11 @@ public class UsersController {
result.put("error", "Please provider password");
return ResponseEntity.ok(result);
}
+Optional optionalUserEntity =
usersRepository.findByUserName(userInfoEntity.getName());
+if (optionalUserEntity.isPresent()) {
+result.put("error", "Superuser already exists");
+return ResponseEntity.ok(result);
+}
userInfoEntity.setPassword(DigestUtils.sha256Hex(userInfoEntity.getPassword()));
usersRepository.save(userInfoEntity);
(pulsar-helm-chart) branch master updated: Add namespace to hpa templates (#494)
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git
The following commit(s) were added to refs/heads/master by this push:
new c4941b3 Add namespace to hpa templates (#494)
c4941b3 is described below
commit c4941b32d19148b5741a087e5e2c250e2a37b793
Author: MonicaMagoniCom <79588876+monicamagoni...@users.noreply.github.com>
AuthorDate: Fri May 3 20:48:02 2024 +0200
Add namespace to hpa templates (#494)
---
charts/pulsar/templates/broker-hpa.yaml | 1 +
charts/pulsar/templates/proxy-hpa.yaml | 1 +
2 files changed, 2 insertions(+)
diff --git a/charts/pulsar/templates/broker-hpa.yaml
b/charts/pulsar/templates/broker-hpa.yaml
index f52850a..83a24aa 100644
--- a/charts/pulsar/templates/broker-hpa.yaml
+++ b/charts/pulsar/templates/broker-hpa.yaml
@@ -26,6 +26,7 @@ apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
name: "{{ template "pulsar.fullname" . }}-{{ .Values.broker.component }}"
+ namespace: {{ template "pulsar.namespace" . }}
spec:
maxReplicas: {{ .Values.broker.autoscaling.maxReplicas }}
{{- with .Values.broker.autoscaling.metrics }}
diff --git a/charts/pulsar/templates/proxy-hpa.yaml
b/charts/pulsar/templates/proxy-hpa.yaml
index 587382f..291c072 100644
--- a/charts/pulsar/templates/proxy-hpa.yaml
+++ b/charts/pulsar/templates/proxy-hpa.yaml
@@ -26,6 +26,7 @@ apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
name: "{{ template "pulsar.fullname" . }}-{{ .Values.proxy.component }}"
+ namespace: {{ template "pulsar.namespace" . }}
spec:
maxReplicas: {{ .Values.proxy.autoscaling.maxReplicas }}
{{- with .Values.proxy.autoscaling.metrics }}
Re: [PR] Add namespace to hpa templates [pulsar-helm-chart]
lhotari merged PR #494: URL: https://github.com/apache/pulsar-helm-chart/pull/494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] HPA missing namespace [pulsar-helm-chart]
lhotari closed issue #493: HPA missing namespace URL: https://github.com/apache/pulsar-helm-chart/issues/493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] `/pulsar-manager/users/superuser` can create multiple same superusers, login throws InternalServerError [pulsar-manager]
maranmaran commented on issue #563: URL: https://github.com/apache/pulsar-manager/issues/563#issuecomment-2093552406 Above PR's should solve this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] `/pulsar-manager/users/superuser` can create multiple same superusers, login throws InternalServerError [pulsar-manager]
maranmaran closed issue #563: `/pulsar-manager/users/superuser` can create multiple same superusers, login throws InternalServerError URL: https://github.com/apache/pulsar-manager/issues/563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] creating the same superuser twice create inconsistent state in accounts [pulsar-manager]
maranmaran commented on issue #537: URL: https://github.com/apache/pulsar-manager/issues/537#issuecomment-2093550752 @coreybutler @fvigotti https://github.com/apache/pulsar-manager/pull/564 should solve this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [improve][broker][WIP] Add brokerId to lookup results and load manager data [pulsar]
lhotari opened a new pull request, #22647: URL: https://github.com/apache/pulsar/pull/22647 WIP: This PR most likely requires a PIP and that will follow. ### Motivation In the past brokers didn't have a stable unique identifier. In PR #21894, the "lookupServiceAddress" was renamed to be "brokerId" so that there would be a single unique identifier for a broker in a cluster. This PR continues making brokerId a first class identifier for a broker. The long term benefit is having consistency across the APIs. One reason to add this information to the topic lookup result is to be able to use the APIs in a way where you lookup a topic and receive that broker id. With this broker id, you could then lookup more details about the broker in the Admin API with the broker id. ### Modifications - add brokerId to lookup results - add brokerId to load manager data - brokerId already was contained in LoadReport with the field name `name` instead of `brokerId`. Keep the name `name` for backwards compatibility - add client test to ensure that lookup result includes the broker id for both binary and http lookup results ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(pulsar-manager) branch master updated: fix: error pages path exception (#562)
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git
The following commit(s) were added to refs/heads/master by this push:
new 3243fea fix: error pages path exception (#562)
3243fea is described below
commit 3243fea62444a19cbe1206aad6d0e30272722f78
Author: Bäm
AuthorDate: Fri May 3 19:21:14 2024 +0200
fix: error pages path exception (#562)
---
src/main/java/org/apache/pulsar/manager/PulsarManagerApplication.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
a/src/main/java/org/apache/pulsar/manager/PulsarManagerApplication.java
b/src/main/java/org/apache/pulsar/manager/PulsarManagerApplication.java
index 1505a02..e28260a 100644
--- a/src/main/java/org/apache/pulsar/manager/PulsarManagerApplication.java
+++ b/src/main/java/org/apache/pulsar/manager/PulsarManagerApplication.java
@@ -16,9 +16,10 @@ package org.apache.pulsar.manager;
import org.mybatis.spring.annotation.MapperScan;
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
+import
org.springframework.boot.autoconfigure.web.servlet.error.ErrorMvcAutoConfiguration;
import org.springframework.cloud.netflix.zuul.EnableZuulProxy;
-@SpringBootApplication
+@SpringBootApplication(exclude = {ErrorMvcAutoConfiguration.class})
@EnableZuulProxy
@MapperScan("org.apache.pulsar.manager.mapper")
public class PulsarManagerApplication {
Re: [I] NoSuchMethodError: 'java.lang.String org.springframework.boot.web.servlet.error.ErrorController.getErrorPath()' [pulsar-manager]
lhotari closed issue #560: NoSuchMethodError: 'java.lang.String org.springframework.boot.web.servlet.error.ErrorController.getErrorPath()' URL: https://github.com/apache/pulsar-manager/issues/560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix: ErrorController.getErrorPath() [pulsar-manager]
lhotari merged PR #562: URL: https://github.com/apache/pulsar-manager/pull/562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: add token column to init sql [pulsar-manager]
lhotari merged PR #561: URL: https://github.com/apache/pulsar-manager/pull/561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(pulsar-manager) branch master updated: fix: add token column to init sql (#561)
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git The following commit(s) were added to refs/heads/master by this push: new 5c7d4f3 fix: add token column to init sql (#561) 5c7d4f3 is described below commit 5c7d4f3d2c9b2c9432c321ad7b248d7778a80311 Author: Bäm AuthorDate: Fri May 3 19:20:24 2024 +0200 fix: add token column to init sql (#561) --- docker/init_db.sql | 1 + 1 file changed, 1 insertion(+) diff --git a/docker/init_db.sql b/docker/init_db.sql index a835251..c1ff98e 100644 --- a/docker/init_db.sql +++ b/docker/init_db.sql @@ -25,6 +25,7 @@ CREATE TABLE IF NOT EXISTS environments ( name varchar(256) NOT NULL, broker varchar(1024) NOT NULL, bookie varchar(1024) NOT NULL, + token varchar(1024), CONSTRAINT PK_name PRIMARY KEY (name), UNIQUE (broker) );
(pulsar) branch master updated: [improve][broker] Add logging to leader election (#22645)
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 7a8c4549639 [improve][broker] Add logging to leader election (#22645)
7a8c4549639 is described below
commit 7a8c4549639d67182049bca9f714c0f4b3061236
Author: Lari Hotari
AuthorDate: Fri May 3 20:16:08 2024 +0300
[improve][broker] Add logging to leader election (#22645)
---
.../org/apache/pulsar/broker/PulsarService.java| 6 +++---
.../coordination/impl/LeaderElectionImpl.java | 22 ++
2 files changed, 21 insertions(+), 7 deletions(-)
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
index 8c910fb91e1..559ca1e9e69 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
@@ -1181,7 +1181,7 @@ public class PulsarService implements AutoCloseable,
ShutdownService {
new LeaderElectionService(coordinationService, getBrokerId(),
getSafeWebServiceAddress(),
state -> {
if (state == LeaderElectionState.Leading) {
-LOG.info("This broker was elected leader");
+LOG.info("This broker {} was elected leader",
getBrokerId());
if (getConfiguration().isLoadBalancerEnabled()) {
long resourceQuotaUpdateInterval = TimeUnit.MINUTES
.toMillis(getConfiguration().getLoadBalancerResourceQuotaUpdateIntervalMinutes());
@@ -1202,10 +1202,10 @@ public class PulsarService implements AutoCloseable,
ShutdownService {
if (leaderElectionService != null) {
final Optional currentLeader =
leaderElectionService.getCurrentLeader();
if (currentLeader.isPresent()) {
-LOG.info("This broker is a follower. Current
leader is {}",
+LOG.info("This broker {} is a follower.
Current leader is {}", getBrokerId(),
currentLeader);
} else {
-LOG.info("This broker is a follower. No leader
has been elected yet");
+LOG.info("This broker {} is a follower. No
leader has been elected yet", getBrokerId());
}
}
diff --git
a/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/coordination/impl/LeaderElectionImpl.java
b/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/coordination/impl/LeaderElectionImpl.java
index 9e6a9b94c42..aa606084173 100644
---
a/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/coordination/impl/LeaderElectionImpl.java
+++
b/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/coordination/impl/LeaderElectionImpl.java
@@ -129,19 +129,26 @@ class LeaderElectionImpl implements LeaderElection {
return FutureUtils.exception(t);
}
-if (existingValue.equals(proposedValue.orElse(null))) {
+T value = proposedValue.orElse(null);
+if (existingValue.equals(value)) {
// If the value is the same as our proposed value, it means this
instance was the leader at some
// point before. The existing value can either be for this same
session or for a previous one.
if (res.getStat().isCreatedBySelf()) {
// The value is still valid because it was created in the same
session
changeState(LeaderElectionState.Leading);
} else {
+log.info("Conditionally deleting existing equals value {} for
{} because it's not created in the "
++ "current session. stat={}", existingValue, path,
res.getStat());
// Since the value was created in a different session, it
might be expiring. We need to delete it
// and try the election again.
return store.delete(path,
Optional.of(res.getStat().getVersion()))
.thenCompose(__ -> tryToBecomeLeader());
}
} else if (res.getStat().isCreatedBySelf()) {
+log.warn("Conditionally deleting existing value {} for {} because
it's different from the proposed value "
++ "({}). This is unexpected since it was created
within the same session. "
++ "In tests this could happen because of an
invalid shared session id when using mocks.",
+existingValue, path, value);
// The existing value is different but was created from the same
session
Re: [PR] [improve][broker] Add logging to leader election [pulsar]
merlimat merged PR #22645: URL: https://github.com/apache/pulsar/pull/22645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(pulsar) branch master updated: [improve][build] Use slf4j-bom to align slf4j versions (#22646)
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new d12f623739d [improve][build] Use slf4j-bom to align slf4j versions
(#22646)
d12f623739d is described below
commit d12f623739df80cbc57a22a2de3ddba343f26ee3
Author: Lari Hotari
AuthorDate: Fri May 3 19:55:31 2024 +0300
[improve][build] Use slf4j-bom to align slf4j versions (#22646)
---
buildtools/pom.xml | 8 +++-
pom.xml| 16 +++-
2 files changed, 10 insertions(+), 14 deletions(-)
diff --git a/buildtools/pom.xml b/buildtools/pom.xml
index 58f99e9ea86..3b0b24d1d53 100644
--- a/buildtools/pom.xml
+++ b/buildtools/pom.xml
@@ -63,6 +63,13 @@
+
+org.slf4j
+slf4j-bom
+${slf4j.version}
+pom
+import
+
org.apache.logging.log4j
log4j-bom
@@ -122,7 +129,6 @@
org.slf4j
jcl-over-slf4j
- ${slf4j.version}
org.apache.commons
diff --git a/pom.xml b/pom.xml
index b72db9b3b76..048bc952466 100644
--- a/pom.xml
+++ b/pom.xml
@@ -763,20 +763,10 @@ flexible messaging model and an intuitive client
API.
org.slf4j
-slf4j-api
-${slf4j.version}
-
-
-
-org.slf4j
-slf4j-simple
-${slf4j.version}
-
-
-
-org.slf4j
-jcl-over-slf4j
+slf4j-bom
${slf4j.version}
+pom
+import
Re: [PR] [improve][build] Use slf4j-bom to align slf4j versions [pulsar]
lhotari merged PR #22646: URL: https://github.com/apache/pulsar/pull/22646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [improve][build] Use slf4j-bom to align slf4j versions [pulsar]
codecov-commenter commented on PR #22646: URL: https://github.com/apache/pulsar/pull/22646#issuecomment-2093378039 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22646?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 72.70%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`75b66e1`)](https://app.codecov.io/gh/apache/pulsar/pull/22646?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 218 commits behind head on master. Additional details and impacted files [](https://app.codecov.io/gh/apache/pulsar/pull/22646?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #22646 +/- ## - Coverage 73.57% 72.70% -0.88% + Complexity3262432554 -70 Files 1877 1887 +10 Lines139502 141006+1504 Branches 1529915478 +179 - Hits 102638 102516 -122 - Misses2890830618+1710 + Partials 7956 7872 -84 ``` | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/22646/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/22646/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.39% <ø> (+2.80%)` | :arrow_up: | | [systests](https://app.codecov.io/gh/apache/pulsar/pull/22646/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.58% <ø> (+0.26%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/22646/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `71.47% <ø> (-1.38%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 344 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/22646/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] feat: support seeding default superuser via application.properties [pulsar-manager]
maranmaran opened a new pull request, #565: URL: https://github.com/apache/pulsar-manager/pull/565 Fixes #563 ### Motivation I'm working on integrating apache pulsar into [.NET Aspire](https://github.com/dotnet/aspire) Next to pulsar I wish to deliver a management UI, pulsar manager. Like Kafka and Rabbit do. Here's [my implementation](https://github.com/maranmaran/aspire/tree/feature/hosting-apache-pulsar/src/Aspire.Hosting.Apache.Pulsar) Right now, in order for me to seed default superuser, I must do this gymnastics of waiting for container and backend to be ready then acquire token, then issue put request. This is clumsy a little and there should be a way to provide some default superuser via configuration. Like rabbit does, SQL, bunch of other tools. In particular I'm afraid that Aspire team [won't accept a solution like this one](https://github.com/maranmaran/aspire/blob/feature/hosting-apache-pulsar/src/Aspire.Hosting.Apache.Pulsar/PulsarManagerSeedDefaultSuperUser.cs) Where I subscribe lifecycle hooks of container and then retry loop till I seed the user. It works, but it feels too "hacky" ### Modifications In `PulsarApplicationListener` implemented `seedDefaultSuperuser` ### Verifying this change - [x] Make sure that the change passes the `./gradlew build` checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix: check for existing superuser [pulsar-manager]
maranmaran opened a new pull request, #564: URL: https://github.com/apache/pulsar-manager/pull/564 Fixes #563 and #537 ### Motivation When creating superuser, currently there's no guard to protect against already created superuser. If you seed superuser more then one times, it breaks login for that particular user as the request throws `InternalServerError` on login ### Modifications In the same style of other guards within `UsersController` I've added query to repository to get entity by name for the incoming user payload. If the entity exists we return validation error. ### Verifying this change - [x] Make sure that the change passes the `./gradlew build` checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]
lhotari commented on PR #22607: URL: https://github.com/apache/pulsar/pull/22607#issuecomment-2093242915 > Based on the review results, let's continue to use compile scope. When using the pulsar dependency, the downstream users must unify the slf4j version in the project. @nodece makes sense. slf4j 2.0.x comes with a BOM, so aligning slf4j versions is easy with it. I created PR #22646 for Pulsar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] `/pulsar-manager/users/superuser` can create multiple same superusers, login throws InternalServerError [pulsar-manager]
maranmaran commented on issue #563: URL: https://github.com/apache/pulsar-manager/issues/563#issuecomment-2093242931 https://github.com/apache/pulsar-manager/issues/537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] `/pulsar-manager/users/superuser` can create multiple same superusers breaking the client [pulsar-manager]
maranmaran opened a new issue, #563: URL: https://github.com/apache/pulsar-manager/issues/563 Hello 👋 Bug report, Right now, you are able to PUT superuser multiple times which henceforth breaks client login as there's internal server error being thrown that there's more than 1 expected result. Request or consideration: I'm about 85% done with integrating Pulsar into [Aspire](https://github.com/dotnet/aspire), but I would like to provide a client next to it as a plugin. However, this seeding of superusers is making it feel necessarily hacky. You need to wait for container to spin up and start accepting then make request to some /superuser endpoint Can some defaults arrive with the config or envvars like rabbit management plugin would -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]
nodece commented on PR #22607: URL: https://github.com/apache/pulsar/pull/22607#issuecomment-2093193496 Based on the review results, let's continue to use compile scope. When using the pulsar dependency, the downstream users must unify the slf4j version in the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]
nodece closed pull request #22607: [fix][build] Switch slf4j scope to provided from compile URL: https://github.com/apache/pulsar/pull/22607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [improve][broker] Add logging to leader election [pulsar]
codecov-commenter commented on PR #22645: URL: https://github.com/apache/pulsar/pull/22645#issuecomment-2093115930 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `85.71429%` with `2 lines` in your changes are missing coverage. Please review. > Project coverage is 72.72%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6a80538`)](https://app.codecov.io/gh/apache/pulsar/pull/22645?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 218 commits behind head on master. Additional details and impacted files [](https://app.codecov.io/gh/apache/pulsar/pull/22645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #22645 +/- ## - Coverage 73.57% 72.72% -0.85% + Complexity3262432344 -280 Files 1877 1887 +10 Lines139502 141014+1512 Branches 1529915478 +179 - Hits 102638 102554 -84 - Misses2890830603+1695 + Partials 7956 7857 -99 ``` | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/22645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/22645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.10% <50.00%> (+2.51%)` | :arrow_up: | | [systests](https://app.codecov.io/gh/apache/pulsar/pull/22645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.63% <42.85%> (+0.30%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/22645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `71.49% <85.71%> (-1.35%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/apache/pulsar/pull/22645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...n/java/org/apache/pulsar/broker/PulsarService.java](https://app.codecov.io/gh/apache/pulsar/pull/22645?src=pr&el=tree&filepath=pulsar-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fbroker%2FPulsarService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9QdWxzYXJTZXJ2aWNlLmphdmE=) | `82.36% <66.66%> (-0.01%)` | :arrow_down: | | [...metadata/coordination/impl/LeaderElectionImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/22645?src=pr&el=tree&filepath=pulsar-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fmetadata%2Fcoordination%2Fimpl%2FLeaderElectionImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLW1ldGFkYXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvbWV0YWRhdGEvY29vcmRpbmF0aW9uL2ltcGwvTGVhZGVyRWxlY3Rpb25JbXBsLmphdmE=) | `76.21% <90.90%> (-2.63%)` | :arrow_down: | ... and [337 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/22645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai
Re: [PR] [fix][storage] ReadonlyManagedLedger initialization does not fill in the properties [pulsar]
codecov-commenter commented on PR #22630: URL: https://github.com/apache/pulsar/pull/22630#issuecomment-2092888096 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22630?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 72.74%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`1dc0ca0`)](https://app.codecov.io/gh/apache/pulsar/pull/22630?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 218 commits behind head on master. Additional details and impacted files [](https://app.codecov.io/gh/apache/pulsar/pull/22630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #22630 +/- ## - Coverage 73.57% 72.74% -0.83% + Complexity32624 2418 -30206 Files 1877 1887 +10 Lines139502 141010+1508 Branches 1529915480 +181 - Hits 102638 102581 -57 - Misses2890830569+1661 + Partials 7956 7860 -96 ``` | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/22630/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/22630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.11% <0.00%> (+2.53%)` | :arrow_up: | | [systests](https://app.codecov.io/gh/apache/pulsar/pull/22630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.66% <0.00%> (+0.34%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/22630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `71.50% <100.00%> (-1.35%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/apache/pulsar/pull/22630?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...keeper/mledger/impl/ReadOnlyManagedLedgerImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/22630?src=pr&el=tree&filepath=managed-ledger%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbookkeeper%2Fmledger%2Fimpl%2FReadOnlyManagedLedgerImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL1JlYWRPbmx5TWFuYWdlZExlZGdlckltcGwuamF2YQ==) | `56.16% <100.00%> (+2.54%)` | :arrow_up: | ... and [341 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/22630/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][storage] ReadonlyManagedLedger initialization does not fill in the properties [pulsar]
gvanyao commented on PR #22630: URL: https://github.com/apache/pulsar/pull/22630#issuecomment-2092822902 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [feat] admin api/cli to delete package uploaded by pulsar-admin functions upload [pulsar]
truong-hua commented on issue #21942: URL: https://github.com/apache/pulsar/issues/21942#issuecomment-2092798188 Can any body help on this? I think the right process is to find related znodes and read their entries. Then remove all bookeepers entries and znodes. But I can not completely understand the logic behind the metadata to be able to implement the feature yet. Hope that anyone can explain the logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][storage] ReadonlyManagedLedger initialization does not fill in the properties [pulsar]
gvanyao commented on PR #22630: URL: https://github.com/apache/pulsar/pull/22630#issuecomment-2092766890 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][storage] ReadonlyManagedLedger initialization does not fill in the properties [pulsar]
gvanyao commented on PR #22630: URL: https://github.com/apache/pulsar/pull/22630#issuecomment-2092715999 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][storage] ReadonlyManagedLedger initialization does not fill in the properties [pulsar]
nodece commented on PR #22630: URL: https://github.com/apache/pulsar/pull/22630#issuecomment-2092589271 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [feat][misc] PIP-264: Add authentication metrics [pulsar]
github-actions[bot] commented on PR #22643: URL: https://github.com/apache/pulsar/pull/22643#issuecomment-2092507930 @dragosvictor Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [feat][misc] PIP-264: Add authentication metrics [pulsar]
dragosvictor closed pull request #22643: [feat][misc] PIP-264: Add authentication metrics URL: https://github.com/apache/pulsar/pull/22643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [feat][misc] PIP-264: Add authentication metrics [pulsar]
dragosvictor opened a new pull request, #22643: URL: https://github.com/apache/pulsar/pull/22643 Fixes #xyz Main Issue: #xyz PIP: #xyz ### Motivation ### Modifications ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [fix][sec] Upgrade Debezium oracle connector version to avoid CVE-2023-4586 [pulsar]
nikhilerigila09 opened a new pull request, #22641: URL: https://github.com/apache/pulsar/pull/22641 Fixes https://github.com/apache/pulsar/issues/22626 ### Motivation Avoid CVE-2023-4586 ### Modifications Upgrade elasticsearch-java version to 8.12.1 which avoids `org.infinispan:infinispan-client-hotrod@14.0.4.Final` which has the vulnerability and uses `org.infinispan:infinispan-client-hotrod-jakarta@14.0.4.Final` instead, which has no vulnerabilities. ### Verifying this change - [X] Make sure that the change passes the CI checks. ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [X] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [ ] `doc-required` - [X] `doc-not-needed` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
