[GitHub] [pulsar] Shoothzj commented on pull request #10595: [Pulsar IO] Develop Huawei Cloud DIS connector

2021-05-15 Thread GitBox


Shoothzj commented on pull request #10595:
URL: https://github.com/apache/pulsar/pull/10595#issuecomment-841633526


   > @Shoothzj thank you for the great work!
   > 
   > My take on the connectors - I would recommend avoiding adding more 
connectors to the Pulsar repo. It becomes really hard to maintain the quality 
of the connectors. It is a similar situation in other projects like Flink.
   > 
   > I’d recommend the author of the connector maintaining the connector 
themselves. In this way, we can scale out the Pulsar ecosystem.
   > 
   > Where to host the connector code is totally up to the author. It can be 
under his personal GitHub account. If you want to share the connector with the 
broader ecosystem, you are welcome to add your connector to 
https://hub.streamnative.io
   
   @sijie 
   I think you make sense, connectors are hard to maintain the quality. Let me 
open a discussion, let the connector merge policy come to a conclusion.
   
   By the way, if we decide not to merge to Pulsar repo. I want to maintain 
this connector in StreamNative repo, I think it's better than maintain on 
personal repos.
   
   Thanks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [pulsar] Shoothzj commented on pull request #10595: [Pulsar IO] Develop Huawei Cloud DIS connector

2021-05-15 Thread GitBox


Shoothzj commented on pull request #10595:
URL: https://github.com/apache/pulsar/pull/10595#issuecomment-841626874


   > Personally I believe that we can accept this code here and when we will 
split the repo the code will go into the new repo for connectors.
   > 
   > That said, it is your decision.
   > As ASF project we are happy to see more integrations
   
   I want to merge code to **Pulsar IO** module too.  @sijie says growing 
connectors brings difficulty for pulsar project build、tests、release. He 
recommends for two way to share project. The other way is waiting for him to 
split the code. Should we discuss with sijie?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [pulsar] Shoothzj commented on pull request #10595: [Pulsar IO] Develop Huawei Cloud DIS connector

2021-05-15 Thread GitBox


Shoothzj commented on pull request #10595:
URL: https://github.com/apache/pulsar/pull/10595#issuecomment-841619991


   > Can you please explain better this problem with 'merge policy' ?
   
   @codelipenghui told me that the IO part is going to split with Pulsar main 
Repo, currently it's not recommend to merge to main repo. I think after the 
split, i will merge to PulsarIO repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [pulsar] Shoothzj commented on pull request #10595: [Pulsar IO] Develop Huawei Cloud DIS connector

2021-05-14 Thread GitBox


Shoothzj commented on pull request #10595:
URL: https://github.com/apache/pulsar/pull/10595#issuecomment-841585081


   For the merge policy, I close this PR, I will commit these codes to 
https://github.com/streamnative/pulsar-io-huawei-dis


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org