[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen (allow Pulsar to run on JDK14+)
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-793923633 @wolfstudy @codelipenghui @rdhabalia CI finally passed. I believe this is a good time to merge this patch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen (allow Pulsar to run on JDK14+)
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-793716473 /pulsarbot rerun-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen (allow Pulsar to run on JDK14+)
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-793641906 /pulsarbot run-failure-tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen (allow Pulsar to run on JDK14+)
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-793537921 /pulsarbot run-failure-tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen (allow Pulsar to run on JDK14+)
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-791249566 @wolfstudy can you please help merging this patch ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen (allow Pulsar to run on JDK14+)
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-790787061 /pulsarbot run-failure-tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen (allow Pulsar to run on JDK14+)
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-789898332 I have merged with current master in order to bootstrap CI again. Thank you @sijie for taking a look This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen (allow Pulsar to run on JDK14+)
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-789551645 @codelipenghui @congbobo184 @wolfstudy can you please take a look ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-785020260 @rdhabalia @merlimat @codelipenghui PTAL as well This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-784357956 > @eolivelli I think the integration tests should be added in this repo. The helm chart repo is used for testing the helm chart. You can clone the helm chart repo in the CI job to start a KIND cluster for testing. @sijie agreed, we can make it here (or in the new 'release repo' once PIP-62 is completed but I would keep it out of the scope of this patch I created a new issue https://github.com/apache/pulsar/issues/9687 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-784289109 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-784188654 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-784116181 @sijie @wolfstudy I have tested locally this branch (using the helm-chart) and it works very well. I believe there is no need to add integration tests in order to commit this patch. We can add system tests, probably the best place would be nearby the helm-chart and not in this repository. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-770772868 @wolfstudy @sijie I am going to try out this brach on a K8s cluster manually. Any suggestion about where to put an integration tests is very appreciated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-762356280 @wolfstudy if you do not have cycles. Can you please point me to some other kind of k8s tests we have here in Pulsar ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-741753538 @wolfstudy do you have time to pick up this issue ? it is very annoying for people running on a recent Java version This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-735630424 @wolfstudy feel free to pick up this patch thank you This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-729492132 @sijie not a problem from my side. I think it is safer to postpone This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-728709428 @sijie no I didn't and I do not have a way to do it right now, I am sorry. It would be really better to test it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8576: Issue 8558: Upgrade Kubernetes client and remove sundr-codegen
eolivelli commented on pull request #8576: URL: https://github.com/apache/pulsar/pull/8576#issuecomment-728023510 @codelipenghui PTAL to this change as well, otherwise it is not possible to run Pulsar on JDK14+ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
