[GitHub] [pulsar] fangpengcheng95 commented on a change in pull request #5789: [Issue 5708][docs] correct some wrong info about persistent topics
fangpengcheng95 commented on a change in pull request #5789: [Issue 5708][docs] correct some wrong info about persistent topics URL: https://github.com/apache/pulsar/pull/5789#discussion_r355279658 ## File path: site2/docs/admin-api-persistent-topics.md ## @@ -314,27 +345,35 @@ It shows detailed statistics of a topic. - **ledgers**: The ordered list of all ledgers for this topic holding its messages + - **ledgerId**: Id of this ledger + + - **entries**: Total number of entries belong to this ledger + + - **size**: Size of messages written to this ledger (in bytes) + + - **offloaded**: Whether this ledger is offloaded + - **cursors**: The list of all cursors on this topic. There will be one for every subscription you saw in the topic stats. - - **markDeletePosition**: The ack position: the last message the subscriber acknowledged receiving + - **markDeletePosition**: The ack position where the subscriber acknowledges receiving the last message Review comment: That is a constructive suggestion！ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] fangpengcheng95 commented on a change in pull request #5789: [Issue 5708][docs] correct some wrong info about persistent topics
fangpengcheng95 commented on a change in pull request #5789: [Issue 5708][docs] correct some wrong info about persistent topics URL: https://github.com/apache/pulsar/pull/5789#discussion_r355275519 ## File path: site2/docs/admin-api-persistent-topics.md ## @@ -191,47 +192,77 @@ It shows current statistics of a given non-partitioned topic. - **averageMsgSize**: The average size in bytes of messages published within the last interval - - **storageSize**: The sum of the ledgers' storage size for this topic. See + - **storageSize**: The sum of the ledgers' storage size for this topic. Space used to store the messages for the topic - **publishers**: The list of all local publishers into the topic. There can be zero or thousands - - **averageMsgSize**: Average message size in bytes from this publisher within the last interval + - **msgRateIn**: Total rate of messages published by this publisher in messages per second + + - **msgThroughputIn**: Total throughput of the messages published by this publisher in bytes per second + + - **averageMsgSize**: Average message size in bytes from this publisher within the last interval - - **producerId**: Internal identifier for this producer on this topic + - **producerId**: Id of this publisher. Internal identifier for this producer on this topic - - **producerName**: Internal identifier for this producer, generated by the client library + - **producerName**: Publisher name which is generated by the client library Review comment: Thanks a lot, i will revert it! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] fangpengcheng95 commented on a change in pull request #5789: [Issue 5708][docs] correct some wrong info about persistent topics
fangpengcheng95 commented on a change in pull request #5789: [Issue 5708][docs] correct some wrong info about persistent topics URL: https://github.com/apache/pulsar/pull/5789#discussion_r355274852 ## File path: site2/docs/admin-api-persistent-topics.md ## @@ -191,47 +192,77 @@ It shows current statistics of a given non-partitioned topic. - **averageMsgSize**: The average size in bytes of messages published within the last interval - - **storageSize**: The sum of the ledgers' storage size for this topic. See + - **storageSize**: The sum of the ledgers' storage size for this topic. Space used to store the messages for the topic - **publishers**: The list of all local publishers into the topic. There can be zero or thousands - - **averageMsgSize**: Average message size in bytes from this publisher within the last interval + - **msgRateIn**: Total rate of messages published by this publisher in messages per second + + - **msgThroughputIn**: Total throughput of the messages published by this publisher in bytes per second + + - **averageMsgSize**: Average message size in bytes from this publisher within the last interval - - **producerId**: Internal identifier for this producer on this topic + - **producerId**: Id of this publisher. Internal identifier for this producer on this topic Review comment: Thanks for suggestion, i will revert it! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] fangpengcheng95 commented on a change in pull request #5789: [Issue 5708][docs] correct some wrong info about persistent topics
fangpengcheng95 commented on a change in pull request #5789: [Issue 5708][docs] correct some wrong info about persistent topics URL: https://github.com/apache/pulsar/pull/5789#discussion_r355274132 ## File path: site2/docs/admin-api-persistent-topics.md ## @@ -26,6 +26,7 @@ List of topics can be fetched using [`list`](../../reference/CliTools#list) comm ```shell $ pulsar-admin persistent list \ my-tenant/my-namespace + Review comment: Sorry for this mess，I will correct it！ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] fangpengcheng95 commented on a change in pull request #5789: [Issue 5708][docs] correct some wrong info about persistent topics
fangpengcheng95 commented on a change in pull request #5789: [Issue 5708][docs] correct some wrong info about persistent topics URL: https://github.com/apache/pulsar/pull/5789#discussion_r354099611 ## File path: site2/docs/admin-api-persistent-topics.md ## @@ -191,47 +192,77 @@ It shows current statistics of a given non-partitioned topic. - **averageMsgSize**: The average size in bytes of messages published within the last interval - - **storageSize**: The sum of the ledgers' storage size for this topic. See + - **storageSize**: The sum of the ledgers' storage size for this topic. Space used to store the messages for the topic - **publishers**: The list of all local publishers into the topic. There can be zero or thousands - - **averageMsgSize**: Average message size in bytes from this publisher within the last interval + - **msgRateIn**: Total rate of messages published by this publisher in messages per second + + - **msgThroughputIn**: Total throughput of the messages published by this publisher in bytes per second + + - **averageMsgSize**: Average message size in bytes from this publisher within the last interval - - **producerId**: Internal identifier for this producer on this topic + - **producerId**: Id of this publisher. Internal identifier for this producer on this topic - - **producerName**: Internal identifier for this producer, generated by the client library + - **producerName**: Publisher name which is generated by the client library - - **address**: IP address and source port for the connection of this producer + - **address**: IP address and source port for the connection of this producer - - **connectedSince**: Timestamp this producer was created or last reconnected + - **connectedSince**: Timestamp this producer was created or last reconnected - **subscriptions**: The list of all local subscriptions to the topic - - **my-subscription**: The name of this subscription (client defined) + - **my-subscription**: The name of this subscription (client defined) + + - **msgRateOut**: Total rate of messages delivered on this subscription (msg/s) + + - **msgThroughputOut**: Total throughput delivered on this subscription (bytes/s) - - **msgBacklog**: The count of messages in backlog for this subscription + - **msgBacklog**: Number of messages in the subscription backlog - - **type**: This subscription type + - **type**: This subscription's type - - **msgRateExpired**: The rate at which messages were discarded instead of dispatched from this subscription due to TTL + - **msgRateExpired**: The rate at which messages were discarded instead of dispatched from this subscription due to TTL - - **consumers**: The list of connected consumers for this subscription + - **consumers**: The list of connected consumers for this subscription - - **consumerName**: Internal identifier for this consumer, generated by the client library +- **msgRateOut**: Total rate of messages delivered to the consumer (msg/s) - - **availablePermits**: The number of messages this consumer has space for in the client library's listen queue. A value of 0 means the client library's queue is full and receive() isn't being called. A nonzero value means this consumer is ready to be dispatched messages. +- **msgThroughputOut**: Total throughput delivered to the consumer (bytes/s) + +- **consumerName**: Internal identifier for this consumer, generated by the client library + +- **availablePermits**: The number of messages this consumer has space for in the client library's listen queue. A value of 0 means the client library's queue is full and receive() isn't being called. A nonzero value means this consumer is ready to be dispatched messages. + +- **unackedMessages**: Number of unacknowledged messages for the consumer + +- **blockedConsumerOnUnackedMsgs**: Flag to verify if consumer is blocked due to reaching threshold of unacked messages - **replication**: This section gives the stats for cross-colo replication of this topic - - **replicationBacklog**: The outbound replication backlog in messages + - **msgRateIn**: Total rate of messages received from the remote cluster (msg/s) + + - **msgThroughputIn**: Total throughput received from the remote cluster (bytes/s) - - **connected**: Whether the outbound replicator is connected + - **msgRateOut**: Total rate of messages delivered to the replication-subscriber (msg/s) - - **replicationDelayInSeconds**: How long the oldest message has been waiting to be sent through the connection, if connected is true + - **msgThroughputOut**: Total through delivered to the replicatio
