[GitHub] [pulsar] jai1 commented on a change in pull request #3633: [pulsar-broker] Fix deadlock: add zk-operation timeout for blocking call on zk-cache
jai1 commented on a change in pull request #3633: [pulsar-broker] Fix deadlock:
add zk-operation timeout for blocking call on zk-cache
URL: https://github.com/apache/pulsar/pull/3633#discussion_r263094693
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
##
@@ -609,9 +608,10 @@ protected void validateTopicOwnership(TopicName
topicName, boolean authoritative
* @throws Exception
*/
protected void validateGlobalNamespaceOwnership(NamespaceName namespace) {
+int timeout =
pulsar().getConfiguration().getZooKeeperOperationTimeoutSeconds();
Review comment:
nit: var name -> timeoutInSecs
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jai1 commented on a change in pull request #3633: [pulsar-broker] Fix deadlock: add zk-operation timeout for blocking call on zk-cache
jai1 commented on a change in pull request #3633: [pulsar-broker] Fix deadlock: add zk-operation timeout for blocking call on zk-cache URL: https://github.com/apache/pulsar/pull/3633#discussion_r263094012 ## File path: conf/broker.conf ## @@ -61,6 +61,9 @@ failureDomainsEnabled=false # Zookeeper session timeout in milliseconds zooKeeperSessionTimeoutMillis=3 +# ZooKeeper operation timeout in seconds Review comment: nit: Other config around this are in Ms so I would suggest to keep the TimeUnit in millis. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
