[GitHub] [pulsar] jiazhai commented on issue #5453: [Cpp] Fixed negative ack tracker constructor sequence

2019-10-24 Thread GitBox 
jiazhai commented on issue #5453: [Cpp] Fixed negative ack tracker constructor 
sequence
URL: https://github.com/apache/pulsar/pull/5453#issuecomment-546187195
 
 
   run java8 tests
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on issue #5453: [Cpp] Fixed negative ack tracker constructor sequence

2019-10-24 Thread GitBox 
jiazhai commented on issue #5453: [Cpp] Fixed negative ack tracker constructor 
sequence
URL: https://github.com/apache/pulsar/pull/5453#issuecomment-545839018
 
 
   @merlimat Thanks for the fix. 
   seems [ci](https://builds.apache.org/job/pulsar_precommit_cpp/10208/console) 
failed with `check-format`
   ```
   -- Build files have been written to: /pulsar/pulsar-client-cpp
   Scanning dependencies of target check-format
   clang-format checks failed, run 'make format' to fix
   CMakeFiles/check-format.dir/build.make:57: recipe for target 
'CMakeFiles/check-format' failed
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services