[GitHub] [pulsar] lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription
lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription URL: https://github.com/apache/pulsar/pull/3746#issuecomment-470340371 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription
lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription URL: https://github.com/apache/pulsar/pull/3746#issuecomment-470306023 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription
lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription URL: https://github.com/apache/pulsar/pull/3746#issuecomment-470273529 @sijie @jiazhai Great! :+1: thanks you both for the feedback. So when checks are success this pr will be ready to be merged! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription
lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription URL: https://github.com/apache/pulsar/pull/3746#issuecomment-470261127 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription
lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription URL: https://github.com/apache/pulsar/pull/3746#issuecomment-469850271 @jiazhai @sijie I removed this optimization for pattern subscription and for multi topics subscription, which now will only affect single topic subscription. In order to add this optimization for pattern and multi topics subscription a different approach must be taken, I will push this on a different pr if you agree. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
