[GitHub] [pulsar] rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version

2019-12-13 Thread GitBox
rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers 
before giving up bundle ownership to avoid bad zk-version
URL: https://github.com/apache/pulsar/pull/5599#issuecomment-565556744
 
 
   we are keep facing this issue and need this fix soon. so, @merlimat @sijie 
can we please review it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version

2019-11-15 Thread GitBox
rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers 
before giving up bundle ownership to avoid bad zk-version
URL: https://github.com/apache/pulsar/pull/5599#issuecomment-554475085
 
 
   @merlimat can you please review it.. somehow we are seeing this issue with 
2.4 very often when we restart the broker. we also want to merge #5604 as part 
of this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version

2019-11-13 Thread GitBox
rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers 
before giving up bundle ownership to avoid bad zk-version
URL: https://github.com/apache/pulsar/pull/5599#issuecomment-553633011
 
 
   rerun java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version

2019-11-13 Thread GitBox
rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers 
before giving up bundle ownership to avoid bad zk-version
URL: https://github.com/apache/pulsar/pull/5599#issuecomment-553609353
 
 
   rerun java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version

2019-11-13 Thread GitBox
rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers 
before giving up bundle ownership to avoid bad zk-version
URL: https://github.com/apache/pulsar/pull/5599#issuecomment-553585991
 
 
   @merlimat addressed your comments and renamed the flag with more meaningful 
name instead making it enum as enum doesn't seem appropriate to define this 
method behavior. can you please review it again or can you please let me know 
if you have any thought on it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version

2019-11-11 Thread GitBox
rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers 
before giving up bundle ownership to avoid bad zk-version
URL: https://github.com/apache/pulsar/pull/5599#issuecomment-552490428
 
 
   rerun integration tests
   rerun cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version

2019-11-10 Thread GitBox
rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers 
before giving up bundle ownership to avoid bad zk-version
URL: https://github.com/apache/pulsar/pull/5599#issuecomment-552320444
 
 
   rerun integration tests
   rerun cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services