[GitHub] [pulsar] srkukarni commented on issue #3770: Allow users to update everything in inputspecs except for isregexpattern

2019-03-06 Thread GitBox
srkukarni commented on issue #3770: Allow users to update everything in 
inputspecs except for isregexpattern
URL: https://github.com/apache/pulsar/pull/3770#issuecomment-470404385
 
 
   run integration tests
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] srkukarni commented on issue #3770: Allow users to update everything in inputspecs except for isregexpattern

2019-03-06 Thread GitBox
srkukarni commented on issue #3770: Allow users to update everything in 
inputspecs except for isregexpattern
URL: https://github.com/apache/pulsar/pull/3770#issuecomment-470326835
 
 
   updating input topic has the associated overhead of cleaning up 
subscriptions and such. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] srkukarni commented on issue #3770: Allow users to update everything in inputspecs except for isregexpattern

2019-03-06 Thread GitBox
srkukarni commented on issue #3770: Allow users to update everything in 
inputspecs except for isregexpattern
URL: https://github.com/apache/pulsar/pull/3770#issuecomment-470262744
 
 
   @jerrypeng I don't see a reason not to? Afterall one can experiment with 
different libraries of serialization changes to test which one works better. 
And also we do make sure that the types etc match.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services