[GitHub] [pulsar] tuteng commented on issue #5635: [Issue 5612] Use Reactivestreams client for Mongo Sink

2019-12-01 Thread GitBox
tuteng commented on issue #5635: [Issue 5612] Use Reactivestreams client for 
Mongo Sink
URL: https://github.com/apache/pulsar/pull/5635#issuecomment-560222478
 
 
   LGTM 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] tuteng commented on issue #5635: [Issue 5612] Use Reactivestreams client for Mongo Sink

2019-12-02 Thread GitBox
tuteng commented on issue #5635: [Issue 5612] Use Reactivestreams client for 
Mongo Sink
URL: https://github.com/apache/pulsar/pull/5635#issuecomment-560311429
 
 
   Please check unit test:
   
   ```
   2019-12-02\T\05:14:57.921 [ERROR] 
testWriteGoodMessage(org.apache.pulsar.io.mongodb.MongoSinkTest)  Time elapsed: 
1.027 s  <<< FAILURE!
   Wanted but not invoked:
   record.ack();
   -> at 
org.apache.pulsar.io.mongodb.MongoSinkTest.testWriteGoodMessage(MongoSinkTest.java:137)
   
   However, there were exactly 2 interactions with this mock:
   record.getValue();
   -> at org.apache.pulsar.io.mongodb.MongoSink.write(MongoSink.java:111)
   
   record.getValue();
   -> at org.apache.pulsar.io.mongodb.MongoSink.flush(MongoSink.java:148)
   
   
at 
org.apache.pulsar.io.mongodb.MongoSinkTest.testWriteGoodMessage(MongoSinkTest.java:137)
at 
org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:124)
at 
org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:54)
at 
org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:44)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
   
   2019-12-02\T\05:14:57.923 [ERROR] 
testWriteMultipleMessages(org.apache.pulsar.io.mongodb.MongoSinkTest)  Time 
elapsed: 1.014 s  <<< FAILURE!
   Wanted but not invoked:
   record.ack();
   -> at 
org.apache.pulsar.io.mongodb.MongoSinkTest.testWriteMultipleMessages(MongoSinkTest.java:151)
   
   However, there were exactly 6 interactions with this mock:
   record.getValue();
   -> at org.apache.pulsar.io.mongodb.MongoSink.write(MongoSink.java:111)
   
   record.getValue();
   -> at org.apache.pulsar.io.mongodb.MongoSink.write(MongoSink.java:111)
   
   record.getValue();
   -> at org.apache.pulsar.io.mongodb.MongoSink.write(MongoSink.java:111)
   
   record.getValue();
   -> at org.apache.pulsar.io.mongodb.MongoSink.flush(MongoSink.java:148)
   
   record.getValue();
   -> at org.apache.pulsar.io.mongodb.MongoSink.flush(MongoSink.java:148)
   
   record.getValue();
   -> at org.apache.pulsar.io.mongodb.MongoSink.flush(MongoSink.java:148)
   ```
   
   You can try command:
   
   ```
   mvn test -Dtest=unit-test-name (e.g: ConsumerBuilderImplTest)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] tuteng commented on issue #5635: [Issue 5612] Use Reactivestreams client for Mongo Sink

2019-12-03 Thread GitBox
tuteng commented on issue #5635: [Issue 5612] Use Reactivestreams client for 
Mongo Sink
URL: https://github.com/apache/pulsar/pull/5635#issuecomment-561156011
 
 
   run cpp tests
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services