[GitHub] [pulsar] yittg commented on a change in pull request #5013: [pulsar-client-cpp] cmake isolate auto gen srcs
yittg commented on a change in pull request #5013: [pulsar-client-cpp] cmake
isolate auto gen srcs
URL: https://github.com/apache/pulsar/pull/5013#discussion_r316921202
##
File path: pulsar-client-cpp/CMakeLists.txt
##
@@ -195,9 +195,13 @@ MESSAGE(STATUS "HAS_SNAPPY: ${HAS_SNAPPY}")
set(ADDITIONAL_LIBRARIES $ENV{PULSAR_ADDITIONAL_LIBRARIES})
link_directories( $ENV{PULSAR_ADDITIONAL_LIBRARY_PATH} )
+set(AUTOGEN_DIR ${CMAKE_BINARY_DIR}/generated)
Review comment:
@merlimat `gernerated` added to `.gitignore`, PTAL.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yittg commented on a change in pull request #5013: [pulsar-client-cpp] cmake isolate auto gen srcs
yittg commented on a change in pull request #5013: [pulsar-client-cpp] cmake
isolate auto gen srcs
URL: https://github.com/apache/pulsar/pull/5013#discussion_r316883740
##
File path: pulsar-client-cpp/CMakeLists.txt
##
@@ -195,9 +195,13 @@ MESSAGE(STATUS "HAS_SNAPPY: ${HAS_SNAPPY}")
set(ADDITIONAL_LIBRARIES $ENV{PULSAR_ADDITIONAL_LIBRARIES})
link_directories( $ENV{PULSAR_ADDITIONAL_LIBRARY_PATH} )
+set(AUTOGEN_DIR ${CMAKE_BINARY_DIR}/generated)
Review comment:
@merlimat not necessary for now as files would be ignored by `pd.{cc,h}`
suffix, it would be great to add `generated` directory though, and the suffix
pattern could be removed, i'll add it. Actually i always new a `build`
directory for cmake, would we suggest to do like that and add `build` directory
to `.gitignore` also?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yittg commented on a change in pull request #5013: [pulsar-client-cpp] cmake isolate auto gen srcs
yittg commented on a change in pull request #5013: [pulsar-client-cpp] cmake
isolate auto gen srcs
URL: https://github.com/apache/pulsar/pull/5013#discussion_r316883740
##
File path: pulsar-client-cpp/CMakeLists.txt
##
@@ -195,9 +195,13 @@ MESSAGE(STATUS "HAS_SNAPPY: ${HAS_SNAPPY}")
set(ADDITIONAL_LIBRARIES $ENV{PULSAR_ADDITIONAL_LIBRARIES})
link_directories( $ENV{PULSAR_ADDITIONAL_LIBRARY_PATH} )
+set(AUTOGEN_DIR ${CMAKE_BINARY_DIR}/generated)
Review comment:
@merlimat not necessary for now as files would be ignored by `pd.{cc,h}`
suffix, it would be great to add `generated` directory, and the suffix pattern
could be removed, i'll add it. Actually i always new a `build` directory for
cmake, would we suggest to do like that and add `build` directory to
`.gitignore` also?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yittg commented on a change in pull request #5013: [pulsar-client-cpp] cmake isolate auto gen srcs
yittg commented on a change in pull request #5013: [pulsar-client-cpp] cmake
isolate auto gen srcs
URL: https://github.com/apache/pulsar/pull/5013#discussion_r316883740
##
File path: pulsar-client-cpp/CMakeLists.txt
##
@@ -195,9 +195,13 @@ MESSAGE(STATUS "HAS_SNAPPY: ${HAS_SNAPPY}")
set(ADDITIONAL_LIBRARIES $ENV{PULSAR_ADDITIONAL_LIBRARIES})
link_directories( $ENV{PULSAR_ADDITIONAL_LIBRARY_PATH} )
+set(AUTOGEN_DIR ${CMAKE_BINARY_DIR}/generated)
Review comment:
@merlimat not necessary for now as files would be ignored by `pd.{cc,h}`
suffix, it would be great to add `generated` directory, and the suffix pattern
could be removed, i'll add it. Actually i always new a `build| directory for
cmake, would we suggest to do like that and add `build` directory to .gitignore
also?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
