[GitHub] jerrypeng commented on issue #2642: Duplicate classes caught by maven-enforcer-plugin

2018-10-04 Thread GitBox
jerrypeng commented on issue #2642: Duplicate classes caught by 
maven-enforcer-plugin
URL: https://github.com/apache/pulsar/issues/2642#issuecomment-427212316
 
 
   @MarkAddison the multiple version of dependencies has to deal with protobuf 
2.0 vs 3.0.  In more recent code we started using protobuf 3.0 because of its 
integration with GRPC (2.0 does not work very well).  Thus, in some places we 
are using protobuf 2.0, while in other places we are using 3.0.  Eventually we 
will probably migrate everything to use protobuf 3 but that hasn't been done 
yet.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jerrypeng commented on issue #2642: Duplicate classes caught by maven-enforcer-plugin

2018-09-27 Thread GitBox
jerrypeng commented on issue #2642: Duplicate classes caught by 
maven-enforcer-plugin
URL: https://github.com/apache/pulsar/issues/2642#issuecomment-425254004
 
 
   The reason this happens if because in Pulsar different modules depend on 
different version of the same dependencies.  While I think there is a way to 
fix it, I am not sure how much benefit it will actually bring.  @MarkAddison is 
this a critical issue for you?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services