[GitHub] srkukarni commented on issue #2546: Elastic connector
srkukarni commented on issue #2546: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2546#issuecomment-419724450 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] david-streamlio commented on issue #2546: Elastic connector
david-streamlio commented on issue #2546: Elastic connector
URL: https://github.com/apache/incubator-pulsar/pull/2546#issuecomment-419734115
How do I view the actual cause of the error..
org.apache.pulsar.tests.integration.docker.ContainerExecException:
/pulsar/bin/pulsar-admin sink create --tenant public --namespace default --name
test-sink-connector-elastic_search-THREAD-name-exoiydod --sink-type
elastic_search --sinkConfig
{"elasticSearchUrl":"http://localhost:9200","indexName":"test-index"} --inputs
test-sink-connector-**ELASTIC_SEARCH-THREAD-input-topic-midgxwab failed on
e463877cd694fe13c88a7b3695cabe3c2840fae0f25b095b1483f2c244ad1d05 with error
code 1**
at
org.apache.pulsar.tests.integration.utils.DockerUtils.runCommand(DockerUtils.java:234)
at
org.apache.pulsar.tests.integration.containers.ChaosContainer.execCmd(ChaosContainer.java:109)
at
org.apache.pulsar.tests.integration.functions.PulsarFunctionsTest.submitSinkConnector(PulsarFunctionsTest.java:171)
at
org.apache.pulsar.tests.integration.functions.PulsarFunctionsTest.testSink(PulsarFunctionsTest.java:107)
at
org.apache.pulsar.tests.integration.functions.PulsarFunctionsTest.testElasticSearchSink(PulsarFunctionsTest.java:89)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image
sijie commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419740749 @cckellogg not sure if we can easily change to sqlite. It is probably ok, however I would not suggest changing it right now. Because it requires fair amount of testing. Yes we should update the dashboard. Will create a task to follow up. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kramasamy commented on issue #2545: [docker] introduce a pulsar standalone image
kramasamy commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419741204 @sijie @merlimat - these code seems to be copy of the code under /dashboard. This is not a clean way to do this - since any changes in /dashboard - have to be changed here as well. Is there a way to build the docker directly from the files under /dashboard ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image
sijie commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419741657 We can’t do it, because docker doesn’t allow accessing files outside the dockerfile directory. To deliver this ASAP, we have to copy the files This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cckellogg commented on issue #2545: [docker] introduce a pulsar standalone image
cckellogg commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419742245 Is that a maven issue? There is a way to point to a specific file when do a docker build "$ docker build -f /path/to/a/Dockerfile ." https://docs.docker.com/engine/reference/builder/#usage Would this work so the files are not copied? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cckellogg edited a comment on issue #2545: [docker] introduce a pulsar standalone image
cckellogg edited a comment on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419742245 Is that a maven issue? There is a way to point to a specific file when doing a docker build "$ docker build -f /path/to/a/Dockerfile ." https://docs.docker.com/engine/reference/builder/#usage Would this work so the files are not copied? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image
sijie commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419743264 you can point to a location of a dockerfile. But in the dockerfile defintion, you can’t access files not in the same dir as the dockerfile, and you can’t use symlinks as well. That’s why on building pulsar image, we copy the packages to the dockerfile dir. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kramasamy commented on issue #2545: [docker] introduce a pulsar standalone image
kramasamy commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419744589 Another options is move the dockerfile to the top. Duplicating code and config will be difficult to manage as time goes on Sent from my iPhone > On Sep 9, 2018, at 1:36 PM, Sijie Guo wrote: > > you can point to a location of a dockerfile. But in the dockerfile defintion, you can’t access files not in the same dir as the dockerfile, and you can’t use symlinks as well. That’s why on building pulsar image, we copy the packages to the dockerfile dir. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub, or mute the thread. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image
sijie commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419746688 Sure. We can reorganize modules to do that. but it will take some time to make sure it doesn’t break others like CI, release process and such. Thats why I didn’t do that for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed pull request #2529: Added cmake install for lib and headers
sijie closed pull request #2529: Added cmake install for lib and headers
URL: https://github.com/apache/incubator-pulsar/pull/2529
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pulsar-client-cpp/lib/CMakeLists.txt
b/pulsar-client-cpp/lib/CMakeLists.txt
index 5b2dbf9139..2116ed65a9 100644
--- a/pulsar-client-cpp/lib/CMakeLists.txt
+++ b/pulsar-client-cpp/lib/CMakeLists.txt
@@ -45,3 +45,7 @@ set_target_properties(pulsarShared PROPERTIES OUTPUT_NAME
${LIB_NAME} VERSION ${
target_link_libraries(pulsarStatic ${COMMON_LIBS})
target_link_libraries(pulsarShared ${COMMON_LIBS})
+install(TARGETS pulsarStatic DESTINATION lib)
+install(TARGETS pulsarShared DESTINATION lib)
+
+install(DIRECTORY "../include/pulsar" DESTINATION include)
\ No newline at end of file
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[incubator-pulsar] branch master updated: Added cmake install for lib and headers (#2529)
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 1c72ac3 Added cmake install for lib and headers (#2529)
1c72ac3 is described below
commit 1c72ac3fb1d20b4f12300c4d339cb1a383d718ae
Author: Matteo Merli
AuthorDate: Sun Sep 9 16:50:49 2018 -0700
Added cmake install for lib and headers (#2529)
### Motivation
Added `install` target to do local install for C++ client lib
---
pulsar-client-cpp/lib/CMakeLists.txt | 4
1 file changed, 4 insertions(+)
diff --git a/pulsar-client-cpp/lib/CMakeLists.txt
b/pulsar-client-cpp/lib/CMakeLists.txt
index 5b2dbf9..2116ed6 100644
--- a/pulsar-client-cpp/lib/CMakeLists.txt
+++ b/pulsar-client-cpp/lib/CMakeLists.txt
@@ -45,3 +45,7 @@ set_target_properties(pulsarShared PROPERTIES OUTPUT_NAME
${LIB_NAME} VERSION ${
target_link_libraries(pulsarStatic ${COMMON_LIBS})
target_link_libraries(pulsarShared ${COMMON_LIBS})
+install(TARGETS pulsarStatic DESTINATION lib)
+install(TARGETS pulsarShared DESTINATION lib)
+
+install(DIRECTORY "../include/pulsar" DESTINATION include)
\ No newline at end of file
[GitHub] sijie closed pull request #2511: [documentation] Add section about licensing at contribution guide
sijie closed pull request #2511: [documentation] Add section about licensing at contribution guide URL: https://github.com/apache/incubator-pulsar/pull/2511 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/site2/website/contributing.md b/site2/website/contributing.md index 9552244daa..310045a08c 100644 --- a/site2/website/contributing.md +++ b/site2/website/contributing.md @@ -181,6 +181,15 @@ Then you can push your local, committed changes to your (forked) repository on G All code should have appropriate unit testing coverage. New code should have new tests in the same contribution. Bug fixes should include a regression test to prevent the issue from reoccurring. +### Licensing + +All code contributed to Pulsar will be licensed under [Apache License V2](https://www.apache.org/licenses/LICENSE-2.0). You need to ensure every new files you are adding have the right +license header. You can add license header to your files by running following command: + +```shell +$ mvn license:format +``` + ### Develop C++/Python Client Currently C++ and Python client are developed under `pulsar-client-cpp` directory. You can use following commands to build and test your c++ or python code changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #2500: [schema] add schemas for primtive types
sijie commented on issue #2500: [schema] add schemas for primtive types URL: https://github.com/apache/incubator-pulsar/pull/2500#issuecomment-419754258 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-pulsar] branch master updated: [documentation] Add section about licensing at contribution guide (#2511)
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3e9a445 [documentation] Add section about licensing at contribution guide (#2511) 3e9a445 is described below commit 3e9a445e9ced577c1e494875e9a490c3dee9a5ab Author: Sijie Guo AuthorDate: Sun Sep 9 16:51:03 2018 -0700 [documentation] Add section about licensing at contribution guide (#2511) --- site2/website/contributing.md | 9 + 1 file changed, 9 insertions(+) diff --git a/site2/website/contributing.md b/site2/website/contributing.md index 9552244..310045a 100644 --- a/site2/website/contributing.md +++ b/site2/website/contributing.md @@ -181,6 +181,15 @@ Then you can push your local, committed changes to your (forked) repository on G All code should have appropriate unit testing coverage. New code should have new tests in the same contribution. Bug fixes should include a regression test to prevent the issue from reoccurring. +### Licensing + +All code contributed to Pulsar will be licensed under [Apache License V2](https://www.apache.org/licenses/LICENSE-2.0). You need to ensure every new files you are adding have the right +license header. You can add license header to your files by running following command: + +```shell +$ mvn license:format +``` + ### Develop C++/Python Client Currently C++ and Python client are developed under `pulsar-client-cpp` directory. You can use following commands to build and test your c++ or python code changes.
[GitHub] YuiFn opened a new pull request #2547: Merge pull request #1 from apache/master
YuiFn opened a new pull request #2547: Merge pull request #1 from apache/master URL: https://github.com/apache/incubator-pulsar/pull/2547 merge remote ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to solve. ### Modifications Describe the modifications you've done. ### Result After your change, what will change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YuiFn closed pull request #2547: Merge pull request #1 from apache/master
YuiFn closed pull request #2547: Merge pull request #1 from apache/master URL: https://github.com/apache/incubator-pulsar/pull/2547 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rdhabalia opened a new pull request #2548: Stop all functions gracefully on closing worker-service
rdhabalia opened a new pull request #2548: Stop all functions gracefully on closing worker-service URL: https://github.com/apache/incubator-pulsar/pull/2548 ### Motivation Right now, if stopping [WorkerService](https://github.com/apache/incubator-pulsar/blob/master/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerService.java#L189) doesn't stop functions and all the threads stayed alive event `WorkerService` is stopped. ### Modifications Stop all function resource gracefully while stopping worker service. ### Result Function threads will not stay alive while stopping worker-service. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] snoodleboot commented on issue #271: Consider using gRPC as an externally exposed API
snoodleboot commented on issue #271: Consider using gRPC as an externally exposed API URL: https://github.com/apache/incubator-pulsar/issues/271#issuecomment-419781785 I would love to see this! I can understand about pub/sub. It really doesn't serve the same purpose as Pulsar or any distributed log. Different use cases. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codelipenghui commented on a change in pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC…
codelipenghui commented on a change in pull request #2543: Add
ServiceUrlProvider and add method forceCloseConnection in PulsarC…
URL: https://github.com/apache/incubator-pulsar/pull/2543#discussion_r216212676
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
##
@@ -706,6 +706,58 @@ public void shutdown() throws PulsarClientException {
}
}
+@Override
+public void forceCloseConnection() {
+if (this.producers != null) {
Review comment:
@merlimat I'm already fix it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
