[GitHub] ivankelly commented on a change in pull request #1132: Explicitly set zookeeper version in broker
ivankelly commented on a change in pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164565853 ## File path: pom.xml ## @@ -741,7 +761,7 @@ flexible messaging model and an intuitive client API. maven-compiler-plugin - 2.3.2 + 3.7.0 Review comment: oops, i didn't mean to push this. Will remove. Though it would be nice to get the other one in, as I end up changing this a couple of times a day. I rekicked a build on it earlier. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ivankelly commented on a change in pull request #1132: Explicitly set zookeeper version in broker
ivankelly commented on a change in pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164565510 ## File path: pom.xml ## @@ -180,7 +200,7 @@ flexible messaging model and an intuitive client API. log4j -org.jboss.netty +io.netty Review comment: 3.4.6 is already on the io groupId http://search.maven.org/#artifactdetails%7Corg.apache.zookeeper%7Czookeeper%7C3.4.6%7Cpom This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ivankelly commented on a change in pull request #1132: Explicitly set zookeeper version in broker
ivankelly commented on a change in pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164548657 ## File path: pulsar-broker/pom.xml ## @@ -119,6 +119,34 @@ test + Review comment: Ah, will move it there. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
