[GitHub] ivankelly commented on issue #1044: Compact algo
ivankelly commented on issue #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#issuecomment-361366560 @merlimat CI is green now. I can push some more changes if this gets merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ivankelly commented on issue #1044: Compact algo
ivankelly commented on issue #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#issuecomment-359859998 @sijie I started poking at changing a bit to async and ended up doing the whole lot. Still though, the algorithm isn't safe until we have #1066 as we may only compact a prefix of whatever is already compacted. We can move forward with it as it is though, and update once #1066 is in. #1066 should make the tests much faster too. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ivankelly commented on issue #1044: Compact algo
ivankelly commented on issue #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#issuecomment-358322139 Going to wait for #1066 so the algorithm can be made async. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ivankelly commented on issue #1044: Compact algo
ivankelly commented on issue #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#issuecomment-357644735 Based on #1039, only the second commit should be reviewed here This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ivankelly commented on issue #1044: Compact algo
ivankelly commented on issue #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#issuecomment-357644453 @merlimat @sijie could I get a review on this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ivankelly commented on issue #1044: Compact algo
ivankelly commented on issue #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#issuecomment-356340028 Implements #967 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
