[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388435528 I discussed with @srkukarni and we are going to leave the KakfaSource as it is for now This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388279505 @srkukarni but isn't that just the same as using the PushSource but instead you a pulling the queuing logic back into the KafkaSource? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388277056 @srkukarni using a push source might be more efficient since not we are doing async reads in a sense. Remember the actual source called synchronously. It can only process on tuple at a time This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388277056 @srkukarni using a push source might be more efficient since not we are doing async reads in a sense. Remember the actual source is synchronous. It can only process on tuple at a time This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388277056 @srkukarni using a push source might be more efficient since not we are doing async reads in a sense. Remember the actual source synchronous. It can only process on tuple at a time This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388277056 @srkukarni user a push source might be more efficient since not we are doing async reads in a sense. Remember the actual source synchronous. It can only process on tuple at a time This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388276631 @srkukarni are you suggesting we poll one tuple at a time? e.g. onsumerRecords = consumer.poll(1); is that efficient? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388271445 @sijie @srkukarni please review This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
