[GitHub] lucperkins commented on issue #1531: remove unnecessary proto def in FunctionsConfig
lucperkins commented on issue #1531: remove unnecessary proto def in FunctionsConfig URL: https://github.com/apache/incubator-pulsar/pull/1531#issuecomment-379927094 @jerrypeng As far as I can tell this *is* necessary for users to be able to specify FQFN in a function's YAML config, like so: ```yaml jar: my-jar.jar className: org.example.functions.MyFunction inputs: - persistent://sample/standalone/ns1/in output: persistent://sample/standalone/ns1/out fqfn: sample/ns1/my-func ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lucperkins commented on issue #1531: remove unnecessary proto def in FunctionsConfig
lucperkins commented on issue #1531: remove unnecessary proto def in FunctionsConfig URL: https://github.com/apache/incubator-pulsar/pull/1531#issuecomment-379927094 @jerrypeng As far as I can tell this *is* necessary for users to be able to specify FQFN in a function's YAML config, like so: ```yaml jar: my-jar.jar className: org.example.functions.MyFunction inputs: - persistent://sample/standalone/ns1/in output: persistent://sample/standalone/ns1/out fqfn: sample/ns1/my-func ``` At the moment, the `FunctionConfig` class that's generated from that Protobuf file powers the whole YAML config system. I'm not sure if that's optimal but for now it's the system that's in place. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lucperkins commented on issue #1531: remove unnecessary proto def in FunctionsConfig
lucperkins commented on issue #1531: remove unnecessary proto def in FunctionsConfig URL: https://github.com/apache/incubator-pulsar/pull/1531#issuecomment-379930880 @srkukarni I feel like FQFN should be settable either via the command line *and* via YAML or neither. Inconsistent interfaces will likely sow a lot of unnecessary confusion. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lucperkins commented on issue #1531: remove unnecessary proto def in FunctionsConfig
lucperkins commented on issue #1531: remove unnecessary proto def in FunctionsConfig URL: https://github.com/apache/incubator-pulsar/pull/1531#issuecomment-380207479 I think the underlying issue here is that using a Protobuf definition as a source of truth for configuration management is an anti-pattern in itself. At some point we should strongly consider using a more native approach. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
