massakam opened a new pull request #1977: Enable listener to receive messages 
even if receiver queue size is zero
URL: https://github.com/apache/incubator-pulsar/pull/1977
 
 
   ### Motivation
   
   If `receiverQueueSize` is set to 0, consumer using message listener can not 
receive any messages.
   I think there are two causes:
   
   - The consumer does not send flow command when the connection has been opened
   - Even if the client receive a message, the message is not added to 
`incomingMessages` so the listener can not handle it
   
   ### Modifications
   
   If the queue size is zero and the message listener is registered,
   
   - the client sends a flow command when the connection has been opened
   - the received message is passed directly to the listener without being 
added to `incomingMessages`
   
   I am not confident about this change, so please review carefully.
   
   ### Result
   
   Even if the queue size is zero, the message listener can process the 
received messages.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to