[GitHub] merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker
merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164583151 ## File path: pom.xml ## @@ -180,7 +200,7 @@ flexible messaging model and an intuitive client API. log4j -org.jboss.netty +io.netty Review comment: Got it, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker
merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164565191 ## File path: pom.xml ## @@ -741,7 +761,7 @@ flexible messaging model and an intuitive client API. maven-compiler-plugin - 2.3.2 + 3.7.0 Review comment: I was seeing the errors in the other PR but wasn't able to figure out why would those test be failing with the newer compiler plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker
merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164564840 ## File path: pom.xml ## @@ -180,7 +200,7 @@ flexible messaging model and an intuitive client API. log4j -org.jboss.netty +io.netty Review comment: This one is actually the version of netty 3 used by ZK client This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker
merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164501056 ## File path: pulsar-broker/pom.xml ## @@ -119,6 +119,34 @@ test + Review comment: I think the issue is that we're not specifying ZK in the `` section like most other dependencies. Right now we only have the `tests` ZK artifact defined there: https://github.com/apache/incubator-pulsar/blob/master/pom.xml#L168 Once we set it in the `dependencyManagement` it will override the ZK version for all the modules in the project (and transitive dependencies) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
