[GitHub] merlimat commented on issue #1381: Schema registry 4/N

2018-04-05 Thread GitBox
merlimat commented on issue #1381: Schema registry 4/N
URL: https://github.com/apache/incubator-pulsar/pull/1381#issuecomment-379106872
 
 
   @mgodave there is a conflict with a change that went into master again, 
sorry. 
   
   I had changed `getTopicReference()` to return `Optional`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] merlimat commented on issue #1381: Schema registry 4/N

2018-04-03 Thread GitBox
merlimat commented on issue #1381: Schema registry 4/N
URL: https://github.com/apache/incubator-pulsar/pull/1381#issuecomment-378411591
 
 
   @mgodave please merge with master again and it should go through CI this 
time.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] merlimat commented on issue #1381: Schema registry 4/N

2018-04-02 Thread GitBox
merlimat commented on issue #1381: Schema registry 4/N
URL: https://github.com/apache/incubator-pulsar/pull/1381#issuecomment-378077331
 
 
   @mgodave  there's a file that's missing the license header: 
`ProducerResponse.java`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services