[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image

2018-09-10 Thread GitBox
sijie commented on issue #2545: [docker] introduce a pulsar standalone image
URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-420001590
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image

2018-09-09 Thread GitBox
sijie commented on issue #2545: [docker] introduce a pulsar standalone image
URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419746688
 
 
   Sure. We can reorganize modules to do that. but it will take some time to 
make sure it doesn’t break others like CI, release process and such. Thats why 
I didn’t do that for this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image

2018-09-09 Thread GitBox
sijie commented on issue #2545: [docker] introduce a pulsar standalone image
URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419743264
 
 
   you can point to a location of a dockerfile. But in the dockerfile 
defintion, you can’t access files not in the same dir as the dockerfile, and 
you can’t use symlinks as well. That’s why on building pulsar image, we copy 
the packages to the dockerfile dir. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image

2018-09-09 Thread GitBox
sijie commented on issue #2545: [docker] introduce a pulsar standalone image
URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419741657
 
 
   We can’t do it, because docker doesn’t allow accessing files outside the 
dockerfile directory. To deliver this ASAP, we have to copy the files 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image

2018-09-09 Thread GitBox
sijie commented on issue #2545: [docker] introduce a pulsar standalone image
URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419740749
 
 
   @cckellogg not sure if we can easily change to sqlite. It is probably ok, 
however I would not suggest changing it right now. Because it requires fair 
amount of testing.
   
   Yes we should update the dashboard. Will create a task to follow up.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image

2018-09-07 Thread GitBox
sijie commented on issue #2545: [docker] introduce a pulsar standalone image
URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419582422
 
 
   @cckellogg ^^


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services