[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358439676 @merlimat yes, It is related to the changes i made to `public ByteBuffer[] nioBuffers()`, they are not feasible right now, I made them based on wrong assumptions. I will leave the only really needed change. It will be best to just try to dump `DoubleByteBuf` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358375422 @merlimat we need to change this in yahoo's fork of bookkeeper as well, I made a PR https://github.com/yahoo/bookkeeper/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358368557 > @sschepens Regarding the merge access, probably you have check again https://gitbox.apache.org/setup/ I was missing the apache foundation invitation, found it :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358096761 > Can you check a different PR that is already approved and with tests passing to see if you have the green merge button? Eg: #1038 No merge button, only comment > Yes, at least it should fix the failing tests. Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358091287 > There are some tests failing (otherwise you should be able to merge). I think they're not related to the DoubleByteBuf change, though they might be releated to the netty upgrade to 4.1.19 Shall i leave netty upgrade to another PR? We probably need to update yahoo/bookkeeer to 4.1.19 as well. I thought I had merge permissions as well @merlimat but it seems I don't This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-357724800 @merlimat can you merge this? I don't have permissions This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-357036886 @merlimat When flushing writing multiple messages they are sort of queued inside a `ChannelOutboundBuffer` which is a sort of linked list, this could cause allocations as well, I really don't know which is better. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-357043076 I think it's more troublesome to have it as a holder, we would have to change a lot of files with probably little benefit. The changes I made here should be the same or slightly better than previously This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-357036886 @merlimat When flushing writing multiple messages they are sort of queued inside a `ChannelOutboundBuffer` which is a sort of linked list, this could cause [allocations](https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java#L113) as well, I really don't know which is better. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-357036886 @merlimat When flushing writing multiple messages they are sort of queued inside a `ChannelOutboundBuffer` which is a sort of linked list, this causes [allocations](https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java#L113) as well, I really don't know which is better. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-357036886 @merlimat When flushing writing multiple messages they are sort of queued inside a `ChannelOutboundBuffer` which is a sort of linked list, this causes [allocations](https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java#L113) as well, I really don't know which is better. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-356990524 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-356990524 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
