This is an automated email from the ASF dual-hosted git repository. cliffjansen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/qpid-proton.git
The following commit(s) were added to refs/heads/main by this push: new af4382b85 PROTON-2699: disable fdlimit test by default af4382b85 is described below commit af4382b85fac30a5a352fd0057d67a04113f610d Author: Clifford Jansen <cliffjan...@apache.org> AuthorDate: Wed Mar 29 23:27:10 2023 -0700 PROTON-2699: disable fdlimit test by default --- c/tests/CMakeLists.txt | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/c/tests/CMakeLists.txt b/c/tests/CMakeLists.txt index 2645ba5f8..83f6e2213 100644 --- a/c/tests/CMakeLists.txt +++ b/c/tests/CMakeLists.txt @@ -115,14 +115,21 @@ if (CMAKE_CXX_COMPILER) set(pypath "${CMAKE_SOURCE_DIR}/tests/py") - # unset TEST_EXE_PREFIX as valgrind does not run successfully when fds are limited - pn_add_test( - UNWRAPPED - NAME c-fdlimit-tests - PREPEND_ENVIRONMENT "PATH=${path}" "PYTHONPATH=${pypath}" "${test_env}" - APPEND_ENVIRONMENT "TEST_EXE_PREFIX=" - WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} - COMMAND ${Python_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/fdlimit.py) + # Disable fdlimit test by default. Flaky throughout its history and implemntations. + # Very useful for proactor development, so keep around. + set(DEFAULT_FDLIMIT OFF) + option(FDLIMIT "Run the fdlimit recovery test" ${DEFAULT_FDLIMIT}) + if (FDLIMIT) + # unset TEST_EXE_PREFIX as valgrind does not run successfully when fds are limited + pn_add_test( + UNWRAPPED + NAME c-fdlimit-tests + PREPEND_ENVIRONMENT "PATH=${path}" "PYTHONPATH=${pypath}" "${test_env}" + APPEND_ENVIRONMENT "TEST_EXE_PREFIX=" + WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} + COMMAND ${Python_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/fdlimit.py) + endif() + endif(HAS_PROACTOR) if(HAS_TLS) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org For additional commands, e-mail: commits-h...@qpid.apache.org