This is an automated email from the ASF dual-hosted git repository.

cliffjansen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-proton.git


The following commit(s) were added to refs/heads/master by this push:
     new 06833ac  PROTON-2292: TSAN failure in epoll_timer.c.  Replace missing 
lock spotted by TSAN and Coverity.
06833ac is described below

commit 06833acb10f30343d1e2e970a31e11cb290e32ff
Author: Cliff Jansen <cliffjan...@apache.org>
AuthorDate: Mon Nov 9 00:25:31 2020 -0800

    PROTON-2292: TSAN failure in epoll_timer.c.  Replace missing lock spotted 
by TSAN and Coverity.
---
 c/src/proactor/epoll_timer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/c/src/proactor/epoll_timer.c b/c/src/proactor/epoll_timer.c
index 58f0211..6c7c3db 100644
--- a/c/src/proactor/epoll_timer.c
+++ b/c/src/proactor/epoll_timer.c
@@ -287,6 +287,7 @@ void pni_timer_set(pni_timer_t *timer, uint64_t deadline) {
 
 pn_event_batch_t *pni_timer_manager_process(pni_timer_manager_t *tm, bool 
timeout, bool wake) {
   uint64_t now = pn_proactor_now_64();
+  lock(&tm->context.mutex);
   tm->context.working = true;
   if (timeout)
     tm->timerfd_deadline = 0;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org
For additional commands, e-mail: commits-h...@qpid.apache.org

Reply via email to