Re: [I] [OPTIMIZATION] Change the broker default value configuration of 'useServerSideResetOffset' [rocketmq]
echooymxq commented on issue #5613: URL: https://github.com/apache/rocketmq/issues/5613#issuecomment-1820324030 > At that time, the switch was not turned on by default to carefully evaluate the impact of server-side offset management on ha implementation. @RongtongJin @mxsm Can u help evaluate it? @lizhimins Why might there be an impact? if the slave read enable ??🤔️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: ca721b0145994d7f5e67b4d2fe3b7a4ad7a1c132 / zhanghong <985492...@qq.com> [ISSUE #7462] Remove deprecated LocalTransactionExecuter (#7463) Report URL: https://github.com/apache/rocketmq/actions/runs/6939911220 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: ca721b0145994d7f5e67b4d2fe3b7a4ad7a1c132 / zhanghong <985492...@qq.com> [ISSUE #7462] Remove deprecated LocalTransactionExecuter (#7463) Report URL: https://github.com/apache/rocketmq/actions/runs/6939911217 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 63130f51e84bda2547c3aa442f14184ccefb9180 / lizhimins <707364...@qq.com> [ISSUE #7545] [RIP-65] Support efficient random index for massive messages (#7546) Support efficient random index for massive messages Co-authored-by: bareheadtom <1983697...@qq.com> Report URL: https://github.com/apache/rocketmq/actions/runs/6939864402 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #4778] Design of optimize log transfer protocol [rocketmq]
lizhimins closed pull request #4780: [ISSUE #4778] Design of optimize log transfer protocol URL: https://github.com/apache/rocketmq/pull/4780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 63130f51e84bda2547c3aa442f14184ccefb9180 / lizhimins <707364...@qq.com> [ISSUE #7545] [RIP-65] Support efficient random index for massive messages (#7546) Support efficient random index for massive messages Co-authored-by: bareheadtom <1983697...@qq.com> Report URL: https://github.com/apache/rocketmq/actions/runs/6939864403 With regards, GitHub Actions via GitBox
(rocketmq) branch develop updated: [ISSUE #7462] Remove deprecated LocalTransactionExecuter (#7463)
This is an automated email from the ASF dual-hosted git repository.
lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new ca721b0145 [ISSUE #7462] Remove deprecated LocalTransactionExecuter
(#7463)
ca721b0145 is described below
commit ca721b0145994d7f5e67b4d2fe3b7a4ad7a1c132
Author: zhanghong <985492...@qq.com>
AuthorDate: Tue Nov 21 14:03:24 2023 +0800
[ISSUE #7462] Remove deprecated LocalTransactionExecuter (#7463)
---
.../impl/producer/DefaultMQProducerImpl.java | 9
.../client/producer/DefaultMQProducer.java | 16 -
.../client/producer/LocalTransactionExecuter.java | 27 --
.../rocketmq/client/producer/MQProducer.java | 3 ---
.../client/producer/TransactionMQProducer.java | 16 -
.../api/client.producer.DefaultMQProducer.schema | 1 -
6 files changed, 4 insertions(+), 68 deletions(-)
diff --git
a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
index b0c212e46b..545f17d931 100644
---
a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
+++
b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
@@ -54,7 +54,6 @@ import org.apache.rocketmq.client.latency.MQFaultStrategy;
import org.apache.rocketmq.client.latency.Resolver;
import org.apache.rocketmq.client.latency.ServiceDetector;
import org.apache.rocketmq.client.producer.DefaultMQProducer;
-import org.apache.rocketmq.client.producer.LocalTransactionExecuter;
import org.apache.rocketmq.client.producer.LocalTransactionState;
import org.apache.rocketmq.client.producer.MessageQueueSelector;
import org.apache.rocketmq.client.producer.RequestCallback;
@@ -1379,10 +1378,10 @@ public class DefaultMQProducerImpl implements
MQProducerInner {
}
public TransactionSendResult sendMessageInTransaction(final Message msg,
-final LocalTransactionExecuter localTransactionExecuter, final Object
arg)
+final TransactionListener localTransactionListener, final Object arg)
throws MQClientException {
TransactionListener transactionListener = getCheckListener();
-if (null == localTransactionExecuter && null == transactionListener) {
+if (null == localTransactionListener && null == transactionListener) {
throw new MQClientException("tranExecutor is null", null);
}
@@ -1414,8 +1413,8 @@ public class DefaultMQProducerImpl implements
MQProducerInner {
if (null != transactionId && !"".equals(transactionId)) {
msg.setTransactionId(transactionId);
}
-if (null != localTransactionExecuter) {
-localTransactionState =
localTransactionExecuter.executeLocalTransactionBranch(msg, arg);
+if (null != localTransactionListener) {
+localTransactionState =
localTransactionListener.executeLocalTransaction(msg, arg);
} else {
log.debug("Used new transaction API");
localTransactionState =
transactionListener.executeLocalTransaction(msg, arg);
diff --git
a/client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java
b/client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java
index c5b1b52230..7bd3876f5a 100644
---
a/client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java
+++
b/client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java
@@ -853,22 +853,6 @@ public class DefaultMQProducer extends ClientConfig
implements MQProducer {
this.defaultMQProducerImpl.sendOneway(msg, selector, arg);
}
-/**
- * This method is to send transactional messages.
- *
- * @param msg Transactional message to send.
- * @param tranExecuter local transaction executor.
- * @param arg Argument used along with local transaction executor.
- * @return Transaction result.
- * @throws MQClientException if there is any client error.
- */
-@Override
-public TransactionSendResult sendMessageInTransaction(Message msg,
LocalTransactionExecuter tranExecuter,
-final Object arg)
-throws MQClientException {
-throw new RuntimeException("sendMessageInTransaction not implement,
please use TransactionMQProducer class");
-}
-
/**
* This method is used to send transactional messages.
*
diff --git
a/client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecuter.java
b/client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecuter.java
deleted file
Re: [I] [Enhancement] remove Deprecated class [rocketmq]
lizhimins closed issue #7462: [Enhancement] remove Deprecated class URL: https://github.com/apache/rocketmq/issues/7462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7462] Remove deprecated LocalTransactionExecuter [rocketmq]
lizhimins merged PR #7463: URL: https://github.com/apache/rocketmq/pull/7463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 63130f51e84bda2547c3aa442f14184ccefb9180 / lizhimins <707364...@qq.com> [ISSUE #7545] [RIP-65] Support efficient random index for massive messages (#7546) Support efficient random index for massive messages Co-authored-by: bareheadtom <1983697...@qq.com> Report URL: https://github.com/apache/rocketmq/actions/runs/6939864396 With regards, GitHub Actions via GitBox
(rocketmq) branch develop updated: [ISSUE #7545] [RIP-65] Support efficient random index for massive messages (#7546)
This is an automated email from the ASF dual-hosted git repository.
lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 63130f51e8 [ISSUE #7545] [RIP-65] Support efficient random index for
massive messages (#7546)
63130f51e8 is described below
commit 63130f51e84bda2547c3aa442f14184ccefb9180
Author: lizhimins <707364...@qq.com>
AuthorDate: Tue Nov 21 13:57:44 2023 +0800
[ISSUE #7545] [RIP-65] Support efficient random index for massive messages
(#7546)
Support efficient random index for massive messages
Co-authored-by: bareheadtom <1983697...@qq.com>
---
style/spotbugs-suppressions.xml| 2 +-
tieredstore/pom.xml| 14 +
.../rocketmq/tieredstore/TieredMessageFetcher.java | 103 ++---
.../tieredstore/file/CompositeQueueFlatFile.java | 29 +-
.../tieredstore/file/TieredConsumeQueue.java | 2 +-
.../rocketmq/tieredstore/file/TieredFlatFile.java | 5 +-
.../tieredstore/file/TieredFlatFileManager.java| 40 +-
.../rocketmq/tieredstore/file/TieredIndexFile.java | 470 ---
.../rocketmq/tieredstore/index/IndexFile.java | 35 ++
.../rocketmq/tieredstore/index/IndexItem.java | 114 +
.../rocketmq/tieredstore/index/IndexService.java | 62 +++
.../rocketmq/tieredstore/index/IndexStoreFile.java | 499 +
.../tieredstore/index/IndexStoreService.java | 362 +++
.../tieredstore/provider/TieredFileSegment.java| 9 +-
.../tieredstore/provider/TieredStoreProvider.java | 10 +-
.../provider/posix/PosixFileSegment.java | 1 +
.../tieredstore/TieredMessageFetcherTest.java | 17 +-
.../tieredstore/file/TieredIndexFileTest.java | 93
.../rocketmq/tieredstore/index/IndexItemTest.java | 91
.../tieredstore/index/IndexStoreFileTest.java | 282
.../index/IndexStoreServiceBenchTest.java | 147 ++
.../tieredstore/index/IndexStoreServiceTest.java | 313 +
.../tieredstore/util/MessageBufferUtilTest.java| 1 -
.../src/test/resources/rmq.logback-test.xml| 15 +-
24 files changed, 2019 insertions(+), 697 deletions(-)
diff --git a/style/spotbugs-suppressions.xml b/style/spotbugs-suppressions.xml
index 5778695e1e..6443e029fa 100644
--- a/style/spotbugs-suppressions.xml
+++ b/style/spotbugs-suppressions.xml
@@ -31,7 +31,7 @@
-
+
diff --git a/tieredstore/pom.xml b/tieredstore/pom.xml
index b2ea40bf3a..9f2a8bf228 100644
--- a/tieredstore/pom.xml
+++ b/tieredstore/pom.xml
@@ -53,5 +53,19 @@
commons-io
test
+
+
+org.openjdk.jmh
+jmh-core
+1.36
+provided
+
+
+
+org.openjdk.jmh
+jmh-generator-annprocess
+1.36
+provided
+
diff --git
a/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageFetcher.java
b/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageFetcher.java
index c948fa3fa1..f739773eb3 100644
---
a/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageFetcher.java
+++
b/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageFetcher.java
@@ -31,6 +31,7 @@ import java.util.concurrent.CompletableFuture;
import java.util.concurrent.TimeUnit;
import javax.annotation.Nullable;
import org.apache.commons.lang3.tuple.Pair;
+import org.apache.rocketmq.common.BoundaryType;
import org.apache.rocketmq.common.message.MessageQueue;
import org.apache.rocketmq.logging.org.slf4j.Logger;
import org.apache.rocketmq.logging.org.slf4j.LoggerFactory;
@@ -50,7 +51,8 @@ import org.apache.rocketmq.tieredstore.file.CompositeFlatFile;
import org.apache.rocketmq.tieredstore.file.CompositeQueueFlatFile;
import org.apache.rocketmq.tieredstore.file.TieredConsumeQueue;
import org.apache.rocketmq.tieredstore.file.TieredFlatFileManager;
-import org.apache.rocketmq.tieredstore.file.TieredIndexFile;
+import org.apache.rocketmq.tieredstore.index.IndexItem;
+import org.apache.rocketmq.tieredstore.index.IndexService;
import org.apache.rocketmq.tieredstore.metadata.TieredMetadataStore;
import org.apache.rocketmq.tieredstore.metadata.TopicMetadata;
import org.apache.rocketmq.tieredstore.metrics.TieredStoreMetricsConstant;
@@ -58,7 +60,6 @@ import
org.apache.rocketmq.tieredstore.metrics.TieredStoreMetricsManager;
import org.apache.rocketmq.tieredstore.util.CQItemBufferUtil;
import org.apache.rocketmq.tieredstore.util.MessageBufferUtil;
import org.apache.rocketmq.tieredstore.util.TieredStoreUtil;
-import org.apache.rocketmq.common.BoundaryType;
public class TieredMessageFetcher implements MessageStoreFetcher {
@@ -555,85 +556,51 @@ public class TieredMessageF
Re: [PR] [ISSUE #7545] [RIP-65] Support efficient random index for massive messages [rocketmq]
lizhimins merged PR #7546: URL: https://github.com/apache/rocketmq/pull/7546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: add topic message type [rocketmq-dashboard]
iamgd67 commented on PR #179: URL: https://github.com/apache/rocketmq-dashboard/pull/179#issuecomment-1820209280 @lizhanhui please review this, this is very useful feacher. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update 05message4.md [rocketmq-site]
leesin9527 opened a new pull request, #607: URL: https://github.com/apache/rocketmq-site/pull/607 Please do not create a Pull Request without creating an issue first. ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user joeCarf (triggered by lizhimins). Head commit for run: 4cfbe183db210b608f2c5639179de8993af2fded / joeCarf fix 7495 Report URL: https://github.com/apache/rocketmq/actions/runs/6650633289 With regards, GitHub Actions via GitBox
Re: [I] [Bug] 判断消息是否拒绝逻辑取反？ org.apache.rocketmq.store.timer.TimerMessageStore#isReject [rocketmq]
1040087877 closed issue #7573: [Bug] 判断消息是否拒绝逻辑取反？ org.apache.rocketmq.store.timer.TimerMessageStore#isReject URL: https://github.com/apache/rocketmq/issues/7573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] 判断消息是否拒绝逻辑取反？ org.apache.rocketmq.store.timer.TimerMessageStore#isReject [rocketmq]
1040087877 commented on issue #7573: URL: https://github.com/apache/rocketmq/issues/7573#issuecomment-1819243555 CLOSE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 9e6a94f0e5c3f22f1b0e23159b2661c7940b0f04 / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6930545611 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 9e6a94f0e5c3f22f1b0e23159b2661c7940b0f04 / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6930545604 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7534]use a new class to replace topiclist in concurrent scene [rocketmq]
lizhimins commented on code in PR #7559: URL: https://github.com/apache/rocketmq/pull/7559#discussion_r1399275718 ## remoting/src/main/java/org/apache/rocketmq/remoting/protocol/body/ConcurrentTopicList.java: ## @@ -0,0 +1,42 @@ +/* Review Comment: 如何判断是这里慢而不是 config json flush 慢呢 ## remoting/src/main/java/org/apache/rocketmq/remoting/protocol/body/ConcurrentTopicList.java: ## @@ -0,0 +1,42 @@ +/* Review Comment: 如何判断是这里慢而不是 config json flush 慢呢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 9e6a94f0e5c3f22f1b0e23159b2661c7940b0f04 / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6930545604 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: a1afabe22d8b9d46f80e570520827a67191a4cd2 / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6929662423 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 8e7e2b5f50e0db14b77462ef1574d4020c0fd986 / guyinyou <36399867+guyin...@users.noreply.github.com> [ISSUE #7574] Fix RunningFlags conflict Co-authored-by: guyinyou Report URL: https://github.com/apache/rocketmq/actions/runs/6930575599 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 9e6a94f0e5c3f22f1b0e23159b2661c7940b0f04 / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6930545604 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: a1afabe22d8b9d46f80e570520827a67191a4cd2 / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6929662423 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 8e7e2b5f50e0db14b77462ef1574d4020c0fd986 / guyinyou <36399867+guyin...@users.noreply.github.com> [ISSUE #7574] Fix RunningFlags conflict Co-authored-by: guyinyou Report URL: https://github.com/apache/rocketmq/actions/runs/6929493397 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: a1afabe22d8b9d46f80e570520827a67191a4cd2 / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6929662419 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: ef9ac31b47df1aa0006a833acee5f390fa184273 / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6929577636 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 8e7e2b5f50e0db14b77462ef1574d4020c0fd986 / guyinyou <36399867+guyin...@users.noreply.github.com> [ISSUE #7574] Fix RunningFlags conflict Co-authored-by: guyinyou Report URL: https://github.com/apache/rocketmq/actions/runs/6929685112 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: ef9ac31b47df1aa0006a833acee5f390fa184273 / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6929577629 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 8e7e2b5f50e0db14b77462ef1574d4020c0fd986 / guyinyou <36399867+guyin...@users.noreply.github.com> [ISSUE #7574] Fix RunningFlags conflict Co-authored-by: guyinyou Report URL: https://github.com/apache/rocketmq/actions/runs/6929493352 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 8e7e2b5f50e0db14b77462ef1574d4020c0fd986 / guyinyou <36399867+guyin...@users.noreply.github.com> [ISSUE #7574] Fix RunningFlags conflict Co-authored-by: guyinyou Report URL: https://github.com/apache/rocketmq/actions/runs/6929605989 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: e5c24a2b2e9155c97938d85f72f013fd8edba09b / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6928462298 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: a1afabe22d8b9d46f80e570520827a67191a4cd2 / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6929662396 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 8e7e2b5f50e0db14b77462ef1574d4020c0fd986 / guyinyou <36399867+guyin...@users.noreply.github.com> [ISSUE #7574] Fix RunningFlags conflict Co-authored-by: guyinyou Report URL: https://github.com/apache/rocketmq/actions/runs/6929493355 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: ef9ac31b47df1aa0006a833acee5f390fa184273 / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6929577630 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: ef9ac31b47df1aa0006a833acee5f390fa184273 / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6929577630 With regards, GitHub Actions via GitBox
(rocketmq) branch develop updated: [ISSUE #7574] Fix RunningFlags conflict
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 8e7e2b5f50 [ISSUE #7574] Fix RunningFlags conflict
8e7e2b5f50 is described below
commit 8e7e2b5f50e0db14b77462ef1574d4020c0fd986
Author: guyinyou <36399867+guyin...@users.noreply.github.com>
AuthorDate: Mon Nov 20 19:32:57 2023 +0800
[ISSUE #7574] Fix RunningFlags conflict
Co-authored-by: guyinyou
---
store/src/main/java/org/apache/rocketmq/store/RunningFlags.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/store/src/main/java/org/apache/rocketmq/store/RunningFlags.java
b/store/src/main/java/org/apache/rocketmq/store/RunningFlags.java
index 91fcb155a6..88b398a77e 100644
--- a/store/src/main/java/org/apache/rocketmq/store/RunningFlags.java
+++ b/store/src/main/java/org/apache/rocketmq/store/RunningFlags.java
@@ -30,7 +30,7 @@ public class RunningFlags {
private static final int FENCED_BIT = 1 << 5;
-private static final int LOGIC_DISK_FULL_BIT = 1 << 5;
+private static final int LOGIC_DISK_FULL_BIT = 1 << 6;
private volatile int flagBits = 0;
Re: [I] [Bug] The values of FENCED_BIT and LOGIC_DISK_FULL_BIT in RunningFlags conflict [rocketmq]
RongtongJin closed issue #7574: [Bug] The values of FENCED_BIT and LOGIC_DISK_FULL_BIT in RunningFlags conflict URL: https://github.com/apache/rocketmq/issues/7574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7574] Fix RunningFlags conflict [rocketmq]
RongtongJin merged PR #7575: URL: https://github.com/apache/rocketmq/pull/7575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix #217 [rocketmq-mqtt]
pingww commented on PR #220: URL: https://github.com/apache/rocketmq-mqtt/pull/220#issuecomment-1818858364 please pr to develop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 54384906ab064289d2ee292d5af6574235f6863b / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6928511192 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 54384906ab064289d2ee292d5af6574235f6863b / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6928511198 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 723a7b972cc11204830131a9a2decfd2bff0552e / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6928220153 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 01a2aef96bdfb17c5f82415141ef421efb4e3bc7 / cnScarb [ISSUE #7570] Add default value for lastPopTimestamp (#7571) Report URL: https://github.com/apache/rocketmq/actions/runs/6928548337 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: e5c24a2b2e9155c97938d85f72f013fd8edba09b / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6928462310 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" is working again!
The GitHub Actions job "PR-CI" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 54384906ab064289d2ee292d5af6574235f6863b / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6928511199 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7545] [RIP-65] Support efficient random index for massive messages [rocketmq]
codecov-commenter commented on PR #7546: URL: https://github.com/apache/rocketmq/pull/7546#issuecomment-1818742778 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `171 lines` in your changes are missing coverage. Please review. > Comparison is base [(`46962c2`)](https://app.codecov.io/gh/apache/rocketmq/commit/46962c262c37554ff09afe9e02c7baf66a5ecc73?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 42.97% compared to head [(`723a7b9`)](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.28%. > Report is 9 commits behind head on develop. > :exclamation: Current head 723a7b9 differs from pull request most recent head 5438490. Consider uploading reports for the commit 5438490 to get more accurate results | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/rocketmq/tieredstore/index/IndexStoreFile.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL2luZGV4L0luZGV4U3RvcmVGaWxlLmphdmE=) | 77.50% | [35 Missing and 19 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../rocketmq/tieredstore/index/IndexStoreService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL2luZGV4L0luZGV4U3RvcmVTZXJ2aWNlLmphdmE=) | 74.86% | [32 Missing and 14 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/rocketmq/tieredstore/TieredMessageFetcher.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL1RpZXJlZE1lc3NhZ2VGZXRjaGVyLmphdmE=) | 0.00% | [28 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...main/java/org/apache/rocketmq/store/CommitLog.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | 59.09% | [7 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...a/org/apache/rocketmq/store/MessageExtEncoder.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL01lc3NhZ2VFeHRFbmNvZGVyLmphdmE=) | 78.26% | [3 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/org/apache/rocketmq/store/MultiDispatch.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL011bHRpRGlzcGF0Y2guamF2YQ==) | 87.09% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rocketmq/common/message/MessageExtBrokerInner.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vbWVzc2FnZS9NZXNzYWdlRXh0QnJva2VySW5uZXIuamF2YQ==) | 25.00% | [3 Missing :warning: ](h
Re: [PR] [ISSUE #7300] jRaft-Controller Implemention [rocketmq]
RongtongJin commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1396960356
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -67,6 +68,13 @@ public class ControllerConfig {
*/
private long scanInactiveMasterInterval = 5 * 1000;
+private int jRaftElectionTimeoutMs = 1000;
+private int jRaftSnapshotIntervalSecs = 3600;
+private String jRaftGroupId = "jRaft-Controller";
+private String jRaftServerId = "localhost:9880";
+private String jRaftInitConf =
"localhost:9880,localhost:9881,localhost:9882";
+private String jRaftControllerRPCAddr =
"localhost:9770,localhost:9771,localhost:9772";
Review Comment:
Moving these configurations to a jraftConfig class will make it clearer.
##
controller/src/main/java/org/apache/rocketmq/controller/impl/JRaftController.java:
##
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.controller.impl;
+
+import com.alipay.sofa.jraft.Node;
+import com.alipay.sofa.jraft.RaftGroupService;
+import com.alipay.sofa.jraft.Status;
+import com.alipay.sofa.jraft.conf.Configuration;
+import com.alipay.sofa.jraft.entity.NodeId;
+import com.alipay.sofa.jraft.entity.PeerId;
+import com.alipay.sofa.jraft.entity.Task;
+import com.alipay.sofa.jraft.option.NodeOptions;
+import org.apache.commons.io.FileUtils;
+import org.apache.rocketmq.common.ControllerConfig;
+import org.apache.rocketmq.common.constant.LoggerName;
+import org.apache.rocketmq.controller.Controller;
+import org.apache.rocketmq.controller.helper.BrokerLifecycleListener;
+import org.apache.rocketmq.controller.impl.closure.ControllerClosure;
+import org.apache.rocketmq.controller.impl.task.BrokerCloseChannelRequest;
+import org.apache.rocketmq.controller.impl.task.CheckNotActiveBrokerRequest;
+import org.apache.rocketmq.controller.impl.task.GetBrokerLiveInfoRequest;
+import org.apache.rocketmq.controller.impl.task.GetSyncStateDataRequest;
+import
org.apache.rocketmq.controller.impl.task.RaftBrokerHeartBeatEventRequest;
+import org.apache.rocketmq.remoting.ChannelEventListener;
+import org.apache.rocketmq.remoting.CommandCustomHeader;
+import org.apache.rocketmq.remoting.RemotingServer;
+import org.apache.rocketmq.remoting.netty.NettyRemotingServer;
+import org.apache.rocketmq.remoting.netty.NettyServerConfig;
+import org.apache.rocketmq.remoting.protocol.RemotingCommand;
+import org.apache.rocketmq.remoting.protocol.RemotingSerializable;
+import org.apache.rocketmq.remoting.protocol.RequestCode;
+import org.apache.rocketmq.remoting.protocol.ResponseCode;
+import org.apache.rocketmq.remoting.protocol.body.SyncStateSet;
+import
org.apache.rocketmq.remoting.protocol.header.controller.AlterSyncStateSetRequestHeader;
+import
org.apache.rocketmq.remoting.protocol.header.controller.ElectMasterRequestHeader;
+import
org.apache.rocketmq.remoting.protocol.header.controller.GetMetaDataResponseHeader;
+import
org.apache.rocketmq.remoting.protocol.header.controller.GetReplicaInfoRequestHeader;
+import
org.apache.rocketmq.remoting.protocol.header.controller.admin.CleanControllerBrokerDataRequestHeader;
+import
org.apache.rocketmq.remoting.protocol.header.controller.register.ApplyBrokerIdRequestHeader;
+import
org.apache.rocketmq.remoting.protocol.header.controller.register.GetNextBrokerIdRequestHeader;
+import
org.apache.rocketmq.remoting.protocol.header.controller.register.RegisterBrokerToControllerRequestHeader;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+
+public class JRaftController implements Controller {
+private static final Logger log =
LoggerFactory.getLogger(LoggerName.CONTROLLER_LOGGER_NAME);
+private final RaftGroupService raftGroupService;
+private final Node node;
+private final JRaftControllerStateMachine stateMachine;
+private final ControllerConfig controllerConfig;
+private final List brokerLifecycleListeners;
+private final Map pee
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 01a2aef96bdfb17c5f82415141ef421efb4e3bc7 / cnScarb [ISSUE #7570] Add default value for lastPopTimestamp (#7571) Report URL: https://github.com/apache/rocketmq/actions/runs/6928477114 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: e5c24a2b2e9155c97938d85f72f013fd8edba09b / lizhimins <707364...@qq.com> fix unit test on windows Report URL: https://github.com/apache/rocketmq/actions/runs/6928462305 With regards, GitHub Actions via GitBox
Re: [I] sendAndReceive throw exception Message cannot be cast to MessageExt [rocketmq-spring]
oniubi commented on issue #528:
URL:
https://github.com/apache/rocketmq-spring/issues/528#issuecomment-1818733682
2023-11-20T17:57:33.158+08:00 ERROR 35316 --- [ main]
o.a.r.spring.core.RocketMQTemplate : send request message failed.
destination:stringRequestTopic:tagA, message:GenericMessage
[payload=requestTopicSync, headers={id=9733c3bf-16e8-ef40-9d65-767525633453,
timestamp=1700474252884}]
java.lang.AssertionError:
Expecting throwable message:
"class org.apache.rocketmq.common.message.Message cannot be cast to class
org.apache.rocketmq.common.message.MessageExt
(org.apache.rocketmq.common.message.Message and
org.apache.rocketmq.common.message.MessageExt are in unnamed module of loader
'app')"
to contain:
"org.apache.rocketmq.remoting.exception.RemotingConnectException: connect
to [127.0.0.1:9876] failed"
but did not.
Throwable that failed the check:
org.springframework.messaging.MessagingException: class
org.apache.rocketmq.common.message.Message cannot be cast to class
org.apache.rocketmq.common.message.MessageExt
(org.apache.rocketmq.common.message.Message and
org.apache.rocketmq.common.message.MessageExt are in unnamed module of loader
'app')
at
org.apache.rocketmq.spring.core.RocketMQTemplate.sendAndReceive(RocketMQTemplate.java:252)
at
org.apache.rocketmq.spring.core.RocketMQTemplate.sendAndReceive(RocketMQTemplate.java:117)
at
org.apache.rocketmq.spring.core.RocketMQTemplateTest.testSendAndReceive_Sync(RocketMQTemplateTest.java:187)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.springframework.test.context.junit4.statements.RunBeforeTestExecutionCallbacks.evaluate(RunBeforeTestExecutionCallbacks.java:76)
at
org.springframework.test.context.junit4.statements.RunAfterTestExecutionCallbacks.evaluate(RunAfterTestExecutionCallbacks.java:84)
at
org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75)
at
org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86)
at
org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:84)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:252)
at
org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:97)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at
org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
at
org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at
org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:191)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at
com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
at
com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
at
com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
at
com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:232)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:55)
Caused by: java.lang.ClassCastException: class
org.apache.rocketmq.common.message.Message cannot be cast to class
org.apache.rocketmq.common.message.Mess
Re: [I] sendAndReceive throw exception Message cannot be cast to MessageExt [rocketmq-spring]
oniubi commented on issue #528: URL: https://github.com/apache/rocketmq-spring/issues/528#issuecomment-1818732317 I still get an error when I test with the official example -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] sendAndReceive throw exception Message cannot be cast to MessageExt [rocketmq-spring]
oniubi commented on issue #528: URL: https://github.com/apache/rocketmq-spring/issues/528#issuecomment-1818731972 This is definitely an official bug! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 01a2aef96bdfb17c5f82415141ef421efb4e3bc7 / cnScarb [ISSUE #7570] Add default value for lastPopTimestamp (#7571) Report URL: https://github.com/apache/rocketmq/actions/runs/6928251839 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7300] jRaft-Controller Implemention [rocketmq]
GenerousMan commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1398938302
##
controller/src/main/java/org/apache/rocketmq/controller/impl/heartbeat/RaftBrokerHeartBeatManager.java:
##
@@ -0,0 +1,261 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.controller.impl.heartbeat;
+
+import com.alibaba.fastjson.JSON;
+import com.alibaba.fastjson.TypeReference;
+import io.netty.channel.Channel;
+import org.apache.rocketmq.common.ControllerConfig;
+import org.apache.rocketmq.common.ThreadFactoryImpl;
+import org.apache.rocketmq.common.constant.LoggerName;
+import org.apache.rocketmq.controller.BrokerHeartbeatManager;
+import org.apache.rocketmq.controller.helper.BrokerLifecycleListener;
+import org.apache.rocketmq.controller.impl.JRaftController;
+import org.apache.rocketmq.controller.impl.task.BrokerCloseChannelRequest;
+import org.apache.rocketmq.controller.impl.task.CheckNotActiveBrokerRequest;
+import org.apache.rocketmq.controller.impl.task.GetBrokerLiveInfoRequest;
+import org.apache.rocketmq.controller.impl.task.GetBrokerLiveInfoResponse;
+import
org.apache.rocketmq.controller.impl.task.RaftBrokerHeartBeatEventRequest;
+import org.apache.rocketmq.logging.org.slf4j.Logger;
+import org.apache.rocketmq.logging.org.slf4j.LoggerFactory;
+import org.apache.rocketmq.remoting.common.RemotingHelper;
+import org.apache.rocketmq.remoting.protocol.RemotingCommand;
+import org.apache.rocketmq.remoting.protocol.ResponseCode;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+public class RaftBrokerHeartBeatManager implements BrokerHeartbeatManager {
+private static final Logger log =
LoggerFactory.getLogger(LoggerName.CONTROLLER_LOGGER_NAME);
+private JRaftController controller;
+private final List brokerLifecycleListeners = new
ArrayList<>();
+private final ScheduledExecutorService scheduledService;
+private final ExecutorService executor;
+private final ControllerConfig controllerConfig;
+
+private final Map
brokerChannelIdentityInfoMap = new HashMap<>();
+
+public RaftBrokerHeartBeatManager(ControllerConfig controllerConfig) {
+this.scheduledService = Executors.newSingleThreadScheduledExecutor(new
ThreadFactoryImpl("RaftBrokerHeartbeatManager_scheduledService_"));
+this.executor = Executors.newFixedThreadPool(2, new
ThreadFactoryImpl("RaftBrokerHeartbeatManager_executorService_"));
+this.controllerConfig = controllerConfig;
+}
+
+public void setController(JRaftController controller) {
+this.controller = controller;
+}
+
+@Override
+public void initialize() {
+
+}
+
+@Override
+public void start() {
+this.scheduledService.scheduleAtFixedRate(this::scanNotActiveBroker,
2000, this.controllerConfig.getScanNotActiveBrokerInterval(),
TimeUnit.MILLISECONDS);
+}
+
+@Override
+public void shutdown() {
+this.scheduledService.shutdown();
+this.executor.shutdown();
+}
+
+@Override
+public void registerBrokerLifecycleListener(BrokerLifecycleListener
listener) {
+brokerLifecycleListeners.add(listener);
+}
+
+@Override
+public void onBrokerHeartbeat(String clusterName, String brokerName,
String brokerAddr, Long brokerId,
+Long timeoutMillis, Channel channel, Integer epoch, Long maxOffset,
Long confirmOffset,
+Integer electionPriority) {
+BrokerIdentityInfo brokerIdentityInfo = new
BrokerIdentityInfo(clusterName, brokerName, brokerId);
+int realEpoch = Optional.ofNullable(epoch).orElse(-1);
+long realBrokerId = Optional.ofNullable(brokerId).orElse(-1L);
+long realMaxOffset = Optional.ofNullable(maxOffset).orElse(-1L);
+long realConf
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user guyinyou (triggered by guyinyou). Head commit for run: c5a57ceedea59a787ecab1ae6a9554b66cc59dca / guyinyou fix RunningFlags conflict Report URL: https://github.com/apache/rocketmq/actions/runs/6927873180 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user guyinyou (triggered by guyinyou). Head commit for run: c5a57ceedea59a787ecab1ae6a9554b66cc59dca / guyinyou fix RunningFlags conflict Report URL: https://github.com/apache/rocketmq/actions/runs/6927873173 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user guyinyou (triggered by guyinyou). Head commit for run: 01a2aef96bdfb17c5f82415141ef421efb4e3bc7 / cnScarb [ISSUE #7570] Add default value for lastPopTimestamp (#7571) Report URL: https://github.com/apache/rocketmq/actions/runs/6927902036 With regards, GitHub Actions via GitBox
[I] 不兼容的升级API导致项目无法编译，如何绕过此缺陷？ [rocketmq-client-go]
kpvt001 opened a new issue, #1108: URL: https://github.com/apache/rocketmq-client-go/issues/1108 项目依赖2个库（简称A和B），由于一些原因，这两个库**不能**进行修改和升级。 但A调用的primitive.GetProducerCtx/GetConsumerCtx是2个返回值，B调用的primitive.GetProducerCtx/GetConsumerCtx是1个返回值，这导致无论使用新的还是旧的rocketmq-client-go版本，均无法编译项目。 A和B **不能** 修改。 A和B **不能** 修改。 A和B **不能** 修改。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Rocketmq restart failed [rocketmq]
smallemployees opened a new issue, #7576: URL: https://github.com/apache/rocketmq/issues/7576 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment K8s running cluster ### RocketMQ version 4.6.0 ### JDK Version _No response_ ### Describe the Bug After the pod restarts, the consistent startup fails, indicating that the instance has already been running. However, the reason for checking later is that the lock file already exists. Why didn't the cleaning be done during the restart ### Steps to Reproduce Abnormal down of service, causing K8S to pull up the pod ### What Did You Expect to See? Can clear lock files before shutting down ### What Did You See Instead? 重启失败 ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #7574] Fix RunningFlags conflict [rocketmq]
guyinyou opened a new pull request, #7575: URL: https://github.com/apache/rocketmq/pull/7575 ### Which Issue(s) This PR Fixes Fixes #7574 ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Doc] Chinese comma in page basic concept [rocketmq]
tzq0301 closed issue #7564: [Doc] Chinese comma in page basic concept URL: https://github.com/apache/rocketmq/issues/7564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] The values of FENCED_BIT and LOGIC_DISK_FULL_BIT in RunningFlags conflict. [rocketmq]
RongtongJin commented on issue #7574: URL: https://github.com/apache/rocketmq/issues/7574#issuecomment-1818507333 @guyinyou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] The values of FENCED_BIT and LOGIC_DISK_FULL_BIT in RunningFlags conflict. [rocketmq]
RongtongJin opened a new issue, #7574: URL: https://github.com/apache/rocketmq/issues/7574 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment Linux ### RocketMQ version develop ### JDK Version 1.8 ### Describe the Bug  The values of FENCED_BIT and LOGIC_DISK_FULL_BIT in RunningFlags conflict. ### Steps to Reproduce This will cause the broker to be unable to write messages in controller mode ### What Did You Expect to See? The broker can write messages normally ### What Did You See Instead? The broker can not write messages ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: f179427f0e0d9bd917087a8cc08e35e53d383170 / lizhimins <707364...@qq.com> fix unit test and change store temp path Report URL: https://github.com/apache/rocketmq/actions/runs/6926886289 With regards, GitHub Actions via GitBox
