Re: [I] [Enhancement] Pop retry topic v2 [rocketmq]

2023-12-15 Thread via GitHub


drpmma closed issue #7543: [Enhancement] Pop retry topic v2
URL: https://github.com/apache/rocketmq/issues/7543


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
8e585d8767bc24ab21217498daaea12d76cfd8ca / Zhouxiang Zhan 
[ISSUE #7543] Use "+" as the new separator for retry topic  (#7655)

Report URL: https://github.com/apache/rocketmq/actions/runs/7219526596

With regards,
GitHub Actions via GitBox



Re: [PR] [ISSUE #7543] Use "+" as the new separator for retry topic [rocketmq]

2023-12-15 Thread via GitHub


drpmma merged PR #7655:
URL: https://github.com/apache/rocketmq/pull/7655


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq) branch develop updated: [ISSUE #7543] Use "+" as the new separator for retry topic (#7655)

2023-12-15 Thread zhouxzhan
This is an automated email from the ASF dual-hosted git repository.

zhouxzhan pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
 new 8e585d8767 [ISSUE #7543] Use "+" as the new separator for retry topic  
(#7655)
8e585d8767 is described below

commit 8e585d8767bc24ab21217498daaea12d76cfd8ca
Author: Zhouxiang Zhan 
AuthorDate: Fri Dec 15 16:08:43 2023 +0800

[ISSUE #7543] Use "+" as the new separator for retry topic  (#7655)
---
 .../java/org/apache/rocketmq/common/KeyBuilder.java| 11 ++-
 .../org/apache/rocketmq/common/KeyBuilderTest.java | 18 --
 2 files changed, 14 insertions(+), 15 deletions(-)

diff --git a/common/src/main/java/org/apache/rocketmq/common/KeyBuilder.java 
b/common/src/main/java/org/apache/rocketmq/common/KeyBuilder.java
index f2a8c40895..0f77c96ab0 100644
--- a/common/src/main/java/org/apache/rocketmq/common/KeyBuilder.java
+++ b/common/src/main/java/org/apache/rocketmq/common/KeyBuilder.java
@@ -18,8 +18,9 @@ package org.apache.rocketmq.common;
 
 public class KeyBuilder {
 public static final int POP_ORDER_REVIVE_QUEUE = 999;
-private static final String POP_RETRY_SEPARATOR_V1 = "_";
-private static final String POP_RETRY_SEPARATOR_V2 = ":";
+private static final char POP_RETRY_SEPARATOR_V1 = '_';
+private static final char POP_RETRY_SEPARATOR_V2 = '+';
+private static final String POP_RETRY_REGEX_SEPARATOR_V2 = "\\+";
 
 public static String buildPopRetryTopic(String topic, String cid) {
 return MixAll.RETRY_GROUP_TOPIC_PREFIX + cid + POP_RETRY_SEPARATOR_V2 
+ topic;
@@ -42,7 +43,7 @@ public class KeyBuilder {
 
 public static String parseNormalTopic(String retryTopic) {
 if (isPopRetryTopicV2(retryTopic)) {
-String[] result = retryTopic.split(POP_RETRY_SEPARATOR_V2);
+String[] result = retryTopic.split(POP_RETRY_REGEX_SEPARATOR_V2);
 if (result.length == 2) {
 return result[1];
 }
@@ -52,7 +53,7 @@ public class KeyBuilder {
 
 public static String parseGroup(String retryTopic) {
 if (isPopRetryTopicV2(retryTopic)) {
-String[] result = retryTopic.split(POP_RETRY_SEPARATOR_V2);
+String[] result = retryTopic.split(POP_RETRY_REGEX_SEPARATOR_V2);
 if (result.length == 2) {
 return 
result[0].substring(MixAll.RETRY_GROUP_TOPIC_PREFIX.length());
 }
@@ -65,6 +66,6 @@ public class KeyBuilder {
 }
 
 public static boolean isPopRetryTopicV2(String retryTopic) {
-return retryTopic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX) && 
retryTopic.contains(POP_RETRY_SEPARATOR_V2);
+return retryTopic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX) && 
retryTopic.contains(String.valueOf(POP_RETRY_SEPARATOR_V2));
 }
 }
diff --git 
a/common/src/test/java/org/apache/rocketmq/common/KeyBuilderTest.java 
b/common/src/test/java/org/apache/rocketmq/common/KeyBuilderTest.java
index f83e0aa143..3c75871eaf 100644
--- a/common/src/test/java/org/apache/rocketmq/common/KeyBuilderTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/KeyBuilderTest.java
@@ -26,37 +26,35 @@ public class KeyBuilderTest {
 String group = "test-group";
 
 @Test
-public void buildPopRetryTopic() {
-assertThat(KeyBuilder.buildPopRetryTopic(topic, 
group)).isEqualTo(MixAll.RETRY_GROUP_TOPIC_PREFIX + group + ":" + topic);
+public void testBuildPopRetryTopic() {
+assertThat(KeyBuilder.buildPopRetryTopic(topic, 
group)).isEqualTo(MixAll.RETRY_GROUP_TOPIC_PREFIX + group + "+" + topic);
 }
 
 @Test
-public void buildPopRetryTopicV1() {
+public void testBuildPopRetryTopicV1() {
 assertThat(KeyBuilder.buildPopRetryTopicV1(topic, 
group)).isEqualTo(MixAll.RETRY_GROUP_TOPIC_PREFIX + group + "_" + topic);
 }
 
 @Test
-public void parseNormalTopic() {
+public void testParseNormalTopic() {
 String popRetryTopic = KeyBuilder.buildPopRetryTopic(topic, group);
 assertThat(KeyBuilder.parseNormalTopic(popRetryTopic, 
group)).isEqualTo(topic);
+
 String popRetryTopicV1 = KeyBuilder.buildPopRetryTopicV1(topic, group);
 assertThat(KeyBuilder.parseNormalTopic(popRetryTopicV1, 
group)).isEqualTo(topic);
-}
 
-@Test
-public void testParseNormalTopic() {
-String popRetryTopic = KeyBuilder.buildPopRetryTopic(topic, group);
+popRetryTopic = KeyBuilder.buildPopRetryTopic(topic, group);
 
assertThat(KeyBuilder.parseNormalTopic(popRetryTopic)).isEqualTo(topic);
 }
 
 @Test
-public void parseGroup() {
+public void testParseGroup() {
 String popRetryTopic = KeyBuilder.buildPopRetryTopic(topic, group);
 assertThat(KeyBuilder.parseGroup(popRetryTopic)).isEqualTo(group);
 }
 
 @Test
-public void isPopRetryTopicV2() {
+  

Re: [PR] [ISSUE #7543] only call a single type of retry topic in pop [rocketmq]

2023-12-15 Thread via GitHub


drpmma merged PR #7665:
URL: https://github.com/apache/rocketmq/pull/7665


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq) branch develop updated: [ISSUE #7543] only call a single type of retry topic in pop (#7665)

2023-12-15 Thread zhouxzhan
This is an automated email from the ASF dual-hosted git repository.

zhouxzhan pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
 new 71a7a659be [ISSUE #7543] only call a single type of retry topic in pop 
(#7665)
71a7a659be is described below

commit 71a7a659bed15110d1146091bfb7a51d28ade562
Author: Zhouxiang Zhan 
AuthorDate: Fri Dec 15 16:09:11 2023 +0800

[ISSUE #7543] only call a single type of retry topic in pop (#7665)

* only call a single type of retry topic in pop
---
 .../broker/processor/PopMessageProcessor.java  | 85 ++
 .../broker/processor/PopMessageProcessorTest.java  |  2 +-
 2 files changed, 55 insertions(+), 32 deletions(-)

diff --git 
a/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java
 
b/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java
index 58baecc05a..5d86ecc0cd 100644
--- 
a/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java
+++ 
b/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java
@@ -351,27 +351,42 @@ public class PopMessageProcessor implements 
NettyRequestProcessor {
 ExpressionMessageFilter finalMessageFilter = messageFilter;
 StringBuilder finalOrderCountInfo = orderCountInfo;
 
+// Due to the design of the fields startOffsetInfo, msgOffsetInfo, and 
orderCountInfo,
+// a single POP request could only invoke the popMsgFromQueue method 
once
+// for either a normal topic or a retry topic's queue. Retry topics v1 
and v2 are
+// considered the same type because they share the same retry flag in 
previous fields.
+// Therefore, needRetryV1 is designed as a subset of needRetry, and 
within a single request,
+// only one type of retry topic is able to call popMsgFromQueue.
 boolean needRetry = randomQ % 5 == 0;
+boolean needRetryV1 = false;
+if 
(brokerController.getBrokerConfig().isRetrieveMessageFromPopRetryTopicV1()) {
+needRetryV1 = randomQ % 2 == 0;
+}
 long popTime = System.currentTimeMillis();
 CompletableFuture getMessageFuture = 
CompletableFuture.completedFuture(0L);
 if (needRetry && !requestHeader.isOrder()) {
-TopicConfig retryTopicConfig =
-
this.brokerController.getTopicConfigManager().selectTopicConfig(KeyBuilder.buildPopRetryTopic(requestHeader.getTopic(),
 requestHeader.getConsumerGroup()));
-if (retryTopicConfig != null) {
-for (int i = 0; i < retryTopicConfig.getReadQueueNums(); i++) {
-int queueId = (randomQ + i) % 
retryTopicConfig.getReadQueueNums();
-getMessageFuture = getMessageFuture.thenCompose(restNum -> 
popMsgFromQueue(requestHeader.getAttemptId(), true, getMessageResult, 
requestHeader, queueId, restNum, reviveQid, channel, popTime, 
finalMessageFilter,
-startOffsetInfo, msgOffsetInfo, finalOrderCountInfo));
-}
-}
-if 
(brokerController.getBrokerConfig().isRetrieveMessageFromPopRetryTopicV1()) {
+if (needRetryV1) {
 TopicConfig retryTopicConfigV1 =
 
this.brokerController.getTopicConfigManager().selectTopicConfig(KeyBuilder.buildPopRetryTopicV1(requestHeader.getTopic(),
 requestHeader.getConsumerGroup()));
 if (retryTopicConfigV1 != null) {
 for (int i = 0; i < retryTopicConfigV1.getReadQueueNums(); 
i++) {
 int queueId = (randomQ + i) % 
retryTopicConfigV1.getReadQueueNums();
-getMessageFuture = 
getMessageFuture.thenCompose(restNum -> 
popMsgFromQueue(requestHeader.getAttemptId(), true, getMessageResult, 
requestHeader, queueId, restNum, reviveQid, channel, popTime, 
finalMessageFilter,
-startOffsetInfo, msgOffsetInfo, 
finalOrderCountInfo));
+getMessageFuture = 
getMessageFuture.thenCompose(restNum ->
+popMsgFromQueue(retryTopicConfigV1.getTopicName(), 
requestHeader.getAttemptId(), true,
+getMessageResult, requestHeader, queueId, 
restNum, reviveQid, channel, popTime, finalMessageFilter,
+startOffsetInfo, msgOffsetInfo, 
finalOrderCountInfo));
+}
+}
+} else {
+TopicConfig retryTopicConfig =
+
this.brokerController.getTopicConfigManager().selectTopicConfig(KeyBuilder.buildPopRetryTopic(requestHeader.getTopic(),
 requestHeader.getConsumerGroup()));
+if (retryTopicConfig != null) {
+for (int i = 0; i < retryTopicConfig.getReadQueueNums(); 
i++) {
+int queueId = (ran

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
71a7a659bed15110d1146091bfb7a51d28ade562 / Zhouxiang Zhan 
[ISSUE #7543] only call a single type of retry topic in pop (#7665)

* only call a single type of retry topic in pop

Report URL: https://github.com/apache/rocketmq/actions/runs/7219530816

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "PUSH-CI" on rocketmq.git has failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
8e585d8767bc24ab21217498daaea12d76cfd8ca / Zhouxiang Zhan 
[ISSUE #7543] Use "+" as the new separator for retry topic  (#7655)

Report URL: https://github.com/apache/rocketmq/actions/runs/7219526601

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "PUSH-CI" on rocketmq.git has failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
71a7a659bed15110d1146091bfb7a51d28ade562 / Zhouxiang Zhan 
[ISSUE #7543] only call a single type of retry topic in pop (#7665)

* only call a single type of retry topic in pop

Report URL: https://github.com/apache/rocketmq/actions/runs/7219530823

With regards,
GitHub Actions via GitBox



Re: [PR] [ISSUE #7646] Optimize pull onException logging [rocketmq]

2023-12-15 Thread via GitHub


drpmma merged PR #7647:
URL: https://github.com/apache/rocketmq/pull/7647


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Enhancement] Optimize pull onException logging [rocketmq]

2023-12-15 Thread via GitHub


drpmma closed issue #7646: [Enhancement] Optimize pull onException logging
URL: https://github.com/apache/rocketmq/issues/7646


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq) branch develop updated: [ISSUE #7646] Optimize pull onException logging (#7647)

2023-12-15 Thread zhouxzhan
This is an automated email from the ASF dual-hosted git repository.

zhouxzhan pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
 new 23ee0eaaef [ISSUE #7646] Optimize pull onException logging (#7647)
23ee0eaaef is described below

commit 23ee0eaaef430921da6dbf5361b7e76b9e058f73
Author: Zhouxiang Zhan 
AuthorDate: Fri Dec 15 16:49:44 2023 +0800

[ISSUE #7646] Optimize pull onException logging (#7647)

* Optimize SUBSCRIPTION_NOT_LATEST logging

* Add message queue in pullMessage onException
---
 .../rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git 
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java
 
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java
index d2a362ba56..cbde258655 100644
--- 
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java
+++ 
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java
@@ -332,7 +332,8 @@ public class DefaultMQPushConsumerImpl implements 
MQConsumerInner {
 }
 }
 
-final SubscriptionData subscriptionData = 
this.rebalanceImpl.getSubscriptionInner().get(pullRequest.getMessageQueue().getTopic());
+final MessageQueue messageQueue = pullRequest.getMessageQueue();
+final SubscriptionData subscriptionData = 
this.rebalanceImpl.getSubscriptionInner().get(messageQueue.getTopic());
 if (null == subscriptionData) {
 this.executePullRequestLater(pullRequest, 
pullTimeDelayMillsWhenException);
 log.warn("find the consumer's subscription failed, {}", 
pullRequest);
@@ -433,7 +434,11 @@ public class DefaultMQPushConsumerImpl implements 
MQConsumerInner {
 @Override
 public void onException(Throwable e) {
 if 
(!pullRequest.getMessageQueue().getTopic().startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX))
 {
-log.warn("execute the pull request exception", e);
+if (e instanceof MQBrokerException && ((MQBrokerException) 
e).getResponseCode() == ResponseCode.SUBSCRIPTION_NOT_LATEST) {
+log.warn("the subscription is not latest, group={}, 
messageQueue={}", groupName(), messageQueue);
+} else {
+log.warn("execute the pull request exception, 
group={}, messageQueue={}", groupName(), messageQueue, e);
+}
 }
 
 if (e instanceof MQBrokerException && ((MQBrokerException) 
e).getResponseCode() == ResponseCode.FLOW_CONTROL) {



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
23ee0eaaef430921da6dbf5361b7e76b9e058f73 / Zhouxiang Zhan 
[ISSUE #7646] Optimize pull onException logging (#7647)

* Optimize SUBSCRIPTION_NOT_LATEST logging

* Add message queue in pullMessage onException

Report URL: https://github.com/apache/rocketmq/actions/runs/7219901939

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user LittleBoy18 (triggered by RongtongJin).

Head commit for run:
e76d976f2132a722fb9a954157ff0d1a5f0d9258 / littleboy <2283985...@qq.com>
Update RouteInfoManager.java

合并if条件

Report URL: https://github.com/apache/rocketmq/actions/runs/7219700159

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed.
Run started by GitHub user LittleBoy18 (triggered by LittleBoy18).

Head commit for run:
23ee0eaaef430921da6dbf5361b7e76b9e058f73 / Zhouxiang Zhan 
[ISSUE #7646] Optimize pull onException logging (#7647)

* Optimize SUBSCRIPTION_NOT_LATEST logging

* Add message queue in pullMessage onException

Report URL: https://github.com/apache/rocketmq/actions/runs/7219951346

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "PUSH-CI" on rocketmq.git has failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
23ee0eaaef430921da6dbf5361b7e76b9e058f73 / Zhouxiang Zhan 
[ISSUE #7646] Optimize pull onException logging (#7647)

* Optimize SUBSCRIPTION_NOT_LATEST logging

* Add message queue in pullMessage onException

Report URL: https://github.com/apache/rocketmq/actions/runs/7219901935

With regards,
GitHub Actions via GitBox



Re: [PR] [ISSUE #7626] Topic perm was mistakenly changed to 4 in dledger mode [rocketmq]

2023-12-15 Thread via GitHub


RongtongJin merged PR #7661:
URL: https://github.com/apache/rocketmq/pull/7661


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] the topic perm to be modified to 4 and could not be automatically restored to 6 [rocketmq]

2023-12-15 Thread via GitHub


RongtongJin closed issue #7626: [Bug] the topic perm to be modified to 4 and 
could not be automatically restored to 6
URL: https://github.com/apache/rocketmq/issues/7626


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq) branch develop updated: [ISSUE #7626] Topic perm was mistakenly changed to 4 in dledger mode (#7661)

2023-12-15 Thread jinrongtong
This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
 new 7e1786732c [ISSUE #7626] Topic perm was mistakenly changed to 4 in 
dledger mode (#7661)
7e1786732c is described below

commit 7e1786732cfc1a4e02a17535bed9af2115c18822
Author: littleboy <2283985...@qq.com>
AuthorDate: Fri Dec 15 17:49:47 2023 +0800

[ISSUE #7626] Topic perm was mistakenly changed to 4 in dledger mode (#7661)

Signed-off-by: littleboy <2283985...@qq.com>
---
 .../java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git 
a/namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java
 
b/namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java
index f7a95f0a6d..ce311d392a 100644
--- 
a/namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java
+++ 
b/namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java
@@ -301,6 +301,7 @@ public class RouteInfoManager {
 registerFirst = registerFirst || (StringUtils.isEmpty(oldAddr));
 
 boolean isMaster = MixAll.MASTER_ID == brokerId;
+
 boolean isPrimeSlave = !isOldVersionBroker && !isMaster
 && brokerId == Collections.min(brokerAddrsMap.keySet());
 
@@ -339,7 +340,8 @@ public class RouteInfoManager {
 topicConfigWrapper.getDataVersion(), brokerName,
 entry.getValue().getTopicName())) {
 final TopicConfig topicConfig = entry.getValue();
-if (isPrimeSlave) {
+// In Slave Acting Master mode, Namesrv will 
regard the surviving Slave with the smallest brokerId as the "agent" Master, 
and modify the brokerPermission to read-only.
+if (isPrimeSlave && 
brokerData.isEnableActingMaster()) {
 // Wipe write perm for prime slave
 topicConfig.setPerm(topicConfig.getPerm() & 
(~PermName.PERM_WRITE));
 }



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user RongtongJin (triggered by RongtongJin).

Head commit for run:
7e1786732cfc1a4e02a17535bed9af2115c18822 / littleboy <2283985...@qq.com>
[ISSUE #7626] Topic perm was mistakenly changed to 4 in dledger mode (#7661)

Signed-off-by: littleboy <2283985...@qq.com>

Report URL: https://github.com/apache/rocketmq/actions/runs/7220490373

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "PUSH-CI" on rocketmq.git has failed.
Run started by GitHub user RongtongJin (triggered by RongtongJin).

Head commit for run:
7e1786732cfc1a4e02a17535bed9af2115c18822 / littleboy <2283985...@qq.com>
[ISSUE #7626] Topic perm was mistakenly changed to 4 in dledger mode (#7661)

Signed-off-by: littleboy <2283985...@qq.com>

Report URL: https://github.com/apache/rocketmq/actions/runs/7220490375

With regards,
GitHub Actions via GitBox



Re: [I] 能否release一个 支持mac m2 的 构建后的包 非常感谢 [rocketmq-client-cpp]

2023-12-15 Thread via GitHub


Sligcm commented on issue #459:
URL: 
https://github.com/apache/rocketmq-client-cpp/issues/459#issuecomment-1857660326

   回复太慢了,我已经解决了。忽略上面的问题吧。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
failed.
Run started by GitHub user RongtongJin (triggered by RongtongJin).

Head commit for run:
7e1786732cfc1a4e02a17535bed9af2115c18822 / littleboy <2283985...@qq.com>
[ISSUE #7626] Topic perm was mistakenly changed to 4 in dledger mode (#7661)

Signed-off-by: littleboy <2283985...@qq.com>

Report URL: https://github.com/apache/rocketmq/actions/runs/7220490376

With regards,
GitHub Actions via GitBox



Re: [I] remote connect exception [rocketmq-dashboard]

2023-12-15 Thread via GitHub


Carlos1729 commented on issue #181:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/181#issuecomment-1857804778

   I tried all the options none of them fixed the issue back then and I had to 
move to a different MQ. Will try this now also it would be great if the blogs 
or documentation is in English as few cn domains are blocked in other countries 
atleast for the frequently encountered errors


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Support DLedger Controller Snapshot [rocketmq]

2023-12-15 Thread via GitHub


github-actions[bot] commented on issue #5585:
URL: https://github.com/apache/rocketmq/issues/5585#issuecomment-1858625937

   This issue is stale because it has been open for 365 days with no activity. 
It will be closed in 3 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [DISCUSS] [RIP-57]Optimize Building CommitLog [rocketmq]

2023-12-15 Thread via GitHub


github-actions[bot] commented on issue #5529:
URL: https://github.com/apache/rocketmq/issues/5529#issuecomment-1858625954

   This issue is stale because it has been open for 365 days with no activity. 
It will be closed in 3 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [OPTIMIZATION] Support sending a bound of sub-requests IN ONE RPC, especially for data-streaming-related RPCs like sending, consuming and managing consumer offsets. [rocketmq]

2023-12-15 Thread via GitHub


github-actions[bot] commented on issue #5516:
URL: https://github.com/apache/rocketmq/issues/5516#issuecomment-1858625997

   This issue is stale because it has been open for 365 days with no activity. 
It will be closed in 3 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Support update multiple pairs config. [rocketmq]

2023-12-15 Thread via GitHub


github-actions[bot] commented on issue #5519:
URL: https://github.com/apache/rocketmq/issues/5519#issuecomment-1858625972

   This issue is stale because it has been open for 365 days with no activity. 
It will be closed in 3 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] [Feature] Friendly changes: give users feedback on the effective scope of updateBrokerConfig [rocketmq]

2023-12-15 Thread via GitHub


StevenLuMT opened a new issue, #7667:
URL: https://github.com/apache/rocketmq/issues/7667

   ### Is Your Feature Request Related to a Problem?
   
   When the user updateBrokerConfig performs a configuration update, many users 
do not know the current effective range. They need to read the code to know the 
actual effective range.
   
   ### Describe the Solution You'd Like
   
   Directly inform the user of the effective scope and guide the user to do the 
further operations.
   
   ### Describe Alternatives You've Considered
   
   Specify an effective range for each config key. When the user modifies it, 
the user is informed of the effective range.
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [Feature #7667] fix: give users feedback on the effective scope of updateBrokerConfig [rocketmq]

2023-12-15 Thread via GitHub


StevenLuMT opened a new pull request, #7668:
URL: https://github.com/apache/rocketmq/pull/7668

   
   
   ### Which Issue(s) This PR Fixes
   
   Fixes #7667
   
   ### Brief Description
   
   Step1: Only add the execution results of messageDelayLevel and 
brokerPermission
   
   ### How Did You Test This Change?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user StevenLuMT (triggered by StevenLuMT).

Head commit for run:
56588904f3457117ce950e247705ed0c89acdc3b / nuolin 
Friendly changes

Report URL: https://github.com/apache/rocketmq/actions/runs/7230638057

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "License checker" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "License checker" on rocketmq.git has failed.
Run started by GitHub user StevenLuMT (triggered by StevenLuMT).

Head commit for run:
56588904f3457117ce950e247705ed0c89acdc3b / nuolin 
Friendly changes

Report URL: https://github.com/apache/rocketmq/actions/runs/7230638055

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "PR-CI" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "PR-CI" on rocketmq.git has failed.
Run started by GitHub user StevenLuMT (triggered by StevenLuMT).

Head commit for run:
56588904f3457117ce950e247705ed0c89acdc3b / nuolin 
Friendly changes

Report URL: https://github.com/apache/rocketmq/actions/runs/7230638054

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed.
Run started by GitHub user StevenLuMT (triggered by StevenLuMT).

Head commit for run:
7e1786732cfc1a4e02a17535bed9af2115c18822 / littleboy <2283985...@qq.com>
[ISSUE #7626] Topic perm was mistakenly changed to 4 in dledger mode (#7661)

Signed-off-by: littleboy <2283985...@qq.com>

Report URL: https://github.com/apache/rocketmq/actions/runs/7230643402

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user StevenLuMT (triggered by StevenLuMT).

Head commit for run:
9c78a30466d91f1651541ffc3712c43341bdc28e / nuolin 
Friendly changes: Step1: Only add the execution results of messageDelayLevel 
and brokerPermission

Report URL: https://github.com/apache/rocketmq/actions/runs/7230659441

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "License checker" is working again!

2023-12-15 Thread GitBox


The GitHub Actions job "License checker" on rocketmq.git has succeeded.
Run started by GitHub user StevenLuMT (triggered by StevenLuMT).

Head commit for run:
9c78a30466d91f1651541ffc3712c43341bdc28e / nuolin 
Friendly changes: Step1: Only add the execution results of messageDelayLevel 
and brokerPermission

Report URL: https://github.com/apache/rocketmq/actions/runs/7230659440

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "PR-CI" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "PR-CI" on rocketmq.git has failed.
Run started by GitHub user StevenLuMT (triggered by StevenLuMT).

Head commit for run:
9c78a30466d91f1651541ffc3712c43341bdc28e / nuolin 
Friendly changes: Step1: Only add the execution results of messageDelayLevel 
and brokerPermission

Report URL: https://github.com/apache/rocketmq/actions/runs/7230659452

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user StevenLuMT (triggered by StevenLuMT).

Head commit for run:
6bc8cfbf7aceef8e346ab21c86051619498903f9 / nuolin 
Friendly changes: Step1: Only add the execution results of messageDelayLevel 
and brokerPermission

Report URL: https://github.com/apache/rocketmq/actions/runs/7230668626

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed.
Run started by GitHub user StevenLuMT (triggered by StevenLuMT).

Head commit for run:
7e1786732cfc1a4e02a17535bed9af2115c18822 / littleboy <2283985...@qq.com>
[ISSUE #7626] Topic perm was mistakenly changed to 4 in dledger mode (#7661)

Signed-off-by: littleboy <2283985...@qq.com>

Report URL: https://github.com/apache/rocketmq/actions/runs/7230664132

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "PR-CI" is working again!

2023-12-15 Thread GitBox


The GitHub Actions job "PR-CI" on rocketmq.git has succeeded.
Run started by GitHub user StevenLuMT (triggered by StevenLuMT).

Head commit for run:
6bc8cfbf7aceef8e346ab21c86051619498903f9 / nuolin 
Friendly changes: Step1: Only add the execution results of messageDelayLevel 
and brokerPermission

Report URL: https://github.com/apache/rocketmq/actions/runs/7230668627

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Coverage" failed!

2023-12-15 Thread GitBox


The GitHub Actions job "Coverage" on rocketmq.git has failed.
Run started by GitHub user StevenLuMT (triggered by StevenLuMT).

Head commit for run:
56588904f3457117ce950e247705ed0c89acdc3b / nuolin 
Friendly changes

Report URL: https://github.com/apache/rocketmq/actions/runs/7230638060

With regards,
GitHub Actions via GitBox