[I] [Bug] 启用controller模式，将2主4从 改为 1主4从时出现问题 [rocketmq]
TickFairy opened a new issue, #7704: URL: https://github.com/apache/rocketmq/issues/7704 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment CentOs 7.9 k8s 1.24 docker 20.10.16 ### RocketMQ version 5.1.3 ### JDK Version _No response_ ### Describe the Bug controller模式 2主4从 切换为1主4从配置从节点因为broker meta 冲突无法加入 ### Steps to Reproduce 1. 启用controller 模式 2. 启动2主4从 broker-0 和 broker-1，两个配置文件只有brokerName的区别 broker-0 主和从的配置文件如下 broker-0.conf ``` brokerIP1= brokerId=-1 brokerRole=Slave brokerName=broker-0 ``` broker-1 主和从的配置文件如下 broker-1.conf ``` brokerIP1= brokerId=-1 brokerRole=Slave brokerName=broker-1 ``` 3. 启动后运行正常 4. 调整broker-1.conf的brokerName=broker-0，也就是移除一个主节点将他们都设置为broker-0的从节点，重启后查看broker.log报错 The brokerName: broker-1 in broker metadata is different from brokerName: broker-0 in broker config ### What Did You Expect to See? 启动命令指定了brokerConfig，但contoller没有重新设置brokerId ，而且时报和boker metada冲突，这里broker meta 不会根据brokerconfig更新？ ### What Did You See Instead? - ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user dao-jun (triggered by dao-jun). Head commit for run: 038e8329aae0418faa1034c033f7889130fecfee / dao-jun Add tests Report URL: https://github.com/apache/rocketmq/actions/runs/7336840192 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user dao-jun (triggered by dao-jun). Head commit for run: 59e8f9b66ede2f02ec40a0c58fd5e5c2bd6d59e5 / Zhouxiang Zhan [ISSUE #7644] Optimize client rebalance Report URL: https://github.com/apache/rocketmq/actions/runs/7336864593 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user dao-jun (triggered by dao-jun). Head commit for run: 038e8329aae0418faa1034c033f7889130fecfee / dao-jun Add tests Report URL: https://github.com/apache/rocketmq/actions/runs/7336840190 With regards, GitHub Actions via GitBox
[PR] [ISSUE #7697]Fix can't open controller metricsExporter. [rocketmq]
baijun44 opened a new pull request, #7705: URL: https://github.com/apache/rocketmq/pull/7705 ### Which Issue(s) This PR Fixes Fixes #7697 ### Brief Description add two set methods for field metricsExporterType in order to make config 'metricsExporterType' work. ### How Did You Test This Change? 1.add a config "metricsExporterType = PROM" for controller 2.open localhost:5557/metrics and can get metrics info. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user dao-jun (triggered by dao-jun). Head commit for run: 038e8329aae0418faa1034c033f7889130fecfee / dao-jun Add tests Report URL: https://github.com/apache/rocketmq/actions/runs/7336840193 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7702]Fix ascii check for ppv2 tls. [rocketmq]
lollipopjin merged PR #7703: URL: https://github.com/apache/rocketmq/pull/7703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Fix ascii check for ppv2 tls [rocketmq]
lollipopjin closed issue #7702: [Bug] Fix ascii check for ppv2 tls URL: https://github.com/apache/rocketmq/issues/7702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: Fix ascii validate for ppv2 tls. (#7703)
This is an automated email from the ASF dual-hosted git repository.
lollipop pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 2c5bc1422b Fix ascii validate for ppv2 tls. (#7703)
2c5bc1422b is described below
commit 2c5bc1422b330e46b4fc8d9da4a4eb03a3102875
Author: dingshuangxi888
AuthorDate: Wed Dec 27 19:09:52 2023 +0800
Fix ascii validate for ppv2 tls. (#7703)
Co-authored-by: ShuangxiDing
---
common/src/main/java/org/apache/rocketmq/common/utils/BinaryUtil.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/common/src/main/java/org/apache/rocketmq/common/utils/BinaryUtil.java
b/common/src/main/java/org/apache/rocketmq/common/utils/BinaryUtil.java
index 7b4b24819c..68d15e0708 100644
--- a/common/src/main/java/org/apache/rocketmq/common/utils/BinaryUtil.java
+++ b/common/src/main/java/org/apache/rocketmq/common/utils/BinaryUtil.java
@@ -54,7 +54,7 @@ public class BinaryUtil {
return false;
}
for (byte b : subject) {
-if ((b & 0x80) != 0) {
+if (b < 32 || b > 126) {
return false;
}
}
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by lollipopjin). Head commit for run: 2c5bc1422b330e46b4fc8d9da4a4eb03a3102875 / dingshuangxi888 Fix ascii validate for ppv2 tls. (#7703) Co-authored-by: ShuangxiDing Report URL: https://github.com/apache/rocketmq/actions/runs/7337736846 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by lollipopjin). Head commit for run: 2c5bc1422b330e46b4fc8d9da4a4eb03a3102875 / dingshuangxi888 Fix ascii validate for ppv2 tls. (#7703) Co-authored-by: ShuangxiDing Report URL: https://github.com/apache/rocketmq/actions/runs/7337736819 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by lollipopjin). Head commit for run: 2c5bc1422b330e46b4fc8d9da4a4eb03a3102875 / dingshuangxi888 Fix ascii validate for ppv2 tls. (#7703) Co-authored-by: ShuangxiDing Report URL: https://github.com/apache/rocketmq/actions/runs/7337736826 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by lollipopjin). Head commit for run: 2c5bc1422b330e46b4fc8d9da4a4eb03a3102875 / dingshuangxi888 Fix ascii validate for ppv2 tls. (#7703) Co-authored-by: ShuangxiDing Report URL: https://github.com/apache/rocketmq/actions/runs/7337736823 With regards, GitHub Actions via GitBox
[PR] [rust]support message type check on rust client [rocketmq-clients]
glcrazier opened a new pull request, #658: URL: https://github.com/apache/rocketmq-clients/pull/658 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description The rust client doesn't have feature of checking message type with topic type. This pull request is to implement it. ### How Did You Test This Change? I've modified test cases in producer.rs to ensure tests to pass. Those tests are quite sufficient to test this feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] 测试环境开启TLS后，使用自定义证书，报错javax.net.ssl.SSLException: Received fatal alert: certificate_unknown [rocketmq-mqtt]
nameHui opened a new issue, #233: URL: https://github.com/apache/rocketmq-mqtt/issues/233 报错信息如下，请问是什么原因，是自定义证书不能用吗，应该怎么生成证书： 2023-12-27 19:42:33:185 WARN [RpcServer] start rpc server , port:7001 2023-12-27 19:42:33:197 WARN [MqttServer] start mqtt server , port:1883 2023-12-27 19:42:33:229 WARN [MqttServer] start mqtt ws server , port: 2023-12-27 19:42:33:231 WARN [MqttServer] start mqtt tls server , port:8883 2023-12-27 19:42:33:257 INFO [MqttExporter] metrics exporter start success 2023-12-27 19:42:33:847 WARN [GrpcClient] Channel in TRANSIENT_FAILURE state: 10.168.1.115:9876. 2023-12-27 19:42:33:847 WARN [GrpcClient] Channel in SHUTDOWN state: 10.168.1.115:9876. 2023-12-27 19:42:33:950 ERROR [AbstractClientService] Fail to connect 10.168.1.115:9876, remoting exception: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason. 2023-12-27 19:42:33:951 ERROR [AbstractClientService] Fail to connect 10.168.1.115:9876, remoting exception: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason. 2023-12-27 19:42:33:951 ERROR [AbstractClientService] Fail to connect 10.168.1.115:9876, remoting exception: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason. 2023-12-27 19:42:36:707 ERROR [AbstractClientService] Fail to connect 10.168.1.115:9876, remoting exception: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason. 2023-12-27 19:42:36:708 ERROR [AbstractClientService] Fail to connect 10.168.1.115:9876, remoting exception: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason. 2023-12-27 19:42:36:709 ERROR [AbstractClientService] Fail to connect 10.168.1.115:9876, remoting exception: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason. 2023-12-27 19:42:37:603 INFO [NotifyManager] Notify Manager is refreshing, all first topic is [notifyRetryTopic, clientRetryTopic, mqttTopic] 2023-12-27 19:42:39:707 ERROR [AbstractClientService] Fail to connect 10.168.1.115:9876, remoting exception: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason. 2023-12-27 19:42:39:708 ERROR [AbstractClientService] Fail to connect 10.168.1.115:9876, remoting exception: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason. 2023-12-27 19:42:39:709 ERROR [AbstractClientService] Fail to connect 10.168.1.115:9876, remoting exception: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason. 2023-12-27 19:42:42:603 INFO [NotifyManager] Notify Manager is refreshing, all first topic is [notifyRetryTopic, clientRetryTopic, mqttTopic] 2023-12-27 19:42:42:706 ERROR [AbstractClientService] Fail to connect 10.168.1.115:9876, remoting exception: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason. 2023-12-27 19:42:42:706 ERROR [AbstractClientService] Fail to connect 10.168.1.115:9876, remoting exception: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason. 2023-12-27 19:42:42:707 ERROR [AbstractClientService] Fail to connect 10.168.1.115:9876, remoting exception: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason. 2023-12-27 19:42:42:805 ERROR [WillMsgPersistManagerImpl] java.lang.NullPointerException: null at org.apache.rocketmq.mqtt.ds.meta.WillMsgClient.get(WillMsgClient.java:117) at org.apache.rocketmq.mqtt.ds.meta.WillMsgPersistManagerImpl.get(WillMsgPersistManagerImpl.java:69) at org.apache.rocketmq.mqtt.cs.session.loop.WillLoop.masterLoop(WillLoop.java:146) at org.apache.rocketmq.mqtt.cs.session.loop.WillLoop.lambda$init$1(WillLoop.java:73) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) 2023-12-27 1
[I] [Doc] Documentation Related 文档描述“队列数暂不支持修改” 是不是有问题？ [rocketmq]
lancemmt opened a new issue, #7706: URL: https://github.com/apache/rocketmq/issues/7706 ### Search before creation - [X] I had searched in the [issues](https://github.com/apache/rocketmq/issues) and found no similar issues. ### Documentation Related 在 [这个](https://rocketmq.apache.org/zh/docs/domainModel/03messagequeue/#%E8%A1%8C%E4%B8%BA%E7%BA%A6%E6%9D%9F) 文档中，有如下描述： > 每个主题下会由一到多个队列来存储消息，每个主题对应的队列数与消息类型以及实例所处地域（Region）相关，队列数暂不支持修改。 其中的 “队列数暂不支持修改” 是不是有问题？这个队列数应该是支持修改的吧？ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] slave sync acl [rocketmq]
leizhiyuan commented on issue #7672: URL: https://github.com/apache/rocketmq/issues/7672#issuecomment-1870258791 > Maybe it's because the adminClient will send RPC requests to all Brokers to update the acl config. Hmm, currently we also create the full amount during creation. However, upon further thought, it seems reasonable that it should be synchronized here as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Panic in SendResult.String() when MessageQueue is nil [rocketmq-client-go]
MaOreoreorui opened a new issue, #1124: URL: https://github.com/apache/rocketmq-client-go/issues/1124 **BUG REPORT** 1. Please describe the issue you observed: - What did you do (The steps to reproduce)? The `String()` method in `SendResult` cause a panic when `MessageQueue` field is `nil`. This happens beacuse `String()` method tries to access `MessageQueue.String()` without checking if `MessageQueue` is `nil`. - What did you expect to see? The String() method should not panic, even when MessageQueue is nil. Instead, it should return a string that clearly indicates MessageQueue is nil. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #1124] fix: panic in SendResult.String [rocketmq-client-go]
MaOreoreorui opened a new pull request, #1125: URL: https://github.com/apache/rocketmq-client-go/pull/1125 ## What is the purpose of the change The String() method in SendResult struct can cause a panic when MessageQueue field is nil. This is because String() method tries to access MessageQueue.String() without checking if MessageQueue is nil. ## Brief changelog This PR adds a nil check for MessageQueue before calling its String() method. If MessageQueue is nil, it uses the string "nil" to represent it. ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6098] fix issues that could be null and optimize code [rocketmq]
hardyfish closed pull request #6099: [ISSUE #6098] fix issues that could be null and optimize code URL: https://github.com/apache/rocketmq/pull/6099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6222] update addAndGet use [rocketmq]
hardyfish closed pull request #6223: [ISSUE #6222] update addAndGet use URL: https://github.com/apache/rocketmq/pull/6223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6100] Modify RemoteAddressStrategyFactory integer type [rocketmq]
hardyfish closed pull request #6111: [ISSUE #6100] Modify RemoteAddressStrategyFactory integer type URL: https://github.com/apache/rocketmq/pull/6111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6228] optimize deleteExpiredFileByTime method [rocketmq]
hardyfish closed pull request #6229: [ISSUE #6228] optimize deleteExpiredFileByTime method URL: https://github.com/apache/rocketmq/pull/6229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] suggest support jdk17 run mq server [rocketmq]
github-actions[bot] commented on issue #5767: URL: https://github.com/apache/rocketmq/issues/5767#issuecomment-1870704419 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] ConsumerOffset not cleaned when group is deleted and last commmit offset is early than min offset in queue [rocketmq]
github-actions[bot] commented on issue #5762: URL: https://github.com/apache/rocketmq/issues/5762#issuecomment-1870704443 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] ConsumerOffset not cleaned when group is deleted and last commmit offset is early than min offset in queue [rocketmq]
github-actions[bot] closed issue #5762: ConsumerOffset not cleaned when group is deleted and last commmit offset is early than min offset in queue URL: https://github.com/apache/rocketmq/issues/5762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] slave sync acl [rocketmq]
cserwen commented on issue #7672: URL: https://github.com/apache/rocketmq/issues/7672#issuecomment-1870737480 +1在 2023年12月27日，20:23，Lei Zhiyuan ***@***.***> 写道： Maybe it's because the adminClient will send RPC requests to all Brokers to update the acl config. Hmm, currently we also create the full amount during creation. However, upon further thought, it seems reasonable that it should be synchronized here as well. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2571d1197ced25a892adada38e5d2366556a8a6d / zhouxiang Remove GrpcConverter#wrapResourceWithNamespace Report URL: https://github.com/apache/rocketmq/actions/runs/7343894553 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2571d1197ced25a892adada38e5d2366556a8a6d / zhouxiang Remove GrpcConverter#wrapResourceWithNamespace Report URL: https://github.com/apache/rocketmq/actions/runs/7343894554 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2c5bc1422b330e46b4fc8d9da4a4eb03a3102875 / dingshuangxi888 Fix ascii validate for ppv2 tls. (#7703) Co-authored-by: ShuangxiDing Report URL: https://github.com/apache/rocketmq/actions/runs/7343902913 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2571d1197ced25a892adada38e5d2366556a8a6d / zhouxiang Remove GrpcConverter#wrapResourceWithNamespace Report URL: https://github.com/apache/rocketmq/actions/runs/7343894557 With regards, GitHub Actions via GitBox
Re: [I] [Doc] Documentation Related 文档描述“队列数暂不支持修改” 是不是有问题？ [rocketmq]
drpmma commented on issue #7706: URL: https://github.com/apache/rocketmq/issues/7706#issuecomment-1870782918 支持修改的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Enhancement] Refector ProxyContext with link node implementation [rocketmq]
drpmma opened a new issue, #7707: URL: https://github.com/apache/rocketmq/issues/7707 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary Refector ProxyContext with link node implementation ### Motivation ProxyContext should be related to the current stack context, thus link node implementation is more appropriate. ### Describe the Solution You'd Like Refector ProxyContext with link node implementation ### Describe Alternatives You've Considered No ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #7707] Refector Context with link node implementation [rocketmq]
drpmma opened a new pull request, #7708: URL: https://github.com/apache/rocketmq/pull/7708 ### Which Issue(s) This PR Fixes Fixes #7707 ### Brief Description Refector ProxyContext with link node implementation ### How Did You Test This Change? Unit test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 36597fb91f22177e68fa48a244356d08dc1b9009 / zhouxiang Refector Context with link node implement Report URL: https://github.com/apache/rocketmq/actions/runs/7344058868 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" is working again!
The GitHub Actions job "PR-CI" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 36597fb91f22177e68fa48a244356d08dc1b9009 / zhouxiang Refector Context with link node implement Report URL: https://github.com/apache/rocketmq/actions/runs/7344058881 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2571d1197ced25a892adada38e5d2366556a8a6d / zhouxiang Remove GrpcConverter#wrapResourceWithNamespace Report URL: https://github.com/apache/rocketmq/actions/runs/7343894560 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: aa7be48a4a58c9ffbb73d30f4986d3b56acb273e / zhouxiang Use package level private for constructor Report URL: https://github.com/apache/rocketmq/actions/runs/7344076865 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2c5bc1422b330e46b4fc8d9da4a4eb03a3102875 / dingshuangxi888 Fix ascii validate for ppv2 tls. (#7703) Co-authored-by: ShuangxiDing Report URL: https://github.com/apache/rocketmq/actions/runs/7344089583 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2c5bc1422b330e46b4fc8d9da4a4eb03a3102875 / dingshuangxi888 Fix ascii validate for ppv2 tls. (#7703) Co-authored-by: ShuangxiDing Report URL: https://github.com/apache/rocketmq/actions/runs/7344072453 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 36597fb91f22177e68fa48a244356d08dc1b9009 / zhouxiang Refector Context with link node implement Report URL: https://github.com/apache/rocketmq/actions/runs/7344058880 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: aa7be48a4a58c9ffbb73d30f4986d3b56acb273e / zhouxiang Use package level private for constructor Report URL: https://github.com/apache/rocketmq/actions/runs/7344076868 With regards, GitHub Actions via GitBox
Re: [PR] Revert "metrics bugfix: switch getTps() to getSum()" [rocketmq-exporter]
ferrirW commented on PR #141: URL: https://github.com/apache/rocketmq-exporter/pull/141#issuecomment-1870796609 What is the reason for changing to sum before? Is it necessary? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] can't open controller metricsExporter [rocketmq]
baijun44 commented on issue #7697: URL: https://github.com/apache/rocketmq/issues/7697#issuecomment-1870798136 @RongtongJin Please help me review.Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 767882367814095bb18db7c17a976a11f83ea52e / zhouxiang Add copy constructor Report URL: https://github.com/apache/rocketmq/actions/runs/7344235042 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: aa7be48a4a58c9ffbb73d30f4986d3b56acb273e / zhouxiang Use package level private for constructor Report URL: https://github.com/apache/rocketmq/actions/runs/7344076867 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 36597fb91f22177e68fa48a244356d08dc1b9009 / zhouxiang Refector Context with link node implement Report URL: https://github.com/apache/rocketmq/actions/runs/7344058873 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2c5bc1422b330e46b4fc8d9da4a4eb03a3102875 / dingshuangxi888 Fix ascii validate for ppv2 tls. (#7703) Co-authored-by: ShuangxiDing Report URL: https://github.com/apache/rocketmq/actions/runs/7344243626 With regards, GitHub Actions via GitBox
Re: [I] getTransferredTps in BrokerRuntimeStats is wrong in RocketMQ 4.9.1 ，should be change back to getTransferedTps [rocketmq-exporter]
cserwen closed issue #127: getTransferredTps in BrokerRuntimeStats is wrong in RocketMQ 4.9.1 ，should be change back to getTransferedTps URL: https://github.com/apache/rocketmq-exporter/issues/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Build Binary have error [rocketmq-exporter]
cserwen closed issue #115: Build Binary have error URL: https://github.com/apache/rocketmq-exporter/issues/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-exporter) branch master updated: fix some errors which make exporter can't run (#142)
This is an automated email from the ASF dual-hosted git repository.
cserwen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-exporter.git
The following commit(s) were added to refs/heads/master by this push:
new 72ce20c fix some errors which make exporter can't run (#142)
72ce20c is described below
commit 72ce20c7983693e54f74075d68a9f04aa32c8644
Author: cserwen
AuthorDate: Thu Dec 28 12:13:09 2023 +0800
fix some errors which make exporter can't run (#142)
---
src/main/docker/Dockerfile | 2 +-
.../java/org/apache/rocketmq/exporter/model/BrokerRuntimeStats.java | 6 +-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/main/docker/Dockerfile b/src/main/docker/Dockerfile
index 3a559ad..4953093 100644
--- a/src/main/docker/Dockerfile
+++ b/src/main/docker/Dockerfile
@@ -17,6 +17,6 @@
FROM java:8
MAINTAINER breeze
-ADD rocketmq-exporter-0.0.2-SNAPSHOT.jar quickstart.jar
+ADD rocketmq-exporter-0.0.2-SNAPSHOT-exec.jar quickstart.jar
EXPOSE 5557
ENTRYPOINT ["java","-jar","quickstart.jar"]
diff --git
a/src/main/java/org/apache/rocketmq/exporter/model/BrokerRuntimeStats.java
b/src/main/java/org/apache/rocketmq/exporter/model/BrokerRuntimeStats.java
index 238aa96..921b5af 100644
--- a/src/main/java/org/apache/rocketmq/exporter/model/BrokerRuntimeStats.java
+++ b/src/main/java/org/apache/rocketmq/exporter/model/BrokerRuntimeStats.java
@@ -91,7 +91,11 @@ public class BrokerRuntimeStats {
loadTps(this.putTps, kvTable.getTable().get("putTps"));
loadTps(this.getMissTps, kvTable.getTable().get("getMissTps"));
-loadTps(this.getTransferedTps,
kvTable.getTable().get("getTransferredTps"));
+if (kvTable.getTable().containsKey("getTransferredTps")) {
+loadTps(this.getTransferedTps,
kvTable.getTable().get("getTransferredTps"));
+} else {
+loadTps(this.getTransferedTps,
kvTable.getTable().get("getTransferedTps"));
+}
loadTps(this.getTotalTps, kvTable.getTable().get("getTotalTps"));
loadTps(this.getFoundTps, kvTable.getTable().get("getFoundTps"));
Re: [I] ERROR collectBrokerRuntimeStats-parse or report broker runtime stats error! [rocketmq-exporter]
cserwen closed issue #117: ERROR collectBrokerRuntimeStats-parse or report broker runtime stats error! URL: https://github.com/apache/rocketmq-exporter/issues/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix some errors which make exporter can't run [rocketmq-exporter]
cserwen merged PR #142: URL: https://github.com/apache/rocketmq-exporter/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] BrokerRuntimeStats#loadTps NPE [rocketmq-exporter]
cserwen closed issue #131: BrokerRuntimeStats#loadTps NPE URL: https://github.com/apache/rocketmq-exporter/issues/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] @Fix [ISSUE #117] Fix TransferedTps key [rocketmq-exporter]
cserwen commented on PR #152: URL: https://github.com/apache/rocketmq-exporter/pull/152#issuecomment-1870806327 Has been fixed by #142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 767882367814095bb18db7c17a976a11f83ea52e / zhouxiang Add copy constructor Report URL: https://github.com/apache/rocketmq/actions/runs/7344235038 With regards, GitHub Actions via GitBox
[I] 使用grpc协议客户端的时候如果broker开启了acl发送普通消息提示消息类型未指定，但是使用remoting协议客户端上可以的 [rocketmq-clients]
heyouI opened a new issue, #659: URL: https://github.com/apache/rocketmq-clients/issues/659 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq-clients/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq-clients/issues) and [GitHub Discussions](https://github.com/apache/rocketmq-clients/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Programming Language of the Client Java ### Runtime Platform Environment windows10 ### RocketMQ Version of the Client/Server 5.1.4 ### Run or Compiler Version jdk1.8 ### Describe the Bug 使用grpc协议客户端的时候如果broker开启了acl发送普通消息提示消息类型未指定，但是使用remoting协议客户端上可以的 ### Steps to Reproduce 开启acl认证。然后通过java grpc客户端发送普通消息。 ### What Did You Expect to See? 应该是正常的，或者说是该怎么操作是我操作有问题吗 ### What Did You See Instead? https://github.com/apache/rocketmq-clients/assets/45198610/36ad51e3-1d07-4dd0-9559-372e4d7eae51";> ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] controller模式下,两副本且minSync=2时候事务消息提交丢失问题 [rocketmq]
mz0113 opened a new issue, #7709: URL: https://github.com/apache/rocketmq/issues/7709 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment windows 11 ### RocketMQ version rocketmq v5.1.4 ### JDK Version JDK8 ### Describe the Bug controller模式下 , broker为两副本且minSync=2 当发送一笔事务半消息成功后,半消息进入半事务队列,然后本地事务提交这笔消息以后. 半消息将从半事务队列转移到业务消息Topic中,在转发的过程中依然会判断minSync是否满足设置的条件,如果此时从节点broker掉线,那么minSync不满足2这个条件,导致半消息转移失败,重试多次后最终被丢弃. ### Steps to Reproduce 如上 ### What Did You Expect to See? 消息不应该丢弃,或者尽量至少给一个可配置的参数选项能决定是否让半事务消息继续转移,我认为此时不满足minSync=2的时候,半事务消息转移的动作可以暂停不做,而不是转移失败导致消息被丢弃 ### What Did You See Instead? 事务消息没有被转移到业务普通Topic中 ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 767882367814095bb18db7c17a976a11f83ea52e / zhouxiang Add copy constructor Report URL: https://github.com/apache/rocketmq/actions/runs/7344235040 With regards, GitHub Actions via GitBox
[PR] Update 03messagequeue.md [rocketmq-site]
lancemmt opened a new pull request, #612: URL: https://github.com/apache/rocketmq-site/pull/612 删除部分错误的表述 Please do not create a Pull Request without creating an issue first. ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update 03messagequeue.md [rocketmq-site]
lancemmt commented on PR #612: URL: https://github.com/apache/rocketmq-site/pull/612#issuecomment-1870849211 https://github.com/apache/rocketmq/issues/7706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Broker status can not reflect current state [rocketmq-operator]
drivebyer closed issue #185: Broker status can not reflect current state URL: https://github.com/apache/rocketmq-operator/issues/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user baijun44 (triggered by RongtongJin). Head commit for run: 454a3aab512f07ca5be56dff1535ae3f8816d3e0 / baijun [ISSUE #7697]Fix can't open controller metricsExporter. Report URL: https://github.com/apache/rocketmq/actions/runs/7337200064 With regards, GitHub Actions via GitBox
Re: [I] 如何在外部网络访问broker [rocketmq-operator]
drivebyer commented on issue #157: URL: https://github.com/apache/rocketmq-operator/issues/157#issuecomment-1870863365 > > > > > > > > > 可以考虑创建service以便于在k8s集群外访问rocketmq 吗？ > > 可以试下NodePort类型service +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user baijun44 (triggered by baijun44). Head commit for run: 2c5bc1422b330e46b4fc8d9da4a4eb03a3102875 / dingshuangxi888 Fix ascii validate for ppv2 tls. (#7703) Co-authored-by: ShuangxiDing Report URL: https://github.com/apache/rocketmq/actions/runs/7345088932 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user baijun44 (triggered by RongtongJin). Head commit for run: 454a3aab512f07ca5be56dff1535ae3f8816d3e0 / baijun [ISSUE #7697]Fix can't open controller metricsExporter. Report URL: https://github.com/apache/rocketmq/actions/runs/7337200067 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7697]Fix can't open controller metricsExporter. [rocketmq]
codecov-commenter commented on PR #7705: URL: https://github.com/apache/rocketmq/pull/7705#issuecomment-1870875091 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7705?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `4 lines` in your changes are missing coverage. Please review. > Comparison is base [(`59e8f9b`)](https://app.codecov.io/gh/apache/rocketmq/commit/59e8f9b66ede2f02ec40a0c58fd5e5c2bd6d59e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.17% compared to head [(`454a3aa`)](https://app.codecov.io/gh/apache/rocketmq/pull/7705?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.14%. > Report is 1 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...a/org/apache/rocketmq/common/ControllerConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/7705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vQ29udHJvbGxlckNvbmZpZy5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#7705 +/- ## = - Coverage 43.17% 43.14% -0.03% + Complexity 9812 9801 -11 = Files 1165 1165 Lines 8454284546 +4 Branches 1097910979 = - Hits 3650236480 -22 - Misses 4349743521 +24 - Partials4543 4545 +2 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7705?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user baijun44 (triggered by RongtongJin). Head commit for run: 454a3aab512f07ca5be56dff1535ae3f8816d3e0 / baijun [ISSUE #7697]Fix can't open controller metricsExporter. Report URL: https://github.com/apache/rocketmq/actions/runs/7337200061 With regards, GitHub Actions via GitBox
Re: [I] [Doc] Documentation Related 文档描述“队列数暂不支持修改” 是不是有问题？ [rocketmq]
RongtongJin closed issue #7706: [Doc] Documentation Related 文档描述“队列数暂不支持修改” 是不是有问题？ URL: https://github.com/apache/rocketmq/issues/7706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7697]Fix can't open controller metricsExporter. [rocketmq]
RongtongJin merged PR #7705: URL: https://github.com/apache/rocketmq/pull/7705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] can't open controller metricsExporter [rocketmq]
RongtongJin closed issue #7697: [Bug] can't open controller metricsExporter URL: https://github.com/apache/rocketmq/issues/7697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #7697] Fix can't open controller metricsExporter. (#7705)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 9e4fd0e68a [ISSUE #7697] Fix can't open controller metricsExporter.
(#7705)
9e4fd0e68a is described below
commit 9e4fd0e68a1ea6ab1b1f3344ac9ae79af29a32c2
Author: baijun44
AuthorDate: Thu Dec 28 15:39:10 2023 +0800
[ISSUE #7697] Fix can't open controller metricsExporter. (#7705)
---
.../main/java/org/apache/rocketmq/common/ControllerConfig.java| 8
1 file changed, 8 insertions(+)
diff --git
a/common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java
b/common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java
index 1364754a0d..bafe6c9b57 100644
--- a/common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java
+++ b/common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java
@@ -224,6 +224,14 @@ public class ControllerConfig {
this.metricsExporterType = metricsExporterType;
}
+public void setMetricsExporterType(int metricsExporterType) {
+this.metricsExporterType =
MetricsExporterType.valueOf(metricsExporterType);
+}
+
+public void setMetricsExporterType(String metricsExporterType) {
+this.metricsExporterType =
MetricsExporterType.valueOf(metricsExporterType);
+}
+
public String getMetricsGrpcExporterTarget() {
return metricsGrpcExporterTarget;
}
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 9e4fd0e68a1ea6ab1b1f3344ac9ae79af29a32c2 / baijun44 [ISSUE #7697] Fix can't open controller metricsExporter. (#7705) Report URL: https://github.com/apache/rocketmq/actions/runs/7345538293 With regards, GitHub Actions via GitBox
Re: [I] [Bug] There was an issue when changing from 2 master and 4 slave to 1 master and 4 slave [rocketmq]
RongtongJin closed issue #7704: [Bug] There was an issue when changing from 2 master and 4 slave to 1 master and 4 slave URL: https://github.com/apache/rocketmq/issues/7704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #607] Bump jackson to 2.16.1 [rocketmq-spring]
RongtongJin merged PR #606: URL: https://github.com/apache/rocketmq-spring/pull/606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-spring) branch master updated: [ISSUE #607] Bump jackson to 2.16.1
This is an automated email from the ASF dual-hosted git repository. jinrongtong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/rocketmq-spring.git The following commit(s) were added to refs/heads/master by this push: new bc96d49 [ISSUE #607] Bump jackson to 2.16.1 bc96d49 is described below commit bc96d490073b5ccb607db00cb08e2932d4a3903e Author: rongtong AuthorDate: Thu Dec 28 15:52:03 2023 +0800 [ISSUE #607] Bump jackson to 2.16.1 --- rocketmq-v5-client-spring-boot-parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rocketmq-v5-client-spring-boot-parent/pom.xml b/rocketmq-v5-client-spring-boot-parent/pom.xml index 56a394c..309f01f 100644 --- a/rocketmq-v5-client-spring-boot-parent/pom.xml +++ b/rocketmq-v5-client-spring-boot-parent/pom.xml @@ -40,7 +40,7 @@ 2.2.4-SNAPSHOT 5.1.0 1.7.25 -2.11.1 +2.16.1 1.2.83 4.13.2 5.0.5
Re: [PR] Update 03messagequeue.md [rocketmq-site]
RongtongJin merged PR #612: URL: https://github.com/apache/rocketmq-site/pull/612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-site) branch new-official-website updated: Update 03messagequeue.md (#612)
This is an automated email from the ASF dual-hosted git repository. jinrongtong pushed a commit to branch new-official-website in repository https://gitbox.apache.org/repos/asf/rocketmq-site.git The following commit(s) were added to refs/heads/new-official-website by this push: new e1ebac2c13 Update 03messagequeue.md (#612) e1ebac2c13 is described below commit e1ebac2c13ad3dce44db6eceef105730f33b7528 Author: lancemmt <141197136+lance...@users.noreply.github.com> AuthorDate: Thu Dec 28 15:52:54 2023 +0800 Update 03messagequeue.md (#612) 删除部分错误的表述 --- versioned_docs/version-5.0/03-domainModel/03messagequeue.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/versioned_docs/version-5.0/03-domainModel/03messagequeue.md b/versioned_docs/version-5.0/03-domainModel/03messagequeue.md index 941021e4d6..7120e0a3e5 100644 --- a/versioned_docs/version-5.0/03-domainModel/03messagequeue.md +++ b/versioned_docs/version-5.0/03-domainModel/03messagequeue.md @@ -60,7 +60,7 @@ Apache RocketMQ 中通过修改队列数量，以此实现横向的水平扩容 ## 行为约束 -每个主题下会由一到多个队列来存储消息，每个主题对应的队列数与消息类型以及实例所处地域（Region）相关，队列数暂不支持修改。 +每个主题下会由一到多个队列来存储消息，每个主题对应的队列数与消息类型以及实例所处地域（Region）相关。 ## 版本兼容性
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 9e4fd0e68a1ea6ab1b1f3344ac9ae79af29a32c2 / baijun44 [ISSUE #7697] Fix can't open controller metricsExporter. (#7705) Report URL: https://github.com/apache/rocketmq/actions/runs/7345538291 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 9f5a584d719fd9c061a65feeb84de620a7d581a5 / zhouxiang use withValue method name Report URL: https://github.com/apache/rocketmq/actions/runs/7345647332 With regards, GitHub Actions via GitBox
