Re: [PR] [ISSUE #7699] Add namespace v2 in client [rocketmq]
codecov-commenter commented on PR #7700: URL: https://github.com/apache/rocketmq/pull/7700#issuecomment-1871816482 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `114 lines` in your changes are missing coverage. Please review. > Comparison is base [(`71a7a65`)](https://app.codecov.io/gh/apache/rocketmq/commit/71a7a659bed15110d1146091bfb7a51d28ade562?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 43.17% compared to head [(`710d3bc`)](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 43.15%. > Report is 15 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [...apache/rocketmq/remoting/rpc/RpcRequestHeader.java](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3JwYy9ScGNSZXF1ZXN0SGVhZGVyLmphdmE=) | 27.27% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...ocketmq/client/consumer/DefaultMQPushConsumer.java](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvRGVmYXVsdE1RUHVzaENvbnN1bWVyLmphdmE=) | 48.14% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...he/rocketmq/client/producer/DefaultMQProducer.java](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvcHJvZHVjZXIvRGVmYXVsdE1RUHJvZHVjZXIuamF2YQ==) | 43.75% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | 44.44% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...ocketmq/broker/processor/AdminBrokerProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0FkbWluQnJva2VyUHJvY2Vzc29yLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...ocketmq/client/producer/TransactionMQProducer.java](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvcHJvZHVjZXIvVHJhbnNhY3Rpb25NUVByb2R1Y2VyLmphdmE=) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...ng/protocol/header/SendMessageRequestHeaderV2.java](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL2hlYWRlci9TZW5kTWVzc2FnZVJlcXVlc3RIZWFkZXJWMi5qYXZh) | 55.55% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...g/apache/rocketmq/remoting/rpc/RequestBuilder.java](https://app.codecov.io/gh/apache/rocketmq/pull/7700?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3JwYy9SZXF1ZXN0QnVpbGRlci5qYXZh) | 0.00% | [4 Missing :warning:
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 9e4fd0e68a1ea6ab1b1f3344ac9ae79af29a32c2 / baijun44 [ISSUE #7697] Fix can't open controller metricsExporter. (#7705) Report URL: https://github.com/apache/rocketmq/actions/runs/7354703267 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 710d3bcdb083d28f0cdb405adb749509150f0b25 / zhouxiang fix SendMessageRequestHeaderV2Test Report URL: https://github.com/apache/rocketmq/actions/runs/7354688953 With regards, GitHub Actions via GitBox
Re: [PR] [rust]support message type check on rust client [rocketmq-clients]
glcrazier commented on PR #658: URL: https://github.com/apache/rocketmq-clients/pull/658#issuecomment-1871719188 > cargo-fmt failed, please fix it. @lizhanhui already did. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [rust]support message type check on rust client [rocketmq-clients]
lizhanhui commented on PR #658: URL: https://github.com/apache/rocketmq-clients/pull/658#issuecomment-1871706269 cargo-fmt failed, please fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [rust]support message type check on rust client [rocketmq-clients]
codecov-commenter commented on PR #658: URL: https://github.com/apache/rocketmq-clients/pull/658#issuecomment-1871706175 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq-clients/pull/658?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `5 lines` in your changes are missing coverage. Please review. > Comparison is base [(`2d3cdf7`)](https://app.codecov.io/gh/apache/rocketmq-clients/commit/2d3cdf735e27a3c3a9e1786d0ee7c8318ba1578c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 46.69% compared to head [(`75679c2`)](https://app.codecov.io/gh/apache/rocketmq-clients/pull/658?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 46.65%. | [Files](https://app.codecov.io/gh/apache/rocketmq-clients/pull/658?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [rust/src/producer.rs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/658?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cnVzdC9zcmMvcHJvZHVjZXIucnM=) | 75.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq-clients/pull/658?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #658 +/- ## - Coverage 46.69% 46.65% -0.04% Complexity 651 651 Files 207 207 Lines 1212012143 +23 Branches 3510 3533 +23 + Hits 5659 5665 +6 - Misses 6212 6225 +13 - Partials249 253 +4 ``` | [Flag](https://app.codecov.io/gh/apache/rocketmq-clients/pull/658/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [rust](https://app.codecov.io/gh/apache/rocketmq-clients/pull/658/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `79.21% <82.14%> (-0.23%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq-clients/pull/658?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user glcrazier (triggered by lizhanhui). Head commit for run: 75679c222f6cf84472ccdee4149585962e5c16c8 / qipingluo remove unused function Report URL: https://github.com/apache/rocketmq-clients/actions/runs/7348318883 With regards, GitHub Actions via GitBox
Re: [PR] [rust]support message type check on rust client [rocketmq-clients]
lizhanhui commented on code in PR #658:
URL: https://github.com/apache/rocketmq-clients/pull/658#discussion_r1437968517
##
rust/src/model/message.rs:
##
@@ -21,9 +21,27 @@ use std::collections::HashMap;
use crate::error::{ClientError, ErrorKind};
use crate::model::common::Endpoints;
+use crate::model::message::MessageType::{DELAY, FIFO, NORMAL, TRANSACTION};
use crate::model::message_id::UNIQ_ID_GENERATOR;
use crate::pb;
+pub enum MessageType {
+NORMAL = 1,
+FIFO = 2,
+DELAY = 3,
+TRANSACTION = 4,
+}
+
+fn transform_to_pb_message_type(message_type: ) -> i32 {
Review Comment:
Yes, it makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 116c3d41d79e47f9dce80b0f1968b8334666c8b8 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/7346459984 With regards, GitHub Actions via GitBox
[I] There two golang client that are being maintained? [rocketmq-client-go]
jjz921024 opened a new issue, #1126: URL: https://github.com/apache/rocketmq-client-go/issues/1126 There two golang client that are being maintained? - https://github.com/apache/rocketmq-clients/tree/master/golang - https://github.com/apache/rocketmq-client-go which one should I use? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Why DefaultLitePullConsumer poll always return only one message? [rocketmq]
github-actions[bot] commented on issue #5498: URL: https://github.com/apache/rocketmq/issues/5498#issuecomment-1871635221 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #190] Add e2e workflow [rocketmq-operator]
drivebyer opened a new pull request, #205: URL: https://github.com/apache/rocketmq-operator/pull/205 ## What is the purpose of the change #190 ## Brief changelog XX ## Verifying this change **Please go through this checklist to help us incorporate your contribution quickly and easily.** Notice: `It would be helpful if you could finish the following checklist (the last one is not necessary) before request the community to review your PR`. - [ ] Make sure there is a [Github issue](https://github.com/apache/rocketmq-operator/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check RBAC rights for Kubernetes roles. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. - [ ] Run `make docker-build` to build docker image for operator, try your changes from Pod inside your Kubernetes cluster, **not just locally**. Also provide screenshots to show that the RocketMQ cluster is healthy after the changes. - [ ] Before committing your changes, remember to run `make manifests` to make sure the CRD files are updated. - [ ] Update documentation if necessary. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [rust]support message type check on rust client [rocketmq-clients]
glcrazier commented on code in PR #658:
URL: https://github.com/apache/rocketmq-clients/pull/658#discussion_r1437685603
##
rust/src/model/message.rs:
##
@@ -21,9 +21,27 @@ use std::collections::HashMap;
use crate::error::{ClientError, ErrorKind};
use crate::model::common::Endpoints;
+use crate::model::message::MessageType::{DELAY, FIFO, NORMAL, TRANSACTION};
use crate::model::message_id::UNIQ_ID_GENERATOR;
use crate::pb;
+pub enum MessageType {
+NORMAL = 1,
+FIFO = 2,
+DELAY = 3,
+TRANSACTION = 4,
+}
+
+fn transform_to_pb_message_type(message_type: ) -> i32 {
Review Comment:
Thanks a lot! I've found a more concise way to achieve the conversion.
Please review the change again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [rust]support message type check on rust client [rocketmq-clients]
lizhanhui commented on code in PR #658:
URL: https://github.com/apache/rocketmq-clients/pull/658#discussion_r1437674136
##
rust/src/model/message.rs:
##
@@ -21,9 +21,27 @@ use std::collections::HashMap;
use crate::error::{ClientError, ErrorKind};
use crate::model::common::Endpoints;
+use crate::model::message::MessageType::{DELAY, FIFO, NORMAL, TRANSACTION};
use crate::model::message_id::UNIQ_ID_GENERATOR;
use crate::pb;
+pub enum MessageType {
+NORMAL = 1,
+FIFO = 2,
+DELAY = 3,
+TRANSACTION = 4,
+}
+
+fn transform_to_pb_message_type(message_type: ) -> i32 {
Review Comment:
IMO, it would be better to implement From trait for than
offering a free function:
```
impl From<> for i32 {
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: dfb26ae4690cc0551c137b63d2ae242f2ebeb692 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/7346512306 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 116c3d41d79e47f9dce80b0f1968b8334666c8b8 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/7346459984 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 9e4fd0e68a1ea6ab1b1f3344ac9ae79af29a32c2 / baijun44 [ISSUE #7697] Fix can't open controller metricsExporter. (#7705) Report URL: https://github.com/apache/rocketmq/actions/runs/7346535480 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: b824a45fe911ca60047c7d5481a8f96426adf4ff / zhouxiang fix unit test Report URL: https://github.com/apache/rocketmq/actions/runs/7346326167 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 116c3d41d79e47f9dce80b0f1968b8334666c8b8 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/7346459982 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: dfb26ae4690cc0551c137b63d2ae242f2ebeb692 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/7346512309 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 9e4fd0e68a1ea6ab1b1f3344ac9ae79af29a32c2 / baijun44 [ISSUE #7697] Fix can't open controller metricsExporter. (#7705) Report URL: https://github.com/apache/rocketmq/actions/runs/7346474420 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: dfb26ae4690cc0551c137b63d2ae242f2ebeb692 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/7346512301 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: b824a45fe911ca60047c7d5481a8f96426adf4ff / zhouxiang fix unit test Report URL: https://github.com/apache/rocketmq/actions/runs/7346326169 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" is working again!
The GitHub Actions job "PR-CI" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 116c3d41d79e47f9dce80b0f1968b8334666c8b8 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/7346459981 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 116c3d41d79e47f9dce80b0f1968b8334666c8b8 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/7346459986 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 9e4fd0e68a1ea6ab1b1f3344ac9ae79af29a32c2 / baijun44 [ISSUE #7697] Fix can't open controller metricsExporter. (#7705) Report URL: https://github.com/apache/rocketmq/actions/runs/7346339162 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: b824a45fe911ca60047c7d5481a8f96426adf4ff / zhouxiang fix unit test Report URL: https://github.com/apache/rocketmq/actions/runs/7346326171 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: b824a45fe911ca60047c7d5481a8f96426adf4ff / zhouxiang fix unit test Report URL: https://github.com/apache/rocketmq/actions/runs/7346326163 With regards, GitHub Actions via GitBox
[I] The message queue is not in assigned list [rocketmq-flink]
andyyumiao opened a new issue, #107: URL: https://github.com/apache/rocketmq-flink/issues/107 I got the error when i consume rocketmq message in flink job： ``` Caused by: org.apache.rocketmq.client.exception.MQClientException: The message queue is not in assigned list, message queue: MessageQueue [topic=yumiao1205, brokerName=broker-a, queueId=1] For more information, please visit the url, https://rocketmq.apache.org/docs/bestPractice/06FAQ ``` My rocketmq version: 5.1.1 flink version: 1.15.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 9f5a584d719fd9c061a65feeb84de620a7d581a5 / zhouxiang use withValue method name Report URL: https://github.com/apache/rocketmq/actions/runs/7345647330 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 9e4fd0e68a1ea6ab1b1f3344ac9ae79af29a32c2 / baijun44 [ISSUE #7697] Fix can't open controller metricsExporter. (#7705) Report URL: https://github.com/apache/rocketmq/actions/runs/7345538292 With regards, GitHub Actions via GitBox
(rocketmq-site) branch new-official-website updated: [ISSUE #610] Fix doc error about metricsGrpcExporterTarget (#611)
This is an automated email from the ASF dual-hosted git repository. jinrongtong pushed a commit to branch new-official-website in repository https://gitbox.apache.org/repos/asf/rocketmq-site.git The following commit(s) were added to refs/heads/new-official-website by this push: new cb5340defb [ISSUE #610] Fix doc error about metricsGrpcExporterTarget (#611) cb5340defb is described below commit cb5340defbf21b1f0858c05335bd5d9592c222e6 Author: zzl <87265072+zhilia...@users.noreply.github.com> AuthorDate: Thu Dec 28 16:26:44 2023 +0800 [ISSUE #610] Fix doc error about metricsGrpcExporterTarget (#611) Co-authored-by: shizhili --- .../version-5.0/12-observability/01metrics.md | 2 +- versioned_docs/version-5.0/12-observability/01metrics.md| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/i18n/en/docusaurus-plugin-content-docs/version-5.0/12-observability/01metrics.md b/i18n/en/docusaurus-plugin-content-docs/version-5.0/12-observability/01metrics.md index d213a384c9..a01272af24 100644 --- a/i18n/en/docusaurus-plugin-content-docs/version-5.0/12-observability/01metrics.md +++ b/i18n/en/docusaurus-plugin-content-docs/version-5.0/12-observability/01metrics.md @@ -112,7 +112,7 @@ Prerequisites: Deploy an OpenTelemetry Collector that supports the [GRPC OpenTel To enable the gRPC OTLP exporter of Broker metrics, do the following: 1. Set `metricsExporterType` to `OTLP_GRPC`. -2. Set `getMetricsGrpcExporterTarget` to the endpoint provided by the OpenTelemetry Collector. +2. Set `metricsGrpcExporterTarget` to the endpoint provided by the OpenTelemetry Collector. Optional configurations: diff --git a/versioned_docs/version-5.0/12-observability/01metrics.md b/versioned_docs/version-5.0/12-observability/01metrics.md index b06576c343..732c73360e 100644 --- a/versioned_docs/version-5.0/12-observability/01metrics.md +++ b/versioned_docs/version-5.0/12-observability/01metrics.md @@ -112,7 +112,7 @@ gRPC OTLP exporter 会周期性地向指定的 OpenTelemetry Collector 上报 me 开启 Broker metrics 的 gRPC OTLP exporter 需要进行以下配置： 1. 将 `metricsExporterType` 设置为 `OTLP_GRPC` -2. 将 `getMetricsGrpcExporterTarget` 设置为 OpenTelemetry Collector 提供的 endpoint +2. 将 `metricsGrpcExporterTarget` 设置为 OpenTelemetry Collector 提供的 endpoint 可选配置：
Re: [PR] [ISSUE #610] Fix doc error about metricsGrpcExporterTarget [rocketmq-site]
RongtongJin merged PR #611: URL: https://github.com/apache/rocketmq-site/pull/611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] doc error [rocketmq-site]
RongtongJin closed issue #610: doc error URL: https://github.com/apache/rocketmq-site/issues/610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 9f5a584d719fd9c061a65feeb84de620a7d581a5 / zhouxiang use withValue method name Report URL: https://github.com/apache/rocketmq/actions/runs/7345647339 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 9e4fd0e68a1ea6ab1b1f3344ac9ae79af29a32c2 / baijun44 [ISSUE #7697] Fix can't open controller metricsExporter. (#7705) Report URL: https://github.com/apache/rocketmq/actions/runs/7345669996 With regards, GitHub Actions via GitBox
