Re: [PR] [ISSUE #7710] Handle blank string for UtilAll#split to fix the bugs of ACL [rocketmq]
codecov-commenter commented on PR #7712: URL: https://github.com/apache/rocketmq/pull/7712#issuecomment-1873707724 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7712?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`9e4fd0e`)](https://app.codecov.io/gh/apache/rocketmq/commit/9e4fd0e68a1ea6ab1b1f3344ac9ae79af29a32c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.18% compared to head [(`5a82142`)](https://app.codecov.io/gh/apache/rocketmq/pull/7712?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.16%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#7712 +/- ## = - Coverage 43.18% 43.16% -0.02% + Complexity 9821 9809 -12 = Files 1165 1165 Lines 8454684548 +2 Branches 1097910980 +1 = - Hits 3651036496 -14 - Misses 4350343509 +6 - Partials4533 4543 +10 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7712?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user Qinglong-Lee (triggered by yuz10). Head commit for run: 5a821428eaff857a103058f007bf9787bf2a9227 / liqinglong Handle blank string for UtilAll#split Report URL: https://github.com/apache/rocketmq/actions/runs/7383234153 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user Qinglong-Lee (triggered by Qinglong-Lee). Head commit for run: 9e4fd0e68a1ea6ab1b1f3344ac9ae79af29a32c2 / baijun44 [ISSUE #7697] Fix can't open controller metricsExporter. (#7705) Report URL: https://github.com/apache/rocketmq/actions/runs/7383303902 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" is working again!
The GitHub Actions job "PR-CI" on rocketmq.git has succeeded. Run started by GitHub user Qinglong-Lee (triggered by yuz10). Head commit for run: 5a821428eaff857a103058f007bf9787bf2a9227 / liqinglong Handle blank string for UtilAll#split Report URL: https://github.com/apache/rocketmq/actions/runs/7383234154 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user Qinglong-Lee (triggered by yuz10). Head commit for run: 5a821428eaff857a103058f007bf9787bf2a9227 / liqinglong Handle blank string for UtilAll#split Report URL: https://github.com/apache/rocketmq/actions/runs/7383234149 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7710] Handle blank string for UtilAll#split to fix the bugs of ACL [rocketmq]
Qinglong-Lee commented on code in PR #7712: URL: https://github.com/apache/rocketmq/pull/7712#discussion_r1439206440 ## common/src/main/java/org/apache/rocketmq/common/UtilAll.java: ## @@ -31,13 +31,7 @@ import java.text.NumberFormat; import java.text.ParseException; import java.text.SimpleDateFormat; -import java.util.Arrays; -import java.util.Calendar; -import java.util.Date; -import java.util.Enumeration; -import java.util.Iterator; -import java.util.List; -import java.util.Map; +import java.util.*; Review Comment: Hi，RongtongJin, I've fixed the import issue, please review again, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user Qinglong-Lee (triggered by RongtongJin). Head commit for run: 40f783879ecdd8e6655f896d5243a38c1224c890 / liqinglong Handle blank string for UtilAll#split Report URL: https://github.com/apache/rocketmq/actions/runs/7381460088 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7710] Handle blank string for UtilAll#split to fix the bugs of ACL [rocketmq]
RongtongJin commented on code in PR #7712: URL: https://github.com/apache/rocketmq/pull/7712#discussion_r1439171564 ## common/src/main/java/org/apache/rocketmq/common/UtilAll.java: ## @@ -31,13 +31,7 @@ import java.text.NumberFormat; import java.text.ParseException; import java.text.SimpleDateFormat; -import java.util.Arrays; -import java.util.Calendar; -import java.util.Date; -import java.util.Enumeration; -import java.util.Iterator; -import java.util.List; -import java.util.Map; +import java.util.*; Review Comment: Using the '.*' form of import should be avoided -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user Qinglong-Lee (triggered by Qinglong-Lee). Head commit for run: 9e4fd0e68a1ea6ab1b1f3344ac9ae79af29a32c2 / baijun44 [ISSUE #7697] Fix can't open controller metricsExporter. (#7705) Report URL: https://github.com/apache/rocketmq/actions/runs/7382695240 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user Qinglong-Lee (triggered by RongtongJin). Head commit for run: 40f783879ecdd8e6655f896d5243a38c1224c890 / liqinglong Handle blank string for UtilAll#split Report URL: https://github.com/apache/rocketmq/actions/runs/7381460083 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user Qinglong-Lee (triggered by RongtongJin). Head commit for run: 40f783879ecdd8e6655f896d5243a38c1224c890 / liqinglong Handle blank string for UtilAll#split Report URL: https://github.com/apache/rocketmq/actions/runs/7381460087 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user Qinglong-Lee (triggered by RongtongJin). Head commit for run: 40f783879ecdd8e6655f896d5243a38c1224c890 / liqinglong Handle blank string for UtilAll#split Report URL: https://github.com/apache/rocketmq/actions/runs/7381460085 With regards, GitHub Actions via GitBox
Re: [PR] Handle blank string for UtilAll#split to fix the bugs of ACL [rocketmq]
Qinglong-Lee commented on PR #7712: URL: https://github.com/apache/rocketmq/pull/7712#issuecomment-1873564423 @RongtongJin @fuyou001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Handle blank string for UtilAll#split to fix the bugs of ACL [rocketmq]
Qinglong-Lee opened a new pull request, #7712: URL: https://github.com/apache/rocketmq/pull/7712 ### Which Issue(s) This PR Fixes Fixes #7710 ### Brief Description The PR is for a bug the ACL, which caused the problem of deleting the last item of the topic/group perms or the global white list. The bug is due to the flaw of UtilAll#split func which didn't handle the blank string case properly. So I've fixed it. ### How Did You Test This Change? This change have been tested by unit test and the bug have been tested on local. I've also searched the usages of the changed method globally. I'm sure the bug has been fixed and has no influence on any other functions of the project.   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Feat query key by time range [rocketmq]
github-actions[bot] commented on PR #5772: URL: https://github.com/apache/rocketmq/pull/5772#issuecomment-1873536231 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Feat query key by time range [rocketmq]
github-actions[bot] closed pull request #5772: Feat query key by time range URL: https://github.com/apache/rocketmq/pull/5772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #5795]Optimize batch unregistration broker service [rocketmq]
github-actions[bot] commented on PR #5796: URL: https://github.com/apache/rocketmq/pull/5796#issuecomment-1873536201 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] HATest is flaky on macOS [rocketmq]
github-actions[bot] commented on issue #5782: URL: https://github.com/apache/rocketmq/issues/5782#issuecomment-1873536216 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] HATest is flaky on macOS [rocketmq]
github-actions[bot] closed issue #5782: HATest is flaky on macOS URL: https://github.com/apache/rocketmq/issues/5782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Deleting the last item problem of the ACL topic/group perms or the global white list caused by the UtilAll#split func flaw [rocketmq]
Qinglong-Lee commented on issue #7710: URL: https://github.com/apache/rocketmq/issues/7710#issuecomment-1873286935 @RongtongJin @fuyou001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] Deleting the last item problem of the ACL topic/group perms or the global white list caused by the UtilAll#split func flaw [rocketmq]
Qinglong-Lee opened a new issue, #7710: URL: https://github.com/apache/rocketmq/issues/7710 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment OS(CentOS release 7.6.1810) ### RocketMQ version branch(develop) version(5.1.5-SNAPSHOT) ### JDK Version Compliler(Oracke JDK 1.8.0_361) OS(CentOS release 7.6.1810) ### Describe the Bug I found an bug of ACL during my work on RocketMQ. When I tried to delete the last item of the ACL topic/group perms, there was an error which indicates the resouce fomat is incrorrect. And there's also an similar problem of the global white list, which is always remain an empty data at last. ### Steps to Reproduce **To reproduce you can use two ways:** 1. If you use the Dashboard(take the topic/group perms for example) 1.1 Create an ACL with mutiple topic perms and group perms. 1.2 Delete the topic perms or group perms one by one. 1.3 The error woud appear when delete the last one.    2. If you want to create an test method for reproduce 2.1 New an DefaultMQAdminExt and config it with namesrv and then start it. 2.2 New an PlainAccessConfig and setGroupPerms(Collections.EMPTY_LIST), setTopicPerms(Collections.EMPTY_LIST). 2.3 Then call DefaultMQAdminExt #createAndUpdatePlainAccessConfig. 2.4 Or to call DefaultMQAdminExt #updateGlobalWhiteAddrConfig with the second parmeter an empty string.   ### What Did You Expect to See? For the topic/group perms, it should not be an error to delete the last item.  For the global white list, it should not be an empty data  ### What Did You See Instead? For the topic/group perms, it popup an error: org.apache.rocketmq.client.exception.MQClientException: CODE: 209 DESC: Parse Resource format error for . The expected resource format is 'Res=Perm'. For example: topicA=SUB  For the global white list, it remains an empty data  ### Additional Context **I've already found and fixed the bug, and I'll submit an PR later.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
