Re: [I] Could the community publish the official images of Rocketmq-Exporter? [rocketmq-exporter]
peachisai commented on issue #153: URL: https://github.com/apache/rocketmq-exporter/issues/153#issuecomment-1891510476 > @peachisai `rocketmq-exporter` has not been released with docker images, I'd like to add one if it is necessary. Are there any specific requirements for this docker image? Thank you for the promotion.I think the latest code version is good, no other specific requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] SnakeYAML 反序列化漏洞(CVE-2022-1471) [rocketmq]
charliesls opened a new issue, #7755: URL: https://github.com/apache/rocketmq/issues/7755 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment Don't care. ### RocketMQ version 5.1.4 ### JDK Version Don't care. ### Describe the Bug 升级snakeyaml-1.32.jar版本 SnakeYAML 是一个将 YAML 文件与 Java 对象相互转换的开源代码库。 将 snakeyaml 升级到 2.0 及以上版本，下载地址：https://mvnrepository.com/artifact/org.yaml/snakeyaml ### Steps to Reproduce SnakeYAML 存在安全漏洞，该漏洞源于其Constructor()类由于没有对反序列化的类型进行限制，导致攻击者提供恶意yaml内容可以实现远程代码执行。 ### What Did You Expect to See? rocketmq/lib/snakeyaml ≥ 2.0 ### What Did You See Instead? rocketmq/lib/snakeyaml-1.32.jar ### Additional Context 希望官方升级snakeyaml的版本 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 89fdab4d5830ce749e79ad5372d2b349e376c45a / dingshuangxi888 [ISSUE #7752] Fix ppv2 tls ascii start with (byte)2 (#7753) * Fix ascii validate for ppv2 tls. * fix ppv2 tls ascii check - Co-authored-by: ShuangxiDing Report URL: https://github.com/apache/rocketmq/actions/runs/7525566521 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" is working again!
The GitHub Actions job "PUSH-CI" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 89fdab4d5830ce749e79ad5372d2b349e376c45a / dingshuangxi888 [ISSUE #7752] Fix ppv2 tls ascii start with (byte)2 (#7753) * Fix ascii validate for ppv2 tls. * fix ppv2 tls ascii check - Co-authored-by: ShuangxiDing Report URL: https://github.com/apache/rocketmq/actions/runs/7525566520 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 89fdab4d5830ce749e79ad5372d2b349e376c45a / dingshuangxi888 [ISSUE #7752] Fix ppv2 tls ascii start with (byte)2 (#7753) * Fix ascii validate for ppv2 tls. * fix ppv2 tls ascii check - Co-authored-by: ShuangxiDing Report URL: https://github.com/apache/rocketmq/actions/runs/7525566517 With regards, GitHub Actions via GitBox
(rocketmq) branch develop updated: [ISSUE #7752] Fix ppv2 tls ascii start with (byte)2 (#7753)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 89fdab4d58 [ISSUE #7752] Fix ppv2 tls ascii start with (byte)2 (#7753)
89fdab4d58 is described below
commit 89fdab4d5830ce749e79ad5372d2b349e376c45a
Author: dingshuangxi888
AuthorDate: Mon Jan 15 15:18:45 2024 +0800
[ISSUE #7752] Fix ppv2 tls ascii start with (byte)2 (#7753)
* Fix ascii validate for ppv2 tls.
* fix ppv2 tls ascii check
-
Co-authored-by: ShuangxiDing
---
.../rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java | 9 +
.../org/apache/rocketmq/remoting/netty/NettyRemotingServer.java | 9 +
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git
a/proxy/src/main/java/org/apache/rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java
b/proxy/src/main/java/org/apache/rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java
index b584ddfbdc..cdf33165d7 100644
---
a/proxy/src/main/java/org/apache/rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java
+++
b/proxy/src/main/java/org/apache/rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java
@@ -41,6 +41,7 @@ import
io.grpc.netty.shaded.io.netty.handler.ssl.util.InsecureTrustManagerFactor
import io.grpc.netty.shaded.io.netty.handler.ssl.util.SelfSignedCertificate;
import io.grpc.netty.shaded.io.netty.util.AsciiString;
import io.grpc.netty.shaded.io.netty.util.CharsetUtil;
+import java.nio.charset.StandardCharsets;
import org.apache.commons.collections.CollectionUtils;
import org.apache.commons.lang3.StringUtils;
import org.apache.rocketmq.common.constant.HAProxyConstants;
@@ -193,13 +194,13 @@ public class ProxyAndTlsProtocolNegotiator implements
InternalProtocolNegotiator
}
if (CollectionUtils.isNotEmpty(msg.tlvs())) {
msg.tlvs().forEach(tlv -> {
-byte[] valueBytes =
ByteBufUtil.getBytes(tlv.content());
-if (!BinaryUtil.isAscii(valueBytes)) {
-return;
-}
Attributes.Key key = AttributeKeys.valueOf(
HAProxyConstants.PROXY_PROTOCOL_TLV_PREFIX +
String.format("%02x", tlv.typeByteValue()));
+byte[] valueBytes =
ByteBufUtil.getBytes(tlv.content());
String value = StringUtils.trim(new String(valueBytes,
CharsetUtil.UTF_8));
+if
(!BinaryUtil.isAscii(value.getBytes(StandardCharsets.UTF_8))) {
+return;
+}
builder.set(key, value);
});
}
diff --git
a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingServer.java
b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingServer.java
index 735d36168f..7213b0c24f 100644
---
a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingServer.java
+++
b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingServer.java
@@ -55,6 +55,7 @@ import io.netty.util.TimerTask;
import io.netty.util.concurrent.DefaultEventExecutorGroup;
import java.io.IOException;
import java.net.InetSocketAddress;
+import java.nio.charset.StandardCharsets;
import java.security.cert.CertificateException;
import java.time.Duration;
import java.util.List;
@@ -794,13 +795,13 @@ public class NettyRemotingServer extends
NettyRemotingAbstract implements Remoti
}
if (CollectionUtils.isNotEmpty(msg.tlvs())) {
msg.tlvs().forEach(tlv -> {
+AttributeKey key = AttributeKeys.valueOf(
+HAProxyConstants.PROXY_PROTOCOL_TLV_PREFIX +
String.format("%02x", tlv.typeByteValue()));
byte[] valueBytes =
ByteBufUtil.getBytes(tlv.content());
-if (!BinaryUtil.isAscii(valueBytes)) {
+String value = StringUtils.trim(new String(valueBytes,
CharsetUtil.UTF_8));
+if
(!BinaryUtil.isAscii(value.getBytes(StandardCharsets.UTF_8))) {
return;
}
-AttributeKey key = AttributeKeys.valueOf(
-HAProxyConstants.PROXY_PROTOCOL_TLV_PREFIX +
String.format("%02x", tlv.typeByteValue()));
-String value = StringUtils.trim(new String(valueBytes,
CharsetUtil.UTF_8));
channel.attr(key).set(value);
});
}
Re: [PR] Fix ppv2 tls ascii start with (byte)2 [rocketmq]
RongtongJin merged PR #7753: URL: https://github.com/apache/rocketmq/pull/7753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Fix ppv2 tlvs empty space trim [rocketmq]
RongtongJin closed issue #7752: [Bug] Fix ppv2 tlvs empty space trim URL: https://github.com/apache/rocketmq/issues/7752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user GenerousMan (triggered by GenerousMan). Head commit for run: 14c0048e67dfa62f6d817d71c817fa8cfcca6ab0 / juntao remove useless import. Report URL: https://github.com/apache/rocketmq/actions/runs/7525233366 With regards, GitHub Actions via GitBox
Re: [I] rocketmq-mqtt是否具有客户端ID（clientId）唯一的限制？ [rocketmq-mqtt]
zhouqinghui commented on issue #236: URL: https://github.com/apache/rocketmq-mqtt/issues/236#issuecomment-1891417288   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user GenerousMan (triggered by GenerousMan). Head commit for run: 5e50badca1c84ad420ba38b0b986724f4cec4fb7 / mxsm [ISSUE #7747] Simplify code checks using Optional in ClientRequestProcessor#getRouteInfoByTopic method (#7748) Report URL: https://github.com/apache/rocketmq/actions/runs/752525 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: d3c4e22ede85f28192df4614d8a1df770820fe67 / ShuangxiDing fix ppv2 tls ascii check Report URL: https://github.com/apache/rocketmq/actions/runs/7525159086 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: 5e50badca1c84ad420ba38b0b986724f4cec4fb7 / mxsm [ISSUE #7747] Simplify code checks using Optional in ClientRequestProcessor#getRouteInfoByTopic method (#7748) Report URL: https://github.com/apache/rocketmq/actions/runs/7525176232 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user GenerousMan (triggered by GenerousMan). Head commit for run: 14c0048e67dfa62f6d817d71c817fa8cfcca6ab0 / juntao remove useless import. Report URL: https://github.com/apache/rocketmq/actions/runs/7525233364 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" is working again!
The GitHub Actions job "PR-CI" on rocketmq.git has succeeded. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: d3c4e22ede85f28192df4614d8a1df770820fe67 / ShuangxiDing fix ppv2 tls ascii check Report URL: https://github.com/apache/rocketmq/actions/runs/7525159090 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: d3c4e22ede85f28192df4614d8a1df770820fe67 / ShuangxiDing fix ppv2 tls ascii check Report URL: https://github.com/apache/rocketmq/actions/runs/7525159089 With regards, GitHub Actions via GitBox
[PR] Fix ppv2 tls ascii start with (byte)2 [rocketmq]
dingshuangxi888 opened a new pull request, #7753: URL: https://github.com/apache/rocketmq/pull/7753 ### Which Issue(s) This PR Fixes Fixes #7752 ### Brief Description The tlvs value in ppv2 has the space character can not pass the ascii check. So the value should be trims before the ascii check. ### How Did You Test This Change? Send message with the byte value start with (byte)2, it will not be filtered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] Fix ppv2 tlvs empty space trim [rocketmq]
dingshuangxi888 opened a new issue, #7752: URL: https://github.com/apache/rocketmq/issues/7752 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment Linux ### RocketMQ version develop ### JDK Version Java11 ### Describe the Bug The tlvs value in ppv2 has the space character can not pass the ascii check. So the value should be trims before the ascii check. ### Steps to Reproduce Send message with the byte value start with (byte)2, it will filtered. ### What Did You Expect to See? The tlvs value in ppv2 has the space character can not pass the ascii check. So the value should be trims before the ascii check. ### What Did You See Instead? Send message with the byte value start with (byte)2, it will not filtered. ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Could the community publish the official images of Rocketmq-Exporter? [rocketmq-exporter]
caigy commented on issue #153: URL: https://github.com/apache/rocketmq-exporter/issues/153#issuecomment-1891349003 @peachisai `rocketmq-exporter` has not been released with docker images, I'd like to add one if it is necessary. Are there any specific requirements for this docker image? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 5e50badca1c84ad420ba38b0b986724f4cec4fb7 / mxsm [ISSUE #7747] Simplify code checks using Optional in ClientRequestProcessor#getRouteInfoByTopic method (#7748) Report URL: https://github.com/apache/rocketmq/actions/runs/7524057574 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 5e50badca1c84ad420ba38b0b986724f4cec4fb7 / mxsm [ISSUE #7747] Simplify code checks using Optional in ClientRequestProcessor#getRouteInfoByTopic method (#7748) Report URL: https://github.com/apache/rocketmq/actions/runs/7524057577 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 5e50badca1c84ad420ba38b0b986724f4cec4fb7 / mxsm [ISSUE #7747] Simplify code checks using Optional in ClientRequestProcessor#getRouteInfoByTopic method (#7748) Report URL: https://github.com/apache/rocketmq/actions/runs/7524057573 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user GenerousMan (triggered by GenerousMan). Head commit for run: d83244a13b24f9f14bc5fc4f39d74722bc22f2dc / juntao add license Report URL: https://github.com/apache/rocketmq/actions/runs/7523858700 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 5e50badca1c84ad420ba38b0b986724f4cec4fb7 / mxsm [ISSUE #7747] Simplify code checks using Optional in ClientRequestProcessor#getRouteInfoByTopic method (#7748) Report URL: https://github.com/apache/rocketmq/actions/runs/7524057580 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user GenerousMan (triggered by GenerousMan). Head commit for run: 9384f675c5d49ad6119acf9aea41956027699b1f / juntao Merge remote-tracking branch 'origin/develop' into betterObserve Report URL: https://github.com/apache/rocketmq/actions/runs/7523832491 With regards, GitHub Actions via GitBox
Re: [I] [Enhancement] Simplify code checks using Optional in ClientRequestProcessor#getRouteInfoByTopic method [rocketmq]
RongtongJin closed issue #7747: [Enhancement] Simplify code checks using Optional in ClientRequestProcessor#getRouteInfoByTopic method URL: https://github.com/apache/rocketmq/issues/7747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #7747] Simplify code checks using Optional in ClientRequestProcessor#getRouteInfoByTopic method (#7748)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 5e50badca1 [ISSUE #7747] Simplify code checks using Optional in
ClientRequestProcessor#getRouteInfoByTopic method (#7748)
5e50badca1 is described below
commit 5e50badca1c84ad420ba38b0b986724f4cec4fb7
Author: mxsm
AuthorDate: Mon Jan 15 11:44:00 2024 +0800
[ISSUE #7747] Simplify code checks using Optional in
ClientRequestProcessor#getRouteInfoByTopic method (#7748)
---
.../apache/rocketmq/namesrv/processor/ClientRequestProcessor.java| 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
a/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/ClientRequestProcessor.java
b/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/ClientRequestProcessor.java
index 97a132e234..17a070c7f0 100644
---
a/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/ClientRequestProcessor.java
+++
b/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/ClientRequestProcessor.java
@@ -19,6 +19,7 @@ package org.apache.rocketmq.namesrv.processor;
import com.alibaba.fastjson.serializer.SerializerFeature;
import io.netty.channel.ChannelHandlerContext;
+import java.util.Optional;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import org.apache.rocketmq.common.MQVersion;
@@ -86,8 +87,8 @@ public class ClientRequestProcessor implements
NettyRequestProcessor {
}
byte[] content;
-Boolean standardJsonOnly =
requestHeader.getAcceptStandardJsonOnly();
-if (request.getVersion() >= MQVersion.Version.V4_9_4.ordinal() ||
null != standardJsonOnly && standardJsonOnly) {
+Boolean standardJsonOnly =
Optional.ofNullable(requestHeader.getAcceptStandardJsonOnly()).orElse(false);
+if (request.getVersion() >= MQVersion.Version.V4_9_4.ordinal() ||
standardJsonOnly) {
content =
topicRouteData.encode(SerializerFeature.BrowserCompatible,
SerializerFeature.QuoteFieldNames,
SerializerFeature.SkipTransientField,
SerializerFeature.MapSortField);
Re: [PR] [ISSUE #7747]Simplify code checks using Optional in ClientRequestProcessor#getRouteInfoByTopic method [rocketmq]
RongtongJin merged PR #7748: URL: https://github.com/apache/rocketmq/pull/7748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user GenerousMan (triggered by GenerousMan). Head commit for run: d83244a13b24f9f14bc5fc4f39d74722bc22f2dc / juntao add license Report URL: https://github.com/apache/rocketmq/actions/runs/7523858698 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user GenerousMan (triggered by GenerousMan). Head commit for run: 9384f675c5d49ad6119acf9aea41956027699b1f / juntao Merge remote-tracking branch 'origin/develop' into betterObserve Report URL: https://github.com/apache/rocketmq/actions/runs/7523832496 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user GenerousMan (triggered by GenerousMan). Head commit for run: d83244a13b24f9f14bc5fc4f39d74722bc22f2dc / juntao add license Report URL: https://github.com/apache/rocketmq/actions/runs/7523858694 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user GenerousMan (triggered by GenerousMan). Head commit for run: 50974adaaa75200092a4bb7fad48c6a3d4c2b1ee / Lei Zhiyuan [ISSUE #7658] Fix bug of timer message metrics with setDelayTimeMs Report URL: https://github.com/apache/rocketmq/actions/runs/7523867136 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "License checker" is working again!
The GitHub Actions job "License checker" on rocketmq.git has succeeded. Run started by GitHub user GenerousMan (triggered by GenerousMan). Head commit for run: d83244a13b24f9f14bc5fc4f39d74722bc22f2dc / juntao add license Report URL: https://github.com/apache/rocketmq/actions/runs/7523858691 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user GenerousMan (triggered by GenerousMan). Head commit for run: d83244a13b24f9f14bc5fc4f39d74722bc22f2dc / juntao add license Report URL: https://github.com/apache/rocketmq/actions/runs/7523858692 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user GenerousMan (triggered by GenerousMan). Head commit for run: 50974adaaa75200092a4bb7fad48c6a3d4c2b1ee / Lei Zhiyuan [ISSUE #7658] Fix bug of timer message metrics with setDelayTimeMs Report URL: https://github.com/apache/rocketmq/actions/runs/7523842803 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user GenerousMan (triggered by GenerousMan). Head commit for run: 9384f675c5d49ad6119acf9aea41956027699b1f / juntao Merge remote-tracking branch 'origin/develop' into betterObserve Report URL: https://github.com/apache/rocketmq/actions/runs/7523832492 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "License checker" failed!
The GitHub Actions job "License checker" on rocketmq.git has failed. Run started by GitHub user GenerousMan (triggered by GenerousMan). Head commit for run: 9384f675c5d49ad6119acf9aea41956027699b1f / juntao Merge remote-tracking branch 'origin/develop' into betterObserve Report URL: https://github.com/apache/rocketmq/actions/runs/7523832489 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user GenerousMan (triggered by GenerousMan). Head commit for run: 9384f675c5d49ad6119acf9aea41956027699b1f / juntao Merge remote-tracking branch 'origin/develop' into betterObserve Report URL: https://github.com/apache/rocketmq/actions/runs/7523832500 With regards, GitHub Actions via GitBox
Re: [I] Failed to examine pop consumer group status/progress/connection, no topic route for retry topic [rocketmq]
github-actions[bot] closed issue #5844: Failed to examine pop consumer group status/progress/connection, no topic route for retry topic URL: https://github.com/apache/rocketmq/issues/5844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Failed to examine pop consumer group status/progress/connection, no topic route for retry topic [rocketmq]
github-actions[bot] commented on issue #5844: URL: https://github.com/apache/rocketmq/issues/5844#issuecomment-1891122286 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] set the value of order when create or update topic [rocketmq]
github-actions[bot] commented on issue #5860: URL: https://github.com/apache/rocketmq/issues/5860#issuecomment-1891122269 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] set the value of order when create or update topic [rocketmq]
github-actions[bot] closed issue #5860: set the value of order when create or update topic URL: https://github.com/apache/rocketmq/issues/5860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore: improve timeout control [rocketmq]
diaohancai opened a new pull request, #7750: URL: https://github.com/apache/rocketmq/pull/7750 Fixes #7749 ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #190] Add e2e workflow [rocketmq-operator]
drivebyer closed pull request #205: [ISSUE #190] Add e2e workflow URL: https://github.com/apache/rocketmq-operator/pull/205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Chore] improve `NettyRemotingAbstract` about timeout control [rocketmq]
diaohancai opened a new issue, #7749:
URL: https://github.com/apache/rocketmq/issues/7749
### Before Creating the Bug Report
- [X] I found a bug, not just asking a question, which should be created in
[GitHub Discussions](https://github.com/apache/rocketmq/discussions).
- [X] I have searched the [GitHub
Issues](https://github.com/apache/rocketmq/issues) and [GitHub
Discussions](https://github.com/apache/rocketmq/discussions) of this
repository and believe that this is not a duplicate.
- [X] I have confirmed that this bug belongs to the current repository, not
other repositories of RocketMQ.
### Runtime platform environment
Don't care.
### RocketMQ version
branch: 4.9.x
### JDK Version
Don't care.
### Describe the Bug
`org.apache.rocketmq.remoting.netty.NettyRemotingAbstract#invokeSyncImpl`
```java
channel.writeAndFlush(request).addListener(new ChannelFutureListener() {
@Override
public void operationComplete(ChannelFuture f) throws Exception {
if (f.isSuccess()) {
responseFuture.setSendRequestOK(true);
return;
} else {
responseFuture.setSendRequestOK(false);
}
responseTable.remove(opaque);
responseFuture.setCause(f.cause());
responseFuture.putResponse(null);
log.warn("send a request command to channel <" + addr + ">
failed.");
}
});
RemotingCommand responseCommand = responseFuture.waitResponse(timeoutMillis);
```
`org.apache.rocketmq.remoting.netty.ResponseFuture#putResponse`
```
public void putResponse(final RemotingCommand responseCommand) {
this.responseCommand = responseCommand;
this.countDownLatch.countDown();
}
```
1. `responseFuture.waitResponse(timeoutMillis);` ->
`this.countDownLatch.await(timeoutMillis, TimeUnit.MILLISECONDS);` use
`countDownLatch` to wait for asynchronous response.
2. If `f.isSuccess() == false`, then call
`responseFuture.putResponse(null);` to `countDownLatch.countDown()`.
3. But if `f.isSuccess() == true`, did not to `countDownLatch.countDown()`,
cause `responseFuture.waitResponse(timeoutMillis);` always timeout after
`timeoutMillis`.
### Steps to Reproduce
Don't care.
### What Did You Expect to See?
If `f.isSuccess() == true`, also `countDownLatch.countDown()`.
And `RemotingCommand responseCommand =
responseFuture.waitResponse(timeoutMillis);` is no need to wait for timeout.
### What Did You See Instead?
Nothing.
### Additional Context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
