(rocketmq) branch develop updated: [ISSUE #8100] Expose print audit log function (#8101)
This is an automated email from the ASF dual-hosted git repository. lizhimin pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq.git The following commit(s) were added to refs/heads/develop by this push: new 1a2fc17b5e [ISSUE #8100] Expose print audit log function (#8101) 1a2fc17b5e is described below commit 1a2fc17b5e64061464f32023fcdb247eec943ce3 Author: dingshuangxi888 AuthorDate: Tue May 7 14:54:32 2024 +0800 [ISSUE #8100] Expose print audit log function (#8101) --- .../auth/authentication/provider/DefaultAuthenticationProvider.java | 2 +- .../auth/authorization/provider/DefaultAuthorizationProvider.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/auth/src/main/java/org/apache/rocketmq/auth/authentication/provider/DefaultAuthenticationProvider.java b/auth/src/main/java/org/apache/rocketmq/auth/authentication/provider/DefaultAuthenticationProvider.java index 482b02db03..98e7ede7ee 100644 --- a/auth/src/main/java/org/apache/rocketmq/auth/authentication/provider/DefaultAuthenticationProvider.java +++ b/auth/src/main/java/org/apache/rocketmq/auth/authentication/provider/DefaultAuthenticationProvider.java @@ -68,7 +68,7 @@ public class DefaultAuthenticationProvider implements AuthenticationProvider
Re: [PR] [ISSUE #8100] Expose print audit log function [rocketmq]
lizhimins merged PR #8101: URL: https://github.com/apache/rocketmq/pull/8101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Make audit log method scalabe [rocketmq]
lizhimins closed issue #8100: [Enhancement] Make audit log method scalabe URL: https://github.com/apache/rocketmq/issues/8100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: b476281b47c4107d07fdae7b40bb4936979faa9a / dingshuangxi888 修改参数解析逻辑，修复部分接口没有extFields的问题 Report URL: https://github.com/apache/rocketmq/actions/runs/8980529877 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user dingshuangxi888 (triggered by lizhimins). Head commit for run: 8857fbb80f7a531aa656267525af05a701bc15a6 / dingshuangxi888 make audit log scalable. Report URL: https://github.com/apache/rocketmq/actions/runs/8979218930 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8046] Fix authentication context build for no extFields [rocketmq]
codecov-commenter commented on PR #8102: URL: https://github.com/apache/rocketmq/pull/8102#issuecomment-2097551962 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8102?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `0%` with `4 lines` in your changes are missing coverage. Please review. > Project coverage is 42.85%. Comparing base [(`0f0324a`)](https://app.codecov.io/gh/apache/rocketmq/commit/0f0324a7dd9b2e994aeb4a4f5c8631f8465daae5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b476281`)](https://app.codecov.io/gh/apache/rocketmq/pull/8102?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 1 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8102?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...n/builder/DefaultAuthenticationContextBuilder.java](https://app.codecov.io/gh/apache/rocketmq/pull/8102?src=pr&el=tree&filepath=auth%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fauth%2Fauthentication%2Fbuilder%2FDefaultAuthenticationContextBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvYXV0aC9hdXRoZW50aWNhdGlvbi9idWlsZGVyL0RlZmF1bHRBdXRoZW50aWNhdGlvbkNvbnRleHRCdWlsZGVyLmphdmE=) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...on/builder/DefaultAuthorizationContextBuilder.java](https://app.codecov.io/gh/apache/rocketmq/pull/8102?src=pr&el=tree&filepath=auth%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fauth%2Fauthorization%2Fbuilder%2FDefaultAuthorizationContextBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvYXV0aC9hdXRob3JpemF0aW9uL2J1aWxkZXIvRGVmYXVsdEF1dGhvcml6YXRpb25Db250ZXh0QnVpbGRlci5qYXZh) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8102 +/- ## = - Coverage 42.88% 42.85% -0.03% - Complexity 1035810360 +2 = Files 1270 1270 Lines 8868988692 +3 Branches 1139811400 +2 = - Hits 3803038013 -17 - Misses 4596845987 +19 - Partials4691 4692 +1 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8102?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: d05ff5ef6871839fc202612136bb21a24e67998a / Liu Shengzhong [ISSUE #8098] Fix parsing delay message type from property Report URL: https://github.com/apache/rocketmq/actions/runs/8980558985 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8100]make audit log scalable. [rocketmq]
codecov-commenter commented on PR #8101: URL: https://github.com/apache/rocketmq/pull/8101#issuecomment-2097542555 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8101?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 42.83%. Comparing base [(`0f0324a`)](https://app.codecov.io/gh/apache/rocketmq/commit/0f0324a7dd9b2e994aeb4a4f5c8631f8465daae5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`8857fbb`)](https://app.codecov.io/gh/apache/rocketmq/pull/8101?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 1 commits behind head on develop. Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8101 +/- ## = - Coverage 42.88% 42.83% -0.05% + Complexity 1035810353 -5 = Files 1270 1270 Lines 8868988690 +1 Branches 1139811399 +1 = - Hits 3803037992 -38 - Misses 4596846000 +32 - Partials4691 4698 +7 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8101?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #266]: add connections_size metric [rocketmq-mqtt]
yx9o commented on PR #267: URL: https://github.com/apache/rocketmq-mqtt/pull/267#issuecomment-2097541771 Hi, @pingww , please help check, we have some indicator requirements in actual use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user dingshuangxi888 (triggered by lizhimins). Head commit for run: 8857fbb80f7a531aa656267525af05a701bc15a6 / dingshuangxi888 make audit log scalable. Report URL: https://github.com/apache/rocketmq/actions/runs/8979218939 With regards, GitHub Actions via GitBox
(rocketmq-mqtt) 01/01: Merge pull request #263 from YxAc/improve_readme_on_M2
This is an automated email from the ASF dual-hosted git repository. pingww pushed a commit to branch develop_mqtt5.0 in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git commit 5fffacc5e5d7af0ab11453e38947e168b375dd04 Merge: 82677ec d898b5a Author: pingww AuthorDate: Tue May 7 14:21:22 2024 +0800 Merge pull request #263 from YxAc/improve_readme_on_M2 [ISSUE #261] improvement(doc): supplement README to make protoc-gen-java available on Apple M1/M2 README.md | 21 + 1 file changed, 21 insertions(+)
(rocketmq-mqtt) branch develop_mqtt5.0 updated (82677ec -> 5fffacc)
This is an automated email from the ASF dual-hosted git repository. pingww pushed a change to branch develop_mqtt5.0 in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git from 82677ec Merge pull request #249 from DongyuanPan/MQTT_5.0 add d898b5a Supplement README to make protoc-gen-java available on Apple M1/M2 new 5fffacc Merge pull request #263 from YxAc/improve_readme_on_M2 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: README.md | 21 + 1 file changed, 21 insertions(+)
Re: [PR] [ISSUE #261] improvement(doc): supplement README to make protoc-gen-java available on Apple M1/M2 [rocketmq-mqtt]
pingww merged PR #263: URL: https://github.com/apache/rocketmq-mqtt/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: add experimental support for QUIC transport [rocketmq-mqtt]
pingww commented on PR #260: URL: https://github.com/apache/rocketmq-mqtt/pull/260#issuecomment-2097525790 it's better to create pr to develop branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8046] Fix authentication context build for no extFields [rocketmq]
dingshuangxi888 closed pull request #8047: [ISSUE #8046] Fix authentication context build for no extFields URL: https://github.com/apache/rocketmq/pull/8047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: 8857fbb80f7a531aa656267525af05a701bc15a6 / dingshuangxi888 make audit log scalable. Report URL: https://github.com/apache/rocketmq/actions/runs/8979218930 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: 190bf00895600bd202a20067643266d6808059a9 / Liu Shengzhong [ISSUE #8098] Fix parsing delay message type from property Report URL: https://github.com/apache/rocketmq/actions/runs/8979144300 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user hanmz (triggered by RongtongJin). Head commit for run: 9cf519e1beaa6f22c50164f294faa6ca907c5714 / hanmz Fix some typos in DefaultLitePullConsumer and LitePullConsumer Report URL: https://github.com/apache/rocketmq/actions/runs/8813324701 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: 8857fbb80f7a531aa656267525af05a701bc15a6 / dingshuangxi888 make audit log scalable. Report URL: https://github.com/apache/rocketmq/actions/runs/8979218939 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8046] Fix authentication context build for no extFields [rocketmq]
codecov-commenter commented on PR #8047: URL: https://github.com/apache/rocketmq/pull/8047#issuecomment-2097389181 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8047?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `49.18033%` with `31 lines` in your changes are missing coverage. Please review. > Project coverage is 42.83%. Comparing base [(`b39f65e`)](https://app.codecov.io/gh/apache/rocketmq/commit/b39f65ec08b9a0a72f9fdd5b826f2b1c88c9c496?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`190bf00`)](https://app.codecov.io/gh/apache/rocketmq/pull/8047?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 13 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8047?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...lient/impl/consumer/DefaultMQPullConsumerImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/8047?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2Fconsumer%2FDefaultMQPullConsumerImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdWxsQ29uc3VtZXJJbXBsLmphdmE=) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8047?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mq/client/impl/producer/DefaultMQProducerImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/8047?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2Fproducer%2FDefaultMQProducerImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8047?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ocketmq/client/consumer/DefaultMQPullConsumer.java](https://app.codecov.io/gh/apache/rocketmq/pull/8047?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fconsumer%2FDefaultMQPullConsumer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvRGVmYXVsdE1RUHVsbENvbnN1bWVyLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8047?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/8047?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2FMQClientAPIImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | 82.35% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8047?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...n/builder/DefaultAuthenticationContextBuilder.java](https://app.codecov.io/gh/apache/rocketmq/pull/8047?src=pr&el=tree&filepath=auth%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fauth%2Fauthentication%2Fbuilder%2FDefaultAuthenticationContextBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvYXV0aC9hdXRoZW50aWNhdGlvbi9idWlsZGVyL0RlZmF1bHRBdXRoZW50aWNhdGlvbkNvbnRleHRCdWlsZGVyLmphdmE=) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8047?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...on/builder/DefaultAuthorizationContextBuilder.java](https://app.codecov.io/gh/apache/rocketmq/pull/8047?src=pr&el=tree&filepath=auth%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fauth%2Fauthorization%2Fbuilder%2FDefaultAuthorizationContextBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apach
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: 190bf00895600bd202a20067643266d6808059a9 / Liu Shengzhong [ISSUE #8098] Fix parsing delay message type from property Report URL: https://github.com/apache/rocketmq/actions/runs/8979144292 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: d05ff5ef6871839fc202612136bb21a24e67998a / Liu Shengzhong [ISSUE #8098] Fix parsing delay message type from property Report URL: https://github.com/apache/rocketmq/actions/runs/8979165844 With regards, GitHub Actions via GitBox
[PR] [ISSUE #8100]make audit log scalable. [rocketmq]
dingshuangxi888 opened a new pull request, #8101: URL: https://github.com/apache/rocketmq/pull/8101 ### Which Issue(s) This PR Fixes Fixes #8100 ### Brief Description Make the doAuditLog method protected in authentication and authorization. ### How Did You Test This Change? Nothing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Enhancement] Make audit log method scalabe [rocketmq]
dingshuangxi888 opened a new issue, #8100: URL: https://github.com/apache/rocketmq/issues/8100 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary Make audit log method scalabe, if there are some customized requirement. ### Motivation Make audit log method scalabe, if there are some customized requirement. ### Describe the Solution You'd Like Make the doAuditLog method protected in authentication and authorization. ### Describe Alternatives You've Considered No. ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: d05ff5ef6871839fc202612136bb21a24e67998a / Liu Shengzhong [ISSUE #8098] Fix parsing delay message type from property Report URL: https://github.com/apache/rocketmq/actions/runs/8978878696 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: d05ff5ef6871839fc202612136bb21a24e67998a / Liu Shengzhong [ISSUE #8098] Fix parsing delay message type from property Report URL: https://github.com/apache/rocketmq/actions/runs/8978878693 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: d05ff5ef6871839fc202612136bb21a24e67998a / Liu Shengzhong [ISSUE #8098] Fix parsing delay message type from property Report URL: https://github.com/apache/rocketmq/actions/runs/8978878695 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 0f0324a7dd9b2e994aeb4a4f5c8631f8465daae5 / lizhimins <707364...@qq.com> [ISSUE #8076] Fix correct min cq offset when delete tiered storage CommitLog (#8082) Report URL: https://github.com/apache/rocketmq/actions/runs/8978444577 With regards, GitHub Actions via GitBox
(rocketmq) branch develop updated: [ISSUE #8098] Fix parsing delay message type from property
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new d05ff5ef68 [ISSUE #8098] Fix parsing delay message type from property
d05ff5ef68 is described below
commit d05ff5ef6871839fc202612136bb21a24e67998a
Author: Liu Shengzhong
AuthorDate: Tue May 7 10:44:26 2024 +0800
[ISSUE #8098] Fix parsing delay message type from property
---
.../common/attribute/TopicMessageType.java | 3 +-
.../common/attribute/TopicMessageTypeTest.java | 60 ++
2 files changed, 62 insertions(+), 1 deletion(-)
diff --git
a/common/src/main/java/org/apache/rocketmq/common/attribute/TopicMessageType.java
b/common/src/main/java/org/apache/rocketmq/common/attribute/TopicMessageType.java
index 9680acec74..5e581a34ee 100644
---
a/common/src/main/java/org/apache/rocketmq/common/attribute/TopicMessageType.java
+++
b/common/src/main/java/org/apache/rocketmq/common/attribute/TopicMessageType.java
@@ -50,7 +50,8 @@ public enum TopicMessageType {
return TopicMessageType.TRANSACTION;
} else if (messageProperty.get(MessageConst.PROPERTY_DELAY_TIME_LEVEL)
!= null
|| messageProperty.get(MessageConst.PROPERTY_TIMER_DELIVER_MS) !=
null
-|| messageProperty.get(MessageConst.PROPERTY_TIMER_DELAY_SEC) !=
null) {
+|| messageProperty.get(MessageConst.PROPERTY_TIMER_DELAY_SEC) !=
null
+|| messageProperty.get(MessageConst.PROPERTY_TIMER_DELAY_MS) !=
null) {
return TopicMessageType.DELAY;
} else if (messageProperty.get(MessageConst.PROPERTY_SHARDING_KEY) !=
null) {
return TopicMessageType.FIFO;
diff --git
a/common/src/test/java/org/apache/rocketmq/common/attribute/TopicMessageTypeTest.java
b/common/src/test/java/org/apache/rocketmq/common/attribute/TopicMessageTypeTest.java
new file mode 100644
index 00..67525ae808
--- /dev/null
+++
b/common/src/test/java/org/apache/rocketmq/common/attribute/TopicMessageTypeTest.java
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common.attribute;
+
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.rocketmq.common.message.MessageConst;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TopicMessageTypeTest {
+@Test
+public void testParseFromMessageProperty() {
+Map properties = new HashMap<>();
+
+// TRANSACTION
+properties.put(MessageConst.PROPERTY_TRANSACTION_PREPARED, "true");
+Assert.assertEquals(TopicMessageType.TRANSACTION,
TopicMessageType.parseFromMessageProperty(properties));
+
+// DELAY
+properties.clear();
+properties.put(MessageConst.PROPERTY_DELAY_TIME_LEVEL, "3");
+Assert.assertEquals(TopicMessageType.DELAY,
TopicMessageType.parseFromMessageProperty(properties));
+
+properties.clear();
+properties.put(MessageConst.PROPERTY_TIMER_DELIVER_MS,
System.currentTimeMillis() + 1 + "");
+Assert.assertEquals(TopicMessageType.DELAY,
TopicMessageType.parseFromMessageProperty(properties));
+
+properties.clear();
+properties.put(MessageConst.PROPERTY_TIMER_DELAY_SEC, 10 + "");
+Assert.assertEquals(TopicMessageType.DELAY,
TopicMessageType.parseFromMessageProperty(properties));
+
+properties.clear();
+properties.put(MessageConst.PROPERTY_TIMER_DELAY_MS, 1 + "");
+Assert.assertEquals(TopicMessageType.DELAY,
TopicMessageType.parseFromMessageProperty(properties));
+
+// FIFO
+properties.clear();
+properties.put(MessageConst.PROPERTY_SHARDING_KEY, "sharding_key");
+Assert.assertEquals(TopicMessageType.FIFO,
TopicMessageType.parseFromMessageProperty(properties));
+
+// NORMAL
+properties.clear();
+Assert.assertEquals(TopicMessageType.NORMAL,
TopicMessageType.parseFromMessageProperty(properties));
+}
+}
Re: [I] [Bug] Failed to send delay message by setting property TIMER_DELAY_MS when topic message type checking is enabled [rocketmq]
RongtongJin closed issue #8098: [Bug] Failed to send delay message by setting property TIMER_DELAY_MS when topic message type checking is enabled URL: https://github.com/apache/rocketmq/issues/8098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8098] Fix parsing delay message type from property [rocketmq]
RongtongJin merged PR #8099: URL: https://github.com/apache/rocketmq/pull/8099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8058] Support for upgrading metadata in json to rocksdb [rocketmq]
lizhimins commented on code in PR #8081:
URL: https://github.com/apache/rocketmq/pull/8081#discussion_r1591745079
##
common/src/main/java/org/apache/rocketmq/common/config/ConfigRocksDBStorage.java:
##
@@ -52,8 +47,23 @@
import org.rocksdb.WriteOptions;
import org.rocksdb.util.SizeUnit;
+import java.io.File;
+import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.List;
+
public class ConfigRocksDBStorage extends AbstractRocksDBStorage {
+private static final byte[] KV_DATA_VERSION_COLUMN_FAMILY_NAME =
"kvDataVersion".getBytes(StandardCharsets.UTF_8);
+private static final byte[] KV_DATA_VERSION_KEY =
"dataVersion".getBytes(StandardCharsets.UTF_8);
+protected ColumnFamilyHandle kvDataVersionFamilyHandle;
Review Comment:
为什么有两个版本
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8058] Support for upgrading metadata in json to rocksdb [rocketmq]
lizhimins commented on code in PR #8081:
URL: https://github.com/apache/rocketmq/pull/8081#discussion_r1591743621
##
broker/src/test/java/org/apache/rocketmq/broker/topic/RocksdbTopicConfigManagerTest.java:
##
@@ -370,6 +378,7 @@ private void supportAttributes(List
supportAttributes) {
}
private boolean notToBeExecuted() {
-return MixAll.isMac();
+//return MixAll.isMac();
Review Comment:
Suggest fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8058] Support for upgrading metadata in json to rocksdb [rocketmq]
lizhimins commented on PR #8081: URL: https://github.com/apache/rocketmq/pull/8081#issuecomment-2097311806 Suggest adding a feature switch to broker config -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user Willhow-Gao (triggered by RongtongJin). Head commit for run: d656b4c8ffa68377e5b6233a4a7eb66195a0fc14 / Willhow <65004897+willhow-...@users.noreply.github.com> Modify code style Report URL: https://github.com/apache/rocketmq/actions/runs/8966082608 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: a15088cbd33d665a457472e0f513507dc89d8a8d / cnScarb [ISSUE #8096] fix log placeholder Report URL: https://github.com/apache/rocketmq/actions/runs/8978421221 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 0f0324a7dd9b2e994aeb4a4f5c8631f8465daae5 / lizhimins <707364...@qq.com> [ISSUE #8076] Fix correct min cq offset when delete tiered storage CommitLog (#8082) Report URL: https://github.com/apache/rocketmq/actions/runs/8978444573 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8090]1.optimize isSetEqual method and add Unit tests; 2.fix a… [rocketmq]
codecov-commenter commented on PR #8091: URL: https://github.com/apache/rocketmq/pull/8091#issuecomment-2097288402 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8091?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `33.3%` with `4 lines` in your changes are missing coverage. Please review. > Project coverage is 42.84%. Comparing base [(`b39f65e`)](https://app.codecov.io/gh/apache/rocketmq/commit/b39f65ec08b9a0a72f9fdd5b826f2b1c88c9c496?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d656b4c`)](https://app.codecov.io/gh/apache/rocketmq/pull/8091?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 12 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8091?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/impl/consumer/DefaultLitePullConsumerImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/8091?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2Fconsumer%2FDefaultLitePullConsumerImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TGl0ZVB1bGxDb25zdW1lckltcGwuamF2YQ==) | 40.00% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8091?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...a/org/apache/rocketmq/client/impl/MQAdminImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/8091?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2FMQAdminImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUFkbWluSW1wbC5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8091?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8091 +/- ## = - Coverage 42.88% 42.84% -0.05% - Complexity 1034810350 +2 = Files 1270 1270 Lines 8867388680 +7 Branches 1139811397 -1 = - Hits 3802937994 -35 - Misses 4595045989 +39 - Partials4694 4697 +3 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8091?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: a15088cbd33d665a457472e0f513507dc89d8a8d / cnScarb [ISSUE #8096] fix log placeholder Report URL: https://github.com/apache/rocketmq/actions/runs/8978421222 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user Willhow-Gao (triggered by Willhow-Gao). Head commit for run: 0f0324a7dd9b2e994aeb4a4f5c8631f8465daae5 / lizhimins <707364...@qq.com> [ISSUE #8076] Fix correct min cq offset when delete tiered storage CommitLog (#8082) Report URL: https://github.com/apache/rocketmq/actions/runs/8978473412 With regards, GitHub Actions via GitBox
(rocketmq) branch develop updated: [ISSUE #8076] Fix correct min cq offset when delete tiered storage CommitLog (#8082)
This is an automated email from the ASF dual-hosted git repository.
lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 0f0324a7dd [ISSUE #8076] Fix correct min cq offset when delete tiered
storage CommitLog (#8082)
0f0324a7dd is described below
commit 0f0324a7dd9b2e994aeb4a4f5c8631f8465daae5
Author: lizhimins <707364...@qq.com>
AuthorDate: Tue May 7 09:52:48 2024 +0800
[ISSUE #8076] Fix correct min cq offset when delete tiered storage
CommitLog (#8082)
---
.../rocketmq/tieredstore/file/FlatCommitLogFile.java | 13 +
.../tieredstore/file/FlatCommitLogFileTest.java| 18 --
.../rocketmq/tieredstore/file/FlatFileStoreTest.java | 2 +-
3 files changed, 30 insertions(+), 3 deletions(-)
diff --git
a/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/file/FlatCommitLogFile.java
b/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/file/FlatCommitLogFile.java
index 8a319ed389..6ac0939571 100644
---
a/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/file/FlatCommitLogFile.java
+++
b/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/file/FlatCommitLogFile.java
@@ -60,4 +60,17 @@ public class FlatCommitLogFile extends FlatAppendFile {
return firstOffset.get();
});
}
+
+@Override
+public void destroyExpiredFile(long expireTimestamp) {
+long beforeOffset = this.getMinOffset();
+super.destroyExpiredFile(expireTimestamp);
+long afterOffset = this.getMinOffset();
+
+if (beforeOffset != afterOffset) {
+log.info("CommitLog min cq offset reset, filePath={}, offset={},
expireTimestamp={}, change={}-{}",
+filePath, firstOffset.get(), expireTimestamp, beforeOffset,
afterOffset);
+firstOffset.set(GET_OFFSET_ERROR);
+}
+}
}
diff --git
a/tieredstore/src/test/java/org/apache/rocketmq/tieredstore/file/FlatCommitLogFileTest.java
b/tieredstore/src/test/java/org/apache/rocketmq/tieredstore/file/FlatCommitLogFileTest.java
index 7e030d305e..1e912690b2 100644
---
a/tieredstore/src/test/java/org/apache/rocketmq/tieredstore/file/FlatCommitLogFileTest.java
+++
b/tieredstore/src/test/java/org/apache/rocketmq/tieredstore/file/FlatCommitLogFileTest.java
@@ -93,19 +93,33 @@ public class FlatCommitLogFileTest {
for (int i = 6; i < 9; i++) {
ByteBuffer byteBuffer =
MessageFormatUtilTest.buildMockedMessageBuffer();
byteBuffer.putLong(MessageFormatUtil.QUEUE_OFFSET_POSITION, i);
-Assert.assertEquals(AppendResult.SUCCESS,
flatFile.append(byteBuffer, 1L));
+Assert.assertEquals(AppendResult.SUCCESS,
flatFile.append(byteBuffer, i));
}
Assert.assertEquals(-1L,
flatFile.getMinOffsetFromFileAsync().join().longValue());
// append some messages
for (int i = 9; i < 30; i++) {
+if (i == 20) {
+flatFile.commitAsync().join();
+flatFile.rollingNewFile(flatFile.getAppendOffset());
+}
ByteBuffer byteBuffer =
MessageFormatUtilTest.buildMockedMessageBuffer();
byteBuffer.putLong(MessageFormatUtil.QUEUE_OFFSET_POSITION, i);
-Assert.assertEquals(AppendResult.SUCCESS,
flatFile.append(byteBuffer, 1L));
+Assert.assertEquals(AppendResult.SUCCESS,
flatFile.append(byteBuffer, i));
}
flatFile.commitAsync().join();
Assert.assertEquals(6L, flatFile.getMinOffsetFromFile());
Assert.assertEquals(6L,
flatFile.getMinOffsetFromFileAsync().join().longValue());
+
+// recalculate min offset here
+flatFile.destroyExpiredFile(20L);
+Assert.assertEquals(20L, flatFile.getMinOffsetFromFile());
+Assert.assertEquals(20L,
flatFile.getMinOffsetFromFileAsync().join().longValue());
+
+// clean expired file again
+flatFile.destroyExpiredFile(20L);
+Assert.assertEquals(20L, flatFile.getMinOffsetFromFile());
+Assert.assertEquals(20L,
flatFile.getMinOffsetFromFileAsync().join().longValue());
}
}
\ No newline at end of file
diff --git
a/tieredstore/src/test/java/org/apache/rocketmq/tieredstore/file/FlatFileStoreTest.java
b/tieredstore/src/test/java/org/apache/rocketmq/tieredstore/file/FlatFileStoreTest.java
index 79647932da..2a007af4e9 100644
---
a/tieredstore/src/test/java/org/apache/rocketmq/tieredstore/file/FlatFileStoreTest.java
+++
b/tieredstore/src/test/java/org/apache/rocketmq/tieredstore/file/FlatFileStoreTest.java
@@ -46,7 +46,7 @@ public class FlatFileStoreTest {
storeConfig = new MessageStoreConfig();
storeConfig.setStorePathRootDir(storePath);
storeConfig.setTieredBackendServiceProvider(PosixFileSegment.class.getName());
-storeConfig.setBrokerName(storeConfig.getBrokerName());
+
Re: [I] [Bug] Fix correct min cq offset when delete tiered storage CommitLog [rocketmq]
lizhimins closed issue #8076: [Bug] Fix correct min cq offset when delete tiered storage CommitLog URL: https://github.com/apache/rocketmq/issues/8076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8076] Fix correct min cq offset when delete tiered storage CommitLog [rocketmq]
lizhimins merged PR #8082: URL: https://github.com/apache/rocketmq/pull/8082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #8096] fix log placeholder
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new a15088cbd3 [ISSUE #8096] fix log placeholder
a15088cbd3 is described below
commit a15088cbd33d665a457472e0f513507dc89d8a8d
Author: cnScarb
AuthorDate: Tue May 7 09:49:43 2024 +0800
[ISSUE #8096] fix log placeholder
---
.../org/apache/rocketmq/client/impl/ClientRemotingProcessor.java | 4 ++--
.../java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java | 4 ++--
.../client/impl/consumer/ConsumeMessageConcurrentlyService.java | 8
.../client/impl/consumer/ConsumeMessageOrderlyService.java| 8
.../impl/consumer/ConsumeMessagePopConcurrentlyService.java | 4 ++--
.../client/impl/consumer/ConsumeMessagePopOrderlyService.java | 4 ++--
.../rocketmq/client/impl/producer/DefaultMQProducerImpl.java | 8
.../java/org/apache/rocketmq/common/stats/MomentStatsItem.java| 4 ++--
.../org/apache/rocketmq/controller/impl/DLedgerController.java| 2 +-
.../java/org/apache/rocketmq/test/client/rmq/RMQPopConsumer.java | 2 +-
.../main/java/org/apache/rocketmq/test/util/MQAdminTestUtils.java | 3 +--
test/src/test/java/org/apache/rocketmq/test/base/BaseConf.java| 3 +--
.../apache/rocketmq/test/client/consumer/pop/PopSubCheckIT.java | 2 +-
13 files changed, 27 insertions(+), 29 deletions(-)
diff --git
a/client/src/main/java/org/apache/rocketmq/client/impl/ClientRemotingProcessor.java
b/client/src/main/java/org/apache/rocketmq/client/impl/ClientRemotingProcessor.java
index 2f18c610c1..e46c651f92 100644
---
a/client/src/main/java/org/apache/rocketmq/client/impl/ClientRemotingProcessor.java
+++
b/client/src/main/java/org/apache/rocketmq/client/impl/ClientRemotingProcessor.java
@@ -288,8 +288,8 @@ public class ClientRemotingProcessor implements
NettyRequestProcessor {
}
} else {
String bornHost = replyMsg.getBornHostString();
-logger.warn(String.format("receive reply message, but not matched
any request, CorrelationId: %s , reply from host: %s",
-correlationId, bornHost));
+logger.warn("receive reply message, but not matched any request,
CorrelationId: {} , reply from host: {}",
+correlationId, bornHost);
}
}
}
diff --git
a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
index 0c58affa34..9b15279cb6 100644
--- a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
+++ b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
@@ -1168,7 +1168,7 @@ public class MQClientAPIImpl implements
NameServerUpdateCallback {
index = sortMap.get(queueIdKey).indexOf(offset);
msgQueueOffset =
msgOffsetInfo.get(queueIdKey).get(index);
if (msgQueueOffset != offset) {
-log.warn("Queue offset[%d] of msg is strange,
not equal to the stored in msg, %s",
+log.warn("Queue offset[{}] of msg is strange,
not equal to the stored in msg, {}",
msgQueueOffset, messageExt);
}
messageExt.getProperties().put(MessageConst.PROPERTY_POP_CK,
@@ -1181,7 +1181,7 @@ public class MQClientAPIImpl implements
NameServerUpdateCallback {
index =
sortMap.get(queueIdKey).indexOf(messageExt.getQueueOffset());
msgQueueOffset =
msgOffsetInfo.get(queueIdKey).get(index);
if (msgQueueOffset != messageExt.getQueueOffset())
{
-log.warn("Queue offset[%d] of msg is strange,
not equal to the stored in msg, %s", msgQueueOffset, messageExt);
+log.warn("Queue offset[{}] of msg is strange,
not equal to the stored in msg, {}", msgQueueOffset, messageExt);
}
messageExt.getProperties().put(MessageConst.PROPERTY_POP_CK,
ExtraInfoUtil.buildExtraInfo(startOffsetInfo.get(queueIdKey),
responseHeader.getPopTime(), responseHeader.getInvisibleTime(),
diff --git
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java
index ea6c8072b5..b151fefbbb 100644
---
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java
+++
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java
@@ -169,11
Re: [PR] [ISSUE #8096] fix log placeholder [rocketmq]
RongtongJin merged PR #8097: URL: https://github.com/apache/rocketmq/pull/8097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] wrong slf4j log place holder [rocketmq]
RongtongJin closed issue #8096: [Bug] wrong slf4j log place holder URL: https://github.com/apache/rocketmq/issues/8096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Snapshot Daily Release Automation" failed!
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: ac59c03e64f6ecefd637723283f5f96808def766 / rongtong [ISSUE #8095] Fix some flaky tests on Mac's workflow (#8083) Report URL: https://github.com/apache/rocketmq/actions/runs/8977617332 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user HScarb (triggered by HScarb). Head commit for run: 645c938a78bbff3fe15562a3a766a51349f0f6d5 / Scarb fix: fix log placeholder Report URL: https://github.com/apache/rocketmq/actions/runs/8968373547 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8090]1.optimize isSetEqual method and add Unit tests; 2.fix a… [rocketmq]
Willhow-Gao commented on code in PR #8091: URL: https://github.com/apache/rocketmq/pull/8091#discussion_r1591234961 ## client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImplTest.java: ## @@ -0,0 +1,85 @@ +package org.apache.rocketmq.client.impl.consumer; + +import org.apache.rocketmq.client.consumer.DefaultLitePullConsumer; +import org.apache.rocketmq.common.message.MessageQueue; +import org.junit.Assert; +import org.junit.BeforeClass; +import org.junit.Test; + +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import java.util.HashSet; +import java.util.Set; + +/** + * @author Willhow + * @since 2024/5/3 + */ Review Comment: > 作者信息需要删除 already removed. Also revised code style and added license comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8090]1.optimize isSetEqual method and add Unit tests; 2.fix a… [rocketmq]
Willhow-Gao commented on code in PR #8091: URL: https://github.com/apache/rocketmq/pull/8091#discussion_r1590491448 ## client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImplTest.java: ## @@ -0,0 +1,85 @@ +package org.apache.rocketmq.client.impl.consumer; + +import org.apache.rocketmq.client.consumer.DefaultLitePullConsumer; +import org.apache.rocketmq.common.message.MessageQueue; +import org.junit.Assert; +import org.junit.BeforeClass; +import org.junit.Test; + +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import java.util.HashSet; +import java.util.Set; + +/** + * @author Willhow + * @since 2024/5/3 + */ Review Comment: already removed.Idea generated it automatically, so I didn’t notice it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8055]remove unnecessary math.abs() method [rocketmq]
Willhow-Gao commented on code in PR #8056:
URL: https://github.com/apache/rocketmq/pull/8056#discussion_r1591230018
##
client/src/main/java/org/apache/rocketmq/client/impl/producer/TopicPublishInfo.java:
##
@@ -83,7 +83,7 @@ private MessageQueue selectOneMessageQueue(List
messageQueueList,
if (filter != null && filter.length != 0) {
for (int i = 0; i < messageQueueList.size(); i++) {
-int index = Math.abs(sendQueue.incrementAndGet() %
messageQueueList.size());
+int index = sendQueue.incrementAndGet() %
messageQueueList.size();
Review Comment:
> 这是一个线程local int，用完会再从0开始，不能去掉吧
在同一个类里，也看到了去掉math.abs的用法，应该是确定可以去掉吧，不然下面的方法就会出bug了
https://github.com/apache/rocketmq/assets/65004897/f409d145-5c4f-4d8b-9f87-f1ccfda09b98";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Enhancement] Implement Flow control in MQTT 5.0 [rocketmq-mqtt]
YxAc commented on issue #246: URL: https://github.com/apache/rocketmq-mqtt/issues/246#issuecomment-2096233300 I will work on this recently. By the doc of mqtt v5.0, the flow control just limit `publish qps`, not including `connection limit` and `publish bytes limit`, right? Do I need to provide a design document? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user HScarb (triggered by HScarb). Head commit for run: 645c938a78bbff3fe15562a3a766a51349f0f6d5 / Scarb fix: fix log placeholder Report URL: https://github.com/apache/rocketmq/actions/runs/8968373547 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user redlsz (triggered by redlsz). Head commit for run: b5f300d7f8328176f0f155f5e8d1f5bff6f88e91 / redlsz Fix parsing delay message type from property Report URL: https://github.com/apache/rocketmq/actions/runs/8968901331 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user HScarb (triggered by HScarb). Head commit for run: 645c938a78bbff3fe15562a3a766a51349f0f6d5 / Scarb fix: fix log placeholder Report URL: https://github.com/apache/rocketmq/actions/runs/8968373547 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: ac59c03e64f6ecefd637723283f5f96808def766 / rongtong [ISSUE #8095] Fix some flaky tests on Mac's workflow (#8083) Report URL: https://github.com/apache/rocketmq/actions/runs/8968551590 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user redlsz (triggered by redlsz). Head commit for run: ac59c03e64f6ecefd637723283f5f96808def766 / rongtong [ISSUE #8095] Fix some flaky tests on Mac's workflow (#8083) Report URL: https://github.com/apache/rocketmq/actions/runs/8968936531 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user redlsz (triggered by redlsz). Head commit for run: b5f300d7f8328176f0f155f5e8d1f5bff6f88e91 / redlsz Fix parsing delay message type from property Report URL: https://github.com/apache/rocketmq/actions/runs/8968901319 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user HScarb (triggered by HScarb). Head commit for run: 645c938a78bbff3fe15562a3a766a51349f0f6d5 / Scarb fix: fix log placeholder Report URL: https://github.com/apache/rocketmq/actions/runs/8968373547 With regards, GitHub Actions via GitBox
[PR] [ISSUE #8098] Fix parsing delay message type from property [rocketmq]
redlsz opened a new pull request, #8099: URL: https://github.com/apache/rocketmq/pull/8099 ### Which Issue(s) This PR Fixes Fixes #8098 ### Brief Description Parse as DELAY message if property TIMER_DELAY_MS present. ### How Did You Test This Change? UT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: ac59c03e64f6ecefd637723283f5f96808def766 / rongtong [ISSUE #8095] Fix some flaky tests on Mac's workflow (#8083) Report URL: https://github.com/apache/rocketmq/actions/runs/8968619398 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8096] fix log placeholder [rocketmq]
codecov-commenter commented on PR #8097: URL: https://github.com/apache/rocketmq/pull/8097#issuecomment-2095840218 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8097?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `5.6%` with `17 lines` in your changes are missing coverage. Please review. > Project coverage is 42.80%. Comparing base [(`af43a3e`)](https://app.codecov.io/gh/apache/rocketmq/commit/af43a3e71f2bdb4765294f7d6314b1428737849d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`645c938`)](https://app.codecov.io/gh/apache/rocketmq/pull/8097?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 1 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8097?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...mq/client/impl/producer/DefaultMQProducerImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/8097?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2Fproducer%2FDefaultMQProducerImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8097?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/8097?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2FMQClientAPIImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8097?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pl/consumer/ConsumeMessageConcurrentlyService.java](https://app.codecov.io/gh/apache/rocketmq/pull/8097?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2Fconsumer%2FConsumeMessageConcurrentlyService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZUNvbmN1cnJlbnRseVNlcnZpY2UuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8097?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../apache/rocketmq/common/stats/MomentStatsItem.java](https://app.codecov.io/gh/apache/rocketmq/pull/8097?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fcommon%2Fstats%2FMomentStatsItem.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8097?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../rocketmq/client/impl/ClientRemotingProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/8097?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2FClientRemotingProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9DbGllbnRSZW1vdGluZ1Byb2Nlc3Nvci5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8097?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://app.codecov.io/gh/apache/rocketmq/pull/8097?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2Fconsumer%2FConsumeMessageOrderlyService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2F
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user HScarb (triggered by HScarb). Head commit for run: af43a3e71f2bdb4765294f7d6314b1428737849d / Liu Shengzhong Fix exception when pop messages with multiple LMQ indexes (#7863) Report URL: https://github.com/apache/rocketmq/actions/runs/8968406258 With regards, GitHub Actions via GitBox
(rocketmq) branch develop updated: [ISSUE #8095] Fix some flaky tests on Mac's workflow (#8083)
This is an automated email from the ASF dual-hosted git repository.
lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new ac59c03e64 [ISSUE #8095] Fix some flaky tests on Mac's workflow (#8083)
ac59c03e64 is described below
commit ac59c03e64f6ecefd637723283f5f96808def766
Author: rongtong
AuthorDate: Mon May 6 19:47:37 2024 +0800
[ISSUE #8095] Fix some flaky tests on Mac's workflow (#8083)
---
BUILD.bazel | 1 +
WORKSPACE | 1 +
broker/BUILD.bazel | 4
client/BUILD.bazel | 3 ++-
.../client/consumer/DefaultLitePullConsumerTest.java| 6 +-
.../apache/rocketmq/client/impl/MQClientAPIImplTest.java| 4 ++--
pom.xml | 13 +
.../service/mqclient/ProxyClientRemotingProcessorTest.java | 7 ++-
.../service/receipt/DefaultReceiptHandleManagerTest.java| 2 +-
9 files changed, 35 insertions(+), 6 deletions(-)
diff --git a/BUILD.bazel b/BUILD.bazel
index 358527c314..ba33a9e612 100644
--- a/BUILD.bazel
+++ b/BUILD.bazel
@@ -44,5 +44,6 @@ java_library(
"@maven//:org_awaitility_awaitility",
"@maven//:org_openjdk_jmh_jmh_core",
"@maven//:org_openjdk_jmh_jmh_generator_annprocess",
+"@maven//:org_mockito_mockito_junit_jupiter",
],
)
diff --git a/WORKSPACE b/WORKSPACE
index 8230edef5c..e1f7743302 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -111,6 +111,7 @@ maven_install(
"com.alipay.sofa:jraft-core:1.3.14",
"com.alipay.sofa:hessian:3.3.6",
"io.netty:netty-tcnative-boringssl-static:2.0.48.Final",
+"org.mockito:mockito-junit-jupiter:4.11.0",
],
fetch_sources = True,
repositories = [
diff --git a/broker/BUILD.bazel b/broker/BUILD.bazel
index b2ee2549bc..785b765774 100644
--- a/broker/BUILD.bazel
+++ b/broker/BUILD.bazel
@@ -95,6 +95,10 @@ java_library(
GenTestRules(
name = "GeneratedTestRules",
test_files = glob(["src/test/java/**/*Test.java"]),
+exclude_tests = [
+# These tests are extremely slow and flaky, exclude them before
they are properly fixed.
+
"src/test/java/org/apache/rocketmq/broker/controller/ReplicasManagerRegisterTest",
+],
deps = [
":tests",
],
diff --git a/client/BUILD.bazel b/client/BUILD.bazel
index e491cfcef0..9b6fbc298c 100644
--- a/client/BUILD.bazel
+++ b/client/BUILD.bazel
@@ -49,7 +49,8 @@ java_library(
"@maven//:io_netty_netty_all",
"@maven//:io_opentracing_opentracing_api",
"@maven//:io_opentracing_opentracing_mock",
-"@maven//:org_awaitility_awaitility",
+"@maven//:org_awaitility_awaitility",
+"@maven//:org_mockito_mockito_junit_jupiter",
],
resources = glob(["src/test/resources/certs/*.pem"]) +
glob(["src/test/resources/certs/*.key"])
)
diff --git
a/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumerTest.java
b/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumerTest.java
index 24e39f5668..65237bc8f7 100644
---
a/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumerTest.java
+++
b/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumerTest.java
@@ -63,6 +63,8 @@ import org.mockito.Mock;
import org.mockito.Spy;
import org.mockito.invocation.InvocationOnMock;
import org.mockito.junit.MockitoJUnitRunner;
+import org.mockito.quality.Strictness;
+import org.mockito.junit.jupiter.MockitoSettings;
import org.mockito.stubbing.Answer;
import static org.assertj.core.api.Assertions.assertThat;
@@ -74,11 +76,13 @@ import static org.mockito.ArgumentMatchers.anyBoolean;
import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.ArgumentMatchers.nullable;
+import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.when;
@RunWith(MockitoJUnitRunner.class)
+@MockitoSettings(strictness = Strictness.LENIENT)
public class DefaultLitePullConsumerTest {
@Spy
private MQClientInstance mQClientFactory =
MQClientManager.getInstance().getOrCreateMQClientInstance(new ClientConfig());
@@ -743,7 +747,7 @@ public class DefaultLitePullConsumerTest {
}
});
-when(mQClientFactory.findBrokerAddressInSubscribe(anyString(),
anyLong(), anyBoolean())).thenReturn(new FindBrokerResult("127.0.0.1:10911",
false));
+doAnswer(x -> new FindBrokerResult("127.0.0.1:10911",
false)).when(mQClientFactory).findBrokerAddressInSubscribe(a
Re: [I] [Enhancement] Some tests often fail on Mac's pipeline [rocketmq]
lizhimins closed issue #8095: [Enhancement] Some tests often fail on Mac's pipeline URL: https://github.com/apache/rocketmq/issues/8095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8095] Fix some flaky tests on Mac's workflow [rocketmq]
lizhimins merged PR #8083: URL: https://github.com/apache/rocketmq/pull/8083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8095] Fix some flaky tests on Mac's workflow [rocketmq]
lizhimins commented on PR #8083: URL: https://github.com/apache/rocketmq/pull/8083#issuecomment-2095821301 Temporarily ignore some unstable use cases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] Failed to send delay message by setting property TIMER_DELAY_MS when topic message type checking is enabled [rocketmq]
redlsz opened a new issue, #8098: URL: https://github.com/apache/rocketmq/issues/8098 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment all ### RocketMQ version develop ### JDK Version 1.8 ### Describe the Bug rocketmq-spring https://github.com/apache/rocketmq/assets/103550934/8d4047e4-ce2b-4f49-8a7e-787a34f9bf21";> https://github.com/apache/rocketmq/assets/103550934/2f042fcf-fa0a-4b90-8c70-4083bf205c60";> topics.json https://github.com/apache/rocketmq/assets/103550934/59d61c2b-6e4c-498b-99e9-44e8994dde08";> ### Steps to Reproduce 1. Boot a producer with rocketmq-spring-boot-starter (version 2.2.3) 2. Send delay message by calling rocketMQTemplate.syncSendDelayTimeMills ### What Did You Expect to See? Sent successfully ### What Did You See Instead? Sending failure. "TopicMessageType validate failed, the expected type is DELAY, but actual type is NORMAL" ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #8096] fix log placeholder [rocketmq]
HScarb opened a new pull request, #8097:
URL: https://github.com/apache/rocketmq/pull/8097
### Which Issue(s) This PR Fixes
Fixes #8096
### Brief Description
use `{}` to replace `%s` `%d`
### How Did You Test This Change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] [Bug] wrong slf4j log place holder [rocketmq]
HScarb opened a new issue, #8096: URL: https://github.com/apache/rocketmq/issues/8096 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment Windows 10 ### RocketMQ version develop ### JDK Version JDK8 ### Describe the Bug Some of the code uses `%s`, `%d` as a log placeholder ### Steps to Reproduce Trigger error logs ### What Did You Expect to See? Log output correct ### What Did You See Instead? Log output `%s`, `%d` ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] meta start failed [rocketmq-mqtt]
tongJerry commented on issue #262: URL: https://github.com/apache/rocketmq-mqtt/issues/262#issuecomment-2095785466  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 2f59e3b0a808cb8c4c7832da2f94db99ad8eec65 / RongtongJin skip some flaky tests Report URL: https://github.com/apache/rocketmq/actions/runs/8967196597 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8076] Fix correct min cq offset when delete tiered storage CommitLog [rocketmq]
lollipopjin commented on code in PR #8082:
URL: https://github.com/apache/rocketmq/pull/8082#discussion_r1590828340
##
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/file/FlatCommitLogFile.java:
##
@@ -60,4 +60,17 @@ public CompletableFuture getMinOffsetFromFileAsync() {
return firstOffset.get();
});
}
+
+@Override
+public void destroyExpiredFile(long expireTimestamp) {
+long beforeOffset = this.getMinOffset();
+super.destroyExpiredFile(expireTimestamp);
Review Comment:
Add logs for easier problem troubleshooting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 2f59e3b0a808cb8c4c7832da2f94db99ad8eec65 / RongtongJin skip some flaky tests Report URL: https://github.com/apache/rocketmq/actions/runs/8967196593 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: af43a3e71f2bdb4765294f7d6314b1428737849d / Liu Shengzhong Fix exception when pop messages with multiple LMQ indexes (#7863) Report URL: https://github.com/apache/rocketmq/actions/runs/8967222463 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 44d361636dd9d0834f07d64483372843635e2c19 / RongtongJin Fix some flaky tests Report URL: https://github.com/apache/rocketmq/actions/runs/8965827084 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "License checker" is working again!
The GitHub Actions job "License checker" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 2f59e3b0a808cb8c4c7832da2f94db99ad8eec65 / RongtongJin skip some flaky tests Report URL: https://github.com/apache/rocketmq/actions/runs/8967196665 With regards, GitHub Actions via GitBox
[PR] refactor: fix PushRetryStrategyEnum#parse(String), and some code style optimization of module common [rocketmq-eventbridge]
higlowx opened a new pull request, #171: URL: https://github.com/apache/rocketmq-eventbridge/pull/171 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8058] Support for upgrading metadata in json to rocksdb [rocketmq]
RongtongJin commented on code in PR #8081: URL: https://github.com/apache/rocketmq/pull/8081#discussion_r1590770277 ## tools/src/main/java/org/apache/rocketmq/tools/command/metadata/RocksDBConfigToJsonCommand.java: ## Review Comment: I wonder know why this command was deleted? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user kaiyaok2 (triggered by RongtongJin). Head commit for run: 2b89f2de53e53a073a47ed53743d2a0448d9328a / Kaiyao Ke fixed non-idempotent test Report URL: https://github.com/apache/rocketmq/actions/runs/8964476844 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 44d361636dd9d0834f07d64483372843635e2c19 / RongtongJin Fix some flaky tests Report URL: https://github.com/apache/rocketmq/actions/runs/8965827084 With regards, GitHub Actions via GitBox
(rocketmq-site) branch new-official-website updated: Update 01RocketMQ Connect Overview.md (#639)
This is an automated email from the ASF dual-hosted git repository. jinrongtong pushed a commit to branch new-official-website in repository https://gitbox.apache.org/repos/asf/rocketmq-site.git The following commit(s) were added to refs/heads/new-official-website by this push: new 2e875f6547 Update 01RocketMQ Connect Overview.md (#639) 2e875f6547 is described below commit 2e875f654713694c6d39482b22231f3f8964f1b0 Author: 小陈 AuthorDate: Mon May 6 16:36:39 2024 +0800 Update 01RocketMQ Connect Overview.md (#639) --- versioned_docs/version-5.0/10-connect/01RocketMQ Connect Overview.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/versioned_docs/version-5.0/10-connect/01RocketMQ Connect Overview.md b/versioned_docs/version-5.0/10-connect/01RocketMQ Connect Overview.md index 119443b881..68373e7293 100644 --- a/versioned_docs/version-5.0/10-connect/01RocketMQ Connect Overview.md +++ b/versioned_docs/version-5.0/10-connect/01RocketMQ Connect Overview.md @@ -20,7 +20,7 @@ RocketMQ Connect是一个独立的的分布式，可伸缩，容错的系统， # CDC -CDC作为ETL模式之一，可以近乎实时的捕获增量数据库INSERT、UPDATE，DELETE变化，RocketMQ Connect流试数据传输，具备高可用，低延时等特性，通过Connector很容易实现CDC。 +CDC作为ETL模式之一，可以近乎实时的捕获增量数据库INSERT、UPDATE，DELETE变化，RocketMQ Connect流式数据传输，具备高可用，低延时等特性，通过Connector很容易实现CDC。 ### Connector 部署 @@ -28,7 +28,7 @@ CDC作为ETL模式之一，可以近乎实时的捕获增量数据库INSERT、UP  -一个Connector也可以同时运行多个任务，提高Connector的并行度，例如下图所示的Hudi Sink Connector有2个任务，每个任务处理不同的分片数据，从而Connector的并行度，进而提高处理性能。 +一个Connector也可以同时运行多个任务，提高Connector的并行度，例如下图所示的Hudi Sink Connector有2个任务，每个任务处理不同的分片数据，从而提高Connector的并行度，进而提高处理性能。 
Re: [PR] Fix A Typo in 01RocketMQ Connect Overview.md [rocketmq-site]
RongtongJin merged PR #639: URL: https://github.com/apache/rocketmq-site/pull/639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user Willhow-Gao (triggered by RongtongJin). Head commit for run: 015559e9c071cedbbda3775cf6d3d8bb8d009fa0 / Willhow <65004897+willhow-...@users.noreply.github.com> remove author message Report URL: https://github.com/apache/rocketmq/actions/runs/8963349576 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user kaiyaok2 (triggered by kaiyaok2). Head commit for run: af43a3e71f2bdb4765294f7d6314b1428737849d / Liu Shengzhong Fix exception when pop messages with multiple LMQ indexes (#7863) Report URL: https://github.com/apache/rocketmq/actions/runs/8965953786 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user kaiyaok2 (triggered by RongtongJin). Head commit for run: 2b89f2de53e53a073a47ed53743d2a0448d9328a / Kaiyao Ke fixed non-idempotent test Report URL: https://github.com/apache/rocketmq/actions/runs/8964476843 With regards, GitHub Actions via GitBox
[PR] [ISSUE #266]: add connections_size metric [rocketmq-mqtt]
yx9o opened a new pull request, #267: URL: https://github.com/apache/rocketmq-mqtt/pull/267 add connections_size metric -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Enhancement] Add connection size indicator in metrics [rocketmq-mqtt]
yx9o opened a new issue, #266: URL: https://github.com/apache/rocketmq-mqtt/issues/266 Hi, community, there is no metric to count the number of client connections in the current metrics. In actual applications, I found that this is a key metric. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: af43a3e71f2bdb4765294f7d6314b1428737849d / Liu Shengzhong Fix exception when pop messages with multiple LMQ indexes (#7863) Report URL: https://github.com/apache/rocketmq/actions/runs/8965849277 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user Willhow-Gao (triggered by RongtongJin). Head commit for run: 015559e9c071cedbbda3775cf6d3d8bb8d009fa0 / Willhow <65004897+willhow-...@users.noreply.github.com> remove author message Report URL: https://github.com/apache/rocketmq/actions/runs/8963349572 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" is working again!
The GitHub Actions job "PR-CI" on rocketmq.git has succeeded. Run started by GitHub user kaiyaok2 (triggered by RongtongJin). Head commit for run: 2b89f2de53e53a073a47ed53743d2a0448d9328a / Kaiyao Ke fixed non-idempotent test Report URL: https://github.com/apache/rocketmq/actions/runs/8964476848 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "License checker" failed!
The GitHub Actions job "License checker" on rocketmq.git has failed. Run started by GitHub user Willhow-Gao (triggered by RongtongJin). Head commit for run: 015559e9c071cedbbda3775cf6d3d8bb8d009fa0 / Willhow <65004897+willhow-...@users.noreply.github.com> remove author message Report URL: https://github.com/apache/rocketmq/actions/runs/8963349577 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user Willhow-Gao (triggered by RongtongJin). Head commit for run: 015559e9c071cedbbda3775cf6d3d8bb8d009fa0 / Willhow <65004897+willhow-...@users.noreply.github.com> remove author message Report URL: https://github.com/apache/rocketmq/actions/runs/8963349575 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user Willhow-Gao (triggered by Willhow-Gao). Head commit for run: af43a3e71f2bdb4765294f7d6314b1428737849d / Liu Shengzhong Fix exception when pop messages with multiple LMQ indexes (#7863) Report URL: https://github.com/apache/rocketmq/actions/runs/8965943714 With regards, GitHub Actions via GitBox
[I] [Enhancement] Some tests often fail on Mac's pipeline [rocketmq]
RongtongJin opened a new issue, #8095: URL: https://github.com/apache/rocketmq/issues/8095 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary Some tests often fail on Mac's pipeline ### Motivation Some tests often fail on Mac's pipeline ### Describe the Solution You'd Like Fix some flaky tests ### Describe Alternatives You've Considered No ### Additional Context No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 44d361636dd9d0834f07d64483372843635e2c19 / RongtongJin Fix some flaky tests Report URL: https://github.com/apache/rocketmq/actions/runs/8965827085 With regards, GitHub Actions via GitBox
