Re: [PR] [ISSUE #8061] Fix npe in netty remoting client [rocketmq]
fujian-zfj commented on PR #8064: URL: https://github.com/apache/rocketmq/pull/8064#issuecomment-2104026273 > Hi @fujian-zfj you need to merge the develop branch to include the latest unit test fixes. OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 159a603219e363e5f991a0c85213f6dc13f0a9be / yuz10 <845238...@qq.com> [ISSUE #5923] Fix tiered store README.md error (#8115) Report URL: https://github.com/apache/rocketmq/actions/runs/9028143319 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user fujian-zfj (triggered by fujian-zfj). Head commit for run: 159a603219e363e5f991a0c85213f6dc13f0a9be / yuz10 <845238...@qq.com> [ISSUE #5923] Fix tiered store README.md error (#8115) Report URL: https://github.com/apache/rocketmq/actions/runs/9028657864 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8061] Fix npe in netty remoting client [rocketmq]
codecov-commenter commented on PR #8064: URL: https://github.com/apache/rocketmq/pull/8064#issuecomment-2104083836 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8064?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 42.88%. Comparing base [(`159a603`)](https://app.codecov.io/gh/apache/rocketmq/commit/159a603219e363e5f991a0c85213f6dc13f0a9be?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`2e0bae0`)](https://app.codecov.io/gh/apache/rocketmq/pull/8064?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8064 +/- ## = - Coverage 42.91% 42.88% -0.04% + Complexity 1038210374 -8 = Files 1270 1270 Lines 8869488694 Branches 1140111401 = - Hits 3806638035 -31 - Misses 4593545957 +22 - Partials4693 4702 +9 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8064?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] MQTT在jdk11环境无法启动 [rocketmq-mqtt]
ChangingFond commented on issue #273: URL: https://github.com/apache/rocketmq-mqtt/issues/273#issuecomment-2104105548 JDK 11 is not supported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8058] Support for upgrading metadata in json to rocksdb [rocketmq]
LetLetMe closed pull request #8081: [ISSUE #8058] Support for upgrading metadata in json to rocksdb URL: https://github.com/apache/rocketmq/pull/8081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #650] Fix url and typo [rocketmq-spring]
hakusai22 opened a new pull request, #651: URL: https://github.com/apache/rocketmq-spring/pull/651 ## What is the purpose of the change close [https://github.com/apache/rocketmq-spring/issues/650](https://github.com/apache/rocketmq-spring/issues/650) ## Brief changelog Fix url 404 and typo ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [ ] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-spring): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq-spring.git has failed. Run started by GitHub user hakusai22 (triggered by RongtongJin). Head commit for run: 344ca487bf7a51ca3cbfb3773873ae36190d1d52 / yinpeng [ISSUE #650] Fix url and typo Report URL: https://github.com/apache/rocketmq-spring/actions/runs/9029469680 With regards, GitHub Actions via GitBox
[GH] (rocketmq-spring): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq-spring.git has failed. Run started by GitHub user hakusai22 (triggered by RongtongJin). Head commit for run: 344ca487bf7a51ca3cbfb3773873ae36190d1d52 / yinpeng [ISSUE #650] Fix url and typo Report URL: https://github.com/apache/rocketmq-spring/actions/runs/9029469680 With regards, GitHub Actions via GitBox
Re: [I] MQTT在jdk11环境无法启动 [rocketmq-mqtt]
DongyuanPan commented on issue #273: URL: https://github.com/apache/rocketmq-mqtt/issues/273#issuecomment-2104219793 > 现在的mqtt broker在jdk11的环境下无法启动，现在是没有支持JDK8以后的版本吗？ What exactly went wrong? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] MQTT在jdk11环境无法启动 [rocketmq-mqtt]
DongyuanPan commented on issue #273: URL: https://github.com/apache/rocketmq-mqtt/issues/273#issuecomment-2104219965 > 现在的mqtt broker在jdk11的环境下无法启动，现在是没有支持JDK8以后的版本吗？ What exactly went wrong? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) [rocketmq]
LetLetMe opened a new pull request, #8116: URL: https://github.com/apache/rocketmq/pull/8116 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 8ad587c9d9f3a6d7ed7f0dea81153d115ce5710b / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9030025793 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 159a603219e363e5f991a0c85213f6dc13f0a9be / yuz10 <845238...@qq.com> [ISSUE #5923] Fix tiered store README.md error (#8115) Report URL: https://github.com/apache/rocketmq/actions/runs/9030056910 With regards, GitHub Actions via GitBox
[I] Develop branch startup exception [rocketmq-mqtt]
yx9o opened a new issue, #274: URL: https://github.com/apache/rocketmq-mqtt/issues/274 Hi, community, I got an unexpected exception when running the development branch in the ide. Exception: https://github.com/apache/rocketmq-mqtt/assets/12792261/c4ef2dec-abd2-4ad7-ba29-590918cf7ce2";> Steps to reproduce: - Start a new RocketMQ-ns - Start a new RocketMQ-broker - Start RocketMQ-mqtt Cause analysis: During initialization in `MetaPersistManagerSample`, the information of the consumer group `CID_RMQ_SYS_mqtt_event` will be dynamically obtained. At this time, the broker will return `CODE: 206 DESC: the consumer group[CID_RMQ_SYS_mqtt_event] not online BROKER:`. Here, if code!=200 is judged, an `MQBrokerException` exception will be thrown. The first execution of `refreshMeta()` in init() does not catch the exception, so the startup will fail. https://github.com/apache/rocketmq-mqtt/assets/12792261/555b6e93-220b-4f10-ad6b-58ba38c12df8";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 8ad587c9d9f3a6d7ed7f0dea81153d115ce5710b / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9030025787 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 8ad587c9d9f3a6d7ed7f0dea81153d115ce5710b / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9030025783 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 62f90d2b661a4960ab7e33a08837d08bc17a80ac / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9031467381 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 159a603219e363e5f991a0c85213f6dc13f0a9be / yuz10 <845238...@qq.com> [ISSUE #5923] Fix tiered store README.md error (#8115) Report URL: https://github.com/apache/rocketmq/actions/runs/9031482830 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 62f90d2b661a4960ab7e33a08837d08bc17a80ac / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9031467405 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 62f90d2b661a4960ab7e33a08837d08bc17a80ac / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9031467392 With regards, GitHub Actions via GitBox
[I] 能否release一个 支持mac m3 的 构建后的包 非常感谢 [rocketmq-client-cpp]
Yifan200809 opened a new issue, #471: URL: https://github.com/apache/rocketmq-client-cpp/issues/471 Mac M3在安装librocketmq后遇到报错 使用wget https://github.com/apache/rocketmq-client-cpp/releases/download/2.0.0/rocketmq-client-cpp-2.0.0-bin-release.darwin.tar.gz安装后报错： OSError: dlopen(/usr/local/lib/librocketmq.dylib, 0x0006): tried: '/usr/local/lib/librocketmq.dylib' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64')), '/System/Volumes/Preboot/Cryptexes/OS/usr/local/lib/librocketmq.dylib' (no such file), '/usr/local/lib/librocketmq.dylib' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64')) 使用RocketMQ Client CPP安装包[rocketmq-client-cpp-2.2.0-source-release.tar.gz]编译闪退，更换boost版本均报错 https://github.com/apache/rocketmq-client-cpp/assets/117885306/c0caf545-50b3-4f13-bd17-fd03e2407712";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 62f90d2b661a4960ab7e33a08837d08bc17a80ac / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9031467377 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #266]: add metrics for topic dimension read and write msg size [rocketmq-mqtt]
lizhanhui merged PR #271: URL: https://github.com/apache/rocketmq-mqtt/pull/271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-mqtt) branch develop updated: feat: add metrics for topic dimension read and write msg size (#271)
This is an automated email from the ASF dual-hosted git repository.
lizhanhui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git
The following commit(s) were added to refs/heads/develop by this push:
new 95fbf79 feat: add metrics for topic dimension read and write msg size
(#271)
95fbf79 is described below
commit 95fbf7936a53444a135ac8ecc45742bde62e86c6
Author: yx9o
AuthorDate: Fri May 10 20:58:57 2024 +0800
feat: add metrics for topic dimension read and write msg size (#271)
---
.../rocketmq/mqtt/cs/session/loop/QueueCache.java | 35 +++---
.../mqtt/ds/store/LmqQueueStoreManager.java| 14 +
.../ds/upstream/processor/PublishProcessor.java| 11 ++-
.../exporter/collector/MqttMetricsCollector.java | 4 +++
.../mqtt/exporter/collector/MqttMetricsInfo.java | 4 ++-
5 files changed, 56 insertions(+), 12 deletions(-)
diff --git
a/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/session/loop/QueueCache.java
b/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/session/loop/QueueCache.java
index 771d09f..52f91b8 100644
---
a/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/session/loop/QueueCache.java
+++
b/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/session/loop/QueueCache.java
@@ -33,6 +33,7 @@ import org.apache.rocketmq.mqtt.common.util.StatUtil;
import org.apache.rocketmq.mqtt.cs.config.ConnectConf;
import org.apache.rocketmq.mqtt.cs.session.Session;
import org.apache.rocketmq.mqtt.exporter.collector.MqttMetricsCollector;
+import org.apache.rocketmq.mqtt.exporter.exception.PrometheusException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.stereotype.Component;
@@ -52,6 +53,7 @@ import java.util.concurrent.ScheduledThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
+import java.util.stream.Collectors;
import static org.apache.rocketmq.mqtt.cs.session.loop.PullResultStatus.DONE;
import static org.apache.rocketmq.mqtt.cs.session.loop.PullResultStatus.LATER;
@@ -183,7 +185,7 @@ public class QueueCache {
CompletableFuture
callBackResult) {
if (subscription.isP2p() || subscription.isRetry()) {
StatUtil.addPv("NotPullCache", 1);
-collectorPullCacheStatus("NotPullCache");
+collectorPullCacheStatus("NotPullCache", null);
CompletableFuture pullResult =
lmqQueueStore.pullMessage(toFirstTopic(subscription), queue, queueOffset,
count);
callbackResult(pullResult, callBackResult);
return DONE;
@@ -198,7 +200,7 @@ public class QueueCache {
CacheEntry cacheEntry = cache.getIfPresent(queue);
if (cacheEntry == null) {
StatUtil.addPv("NoPullCache", 1);
-collectorPullCacheStatus("NotPullCache");
+collectorPullCacheStatus("NotPullCache", null);
CompletableFuture pullResult =
lmqQueueStore.pullMessage(toFirstTopic(subscription), queue, queueOffset,
count);
callbackResult(pullResult, callBackResult);
return DONE;
@@ -206,7 +208,7 @@ public class QueueCache {
if (cacheEntry.loading.get()) {
if (System.currentTimeMillis() - cacheEntry.startLoadingT > 1000) {
StatUtil.addPv("LoadPullCacheTimeout", 1);
-collectorPullCacheStatus("LoadPullCacheTimeout");
+collectorPullCacheStatus("LoadPullCacheTimeout", null);
CompletableFuture pullResult =
lmqQueueStore.pullMessage(toFirstTopic(subscription), queue, queueOffset,
count);
callbackResult(pullResult, callBackResult);
return DONE;
@@ -217,12 +219,12 @@ public class QueueCache {
List cacheMsgList = cacheEntry.messageList;
if (cacheMsgList.isEmpty()) {
if (loadEvent.get(queue) != null) {
-collectorPullCacheStatus("EmptyPullCacheLATER");
+collectorPullCacheStatus("EmptyPullCacheLATER", cacheMsgList);
StatUtil.addPv("EmptyPullCacheLATER", 1);
return LATER;
}
StatUtil.addPv("EmptyPullCache", 1);
-collectorPullCacheStatus("EmptyPullCache");
+collectorPullCacheStatus("EmptyPullCache", cacheMsgList);
CompletableFuture pullResult =
lmqQueueStore.pullMessage(toFirstTopic(subscription), queue, queueOffset,
count);
callbackResult(pullResult, callBackResult);
return DONE;
@@ -230,7 +232,7 @@ public class QueueCache {
if (queueOffset.getOffset() < cacheMsgList.get(0).getOffset()) {
StatUtil.addPv("OutPullCache", 1);
-collectorPullCacheStatus("OutPullCache");
+collectorPullCacheStatus("OutPullCache", cacheMsgList);
CompletableFuture pullResult
Re: [PR] feat: add experimental support for QUIC transport [rocketmq-mqtt]
lizhanhui commented on PR #260: URL: https://github.com/apache/rocketmq-mqtt/pull/260#issuecomment-2104569198 > it's better to create pr to develop branch Okay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature Request] Add `imagePullSecrets` to service account in operator helm chart [rocketmq-operator]
DavidSonoda commented on issue #221: URL: https://github.com/apache/rocketmq-operator/issues/221#issuecomment-2104584454 Any updates on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: add experimental support for QUIC transport [rocketmq-mqtt]
lizhanhui merged PR #260: URL: https://github.com/apache/rocketmq-mqtt/pull/260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-mqtt) 01/05: feat: use openssl SSL provider to create TLS/SSL engine, adding netty-tcnative to cs module
This is an automated email from the ASF dual-hosted git repository.
lizhanhui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git
commit 6466344c9171d17908bd3801dae2bd24430bd5f9
Author: Li Zhanhui
AuthorDate: Thu Apr 11 23:56:22 2024 +0800
feat: use openssl SSL provider to create TLS/SSL engine, adding
netty-tcnative to cs module
Signed-off-by: Li Zhanhui
---
mqtt-cs/pom.xml | 6 +-
.../java/org/apache/rocketmq/mqtt/cs/protocol/ssl/SslFactory.java | 8 +++-
pom.xml | 7 ---
3 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/mqtt-cs/pom.xml b/mqtt-cs/pom.xml
index e3924a1..c1c4521 100644
--- a/mqtt-cs/pom.xml
+++ b/mqtt-cs/pom.xml
@@ -30,6 +30,10 @@
io.netty
netty-all
+
+io.netty
+netty-tcnative-boringssl-static
+
org.slf4j
slf4j-api
@@ -78,4 +82,4 @@
-
\ No newline at end of file
+
diff --git
a/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/ssl/SslFactory.java
b/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/ssl/SslFactory.java
index d2cfbd8..b9cc770 100644
---
a/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/ssl/SslFactory.java
+++
b/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/ssl/SslFactory.java
@@ -56,6 +56,12 @@ public class SslFactory {
return;
}
+SslProvider sslProvider = OpenSsl.isAvailable() ? SslProvider.OPENSSL
: SslProvider.JDK;
+if (OpenSsl.isAvailable()) {
+LOG.info("OpenSSL is available");
+} else {
+LOG.warn("OpenSSL is NOT available, falling back to JDK
SslEngine");
+}
try {
File sslCertFile = new File(connectConf.getSslServerCertFile());
File sslKeyFile = new File(connectConf.getSslServerKeyFile());
@@ -64,7 +70,7 @@ public class SslFactory {
SslContextBuilder contextBuilder =
SslContextBuilder.forServer(sslCertFile, sslKeyFile,
StringUtils.isBlank(password) ? null : password);
contextBuilder.clientAuth(ClientAuth.OPTIONAL);
-contextBuilder.sslProvider(OpenSsl.isAvailable() ?
SslProvider.OPENSSL : SslProvider.JDK);
+contextBuilder.sslProvider(sslProvider);
if (connectConf.isNeedClientAuth()) {
LOG.info("client tls authentication is required.");
contextBuilder.clientAuth(ClientAuth.REQUIRE);
diff --git a/pom.xml b/pom.xml
index c99cc65..6826ab6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -47,7 +47,8 @@
1.3.8
32.0.0-jre
1.3.11
-
+4.1.43.Final
+2.0.26.Final
@@ -95,12 +96,12 @@
io.netty
netty-all
-4.1.43.Final
+${netty.version}
io.netty
netty-tcnative-boringssl-static
-2.0.26.Final
+${netty.tcnative.version}
org.springframework
(rocketmq-mqtt) 03/05: feat: support WebSocket over TLS transport
This is an automated email from the ASF dual-hosted git repository.
lizhanhui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git
commit 0643cd3a7ee95bbd32cb9f7320c08cbe5429360f
Author: Li Zhanhui
AuthorDate: Tue Apr 30 11:40:50 2024 +0800
feat: support WebSocket over TLS transport
Signed-off-by: Li Zhanhui
---
.../mqtt/cs/channel/AdaptiveTlsHandler.java| 93 ++
.../rocketmq/mqtt/cs/protocol/ssl/SslFactory.java | 4 +
.../rocketmq/mqtt/cs/starter/MqttServer.java | 20 +
3 files changed, 117 insertions(+)
diff --git
a/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/channel/AdaptiveTlsHandler.java
b/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/channel/AdaptiveTlsHandler.java
new file mode 100644
index 000..d2271ac
--- /dev/null
+++
b/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/channel/AdaptiveTlsHandler.java
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.mqtt.cs.channel;
+
+import io.netty.buffer.ByteBuf;
+import io.netty.channel.ChannelHandler;
+import io.netty.channel.ChannelHandlerContext;
+import io.netty.channel.SimpleChannelInboundHandler;
+import io.netty.handler.ssl.SslHandler;
+import java.util.NoSuchElementException;
+import org.apache.rocketmq.mqtt.cs.protocol.ssl.SslFactory;
+import org.apache.rocketmq.remoting.common.TlsMode;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@ChannelHandler.Sharable
+public class AdaptiveTlsHandler extends SimpleChannelInboundHandler {
+
+private static final Logger LOGGER =
LoggerFactory.getLogger(AdaptiveTlsHandler.class);
+
+private final TlsMode tlsMode;
+
+private static final byte HANDSHAKE_MAGIC_CODE = 0x16;
+
+private final SslFactory sslFactory;
+
+public AdaptiveTlsHandler(TlsMode tlsMode, SslFactory sslFactory) {
+this.tlsMode = tlsMode;
+this.sslFactory = sslFactory;
+}
+
+@Override
+protected void channelRead0(ChannelHandlerContext ctx, ByteBuf msg) {
+
+// Peek the current read index byte to determine if the content is
starting with TLS handshake
+byte b = msg.getByte(msg.readerIndex());
+
+if (b == HANDSHAKE_MAGIC_CODE) {
+switch (tlsMode) {
+case DISABLED:
+ctx.close();
+LOGGER.warn("Clients intend to establish an SSL connection
while this server is running in SSL disabled mode");
+throw new UnsupportedOperationException("The
NettyRemotingServer in SSL disabled mode doesn't support ssl client");
+case PERMISSIVE:
+case ENFORCING:
+if (null != sslFactory.getSslContext()) {
+ctx.pipeline()
+
.addAfter(AdaptiveTlsHandler.class.getSimpleName(),
SslHandler.class.getSimpleName(),
+
sslFactory.getSslContext().newHandler(ctx.alloc()));
+LOGGER.info("Handlers prepended to channel pipeline to
establish SSL connection");
+} else {
+ctx.close();
+LOGGER.error("Trying to establish an SSL connection
but sslContext is null");
+}
+break;
+
+default:
+LOGGER.warn("Unknown TLS mode");
+break;
+}
+} else if (tlsMode == TlsMode.ENFORCING) {
+ctx.close();
+LOGGER.warn("Clients intend to establish an insecure connection
while this server is running in SSL enforcing mode");
+}
+
+try {
+// Remove this handler
+ctx.pipeline().remove(this);
+} catch (NoSuchElementException e) {
+LOGGER.error("Error while removing TlsModeHandler", e);
+}
+
+// Hand over this message to the next handler.
+ctx.fireChannelRead(msg.retain());
+}
+
+
+}
diff --git
a/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/ssl/SslFactory.java
b/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/ssl/SslFactory.java
index b9cc77
(rocketmq-mqtt) 05/05: feat: add experimental support for QUIC transport
This is an automated email from the ASF dual-hosted git repository.
lizhanhui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git
commit 90cfe7c90647e738963fe1e21489aff19865742d
Author: Li Zhanhui
AuthorDate: Fri Apr 12 19:13:03 2024 +0800
feat: add experimental support for QUIC transport
---
docs/quic.md | 16 +
mqtt-common/pom.xml| 5 ++
.../rocketmq/mqtt/common/util/NetworkHelper.java | 35 ++
mqtt-cs/pom.xml| 5 ++
.../rocketmq/mqtt/cs/config/ConnectConf.java | 23 +++
.../rocketmq/mqtt/cs/protocol/ssl/SslFactory.java | 18 -
.../rocketmq/mqtt/cs/starter/MqttServer.java | 80 --
pom.xml| 14
8 files changed, 190 insertions(+), 6 deletions(-)
diff --git a/docs/quic.md b/docs/quic.md
new file mode 100644
index 000..025d71a
--- /dev/null
+++ b/docs/quic.md
@@ -0,0 +1,16 @@
+## Setup
+Download emqtt-bench with QUIC feature
+```shell
+wget
https://github.com/emqx/emqtt-bench/releases/download/0.4.18/emqtt-bench-0.4.18-macos13-amd64-quic.zip
+```
+
+## Test Connect
+```shell
+./bin/emqtt_bench conn -u user0 -P secret0 -V 4 --quic true -h localhost -p
14567 -c 10
+```
+
+### Pub
+
+```shell
+./bin/emqtt_bench pub -u user0 -P secret0 -V 4 --quic true -h localhost -p
14567 -c 1 -t T_Event/test
+```
diff --git a/mqtt-common/pom.xml b/mqtt-common/pom.xml
index 1edfa50..47d1c0d 100644
--- a/mqtt-common/pom.xml
+++ b/mqtt-common/pom.xml
@@ -68,6 +68,11 @@
io.netty
netty-all
+
+io.netty.incubator
+netty-incubator-codec-native-quic
+${os.detected.classifier}
+
org.apache.rocketmq
rocketmq-client
diff --git
a/mqtt-common/src/main/java/org/apache/rocketmq/mqtt/common/util/NetworkHelper.java
b/mqtt-common/src/main/java/org/apache/rocketmq/mqtt/common/util/NetworkHelper.java
new file mode 100644
index 000..769cd89
--- /dev/null
+++
b/mqtt-common/src/main/java/org/apache/rocketmq/mqtt/common/util/NetworkHelper.java
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.mqtt.common.util;
+
+import io.netty.incubator.codec.quic.QuicStreamAddress;
+import java.net.InetSocketAddress;
+import java.net.SocketAddress;
+import org.apache.rocketmq.common.utils.NetworkUtil;
+
+public class NetworkHelper {
+public static String socketAddressToString(SocketAddress address) {
+if (address instanceof InetSocketAddress) {
+return NetworkUtil.socketAddress2String(address);
+} else if (address instanceof QuicStreamAddress) {
+QuicStreamAddress quicAddress = (QuicStreamAddress) address;
+return String.format("quic[%d]", quicAddress.streamId());
+}
+throw new RuntimeException("Unsupported SocketAddress type");
+}
+}
diff --git a/mqtt-cs/pom.xml b/mqtt-cs/pom.xml
index c1c4521..da12f23 100644
--- a/mqtt-cs/pom.xml
+++ b/mqtt-cs/pom.xml
@@ -34,6 +34,11 @@
io.netty
netty-tcnative-boringssl-static
+
+io.netty.incubator
+netty-incubator-codec-native-quic
+${os.detected.classifier}
+
org.slf4j
slf4j-api
diff --git
a/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/config/ConnectConf.java
b/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/config/ConnectConf.java
index f558023..dcab351 100644
--- a/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/config/ConnectConf.java
+++ b/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/config/ConnectConf.java
@@ -32,9 +32,24 @@ public class ConnectConf {
private File confFile;
private int nettySelectorThreadNum = 1;
private int nettyWorkerThreadNum =
Runtime.getRuntime().availableProcessors() * 2;
+
+/**
+ * TCP ports 8883 and 1883 are registered with IANA for MQTT TLS and
non-TLS communication respectively.
+ */
private int mqttPort = 1883;
+
+/**
+ * TCP ports 8883 a
(rocketmq-mqtt) 04/05: feat: use shared netty event loop for TCP/TCP over TLS/Web Socket
This is an automated email from the ASF dual-hosted git repository.
lizhanhui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git
commit 318841e9acb0e6a1c0d846573e6efbd612984970
Author: Li Zhanhui
AuthorDate: Tue Apr 30 10:07:32 2024 +0800
feat: use shared netty event loop for TCP/TCP over TLS/Web Socket
Signed-off-by: Li Zhanhui
---
.../rocketmq/mqtt/cs/starter/MqttServer.java | 56 +++---
1 file changed, 38 insertions(+), 18 deletions(-)
diff --git
a/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/starter/MqttServer.java
b/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/starter/MqttServer.java
index 94d67ff..133c08f 100644
--- a/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/starter/MqttServer.java
+++ b/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/starter/MqttServer.java
@@ -32,6 +32,7 @@ import io.netty.handler.codec.mqtt.MqttDecoder;
import io.netty.handler.codec.mqtt.MqttEncoder;
import io.netty.handler.ssl.SslHandler;
import io.netty.handler.stream.ChunkedWriteHandler;
+import javax.annotation.PreDestroy;
import org.apache.rocketmq.mqtt.cs.channel.AdaptiveTlsHandler;
import org.apache.rocketmq.mqtt.cs.channel.ConnectHandler;
import org.apache.rocketmq.mqtt.cs.config.ConnectConf;
@@ -50,11 +51,11 @@ import java.net.InetSocketAddress;
@Service
public class MqttServer {
-private static Logger logger = LoggerFactory.getLogger(MqttServer.class);
+private static final Logger LOGGER =
LoggerFactory.getLogger(MqttServer.class);
-private ServerBootstrap serverBootstrap = new ServerBootstrap();
-private ServerBootstrap wsServerBootstrap = new ServerBootstrap();
-private ServerBootstrap tlsServerBootstrap = new ServerBootstrap();
+private final ServerBootstrap serverBootstrap = new ServerBootstrap();
+private final ServerBootstrap wsServerBootstrap = new ServerBootstrap();
+private final ServerBootstrap tlsServerBootstrap = new ServerBootstrap();
@Resource
private ConnectHandler connectHandler;
@@ -71,10 +72,17 @@ public class MqttServer {
@Resource
private SslFactory sslFactory;
+private NioEventLoopGroup acceptorEventLoopGroup;
+
+private NioEventLoopGroup workerEventLoopGroup;
+
private AdaptiveTlsHandler adaptiveTlsHandler;
@PostConstruct
public void init() throws Exception {
+acceptorEventLoopGroup = new
NioEventLoopGroup(connectConf.getNettySelectorThreadNum());
+workerEventLoopGroup = new
NioEventLoopGroup(connectConf.getNettyWorkerThreadNum());
+
adaptiveTlsHandler = new AdaptiveTlsHandler(TlsMode.PERMISSIVE,
sslFactory);
start();
@@ -82,10 +90,21 @@ public class MqttServer {
startTls();
}
+@PreDestroy
+public void shutdown() {
+if (null != acceptorEventLoopGroup) {
+acceptorEventLoopGroup.shutdownGracefully();
+}
+
+if (null != workerEventLoopGroup) {
+workerEventLoopGroup.shutdownGracefully();
+}
+}
+
private void start() {
int port = connectConf.getMqttPort();
serverBootstrap
-.group(new
NioEventLoopGroup(connectConf.getNettySelectorThreadNum()), new
NioEventLoopGroup(connectConf.getNettyWorkerThreadNum()))
+.group(acceptorEventLoopGroup, workerEventLoopGroup)
.channel(NioServerSocketChannel.class)
.option(ChannelOption.SO_BACKLOG, 8 * 1024)
.childOption(ChannelOption.ALLOCATOR,
PooledByteBufAllocator.DEFAULT)
@@ -96,14 +115,11 @@ public class MqttServer {
@Override
public void initChannel(SocketChannel ch) throws Exception {
ChannelPipeline pipeline = ch.pipeline();
-pipeline.addLast("connectHandler", connectHandler);
-pipeline.addLast("decoder", new
MqttDecoder(connectConf.getMaxPacketSizeInByte()));
-pipeline.addLast("encoder", MqttEncoder.INSTANCE);
-pipeline.addLast("dispatcher", mqttPacketDispatcher);
+assembleHandlerPipeline(pipeline);
}
});
serverBootstrap.bind();
-logger.warn("start mqtt server , port:{}", port);
+LOGGER.info("MQTT server for TCP started, listening: {}", port);
}
private void startTls() {
@@ -113,7 +129,7 @@ public class MqttServer {
int tlsPort = connectConf.getMqttTlsPort();
tlsServerBootstrap
-.group(new
NioEventLoopGroup(connectConf.getNettySelectorThreadNum()), new
NioEventLoopGroup(connectConf.getNettyWorkerThreadNum()))
+.group(acceptorEventLoopGroup, workerEventLoopGroup)
.channel(NioServerSocketChannel.class)
.option(ChannelOption.SO_BACKLOG, 8 * 1024)
.childOption(ChannelOption.ALLOCATOR,
PooledByteBufAllocator.DEFAULT)
@@ -125,14 +141,18 @@ public class Mq
(rocketmq-mqtt) 02/05: fix: socket option keep_alive shall be a child option in netty
This is an automated email from the ASF dual-hosted git repository.
lizhanhui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git
commit c768b77f9245a56005156156627df9c289cbd38a
Author: Li Zhanhui
AuthorDate: Wed Apr 17 13:38:22 2024 +0800
fix: socket option keep_alive shall be a child option in netty
Signed-off-by: Li Zhanhui
---
.../src/main/java/org/apache/rocketmq/mqtt/cs/starter/MqttServer.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/starter/MqttServer.java
b/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/starter/MqttServer.java
index 81a77b2..f4d0183 100644
--- a/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/starter/MqttServer.java
+++ b/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/starter/MqttServer.java
@@ -135,7 +135,7 @@ public class MqttServer {
.group(new
NioEventLoopGroup(connectConf.getNettySelectorThreadNum()), new
NioEventLoopGroup(connectConf.getNettyWorkerThreadNum()))
.channel(NioServerSocketChannel.class)
.option(ChannelOption.SO_BACKLOG, 8 * 1024)
-.option(ChannelOption.SO_KEEPALIVE, true)
+.childOption(ChannelOption.SO_KEEPALIVE, true)
.childOption(ChannelOption.ALLOCATOR,
PooledByteBufAllocator.DEFAULT)
.childOption(ChannelOption.WRITE_BUFFER_WATER_MARK,new
WriteBufferWaterMark(connectConf.getLowWater(), connectConf.getHighWater()))
.childOption(ChannelOption.TCP_NODELAY, true)
@@ -159,4 +159,4 @@ public class MqttServer {
logger.warn("start mqtt ws server , port:{}", port);
}
-}
\ No newline at end of file
+}
(rocketmq-mqtt) branch develop updated (95fbf79 -> 90cfe7c)
This is an automated email from the ASF dual-hosted git repository.
lizhanhui pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git
from 95fbf79 feat: add metrics for topic dimension read and write msg size
(#271)
new 6466344 feat: use openssl SSL provider to create TLS/SSL engine,
adding netty-tcnative to cs module
new c768b77 fix: socket option keep_alive shall be a child option in netty
new 0643cd3 feat: support WebSocket over TLS transport
new 318841e feat: use shared netty event loop for TCP/TCP over TLS/Web
Socket
new 90cfe7c feat: add experimental support for QUIC transport
The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
docs/quic.md | 16 +++
mqtt-common/pom.xml| 5 +
.../util/{SpringUtils.java => NetworkHelper.java} | 30 ++--
mqtt-cs/pom.xml| 11 +-
.../mqtt/cs/channel/AdaptiveTlsHandler.java| 93
.../rocketmq/mqtt/cs/config/ConnectConf.java | 23 +++
.../rocketmq/mqtt/cs/protocol/ssl/SslFactory.java | 30 +++-
.../rocketmq/mqtt/cs/starter/MqttServer.java | 158 +
pom.xml| 21 ++-
9 files changed, 339 insertions(+), 48 deletions(-)
create mode 100644 docs/quic.md
copy
mqtt-common/src/main/java/org/apache/rocketmq/mqtt/common/util/{SpringUtils.java
=> NetworkHelper.java} (56%)
create mode 100644
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/channel/AdaptiveTlsHandler.java
[PR] 使用.net5中的新方法减少分配，优化性能 [rocketmq-clients]
colprog opened a new pull request, #747: URL: https://github.com/apache/rocketmq-clients/pull/747 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Removing unwanted else block in RebalanceLockManager.java [rocketmq]
github-actions[bot] commented on issue #6738: URL: https://github.com/apache/rocketmq/issues/6738#issuecomment-2105397357 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Enhancement]removed unwanted space. [rocketmq]
github-actions[bot] commented on PR #6736: URL: https://github.com/apache/rocketmq/pull/6736#issuecomment-2105397374 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6677]Client Method RebalanceImpl#computePullFromWhere is marked with @Deprecated replace with computePullFromWhereWithException [rocketmq]
github-actions[bot] commented on PR #6678: URL: https://github.com/apache/rocketmq/pull/6678#issuecomment-2105397393 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6671]Enhance getting PID [rocketmq]
github-actions[bot] commented on PR #6672: URL: https://github.com/apache/rocketmq/pull/6672#issuecomment-2105397402 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Enhance getting PID [rocketmq]
github-actions[bot] commented on issue #6671: URL: https://github.com/apache/rocketmq/issues/6671#issuecomment-2105397409 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] when I use rocketMq with docker, and I test Producer, it occur following error, i want got help, very thanks [rocketmq]
github-actions[bot] commented on issue #6631: URL: https://github.com/apache/rocketmq/issues/6631#issuecomment-2105397421 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: eab0c1746d1e981bc7352554c8ad96f23684d0ed / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9040537032 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 159a603219e363e5f991a0c85213f6dc13f0a9be / yuz10 <845238...@qq.com> [ISSUE #5923] Fix tiered store README.md error (#8115) Report URL: https://github.com/apache/rocketmq/actions/runs/9040542275 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: eab0c1746d1e981bc7352554c8ad96f23684d0ed / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9040537035 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: f76293668f1d02a2cd95c915845bdc6c35ec8b69 / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9040607057 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 159a603219e363e5f991a0c85213f6dc13f0a9be / yuz10 <845238...@qq.com> [ISSUE #5923] Fix tiered store README.md error (#8115) Report URL: https://github.com/apache/rocketmq/actions/runs/9040611241 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: eab0c1746d1e981bc7352554c8ad96f23684d0ed / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9040537038 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: f76293668f1d02a2cd95c915845bdc6c35ec8b69 / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9040607054 With regards, GitHub Actions via GitBox
[I] [Bug] avoid sdk oom risk [rocketmq-clients]
fuyou001 opened a new issue, #748: URL: https://github.com/apache/rocketmq-clients/issues/748 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq-clients/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq-clients/issues) and [GitHub Discussions](https://github.com/apache/rocketmq-clients/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Programming Language of the Client Java ### Runtime Platform Environment all ### RocketMQ Version of the Client/Server sdk ### Run or Compiler Version no ### Describe the Bug In some scenarios, if the SDK continuously submits tasks but process slowly, it can lead to OOM (Out of Memory). By using a bounded queue, a backpressure-like effect is achieved to avoid OOM (Out of Memory). ### Steps to Reproduce no ### What Did You Expect to See? no ### What Did You See Instead? no ### Additional Context no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "PR-CI" is working again!
The GitHub Actions job "PR-CI" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 2bf38400b1c7408a52f7c43a94321ad31db203ba / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9040662744 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: f76293668f1d02a2cd95c915845bdc6c35ec8b69 / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9040607059 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: eab0c1746d1e981bc7352554c8ad96f23684d0ed / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9040537034 With regards, GitHub Actions via GitBox
(rocketmq-clients) 01/01: fixed #748
This is an automated email from the ASF dual-hosted git repository.
fuyou pushed a commit to branch issues-748
in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git
commit 51504dc515e9667ab4cca64a757a66d6ea7c7348
Author: 傅冲
AuthorDate: Sat May 11 11:19:50 2024 +0800
fixed #748
---
.../java/org/apache/rocketmq/client/java/impl/ClientManagerImpl.java| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/java/client/src/main/java/org/apache/rocketmq/client/java/impl/ClientManagerImpl.java
b/java/client/src/main/java/org/apache/rocketmq/client/java/impl/ClientManagerImpl.java
index 2ae5f5e4..7630fefb 100644
---
a/java/client/src/main/java/org/apache/rocketmq/client/java/impl/ClientManagerImpl.java
+++
b/java/client/src/main/java/org/apache/rocketmq/client/java/impl/ClientManagerImpl.java
@@ -122,7 +122,7 @@ public class ClientManagerImpl extends ClientManager {
Runtime.getRuntime().availableProcessors(),
60,
TimeUnit.SECONDS,
-new LinkedBlockingQueue<>(),
+new LinkedBlockingQueue<>(5),
new ThreadFactoryImpl("ClientAsyncWorker", clientIndex));
}
(rocketmq-clients) branch issues-748 created (now 51504dc5)
This is an automated email from the ASF dual-hosted git repository. fuyou pushed a change to branch issues-748 in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git at 51504dc5 fixed #748 This branch includes the following new commits: new 51504dc5 fixed #748 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 159a603219e363e5f991a0c85213f6dc13f0a9be / yuz10 <845238...@qq.com> [ISSUE #5923] Fix tiered store README.md error (#8115) Report URL: https://github.com/apache/rocketmq/actions/runs/9040674623 With regards, GitHub Actions via GitBox
[PR] fixed #748 [rocketmq-clients]
fuyou001 opened a new pull request, #749: URL: https://github.com/apache/rocketmq-clients/pull/749 ### Which Issue(s) This PR Fixes Fixes #748 748 ### Brief Description By using a bounded queue, a backpressure-like effect is achieved to avoid OOM (Out of Memory). ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-clients): Workflow run "Java Coverage" failed!
The GitHub Actions job "Java Coverage" on rocketmq-clients.git has failed. Run started by GitHub user fuyou001 (triggered by fuyou001). Head commit for run: 51504dc515e9667ab4cca64a757a66d6ea7c7348 / 傅冲 fixed #748 Report URL: https://github.com/apache/rocketmq-clients/actions/runs/9040763108 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 2bf38400b1c7408a52f7c43a94321ad31db203ba / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9040662743 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) [rocketmq]
codecov-commenter commented on PR #8116: URL: https://github.com/apache/rocketmq/pull/8116#issuecomment-2105512083 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8116?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `54.71698%` with `96 lines` in your changes are missing coverage. Please review. > Project coverage is 42.97%. Comparing base [(`159a603`)](https://app.codecov.io/gh/apache/rocketmq/commit/159a603219e363e5f991a0c85213f6dc13f0a9be?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`2bf3840`)](https://app.codecov.io/gh/apache/rocketmq/pull/8116?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8116?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...s/command/metadata/RocksDBConfigToJsonCommand.java](https://app.codecov.io/gh/apache/rocketmq/pull/8116?src=pr&el=tree&filepath=tools%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Ftools%2Fcommand%2Fmetadata%2FRocksDBConfigToJsonCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvbWV0YWRhdGEvUm9ja3NEQkNvbmZpZ1RvSnNvbkNvbW1hbmQuamF2YQ==) | 0.00% | [30 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../subscription/RocksDBSubscriptionGroupManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/8116?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Fsubscription%2FRocksDBSubscriptionGroupManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvc3Vic2NyaXB0aW9uL1JvY2tzREJTdWJzY3JpcHRpb25Hcm91cE1hbmFnZXIuamF2YQ==) | 67.60% | [17 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/rocketmq/common/config/ConfigRocksDBStorage.java](https://app.codecov.io/gh/apache/rocketmq/pull/8116?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fcommon%2Fconfig%2FConfigRocksDBStorage.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vY29uZmlnL0NvbmZpZ1JvY2tzREJTdG9yYWdlLmphdmE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/rocketmq/broker/RocksDBConfigManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/8116?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2FRocksDBConfigManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvUm9ja3NEQkNvbmZpZ01hbmFnZXIuamF2YQ==) | 72.22% | [5 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...cketmq/broker/topic/RocksDBTopicConfigManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/8116?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Ftopic%2FRocksDBTopicConfigManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvdG9waWMvUm9ja3NEQlRvcGljQ29uZmlnTWFuYWdlci5qYXZh) | 75.75% | [4 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/rocketmq/broker/topic/TopicConfigManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/8116?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Ftopic%2FTopicConfigManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvdG9waWMvVG9waWNDb25maWdNYW5h
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: f76293668f1d02a2cd95c915845bdc6c35ec8b69 / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9040607055 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 2bf38400b1c7408a52f7c43a94321ad31db203ba / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9040662745 With regards, GitHub Actions via GitBox
[PR] [ISSUE #266]: add metrics for messageType dimension [rocketmq-mqtt]
yx9o opened a new pull request, #275: URL: https://github.com/apache/rocketmq-mqtt/pull/275 For #266 , add metrics for messageType dimension. https://github.com/apache/rocketmq-mqtt/assets/12792261/9e3c0462-d752-499c-a779-f31ee76c8152";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 159a603219e363e5f991a0c85213f6dc13f0a9be / yuz10 <845238...@qq.com> [ISSUE #5923] Fix tiered store README.md error (#8115) Report URL: https://github.com/apache/rocketmq/actions/runs/9041688471 With regards, GitHub Actions via GitBox
