Re: [PR] [ISSUE #8129] support update topic reserved time for topic in tiered storage [rocketmq]
lizhimins commented on PR #8130: URL: https://github.com/apache/rocketmq/pull/8130#issuecomment-2109425234 There is a suggestion in https://github.com/apache/rocketmq/issues/8129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 71c9b02f9325bfcddb25167360ee5b94890f5296 / zhouxiang Set bloomFilterData for ConsumerFilterData When pop or pull Report URL: https://github.com/apache/rocketmq/actions/runs/9059989705 With regards, GitHub Actions via GitBox
[PR] [ISSUE #8124] Avoid scheduled tasks exiting because of unknown exceptions. [rocketmq]
colin719 opened a new pull request, #8132: URL: https://github.com/apache/rocketmq/pull/8132 ### Which Issue(s) This PR Fixes Fixes #8124 ### Brief Description avoid scheduled tasks exiting because of unknown exceptions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] support update topic reserved time for topic in tiered storage [rocketmq]
lizhimins commented on issue #8129: URL: https://github.com/apache/rocketmq/issues/8129#issuecomment-2109423784 How about marking TTL at the topic level in the attributes of TopicConfig? Please refer to 'org.apache.rocketmq.common.attribute.Attribute' and 'org.apache.rocketmq.common TopicAttributes' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by lizhimins). Head commit for run: 308d64f5145491252492fa58c126befe6d38b051 / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9073146601 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 03b16aadce572b3908dc09b99347fcf7e6c6ac7c / fujian-zfj <2573259...@qq.com> [ISSUE #8061] Fix npe in netty remoting client (#8064) Report URL: https://github.com/apache/rocketmq/actions/runs/9074986089 With regards, GitHub Actions via GitBox
(rocketmq) branch develop updated: [ISSUE #8061] Fix npe in netty remoting client (#8064)
This is an automated email from the ASF dual-hosted git repository.
lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 03b16aadce [ISSUE #8061] Fix npe in netty remoting client (#8064)
03b16aadce is described below
commit 03b16aadce572b3908dc09b99347fcf7e6c6ac7c
Author: fujian-zfj <2573259...@qq.com>
AuthorDate: Tue May 14 14:47:37 2024 +0800
[ISSUE #8061] Fix npe in netty remoting client (#8064)
---
.../java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
index ede6005f54..1bc5e57db5 100644
---
a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
+++
b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
@@ -631,7 +631,7 @@ public class NettyRemotingClient extends
NettyRemotingAbstract implements Remoti
if (channelFuture == null) {
return null;
}
-return getAndCreateChannelAsync(addr).awaitUninterruptibly().channel();
+return channelFuture.awaitUninterruptibly().channel();
}
private ChannelFuture getAndCreateNameserverChannelAsync() throws
InterruptedException {
Re: [PR] [ISSUE #8061] Fix npe in netty remoting client [rocketmq]
lizhimins merged PR #8064: URL: https://github.com/apache/rocketmq/pull/8064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] NPE of getAndCreateChannel in NettyRemotingClient [rocketmq]
lizhimins closed issue #8061: [Bug] NPE of getAndCreateChannel in NettyRemotingClient URL: https://github.com/apache/rocketmq/issues/8061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8118] Remove redundant mod in client [rocketmq]
lizhimins merged PR #8119: URL: https://github.com/apache/rocketmq/pull/8119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #8118] Remove redundant mod in client (#8119)
This is an automated email from the ASF dual-hosted git repository.
lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 502e2d798e [ISSUE #8118] Remove redundant mod in client (#8119)
502e2d798e is described below
commit 502e2d798e57fd4f40d16a90c44679af5ee7f986
Author: hiyo <77013030+miles-...@users.noreply.github.com>
AuthorDate: Tue May 14 14:45:29 2024 +0800
[ISSUE #8118] Remove redundant mod in client (#8119)
---
.../client/consumer/rebalance/AllocateMessageQueueAveragely.java | 2 +-
.../java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git
a/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragely.java
b/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragely.java
index 75e5d1c218..6f63a6fc60 100644
---
a/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragely.java
+++
b/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragely.java
@@ -42,7 +42,7 @@ public class AllocateMessageQueueAveragely extends
AbstractAllocateMessageQueueS
int startIndex = (mod > 0 && index < mod) ? index * averageSize :
index * averageSize + mod;
int range = Math.min(averageSize, mqAll.size() - startIndex);
for (int i = 0; i < range; i++) {
-result.add(mqAll.get((startIndex + i) % mqAll.size()));
+result.add(mqAll.get(startIndex + i));
}
return result;
}
diff --git
a/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
b/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
index 227f3346d0..f964869ac2 100644
---
a/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
+++
b/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
@@ -1222,8 +1222,7 @@ public class MQClientInstance {
if (topicRouteData != null) {
List brokers = topicRouteData.getBrokerDatas();
if (!brokers.isEmpty()) {
-int index = random.nextInt(brokers.size());
-BrokerData bd = brokers.get(index % brokers.size());
+BrokerData bd = brokers.get(random.nextInt(brokers.size()));
return bd.selectBrokerAddr();
}
}
Re: [I] [Enhancement] remove redundant mod [rocketmq]
lizhimins closed issue #8118: [Enhancement] remove redundant mod URL: https://github.com/apache/rocketmq/issues/8118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-spring): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq-spring.git has failed. Run started by GitHub user ShannonDing (triggered by ShannonDing). Head commit for run: 017025fe788456f4f20444fe936c27a97697080b / ShannonDing update year to 2024 in NOTICE Report URL: https://github.com/apache/rocketmq-spring/actions/runs/9074841449 With regards, GitHub Actions via GitBox
[PR] update year to 2024 in NOTICE [rocketmq-spring]
ShannonDing opened a new pull request, #652: URL: https://github.com/apache/rocketmq-spring/pull/652 ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [ ] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 使用 docker compose 部署 2m 2s 并且加入代理组件当 其中一个 master broker 宕机之后部分消息一直重复消费 [rocketmq]
muzhi9018 commented on issue #8126: URL: https://github.com/apache/rocketmq/issues/8126#issuecomment-2109371345 > Could you also print message id in your consumer? The one on the left is the producer console, which prints the message id; the one on the right is the consumer console, which prints the message key. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #650] Fix url and typo [rocketmq-spring]
hakusai22 commented on PR #651: URL: https://github.com/apache/rocketmq-spring/pull/651#issuecomment-2109366886 @RongtongJin https://github.com/apache/rocketmq-spring/assets/58761705/2bcfd245-3ad0-4664-801c-2c925ad54336";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-spring): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq-spring.git has failed. Run started by GitHub user hakusai22 (triggered by RongtongJin). Head commit for run: 344ca487bf7a51ca3cbfb3773873ae36190d1d52 / yinpeng [ISSUE #650] Fix url and typo Report URL: https://github.com/apache/rocketmq-spring/actions/runs/9029469680 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 308d64f5145491252492fa58c126befe6d38b051 / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9073146601 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: ee748121d4ab0f90dc1e6c89da958c6f2fe85f82 / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9073125547 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 71c9b02f9325bfcddb25167360ee5b94890f5296 / zhouxiang Set bloomFilterData for ConsumerFilterData When pop or pull Report URL: https://github.com/apache/rocketmq/actions/runs/9059989705 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d943456bcaa8317b8d3ae55f9a1117a5bf8478ed / Zhouxiang Zhan Add unit test for MQClientAPIExtTest (#8080) Report URL: https://github.com/apache/rocketmq/actions/runs/9072933105 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 308d64f5145491252492fa58c126befe6d38b051 / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9073146594 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: d943456bcaa8317b8d3ae55f9a1117a5bf8478ed / Zhouxiang Zhan Add unit test for MQClientAPIExtTest (#8080) Report URL: https://github.com/apache/rocketmq/actions/runs/9073168619 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: ee748121d4ab0f90dc1e6c89da958c6f2fe85f82 / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9073125542 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" is working again!
The GitHub Actions job "PR-CI" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 308d64f5145491252492fa58c126befe6d38b051 / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9073146597 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: d943456bcaa8317b8d3ae55f9a1117a5bf8478ed / Zhouxiang Zhan Add unit test for MQClientAPIExtTest (#8080) Report URL: https://github.com/apache/rocketmq/actions/runs/9073136479 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: ee748121d4ab0f90dc1e6c89da958c6f2fe85f82 / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9073125539 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 3bc62e6101da56e46ef3ed50b9c84e6c837314f1 / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9072610507 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d943456bcaa8317b8d3ae55f9a1117a5bf8478ed / Zhouxiang Zhan Add unit test for MQClientAPIExtTest (#8080) Report URL: https://github.com/apache/rocketmq/actions/runs/9072933112 With regards, GitHub Actions via GitBox
(rocketmq) branch develop updated: Add unit test for MQClientAPIExtTest (#8080)
This is an automated email from the ASF dual-hosted git repository.
zhouxzhan pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new d943456bca Add unit test for MQClientAPIExtTest (#8080)
d943456bca is described below
commit d943456bcaa8317b8d3ae55f9a1117a5bf8478ed
Author: Zhouxiang Zhan
AuthorDate: Tue May 14 10:40:42 2024 +0800
Add unit test for MQClientAPIExtTest (#8080)
---
.../client/impl/mqclient/MQClientAPIExtTest.java | 74 ++
1 file changed, 74 insertions(+)
diff --git
a/client/src/test/java/org/apache/rocketmq/client/impl/mqclient/MQClientAPIExtTest.java
b/client/src/test/java/org/apache/rocketmq/client/impl/mqclient/MQClientAPIExtTest.java
new file mode 100644
index 00..752bc98eab
--- /dev/null
+++
b/client/src/test/java/org/apache/rocketmq/client/impl/mqclient/MQClientAPIExtTest.java
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.client.impl.mqclient;
+
+import java.util.concurrent.CompletableFuture;
+import org.apache.rocketmq.client.ClientConfig;
+import org.apache.rocketmq.client.producer.SendResult;
+import org.apache.rocketmq.common.message.Message;
+import org.apache.rocketmq.common.utils.FutureUtils;
+import org.apache.rocketmq.remoting.exception.RemotingTimeoutException;
+import org.apache.rocketmq.remoting.netty.NettyClientConfig;
+import org.apache.rocketmq.remoting.netty.NettyRemotingClient;
+import org.apache.rocketmq.remoting.protocol.header.SendMessageRequestHeader;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.junit.MockitoJUnitRunner;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyLong;
+import static org.mockito.ArgumentMatchers.anyString;
+
+@RunWith(MockitoJUnitRunner.class)
+public class MQClientAPIExtTest {
+MQClientAPIExt mqClientAPIExt;
+@Mock
+NettyRemotingClient remotingClientMock;
+
+@Before
+public void before() {
+mqClientAPIExt = Mockito.spy(new MQClientAPIExt(new ClientConfig(),
new NettyClientConfig(), null, null));
+
Mockito.when(mqClientAPIExt.getRemotingClient()).thenReturn(remotingClientMock);
+Mockito.when(remotingClientMock.invoke(anyString(), any(),
anyLong())).thenReturn(FutureUtils.completeExceptionally(new
RemotingTimeoutException("addr")));
+}
+
+@Test
+public void sendMessageAsync() {
+String topic = "test";
+Message msg = new Message(topic, "test".getBytes());
+SendMessageRequestHeader requestHeader = new
SendMessageRequestHeader();
+requestHeader.setTopic(topic);
+requestHeader.setProducerGroup("test");
+requestHeader.setDefaultTopic("test");
+requestHeader.setDefaultTopicQueueNums(1);
+requestHeader.setQueueId(0);
+requestHeader.setSysFlag(0);
+requestHeader.setBornTimestamp(0L);
+requestHeader.setFlag(0);
+requestHeader.setProperties("test");
+requestHeader.setReconsumeTimes(0);
+requestHeader.setUnitMode(false);
+requestHeader.setBatch(false);
+CompletableFuture future =
mqClientAPIExt.sendMessageAsync("127.0.0.1:10911", "test", msg, requestHeader,
10);
+
assertThatThrownBy(future::get).getCause().isInstanceOf(RemotingTimeoutException.class);
+}
+}
\ No newline at end of file
Re: [PR] [ISSUE #8079] Add unit test for MQClientAPIExtTest [rocketmq]
drpmma merged PR #8080: URL: https://github.com/apache/rocketmq/pull/8080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Add unit test for MQClientAPIExtTest [rocketmq]
drpmma closed issue #8079: [Enhancement] Add unit test for MQClientAPIExtTest URL: https://github.com/apache/rocketmq/issues/8079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 609196890765b89116e12745279d287b91eae2ee / Colin Lee [ISSUE #8124] Avoid scheduled tasks exiting because of unknown exceptions Signed-off-by: Colin Lee Co-authored-by: lirui Report URL: https://github.com/apache/rocketmq/actions/runs/9072631081 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Node.js Coverage" failed!
The GitHub Actions job "Node.js Coverage" on rocketmq-clients.git has failed. Run started by GitHub user zhaohai666 (triggered by panzhi33). Head commit for run: b04a1701a885117db4e2d26929bce328c20f6639 / zh378814 update version Report URL: https://github.com/apache/rocketmq-clients/actions/runs/9072372814 With regards, GitHub Actions via GitBox
Re: [I] 使用 docker compose 部署 2m 2s 并且加入代理组件当 其中一个 master broker 宕机之后部分消息一直重复消费 [rocketmq]
muzhi9018 commented on issue #8126: URL: https://github.com/apache/rocketmq/issues/8126#issuecomment-2109082541 > Could you also print message id in your consumer? The console prints the keys of the message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Snapshot Daily Release Automation" failed!
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 609196890765b89116e12745279d287b91eae2ee / Colin Lee [ISSUE #8124] Avoid scheduled tasks exiting because of unknown exceptions Signed-off-by: Colin Lee Co-authored-by: lirui Report URL: https://github.com/apache/rocketmq/actions/runs/9071683782 With regards, GitHub Actions via GitBox
Re: [I] build docker image [rocketmq]
github-actions[bot] commented on issue #4704: URL: https://github.com/apache/rocketmq/issues/4704#issuecomment-2109032452 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] when I use rocketMq with docker, and I test Producer, it occur following error, i want got help, very thanks [rocketmq]
github-actions[bot] commented on issue #6631: URL: https://github.com/apache/rocketmq/issues/6631#issuecomment-2109032424 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] when I use rocketMq with docker, and I test Producer, it occur following error, i want got help, very thanks [rocketmq]
github-actions[bot] closed issue #6631: when I use rocketMq with docker, and I test Producer, it occur following error, i want got help, very thanks URL: https://github.com/apache/rocketmq/issues/6631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Enhance getting PID [rocketmq]
github-actions[bot] commented on issue #6671: URL: https://github.com/apache/rocketmq/issues/6671#issuecomment-2109032396 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6671]Enhance getting PID [rocketmq]
github-actions[bot] closed pull request #6672: [ISSUE #6671]Enhance getting PID URL: https://github.com/apache/rocketmq/pull/6672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Enhance getting PID [rocketmq]
github-actions[bot] closed issue #6671: Enhance getting PID URL: https://github.com/apache/rocketmq/issues/6671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6671]Enhance getting PID [rocketmq]
github-actions[bot] commented on PR #6672: URL: https://github.com/apache/rocketmq/pull/6672#issuecomment-2109032356 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6677]Client Method RebalanceImpl#computePullFromWhere is marked with @Deprecated replace with computePullFromWhereWithException [rocketmq]
github-actions[bot] closed pull request #6678: [ISSUE #6677]Client Method RebalanceImpl#computePullFromWhere is marked with @Deprecated replace with computePullFromWhereWithException URL: https://github.com/apache/rocketmq/pull/6678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6677]Client Method RebalanceImpl#computePullFromWhere is marked with @Deprecated replace with computePullFromWhereWithException [rocketmq]
github-actions[bot] commented on PR #6678: URL: https://github.com/apache/rocketmq/pull/6678#issuecomment-2109032337 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Enhancement]removed unwanted space. [rocketmq]
github-actions[bot] commented on PR #6736: URL: https://github.com/apache/rocketmq/pull/6736#issuecomment-2109032312 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Enhancement]removed unwanted space. [rocketmq]
github-actions[bot] closed pull request #6736: [Enhancement]removed unwanted space. URL: https://github.com/apache/rocketmq/pull/6736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Removing unwanted else block in RebalanceLockManager.java [rocketmq]
github-actions[bot] closed issue #6738: [Enhancement] Removing unwanted else block in RebalanceLockManager.java URL: https://github.com/apache/rocketmq/issues/6738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Removing unwanted else block in RebalanceLockManager.java [rocketmq]
github-actions[bot] commented on issue #6738: URL: https://github.com/apache/rocketmq/issues/6738#issuecomment-2109032286 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #229]when use cgroups v2, controller failed to start [rocketmq-operator]
usernameisnull opened a new pull request, #230: URL: https://github.com/apache/rocketmq-operator/pull/230 ## What is the purpose of the change fix bug #229 ## Brief changelog if no file /sys/fs/cgroup/memory/memory.limit_in_bytes try file /sys/fs/cgroup/memory.max ## Verifying this change **Please go through this checklist to help us incorporate your contribution quickly and easily.** Notice: `It would be helpful if you could finish the following checklist (the last one is not necessary) before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq-operator/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check RBAC rights for Kubernetes roles. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. - [ ] Run `make docker-build` to build docker image for operator, try your changes from Pod inside your Kubernetes cluster, **not just locally**. Also provide screenshots to show that the RocketMQ cluster is healthy after the changes. - [ ] Before committing your changes, remember to run `make manifests` to make sure the CRD files are updated. - [ ] Update documentation if necessary. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8127]Fix the metric of the time wheel was incorrectly calculated [rocketmq]
codecov-commenter commented on PR #8128: URL: https://github.com/apache/rocketmq/pull/8128#issuecomment-2108172952 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8128?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `50.0%` with `6 lines` in your changes are missing coverage. Please review. > Project coverage is 42.86%. Comparing base [(`6091968`)](https://app.codecov.io/gh/apache/rocketmq/commit/609196890765b89116e12745279d287b91eae2ee?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e531415`)](https://app.codecov.io/gh/apache/rocketmq/pull/8128?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8128?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/rocketmq/store/timer/TimerMessageStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/8128?src=pr&el=tree&filepath=store%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fstore%2Ftimer%2FTimerMessageStore.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3RpbWVyL1RpbWVyTWVzc2FnZVN0b3JlLmphdmE=) | 50.00% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8128 +/- ## = - Coverage 42.89% 42.86% -0.04% + Complexity 1037510364 -11 = Files 1270 1270 Lines 8869488704 +10 Branches 1140111404 +3 = - Hits 3804838020 -28 - Misses 4595445977 +23 - Partials4692 4707 +15 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8128?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user 3424672656 (triggered by 3424672656). Head commit for run: 609196890765b89116e12745279d287b91eae2ee / Colin Lee [ISSUE #8124] Avoid scheduled tasks exiting because of unknown exceptions Signed-off-by: Colin Lee Co-authored-by: lirui Report URL: https://github.com/apache/rocketmq/actions/runs/9066309026 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user yuz10 (triggered by yuz10). Head commit for run: 675abdf5bb6aebe0d07743b38fc175e5ef7ddbad / yuz10 <845238...@qq.com> fix Report URL: https://github.com/apache/rocketmq/actions/runs/9065206274 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8070] Optimize the submitConsumeRequest and remove unnecessary exception catching [rocketmq]
biningo commented on code in PR #8071:
URL: https://github.com/apache/rocketmq/pull/8071#discussion_r1598683474
##
client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java:
##
@@ -190,35 +189,11 @@ public void submitConsumeRequest(
final MessageQueue messageQueue,
final boolean dispatchToConsume) {
final int consumeBatchSize =
this.defaultMQPushConsumer.getConsumeMessageBatchMaxSize();
-if (msgs.size() <= consumeBatchSize) {
-ConsumeRequest consumeRequest = new ConsumeRequest(msgs,
processQueue, messageQueue);
-try {
-this.consumeExecutor.submit(consumeRequest);
-} catch (RejectedExecutionException e) {
-this.submitConsumeRequestLater(consumeRequest);
-}
-} else {
-for (int total = 0; total < msgs.size(); ) {
-List msgThis = new ArrayList<>(consumeBatchSize);
-for (int i = 0; i < consumeBatchSize; i++, total++) {
-if (total < msgs.size()) {
-msgThis.add(msgs.get(total));
-} else {
-break;
-}
-}
-
-ConsumeRequest consumeRequest = new ConsumeRequest(msgThis,
processQueue, messageQueue);
-try {
-this.consumeExecutor.submit(consumeRequest);
-} catch (RejectedExecutionException e) {
-for (; total < msgs.size(); total++) {
-msgThis.add(msgs.get(total));
-}
-
-this.submitConsumeRequestLater(consumeRequest);
-}
-}
+int batch = ((msgs.size() - 1) / consumeBatchSize) + 1;
Review Comment:
Oh yeah
It's not very readable here. I've optimized it. Thanks for your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8070] Optimize the submitConsumeRequest and remove unnecessary exception catching [rocketmq]
biningo commented on code in PR #8071:
URL: https://github.com/apache/rocketmq/pull/8071#discussion_r1598683474
##
client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java:
##
@@ -190,35 +189,11 @@ public void submitConsumeRequest(
final MessageQueue messageQueue,
final boolean dispatchToConsume) {
final int consumeBatchSize =
this.defaultMQPushConsumer.getConsumeMessageBatchMaxSize();
-if (msgs.size() <= consumeBatchSize) {
-ConsumeRequest consumeRequest = new ConsumeRequest(msgs,
processQueue, messageQueue);
-try {
-this.consumeExecutor.submit(consumeRequest);
-} catch (RejectedExecutionException e) {
-this.submitConsumeRequestLater(consumeRequest);
-}
-} else {
-for (int total = 0; total < msgs.size(); ) {
-List msgThis = new ArrayList<>(consumeBatchSize);
-for (int i = 0; i < consumeBatchSize; i++, total++) {
-if (total < msgs.size()) {
-msgThis.add(msgs.get(total));
-} else {
-break;
-}
-}
-
-ConsumeRequest consumeRequest = new ConsumeRequest(msgThis,
processQueue, messageQueue);
-try {
-this.consumeExecutor.submit(consumeRequest);
-} catch (RejectedExecutionException e) {
-for (; total < msgs.size(); total++) {
-msgThis.add(msgs.get(total));
-}
-
-this.submitConsumeRequestLater(consumeRequest);
-}
-}
+int batch = ((msgs.size() - 1) / consumeBatchSize) + 1;
Review Comment:
Oh yeah!
It's not very readable here. I've optimized it. Thanks for your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8129] support update topic reserved time for topic in tiered storage [rocketmq]
codecov-commenter commented on PR #8130: URL: https://github.com/apache/rocketmq/pull/8130#issuecomment-2108002238 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8130?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `0%` with `108 lines` in your changes are missing coverage. Please review. > Project coverage is 42.85%. Comparing base [(`159a603`)](https://app.codecov.io/gh/apache/rocketmq/commit/159a603219e363e5f991a0c85213f6dc13f0a9be?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`675abdf`)](https://app.codecov.io/gh/apache/rocketmq/pull/8130?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 1 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8130?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...edstore/TieredStoreUpdateTopicMetadataCommand.java](https://app.codecov.io/gh/apache/rocketmq/pull/8130?src=pr&el=tree&filepath=tools%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Ftools%2Fcommand%2Ftieredstore%2FTieredStoreUpdateTopicMetadataCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvdGllcmVkc3RvcmUvVGllcmVkU3RvcmVVcGRhdGVUb3BpY01ldGFkYXRhQ29tbWFuZC5qYXZh) | 0.00% | [44 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ocketmq/broker/processor/AdminBrokerProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/8130?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Fprocessor%2FAdminBrokerProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0FkbWluQnJva2VyUHJvY2Vzc29yLmphdmE=) | 0.00% | [29 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...r/TieredStoreUpdateTopicMetadataRequestHeader.java](https://app.codecov.io/gh/apache/rocketmq/pull/8130?src=pr&el=tree&filepath=remoting%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fremoting%2Fprotocol%2Fheader%2FTieredStoreUpdateTopicMetadataRequestHeader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL2hlYWRlci9UaWVyZWRTdG9yZVVwZGF0ZVRvcGljTWV0YWRhdGFSZXF1ZXN0SGVhZGVyLmphdmE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/8130?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2FMQClientAPIImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/rocketmq/tieredstore/file/FlatMessageFile.java](https://app.codecov.io/gh/apache/rocketmq/pull/8130?src=pr&el=tree&filepath=tieredstore%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Ftieredstore%2Ffile%2FFlatMessageFile.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL2ZpbGUvRmxhdE1lc3NhZ2VGaWxlLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/rocketmq/tieredstore/file/FlatFileStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/8130?src=pr&el=tree&filepath=tieredstore%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Ftieredstore%2Ffile%2FFlatFileStore.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user yuz10 (triggered by yuz10). Head commit for run: 675abdf5bb6aebe0d07743b38fc175e5ef7ddbad / yuz10 <845238...@qq.com> fix Report URL: https://github.com/apache/rocketmq/actions/runs/9065206287 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user yuz10 (triggered by yuz10). Head commit for run: 609196890765b89116e12745279d287b91eae2ee / Colin Lee [ISSUE #8124] Avoid scheduled tasks exiting because of unknown exceptions Signed-off-by: Colin Lee Co-authored-by: lirui Report URL: https://github.com/apache/rocketmq/actions/runs/9065259688 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" is working again!
The GitHub Actions job "PR-CI" on rocketmq.git has succeeded. Run started by GitHub user yuz10 (triggered by yuz10). Head commit for run: 675abdf5bb6aebe0d07743b38fc175e5ef7ddbad / yuz10 <845238...@qq.com> fix Report URL: https://github.com/apache/rocketmq/actions/runs/9065206282 With regards, GitHub Actions via GitBox
[PR] [ISSUE #8129] support update topic reserved time for topic in tiered storage [rocketmq]
yuz10 opened a new pull request, #8130: URL: https://github.com/apache/rocketmq/pull/8130 ### Which Issue(s) This PR Fixes Fixes #8129 ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user 3424672656 (triggered by 3424672656). Head commit for run: db1e41e64ced8553be7fd2514eff99e46b49c9a8 / wanghuaiyuan <3424672...@qq.com> Fix the metric of the time wheel was incorrectly calculated Report URL: https://github.com/apache/rocketmq/actions/runs/9065009005 With regards, GitHub Actions via GitBox
[I] [Enhancement] support update topic reserved time for topic in tiered storage [rocketmq]
yuz10 opened a new issue, #8129: URL: https://github.com/apache/rocketmq/issues/8129 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary support update topic reserved time for topic in tiered storage ### Motivation Currently the message reserved period can only be set for the broker as a whole and cannot be set for topics individually. In advantage of tiered storage, it is able to set reserved period for topics individually. ### Describe the Solution You'd Like add reserved time config to topic metadata in tiered storage, and delete the file in tiered storage in time. ### Describe Alternatives You've Considered add reserved time config to topics.json in broker topicConfigManager ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] when use cgroups v2,the controller can't start [rocketmq-operator]
usernameisnull opened a new issue, #229: URL: https://github.com/apache/rocketmq-operator/issues/229 The issue tracker is **ONLY** used for the bug report(feature request need to follow [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal)). Keep in mind, please check whether there is an existing same report before you raise a new one. Alternately (especially if your communication is not a bug report), you can send mail to our [mailing lists](http://rocketmq.apache.org/about/contact/). We welcome any friendly suggestions, bug fixes, collaboration and other improvements. Please ensure that your bug report is clear and that it is complete. Otherwise, we may be unable to understand it or to reproduce it, either of which would prevent us from fixing the bug. We strongly recommend the report(bug report or feature request) could include some hints as the following: **BUG REPORT** 1. Please describe the issue you observed: - What did you do (The steps to reproduce)? just start a new instance of rocketmq - What did you expect to see? start success - What did you see instead? the controller failed to start 2. Please tell us about your environment: node: ``` root@master01:~# cat /etc/os-release PRETTY_NAME="Ubuntu 22.04.1 LTS" NAME="Ubuntu" VERSION_ID="22.04" VERSION="22.04.1 LTS (Jammy Jellyfish)" VERSION_CODENAME=jammy ID=ubuntu ID_LIKE=debian HOME_URL="https://www.ubuntu.com/"; SUPPORT_URL="https://help.ubuntu.com/"; BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"; PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"; UBUNTU_CODENAME=jammy ``` docker version ``` root@master01:~# docker version Client: Docker Engine - Community Version: 20.10.21 API version: 1.41 Go version:go1.18.7 Git commit:baeda1f Built: Tue Oct 25 18:01:58 2022 OS/Arch: linux/amd64 Context: default Experimental: true Server: Docker Engine - Community Engine: Version: 20.10.21 API version: 1.41 (minimum version 1.12) Go version: go1.18.7 Git commit: 3056208 Built:Tue Oct 25 17:59:49 2022 OS/Arch: linux/amd64 Experimental: false containerd: Version: 1.6.9 GitCommit:1c90a442489720eec95342e1789ee8a5e1b9536f runc: Version: 1.1.4 GitCommit:v1.1.4-0-g5fd4c4d docker-init: Version: 0.19.0 GitCommit:de40ad0 ``` 3. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc): the logs of pod ``` kubectl logs controller-0 cat: can't open '/sys/fs/cgroup/memory/memory.limit_in_bytes': No such file or directory /root/rocketmq/controller/bin/runserver.sh: line 58: arithmetic syntax error ``` **FEATURE REQUEST** 1. Please describe the feature you are requesting. 2. Provide any additional detail on your proposed use case for this feature. 2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue? 4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task: - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 description here, - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 description here, - ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user 3424672656 (triggered by 3424672656). Head commit for run: db1e41e64ced8553be7fd2514eff99e46b49c9a8 / wanghuaiyuan <3424672...@qq.com> Fix the metric of the time wheel was incorrectly calculated Report URL: https://github.com/apache/rocketmq/actions/runs/9065008996 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user 3424672656 (triggered by 3424672656). Head commit for run: db1e41e64ced8553be7fd2514eff99e46b49c9a8 / wanghuaiyuan <3424672...@qq.com> Fix the metric of the time wheel was incorrectly calculated Report URL: https://github.com/apache/rocketmq/actions/runs/9065008993 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user 3424672656 (triggered by 3424672656). Head commit for run: 609196890765b89116e12745279d287b91eae2ee / Colin Lee [ISSUE #8124] Avoid scheduled tasks exiting because of unknown exceptions Signed-off-by: Colin Lee Co-authored-by: lirui Report URL: https://github.com/apache/rocketmq/actions/runs/9065022586 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user 3424672656 (triggered by 3424672656). Head commit for run: db1e41e64ced8553be7fd2514eff99e46b49c9a8 / wanghuaiyuan <3424672...@qq.com> Fix the metric of the time wheel was incorrectly calculated Report URL: https://github.com/apache/rocketmq/actions/runs/9065008992 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8127]Fix the metric of the time wheel was incorrectly calculated [rocketmq]
3424672656 commented on PR #8128: URL: https://github.com/apache/rocketmq/pull/8128#issuecomment-2107843189 #8127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #8127]Fix the metric of the time wheel was incorrectly calculated [rocketmq]
3424672656 opened a new pull request, #8128: URL: https://github.com/apache/rocketmq/pull/8128 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] The metric of the time wheel was incorrectly calculated [rocketmq]
3424672656 opened a new issue, #8127: URL: https://github.com/apache/rocketmq/issues/8127 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment Centos ### RocketMQ version 5.2.1 ### JDK Version 11 ### Describe the Bug The metric of a time wheel in a scheduled task is incorrectly calculated  Because each element is a type of information, the code in the text are invalid and metric fluctuation errors occur  ### Steps to Reproduce Use arrays for correct calculations for each round of placement ### What Did You Expect to See? metric is correctly ### What Did You See Instead? metric is incorrectly ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: fed0dbc7891bab4f38ed655f2af3bc6c283078ee / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9062860750 With regards, GitHub Actions via GitBox
[PR] fix: concurrency problem caused by batchFlushOnCheckpoint [rocketmq-flink]
humkum opened a new pull request, #119: URL: https://github.com/apache/rocketmq-flink/pull/119 fix #118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: fed0dbc7891bab4f38ed655f2af3bc6c283078ee / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9062860757 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 609196890765b89116e12745279d287b91eae2ee / Colin Lee [ISSUE #8124] Avoid scheduled tasks exiting because of unknown exceptions Signed-off-by: Colin Lee Co-authored-by: lirui Report URL: https://github.com/apache/rocketmq/actions/runs/9062898014 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: fed0dbc7891bab4f38ed655f2af3bc6c283078ee / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9062860751 With regards, GitHub Actions via GitBox
Re: [I] 使用 docker compose 部署 2m 2s 并且加入代理组件当 其中一个 master broker 宕机之后部分消息一直重复消费 [rocketmq]
caigy commented on issue #8126: URL: https://github.com/apache/rocketmq/issues/8126#issuecomment-2107341422 Could you also print message id in your consumer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #4440] upgrade fastjson from 1.x to 2.x [rocketmq]
MartinDai commented on PR #6583: URL: https://github.com/apache/rocketmq/pull/6583#issuecomment-2107341251 It should be add more compatibility test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #4440] upgrade fastjson from 1.x to 2.x [rocketmq]
MartinDai closed pull request #6583: [ISSUE #4440] upgrade fastjson from 1.x to 2.x URL: https://github.com/apache/rocketmq/pull/6583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Feature] 支持打包 [rocketmq-clients]
yarlc opened a new issue, #751:
URL: https://github.com/apache/rocketmq-clients/issues/751
### Programming Language of the Client
Node.js
### Is Your Feature Request Related to a Problem?
想要打包可运行只能修改源码
### Describe the Solution You'd Like
# src/util/index.ts 21 行
import { crc32 } from '@node-rs/crc32';
请采用纯JS库.
# 文件 src/client/UserAgent.ts 23 行
const VERSION: string = JSON.parse(readFileSync(path.join(__dirname,
'../../package.json'), 'utf-8')).version;
这行完全无法打包, 请采用其他方式实现.
### Describe Alternatives You've Considered
现在只能修改源码才能解决
### Additional Context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 609196890765b89116e12745279d287b91eae2ee / Colin Lee [ISSUE #8124] Avoid scheduled tasks exiting because of unknown exceptions Signed-off-by: Colin Lee Co-authored-by: lirui Report URL: https://github.com/apache/rocketmq/actions/runs/9060562543 With regards, GitHub Actions via GitBox
Re: [I] 使用 docker compose 部署 2m 2s 并且加入代理组件当 其中一个 master broker 宕机之后部分消息一直重复消费 [rocketmq]
muzhi9018 commented on issue #8126: URL: https://github.com/apache/rocketmq/issues/8126#issuecomment-2107147689 消费者 控制台图片上传错了 重新上传  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] 使用 docker compose 部署 2m 2s 并且加入代理组件当 其中一个 master broker 宕机之后部分消息一直重复消费 [rocketmq]
muzhi9018 opened a new issue, #8126: URL: https://github.com/apache/rocketmq/issues/8126 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment 宿主机 Win 11 23H2 Docker 容器基础镜像 ubuntu:22.04 ### RocketMQ version Rocket MQ 版本 5.1.4 Rocket MQ 客户端版本 5.0.6 (rocketmq-client-java) 客户端 Maven 坐标 ```xml dependency> org.apache.rocketmq rocketmq-client-java 5.0.6 ``` ### JDK Version Zulu JRE 17.0.11 ### Describe the Bug 使用 Docker Compose 部署 2 个 Master Broker; 2 个 Slave Broker; 当其中一个 Master Broker 宕机之后会有部分消息一直重复消费 ### Steps to Reproduce Dockerfile 如下 ```dockerfile FROM java:17.0.11 ARG version=5.1.4 # 定义用户名变量 ARG USER_NAME="rocketmq" # 定义用户id变量 ARG USER_ID="1000" # 定义用户组名称变量 ARG GROUP_NAME="rocketmq" # 定义用户组id变量 ARG GROUP_ID="1000" COPY benchmark /rocketmq/benchmark COPY bin /rocketmq/bin COPY conf /rocketmq/conf COPY lib /rocketmq/lib COPY LICENSE /rocketmq/LICENSE COPY NOTICE /rocketmq/NOTICE # 创建用户组和创建用户; 并且更改文件权限 RUN chown -R $USER_ID:$GROUP_ID /rocketmq \ && groupadd -g $GROUP_ID $GROUP_NAME \ && useradd -d /rocketmq -u $USER_ID -g $GROUP_NAME -l -m -s /bin/bash $USER_NAME \ && chown -R $USER_NAME:$GROUP_NAME /rocketmq \ && chmod +x -R /rocketmq/bin # rocketmq home 环境变量 ENV ROCKETMQ_HOME=/rocketmq ENV PATH=$ROCKETMQ_HOME/bin:$PATH # 切换用户 USER $USER_NAME # 设置工作目录 WORKDIR /rocketmq/bin ENV JAVA_OPT="" ENV JAVA_OPT_EXT="" # nameserver 端口 EXPOSE 9876 # broker 端口 EXPOSE 10909 10911 10912 CMD ["dummy"] ``` docker-compose.yaml 如下 ```yaml services: rocket-nameserver: image: apache/rocketmq:5.1.4 container_name: rocket-nameserver restart: no stop_grace_period: 5s networks: - muzhi-cloud-net #ports: # - "9876:9876" env_file: - "conf/nameserver.env" entrypoint: ["sh", "mqnamesrv"] broker-master-a: image: apache/rocketmq:5.1.4 container_name: broker-master-a restart: no stop_grace_period: 5s depends_on: - rocket-nameserver networks: - muzhi-cloud-net volumes: - "D:/WorkSpace/rocketmq/docker-home/broker-master-a/store:/rocketmq/store" - "D:/WorkSpace/rocketmq/docker-home/broker-master-a/logs:/rocketmq/logs" - "D:/WorkSpace/rocketmq/docker-home/conf/broker-master-a.conf:/rocketmq/conf/broker.conf" #ports: # - "10909:10909" # - "10911:10911" # - "10912:10912" env_file: - "conf/broker.env" entrypoint: ["sh", "mqbroker", "-c", "/rocketmq/conf/broker.conf"] broker-slave-a01: image: apache/rocketmq:5.1.4 container_name: broker-slave-a01 restart: no stop_grace_period: 5s depends_on: - rocket-nameserver networks: - muzhi-cloud-net volumes: - "D:/WorkSpace/rocketmq/docker-home/broker-slave-a01/store:/rocketmq/store" - "D:/WorkSpace/rocketmq/docker-home/broker-slave-a01/logs:/rocketmq/logs" - "D:/WorkSpace/rocketmq/docker-home/conf/broker-slave-a01.conf:/rocketmq/conf/broker.conf" #ports: # - "11909:11909" # - "11911:11911" # - "11912:11912" env_file: - "conf/broker.env" entrypoint: ["sh", "mqbroker", "-c", "/rocketmq/conf/broker.conf"] broker-master-b: image: apache/rocketmq:5.1.4 container_name: broker-master-b restart: no stop_grace_period: 5s depends_on: - rocket-nameserver networks: - muzhi-cloud-net volumes: - "D:/WorkSpace/rocketmq/docker-home/broker-master-b/store:/rocketmq/store" - "D:/WorkSpace/rocketmq/docker-home/broker-master-b/logs:/rocketmq/logs" - "D:/WorkSpace/rocketmq/docker-home/conf/broker-master-b.conf:/rocketmq/conf/broker.conf" #ports: # - "12909:12909" # - "12911:12911" # - "12912:12912" env_file: - "conf/broker.env" entrypoint: ["sh", "mqbroker", "-c", "/rocketmq/conf/broker.conf"] broker-slave-b01: image: apache/rocketmq:5.1.4 container_name: broker-slave-b01 restart: no stop_grace_period: 5s depends_on: - rocket-nam
[GH] (rocketmq): Workflow run "PUSH-CI" is working again!
The GitHub Actions job "PUSH-CI" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 609196890765b89116e12745279d287b91eae2ee / Colin Lee [ISSUE #8124] Avoid scheduled tasks exiting because of unknown exceptions Signed-off-by: Colin Lee Co-authored-by: lirui Report URL: https://github.com/apache/rocketmq/actions/runs/9060562540 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 71c9b02f9325bfcddb25167360ee5b94890f5296 / zhouxiang Set bloomFilterData for ConsumerFilterData When pop or pull Report URL: https://github.com/apache/rocketmq/actions/runs/9059989705 With regards, GitHub Actions via GitBox
(rocketmq) branch develop updated: [ISSUE #8124] Avoid scheduled tasks exiting because of unknown exceptions
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 6091968907 [ISSUE #8124] Avoid scheduled tasks exiting because of
unknown exceptions
6091968907 is described below
commit 609196890765b89116e12745279d287b91eae2ee
Author: Colin Lee
AuthorDate: Mon May 13 17:29:51 2024 +0800
[ISSUE #8124] Avoid scheduled tasks exiting because of unknown exceptions
Signed-off-by: Colin Lee
Co-authored-by: lirui
---
.../org/apache/rocketmq/broker/schedule/ScheduleMessageService.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/schedule/ScheduleMessageService.java
b/broker/src/main/java/org/apache/rocketmq/broker/schedule/ScheduleMessageService.java
index ef7e4f6789..e13b36df91 100644
---
a/broker/src/main/java/org/apache/rocketmq/broker/schedule/ScheduleMessageService.java
+++
b/broker/src/main/java/org/apache/rocketmq/broker/schedule/ScheduleMessageService.java
@@ -224,7 +224,7 @@ public class ScheduleMessageService extends ConfigManager {
result = result && this.correctDelayOffset();
return result;
}
-
+
public boolean loadWhenSyncDelayOffset() {
boolean result = super.load();
result = result && this.parseDelayLevel();
@@ -377,7 +377,7 @@ public class ScheduleMessageService extends ConfigManager {
if (isStarted()) {
this.executeOnTimeUp();
}
-} catch (Exception e) {
+} catch (Throwable e) {
// XXX: warn and notify me
log.error("ScheduleMessageService, executeOnTimeUp exception",
e);
this.scheduleNextTimerTask(this.offset, DELAY_FOR_A_PERIOD);
Re: [PR] [ISSUE #8124] Avoid scheduled tasks exiting because of unknown exceptions [rocketmq]
RongtongJin merged PR #8121: URL: https://github.com/apache/rocketmq/pull/8121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] scheduled tasks exiting because of OutOfDirectMemoryError [rocketmq]
RongtongJin closed issue #8124: [Bug] scheduled tasks exiting because of OutOfDirectMemoryError URL: https://github.com/apache/rocketmq/issues/8124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: b25980fe08232a3513720032e95c81ba60ed945d / zhouxiang Add unit test for MQClientAPIExtTest Report URL: https://github.com/apache/rocketmq/actions/runs/9059530839 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8123] Support bitmap filter for Static Subscription [rocketmq]
codecov-commenter commented on PR #8125: URL: https://github.com/apache/rocketmq/pull/8125#issuecomment-2107057022 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8125?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `15.78947%` with `32 lines` in your changes are missing coverage. Please review. > Project coverage is 42.86%. Comparing base [(`159a603`)](https://app.codecov.io/gh/apache/rocketmq/commit/159a603219e363e5f991a0c85213f6dc13f0a9be?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`71c9b02`)](https://app.codecov.io/gh/apache/rocketmq/pull/8125?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8125?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...a/org/apache/rocketmq/broker/BrokerController.java](https://app.codecov.io/gh/apache/rocketmq/pull/8125?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2FBrokerController.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh) | 0.00% | [10 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ocketmq/broker/processor/AdminBrokerProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/8125?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Fprocessor%2FAdminBrokerProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0FkbWluQnJva2VyUHJvY2Vzc29yLmphdmE=) | 0.00% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rocketmq/broker/processor/PopMessageProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/8125?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Fprocessor%2FPopMessageProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BvcE1lc3NhZ2VQcm9jZXNzb3IuamF2YQ==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...roker/client/DefaultConsumerIdsChangeListener.java](https://app.codecov.io/gh/apache/rocketmq/pull/8125?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Fclient%2FDefaultConsumerIdsChangeListener.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvY2xpZW50L0RlZmF1bHRDb25zdW1lcklkc0NoYW5nZUxpc3RlbmVyLmphdmE=) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ocketmq/broker/processor/PullMessageProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/8125?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Fprocessor%2FPullMessageProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1B1bGxNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../rocketmq/broker/filter/ConsumerFilterManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/8125?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Ffilter%2FConsumerFilterManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyL0NvbnN1bWVyRmlsdGVyTWFuYWdlci5qYXZh) | 66.66% | [0 Missing and 1 par
[GH] (rocketmq-clients): Workflow run "Node.js Coverage" failed!
The GitHub Actions job "Node.js Coverage" on rocketmq-clients.git has failed. Run started by GitHub user zhaohai666 (triggered by panzhi33). Head commit for run: 4f82c90c615b09d9b8189b848366f09a9eab3881 / zh378814 update format Report URL: https://github.com/apache/rocketmq-clients/actions/runs/9060204493 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 71c9b02f9325bfcddb25167360ee5b94890f5296 / zhouxiang Set bloomFilterData for ConsumerFilterData When pop or pull Report URL: https://github.com/apache/rocketmq/actions/runs/9059989695 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Node.js Coverage" failed!
The GitHub Actions job "Node.js Coverage" on rocketmq-clients.git has failed. Run started by GitHub user zhaohai666 (triggered by RongtongJin). Head commit for run: 3df10a5c50e67fe1045f670b1bc6f6f415683331 / zh378814 update format and single quotes Report URL: https://github.com/apache/rocketmq-clients/actions/runs/9059768222 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 71c9b02f9325bfcddb25167360ee5b94890f5296 / zhouxiang Set bloomFilterData for ConsumerFilterData When pop or pull Report URL: https://github.com/apache/rocketmq/actions/runs/9059989695 With regards, GitHub Actions via GitBox
[PR] [ISSUE #8123] Support bitmap filter for Static Subscription [rocketmq]
drpmma opened a new pull request, #8125: URL: https://github.com/apache/rocketmq/pull/8125 ### Which Issue(s) This PR Fixes Fixes #8123 ### Brief Description Support bitmap filter for Static Subscription ### How Did You Test This Change? Integration test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] scheduled tasks exiting because of OutOfDirectMemoryError [rocketmq]
colin719 opened a new issue, #8124: URL: https://github.com/apache/rocketmq/issues/8124 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment OS: ubuntu lts 22.04 ### RocketMQ version branch 4.9.x / develop ### JDK Version jdk8 later ### Describe the Bug If a memory overflow error occurs when DeliverDelayedMessageTimerTask executes executeOnTimeUp, the task cannot continue to be registered for execution. As a result, delayed messages, retrieval messages, etc. will no longer be distributed. ### Steps to Reproduce Modify the jvm parameters, set a smaller direct-memory memory, and continuously send delay or retry messages. If the accumulation reaches a certain level, similar errors may occur. ### What Did You Expect to See? Print error log, but do not exit DeliverDelayedMessageTimerTask ### What Did You See Instead? DeliverDelayedMessageTimerTask exit forever ### Additional Context    -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Enhancement] Support bitmap filter for Static Subscription [rocketmq]
drpmma opened a new issue, #8123: URL: https://github.com/apache/rocketmq/issues/8123 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary 1. Support bitmap filter for Static Subscription ### Motivation Support bitmap filter for Static Subscription ### Describe the Solution You'd Like Support bitmap filter for Static Subscription ### Describe Alternatives You've Considered No ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: b25980fe08232a3513720032e95c81ba60ed945d / zhouxiang Add unit test for MQClientAPIExtTest Report URL: https://github.com/apache/rocketmq/actions/runs/9059530842 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8070] Optimize the submitConsumeRequest and remove unnecessary exception catching [rocketmq]
drpmma commented on code in PR #8071:
URL: https://github.com/apache/rocketmq/pull/8071#discussion_r1598084837
##
client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java:
##
@@ -190,35 +189,11 @@ public void submitConsumeRequest(
final MessageQueue messageQueue,
final boolean dispatchToConsume) {
final int consumeBatchSize =
this.defaultMQPushConsumer.getConsumeMessageBatchMaxSize();
-if (msgs.size() <= consumeBatchSize) {
-ConsumeRequest consumeRequest = new ConsumeRequest(msgs,
processQueue, messageQueue);
-try {
-this.consumeExecutor.submit(consumeRequest);
-} catch (RejectedExecutionException e) {
-this.submitConsumeRequestLater(consumeRequest);
-}
-} else {
-for (int total = 0; total < msgs.size(); ) {
-List msgThis = new ArrayList<>(consumeBatchSize);
-for (int i = 0; i < consumeBatchSize; i++, total++) {
-if (total < msgs.size()) {
-msgThis.add(msgs.get(total));
-} else {
-break;
-}
-}
-
-ConsumeRequest consumeRequest = new ConsumeRequest(msgThis,
processQueue, messageQueue);
-try {
-this.consumeExecutor.submit(consumeRequest);
-} catch (RejectedExecutionException e) {
-for (; total < msgs.size(); total++) {
-msgThis.add(msgs.get(total));
-}
-
-this.submitConsumeRequestLater(consumeRequest);
-}
-}
+int batch = ((msgs.size() - 1) / consumeBatchSize) + 1;
Review Comment:
This line of code could be clearer. Readability is more important than
reducing the number of lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #274]: fix startup exception [rocketmq-mqtt]
DongyuanPan commented on code in PR #276:
URL: https://github.com/apache/rocketmq-mqtt/pull/276#discussion_r1598084965
##
mqtt-ds/src/main/java/org/apache/rocketmq/mqtt/ds/meta/MetaPersistManagerSample.java:
##
@@ -64,15 +63,14 @@ public class MetaPersistManagerSample implements
MetaPersistManager {
public void init() throws MQClientException, RemotingException,
InterruptedException, MQBrokerException {
defaultMQAdminExt = MqFactory.buildDefaultMQAdminExt("MetaLoad",
serviceConf.getProperties());
defaultMQAdminExt.start();
-refreshMeta();
scheduler = new ScheduledThreadPoolExecutor(1, new
ThreadFactoryImpl("refreshMeta"));
scheduler.scheduleWithFixedDelay(() -> {
try {
refreshMeta();
} catch (Throwable t) {
logger.error("", t);
}
-}, 5, 5, TimeUnit.SECONDS);
+}, 0, 5, TimeUnit.SECONDS);
Review Comment:
NotifyManager should be ready before MetaPersistManagerSample#refreshMeta.
This change causes refreshMeta to come earlier, increasing the chance of an
error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user biningo (triggered by cserwen). Head commit for run: 91c4f433c74d8d8b6922dfbf018dd0cf0f1f5f7d / biningo Return SYSTEM_BUSY if PutMessageStatus is OS_PAGE_CACHE_BUSY Report URL: https://github.com/apache/rocketmq/actions/runs/8803572482 With regards, GitHub Actions via GitBox
