[MAVEN-BUILD] Royale-asjs - Build # 1447 - Fixed
The Apache Jenkins build system has built Royale-asjs (build #1447) Status: Fixed Check console output at https://builds.apache.org/job/Royale-asjs/1447/ to view the results.
[royale-compiler.wiki] branch master updated: Updated Eclipse Setup (markdown)
This is an automated email from the ASF dual-hosted git repository. aharui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/royale-compiler.wiki.git The following commit(s) were added to refs/heads/master by this push: new 72c34e2 Updated Eclipse Setup (markdown) 72c34e2 is described below commit 72c34e282c576ffd878f5112d56639e7a57c41c1 Author: aharui AuthorDate: Wed Dec 26 19:58:05 2018 -0800 Updated Eclipse Setup (markdown) --- Eclipse-Setup.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Eclipse-Setup.md b/Eclipse-Setup.md index 2b430ab..6c0fd37 100644 --- a/Eclipse-Setup.md +++ b/Eclipse-Setup.md @@ -23,7 +23,7 @@ git clone https://git-wip-us.apache.org/repos/asf/royale-compiler royale-compile cd royale-compiler git checkout develop -**B. Java SE JDK 1.7 or later**\ +**B. Java SE JDK 1.8**\ Some computers come with Java installed, but not only do you need a Java runtime (JRE) you need a Java Development Kit (JDK). To find out if you have a JDK installed run `javac -version` @@ -72,7 +72,7 @@ All of these projects should be at the top-level of the royale-compiler repo. T ## Using Eclipse -We are using Eclipse Helios for Java 1.6 compatibility because at least one of the jars (flex-compiler-oem) needs to be 1.6 compatible to work with Flash Builder. +We are using Eclipse 20181210 for Java 1.8 compatibility. In theory, any version of Eclipse that supports Java 1.8 should work. ### Run/Debug Configurations @@ -95,4 +95,4 @@ VM Arguments: `-Xmx384m -Dsun.io.useCanonCaches=false -Droyalelib="/Users/myusername/git/apache/royale/royale-asjs/frameworks"` And the environment variables (Only required for SWF Output): -PLAYERGLOBAL_HOME points to the folder containing versions of playerglobal.swc as specified above. Thus, if you followed the instructions above on a Mac, you would set the variable to: /Users/myusername/adobe/flashplayer. +PLAYERGLOBAL_HOME points to the folder containing versions of playerglobal.swc as specified above. Thus, if you followed the instructions above on a Mac, you would set the variable to: /Users/myusername/adobe/flashplayer. \ No newline at end of file
[MAVEN-BUILD] Royale-asjs - Build # 1446 - Still Failing
The Apache Jenkins build system has built Royale-asjs (build #1446) Status: Still Failing Check console output at https://builds.apache.org/job/Royale-asjs/1446/ to view the results.
[royale-typedefs] branch develop updated: gee i thought I'd changed this
This is an automated email from the ASF dual-hosted git repository. aharui pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-typedefs.git The following commit(s) were added to refs/heads/develop by this push: new 226c664 gee i thought I'd changed this 226c664 is described below commit 226c6648f97b8539c5a7dadbbe117f697ab772cd Author: Alex Harui AuthorDate: Wed Dec 26 18:16:58 2018 -0800 gee i thought I'd changed this --- js/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/pom.xml b/js/pom.xml index 71b6f8d..1572249 100644 --- a/js/pom.xml +++ b/js/pom.xml @@ -59,7 +59,7 @@ com.google.javascript closure-compiler-externs -v20170626 +v20181210
[royale-asjs] branch develop updated: clean up some warnings
This is an automated email from the ASF dual-hosted git repository. aharui pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new 11cd8dd clean up some warnings 11cd8dd is described below commit 11cd8ddea0311ec0ee2c841b4e213f27a62fc62d Author: Alex Harui AuthorDate: Wed Dec 26 17:55:17 2018 -0800 clean up some warnings --- .../VirtualDataItemRendererFactoryForICollectionViewData.as | 4 ++-- .../projects/SparkRoyale/src/main/royale/spark/components/Group.as | 6 -- .../main/royale/spark/layouts/supportClasses/LayoutElementHelper.as | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/listClasses/VirtualDataItemRendererFactoryForICollectionViewData.as b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/listClasses/VirtualDataItemRendererFactoryForICollectionViewData.as index 20a5a5f..14520b2 100644 --- a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/listClasses/VirtualDataItemRendererFactoryForICollectionViewData.as +++ b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/listClasses/VirtualDataItemRendererFactoryForICollectionViewData.as @@ -153,11 +153,11 @@ package mx.controls.listClasses cursor = dp.createCursor(); } +var view:IListView = (_strand as IStrandWithModelView).view as IListView; +var dataGroup:IItemRendererParent = view.dataGroup; ir = itemRendererFactory.createItemRenderer(dataGroup) as ISelectableItemRenderer; var dataItemRenderer:DataItemRenderer = ir as DataItemRenderer; -var view:IListView = (_strand as IStrandWithModelView).view as IListView; -var dataGroup:IItemRendererParent = view.dataGroup; dataGroup.addItemRendererAt(ir, elementIndex); ir.index = index; ir.labelField = labelField; diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Group.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Group.as index 4e2250c..34610f2 100644 --- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Group.as +++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Group.as @@ -498,13 +498,15 @@ public class Group extends GroupBase /*implements IVisualElementContainer, // if there's old content and it's different than what // we're trying to set it to, then let's remove all the old // elements first. +/* if (_mxmlContent != null && _mxmlContent != value) { -/*for (i = _mxmlContent.length - 1; i >= 0; i--) +for (i = _mxmlContent.length - 1; i >= 0; i--) { elementRemoved(_mxmlContent[i], i); -}*/ +} } +*/ _mxmlContent = (value) ? value.concat() : null; // defensive copy diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/layouts/supportClasses/LayoutElementHelper.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/layouts/supportClasses/LayoutElementHelper.as index f15b056..ceec9d7 100644 --- a/frameworks/projects/SparkRoyale/src/main/royale/spark/layouts/supportClasses/LayoutElementHelper.as +++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/layouts/supportClasses/LayoutElementHelper.as @@ -80,7 +80,7 @@ public class LayoutElementHelper * so that an array is returned where the first value is * the offset (ie: 10) and the second value is * the boundary (ie: "col1") - * @arg result : optional Array to save an Array memory allocation + * @param result : optional Array to save an Array memory allocation */ public static function parseConstraintExp(val:Object, result:Array=null):Array {
[royale-asjs] 02/02: fix warnings and errors in these files
This is an automated email from the ASF dual-hosted git repository. aharui pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git commit 4ba958cc896c244467fad3d213ecbe4893d0e0a9 Author: Alex Harui AuthorDate: Wed Dec 26 17:50:57 2018 -0800 fix warnings and errors in these files --- .../apache/royale/storage/file/DataInputStream.as | 2 +- .../apache/royale/storage/file/DataOutputStream.as | 21 +- .../providers/AndroidExternalStorageProvider.as| 78 +++-- .../royale/storage/providers/WebStorageProvider.as | 80 -- 4 files changed, 136 insertions(+), 45 deletions(-) diff --git a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataInputStream.as b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataInputStream.as index 695a34e..ef0ce54 100644 --- a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataInputStream.as +++ b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataInputStream.as @@ -67,7 +67,7 @@ public class DataInputStream extends EventDispatcher implements IDataInput var self:DataInputStream = this; - _fileReader.onloadend = function (e):void { + _fileReader.onloadend = function (e:Event):void { var streamEvent:FileEvent = new FileEvent("READ"); streamEvent.stream = self; streamEvent.data = this.result; diff --git a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataOutputStream.as b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataOutputStream.as index 55eab71..f475ade 100644 --- a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataOutputStream.as +++ b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataOutputStream.as @@ -67,13 +67,13 @@ public class DataOutputStream extends EventDispatcher implements IDataOutput var self:DataOutputStream = this; - _fileWriter.onwriteend = function (e):void { + _fileWriter.onwriteend = function (e:Event):void { var newEvent:FileEvent = new FileEvent("WRITE"); newEvent.stream = self; _target.dispatchEvent(newEvent); }; - _fileWriter.onerror = function (e):void { + _fileWriter.onerror = function (e:Event):void { var newEvent:FileErrorEvent = new FileErrorEvent("ERROR"); newEvent.stream = self; newEvent.errorMessage = "Failed to write the file."; @@ -117,7 +117,7 @@ public class DataOutputStream extends EventDispatcher implements IDataOutput public function writeText(text:String):void { COMPILE::JS { - var blob:Blob = new Blob([text], { type: 'text/plain' } as BlobPropertyBag); + var blob:Blob = new Blob([text], new BlobPlainTextOptions()); _fileWriter.write(blob); } COMPILE::SWF { @@ -163,3 +163,18 @@ public class DataOutputStream extends EventDispatcher implements IDataOutput } } + +COMPILE::JS +class BlobPlainTextOptions implements BlobPropertyBag +{ +public function get type():String +{ +return "text/plain"; +} + +public function set type(value:String):void +{ + +} +} + diff --git a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/AndroidExternalStorageProvider.as b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/AndroidExternalStorageProvider.as index cf05a73..22f9be9 100644 --- a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/AndroidExternalStorageProvider.as +++ b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/AndroidExternalStorageProvider.as @@ -98,10 +98,10 @@ package org.apache.royale.storage.providers COMPILE::JS { var fullPath:String = String(cordova["file"]["dataDirectory"]) + fileName; - window.resolveLocalFileSystemURL(fullPath, function (fileEntry):void { - fileEntry.file(function (file):void { + window.resolveLocalFileSystemURL(fullPath, function (fileEntry:FileEntry):void { +
[royale-asjs] 01/02: upgrade to Closure Library 20180910
This is an automated email from the ASF dual-hosted git repository. aharui pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git commit 9240cac14ce92cd1bbec95c56180c03a455964ee Author: Alex Harui AuthorDate: Wed Dec 26 17:50:31 2018 -0800 upgrade to Closure Library 20180910 --- frameworks/downloads.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frameworks/downloads.xml b/frameworks/downloads.xml index 5ba50bf..66dc783 100644 --- a/frameworks/downloads.xml +++ b/frameworks/downloads.xml @@ -262,7 +262,7 @@ - https://github.com/google/closure-library/archive/v20170910.zip"; + https://github.com/google/closure-library/archive/v20180910.zip"; dest="${download.dir}/google-closure-library-master.zip" verbose="false" ignoreerrors="true"/>
[royale-asjs] branch develop updated (5e017a3 -> 4ba958c)
This is an automated email from the ASF dual-hosted git repository. aharui pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git. from 5e017a3 committed this file by mistake new 9240cac upgrade to Closure Library 20180910 new 4ba958c fix warnings and errors in these files The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: frameworks/downloads.xml | 2 +- .../apache/royale/storage/file/DataInputStream.as | 2 +- .../apache/royale/storage/file/DataOutputStream.as | 21 +- .../providers/AndroidExternalStorageProvider.as| 78 +++-- .../royale/storage/providers/WebStorageProvider.as | 80 -- 5 files changed, 137 insertions(+), 46 deletions(-)
[royale-compiler] branch develop updated: Closure Compiler does not like our custom namespace output format that uses bracket syntax, so reformat the names so we don't need brackets. This should also
This is an automated email from the ASF dual-hosted git repository. aharui pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-compiler.git The following commit(s) were added to refs/heads/develop by this push: new 2be08f7 Closure Compiler does not like our custom namespace output format that uses bracket syntax, so reformat the names so we don't need brackets. This should also let the debugger call stacks show the decorated name of the identifier, which will make the call stacks make more sense 2be08f7 is described below commit 2be08f7cc99a7aca2e48cf69985b138bb5a71800 Author: Alex Harui AuthorDate: Wed Dec 26 17:49:04 2018 -0800 Closure Compiler does not like our custom namespace output format that uses bracket syntax, so reformat the names so we don't need brackets. This should also let the debugger call stacks show the decorated name of the identifier, which will make the call stacks make more sense --- .../codegen/typedefs/TypedefsTestUtils.java| 1 - .../internal/codegen/js/jx/AccessorEmitter.java| 28 +++--- .../internal/codegen/js/jx/IdentifierEmitter.java | 6 ++--- .../internal/codegen/js/jx/SuperCallEmitter.java | 16 +++-- .../codegen/js/royale/JSRoyaleEmitter.java | 18 -- .../codegen/js/royale/TestRoyaleAccessors.java | 8 +++ .../codegen/js/royale/TestRoyaleClass.java | 12 +- .../codegen/js/royale/TestRoyaleExpressions.java | 6 ++--- .../codegen/js/royale/TestRoyaleFieldMembers.java | 2 +- .../codegen/js/royale/TestRoyaleMethodMembers.java | 2 +- 10 files changed, 51 insertions(+), 48 deletions(-) diff --git a/compiler-externc/src/test/java/org/apache/royale/compiler/internal/codegen/typedefs/TypedefsTestUtils.java b/compiler-externc/src/test/java/org/apache/royale/compiler/internal/codegen/typedefs/TypedefsTestUtils.java index 87daab5..0378c14 100644 --- a/compiler-externc/src/test/java/org/apache/royale/compiler/internal/codegen/typedefs/TypedefsTestUtils.java +++ b/compiler-externc/src/test/java/org/apache/royale/compiler/internal/codegen/typedefs/TypedefsTestUtils.java @@ -174,7 +174,6 @@ public class TypedefsTestUtils config.addTypedef(coreRoot + "/browser/whatwg_encoding.js"); -config.addTypedef(coreRoot + "/browser/chrome.js"); //config.addTypedef(coreRoot + "/browser/fetchapi.js"); config.addTypedef(coreRoot + "/browser/fileapi.js"); config.addTypedef(coreRoot + "/browser/flash.js"); diff --git a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/AccessorEmitter.java b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/AccessorEmitter.java index 8f5bdce..428f542 100644 --- a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/AccessorEmitter.java +++ b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/AccessorEmitter.java @@ -117,7 +117,7 @@ public class AccessorEmitter extends JSSubEmitter implements INamespaceDefinition nsDef = (INamespaceDefinition)ns.resolve(project); fjs.formatQualifiedName(nsDef.getQualifiedName()); // register with used names String s = nsDef.getURI(); - write("[\"" + s + "::" + propName + "\"]"); + write(JSRoyaleEmitter.formatNamespacedProperty(s, propName, true)); } else { @@ -143,7 +143,7 @@ public class AccessorEmitter extends JSSubEmitter implements INamespaceDefinition nsDef = (INamespaceDefinition)ns.resolve(project); fjs.formatQualifiedName(nsDef.getQualifiedName()); // register with used names String s = nsDef.getURI(); - write("[\"" + s + "::" + JSRoyaleEmitterTokens.GETTER_PREFIX.getToken() + propName + "\"]"); + write(JSRoyaleEmitter.formatNamespacedProperty(s, JSRoyaleEmitterTokens.GETTER_PREFIX.getToken() + propName, true)); } else { @@ -205,7 +205,7 @@ public class AccessorEmitter extends JSSubEmitter implements INamespaceDefinition nsDef = (INamespaceDefinition)ns.resolve(project); fjs.formatQualifiedName(nsDef.getQualifiedName()); // register with used names String s = nsDef.getURI(); - write("[\"" + s + "::" + JSRoyaleEmitterTokens.SETTER_PREFIX.getToken() + propName + "\"]"); + write(JSRoyaleEmitter.formatNamespacedProperty(s, JSRoy
[MAVEN-BUILD] Royale-asjs - Build # 1445 - Still Failing
The Apache Jenkins build system has built Royale-asjs (build #1445) Status: Still Failing Check console output at https://builds.apache.org/job/Royale-asjs/1445/ to view the results.
[royale-asjs] branch develop updated: committed this file by mistake
This is an automated email from the ASF dual-hosted git repository. carlosrovira pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new 5e017a3 committed this file by mistake 5e017a3 is described below commit 5e017a3c6e10804831200d082a9c87349acdbb9e Author: Carlos Rovira AuthorDate: Thu Dec 27 01:38:52 2018 +0100 committed this file by mistake --- pom.xml | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/pom.xml b/pom.xml index 3c08281..21c0c95 100644 --- a/pom.xml +++ b/pom.xml @@ -77,23 +77,10 @@ - - -sgc -http://maven.codeoscopic.com/content/repositories/sgc - - -sgc-snaps - http://maven.codeoscopic.com/content/repositories/sgc-snaps -true - - -sgc-site -dav:http://dav.codeoscopic.com/private/sites/sgc - +
[royale-asjs] branch develop updated: latest two examples updated with tabs for example and source code
This is an automated email from the ASF dual-hosted git repository. carlosrovira pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new b73a705 latest two examples updated with tabs for example and source code b73a705 is described below commit b73a7050876688d9449d20e02305d81d47bfb5a5 Author: Carlos Rovira AuthorDate: Thu Dec 27 01:24:43 2018 +0100 latest two examples updated with tabs for example and source code --- .../src/main/royale/MiscelaneaPlayGound.mxml | 68 --- .../src/main/royale/WelcomeSection.mxml| 99 -- 2 files changed, 89 insertions(+), 78 deletions(-) diff --git a/examples/royale/TourDeJewel/src/main/royale/MiscelaneaPlayGound.mxml b/examples/royale/TourDeJewel/src/main/royale/MiscelaneaPlayGound.mxml index 8eff691..4b94a01 100644 --- a/examples/royale/TourDeJewel/src/main/royale/MiscelaneaPlayGound.mxml +++ b/examples/royale/TourDeJewel/src/main/royale/MiscelaneaPlayGound.mxml @@ -17,39 +17,45 @@ See the License for the specific language governing permissions and limitations under the License. --> -http://ns.adobe.com/mxml/2009"; - xmlns:j="library://ns.apache.org/royale/jewel" - xmlns:js="library://ns.apache.org/royale/basic" - xmlns:html="library://ns.apache.org/royale/html"> - +http://ns.adobe.com/mxml/2009"; + xmlns:j="library://ns.apache.org/royale/jewel" + xmlns:html="library://ns.apache.org/royale/html" + xmlns:js="library://ns.apache.org/royale/basic" + xmlns:c="components.*" + sourceCodeUrl="MiscelaneaPlayGound.mxml"> - - - - - - - - - - - - - - - - + + + + + - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + - + diff --git a/examples/royale/TourDeJewel/src/main/royale/WelcomeSection.mxml b/examples/royale/TourDeJewel/src/main/royale/WelcomeSection.mxml index 65d136e..b896fa4 100644 --- a/examples/royale/TourDeJewel/src/main/royale/WelcomeSection.mxml +++ b/examples/royale/TourDeJewel/src/main/royale/WelcomeSection.mxml @@ -17,61 +17,66 @@ See the License for the specific language governing permissions and limitations under the License. --> -http://ns.adobe.com/mxml/2009"; -xmlns:j="library://ns.apache.org/royale/jewel" -xmlns:js="library://ns.apache.org/royale/basic" -xmlns:html="library://ns.apache.org/royale/html"> - - - +http://ns.adobe.com/mxml/2009"; + xmlns:j="library://ns.apache.org/royale/jewel" + xmlns:html="library://ns.apache.org/royale/html" + xmlns:js="library://ns.apache.org/royale/basic" + xmlns:c="components.*" + sourceCodeUrl="WelcomeSection.mxml"> + - - - - - - - - -https://royale.apache.org'>https://royale.apache.org"> + - - + - + + + + + + + + - - - - - - - - - +https://royale.apache.org'>https://royale.apache.org"> - - + + - - - - - + + + - + + - - - - - - + + + + + + + + + +
[MAVEN-BUILD] Royale-asjs - Build # 1444 - Still Failing
The Apache Jenkins build system has built Royale-asjs (build #1444) Status: Still Failing Check console output at https://builds.apache.org/job/Royale-asjs/1444/ to view the results.
[royale-asjs] branch develop updated: add link to Gihub source code that opens in a new browser tab
This is an automated email from the ASF dual-hosted git repository. carlosrovira pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new 017e16e add link to Gihub source code that opens in a new browser tab 017e16e is described below commit 017e16e397bdc7c84b39a14e55646239a0f8f8f0 Author: Carlos Rovira AuthorDate: Thu Dec 27 01:14:26 2018 +0100 add link to Gihub source code that opens in a new browser tab --- .../royale/components/ExampleAndSourceCodeTabbedSectionContent.as | 8 1 file changed, 8 insertions(+) diff --git a/examples/royale/TourDeJewel/src/main/royale/components/ExampleAndSourceCodeTabbedSectionContent.as b/examples/royale/TourDeJewel/src/main/royale/components/ExampleAndSourceCodeTabbedSectionContent.as index c7e5688..4042bd0 100644 --- a/examples/royale/TourDeJewel/src/main/royale/components/ExampleAndSourceCodeTabbedSectionContent.as +++ b/examples/royale/TourDeJewel/src/main/royale/components/ExampleAndSourceCodeTabbedSectionContent.as @@ -35,6 +35,7 @@ package components import org.apache.royale.utils.MXMLDataInterpreter; import org.apache.royale.core.IContainerBaseStrandChildrenHost; import org.apache.royale.core.IChild; +import org.apache.royale.html.elements.A; [DefaultProperty("mxmlContent")] @@ -69,6 +70,7 @@ package components private var sourceCodeMXMLText:Code; private var sourceCodeUrlPrefix:String = "https://api.github.com/repos/apache/royale-asjs/contents/examples/royale/TourDeJewel/src/main/royale/";; +private var sourceCodeUrlWebPrefix:String = "https://github.com/apache/royale-asjs/blob/develop/examples/royale/TourDeJewel/src/main/royale/";; private var _sourceCodeUrl:String; /** @@ -98,6 +100,12 @@ package components sourceCodeTab = new SectionContent(); sourceCodeTab.name = "sourceCodeTab"; +var link:A = new A(); +link.href = sourceCodeUrlWebPrefix + sourceCodeUrl; +link.text = "Source code in GitHub"; +link.target = "_blank"; +link.rel = "noreferrer noopener" +sourceCodeTab.addElement(link); var pre:Pre = new Pre(); sourceCodeMXMLText = new Code(); sourceCodeMXMLText.className = "xml codeExample";
[royale-asjs] branch develop updated: add attributes "target" and "rel" to html anchor component (A)
This is an automated email from the ASF dual-hosted git repository. carlosrovira pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new ead14ed add attributes "target" and "rel" to html anchor component (A) ead14ed is described below commit ead14eda2d6a92e96a16bd976325ae2c9326d807 Author: Carlos Rovira AuthorDate: Thu Dec 27 01:13:46 2018 +0100 add attributes "target" and "rel" to html anchor component (A) --- .../royale/org/apache/royale/html/elements/A.as| 47 ++ 1 file changed, 47 insertions(+) diff --git a/frameworks/projects/HTML/src/main/royale/org/apache/royale/html/elements/A.as b/frameworks/projects/HTML/src/main/royale/org/apache/royale/html/elements/A.as index ae3752f..7d81c51 100644 --- a/frameworks/projects/HTML/src/main/royale/org/apache/royale/html/elements/A.as +++ b/frameworks/projects/HTML/src/main/royale/org/apache/royale/html/elements/A.as @@ -72,6 +72,53 @@ package org.apache.royale.html.elements element.setAttribute('href', value); } } + + private var _target:String = "_self"; +/** + * the target attribute. Defaults to "_self" +* Other options "_blank", "_parent", "_top" + * + * @langversion 3.0 + * @playerversion Flash 10.2 + * @playerversion AIR 2.6 + * @productversion Royale 0.9.6 + */ + public function get target():String + { +return _target; + } + public function set target(value:String):void + { +_target = value; + +COMPILE::JS +{ +element.setAttribute('target', value); +} + } + + private var _rel:String = ""; +/** + * The rel attribute specifies the relationship between the current document and the linked document. + * + * @langversion 3.0 + * @playerversion Flash 10.2 + * @playerversion AIR 2.6 + * @productversion Royale 0.9.6 + */ + public function get rel():String + { +return _rel; + } + public function set rel(value:String):void + { +_rel = value; + +COMPILE::JS +{ +element.setAttribute('rel', value); +} + } COMPILE::JS override protected function createElement():WrappedHTMLElement
[MAVEN-BUILD] Royale-asjs - Build # 1443 - Still Failing
The Apache Jenkins build system has built Royale-asjs (build #1443) Status: Still Failing Check console output at https://builds.apache.org/job/Royale-asjs/1443/ to view the results.
[royale-asjs] branch develop updated: Make all example pages in Tour de Jewel have tabs one for the example and other for the source code in github
This is an automated email from the ASF dual-hosted git repository. carlosrovira pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new b99966a Make all example pages in Tour de Jewel have tabs one for the example and other for the source code in github b99966a is described below commit b99966ae8e753ba42918aa9013497ae7cf3c87b5 Author: Carlos Rovira AuthorDate: Wed Dec 26 19:30:59 2018 +0100 Make all example pages in Tour de Jewel have tabs one for the example and other for the source code in github --- .../src/main/royale/ButtonPlayGround.mxml | 13 ++-- .../src/main/royale/CardPlayGround.mxml| 12 ++- .../src/main/royale/CheckBoxPlayGround.mxml| 12 ++- .../src/main/royale/ComboBoxPlayGround.mxml| 15 +++--- .../src/main/royale/DateComponentsPlayGround.mxml | 13 ++-- .../src/main/royale/DropDownListPlayGround.mxml| 16 +++ .../src/main/royale/FormsValidationPlayGround.mxml | 16 +++ .../src/main/royale/GridPlayGround.mxml| 14 ++--- .../src/main/royale/HeadingsAndText.mxml | 12 ++- .../src/main/royale/ImagePlayGround.mxml | 13 ++-- .../src/main/royale/LabelPlayGround.mxml | 12 ++- .../src/main/royale/LayoutsPlayGround.mxml | 13 ++-- .../src/main/royale/ListPlayGround.mxml| 15 +++--- .../src/main/royale/NumericStepperPlayGround.mxml | 12 ++- .../src/main/royale/RadioButtonPlayGround.mxml | 12 ++- .../src/main/royale/SliderPlayGround.mxml | 13 ++-- .../src/main/royale/SnackbarPlayGround.mxml| 12 ++- .../src/main/royale/TabBarPlayGround.mxml | 13 ++-- .../src/main/royale/TablePlayGround.mxml | 15 +++--- .../src/main/royale/TextInputPlayGround.mxml | 13 ++-- .../src/main/royale/ViewStatesPlayGround.mxml | 23 +- .../src/main/royale/WizardPlayGround.mxml | 16 +++ 22 files changed, 162 insertions(+), 143 deletions(-) diff --git a/examples/royale/TourDeJewel/src/main/royale/ButtonPlayGround.mxml b/examples/royale/TourDeJewel/src/main/royale/ButtonPlayGround.mxml index b83a67d..8190ecd 100644 --- a/examples/royale/TourDeJewel/src/main/royale/ButtonPlayGround.mxml +++ b/examples/royale/TourDeJewel/src/main/royale/ButtonPlayGround.mxml @@ -17,11 +17,12 @@ See the License for the specific language governing permissions and limitations under the License. --> -http://ns.adobe.com/mxml/2009"; - xmlns:j="library://ns.apache.org/royale/jewel" - xmlns:html="library://ns.apache.org/royale/html" - xmlns:js="library://ns.apache.org/royale/basic"> - +http://ns.adobe.com/mxml/2009"; + xmlns:j="library://ns.apache.org/royale/jewel" + xmlns:html="library://ns.apache.org/royale/html" + xmlns:js="library://ns.apache.org/royale/basic" + xmlns:c="components.*" + sourceCodeUrl="ButtonPlayGround.mxml"> - + diff --git a/examples/royale/TourDeJewel/src/main/royale/TextInputPlayGround.mxml b/examples/royale/TourDeJewel/src/main/royale/TextInputPlayGround.mxml index 031efb8..2be75e1 100644 --- a/examples/royale/TourDeJewel/src/main/royale/TextInputPlayGround.mxml +++ b/examples/royale/TourDeJewel/src/main/royale/TextInputPlayGround.mxml @@ -17,11 +17,12 @@ See the License for the specific language governing permissions and limitations under the License. --> -http://ns.adobe.com/mxml/2009"; - xmlns:j="library://ns.apache.org/royale/jewel" - xmlns:js="library://ns.apache.org/royale/basic" - xmlns:html="library://ns.apache.org/royale/html"> - +http://ns.adobe.com/mxml/2009"; + xmlns:j="library://ns.apache.org/royale/jewel" + xmlns:html="library://ns.apache.org/royale/html" + xmlns:js="library://ns.apache.org/royale/basic" + xmlns:c="components.*" + sourceCodeUrl="TextInputPlayGround.m
[MAVEN-BUILD] Royale-asjs - Build # 1442 - Still Failing
The Apache Jenkins build system has built Royale-asjs (build #1442) Status: Still Failing Check console output at https://builds.apache.org/job/Royale-asjs/1442/ to view the results.
[royale-asjs] branch develop updated: rename "activableName" to "name"
This is an automated email from the ASF dual-hosted git repository. carlosrovira pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new af5c7a2 rename "activableName" to "name" af5c7a2 is described below commit af5c7a2623ab2fc9ede6e45494f9fbf99793c554 Author: Carlos Rovira AuthorDate: Wed Dec 26 18:27:04 2018 +0100 rename "activableName" to "name" --- .../TourDeJewel/src/main/royale/MainContent.mxml | 52 +++--- .../src/main/royale/TabBarPlayGround.mxml | 8 ++-- .../src/main/royale/WizardPlayGround.mxml | 10 ++--- .../ExampleAndSourceCodeTabbedSectionContent.as| 25 +++ .../apache/royale/jewel/ApplicationMainContent.as | 6 +-- .../org/apache/royale/jewel/SectionContent.as | 31 ++--- .../org/apache/royale/jewel/TabBarContent.as | 4 +- .../org/apache/royale/jewel/WizardContent.as | 6 +-- .../royale/jewel/supportClasses/IActivable.as | 6 +-- pom.xml| 17 ++- 10 files changed, 101 insertions(+), 64 deletions(-) diff --git a/examples/royale/TourDeJewel/src/main/royale/MainContent.mxml b/examples/royale/TourDeJewel/src/main/royale/MainContent.mxml index fdd7358..a4e9952 100644 --- a/examples/royale/TourDeJewel/src/main/royale/MainContent.mxml +++ b/examples/royale/TourDeJewel/src/main/royale/MainContent.mxml @@ -120,32 +120,32 @@ limitations under the License. - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/examples/royale/TourDeJewel/src/main/royale/TabBarPlayGround.mxml b/examples/royale/TourDeJewel/src/main/royale/TabBarPlayGround.mxml index 866aef4..4d260d1 100644 --- a/examples/royale/TourDeJewel/src/main/royale/TabBarPlayGround.mxml +++ b/examples/royale/TourDeJewel/src/main/royale/TabBarPlayGround.mxml @@ -66,16 +66,16 @@ limitations under the License. - + - + - + - + diff --git a/examples/royale/TourDeJewel/src/main/royale/WizardPlayGround.mxml b/examples/royale/TourDeJewel/src/main/royale/WizardPlayGround.mxml index 61ff459..e74e71e 100644 --- a/examples/royale/TourDeJewel/src/main/royale/WizardPlayGround.mxml +++ b/examples/royale/TourDeJewel/src/main/royale/WizardPlayGround.mxml @@ -61,7 +61,7 @@ limitations under the License. - + @@ -70,7 +70,7 @@ limitations under the License. - + @@ -85,7 +85,7 @@ limitations under the License. - + @@ -99,7 +99,7 @@ limitations under the License. - + @@ -115,7 +115,7 @@ limitations under the License. - + diff --git a/examples/royale/TourDeJewel/src/main/royale/components/Exampl
[MAVEN-BUILD] Royale-asjs - Build # 1441 - Still Failing
The Apache Jenkins build system has built Royale-asjs (build #1441) Status: Still Failing Check console output at https://builds.apache.org/job/Royale-asjs/1441/ to view the results.
[royale-asjs] branch develop updated: Fix implicit coercion error
This is an automated email from the ASF dual-hosted git repository. yishayw pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new 2f127d4 Fix implicit coercion error 2f127d4 is described below commit 2f127d459ee807f197950e11af947c623c270369 Author: DESKTOP-RH4S838\Yishay AuthorDate: Wed Dec 26 16:57:33 2018 +0200 Fix implicit coercion error --- .../src/main/royale/org/apache/royale/storage/file/DataOutputStream.as | 2 +- .../apache/royale/storage/providers/AndroidExternalStorageProvider.as | 2 +- .../royale/org/apache/royale/storage/providers/WebStorageProvider.as| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataOutputStream.as b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataOutputStream.as index cff76eb..55eab71 100644 --- a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataOutputStream.as +++ b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataOutputStream.as @@ -117,7 +117,7 @@ public class DataOutputStream extends EventDispatcher implements IDataOutput public function writeText(text:String):void { COMPILE::JS { - var blob:Blob = new Blob([text], { type: 'text/plain' }); + var blob:Blob = new Blob([text], { type: 'text/plain' } as BlobPropertyBag); _fileWriter.write(blob); } COMPILE::SWF { diff --git a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/AndroidExternalStorageProvider.as b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/AndroidExternalStorageProvider.as index ea79a5b..cf05a73 100644 --- a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/AndroidExternalStorageProvider.as +++ b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/AndroidExternalStorageProvider.as @@ -199,7 +199,7 @@ package org.apache.royale.storage.providers _target.dispatchEvent(newEvent); }; - var blob:Blob = new Blob([text], { type: 'text/plain' }); + var blob:Blob = new Blob([text], { type: 'text/plain' } as BlobPropertyBag); fileWriter.write(blob); }, function(e):void { var errEvent:FileErrorEvent = new FileErrorEvent("ERROR"); diff --git a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/WebStorageProvider.as b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/WebStorageProvider.as index 1632bfa..dd9c84c 100644 --- a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/WebStorageProvider.as +++ b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/WebStorageProvider.as @@ -199,7 +199,7 @@ package org.apache.royale.storage.providers _target.dispatchEvent(newEvent); }; - var blob:Blob = new Blob([text], { type: 'text/plain' }); + var blob:Blob = new Blob([text], { type: 'text/plain' } as BlobPropertyBag); fileWriter.write(blob); }, function(e):void { var errEvent:FileErrorEvent = new FileErrorEvent("ERROR");
[MAVEN-BUILD] Royale-asjs - Build # 1440 - Still Failing
The Apache Jenkins build system has built Royale-asjs (build #1440) Status: Still Failing Check console output at https://builds.apache.org/job/Royale-asjs/1440/ to view the results.
[MAVEN-BUILD] Royale-asjs - Build # 1439 - Still Failing
The Apache Jenkins build system has built Royale-asjs (build #1439) Status: Still Failing Check console output at https://builds.apache.org/job/Royale-asjs/1439/ to view the results.
[MAVEN-BUILD] Royale-asjs - Build # 1438 - Failure
The Apache Jenkins build system has built Royale-asjs (build #1438) Status: Failure Check console output at https://builds.apache.org/job/Royale-asjs/1438/ to view the results.
[royale-asjs] branch develop updated: reorder Tour de Jewel Example menu options to be alphabetic order
This is an automated email from the ASF dual-hosted git repository. carlosrovira pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new 7eabb60 reorder Tour de Jewel Example menu options to be alphabetic order 7eabb60 is described below commit 7eabb6087bddbb5127e921148015f2de1c8df68b Author: Carlos Rovira AuthorDate: Wed Dec 26 10:53:00 2018 +0100 reorder Tour de Jewel Example menu options to be alphabetic order --- .../src/main/royale/models/MainNavigationModel.as | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/examples/royale/TourDeJewel/src/main/royale/models/MainNavigationModel.as b/examples/royale/TourDeJewel/src/main/royale/models/MainNavigationModel.as index 798d07b..a9b123a 100644 --- a/examples/royale/TourDeJewel/src/main/royale/models/MainNavigationModel.as +++ b/examples/royale/TourDeJewel/src/main/royale/models/MainNavigationModel.as @@ -27,22 +27,22 @@ package models private var _controlsDrawerNavigation:ArrayList = new ArrayList([ new NavigationLinkVO("Alert", "alert_panel", MaterialIconType.WEB_ASSET), new NavigationLinkVO("Button", "button_panel", MaterialIconType.CROP_7_5), -new NavigationLinkVO("Images", "image_panel", MaterialIconType.IMAGE), -new NavigationLinkVO("NumericStepper", "numericstepper_panel", MaterialIconType.UNFOLD_MORE), -new NavigationLinkVO("Date Components", "datecomponents_panel", MaterialIconType.DATE_RANGE), -new NavigationLinkVO("ComboBox", "combobox_panel", MaterialIconType.CREDIT_CARD), new NavigationLinkVO("CheckBox", "checkbox_panel", MaterialIconType.CHECK_BOX), +new NavigationLinkVO("ComboBox", "combobox_panel", MaterialIconType.CREDIT_CARD), +new NavigationLinkVO("Date Components", "datecomponents_panel", MaterialIconType.DATE_RANGE), +new NavigationLinkVO("DropDownList", "dropdownlist_panel", MaterialIconType.CREDIT_CARD), +new NavigationLinkVO("Forms & Validation", "form_validation_panel", MaterialIconType.ASSIGNMENT_TURNED_IN), new NavigationLinkVO("Icon", "miscelanea_panel", MaterialIconType.FACE), +new NavigationLinkVO("Images", "image_panel", MaterialIconType.IMAGE), new NavigationLinkVO("Label", "label_panel", MaterialIconType.LABEL), new NavigationLinkVO("List", "list_panel", MaterialIconType.LIST_ALT), +new NavigationLinkVO("NumericStepper", "numericstepper_panel", MaterialIconType.UNFOLD_MORE), +new NavigationLinkVO("PopUp", "popupview_panel", MaterialIconType.FLIP_TO_FRONT), new NavigationLinkVO("RadioButton", "radiobutton_panel", MaterialIconType.RADIO_BUTTON_CHECKED), new NavigationLinkVO("Slider", "slider_panel", MaterialIconType.STORAGE), -new NavigationLinkVO("Text", "text_panel", MaterialIconType.SUBJECT), -new NavigationLinkVO("TextInput", "textinput_panel", MaterialIconType.TEXT_FIELDS), -new NavigationLinkVO("Forms & Validation", "form_validation_panel", MaterialIconType.ASSIGNMENT_TURNED_IN), -new NavigationLinkVO("DropDownList", "dropdownlist_panel", MaterialIconType.CREDIT_CARD), new NavigationLinkVO("Snackbar", "snackbar_panel", MaterialIconType.VIDEO_LABEL), -new NavigationLinkVO("PopUpView", "popupview_panel", MaterialIconType.FLIP_TO_FRONT) +new NavigationLinkVO("Text", "text_panel", MaterialIconType.SUBJECT), +new NavigationLinkVO("TextInput", "textinput_panel", MaterialIconType.TEXT_FIELDS) // new NavigationLinkVO("Menu", "menus_panel"), // new NavigationLinkVO("Loading", "loading_panel") ]); @@ -52,12 +52,12 @@ package models } private var _containerDrawerNavigation:ArrayList = new ArrayList([ -new NavigationLinkVO("View States", "viewstates_panel", MaterialIconType.FLIP_TO_FRONT), +new NavigationLinkVO("Card", "card_panel", MaterialIconType.WEB_ASSET), new NavigationLinkVO("Layouts", "layouts_panel", MaterialIconType.VIEW_QUILT), new NavigationLinkVO("Grid", "grid_panel", MaterialIconType.GRID_ON), new NavigationLinkVO("Tables", "tables_panel", MaterialIconType.VIEW_LIST), new NavigationLinkVO("TabBar", "tabbar_panel", MaterialIconType.TAB), -new NavigationLinkVO("Card", "card_panel", MaterialIconType.WEB_ASSET), +new NavigationLinkVO("View States", "viewstates_panel", MaterialIconType.FLIP_TO_FRONT), new NavigationLinkVO("Wizard", "wizards_panel", MaterialIconType.MOVIE_FILTER) // new NavigationLinkVO("Tabs", "tabs_panel") ]);
[royale-asjs] branch develop updated: new ExampleAndSourceCodeTabbedSectionContent in Tour de Jewel to have a tabbar for example/sourceCode
This is an automated email from the ASF dual-hosted git repository. carlosrovira pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new e47fc89 new ExampleAndSourceCodeTabbedSectionContent in Tour de Jewel to have a tabbar for example/sourceCode e47fc89 is described below commit e47fc89344c491122f8923041966065fbbac2a90 Author: Carlos Rovira AuthorDate: Wed Dec 26 10:52:31 2018 +0100 new ExampleAndSourceCodeTabbedSectionContent in Tour de Jewel to have a tabbar for example/sourceCode --- .../src/main/royale/AlertPlayGround.mxml | 109 ++--- .../src/main/royale/PopUpViewPlayGround.mxml | 16 +- .../ExampleAndSourceCodeTabbedSectionContent.as| 251 + 3 files changed, 284 insertions(+), 92 deletions(-) diff --git a/examples/royale/TourDeJewel/src/main/royale/AlertPlayGround.mxml b/examples/royale/TourDeJewel/src/main/royale/AlertPlayGround.mxml index eee4d69..6e12f74 100644 --- a/examples/royale/TourDeJewel/src/main/royale/AlertPlayGround.mxml +++ b/examples/royale/TourDeJewel/src/main/royale/AlertPlayGround.mxml @@ -17,12 +17,12 @@ See the License for the specific language governing permissions and limitations under the License. --> -http://ns.adobe.com/mxml/2009"; - xmlns:j="library://ns.apache.org/royale/jewel" - xmlns:js="library://ns.apache.org/royale/basic" - xmlns:html="library://ns.apache.org/royale/html" - xmlns:services="services.*"> - +http://ns.adobe.com/mxml/2009"; + xmlns:j="library://ns.apache.org/royale/jewel" + xmlns:html="library://ns.apache.org/royale/html" + xmlns:js="library://ns.apache.org/royale/basic" + xmlns:c="components.*" + sourceCodeUrl="AlertPlayGround.mxml"> -https://api.github.com/repos/apache/royale-asjs/contents/examples/royale/TourDeJewel/src/main/royale/AlertPlayGround.mxml"; -dataReady="dataReadyHandler(event)"/> - - - - - - - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + - + diff --git a/examples/royale/TourDeJewel/src/main/royale/PopUpViewPlayGround.mxml b/examples/royale/TourDeJewel/src/main/royale/PopUpViewPlayGround.mxml index ea8cde9..ffeee20 100644 --- a/examples/royale/TourDeJewel/src/main/royale/PopUpViewPlayGround.mxml +++ b/examples/royale/TourDeJewel/src/main/royale/PopUpViewPlayGround.mxml @@ -17,15 +17,15 @@ See the License for the specific language governing permissions and limitations under the License. --> -http://ns.adobe.com/mxml/2009"; - xmlns:j="library://ns.apache.org/royale/jewel" - xmlns:html="library://ns.apache.org/royale/html" - xmlns:js="library://ns.apache.org/royale/basic"> +http://ns.adobe.com/mxml/2009"; + xmlns:j="library://ns.apache.org/royale/jewel" + xmlns:html="library://ns.apache.org/royale/html" + xmlns:js="library://ns.apache.org/royale/basic" + xmlns:c="components.*" + sourceCodeUrl="PopUpViewPlayGround.mxml"> @@ -54,4 +54,4 @@ limitations under the License. - + diff --git a/examples/royale/TourDeJewel/src/main/royale/components/ExampleAndSourceCodeTabbedSectionContent.as b/examples/royale/TourDeJewel/src/main/royale/components/ExampleAndSourceCodeTabbedSectionContent.as new file mode 100644 index 000..065acfd --- /dev/null +++ b/examples/royale/TourDeJewel/src/main/royale/components/ExampleAndSourceCodeTabbedSectionCo
[royale-asjs] branch develop updated: change Tour de Jewel examples to use new activableName instead of ids
This is an automated email from the ASF dual-hosted git repository. carlosrovira pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new d858d3f change Tour de Jewel examples to use new activableName instead of ids d858d3f is described below commit d858d3f81393c218ef4f584068fd33624fa38419 Author: Carlos Rovira AuthorDate: Wed Dec 26 10:51:22 2018 +0100 change Tour de Jewel examples to use new activableName instead of ids --- .../TourDeJewel/src/main/royale/MainContent.mxml | 52 +++--- .../src/main/royale/TabBarPlayGround.mxml | 8 ++-- .../src/main/royale/WizardPlayGround.mxml | 10 ++--- 3 files changed, 35 insertions(+), 35 deletions(-) diff --git a/examples/royale/TourDeJewel/src/main/royale/MainContent.mxml b/examples/royale/TourDeJewel/src/main/royale/MainContent.mxml index 729207e..fdd7358 100644 --- a/examples/royale/TourDeJewel/src/main/royale/MainContent.mxml +++ b/examples/royale/TourDeJewel/src/main/royale/MainContent.mxml @@ -120,32 +120,32 @@ limitations under the License. - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/examples/royale/TourDeJewel/src/main/royale/TabBarPlayGround.mxml b/examples/royale/TourDeJewel/src/main/royale/TabBarPlayGround.mxml index 7e8a2c3..866aef4 100644 --- a/examples/royale/TourDeJewel/src/main/royale/TabBarPlayGround.mxml +++ b/examples/royale/TourDeJewel/src/main/royale/TabBarPlayGround.mxml @@ -66,16 +66,16 @@ limitations under the License. - + - + - + - + diff --git a/examples/royale/TourDeJewel/src/main/royale/WizardPlayGround.mxml b/examples/royale/TourDeJewel/src/main/royale/WizardPlayGround.mxml index 245b8e5..61ff459 100644 --- a/examples/royale/TourDeJewel/src/main/royale/WizardPlayGround.mxml +++ b/examples/royale/TourDeJewel/src/main/royale/WizardPlayGround.mxml @@ -61,7 +61,7 @@ limitations under the License. - + @@ -70,7 +70,7 @@ limitations under the License. - + @@ -85,7 +85,7 @@ limitations under the License. - + @@ -99,7 +99,7 @@ limitations under the License. - + @@ -115,7 +115,7 @@ limitations under the License. - +
[royale-asjs] branch develop updated: improve IActivable to not rely on ids and use new activableName property
This is an automated email from the ASF dual-hosted git repository. carlosrovira pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new f47a24a improve IActivable to not rely on ids and use new activableName property f47a24a is described below commit f47a24a6cade10a8da297f2f9cd86dc4632754e6 Author: Carlos Rovira AuthorDate: Wed Dec 26 10:50:21 2018 +0100 improve IActivable to not rely on ids and use new activableName property --- .../apache/royale/jewel/ApplicationMainContent.as | 6 +++--- .../org/apache/royale/jewel/SectionContent.as | 23 ++ .../org/apache/royale/jewel/TabBarContent.as | 6 +++--- .../org/apache/royale/jewel/WizardContent.as | 6 +++--- .../royale/jewel/supportClasses/IActivable.as | 11 +++ 5 files changed, 43 insertions(+), 9 deletions(-) diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/ApplicationMainContent.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/ApplicationMainContent.as index 21c47a0..389c209 100644 --- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/ApplicationMainContent.as +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/ApplicationMainContent.as @@ -85,14 +85,14 @@ package org.apache.royale.jewel /** * shows a concrete content and hides the rest * -* @param id, the id of the container to show +* @param activableName, the activableName of the container to show * * @langversion 3.0 * @playerversion Flash 10.2 * @playerversion AIR 2.6 * @productversion Royale 0.9.4 */ -public function showContent(id:String):void +public function showContent(activableName:String):void { try { @@ -100,7 +100,7 @@ package org.apache.royale.jewel { var content:IActivable = getElementAt(i) as IActivable; - if(content.id == id) + if(content.activableName == activableName) { content.isActive = true; } diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/SectionContent.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/SectionContent.as index 056514e..515320e 100644 --- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/SectionContent.as +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/SectionContent.as @@ -87,5 +87,28 @@ package org.apache.royale.jewel toggleClass("is-active", _isActive); } } + + private var _activableName:String; + +/** + * activableName is the name od this activable content + * + * @langversion 3.0 + * @playerversion Flash 10.2 + * @playerversion AIR 2.6 + * @productversion Royale 0.9.4 + */ + public function get activableName():String + { +return _activableName; + } + + public function set activableName(value:String):void + { +if (_activableName != value) +{ +_activableName = value; +} + } } } diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TabBarContent.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TabBarContent.as index 7bd118e..91b95d1 100644 --- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TabBarContent.as +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TabBarContent.as @@ -56,14 +56,14 @@ package org.apache.royale.jewel /** * shows a concrete content and hides the rest * -* @param id, the id of the container to show +* @param name, the name of the container to show * * @langversion 3.0 * @playerversion Flash 10.2 * @playerversion AIR 2.6 * @productversion Royale 0.9.4 */ -public function showContent(id:String):void +public function showContent(activableName:String):void { try { @@ -71,7 +71,7 @@ package org.apache.royale.jewel
[royale-asjs] branch develop updated: Using nested state causes parent to be null in some cases, added null check to prevent exception. (#357)
This is an automated email from the ASF dual-hosted git repository. harbs pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new eb1bcbb Using nested state causes parent to be null in some cases, added null check to prevent exception. (#357) eb1bcbb is described below commit eb1bcbb0bd74b0cd4566ee36b3895d97626ebc4a Author: likyateknoloji AuthorDate: Wed Dec 26 12:04:16 2018 +0300 Using nested state causes parent to be null in some cases, added null check to prevent exception. (#357) --- .../org/apache/royale/core/StatesWithTransitionsImpl.as | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/frameworks/projects/Effects/src/main/royale/org/apache/royale/core/StatesWithTransitionsImpl.as b/frameworks/projects/Effects/src/main/royale/org/apache/royale/core/StatesWithTransitionsImpl.as index fb09826..f00448a 100644 --- a/frameworks/projects/Effects/src/main/royale/org/apache/royale/core/StatesWithTransitionsImpl.as +++ b/frameworks/projects/Effects/src/main/royale/org/apache/royale/core/StatesWithTransitionsImpl.as @@ -321,11 +321,14 @@ package org.apache.royale.core var child:IChild = ai.document[ai.relativeTo] as IChild; if (ai.destination == null) parent = child.parent as IParent; -var index:int = parent.getElementIndex(child); -if (ai.position == "after") -index++; -parent.addElementAt(item, index); -childrenAdded = true; + if(parent != null) + { + var index:int = parent.getElementIndex(child); + if (ai.position == "after") + index++; + parent.addElementAt(item, index); + childrenAdded = true; + } } else {