[jira] [Commented] (SAMZA-1781) Flaky test: testNonResponsiveClusterManager

2018-07-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SAMZA-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553671#comment-16553671
 ] 

ASF GitHub Bot commented on SAMZA-1781:
---

Github user asfgit closed the pull request at:

https://github.com/apache/samza/pull/576


> Flaky test: testNonResponsiveClusterManager
> ---
>
> Key: SAMZA-1781
> URL: https://issues.apache.org/jira/browse/SAMZA-1781
> Project: Samza
>  Issue Type: Bug
>Reporter: Jagadish
>Priority: Major
>
> testExpiryWithNonResponsiveClusterManager FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.samza.clustermanager.TestHostAwareContainerAllocator.testExpiryWithNonResponsiveClusterManager(TestHostAwareContainerAllocator.java:406)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


samza git commit: SAMZA-1781: Minor: Disable flaky samza-yarn test. Fix tracked in

2018-07-23 Thread jagadish
Repository: samza
Updated Branches:
  refs/heads/master d131d4c55 -> 9f8d593c4


SAMZA-1781: Minor: Disable flaky samza-yarn test. Fix tracked in

Author: Jagadish 

Reviewers: Jagadish 

Closes #576 from vjagadish1989/flakytest-1


Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/9f8d593c
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/9f8d593c
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/9f8d593c

Branch: refs/heads/master
Commit: 9f8d593c41d93977afd1750050d7f8e956b7376b
Parents: d131d4c
Author: Jagadish 
Authored: Mon Jul 23 18:35:20 2018 -0700
Committer: Jagadish 
Committed: Mon Jul 23 18:35:20 2018 -0700

--
 .../samza/clustermanager/TestHostAwareContainerAllocator.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/samza/blob/9f8d593c/samza-core/src/test/java/org/apache/samza/clustermanager/TestHostAwareContainerAllocator.java
--
diff --git 
a/samza-core/src/test/java/org/apache/samza/clustermanager/TestHostAwareContainerAllocator.java
 
b/samza-core/src/test/java/org/apache/samza/clustermanager/TestHostAwareContainerAllocator.java
index b9fc2e5..3e5e785 100644
--- 
a/samza-core/src/test/java/org/apache/samza/clustermanager/TestHostAwareContainerAllocator.java
+++ 
b/samza-core/src/test/java/org/apache/samza/clustermanager/TestHostAwareContainerAllocator.java
@@ -334,7 +334,7 @@ public class TestHostAwareContainerAllocator {
 Assert.assertEquals(clusterResourceManager.cancelledRequests.size(), 3);
   }
 
-  @Test
+  //@Test
   public void testExpiryWithNonResponsiveClusterManager() throws Exception {
 
 final SamzaResource resource0 = new SamzaResource(1, 1000, "host-3", 
"id1");



[jira] [Commented] (SAMZA-1781) Flaky test: testNonResponsiveClusterManager

2018-07-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SAMZA-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553670#comment-16553670
 ] 

ASF GitHub Bot commented on SAMZA-1781:
---

GitHub user vjagadish1989 opened a pull request:

https://github.com/apache/samza/pull/576

Minor: Disable flaky samza-yarn test. Fix tracked in SAMZA-1781



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vjagadish1989/samza flakytest-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/samza/pull/576.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #576


commit ad5436a4bdce69fb4ed072ddb8882aa631d2ddb6
Author: Jagadish 
Date:   2018-05-30T22:06:03Z

Add logging for EventHubs configs

commit 4976d2157bdd9146c7df8950eed46dce26bb95de
Author: Jagadish 
Date:   2018-05-30T22:49:46Z

Fix a checkstyle failure

commit 85de1b36752597bb4e147099c583dc6aeaef8eb6
Author: Jagadish 
Date:   2018-06-05T19:17:48Z

Merge branch 'master' of https://github.com/apache/samza

commit 2124d4ed1d9f6fcca753ce3fb3c74ceae097f616
Author: Jagadish 
Date:   2018-06-08T18:00:16Z

Merge branch 'master' of https://github.com/apache/samza

commit 3d03e3b9af7094bc7026922d22b3104943dd4343
Author: Jagadish 
Date:   2018-06-11T17:49:01Z

Merge branch 'master' of https://github.com/apache/samza

commit 7db95735d9e517193edfc594ba11d05eefeefc3f
Author: Jagadish 
Date:   2018-06-14T03:45:53Z

Add metric for effectiveness of host-affinity

commit 86332640e380817d4515f82afa9f893c0bb82976
Author: Jagadish 
Date:   2018-06-19T00:01:14Z

Merge branch 'master' of https://github.com/apache/samza

commit ba7861b1182fe9442b10a7c1f4993da83efda9d9
Author: Jagadish 
Date:   2018-07-24T01:28:43Z

Merge branch 'master' of https://github.com/apache/samza

commit de604d5c1f7a087be40051fd1615089194c22945
Author: Jagadish 
Date:   2018-07-24T01:33:38Z

Minor: Disable flaky samza-yarn test. Tracked in SAMZA-1781




> Flaky test: testNonResponsiveClusterManager
> ---
>
> Key: SAMZA-1781
> URL: https://issues.apache.org/jira/browse/SAMZA-1781
> Project: Samza
>  Issue Type: Bug
>Reporter: Jagadish
>Priority: Major
>
> testExpiryWithNonResponsiveClusterManager FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.samza.clustermanager.TestHostAwareContainerAllocator.testExpiryWithNonResponsiveClusterManager(TestHostAwareContainerAllocator.java:406)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SAMZA-1781) Flaky test: testNonResponsiveClusterManager

2018-07-23 Thread Jagadish (JIRA)
Jagadish created SAMZA-1781:
---

 Summary: Flaky test: testNonResponsiveClusterManager
 Key: SAMZA-1781
 URL: https://issues.apache.org/jira/browse/SAMZA-1781
 Project: Samza
  Issue Type: Bug
 Environment: testExpiryWithNonResponsiveClusterManager FAILED
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at 
org.apache.samza.clustermanager.TestHostAwareContainerAllocator.testExpiryWithNonResponsiveClusterManager(TestHostAwareContainerAllocator.java:406)

Reporter: Jagadish






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SAMZA-1781) Flaky test: testNonResponsiveClusterManager

2018-07-23 Thread Jagadish (JIRA)


 [ 
https://issues.apache.org/jira/browse/SAMZA-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jagadish updated SAMZA-1781:

Environment: (was: testExpiryWithNonResponsiveClusterManager FAILED
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at 
org.apache.samza.clustermanager.TestHostAwareContainerAllocator.testExpiryWithNonResponsiveClusterManager(TestHostAwareContainerAllocator.java:406)
)

> Flaky test: testNonResponsiveClusterManager
> ---
>
> Key: SAMZA-1781
> URL: https://issues.apache.org/jira/browse/SAMZA-1781
> Project: Samza
>  Issue Type: Bug
>Reporter: Jagadish
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SAMZA-1779) Fix Fix SamzaSql AvroRelConverter to handle BYTES and FIXED avro schema types

2018-07-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SAMZA-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553639#comment-16553639
 ] 

ASF GitHub Bot commented on SAMZA-1779:
---

Github user atoomula closed the pull request at:

https://github.com/apache/samza/pull/574


> Fix Fix SamzaSql AvroRelConverter to handle BYTES and FIXED avro schema types
> -
>
> Key: SAMZA-1779
> URL: https://issues.apache.org/jira/browse/SAMZA-1779
> Project: Samza
>  Issue Type: Bug
>Reporter: Aditya
>Priority: Major
>
> Currently, having bytes avro type fails with cast exception:
> java.lang.ClassCastException: java.nio.HeapByteBuffer cannot be cast to 
> org.apache.calcite.avatica.util.ByteString



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SAMZA-1779) Fix Fix SamzaSql AvroRelConverter to handle BYTES and FIXED avro schema types

2018-07-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SAMZA-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553635#comment-16553635
 ] 

ASF GitHub Bot commented on SAMZA-1779:
---

GitHub user atoomula opened a pull request:

https://github.com/apache/samza/pull/575

SAMZA-1779: Fix SamzaSql AvroRelConverter to handle BYTES and FIXED avro 
schema types



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/atoomula/samza bytes1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/samza/pull/575.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #575


commit 80268fc1e3168af34cfbe2b7c75167456d4ec63e
Author: Aditya Toomula 
Date:   2018-07-24T00:45:23Z

Fix SamzaSql AvroRelConverter to handle BYTES and FIXED avro schema types

commit df4886d838ef89eb0ce380d02751397cedf354b5
Author: Aditya Toomula 
Date:   2018-07-24T00:49:48Z

Fix SamzaSql AvroRelConverter to handle BYTES and FIXED avro schema types




> Fix Fix SamzaSql AvroRelConverter to handle BYTES and FIXED avro schema types
> -
>
> Key: SAMZA-1779
> URL: https://issues.apache.org/jira/browse/SAMZA-1779
> Project: Samza
>  Issue Type: Bug
>Reporter: Aditya
>Priority: Major
>
> Currently, having bytes avro type fails with cast exception:
> java.lang.ClassCastException: java.nio.HeapByteBuffer cannot be cast to 
> org.apache.calcite.avatica.util.ByteString



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SAMZA-1780) Side Inputs Future Work

2018-07-23 Thread Prateek Maheshwari (JIRA)


 [ 
https://issues.apache.org/jira/browse/SAMZA-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prateek Maheshwari updated SAMZA-1780:
--
Description: 
# More unit, integration and performance tests.
 # Document the feature semantics, and how to configure and use it.
 # Ensure that the TaskSideInputStorageManager is always non null, even if 
there are no side input stores.
 # Make side input store max staleness configurable. This is simlar to the 
"changelog delete retention" for TaskStorageManager.
 # Consolidate getStoreLocation in TaskStorageManager and TaskSideInputManager 
and move it to StorageManagerUtil.
 # Consolidate store location configuration. Instead of introducing a new 
configuration for side input stores, should change existing configuration to 
"durable.store.path" or something similar.

  was:
# More unit, integration and performance tests.
 # Document the feature semantics, and how to configure and use it.
 # Make side input store max staleness configurable. This is simlar to the 
"changelog delete retention" for TaskStorageManager.
 # Consolidate getStoreLocation in TaskStorageManager and TaskSideInputManager 
and move it to StorageManagerUtil.
 # Consoliate store location configuration. Instead of introducing a new 
configuration for side input stores, should change existing configuration to 
"durable.store.path" or something similar.


> Side Inputs Future Work
> ---
>
> Key: SAMZA-1780
> URL: https://issues.apache.org/jira/browse/SAMZA-1780
> Project: Samza
>  Issue Type: New Feature
>Reporter: Prateek Maheshwari
>Priority: Major
>
> # More unit, integration and performance tests.
>  # Document the feature semantics, and how to configure and use it.
>  # Ensure that the TaskSideInputStorageManager is always non null, even if 
> there are no side input stores.
>  # Make side input store max staleness configurable. This is simlar to the 
> "changelog delete retention" for TaskStorageManager.
>  # Consolidate getStoreLocation in TaskStorageManager and 
> TaskSideInputManager and move it to StorageManagerUtil.
>  # Consolidate store location configuration. Instead of introducing a new 
> configuration for side input stores, should change existing configuration to 
> "durable.store.path" or something similar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SAMZA-1780) Side Inputs Future Work

2018-07-23 Thread Prateek Maheshwari (JIRA)


 [ 
https://issues.apache.org/jira/browse/SAMZA-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prateek Maheshwari updated SAMZA-1780:
--
Description: 
# More unit, integration and performance tests.
 # Document the feature semantics, and how to configure and use it.
 # Make side input store max staleness configurable. This is simlar to the 
"changelog delete retention" for TaskStorageManager.
 # Consolidate getStoreLocation in TaskStorageManager and TaskSideInputManager 
and move it to StorageManagerUtil.
 # Consoliate store location configuration. Instead of introducing a new 
configuration for side input stores, should change existing configuration to 
"durable.store.path" or something similar.

  was:
# More unit, integration and performance tests.
 # Document the feature semantics, and how to configure and use it.
 # Make side input store max staleness configurable. This is simlar to the 
"changelog delete retention" for TaskStorageManager.
 # Consolidate getStoreLocation in TaskStorageManager and TaskSideInputManager 
and move it to StorageManagerUtil.


> Side Inputs Future Work
> ---
>
> Key: SAMZA-1780
> URL: https://issues.apache.org/jira/browse/SAMZA-1780
> Project: Samza
>  Issue Type: New Feature
>Reporter: Prateek Maheshwari
>Priority: Major
>
> # More unit, integration and performance tests.
>  # Document the feature semantics, and how to configure and use it.
>  # Make side input store max staleness configurable. This is simlar to the 
> "changelog delete retention" for TaskStorageManager.
>  # Consolidate getStoreLocation in TaskStorageManager and 
> TaskSideInputManager and move it to StorageManagerUtil.
>  # Consoliate store location configuration. Instead of introducing a new 
> configuration for side input stores, should change existing configuration to 
> "durable.store.path" or something similar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SAMZA-1780) Side Inputs Future Work

2018-07-23 Thread Prateek Maheshwari (JIRA)
Prateek Maheshwari created SAMZA-1780:
-

 Summary: Side Inputs Future Work
 Key: SAMZA-1780
 URL: https://issues.apache.org/jira/browse/SAMZA-1780
 Project: Samza
  Issue Type: New Feature
Reporter: Prateek Maheshwari


# More unit, integration and performance tests.
 # Document the feature semantics, and how to configure and use it.
 # Make side input store max staleness configurable. This is simlar to the 
"changelog delete retention" for TaskStorageManager.
 # Consolidate getStoreLocation in TaskStorageManager and TaskSideInputManager 
and move it to StorageManagerUtil.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SAMZA-1565) Disallow switching between TTL and non-TTL mode for RocksDB stores

2018-07-23 Thread Daniel Nishimura (JIRA)


 [ 
https://issues.apache.org/jira/browse/SAMZA-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Nishimura reassigned SAMZA-1565:
---

Assignee: Daniel Nishimura

> Disallow switching between TTL and non-TTL mode for RocksDB stores
> --
>
> Key: SAMZA-1565
> URL: https://issues.apache.org/jira/browse/SAMZA-1565
> Project: Samza
>  Issue Type: Bug
>Reporter: Prateek Maheshwari
>Assignee: Daniel Nishimura
>Priority: Major
>
> Opening a TTL'd store in non-TTL mode or vice-versa can cause data corruption 
> on writes to the store and false negatives on reads. Samza should disallow 
> this change.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SAMZA-1779) Fix Fix SamzaSql AvroRelConverter to handle BYTES and FIXED avro schema types

2018-07-23 Thread Aditya (JIRA)
Aditya created SAMZA-1779:
-

 Summary: Fix Fix SamzaSql AvroRelConverter to handle BYTES and 
FIXED avro schema types
 Key: SAMZA-1779
 URL: https://issues.apache.org/jira/browse/SAMZA-1779
 Project: Samza
  Issue Type: Bug
Reporter: Aditya


Currently, having bytes avro type fails with cast exception:

java.lang.ClassCastException: java.nio.HeapByteBuffer cannot be cast to 
org.apache.calcite.avatica.util.ByteString



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)