[jira] [Commented] (SAMZA-1900) Logging improvement: Changelog restore logs should log store name including task name/store path

2018-10-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SAMZA-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646906#comment-16646906
 ] 

ASF GitHub Bot commented on SAMZA-1900:
---

Github user asfgit closed the pull request at:

https://github.com/apache/samza/pull/653


> Logging improvement: Changelog restore logs should log store name including 
> task name/store path
> 
>
> Key: SAMZA-1900
> URL: https://issues.apache.org/jira/browse/SAMZA-1900
> Project: Samza
>  Issue Type: Bug
>  Components: kv-store
>Reporter: Daniel Chen 
>Assignee: Daniel Chen 
>Priority: Major
>
> Add logging in changelog restores and log store to include the TaskName and 
> the Store path in printing info logs.
>  
> Example changes:
> 1.
> From: 2018-05-15 20:10:31.423 [main]RocksDbKeyValueStore$ [INFO] Opening 
> RocksDB store with TTL value: 14400
> To: 2018-05-15 20:10:31.423 [main]RocksDbKeyValueStore$ [INFO] Opening 
> RocksDB store at path  with TTL value: 14400
> 2. 
> From: 2018-05-15 20:10:31.421 [main]KeyValueStorageEngine [INFO] Restoring 
> entries for store storageRankingEventStore
> To: 2018-05-15 20:10:31.421 [main]KeyValueStorageEngine [INFO] Restoring 
> entries for store storageRankingEventStore for task 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SAMZA-1900) Logging improvement: Changelog restore logs should log store name including task name/store path

2018-09-21 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SAMZA-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624356#comment-16624356
 ] 

ASF GitHub Bot commented on SAMZA-1900:
---

GitHub user dxichen opened a pull request:

https://github.com/apache/samza/pull/653

SAMZA-1900 Add restore logging info

@prateekm let me know if there are other places that logging should also be 
improved in this patch.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dxichen/samza add-restore-logging-info

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/samza/pull/653.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #653


commit 3b6ef138943a41f609afbc19de197d47c4100f19
Author: Daniel Chen 
Date:   2018-09-20T23:45:54Z

Merge pull request #2 from apache/master

update fork

commit 4a36642aec8188b56be79a0fe7ac4f7b4ab481c2
Author: Daniel Chen 
Date:   2018-09-22T00:05:06Z

SAMZA-1900 Change store logging improvement




> Logging improvement: Changelog restore logs should log store name including 
> task name/store path
> 
>
> Key: SAMZA-1900
> URL: https://issues.apache.org/jira/browse/SAMZA-1900
> Project: Samza
>  Issue Type: Bug
>  Components: kv-store
>Reporter: Daniel Chen 
>Assignee: Daniel Chen 
>Priority: Major
>
> Add logging in changelog restores and log store to include the TaskName and 
> the Store path in printing info logs.
>  
> Example changes:
> 1.
> From: 2018-05-15 20:10:31.423 [main]RocksDbKeyValueStore$ [INFO] Opening 
> RocksDB store with TTL value: 14400
> To: 2018-05-15 20:10:31.423 [main]RocksDbKeyValueStore$ [INFO] Opening 
> RocksDB store at path  with TTL value: 14400
> 2. 
> From: 2018-05-15 20:10:31.421 [main]KeyValueStorageEngine [INFO] Restoring 
> entries for store storageRankingEventStore
> To: 2018-05-15 20:10:31.421 [main]KeyValueStorageEngine [INFO] Restoring 
> entries for store storageRankingEventStore for task 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)