[GitHub] [servicecomb-java-chassis] yhs0092 commented on a change in pull request #1302: [SCB-1451] Printing the service information on the log
yhs0092 commented on a change in pull request #1302: [SCB-1451] Printing the
service information on the log
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1302#discussion_r316514683
##
File path:
core/src/main/java/org/apache/servicecomb/core/bootup/AddressInformationCollector.java
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.core.bootup;
+
+import org.apache.servicecomb.deployment.Deployment;
+import org.apache.servicecomb.deployment.SystemBootstrapInfo;
+
+public class AddressInformationCollector implements BootUpInformationCollector
{
+@Override
+public String collect() {
+return "service center: "
++
getCenterInfo(Deployment.getSystemBootStrapInfo("ServiceCenter"))
++ "\n" + "config center: "
++
getCenterInfo(Deployment.getSystemBootStrapInfo("ConfigCenter"));
+}
+
+@Override
+public int getOrder() {
+return 0;
+}
+
+private String getCenterInfo(SystemBootstrapInfo systemBootstrapInfo) {
+if (systemBootstrapInfo == null) {
+return ("not exist");
+} else {
+return systemBootstrapInfo.getAccessURL().toString();
+}
+}
+
+}
Review comment:
The indent of some files a different from our code style, please reformat it
: )
And you can find code style config files
[here](https://github.com/apache/servicecomb-java-chassis/tree/master/etc)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] yhs0092 commented on a change in pull request #1302: [SCB-1451] Printing the service information on the log
yhs0092 commented on a change in pull request #1302: [SCB-1451] Printing the
service information on the log
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1302#discussion_r316513601
##
File path: core/src/main/java/org/apache/servicecomb/core/SCBEngine.java
##
@@ -223,10 +228,22 @@ public synchronized void init() {
}
status = SCBStatus.FAILED;
throw new IllegalStateException("ServiceComb init failed.", e);
+ } finally {
+ServiceInfoPrinter();
}
}
}
+ private void ServiceInfoPrinter() {
Review comment:
- method name should follow CamelCase
- please use verb as method name, e.g. `printServiceInfo` is better than
`ServiceInfoPrinter`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1301: [SCB-1450] Microservice instance may get stuck when watch connection to sc is recovered and pulling instance action is executed
coveralls commented on issue #1301: [SCB-1450] Microservice instance may get stuck when watch connection to sc is recovered and pulling instance action is executed in eventloop thread URL: https://github.com/apache/servicecomb-java-chassis/pull/1301#issuecomment-523767235 [](https://coveralls.io/builds/25232372) Coverage increased (+0.08%) to 85.843% when pulling **4438b67a9ad40c4bf4e9fcf563c39904ca18c824 on HuaiJoe:master** into **350e988c338204db11fd074fbd678f93ad41cfd2 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-service-center] coveralls commented on issue #575: Clear no-instance services automatically
coveralls commented on issue #575: Clear no-instance services automatically URL: https://github.com/apache/servicecomb-service-center/pull/575#issuecomment-523755140 [](https://coveralls.io/builds/25280263) Coverage decreased (-0.2%) to 60.603% when pulling **9f67ff8842e2ec9fed3a3f5623eea515b41b40d9 on humingcheng:serviceclear** into **dad8f29c07a8a848469a986124236f0fcac0ac6a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-service-center] humingcheng opened a new pull request #575: Clear no-instance services automatically
humingcheng opened a new pull request #575: Clear no-instance services automatically URL: https://github.com/apache/servicecomb-service-center/pull/575 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-docs] ZihangJiao opened a new pull request #106: [SCB-1451]Printing the service information on the log
ZihangJiao opened a new pull request #106: [SCB-1451]Printing the service information on the log URL: https://github.com/apache/servicecomb-docs/pull/106 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-service-center] branch master updated: Add new servicecenter plugin supported eureka
This is an automated email from the ASF dual-hosted git repository.
zenlin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-service-center.git
The following commit(s) were added to refs/heads/master by this push:
new 11eed33 Add new servicecenter plugin supported eureka
new dad8f29 Merge pull request #574 from zenlint/syncer-eureka
11eed33 is described below
commit 11eed33811468dfa9bb4a46f7b8fbeec13f024f5
Author: Zen Lin
AuthorDate: Thu Aug 22 11:11:24 2019 +0800
Add new servicecenter plugin supported eureka
---
syncer/cmd/daemon.go | 3 +
syncer/config/config.go | 1 +
syncer/plugins/eureka/eureka.go | 113
syncer/plugins/eureka/instance.go | 108 +++
syncer/plugins/eureka/service.go | 38 ++
syncer/plugins/eureka/transform.go| 218 ++
syncer/plugins/eureka/type.go | 155 +
syncer/plugins/servicecenter/transform.go | 6 +-
8 files changed, 641 insertions(+), 1 deletion(-)
diff --git a/syncer/cmd/daemon.go b/syncer/cmd/daemon.go
index dde9836..70b65da 100644
--- a/syncer/cmd/daemon.go
+++ b/syncer/cmd/daemon.go
@@ -61,6 +61,9 @@ func init() {
syncerCmd.Flags().IntVar(&conf.ClusterPort, "cluster-port",
conf.ClusterPort,
"port to communicate between cluster members")
+
+ syncerCmd.Flags().StringVar(&conf.ServicecenterPlugin, "sc-plugin",
conf.ServicecenterPlugin,
+ "plugin name of servicecenter")
}
// runSyncer Runs the Syncer service.
diff --git a/syncer/config/config.go b/syncer/config/config.go
index b194d45..723eab8 100644
--- a/syncer/config/config.go
+++ b/syncer/config/config.go
@@ -25,6 +25,7 @@ import (
"github.com/apache/servicecomb-service-center/pkg/log"
"github.com/apache/servicecomb-service-center/syncer/etcd"
"github.com/apache/servicecomb-service-center/syncer/pkg/utils"
+ _ "github.com/apache/servicecomb-service-center/syncer/plugins/eureka"
"github.com/apache/servicecomb-service-center/syncer/plugins/servicecenter"
"github.com/apache/servicecomb-service-center/syncer/serf"
)
diff --git a/syncer/plugins/eureka/eureka.go b/syncer/plugins/eureka/eureka.go
new file mode 100644
index 000..71039e2
--- /dev/null
+++ b/syncer/plugins/eureka/eureka.go
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package eureka
+
+import (
+ "context"
+ "encoding/json"
+ "errors"
+ "io/ioutil"
+ "net/http"
+
+ "github.com/apache/servicecomb-service-center/pkg/client/sc"
+ "github.com/apache/servicecomb-service-center/pkg/util"
+ "github.com/apache/servicecomb-service-center/syncer/plugins"
+ pb "github.com/apache/servicecomb-service-center/syncer/proto"
+)
+
+const (
+ PluginName = "eureka"
+
+ apiApplications = "/apps"
+)
+
+func init() {
+ // Register self as a repository plugin
+ plugins.RegisterPlugin(&plugins.Plugin{
+ Kind: plugins.PluginServicecenter,
+ Name: PluginName,
+ New: New,
+ })
+}
+
+type adaptor struct{}
+
+func New() plugins.PluginInstance {
+ return &adaptor{}
+}
+
+// New repository with endpoints
+func (*adaptor) New(endpoints []string) (plugins.Servicecenter, error) {
+ cfg := sc.Config{Endpoints: endpoints}
+ client, err := sc.NewLBClient(cfg.Endpoints, cfg.Merge())
+ if err != nil {
+ return nil, err
+ }
+ return &Client{LBClient: client, Cfg: cfg}, nil
+}
+
+type Client struct {
+ *sc.LBClient
+ Cfg sc.Config
+}
+
+// GetAll get and transform eureka data to SyncData
+func (c *Client) GetAll(ctx context.Context) (*pb.SyncData, error) {
+ method := http.MethodGet
+ headers := c.CommonHeaders(method)
+ resp, err := c.RestDoWithContext(ctx, method, apiApplications, headers,
nil)
+ if err != nil {
+ return nil, err
+ }
+ defer resp.Body.Close()
+
+ body, err := ioutil.ReadAll(resp.Body)
+ if err != nil {
+ return nil,
[GitHub] [servicecomb-service-center] zenlint merged pull request #574: [SCB-1453] Add new servicecenter plugin supported eureka
zenlint merged pull request #574: [SCB-1453] Add new servicecenter plugin supported eureka URL: https://github.com/apache/servicecomb-service-center/pull/574 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-service-center] ChinX commented on issue #574: [SCB-1453] Add new servicecenter plugin supported eureka
ChinX commented on issue #574: [SCB-1453] Add new servicecenter plugin supported eureka URL: https://github.com/apache/servicecomb-service-center/pull/574#issuecomment-523738550 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-service-center] coveralls commented on issue #574: [SCB-1453] Add new servicecenter plugin supported eureka
coveralls commented on issue #574: [SCB-1453] Add new servicecenter plugin supported eureka URL: https://github.com/apache/servicecomb-service-center/pull/574#issuecomment-523737797 [](https://coveralls.io/builds/25279440) Coverage decreased (-0.1%) to 60.639% when pulling **11eed33811468dfa9bb4a46f7b8fbeec13f024f5 on zenlint:syncer-eureka** into **956a04bb21bff9c723fd3235e503301f2908448d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-service-center] zenlint opened a new pull request #574: [SCB-1453] Add new servicecenter plugin supported eureka
zenlint opened a new pull request #574: [SCB-1453] Add new servicecenter plugin supported eureka URL: https://github.com/apache/servicecomb-service-center/pull/574 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] WillemJiang commented on issue #1270: 程序运行失败都没有看到一个error日志
WillemJiang commented on issue #1270: 程序运行失败都没有看到一个error日志 URL: https://github.com/apache/servicecomb-java-chassis/issues/1270#issuecomment-523731766 @walker-dead-cave 有什么更多的信息需要补充吗？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] pengyu0929 opened a new issue #542: 数据库使用TiDB，在启动时报错，导致不能执行补偿方法
pengyu0929 opened a new issue #542: 数据库使用TiDB，在启动时报错，导致不能执行补偿方法 URL: https://github.com/apache/servicecomb-pack/issues/542 `Error Code: 1146 Call: INSERT INTO TL_TxTimeout (SURROGATEID, STATUS, VERSION) SELECT t0.SURROGATEID, ?, (t0.VERSION + ?) FROM TxTimeout t0 WHERE ((t0.STATUS <> ?) AND EXISTS (SELECT ? FROM TxEvent t1 WHERE (((t1.GLOBALTXID = t0.GLOBALTXID) AND (t1.LOCALTXID = t0.LOCALTXID)) AND (t1.TYPE <> t0.TYPE))) ) bind => [4 parameters bound] Query: UpdateAllQuery(referenceClass=TxTimeout sql="CREATE TEMPORARY TABLE IF NOT EXISTS TL_TxTimeout (SURROGATEID BIGINT NOT NULL, EVENTID BIGINT, EXPIRYTIME DATETIME, GLOBALTXID VARCHAR(255), INSTANCEID VARCHAR(255), LOCALTXID VARCHAR(255), PARENTTXID VARCHAR(255), SERVICENAME VARCHAR(255), STATUS VARCHAR(255), TYPE VARCHAR(255), VERSION BIGINT, PRIMARY KEY (SURROGATEID))") at org.eclipse.persistence.exceptions.DatabaseException.sqlException(DatabaseException.java:331) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeDirectNoSelect(DatabaseAccessor.java:905) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeNoSelect(DatabaseAccessor.java:967) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.basicExecuteCall(DatabaseAccessor.java:637) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeCall(DatabaseAccessor.java:564) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.internal.sessions.AbstractSession.basicExecuteCall(AbstractSession.java:2093) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.sessions.server.ClientSession.executeCall(ClientSession.java:309) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.internal.queries.DatasourceCallQueryMechanism.executeCall(DatasourceCallQueryMechanism.java:270) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.internal.queries.DatasourceCallQueryMechanism.updateAllUsingTempTables(DatasourceCallQueryMechanism.java:899) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.internal.queries.DatasourceCallQueryMechanism.updateAll(DatasourceCallQueryMechanism.java:861) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.queries.UpdateAllQuery.executeDatabaseQuery(UpdateAllQuery.java:154) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.queries.DatabaseQuery.execute(DatabaseQuery.java:911) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.queries.DatabaseQuery.executeInUnitOfWork(DatabaseQuery.java:810) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.queries.ModifyAllQuery.executeInUnitOfWork(ModifyAllQuery.java:148) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.internalExecuteQuery(UnitOfWorkImpl.java:2979) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.internal.sessions.AbstractSession.executeQuery(AbstractSession.java:1892) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.internal.sessions.AbstractSession.executeQuery(AbstractSession.java:1874) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.internal.sessions.AbstractSession.executeQuery(AbstractSession.java:1839) ~[org.eclipse.persistence.core-2.7.1.jar:?] at org.eclipse.persistence.internal.jpa.QueryImpl.executeUpdate(QueryImpl.java:300) ~[org.eclipse.persistence.jpa-2.7.1.jar:?] at org.springframework.data.jpa.repository.query.JpaQueryExecution$ModifyingExecution.doExecute(JpaQueryExecution.java:256) ~[spring-data-jpa-2.0.11.RELEASE.jar:2.0.11.RELEASE] at org.springframework.data.jpa.repository.query.JpaQueryExecution.execute(JpaQueryExecution.java:91) ~[spring-data-jpa-2.0.11.RELEASE.jar:2.0.11.RELEASE] at org.springframework.data.jpa.repository.query.AbstractJpaQuery.doExecute(AbstractJpaQuery.java:136) ~[spring-data-jpa-2.0.11.RELEASE.jar:2.0.11.RELEASE] at org.springframework.data.jpa.repository.query.AbstractJpaQuery.execute(AbstractJpaQuery.java:125) ~[spring-data-jpa-2.0.11.RELEASE.jar:2.0.11.RELEASE] at org.springframework.data.repository.core.support.RepositoryFactorySupport$QueryExecutorMethodInterceptor.doInvoke(RepositoryFactorySupport.java:602) ~[spring-data-commons-2.0.11.RELEASE.jar:2.0.11.RELEASE] at org.springframework.data.repository.core.support.RepositoryFactorySupport$QueryExecutorMethodInterceptor.invoke(RepositoryFactorySupport.java:590) ~[spring-data-commons-2.0.11.RELEASE.jar:2.0.11.RELEASE] at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:1
[GitHub] [servicecomb-pack] pengyu0929 closed issue #541: docker部署alpha时，host使用localhost，omega端报连接拒绝异常
pengyu0929 closed issue #541: docker部署alpha时，host使用localhost，omega端报连接拒绝异常 URL: https://github.com/apache/servicecomb-pack/issues/541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] WillemJiang merged pull request #1296: [SCB-1434] add a springboot2 archetype
WillemJiang merged pull request #1296: [SCB-1434] add a springboot2 archetype URL: https://github.com/apache/servicecomb-java-chassis/pull/1296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-java-chassis] branch master updated (350e988 -> 5399add)
This is an automated email from the ASF dual-hosted git repository.
ningjiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git.
from 350e988 [SCB-1448]support class inheritance and interface inheritance
with template type
add 5399add [SCB-1434] add a springboot2 archetype
No new revisions were added by this update.
Summary of changes:
.../README.md | 8
.../pom.xml| 4 ++--
.../META-INF/maven/archetype-metadata.xml | 0
.../src/main/resources/archetype-resources/README.md | 8
.../src/main/resources/archetype-resources/pom.xml | 18 +-
.../archetype-resources/src/main/java/Application.java | 2 +-
.../src/main/java/HelloConsumer.java | 0
.../archetype-resources/src/main/java/HelloImpl.java | 0
.../src/main/resources/application.yaml| 7 +++
.../src/main/resources/microservice.yaml | 0
archetypes/pom.xml | 1 +
11 files changed, 20 insertions(+), 28 deletions(-)
copy
archetypes/{business-service-spring-boot-starter/src/main/resources/archetype-resources
=> business-service-spring-boot2-starter}/README.md (79%)
mode change 100644 => 100755
copy archetypes/{business-service-spring-boot-starter =>
business-service-spring-boot2-starter}/pom.xml (93%)
mode change 100644 => 100755
copy archetypes/{business-service-springmvc =>
business-service-spring-boot2-starter}/src/main/resources-filtered/META-INF/maven/archetype-metadata.xml
(100%)
mode change 100644 => 100755
copy archetypes/{business-service-spring-boot-starter =>
business-service-spring-boot2-starter}/src/main/resources/archetype-resources/README.md
(79%)
mode change 100644 => 100755
copy archetypes/{business-service-spring-boot-starter =>
business-service-spring-boot2-starter}/src/main/resources/archetype-resources/pom.xml
(80%)
mode change 100644 => 100755
copy archetypes/{business-service-spring-boot-starter =>
business-service-spring-boot2-starter}/src/main/resources/archetype-resources/src/main/java/Application.java
(93%)
mode change 100644 => 100755
copy archetypes/{business-service-springmvc =>
business-service-spring-boot2-starter}/src/main/resources/archetype-resources/src/main/java/HelloConsumer.java
(100%)
mode change 100644 => 100755
copy archetypes/{business-service-springmvc =>
business-service-spring-boot2-starter}/src/main/resources/archetype-resources/src/main/java/HelloImpl.java
(100%)
mode change 100644 => 100755
copy {integration-tests/it-producer-deploy-springboot2-servlet =>
archetypes/business-service-spring-boot2-starter/src/main/resources/archetype-resources}/src/main/resources/application.yaml
(83%)
copy archetypes/{business-service-springmvc =>
business-service-spring-boot2-starter}/src/main/resources/archetype-resources/src/main/resources/microservice.yaml
(100%)
mode change 100644 => 100755
[GitHub] [servicecomb-java-chassis] msnetc closed issue #1305: operation with url /Tenant/insertTenant/, method POST is duplicated.
msnetc closed issue #1305: operation with url /Tenant/insertTenant/, method POST is duplicated. URL: https://github.com/apache/servicecomb-java-chassis/issues/1305 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] willard-kali commented on issue #1303: 哪位大佬帮忙看看，Servicecomb无法集成CAS实现单点登录吗？急，在线等！！！
willard-kali commented on issue #1303: 哪位大佬帮忙看看，Servicecomb无法集成CAS实现单点登录吗？急，在线等！！！ URL: https://github.com/apache/servicecomb-java-chassis/issues/1303#issuecomment-523725654 可以参考pac4j-cas的实现， https://github.com/pac4j/pac4j/tree/master/pac4j-cas This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] msnetc opened a new issue #1305: peration with url /Tenant/insertTenant/, method POST is duplicated.
msnetc opened a new issue #1305: peration with url /Tenant/insertTenant/, method POST is duplicated. URL: https://github.com/apache/servicecomb-java-chassis/issues/1305 启动应用时报错，java-chaasis版本1.2.0， 请问是什么原因导致的？ Caused by: org.apache.servicecomb.foundation.common.exceptions.ServiceCombException: operation with url /Tenant/insertTenant/, method POST is duplicated. at org.apache.servicecomb.common.rest.locator.MicroservicePaths.addStaticPathResource(MicroservicePaths.java:81) at org.apache.servicecomb.common.rest.locator.MicroservicePaths.addResource(MicroservicePaths.java:57) at org.apache.servicecomb.common.rest.locator.ServicePathManager.addResource(ServicePathManager.java:121) at org.apache.servicecomb.common.rest.locator.ServicePathManager.addSchema(ServicePathManager.java:88) at org.apache.servicecomb.common.rest.RestEngineSchemaListener.onSchemaLoaded(RestEngineSchemaListener.java:54) at org.apache.servicecomb.core.definition.loader.SchemaListenerManager.notifySchemaListener(SchemaListenerManager.java:59) at org.apache.servicecomb.core.definition.loader.SchemaListenerManager.notifySchemaListener(SchemaListenerManager.java:48) at org.apache.servicecomb.core.definition.loader.SchemaListenerManager.notifySchemaListener(SchemaListenerManager.java:54) at org.apache.servicecomb.core.SCBEngine.doInit(SCBEngine.java:246) at org.apache.servicecomb.core.SCBEngine.init(SCBEngine.java:206) ... 12 common frames omitted This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] ScorpJ removed a comment on issue #446: fix mysql master_lock table schema wrong default value
ScorpJ removed a comment on issue #446: fix mysql master_lock table schema wrong default value URL: https://github.com/apache/servicecomb-pack/pull/446#issuecomment-523525189 Still get the same error after patch fix f6e9498208cb061f4d01825927f883e8db0d0f2f. My env is alpha-server:0.4.0 and mysql-connector-java-8.0.15.jar And the issue has gone with below fix. CREATE TABLE IF NOT EXISTS master_lock ( serviceName varchar(36) not NULL, expireTime datetime NOT NULL DEFAULT CURRENT_TIMESTAMP**(3)**, lockedTime datetime NOT NULL DEFAULT CURRENT_TIMESTAMP**(3)**, instanceId varchar(255) not NULL, PRIMARY KEY (serviceName) ) ENGINE=InnoDB DEFAULT CHARSET=utf8; I refered below link; https://stackoverflow.com/questions/23671222/mysql-default-value-for-timestamp3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] ScorpJ edited a comment on issue #446: fix mysql master_lock table schema wrong default value
ScorpJ edited a comment on issue #446: fix mysql master_lock table schema wrong default value URL: https://github.com/apache/servicecomb-pack/pull/446#issuecomment-523525189 Still get the same error after patch fix f6e9498208cb061f4d01825927f883e8db0d0f2f. My env is alpha-server:0.4.0 and mysql-connector-java-8.0.15.jar And the issue has gone with below fix. CREATE TABLE IF NOT EXISTS master_lock ( serviceName varchar(36) not NULL, expireTime datetime NOT NULL DEFAULT CURRENT_TIMESTAMP**(3)**, lockedTime datetime NOT NULL DEFAULT CURRENT_TIMESTAMP**(3)**, instanceId varchar(255) not NULL, PRIMARY KEY (serviceName) ) ENGINE=InnoDB DEFAULT CHARSET=utf8; I refered below link; https://stackoverflow.com/questions/23671222/mysql-default-value-for-timestamp3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] ScorpJ commented on issue #446: fix mysql master_lock table schema wrong default value
ScorpJ commented on issue #446: fix mysql master_lock table schema wrong default value URL: https://github.com/apache/servicecomb-pack/pull/446#issuecomment-523525189 Still get the same error after patch fix 949feb68f61005304f6b373af3f6e7b5d011e63d. My env is alpha-server:0.4.0 and mysql-connector-java-8.0.15.jar And the issue has gone with below fix. CREATE TABLE IF NOT EXISTS master_lock ( serviceName varchar(36) not NULL, expireTime datetime NOT NULL DEFAULT CURRENT_TIMESTAMP**(3)**, lockedTime datetime NOT NULL DEFAULT CURRENT_TIMESTAMP**(3)**, instanceId varchar(255) not NULL, PRIMARY KEY (serviceName) ) ENGINE=InnoDB DEFAULT CHARSET=utf8; I refered below link; https://stackoverflow.com/questions/23671222/mysql-default-value-for-timestamp3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-pack] branch 0.5.x created (now 6ab3a53)
This is an automated email from the ASF dual-hosted git repository. asifdxtreme pushed a change to branch 0.5.x in repository https://gitbox.apache.org/repos/asf/servicecomb-pack.git. at 6ab3a53 Try to fix the Travis CI build error No new revisions were added by this update.
[GitHub] [servicecomb-java-chassis] jiaom commented on issue #1290: servicecomb-java-chassis mvn clean install -DskipTests失败
jiaom commented on issue #1290: servicecomb-java-chassis mvn clean install -DskipTests失败 URL: https://github.com/apache/servicecomb-java-chassis/issues/1290#issuecomment-523418892 就是master分支，为什么我看不到这个类呢？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] MabinGo commented on issue #21: SCB-1454 The modules tag is not generated in the pom file when using cli
MabinGo commented on issue #21: SCB-1454 The modules tag is not generated in the pom file when using cli URL: https://github.com/apache/servicecomb-toolkit/pull/21#issuecomment-523370515 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] MabinGo merged pull request #21: SCB-1454 The modules tag is not generated in the pom file when using cli
MabinGo merged pull request #21: SCB-1454 The modules tag is not generated in the pom file when using cli URL: https://github.com/apache/servicecomb-toolkit/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-toolkit] branch master updated: SCB-1454 The modules tag is not generated in the pom file when using cli
This is an automated email from the ASF dual-hosted git repository.
mabin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-toolkit.git
The following commit(s) were added to refs/heads/master by this push:
new 59e664f SCB-1454 The modules tag is not generated in the pom file
when using cli
new 9278c1a Merge pull request #21 from kakulisen/fix-cli-problem
59e664f is described below
commit 59e664f4cabe86062cb92b46fb71597fb8eb1345
Author: kakulisen <18813972...@163.com>
AuthorDate: Wed Aug 21 11:45:31 2019 +0800
SCB-1454 The modules tag is not generated in the pom file when using cli
Signed-off-by: kakulisen <18813972...@163.com>
---
.../org/apache/servicecomb/toolkit/codegen/ServiceCombCodegen.java | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
a/codegen/src/main/java/org/apache/servicecomb/toolkit/codegen/ServiceCombCodegen.java
b/codegen/src/main/java/org/apache/servicecomb/toolkit/codegen/ServiceCombCodegen.java
index 60a5d32..89ea343 100755
---
a/codegen/src/main/java/org/apache/servicecomb/toolkit/codegen/ServiceCombCodegen.java
+++
b/codegen/src/main/java/org/apache/servicecomb/toolkit/codegen/ServiceCombCodegen.java
@@ -119,6 +119,10 @@ public class ServiceCombCodegen extends
AbstractJavaCodegen implements CodegenCo
library.setEnum(supportedLibraries);
library.setDefault(DEFAULT_LIBRARY);
cliOptions.add(library);
+
+
additionalProperties.put(GeneratorExternalConfigConstant.PROVIDER_PROJECT_NAME,
providerProject);
+
additionalProperties.put(GeneratorExternalConfigConstant.CONSUMER_PROJECT_NAME,
consumerProject);
+
additionalProperties.put(GeneratorExternalConfigConstant.MODEL_PROJECT_NAME,
modelProject);
}
@Override
@@ -183,7 +187,7 @@ public class ServiceCombCodegen extends AbstractJavaCodegen
implements CodegenCo
}
additionalProperties.put("camelcase", new CamelCaseLambda());
additionalProperties.put("getGenericClassType", new
GetGenericClassTypeLambda());
-additionalProperties.put("getRelativeBasePath",new
GetRelativeBasePathLambda());
+additionalProperties.put("getRelativeBasePath", new
GetRelativeBasePathLambda());
additionalProperties.put("removeImplSuffix", new RemoveImplSuffixLambda());
additionalProperties.put("applicationId", applicationId);
[GitHub] [servicecomb-toolkit] MabinGo merged pull request #20: SCB-1452 update README
MabinGo merged pull request #20: SCB-1452 update README URL: https://github.com/apache/servicecomb-toolkit/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-toolkit] branch master updated: SCB-1452 update README
This is an automated email from the ASF dual-hosted git repository. mabin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-toolkit.git The following commit(s) were added to refs/heads/master by this push: new 47e4569 SCB-1452 update README new 21f1f9a Merge pull request #20 from kakulisen/update-readme 47e4569 is described below commit 47e4569cf58d4657b6b2de4719cfe4da5cdd6995 Author: kakulisen <18813972...@163.com> AuthorDate: Wed Aug 21 10:11:02 2019 +0800 SCB-1452 update README Signed-off-by: kakulisen <18813972...@163.com> --- README-ZH.md | 6 ++ README.md| 5 + 2 files changed, 11 insertions(+) diff --git a/README-ZH.md b/README-ZH.md index 3eadc62..f8e693e 100755 --- a/README-ZH.md +++ b/README-ZH.md @@ -163,6 +163,12 @@ mvn toolkit:verify mvn toolkit:generate ``` +代码生成契约现已支持以下注解(类级别)编写的restful接口 +>RestController, RestSchema, RpcSchema, RequestMapping + +代码生成契约时,restful接口方法修饰符必须指定为public + + 3.2.2.2 解析契约，生成微服务工程、文档 配置项(不显式设置 `` 则使用默认配置) diff --git a/README.md b/README.md index a2a4117..a7ea54e 100755 --- a/README.md +++ b/README.md @@ -162,6 +162,11 @@ Run in shell mvn toolkit:generate ``` +When generating contracts from code,support for identifying restful interfaces written by the following annotations (class level) +>RestController, RestSchema, RpcSchema, RequestMapping + +When generating contracts from code,the restful interface method access modifier must be specified as public + 3.2.2.2 Generate the microservice project and document from contract
[GitHub] [servicecomb-toolkit] MabinGo commented on issue #20: SCB-1452 update README
MabinGo commented on issue #20: SCB-1452 update README URL: https://github.com/apache/servicecomb-toolkit/pull/20#issuecomment-523367376 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
