[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #440: [WIP] [SCB-1223] Update the license Information
WillemJiang commented on a change in pull request #440: [WIP] [SCB-1223] Update the license Information URL: https://github.com/apache/servicecomb-pack/pull/440#discussion_r268978633 ## File path: distribution/src/release/LICENSE ## @@ -366,9 +366,6 @@ Spring Boot (http://projects.spring.io/spring-boot/) org.springframework.boot:sp Spring Boot AutoConfigure (http://projects.spring.io/spring-boot/) org.springframework.boot:spring-boot-autoconfigure:jar:2.1.1.REALEASE Spring Boot Logging Starter (http://projects.spring.io/spring-boot/) org.springframework.boot:spring-boot-starter-logging:jar:2.1.1.REALEASE Spring Boot Starter (http://projects.spring.io/spring-boot/) org.springframework.boot:spring-boot-starter:jar:2.1.1.REALEASE -Spring Boot Tomcat Starter (http://projects.spring.io/spring-boot/) org.springframework.boot:spring-boot-starter-tomcat:jar:1.5.14.REALEASE -Spring Cloud Starter Netflix (https://github.com/spring-cloud/spring-cloud-netflix) spring-cloud-starter-netflix-eureka-client:jar:2.1.1.RELEASE Review comment: I think we still need to use these two starter (Netflix and Consul) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #440: [WIP] [SCB-1223] Update the license Information
WillemJiang commented on a change in pull request #440: [WIP] [SCB-1223] Update the license Information URL: https://github.com/apache/servicecomb-pack/pull/440#discussion_r268978633 ## File path: distribution/src/release/LICENSE ## @@ -366,9 +366,6 @@ Spring Boot (http://projects.spring.io/spring-boot/) org.springframework.boot:sp Spring Boot AutoConfigure (http://projects.spring.io/spring-boot/) org.springframework.boot:spring-boot-autoconfigure:jar:2.1.1.REALEASE Spring Boot Logging Starter (http://projects.spring.io/spring-boot/) org.springframework.boot:spring-boot-starter-logging:jar:2.1.1.REALEASE Spring Boot Starter (http://projects.spring.io/spring-boot/) org.springframework.boot:spring-boot-starter:jar:2.1.1.REALEASE -Spring Boot Tomcat Starter (http://projects.spring.io/spring-boot/) org.springframework.boot:spring-boot-starter-tomcat:jar:1.5.14.REALEASE -Spring Cloud Starter Netflix (https://github.com/spring-cloud/spring-cloud-netflix) spring-cloud-starter-netflix-eureka-client:jar:2.1.1.RELEASE Review comment: I think we still need to use these two starter (Netflix and Consul) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
