[GitHub] wujimin commented on a change in pull request #713: [SCB-591] configcenter need to do encode

[GitBox]

wujimin commented on a change in pull request #713:  [SCB-591] configcenter 
need to do encode
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/713#discussion_r189149432
 
 

 ##
 File path: 
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
 ##
 @@ -329,8 +329,14 @@ private void sendHeartbeat(WebSocket ws) {
 
 public void refreshConfig(String configcenter, boolean wait) {
   CountDownLatch latch = new CountDownLatch(1);
+  String encodeServiceName = "";
+  try {
+encodeServiceName = 
URLEncoder.encode(StringUtils.deleteWhitespace(serviceName), "UTF-8");
+  } catch (UnsupportedEncodingException e) {
+LOGGER.error("encode error: {}",e.getMessage());
 
 Review comment:
   1.not format code
   2.failed but still continue?
   3."UTF-8" can changed to java.nio.charset.StandardCharsets.UTF_8.name()


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #713: [SCB-591] configcenter need to do encode

[GitBox]

wujimin commented on a change in pull request #713:  [SCB-591] configcenter 
need to do encode
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/713#discussion_r188969749
 
 

 ##
 File path: 
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
 ##
 @@ -329,8 +329,14 @@ private void sendHeartbeat(WebSocket ws) {
 
 public void refreshConfig(String configcenter, boolean wait) {
   CountDownLatch latch = new CountDownLatch(1);
+  String encodeServiceName = "";
+  try {
+encodeServiceName = URLEncoder.encode(serviceName, "UTF-8");
+  } catch (UnsupportedEncodingException e1) {
+e1.printStackTrace();
+  }
+  String path = URIConst.ITEMS + "?dimensionsInfo=" + 
StringUtils.deleteWhitespace(encodeServiceName);
 
 Review comment:
   delete whitespace before or after encode?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #713: [SCB-591] configcenter need to do encode

[GitBox]

wujimin commented on a change in pull request #713:  [SCB-591] configcenter 
need to do encode
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/713#discussion_r188969579
 
 

 ##
 File path: 
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
 ##
 @@ -329,8 +329,14 @@ private void sendHeartbeat(WebSocket ws) {
 
 public void refreshConfig(String configcenter, boolean wait) {
   CountDownLatch latch = new CountDownLatch(1);
+  String encodeServiceName = "";
+  try {
+encodeServiceName = URLEncoder.encode(serviceName, "UTF-8");
+  } catch (UnsupportedEncodingException e1) {
+e1.printStackTrace();
 
 Review comment:
   print?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services