This is an automated email from the ASF dual-hosted git repository. gurwls223 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new e7616dc9502 [SPARK-46276][PYTHON][TESTS] Improve test coverage of pyspark utils e7616dc9502 is described below commit e7616dc95021471b42e9dfcf2ef99b4e3f726e52 Author: Xinrong Meng <xinr...@apache.org> AuthorDate: Wed Dec 6 17:21:01 2023 +0900 [SPARK-46276][PYTHON][TESTS] Improve test coverage of pyspark utils ### What changes were proposed in this pull request? Improve test coverage of pyspark utils ### Why are the changes needed? Subtasks of [SPARK-46041](https://issues.apache.org/jira/browse/SPARK-46041) to improve test coverage ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Test changes only. ### Was this patch authored or co-authored using generative AI tooling? No Closes #44192 from xinrong-meng/improve_test_util. Authored-by: Xinrong Meng <xinr...@apache.org> Signed-off-by: Hyukjin Kwon <gurwls...@apache.org> --- python/pyspark/tests/test_util.py | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/python/pyspark/tests/test_util.py b/python/pyspark/tests/test_util.py index af104d683aa..ad0b106d229 100644 --- a/python/pyspark/tests/test_util.py +++ b/python/pyspark/tests/test_util.py @@ -20,6 +20,8 @@ import unittest from py4j.protocol import Py4JJavaError from pyspark import keyword_only +from pyspark.util import _parse_memory +from pyspark.loose_version import LooseVersion from pyspark.testing.utils import PySparkTestCase, eventually from pyspark.find_spark_home import _find_spark_home @@ -105,6 +107,23 @@ class UtilTests(PySparkTestCase): lambda: self.assertTrue(random.random() < 0.1) )() + def test_loose_version(self): + v1 = LooseVersion("1.2.3") + self.assertEqual(str(v1), "1.2.3") + self.assertEqual(repr(v1), "LooseVersion ('1.2.3')") + v2 = "1.2.3" + self.assertTrue(v1 == v2) + v3 = 1.1 + with self.assertRaises(TypeError): + v1 > v3 + v4 = LooseVersion("1.2.4") + self.assertTrue(v1 <= v4) + + def test_parse_memory(self): + self.assertEqual(_parse_memory("1g"), 1024) + with self.assertRaisesRegex(ValueError, "invalid format"): + _parse_memory("2gs") + if __name__ == "__main__": from pyspark.tests.test_util import * # noqa: F401 --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org